)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34041e8138c53a03d16b67c498614cbf486a9490","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-11-04 02:05:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add JSON schema validation to share-extend API"},{"line_number":8,"context_line":"Change-Id: 2b91a4339ee21cc05fbe25b0c80e770b2037082a"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ic4d9a8de0916c5dbde00452e20f502a3eceea842"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8e68c645_cf651822","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":51},"updated":"2024-11-07 22:23:40.000000000","message":"the change IDs are duplicated, but you should only have one of them. Could you please keep only one?","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5cb08b0bca438c5425c8d4e464ec417d6ce4f4f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-11-04 02:05:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add JSON schema validation to share-extend API"},{"line_number":8,"context_line":"Change-Id: 2b91a4339ee21cc05fbe25b0c80e770b2037082a"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ic4d9a8de0916c5dbde00452e20f502a3eceea842"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7b79bd70_b5d084f9","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":51},"in_reply_to":"8e68c645_cf651822","updated":"2025-09-02 12:21:21.000000000","message":"Done","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34041e8138c53a03d16b67c498614cbf486a9490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"20a1d891_c23e9158","updated":"2024-11-07 22:23:40.000000000","message":"Great job on this change, Youssef! Happy to see how far you\u0027ve got so far. Please take a look at my comments inline","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0da09c9afa58dd95ae9dfb68080b5e2a9001bf4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"706b08b5_7c31ce22","updated":"2025-12-05 19:01:02.000000000","message":"LGTM, thanks Stephen and Youssef","commit_id":"0ae5d257ab713c63181b8581f399a02a3ec0a3be"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"145531b95955abae99d4ff1e14a2b93ecafc5271","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fd8387c7_492532ef","updated":"2025-12-05 20:19:36.000000000","message":"Thank you Youssf and Stephen!","commit_id":"0ae5d257ab713c63181b8581f399a02a3ec0a3be"}],"manila/api/schemas/shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34041e8138c53a03d16b67c498614cbf486a9490","unresolved":true,"context_lines":[{"line_number":9,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\r"},{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations\r"},{"line_number":11,"context_line":"# under the License.\r"},{"line_number":12,"context_line":"\r"},{"line_number":13,"context_line":"import copy\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"from oslo_config import cfg\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"cdb918e0_4ccf8418","line":12,"updated":"2024-11-07 22:23:40.000000000","message":"I believe there is an issue with this file, and it is likely because it was created in windows and it has a different mode. Could you please attempt running dos2unix in this file? :)","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5cb08b0bca438c5425c8d4e464ec417d6ce4f4f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\r"},{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations\r"},{"line_number":11,"context_line":"# under the License.\r"},{"line_number":12,"context_line":"\r"},{"line_number":13,"context_line":"import copy\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"from oslo_config import cfg\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"982a35bc_fb2f8d83","line":12,"in_reply_to":"cdb918e0_4ccf8418","updated":"2025-09-02 12:21:21.000000000","message":"Done","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34041e8138c53a03d16b67c498614cbf486a9490","unresolved":true,"context_lines":[{"line_number":18,"context_line":"\r"},{"line_number":19,"context_line":"CONF \u003d cfg.CONF\r"},{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"extend_request_body \u003d {\r"},{"line_number":22,"context_line":"    \u0027type\u0027: \u0027object\u0027,\r"},{"line_number":23,"context_line":"    \u0027properties\u0027: {\r"},{"line_number":24,"context_line":"        \u0027os-extend\u0027: {\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9550686_94941c45","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":19},"updated":"2024-11-07 22:23:40.000000000","message":"```suggestion\nextend_request_body_v27 \u003d {\n```","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5cb08b0bca438c5425c8d4e464ec417d6ce4f4f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\r"},{"line_number":19,"context_line":"CONF \u003d cfg.CONF\r"},{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"extend_request_body \u003d {\r"},{"line_number":22,"context_line":"    \u0027type\u0027: \u0027object\u0027,\r"},{"line_number":23,"context_line":"    \u0027properties\u0027: {\r"},{"line_number":24,"context_line":"        \u0027os-extend\u0027: {\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"ae280d45_5e9a4ee6","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":19},"in_reply_to":"b9550686_94941c45","updated":"2025-09-02 12:21:21.000000000","message":"Done","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34041e8138c53a03d16b67c498614cbf486a9490","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a7d7cb6_270122b5","line":52,"updated":"2024-11-07 22:23:40.000000000","message":"even though the response might be null for all of these, I\u0027d recommend adding the validations for them as well... they would look like:\n\n```\nextend_response_body \u003d {\n    \u0027type\u0027: \u0027null\u0027,\n}\n```\nAnd then you can link them in the validation :)","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5cb08b0bca438c5425c8d4e464ec417d6ce4f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65587c32_4401e4dd","line":52,"in_reply_to":"0a7d7cb6_270122b5","updated":"2025-09-02 12:21:21.000000000","message":"Done","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"}],"manila/api/v2/shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34041e8138c53a03d16b67c498614cbf486a9490","unresolved":true,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027, \u00272.63\u0027)"},{"line_number":536,"context_line":"    @wsgi.action(\u0027extend\u0027)"},{"line_number":537,"context_line":"    @validation.request_body_schema(share_schema.extend_request_body_v27_to_v263)"},{"line_number":538,"context_line":"    def extend(self, req, id, body):"},{"line_number":539,"context_line":"        \"\"\"Extend size of a share.\"\"\""},{"line_number":540,"context_line":"        body.get(\u0027extend\u0027, {}).pop(\u0027force\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea9ee405_098070b1","line":537,"in_reply_to":"dcf9add4_c33cf5ca","updated":"2024-11-07 22:23:40.000000000","message":"\u003e pep8: E501 line too long (81 \u003e 79 characters)\n\nPlease fix.","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5cb08b0bca438c5425c8d4e464ec417d6ce4f4f","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027, \u00272.63\u0027)"},{"line_number":536,"context_line":"    @wsgi.action(\u0027extend\u0027)"},{"line_number":537,"context_line":"    @validation.request_body_schema(share_schema.extend_request_body_v27_to_v263)"},{"line_number":538,"context_line":"    def extend(self, req, id, body):"},{"line_number":539,"context_line":"        \"\"\"Extend size of a share.\"\"\""},{"line_number":540,"context_line":"        body.get(\u0027extend\u0027, {}).pop(\u0027force\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"71fe1e84_ce217bd7","line":537,"in_reply_to":"ea9ee405_098070b1","updated":"2025-09-02 12:21:21.000000000","message":"Done","commit_id":"eb8361b9b5555c7ecc5dfd1226517735b07c5b3a"}]}