)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"762ccc42b62f13cdbcef52850ba14b568022bd6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0bbab7a_5781e7dd","updated":"2024-10-09 20:50:14.000000000","message":"Thanks @rodrigo.barbieri@canonical.com; please feel free to address the comment inline; or it\u0027d be a follow up for @gawasthi2010@gmail.com","commit_id":"9f2740752ea8154a11ea97f24cb22f0bdd1edccc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2b4e4accf7750fc51d287c35dc0f8059dcd27b6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e127cb18_30b1c76f","updated":"2024-10-10 13:31:06.000000000","message":"LGTM, thank you ganso!","commit_id":"31c97211cbfab7d6fcc96ba92fbbc9aa988c167b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"99938b906cf0977ef621ebb4177f1e2be6da8765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea56c30c_8a048655","updated":"2024-10-14 19:10:10.000000000","message":"thank you for fixing up the unit tests!","commit_id":"31c97211cbfab7d6fcc96ba92fbbc9aa988c167b"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"762ccc42b62f13cdbcef52850ba14b568022bd6f","unresolved":true,"context_lines":[{"line_number":3028,"context_line":"            mock.call(\u0027kerberos-config-get\u0027, kerberos_config_get_args_lif1),"},{"line_number":3029,"context_line":"            mock.call(\u0027kerberos-config-get\u0027, kerberos_config_get_args_lif2),"},{"line_number":3030,"context_line":"        ])"},{"line_number":3031,"context_line":"        self.client.get_network_interfaces.assert_called_once()"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"    def test_is_kerberos_enabled_exception_return_false(self):"},{"line_number":3034,"context_line":"        self.client.features.add_feature(\u0027KERBEROS_VSERVER\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"65c27c22_d7b84c12","line":3031,"range":{"start_line":3031,"start_character":0,"end_line":3031,"end_character":63},"updated":"2024-10-09 20:50:14.000000000","message":"assert_called_once() must be replaced with assert_called_one_with() here, and in other tests so we assert the parameters used; since https://review.opendev.org/c/openstack/manila/+/926903, we call this with \n`protocols\u003d[\u0027NFS\u0027, \u0027CIFS\u0027]`","commit_id":"9f2740752ea8154a11ea97f24cb22f0bdd1edccc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1ea063f7eb0c8495ac0d315986346370bd42bef8","unresolved":true,"context_lines":[{"line_number":3028,"context_line":"            mock.call(\u0027kerberos-config-get\u0027, kerberos_config_get_args_lif1),"},{"line_number":3029,"context_line":"            mock.call(\u0027kerberos-config-get\u0027, kerberos_config_get_args_lif2),"},{"line_number":3030,"context_line":"        ])"},{"line_number":3031,"context_line":"        self.client.get_network_interfaces.assert_called_once()"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"    def test_is_kerberos_enabled_exception_return_false(self):"},{"line_number":3034,"context_line":"        self.client.features.add_feature(\u0027KERBEROS_VSERVER\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"01e10157_09ed9664","line":3031,"range":{"start_line":3031,"start_character":0,"end_line":3031,"end_character":63},"in_reply_to":"65c27c22_d7b84c12","updated":"2024-10-10 10:47:00.000000000","message":"I see, I copy-pasted it from the original test and didn\u0027t notice it was missing the _with(). THanks Goutham!","commit_id":"9f2740752ea8154a11ea97f24cb22f0bdd1edccc"}]}