)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"07a11e708226abcde3886d67287311e0e0752633","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Netapp] make deleted volume retention period configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The NetApp driver has now supports user configurable volume delete"},{"line_number":10,"context_line":"retention period (in hours). Also, the max value of share manager config"},{"line_number":11,"context_line":"option ``unused_share_server_cleanup_interval`` is updated to possible"},{"line_number":12,"context_line":"max value of retention period because if a share server gets deleted,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ec23c538_9424096e","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":34},"updated":"2024-12-18 11:12:46.000000000","message":"nit: now supports","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2306b96b39dc6c9db2a5e3c352e021e9401f60db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Netapp] make deleted volume retention period configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The NetApp driver has now supports user configurable volume delete"},{"line_number":10,"context_line":"retention period (in hours). Also, the max value of share manager config"},{"line_number":11,"context_line":"option ``unused_share_server_cleanup_interval`` is updated to possible"},{"line_number":12,"context_line":"max value of retention period because if a share server gets deleted,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"977c7dc1_080a02db","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":34},"in_reply_to":"ec23c538_9424096e","updated":"2024-12-18 12:59:03.000000000","message":"Done","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49c89ae0_4b328ab9","updated":"2024-11-21 09:41:09.000000000","message":"Thanks Kiran for working on this. I have few comments on this patch.","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"44610415f18de9ce5ec6dee6664bfed27a797b1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49377a61_8b0a2ee0","updated":"2024-11-06 12:17:34.000000000","message":"recheck","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced44c66da1a76ae60ba0b7e7316c324491f5d05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0c46e36_9e69fbca","updated":"2024-10-24 14:05:03.000000000","message":"recheck","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"bf8d7e82726906ac68a3da484ca705e6cc320d66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9a5aff3_80df7625","updated":"2024-11-26 15:17:07.000000000","message":"Thanks Kiran for fixing all the comments, I have added 2 more comments please fix those also.","commit_id":"9a893e21a200a9de2b66ad440a2df1d784d812a1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5d69b1a26bdbd67c879c3c279040c998623fee5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"85099b06_f6ccde47","updated":"2024-11-29 06:54:38.000000000","message":"I don\u0027t know much about netapp\u0027s driver interface, but from the logic of the code, there is no problem.","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c98fc1229557ff384383af2f78cce3819981cc0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7130d5c6_0e8996ce","updated":"2024-11-28 08:47:04.000000000","message":"Thanks kiran for incorporating all the review comments, changes looks good for me now.","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"cb562047ddaa8b922d0fd44df75021369219c9f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a92e2578_ad0268ca","updated":"2024-11-29 06:11:54.000000000","message":"haixin/goutham/Carlos,\ncan you please review ?","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"07a11e708226abcde3886d67287311e0e0752633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a4a7373_7a515b9c","updated":"2024-12-18 11:12:46.000000000","message":"thanks for working on this change. I am concerned about quotas in this case. If we are releasing the quotas in the storage but the share is going to remain in the share server for 12 hours, what if the deletion fails after the 12 hours? We would have a leftover share in that case, now? How can we handle this?","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2306b96b39dc6c9db2a5e3c352e021e9401f60db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d81d78ac_5b0b2639","in_reply_to":"2a4a7373_7a515b9c","updated":"2024-12-18 12:59:03.000000000","message":"The default value of 12 stand even today, because of which the volumes space is not released. So admin can config and reduce this value to 1/2 and get volumes space recovered quickly. Also, the value should not be max than share server cleanup interval because by then the volumes are must deleted (i.e. there are no leftover on backend)","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fd182ee3b20a158c8a2d787d656a16a793b03071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"065373a5_e0cbcdc2","in_reply_to":"d81d78ac_5b0b2639","updated":"2024-12-19 14:59:08.000000000","message":"Got it, thanks","commit_id":"6c8cf19b6daa713699051d03a3e9e9a483afe1f0"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ed427b448536c4c1d95bfcb187659b22de408c7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a8a2966e_29477064","updated":"2024-12-20 09:53:57.000000000","message":"Changes looks good, Caloss also given +2 so executing the merge workflow","commit_id":"998f9f24cfbb02a2782f77e4d968c3b6ae58f0f8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fd182ee3b20a158c8a2d787d656a16a793b03071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a09a952_6b84c9e1","updated":"2024-12-19 14:59:08.000000000","message":"LGTM, thank you!","commit_id":"998f9f24cfbb02a2782f77e4d968c3b6ae58f0f8"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":181,"context_line":"    @na_utils.trace"},{"line_number":182,"context_line":"    def create_vserver(self, vserver_name, root_volume_aggregate_name,"},{"line_number":183,"context_line":"                       root_volume_name, aggregate_names, ipspace_name,"},{"line_number":184,"context_line":"                       security_cert_expire_days, delete_retention_hours):"},{"line_number":185,"context_line":"        \"\"\"Creates new vserver and assigns aggregates.\"\"\""},{"line_number":186,"context_line":"        self._create_vserver("},{"line_number":187,"context_line":"            vserver_name, aggregate_names, ipspace_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"959affa5_e602508b","line":184,"range":{"start_line":184,"start_character":50,"end_line":184,"end_character":72},"updated":"2024-11-21 09:41:09.000000000","message":"change it to volume_delete_retention_hours. This value should be optional. It is not must that every customer will have this option in configuration file. So this option should be volume_delete_retention_hours\u003dNone.","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    @na_utils.trace"},{"line_number":182,"context_line":"    def create_vserver(self, vserver_name, root_volume_aggregate_name,"},{"line_number":183,"context_line":"                       root_volume_name, aggregate_names, ipspace_name,"},{"line_number":184,"context_line":"                       security_cert_expire_days, delete_retention_hours):"},{"line_number":185,"context_line":"        \"\"\"Creates new vserver and assigns aggregates.\"\"\""},{"line_number":186,"context_line":"        self._create_vserver("},{"line_number":187,"context_line":"            vserver_name, aggregate_names, ipspace_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"70c443ff_e44e71d1","line":184,"range":{"start_line":184,"start_character":50,"end_line":184,"end_character":72},"in_reply_to":"959affa5_e602508b","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @na_utils.trace"},{"line_number":196,"context_line":"    def create_vserver_dp_destination(self, vserver_name, aggregate_names,"},{"line_number":197,"context_line":"                                      ipspace_name, delete_retention_hours):"},{"line_number":198,"context_line":"        \"\"\"Creates new \u0027dp_destination\u0027 vserver and assigns aggregates.\"\"\""},{"line_number":199,"context_line":"        self._create_vserver("},{"line_number":200,"context_line":"            vserver_name, aggregate_names, ipspace_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"34cce004_24820b66","line":197,"range":{"start_line":197,"start_character":52,"end_line":197,"end_character":74},"updated":"2024-11-21 09:41:09.000000000","message":"change the variable name as suggested and this should be also optional. Same as above comment","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @na_utils.trace"},{"line_number":196,"context_line":"    def create_vserver_dp_destination(self, vserver_name, aggregate_names,"},{"line_number":197,"context_line":"                                      ipspace_name, delete_retention_hours):"},{"line_number":198,"context_line":"        \"\"\"Creates new \u0027dp_destination\u0027 vserver and assigns aggregates.\"\"\""},{"line_number":199,"context_line":"        self._create_vserver("},{"line_number":200,"context_line":"            vserver_name, aggregate_names, ipspace_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd5eb6fd_d0de713b","line":197,"range":{"start_line":197,"start_character":52,"end_line":197,"end_character":74},"in_reply_to":"34cce004_24820b66","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @na_utils.trace"},{"line_number":204,"context_line":"    def _create_vserver(self, vserver_name, aggregate_names, ipspace_name,"},{"line_number":205,"context_line":"                        delete_retention_hours,"},{"line_number":206,"context_line":"                        root_volume_name\u003dNone, root_volume_aggregate_name\u003dNone,"},{"line_number":207,"context_line":"                        root_volume_security_style\u003dNone,"},{"line_number":208,"context_line":"                        name_server_switch\u003dNone, subtype\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"054a20f7_b840ede7","line":205,"range":{"start_line":205,"start_character":24,"end_line":205,"end_character":46},"updated":"2024-11-21 09:41:09.000000000","message":"This should be volume_delete_retention_hours\u003dNone","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @na_utils.trace"},{"line_number":204,"context_line":"    def _create_vserver(self, vserver_name, aggregate_names, ipspace_name,"},{"line_number":205,"context_line":"                        delete_retention_hours,"},{"line_number":206,"context_line":"                        root_volume_name\u003dNone, root_volume_aggregate_name\u003dNone,"},{"line_number":207,"context_line":"                        root_volume_security_style\u003dNone,"},{"line_number":208,"context_line":"                        name_server_switch\u003dNone, subtype\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"43728f06_92897c08","line":205,"range":{"start_line":205,"start_character":24,"end_line":205,"end_character":46},"in_reply_to":"054a20f7_b840ede7","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":237,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":238,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":"        if delete_retention_hours !\u003d 0:"},{"line_number":241,"context_line":"            modify_args.update("},{"line_number":242,"context_line":"                {\u0027volume-delete-retention-hours\u0027: delete_retention_hours})"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"27470b5d_ca26e7aa","line":240,"range":{"start_line":240,"start_character":11,"end_line":240,"end_character":33},"updated":"2024-11-21 09:41:09.000000000","message":"I think we should accept the zero here. According to me below condition will be fine \n\nif volume_delete_retention_hours is not None:","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":238,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":"        if delete_retention_hours !\u003d 0:"},{"line_number":241,"context_line":"            modify_args.update("},{"line_number":242,"context_line":"                {\u0027volume-delete-retention-hours\u0027: delete_retention_hours})"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"14d1b8fb_a149facd","line":240,"range":{"start_line":240,"start_character":11,"end_line":240,"end_character":33},"in_reply_to":"27470b5d_ca26e7aa","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"bf8d7e82726906ac68a3da484ca705e6cc320d66","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":241,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"        if volume_delete_retention_hours:"},{"line_number":244,"context_line":"            modify_args.update("},{"line_number":245,"context_line":"                {\u0027volume-delete-retention-hours\u0027: ("},{"line_number":246,"context_line":"                    volume_delete_retention_hours)})"}],"source_content_type":"text/x-python","patch_set":3,"id":"aefb1c08_2505c85f","line":243,"updated":"2024-11-26 15:17:07.000000000","message":"\"volume-delete-retention-hours\" is added from ONTAP 9.11.1, could you please add one more condition to make sure ONTAP cluster version should be \u003e\u003d 9.11.1. This need to add only ZAPI.","commit_id":"9a893e21a200a9de2b66ad440a2df1d784d812a1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1db69380b0688cdf7c2cbbf7ab37589ea897cd53","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":241,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"        if volume_delete_retention_hours:"},{"line_number":244,"context_line":"            modify_args.update("},{"line_number":245,"context_line":"                {\u0027volume-delete-retention-hours\u0027: ("},{"line_number":246,"context_line":"                    volume_delete_retention_hours)})"}],"source_content_type":"text/x-python","patch_set":3,"id":"e335e5e2_e6b40912","line":243,"in_reply_to":"aefb1c08_2505c85f","updated":"2024-11-26 17:29:13.000000000","message":"Done","commit_id":"9a893e21a200a9de2b66ad440a2df1d784d812a1"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":4347,"context_line":"    @na_utils.trace"},{"line_number":4348,"context_line":"    def create_vserver(self, vserver_name, root_volume_aggregate_name,"},{"line_number":4349,"context_line":"                       root_volume_name, aggregate_names, ipspace_name,"},{"line_number":4350,"context_line":"                       security_cert_expire_days, delete_retention_hours):"},{"line_number":4351,"context_line":"        \"\"\"Creates new vserver and assigns aggregates.\"\"\""},{"line_number":4352,"context_line":""},{"line_number":4353,"context_line":"        # NOTE(nahimsouza): root_volume_aggregate_name and root_volume_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9574c02_f068389d","line":4350,"range":{"start_line":4350,"start_character":50,"end_line":4350,"end_character":72},"updated":"2024-11-21 09:41:09.000000000","message":"What ever comments are provided for Cmode lib all are applicable for this lib also. Requested you to make the same changes here.","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":4347,"context_line":"    @na_utils.trace"},{"line_number":4348,"context_line":"    def create_vserver(self, vserver_name, root_volume_aggregate_name,"},{"line_number":4349,"context_line":"                       root_volume_name, aggregate_names, ipspace_name,"},{"line_number":4350,"context_line":"                       security_cert_expire_days, delete_retention_hours):"},{"line_number":4351,"context_line":"        \"\"\"Creates new vserver and assigns aggregates.\"\"\""},{"line_number":4352,"context_line":""},{"line_number":4353,"context_line":"        # NOTE(nahimsouza): root_volume_aggregate_name and root_volume_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"a94cfb6e_dd7b5578","line":4350,"range":{"start_line":4350,"start_character":50,"end_line":4350,"end_character":72},"in_reply_to":"c9574c02_f068389d","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":334,"context_line":"                vserver_name,"},{"line_number":335,"context_line":"                aggregate_names,"},{"line_number":336,"context_line":"                ipspace_name,"},{"line_number":337,"context_line":"                self.configuration.netapp_delete_retention_hours)"},{"line_number":338,"context_line":"            # Set up port and broadcast domain for the current ipspace"},{"line_number":339,"context_line":"            self._create_port_and_broadcast_domain("},{"line_number":340,"context_line":"                ipspace_name, network_info[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"df018835_9c08f91e","line":337,"range":{"start_line":337,"start_character":16,"end_line":337,"end_character":65},"updated":"2024-11-21 09:41:09.000000000","message":"better to use the \"self.configuration.safe_get(..\" for safer side.","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                vserver_name,"},{"line_number":335,"context_line":"                aggregate_names,"},{"line_number":336,"context_line":"                ipspace_name,"},{"line_number":337,"context_line":"                self.configuration.netapp_delete_retention_hours)"},{"line_number":338,"context_line":"            # Set up port and broadcast domain for the current ipspace"},{"line_number":339,"context_line":"            self._create_port_and_broadcast_domain("},{"line_number":340,"context_line":"                ipspace_name, network_info[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"6db8348a_c281634a","line":337,"range":{"start_line":337,"start_character":16,"end_line":337,"end_character":65},"in_reply_to":"df018835_9c08f91e","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":349,"context_line":"                aggr_set,"},{"line_number":350,"context_line":"                ipspace_name,"},{"line_number":351,"context_line":"                self.configuration.netapp_security_cert_expire_days,"},{"line_number":352,"context_line":"                self.configuration.netapp_delete_retention_hours)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"            vserver_client \u003d self._get_api_client(vserver\u003dvserver_name)"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"495bd484_097c598a","line":352,"range":{"start_line":352,"start_character":16,"end_line":352,"end_character":64},"updated":"2024-11-21 09:41:09.000000000","message":"better to use the \"self.configuration.safe_get(..\"","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                aggr_set,"},{"line_number":350,"context_line":"                ipspace_name,"},{"line_number":351,"context_line":"                self.configuration.netapp_security_cert_expire_days,"},{"line_number":352,"context_line":"                self.configuration.netapp_delete_retention_hours)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"            vserver_client \u003d self._get_api_client(vserver\u003dvserver_name)"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"187d06ba_f0ea7728","line":352,"range":{"start_line":352,"start_character":16,"end_line":352,"end_character":64},"in_reply_to":"495bd484_097c598a","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"19d4d54bf55f4c3c65080fe8e9ac7008818f2a07","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    cfg.StrOpt(\u0027netapp_root_volume\u0027,"},{"line_number":108,"context_line":"               default\u003d\u0027root\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027Root volume name.\u0027),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027netapp_delete_retention_hours\u0027,"},{"line_number":111,"context_line":"               min\u003d0,"},{"line_number":112,"context_line":"               default\u003d12,"},{"line_number":113,"context_line":"               help\u003d\u0027The number of hours that a deleted volume should be \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"237c5176_a3e431d1","line":110,"range":{"start_line":110,"start_character":16,"end_line":110,"end_character":45},"updated":"2024-11-21 09:41:09.000000000","message":"Change it to \"netapp_volume_delete_retention_hours\"","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a37b5245ca5e390c3aecb70439efcc20b4f9adce","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    cfg.StrOpt(\u0027netapp_root_volume\u0027,"},{"line_number":108,"context_line":"               default\u003d\u0027root\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027Root volume name.\u0027),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027netapp_delete_retention_hours\u0027,"},{"line_number":111,"context_line":"               min\u003d0,"},{"line_number":112,"context_line":"               default\u003d12,"},{"line_number":113,"context_line":"               help\u003d\u0027The number of hours that a deleted volume should be \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"91ba3d8c_cdbfab63","line":110,"range":{"start_line":110,"start_character":16,"end_line":110,"end_character":45},"in_reply_to":"237c5176_a3e431d1","updated":"2024-11-21 10:42:53.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"}],"releasenotes/notes/bug-2085112-netapp-make-deleted-volumes-retention-period-configurable-403ec227f256e24b.yaml":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"bf8d7e82726906ac68a3da484ca705e6cc320d66","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The NetApp driver now supports user configurable volume delete retention"},{"line_number":5,"context_line":"    period i.e. ``netapp_delete_retention_hours``. The max value of config"},{"line_number":6,"context_line":"    option ``unused_share_server_cleanup_interval`` is updated to possible"},{"line_number":7,"context_line":"    max value of retention period because if a share server gets deleted, the"},{"line_number":8,"context_line":"    volume recovery queue also gets purged. For more details, please check"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"43081c1b_65120417","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":47},"updated":"2024-11-26 15:17:07.000000000","message":"Change here also \"netapp_volume_delete_retention_hours\"","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1db69380b0688cdf7c2cbbf7ab37589ea897cd53","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The NetApp driver now supports user configurable volume delete retention"},{"line_number":5,"context_line":"    period i.e. ``netapp_delete_retention_hours``. The max value of config"},{"line_number":6,"context_line":"    option ``unused_share_server_cleanup_interval`` is updated to possible"},{"line_number":7,"context_line":"    max value of retention period because if a share server gets deleted, the"},{"line_number":8,"context_line":"    volume recovery queue also gets purged. For more details, please check"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bda911fa_2094116c","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":47},"in_reply_to":"43081c1b_65120417","updated":"2024-11-26 17:29:13.000000000","message":"Done","commit_id":"0ac291b9104abaf51442a64c0fbe848a357e035c"}]}