)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b7935076b21de074fa2370670d790b47f081dbaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f06bf9b9_9b989cfb","updated":"2024-11-11 08:38:53.000000000","message":"If manila interconnects with two backends at the same time, one supports this feature and the other does not. Then this configuration is global and it is difficult to control.\n\nI recommend making it a backend capability like \u0027create_share_from_snapshot_support\u0027 and matching your backend against share.host. The system automatically determines whether migration with replicas is supported.","commit_id":"81d965947db3bf086cf02b966ccd6fb75c66321f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e09f611bbfb29007f9fdc7a4081e1237099d90d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3994cec8_8a426d0d","updated":"2024-11-01 08:52:08.000000000","message":"recheck","commit_id":"81d965947db3bf086cf02b966ccd6fb75c66321f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"770ad3a7f47ef1d70ad496fb4bd08224dd6a484a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69cb3b83_ce1d43f2","updated":"2024-11-04 11:27:08.000000000","message":"recheck","commit_id":"81d965947db3bf086cf02b966ccd6fb75c66321f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ed52e7851f03e738f11a83962a19e9d669bb3dc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0fed027_2f899014","updated":"2024-11-06 12:17:26.000000000","message":"recheck","commit_id":"81d965947db3bf086cf02b966ccd6fb75c66321f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f0e09846c431ad759d97ea274d71ac1efca0a468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd55d4c3_a7551eb8","in_reply_to":"4841115c_0baa4f7b","updated":"2024-11-14 17:25:29.000000000","message":"The driver capability is good for making scheduling decisions; but, in addition, please store this capability as a property in the share server so you don\u0027t have to make an RPC call to the backend to figure out whether or not something is supported","commit_id":"81d965947db3bf086cf02b966ccd6fb75c66321f"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"13a51ac836b17a7a941397fa588319e03e946ffb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4841115c_0baa4f7b","in_reply_to":"df435298_a69032dd","updated":"2024-11-12 09:52:30.000000000","message":"yes, that is what i mean, i will review the code later. thanks.","commit_id":"81d965947db3bf086cf02b966ccd6fb75c66321f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"20cc13cf67faca106d8bfa047803de57e87b5014","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df435298_a69032dd","in_reply_to":"f06bf9b9_9b989cfb","updated":"2024-11-11 14:42:30.000000000","message":"You mean adding driver capability and using that during migration check in API layer. I have updated code, let me know wdyt.","commit_id":"81d965947db3bf086cf02b966ccd6fb75c66321f"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d3045b666449b774933d0f48167c51a99944017f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f70a92d_e0cec9ec","updated":"2024-11-13 06:51:03.000000000","message":"hi, Kiran Pawar, thanks for your change.","commit_id":"d3fc46a3e210e18802a1c73ce8034459e9c62dca"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"28ed237f7af69937d87e3c5bc7bca82c3eef8816","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b514a998_acc255f6","updated":"2024-11-14 00:58:24.000000000","message":"another comment, please check, thanks Kiran Pawar.","commit_id":"974110e658c95d605b90a692ecfbfbfe1cbeed98"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"aef9f26f21a67ce080957838b514719a4953a2e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c1e2cb2_94698095","updated":"2024-11-14 08:33:10.000000000","message":"LGTM, thanks for your change.","commit_id":"ea81c269a32744912ffeb166e436170065d1669f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f0e09846c431ad759d97ea274d71ac1efca0a468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"56b3a699_cf6e1121","updated":"2024-11-14 17:25:29.000000000","message":"I agree with Haixin\u0027s comments; but do not think this RPC interaction is necessary for static information like this. Please see my comments inline","commit_id":"babb8340ed9309a3f485cb96ebeebcb0df7abb30"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8ad35ecb87eaa69b6521e27a2c2b5880ec635029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b3b1b655_cfc5afec","updated":"2024-11-15 16:24:35.000000000","message":"recheck","commit_id":"02eb7c30c799c67ad5eb3cf238d97e5aa26663e5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8d3c1ff7d96d7de1aa760b2403d6d7316967e0b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1fe5e67a_4429fdf8","updated":"2024-11-18 10:48:00.000000000","message":"recheck","commit_id":"7d7eab03c42959f065d8c7384f8012cb0f3809dc"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"51dc8ac856c24328b775ac03423313b3885e8158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f064cbcf_341fe57d","updated":"2024-11-19 17:42:02.000000000","message":"As we have done db changes so we have to change the api version also. So according to me we have to make the changes in \"manila/api/openstack/api_version_request.py\" and \"manila/api/openstack/rest_api_version_history.rst\" file.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"88850a799ed98f23ff55ff9951c48e9c906b26bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2d9ee6ba_cc026a92","updated":"2024-11-19 14:39:19.000000000","message":"Can you have 2 separate patches one for core and one for driver. Driver should have only NetApp driver code. Other can also comment on this, if I am wrong here.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0725f0657530deb476329e620348f6fbbd07e98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5c456b50_edb8a9ad","updated":"2024-11-21 08:16:20.000000000","message":"code looks good, only one comment.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"071ab7da52d1454e50dc6ae49cbf95aa6381f8d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6152885e_c2204320","updated":"2024-11-21 07:05:00.000000000","message":"kiran, I have couple of questions. Could you please reply those.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"eae2e7af32dfd3da397ba6f67b335a8be514e433","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fec1c34a_4cd008c2","in_reply_to":"2d9ee6ba_cc026a92","updated":"2024-11-19 14:43:11.000000000","message":"Netapp driver is the one which support this feature and since driver specific changes are very small, no need to have separate patch I believe.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7948dcb69ba54547a497926199a5c1b61f316b8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"153528de_afea1600","in_reply_to":"3bd72592_8d624b8e","updated":"2024-11-21 23:37:17.000000000","message":"Hi Kiran: for the future, i think Gireesh has a valid request here.. it may sound pedantic, but, \n\nvendor driver patches must be submitted separately. Doing this provides a clean separation that allows reviewers to pay attention to the core code changes and avoid the question: \"what is the issue you solving here?\"\n\nwe\u0027re a small review team and we may let it slide for now.. but next time, i\u0027ll insist","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f098a59d72f4b8a6f54eefd377c74c112e117bbb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ca467df9_3f3a4c71","in_reply_to":"6152885e_c2204320","updated":"2024-11-21 12:50:13.000000000","message":"replied. If you have other please raise in reply else mark this comment as resolved.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8aa53ab4f76988958cbb71f5cbf6f79faad37510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3bd72592_8d624b8e","in_reply_to":"6b5bcf63_2402f932","updated":"2024-11-21 07:10:03.000000000","message":"yes, during share server creation we get True/False based on driver defined value.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ec82809b05816804472ed9ebf5badc2481d1d2b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6b5bcf63_2402f932","in_reply_to":"778a1e7a_2df15e64","updated":"2024-11-19 17:39:48.000000000","message":"So, we are added \"share_replicas_migration_support\" new field for share server, default value of this is \"False\", where we are updating this field value ..?\nSo while share server creation we should update the value of \"share_replicas_migration_support\" field, right ..?","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"717f43f647582eabb67f658b338b7107bbe4f8fd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"dd9e6109_ab48e4d8","in_reply_to":"ca467df9_3f3a4c71","updated":"2024-11-26 15:24:34.000000000","message":"Thanks kiran for your response","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"2209570c80360500182af68713cf89d644616789","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"778a1e7a_2df15e64","in_reply_to":"cdbafb8e_a3c89c88","updated":"2024-11-19 16:04:43.000000000","message":"thanks Kiran got it","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ebd06beee7d49f8dfdeeef0699a6720c7fa46847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"957c0cd4_f8e2a9c5","in_reply_to":"dd9e6109_ab48e4d8","updated":"2024-11-26 15:25:03.000000000","message":"marking this to resolved","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8aa53ab4f76988958cbb71f5cbf6f79faad37510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"901cc496_ea83fbc5","in_reply_to":"f064cbcf_341fe57d","updated":"2024-11-21 07:10:03.000000000","message":"No API changes needed.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"8ba7eb39d923002f7f68d712ef659fa07e3c4900","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cdbafb8e_a3c89c88","in_reply_to":"fa76a98b_8d4c3794","updated":"2024-11-19 16:03:33.000000000","message":"I mean if share server has \"share_replicas_migration_support\" set as false and share has replica then we will make it failed otherwise we will allow this. right ..?","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ab34d1bf1e74e7cc92895a2f5e65db91f365cf0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3536fe5d_7000a83d","in_reply_to":"fa76a98b_8d4c3794","updated":"2024-11-19 16:00:31.000000000","message":"yes.","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"0e040f0e8725f288c7060ed610e8802d31f284a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fa76a98b_8d4c3794","in_reply_to":"fec1c34a_4cd008c2","updated":"2024-11-19 15:55:55.000000000","message":"ok, thanks for this. Just wanted to understand what is issue you are solving here ..? \n\nif share has replica we will not allow it to migrate and failed the migration at api layer, right ..?","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7948dcb69ba54547a497926199a5c1b61f316b8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"831ce0bc_98afa68a","updated":"2024-11-21 23:37:17.000000000","message":"I still think this warrants a tempest test that can be executed on NetApp CI..","commit_id":"c9fa6f939c8f3ad5a0add3ed92499b394b1330c8"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"382ace17be7e15b70772e7e6021acbd7ab61040f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"264a0ad9_bf796946","updated":"2024-11-22 01:22:15.000000000","message":"LGTM,thanks. i think we can merge this.","commit_id":"c9fa6f939c8f3ad5a0add3ed92499b394b1330c8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"961b5c46d40fe320cbef83ffcc8f08530762c0f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cd64dbb9_fa40f8e4","updated":"2024-11-22 05:46:43.000000000","message":"recheck","commit_id":"c9fa6f939c8f3ad5a0add3ed92499b394b1330c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a2b0c62afccdbaeb41bcdf45f58417fb82fba0c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a19f8e3e_a6440e79","updated":"2024-11-27 16:23:13.000000000","message":"recheck\nDepends-on change is merged now","commit_id":"c9fa6f939c8f3ad5a0add3ed92499b394b1330c8"}],"manila/db/migrations/alembic/versions/0d8c8f6d54a4_modify_share_servers_table.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c8452d6bb12e99e6953b2c94e8829b1b28299c6","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    try:"},{"line_number":37,"context_line":"        op.add_column("},{"line_number":38,"context_line":"            SHARE_SERVERS_TABLE,"},{"line_number":39,"context_line":"            sa.Column(\u0027allow_migration_with_replicas\u0027, sa.Boolean,"},{"line_number":40,"context_line":"                      nullable\u003dFalse, server_default\u003dsa.sql.false()))"},{"line_number":41,"context_line":"    except Exception:"},{"line_number":42,"context_line":"        LOG.error(\"Table %s could not add column \""}],"source_content_type":"text/x-python","patch_set":9,"id":"2599ca6f_ea9e6c0f","line":39,"range":{"start_line":39,"start_character":23,"end_line":39,"end_character":52},"updated":"2024-11-18 22:26:00.000000000","message":"\"share_replicas_migration_support\" perhaps to be consistent with the existing boolean properties: security_service_update_support and network_allocation_update_support","commit_id":"2ab05ed2ecab938eaf1cfdc42f064d5ed04fd999"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6a216d58c5872ff94c7443b5e52d7c336f650ce6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    try:"},{"line_number":37,"context_line":"        op.add_column("},{"line_number":38,"context_line":"            SHARE_SERVERS_TABLE,"},{"line_number":39,"context_line":"            sa.Column(\u0027allow_migration_with_replicas\u0027, sa.Boolean,"},{"line_number":40,"context_line":"                      nullable\u003dFalse, server_default\u003dsa.sql.false()))"},{"line_number":41,"context_line":"    except Exception:"},{"line_number":42,"context_line":"        LOG.error(\"Table %s could not add column \""}],"source_content_type":"text/x-python","patch_set":9,"id":"535bfd70_fc6b0c2c","line":39,"range":{"start_line":39,"start_character":23,"end_line":39,"end_character":52},"in_reply_to":"2599ca6f_ea9e6c0f","updated":"2024-11-19 06:53:10.000000000","message":"Done","commit_id":"2ab05ed2ecab938eaf1cfdc42f064d5ed04fd999"}],"manila/scheduler/host_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c8452d6bb12e99e6953b2c94e8829b1b28299c6","unresolved":true,"context_lines":[{"line_number":366,"context_line":"            pool_cap[\u0027share_server_multiple_subnet_support\u0027] \u003d ("},{"line_number":367,"context_line":"                self.share_server_multiple_subnet_support)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        if \u0027allow_share_server_migration_with_replicas\u0027 not in pool_cap:"},{"line_number":370,"context_line":"            pool_cap[\u0027allow_share_server_migration_with_replicas\u0027] \u003d ("},{"line_number":371,"context_line":"                self.allow_share_server_migration_with_replicas)"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fb4d4d6a_6d54b1a7","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":54},"updated":"2024-11-18 22:26:00.000000000","message":"use the same name as the property you\u0027re adding to the ShareServer database model","commit_id":"2ab05ed2ecab938eaf1cfdc42f064d5ed04fd999"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6a216d58c5872ff94c7443b5e52d7c336f650ce6","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            pool_cap[\u0027share_server_multiple_subnet_support\u0027] \u003d ("},{"line_number":367,"context_line":"                self.share_server_multiple_subnet_support)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        if \u0027allow_share_server_migration_with_replicas\u0027 not in pool_cap:"},{"line_number":370,"context_line":"            pool_cap[\u0027allow_share_server_migration_with_replicas\u0027] \u003d ("},{"line_number":371,"context_line":"                self.allow_share_server_migration_with_replicas)"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"c8b6819d_3c9c3593","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":54},"in_reply_to":"fb4d4d6a_6d54b1a7","updated":"2024-11-19 06:53:10.000000000","message":"Done","commit_id":"2ab05ed2ecab938eaf1cfdc42f064d5ed04fd999"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f0e09846c431ad759d97ea274d71ac1efca0a468","unresolved":true,"context_lines":[{"line_number":3014,"context_line":"                    \u0027networks. Share server migration will not proceed.\u0027)"},{"line_number":3015,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":3016,"context_line":""},{"line_number":3017,"context_line":"        allow_migration_with_replicas \u003d ("},{"line_number":3018,"context_line":"            self.share_rpcapi.is_allow_migration_with_replicas("},{"line_number":3019,"context_line":"                context, share_server, dest_host))"},{"line_number":3020,"context_line":""},{"line_number":3021,"context_line":"        filters \u003d {\u0027source_share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":3022,"context_line":"                   \u0027status\u0027: constants.STATUS_SERVER_MIGRATING_TO}"}],"source_content_type":"text/x-python","patch_set":6,"id":"969ef0f6_56a530b2","line":3019,"range":{"start_line":3017,"start_character":8,"end_line":3019,"end_character":50},"updated":"2024-11-14 17:25:29.000000000","message":"I see that you\u0027re plumbing a boolean via pool stats that drivers report. If this information is always known, what\u0027s the point of an RPC call?\n\nIf you recall, our preference is to not mix up RPC casts and calls within the context of a REST API. Any communication over RPC will be indeterministic - we rely on the listener on the other side actively able to respond within user-configurable timeouts, and ttls... This use case doesn\u0027t seem to warrant it.\n\nIf its static information, you can find some other way to surface it; maybe allow the driver to set a property on the share server as it creates it. See \"security_group_update_support\" or \"network_allocation_update_support\" properties on the share server: https://github.com/openstack/manila/blob/faec042d066489d8f6c9f8468c97b829ed8711fe/manila/db/sqlalchemy/models.py#L1119","commit_id":"babb8340ed9309a3f485cb96ebeebcb0df7abb30"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5be12e65de437a2a11d9666e75d1c9dacef60e12","unresolved":false,"context_lines":[{"line_number":3014,"context_line":"                    \u0027networks. Share server migration will not proceed.\u0027)"},{"line_number":3015,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":3016,"context_line":""},{"line_number":3017,"context_line":"        allow_migration_with_replicas \u003d ("},{"line_number":3018,"context_line":"            self.share_rpcapi.is_allow_migration_with_replicas("},{"line_number":3019,"context_line":"                context, share_server, dest_host))"},{"line_number":3020,"context_line":""},{"line_number":3021,"context_line":"        filters \u003d {\u0027source_share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":3022,"context_line":"                   \u0027status\u0027: constants.STATUS_SERVER_MIGRATING_TO}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5cdf30d2_1e21027a","line":3019,"range":{"start_line":3017,"start_character":8,"end_line":3019,"end_character":50},"in_reply_to":"969ef0f6_56a530b2","updated":"2024-11-15 10:22:32.000000000","message":"removed RPC, added new property and set it via share backend information similar to above mentioned examples.","commit_id":"babb8340ed9309a3f485cb96ebeebcb0df7abb30"}],"manila/share/driver.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d3045b666449b774933d0f48167c51a99944017f","unresolved":true,"context_lines":[{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        self.add_ip_version_capability(common)"},{"line_number":1379,"context_line":"        self._stats \u003d common"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"    def get_share_server_pools(self, share_server):"},{"line_number":1382,"context_line":"        \"\"\"Return list of pools related to a particular share server."},{"line_number":1383,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4a74b0b4_1e9bbc9a","line":1380,"updated":"2024-11-13 06:51:03.000000000","message":"add new function:\n\n    def allow_share_server_migration_with_replicas(self):\n        \"\"\"Return True if driver supports share server migration with replicas.\n        \"\"\"\n        return self._stats[\u0027allow_share_server_migration_with_replicas\u0027]","commit_id":"d3fc46a3e210e18802a1c73ce8034459e9c62dca"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"cb7d7feabc9e3c068fd3546eb412b94ee28fa54d","unresolved":false,"context_lines":[{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        self.add_ip_version_capability(common)"},{"line_number":1379,"context_line":"        self._stats \u003d common"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"    def get_share_server_pools(self, share_server):"},{"line_number":1382,"context_line":"        \"\"\"Return list of pools related to a particular share server."},{"line_number":1383,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"97eb6f57_e22e912a","line":1380,"in_reply_to":"4a74b0b4_1e9bbc9a","updated":"2024-11-13 08:41:20.000000000","message":"done","commit_id":"d3fc46a3e210e18802a1c73ce8034459e9c62dca"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c8452d6bb12e99e6953b2c94e8829b1b28299c6","unresolved":true,"context_lines":[{"line_number":571,"context_line":"            \u0027security_service_update_support\u0027: True,"},{"line_number":572,"context_line":"            \u0027share_server_multiple_subnet_support\u0027: True,"},{"line_number":573,"context_line":"            \u0027mount_point_name_support\u0027: True,"},{"line_number":574,"context_line":"            \u0027allow_share_server_migration_with_replicas\u0027: True,"},{"line_number":575,"context_line":"        }"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        # Add storage service catalog data."}],"source_content_type":"text/x-python","patch_set":9,"id":"277b809f_744b387b","line":574,"range":{"start_line":574,"start_character":0,"end_line":574,"end_character":63},"updated":"2024-11-18 22:26:00.000000000","message":"Have you tested that this works without any code changes in the driver? The NetApp CI has been broken for a while, and even if it did, there\u0027s no test that exercises this scenario with Manila Tempest Plugin..\n\nMaybe add a small happy-path test, and if you\u0027re able to, run this with the NetApp driver.. we can tag some NetApp maintainers to help out with the testing","commit_id":"2ab05ed2ecab938eaf1cfdc42f064d5ed04fd999"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6a216d58c5872ff94c7443b5e52d7c336f650ce6","unresolved":true,"context_lines":[{"line_number":571,"context_line":"            \u0027security_service_update_support\u0027: True,"},{"line_number":572,"context_line":"            \u0027share_server_multiple_subnet_support\u0027: True,"},{"line_number":573,"context_line":"            \u0027mount_point_name_support\u0027: True,"},{"line_number":574,"context_line":"            \u0027allow_share_server_migration_with_replicas\u0027: True,"},{"line_number":575,"context_line":"        }"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        # Add storage service catalog data."}],"source_content_type":"text/x-python","patch_set":9,"id":"7b239f2f_3ecdb374","line":574,"range":{"start_line":574,"start_character":0,"end_line":574,"end_character":63},"in_reply_to":"277b809f_744b387b","updated":"2024-11-19 06:53:10.000000000","message":"yes, share server migration works with replica for Netapp with downstream deployment since last 6 months. \nthere is test in tempest plugin added in dependent PR.","commit_id":"2ab05ed2ecab938eaf1cfdc42f064d5ed04fd999"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8aa53ab4f76988958cbb71f5cbf6f79faad37510","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            \u0027security_service_update_support\u0027: True,"},{"line_number":572,"context_line":"            \u0027share_server_multiple_subnet_support\u0027: True,"},{"line_number":573,"context_line":"            \u0027mount_point_name_support\u0027: True,"},{"line_number":574,"context_line":"            \u0027allow_share_server_migration_with_replicas\u0027: True,"},{"line_number":575,"context_line":"        }"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        # Add storage service catalog data."}],"source_content_type":"text/x-python","patch_set":9,"id":"30f9f410_b6f253fb","line":574,"range":{"start_line":574,"start_character":0,"end_line":574,"end_character":63},"in_reply_to":"7b239f2f_3ecdb374","updated":"2024-11-21 07:10:03.000000000","message":"Done","commit_id":"2ab05ed2ecab938eaf1cfdc42f064d5ed04fd999"}],"manila/share/manager.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d3045b666449b774933d0f48167c51a99944017f","unresolved":true,"context_lines":[{"line_number":5990,"context_line":"    @utils.require_driver_initialized"},{"line_number":5991,"context_line":"    def is_allow_migration_with_replicas("},{"line_number":5992,"context_line":"            self, context, share_server_id, dest_host):"},{"line_number":5993,"context_line":"        return self.driver.allow_share_server_migration_with_replicas"},{"line_number":5994,"context_line":""},{"line_number":5995,"context_line":"    @add_hooks"},{"line_number":5996,"context_line":"    @utils.require_driver_initialized"}],"source_content_type":"text/x-python","patch_set":2,"id":"ed1fd914_380bcfcc","line":5993,"range":{"start_line":5993,"start_character":8,"end_line":5993,"end_character":69},"updated":"2024-11-13 06:51:03.000000000","message":"return self.driver.allow_share_server_migration_with_replicas()\n\nTo do so, allow_share_server_migration_with_replicas must be a member variable or function driven by the parent class,\n\nwe also need add \n\ndef allow_share_server_migration_with_replicas():\n    xxxxx\n    \nto manila/share/driver.py","commit_id":"d3fc46a3e210e18802a1c73ce8034459e9c62dca"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"cb7d7feabc9e3c068fd3546eb412b94ee28fa54d","unresolved":false,"context_lines":[{"line_number":5990,"context_line":"    @utils.require_driver_initialized"},{"line_number":5991,"context_line":"    def is_allow_migration_with_replicas("},{"line_number":5992,"context_line":"            self, context, share_server_id, dest_host):"},{"line_number":5993,"context_line":"        return self.driver.allow_share_server_migration_with_replicas"},{"line_number":5994,"context_line":""},{"line_number":5995,"context_line":"    @add_hooks"},{"line_number":5996,"context_line":"    @utils.require_driver_initialized"}],"source_content_type":"text/x-python","patch_set":2,"id":"faef9d29_300e7fb3","line":5993,"range":{"start_line":5993,"start_character":8,"end_line":5993,"end_character":69},"in_reply_to":"ed1fd914_380bcfcc","updated":"2024-11-13 08:41:20.000000000","message":"Done","commit_id":"d3fc46a3e210e18802a1c73ce8034459e9c62dca"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0725f0657530deb476329e620348f6fbbd07e98","unresolved":true,"context_lines":[{"line_number":3396,"context_line":"                 \u0027identifier\u0027: new_identifier,"},{"line_number":3397,"context_line":"                 \u0027network_allocation_update_support\u0027: ("},{"line_number":3398,"context_line":"                     self.driver.network_allocation_update_support)})"},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"        except Exception:"},{"line_number":3401,"context_line":"            msg \u003d \"Error managing share server %s\""},{"line_number":3402,"context_line":"            LOG.exception(msg, share_server_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"36858876_4d7a0b5e","line":3399,"updated":"2024-11-21 08:16:20.000000000","message":"manage share server also need add:\n                        \u0027share_replicas_migration_support\u0027: (\n                            self.driver.share_replicas_migration_support),","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f098a59d72f4b8a6f54eefd377c74c112e117bbb","unresolved":false,"context_lines":[{"line_number":3396,"context_line":"                 \u0027identifier\u0027: new_identifier,"},{"line_number":3397,"context_line":"                 \u0027network_allocation_update_support\u0027: ("},{"line_number":3398,"context_line":"                     self.driver.network_allocation_update_support)})"},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"        except Exception:"},{"line_number":3401,"context_line":"            msg \u003d \"Error managing share server %s\""},{"line_number":3402,"context_line":"            LOG.exception(msg, share_server_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"e1de341d_0dfb4155","line":3399,"in_reply_to":"36858876_4d7a0b5e","updated":"2024-11-21 12:50:13.000000000","message":"Done","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7948dcb69ba54547a497926199a5c1b61f316b8e","unresolved":false,"context_lines":[{"line_number":3396,"context_line":"                 \u0027identifier\u0027: new_identifier,"},{"line_number":3397,"context_line":"                 \u0027network_allocation_update_support\u0027: ("},{"line_number":3398,"context_line":"                     self.driver.network_allocation_update_support)})"},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"        except Exception:"},{"line_number":3401,"context_line":"            msg \u003d \"Error managing share server %s\""},{"line_number":3402,"context_line":"            LOG.exception(msg, share_server_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3c11cb23_29dda64a","line":3399,"in_reply_to":"e1de341d_0dfb4155","updated":"2024-11-21 23:37:17.000000000","message":"good catch, Haixin!","commit_id":"4bb69b6d3d1d96771d39b665932311a6651646d7"}],"manila/share/rpcapi.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"28ed237f7af69937d87e3c5bc7bca82c3eef8816","unresolved":true,"context_lines":[{"line_number":200,"context_line":"                                         share_server, dest_host):"},{"line_number":201,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":202,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.30\u0027)"},{"line_number":203,"context_line":"        call_context.cast("},{"line_number":204,"context_line":"            context,"},{"line_number":205,"context_line":"            \u0027is_allow_migration_with_replicas\u0027,"},{"line_number":206,"context_line":"            share_server_id\u003dshare_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"2ea66144_e5a8d40c","line":203,"range":{"start_line":203,"start_character":21,"end_line":203,"end_character":25},"updated":"2024-11-14 00:58:24.000000000","message":"should be call.\nbecause we need the bool result in api layer.","commit_id":"974110e658c95d605b90a692ecfbfbfe1cbeed98"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"334226d108930d07878a8023c4b16263381e3539","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                         share_server, dest_host):"},{"line_number":201,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":202,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.30\u0027)"},{"line_number":203,"context_line":"        call_context.cast("},{"line_number":204,"context_line":"            context,"},{"line_number":205,"context_line":"            \u0027is_allow_migration_with_replicas\u0027,"},{"line_number":206,"context_line":"            share_server_id\u003dshare_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"16d7f613_4454b618","line":203,"range":{"start_line":203,"start_character":21,"end_line":203,"end_character":25},"in_reply_to":"2ea66144_e5a8d40c","updated":"2024-11-14 07:52:15.000000000","message":"Done","commit_id":"974110e658c95d605b90a692ecfbfbfe1cbeed98"}],"manila/tests/share/drivers/dummy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f0e09846c431ad759d97ea274d71ac1efca0a468","unresolved":true,"context_lines":[{"line_number":783,"context_line":"        \"\"\"returns true if support a share server migration with replicas."},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        \"\"\""},{"line_number":786,"context_line":"        return False"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    @slow_me_down"},{"line_number":789,"context_line":"    def share_server_migration_start(self, context, src_share_server,"}],"source_content_type":"text/x-python","patch_set":6,"id":"401a7b5d_8204d791","line":786,"updated":"2024-11-14 17:25:29.000000000","message":"No point turning off the feature for the dummy driver? This driver must be enabled to do a whole bunch of things so that we can test behaviors out of the API.. In theory, you cannot/should not have _only_ proprietary implementations for driver behavior. The \"container\" driver supports share server migration, however, it doesn\u0027t support replication... so please atleast have some dummy implementation here so we can test with it.","commit_id":"babb8340ed9309a3f485cb96ebeebcb0df7abb30"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5be12e65de437a2a11d9666e75d1c9dacef60e12","unresolved":false,"context_lines":[{"line_number":783,"context_line":"        \"\"\"returns true if support a share server migration with replicas."},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        \"\"\""},{"line_number":786,"context_line":"        return False"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    @slow_me_down"},{"line_number":789,"context_line":"    def share_server_migration_start(self, context, src_share_server,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0848ac3d_7406f608","line":786,"in_reply_to":"401a7b5d_8204d791","updated":"2024-11-15 10:22:32.000000000","message":"Done","commit_id":"babb8340ed9309a3f485cb96ebeebcb0df7abb30"}]}