)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8c505765b7116b51a044a7c316bae5cc4830179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"858b6f69_0ebd08a5","updated":"2025-03-20 15:32:27.000000000","message":"Forgot to ask this before: could you please add a release note for this fix?","commit_id":"dcf457e3c4012a06cf259c18ddde3b17bf0f3c22"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8514c2de3c32f2c23bbc5ad8663a1c8c70d42c21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b0ac8015_b98db66d","updated":"2025-02-20 14:16:48.000000000","message":"LGTM, thanks for the fix","commit_id":"dcf457e3c4012a06cf259c18ddde3b17bf0f3c22"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d323b8d17fbd152cbf681991b0f2a88a635c046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e1d9f094_0232954d","updated":"2025-03-24 20:35:06.000000000","message":"Hey @ashrod98@redhat.com: can you try enabling share group tests? https://github.com/openstack/manila-tempest-plugin/blob/58903bdd47ad33cc82fd29bd1066f4c4f1245143/zuul.d/manila-tempest-jobs.yaml#L412","commit_id":"12903442f70299452131421c4be52cb885407f5b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"06c20908cf28c0957702f1dc473ae30dcbfc0168","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4228553d_34481b7a","in_reply_to":"d5502955_8dfba167","updated":"2025-03-25 19:46:10.000000000","message":"ah youre right, shoudlve added the link here: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/940169\nI\u0027ll recheck since the output is old","commit_id":"12903442f70299452131421c4be52cb885407f5b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7bd924f10f2df18dda7f79816060ac541abe259","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d5502955_8dfba167","in_reply_to":"e1d9f094_0232954d","updated":"2025-03-25 17:45:53.000000000","message":"@ashrod98@redhat.com\n\nCan you attempt this?","commit_id":"12903442f70299452131421c4be52cb885407f5b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7bd924f10f2df18dda7f79816060ac541abe259","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6e7c7ec4_7ef6a9ac","updated":"2025-03-25 17:45:53.000000000","message":"Testing question remains","commit_id":"b4b13ca1f86d253810d1171e7768297182cf7c53"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bf01a0c404a5eeb000052afab1b359088a49c8f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cc55f413_f5ff300e","updated":"2025-03-25 15:23:15.000000000","message":"Thanks for the reviews!","commit_id":"b4b13ca1f86d253810d1171e7768297182cf7c53"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"66838f8efd7344b7be6fafed0ab9929b1192153c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b453d203_97fde6bf","updated":"2025-09-18 18:06:04.000000000","message":"LGTM, thanks for working on this change. Should we still get the release note though?","commit_id":"963325a1223d7372a84714ff6cf082cbc1dd455c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f4af182ad4bee3894aa72c66bcdbe3d626039d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7505a368_426d7ff9","in_reply_to":"b453d203_97fde6bf","updated":"2025-10-06 18:41:31.000000000","message":"Yes, warranted.. also, i dropped the group snapshot creation attempt with ceph because the functionality is gone in all supported versions of ceph.","commit_id":"963325a1223d7372a84714ff6cf082cbc1dd455c"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"346a648997c55f7ba83361da4ae5e48f4feac205","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"590f69a7_a8fb9b97","updated":"2026-03-09 16:41:44.000000000","message":"Code wise it looks good to me, only one question below. I am okay with +1 if that is answered.","commit_id":"08a5c8c3c1037c07a409bcd56d3452b162c3cfd0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d72db501a010a919714b4888ede23ca2f0522fb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c6cd2bf0_17bed90e","updated":"2025-10-06 22:58:40.000000000","message":"LGTM, thank Goutham and Ashley!","commit_id":"08a5c8c3c1037c07a409bcd56d3452b162c3cfd0"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"103468ed9305d909209e104a0c4c7195349f1242","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cde2e101_0116e0f6","updated":"2026-03-10 13:51:34.000000000","message":"Looks good to me, provided one minor comments.","commit_id":"08a5c8c3c1037c07a409bcd56d3452b162c3cfd0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f2b2ce856b1e17bf4e0bff4bd29a9fcd71e63c33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"71370c2d_62fae67a","updated":"2026-03-11 21:30:46.000000000","message":"Bit of an RC1 rush kicking in, so merging it. Thanks for the review, Gireesh and thanks for addressing the comments, Goutham!","commit_id":"9b4303f42d4908b5d37361da43b8117502ba6531"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5339cb83ce530ebe481f70b2a878485185c83d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c5a13cda_2f8079a7","updated":"2026-03-11 13:22:31.000000000","message":"LGTM, thanks Goutham!","commit_id":"9b4303f42d4908b5d37361da43b8117502ba6531"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b4086fa848029081adcfcb90b871c8be5d83fa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5b2e5739_41502b00","updated":"2026-03-10 22:48:44.000000000","message":"ty for the comments!","commit_id":"9b4303f42d4908b5d37361da43b8117502ba6531"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e7602d5db0446f0d84e7b1fadab8d3344ad1677","unresolved":true,"context_lines":[{"line_number":974,"context_line":"            \"force\": True,"},{"line_number":975,"context_line":"        }"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        rados_command("},{"line_number":978,"context_line":"            self.rados_client, \"fs subvolumegroup snapshot rm\", argdict)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        return None, []"},{"line_number":981,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"25fd6ef5_830e766e","line":978,"range":{"start_line":977,"start_character":0,"end_line":978,"end_character":72},"updated":"2025-03-25 21:17:27.000000000","message":"With the below code change, it\u0027s possible that this command will fail, and we should try to invoke the super class method for snapshots created by the base driver..","commit_id":"b4b13ca1f86d253810d1171e7768297182cf7c53"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"985b345c932be04f0cf78682242d1e90af9f55a6","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            \"force\": True,"},{"line_number":975,"context_line":"        }"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        rados_command("},{"line_number":978,"context_line":"            self.rados_client, \"fs subvolumegroup snapshot rm\", argdict)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        return None, []"},{"line_number":981,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d90cff88_8e28ff0f","line":978,"range":{"start_line":977,"start_character":0,"end_line":978,"end_character":72},"in_reply_to":"25fd6ef5_830e766e","updated":"2025-09-18 06:30:55.000000000","message":"Done","commit_id":"b4b13ca1f86d253810d1171e7768297182cf7c53"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e7602d5db0446f0d84e7b1fadab8d3344ad1677","unresolved":true,"context_lines":[{"line_number":987,"context_line":"                  {\"be\": self.backend_name, \"id\": snap_dict[\u0027share_group_id\u0027],"},{"line_number":988,"context_line":"                   \"sn\": snap_dict[\"id\"]})"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"        raise NotImplementedError(_("},{"line_number":991,"context_line":"            \"Share group snapshot feature is no longer supported in \""},{"line_number":992,"context_line":"            \"mainline CephFS (existing group snapshots can still be \""},{"line_number":993,"context_line":"            \"listed and deleted).\"))"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    def _get_clone_status(self, share):"},{"line_number":996,"context_line":"        \"\"\"Check the status of a newly cloned share.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3131a9a1_5baa5ded","line":993,"range":{"start_line":990,"start_character":8,"end_line":993,"end_character":36},"updated":"2025-03-25 21:17:27.000000000","message":"the tests are telling us that NotImplementedError isn\u0027t being handled any differently in the share manager, we should be invoking the super class\u0027s method instead so that the base driver will do the job of creating individual member snapshots","commit_id":"b4b13ca1f86d253810d1171e7768297182cf7c53"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"985b345c932be04f0cf78682242d1e90af9f55a6","unresolved":false,"context_lines":[{"line_number":987,"context_line":"                  {\"be\": self.backend_name, \"id\": snap_dict[\u0027share_group_id\u0027],"},{"line_number":988,"context_line":"                   \"sn\": snap_dict[\"id\"]})"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"        raise NotImplementedError(_("},{"line_number":991,"context_line":"            \"Share group snapshot feature is no longer supported in \""},{"line_number":992,"context_line":"            \"mainline CephFS (existing group snapshots can still be \""},{"line_number":993,"context_line":"            \"listed and deleted).\"))"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    def _get_clone_status(self, share):"},{"line_number":996,"context_line":"        \"\"\"Check the status of a newly cloned share.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"10968464_5515d4fe","line":993,"range":{"start_line":990,"start_character":8,"end_line":993,"end_character":36},"in_reply_to":"3131a9a1_5baa5ded","updated":"2025-09-18 06:30:55.000000000","message":"Done","commit_id":"b4b13ca1f86d253810d1171e7768297182cf7c53"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"103468ed9305d909209e104a0c4c7195349f1242","unresolved":true,"context_lines":[{"line_number":984,"context_line":"                      \"using CephFS subvolumegroup command.\","},{"line_number":985,"context_line":"                      {\"be\": self.backend_name, \"snap\": snap_dict[\u0027id\u0027]})"},{"line_number":986,"context_line":"            return None, []"},{"line_number":987,"context_line":"        except Exception as e:"},{"line_number":988,"context_line":"            LOG.warning(\"[%(be)s]: CephFS subvolumegroup snapshot rm failed \""},{"line_number":989,"context_line":"                        \"for group snapshot %(snap)s: %(error)s. \""},{"line_number":990,"context_line":"                        \"Falling back to generic deletion method.\","},{"line_number":991,"context_line":"                        {\"be\": self.backend_name, \"snap\": snap_dict[\u0027id\u0027],"},{"line_number":992,"context_line":"                         \"error\": e})"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"            # Fall back to the generic implementation from the parent class"},{"line_number":995,"context_line":"            # This will delete each snapshot member individually"}],"source_content_type":"text/x-python","patch_set":12,"id":"08d72489_a93633cb","line":992,"range":{"start_line":987,"start_character":8,"end_line":992,"end_character":37},"updated":"2026-03-10 13:51:34.000000000","message":"Could you catch a more specific exception for group snapshot deletion instead of using a broader exception","commit_id":"08a5c8c3c1037c07a409bcd56d3452b162c3cfd0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b4086fa848029081adcfcb90b871c8be5d83fa8","unresolved":false,"context_lines":[{"line_number":984,"context_line":"                      \"using CephFS subvolumegroup command.\","},{"line_number":985,"context_line":"                      {\"be\": self.backend_name, \"snap\": snap_dict[\u0027id\u0027]})"},{"line_number":986,"context_line":"            return None, []"},{"line_number":987,"context_line":"        except Exception as e:"},{"line_number":988,"context_line":"            LOG.warning(\"[%(be)s]: CephFS subvolumegroup snapshot rm failed \""},{"line_number":989,"context_line":"                        \"for group snapshot %(snap)s: %(error)s. \""},{"line_number":990,"context_line":"                        \"Falling back to generic deletion method.\","},{"line_number":991,"context_line":"                        {\"be\": self.backend_name, \"snap\": snap_dict[\u0027id\u0027],"},{"line_number":992,"context_line":"                         \"error\": e})"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"            # Fall back to the generic implementation from the parent class"},{"line_number":995,"context_line":"            # This will delete each snapshot member individually"}],"source_content_type":"text/x-python","patch_set":12,"id":"34de3af5_6c3fea7d","line":992,"range":{"start_line":987,"start_character":8,"end_line":992,"end_character":37},"in_reply_to":"08d72489_a93633cb","updated":"2026-03-10 22:48:44.000000000","message":"Good point. Done","commit_id":"08a5c8c3c1037c07a409bcd56d3452b162c3cfd0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"346a648997c55f7ba83361da4ae5e48f4feac205","unresolved":true,"context_lines":[{"line_number":1005,"context_line":"                  \"implementation.\", {\"id\": snap_dict[\u0027share_group_id\u0027],"},{"line_number":1006,"context_line":"                                      \"sn\": snap_dict[\"id\"]})"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        return super(CephFSDriver, self).create_share_group_snapshot("},{"line_number":1009,"context_line":"            context, snap_dict, share_server\u003dshare_server)"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"    def _get_clone_status(self, share):"}],"source_content_type":"text/x-python","patch_set":12,"id":"beb68229_a2c9b5c5","line":1008,"updated":"2026-03-09 16:41:44.000000000","message":"Just a quick question. Since this is a consistent snapshot, I assume the start and commit happens via this method? Because the I/Os need to be quiesced during the snapshot creation and then a commit to the snapshot needs to be done?","commit_id":"08a5c8c3c1037c07a409bcd56d3452b162c3cfd0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff956ac0ba785920dfca7e2e77dd09c81d3c6c61","unresolved":true,"context_lines":[{"line_number":1005,"context_line":"                  \"implementation.\", {\"id\": snap_dict[\u0027share_group_id\u0027],"},{"line_number":1006,"context_line":"                                      \"sn\": snap_dict[\"id\"]})"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        return super(CephFSDriver, self).create_share_group_snapshot("},{"line_number":1009,"context_line":"            context, snap_dict, share_server\u003dshare_server)"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"    def _get_clone_status(self, share):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a415fb9_f3b34524","line":1008,"in_reply_to":"beb68229_a2c9b5c5","updated":"2026-03-09 19:27:42.000000000","message":"This isn\u0027t expected to be a consistent group snapshot... For consistent group snapshots, the driver must report a capability to the scheduler: \"consistent_snapshot_support\" and it must be set to \"host\" or \"pool\" indicating how the shares would (need to) be placed. The CephFS driver didn\u0027t support that and its implementation of group snapshots isn\u0027t that much different/better than the generic implementation where we\u0027re just using a loop to create individual share snapshots and layering metadata to denote a group snapshot","commit_id":"08a5c8c3c1037c07a409bcd56d3452b162c3cfd0"}],"releasenotes/notes/bug-2019156-fix-exception-handling-26e451aaf0d7d698.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d323b8d17fbd152cbf681991b0f2a88a635c046","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed wrong exception being raised replacing ShareBackendException with"},{"line_number":5,"context_line":"    NotImplementedError"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"57ee424a_3868feb0","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":23},"updated":"2025-03-24 20:35:06.000000000","message":"The consequence of this is more useful to end users/operators reading these release notes:\n\nPerhaps:\n\n```\nAn incorrect exception was preventing generic share group snapshots within\nthe CephFS driver. This exception has been changed so that the share manager\ncan generically support group snapshots with this back end.\n```","commit_id":"12903442f70299452131421c4be52cb885407f5b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bf01a0c404a5eeb000052afab1b359088a49c8f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed wrong exception being raised replacing ShareBackendException with"},{"line_number":5,"context_line":"    NotImplementedError"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7700ff61_1062d29c","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":23},"in_reply_to":"57ee424a_3868feb0","updated":"2025-03-25 15:23:15.000000000","message":"Done","commit_id":"12903442f70299452131421c4be52cb885407f5b"}]}