)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a0cf192225957feee2698a2f531777bb455890f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee87573f_8a3a16e8","updated":"2024-12-05 19:59:30.000000000","message":"LGTM, thank you","commit_id":"b01967ef656b5a6449cb74374b5183d6dcb53589"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f5b89648bbb4e30ecaa32fbc26b656439addf20e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d9873bec_c3d8dbcd","updated":"2024-12-03 23:22:34.000000000","message":"LGTM; thank you @kajinamit@oss.nttdata.com","commit_id":"b01967ef656b5a6449cb74374b5183d6dcb53589"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"64255c2aa85456135c5ca1716fc7f7bff13fd342","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"802623c6_0a9da596","updated":"2024-12-18 11:18:04.000000000","message":"LGTM, thank you Takashi","commit_id":"361af5e4b86cf1a91f405c25fef1ba079e735513"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"653f2436567b611840bf5c8c57fabbebdddfaecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a606d7e8_dda0a9c6","updated":"2024-12-06 10:48:36.000000000","message":"Thanks!","commit_id":"361af5e4b86cf1a91f405c25fef1ba079e735513"}],"manila/api/validation/validators.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6a0796b3c57721ec7a896f9fa6216a3c1d55c89","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        validator_cls \u003d jsonschema.validators.extend("},{"line_number":209,"context_line":"            self.validator_org, validators"},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"        global _FORMAT_CHECKER"},{"line_number":212,"context_line":"        self.validator \u003d validator_cls(schema, format_checker\u003d_FORMAT_CHECKER)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def validate(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"c7b0eab4_24f7d8c0","line":211,"updated":"2024-12-04 17:16:15.000000000","message":"Do we need this to be global, given we\u0027re not modifying it?","commit_id":"b01967ef656b5a6449cb74374b5183d6dcb53589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"17f26b45ded27d1827748579ae5e27c7d20c8476","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        validator_cls \u003d jsonschema.validators.extend("},{"line_number":209,"context_line":"            self.validator_org, validators"},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"        global _FORMAT_CHECKER"},{"line_number":212,"context_line":"        self.validator \u003d validator_cls(schema, format_checker\u003d_FORMAT_CHECKER)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def validate(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"98a7e90c_800b8e7f","line":211,"in_reply_to":"59877b93_9fec6e7c","updated":"2024-12-06 03:12:28.000000000","message":"OK I understand the point and I agree we may not need the global keyword... let me update the change.","commit_id":"b01967ef656b5a6449cb74374b5183d6dcb53589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"647629fd2ab1774433522ac8f095951a499680e4","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        validator_cls \u003d jsonschema.validators.extend("},{"line_number":209,"context_line":"            self.validator_org, validators"},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"        global _FORMAT_CHECKER"},{"line_number":212,"context_line":"        self.validator \u003d validator_cls(schema, format_checker\u003d_FORMAT_CHECKER)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def validate(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1b58d774_1ee9e2ac","line":211,"in_reply_to":"98a7e90c_800b8e7f","updated":"2024-12-06 03:12:52.000000000","message":"Done","commit_id":"b01967ef656b5a6449cb74374b5183d6dcb53589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"11d3e333b162b817f800d961de72d73a8d759e8f","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        validator_cls \u003d jsonschema.validators.extend("},{"line_number":209,"context_line":"            self.validator_org, validators"},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"        global _FORMAT_CHECKER"},{"line_number":212,"context_line":"        self.validator \u003d validator_cls(schema, format_checker\u003d_FORMAT_CHECKER)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def validate(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dddef7ba_823fffd7","line":211,"in_reply_to":"c7b0eab4_24f7d8c0","updated":"2024-12-05 07:01:13.000000000","message":"We need this global instance. Previously the FormatChecker instance was implicitly updated with the additional format checkers (_validate_datetime_format and _validate_uuid_format ) Now we use a dedicated instance to load additional checkers, we need that instance picked up here.","commit_id":"b01967ef656b5a6449cb74374b5183d6dcb53589"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71e5d266ad67cc6e0d0cb9276aaa3eb732b216d5","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        validator_cls \u003d jsonschema.validators.extend("},{"line_number":209,"context_line":"            self.validator_org, validators"},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"        global _FORMAT_CHECKER"},{"line_number":212,"context_line":"        self.validator \u003d validator_cls(schema, format_checker\u003d_FORMAT_CHECKER)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def validate(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"59877b93_9fec6e7c","line":211,"in_reply_to":"dddef7ba_823fffd7","updated":"2024-12-05 16:18:34.000000000","message":"Sorry, I mean do we need the `global` keyword? You can still access the variable without this. You just can\u0027t change its value (or rather, attempting to change it will create a shadow variable)","commit_id":"b01967ef656b5a6449cb74374b5183d6dcb53589"}]}