)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e44c29d678776954157874edf506545a9d30aa30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a7a80ec_70ccb9b3","updated":"2024-11-20 14:44:42.000000000","message":"Before the fix the non privileged user can see the access made by and locked by nova:\n```\nstack@gibi-devstack-aio-jammy:~$ openstack share access list 1b4fd14f-349f-4ab5-83a7-084a444aaf7a\n+------------+-------------+------------+--------------+---------+------------+------------+----------------+\n| ID         | Access Type | Access To  | Access Level | State   | Access Key | Created At | Updated At     |\n+------------+-------------+------------+--------------+---------+------------+------------+----------------+\n| 57358712-  | ip          | 10.0.76.22 | rw           | denying | None       | 2024-11-   | 2024-11-       |\n| ebc1-49e0- |             | 2          |              |         |            | 20T14:20:5 | 20T14:21:38.31 |\n| a8e8-      |             |            |              |         |            | 4.360814   | 2539           |\n| de2a0de702 |             |            |              |         |            |            |                |\n| cb         |             |            |              |         |            |            |                |\n+------------+-------------+------------+--------------+---------+------------+------------+----------------+\n```\nAfter the fix the fact that there is an access is visible but the sensitive fields are hidden:\n```\nstack@gibi-devstack-aio-jammy:~$ openstack share access list 1b4fd14f-349f-4ab5-83a7-084a444aaf7a\n+-------------+-------------+-----------+--------------+--------+------------+-------------+--------------+\n| ID          | Access Type | Access To | Access Level | State  | Access Key | Created At  | Updated At   |\n+-------------+-------------+-----------+--------------+--------+------------+-------------+--------------+\n| 640b6776-   | ip          | ******    | rw           | active | ******     | 2024-11-    | 2024-11-     |\n| 9612-4715-  |             |           |              |        |            | 20T14:37:28 | 20T14:37:30. |\n| 936b-       |             |           |              |        |            | .648287     | 835469       |\n| e4e587da27a |             |           |              |        |            |             |              |\n| d           |             |           |              |        |            |             |              |\n+-------------+-------------+-----------+--------------+--------+------------+-------------+--------------+\nstack@gibi-devstack-aio-jammy:~$ openstack share access show 640b6776-9612-4715-936b-e4e587da27ad\n+--------------+--------------------------------------+\n| Field        | Value                                |\n+--------------+--------------------------------------+\n| id           | 640b6776-9612-4715-936b-e4e587da27ad |\n| share_id     | 1b4fd14f-349f-4ab5-83a7-084a444aaf7a |\n| access_level | rw                                   |\n| access_to    | ******                               |\n| access_type  | ip                                   |\n| state        | active                               |\n| access_key   | ******                               |\n| created_at   | 2024-11-20T14:37:28.648287           |\n| updated_at   | 2024-11-20T14:37:30.835469           |\n| properties   |                                      |\n+--------------+--------------------------------------+\n```\nSo for me this fixes the issue.","commit_id":"0b9cb2f097bc6d8d02e92c9bc0e53f020168df60"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2895b8a407126f8b659703dd057d0b8ef0ff3b3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55b94905_4baf1ef0","updated":"2024-11-20 21:06:27.000000000","message":"Thanks Carlos; can you please see the test failures; it looks like a test needs to be adjusted in manila-tempest-plugin; i\u0027d also look at adding test cases that we discussed for:\n\n1) Access rule with restrictions created by admin in the \"admin\" project, assert that sensitive fields are not visible nor rule not deletable by a \"member\" user in the admin\u0027s project\n2) Access rule with restrictions created by admin in a user\u0027s project, assert that sensitive fields are not visible nor rule not deletable by a \"member\" user in the the the user\u0027s project.\n\n\nPlease also include a release note so we can backport this fix with docs..","commit_id":"0b9cb2f097bc6d8d02e92c9bc0e53f020168df60"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8708ccde3609f424566c3e2825ec728e767c7fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e36858e_99502420","updated":"2024-11-21 18:28:21.000000000","message":"Thanks for the reviews. The issue with the tests was that in the deletion, I was always assuming that not found would be due to lack of privileges. Now, we will assume that only in some scenarios. Please take another look :)","commit_id":"0b9cb2f097bc6d8d02e92c9bc0e53f020168df60"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86bfcee7_e563f25a","updated":"2024-11-21 20:32:30.000000000","message":"Dummy job already passed, confirming the issue with the test is gone. Updating the change with the suggestions now...","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8a923245b1605287be82a07e435c833bc466d8b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c4f7cb51_76618d46","updated":"2024-11-22 02:00:09.000000000","message":"LGTM, thanks. Carlos!","commit_id":"3d80e8668bb3ce96d9d0c099964bb5ca0a6df60b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb0ad27b2ac8590ccec6d86a65ab21eeb4af51d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2dc990d9_0d97659c","updated":"2024-11-21 22:11:57.000000000","message":"LGTM; thank you Carlos","commit_id":"3d80e8668bb3ce96d9d0c099964bb5ca0a6df60b"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16e77753c1bad65b113e6b95fa5e862685d079c5","unresolved":true,"context_lines":[{"line_number":616,"context_line":"        search_opts \u003d {"},{"line_number":617,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":618,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":619,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":620,"context_line":"        }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        locks, locks_count \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"e85b2153_feb5e245","line":619,"range":{"start_line":619,"start_character":28,"end_line":619,"end_character":32},"updated":"2024-11-21 20:18:41.000000000","message":"nit: trailing comma","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        search_opts \u003d {"},{"line_number":617,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":618,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":619,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":620,"context_line":"        }"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        locks, locks_count \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"255ac275_6ad1f7bd","line":619,"range":{"start_line":619,"start_character":28,"end_line":619,"end_character":32},"in_reply_to":"e85b2153_feb5e245","updated":"2024-11-21 20:32:30.000000000","message":"Done","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16e77753c1bad65b113e6b95fa5e862685d079c5","unresolved":true,"context_lines":[{"line_number":648,"context_line":"            try:"},{"line_number":649,"context_line":"                self.resource_locks_api.ensure_context_can_delete_lock("},{"line_number":650,"context_line":"                    context, lock[\u0027id\u0027])"},{"line_number":651,"context_line":"            except exception.NotAuthorized:"},{"line_number":652,"context_line":"                non_deletable_locks.append(lock)"},{"line_number":653,"context_line":"            except exception.ResourceLockNotFound:"},{"line_number":654,"context_line":"                # If it is not found, then it means that the context doesn\u0027t"},{"line_number":655,"context_line":"                # have access to this resource and should be denied."},{"line_number":656,"context_line":"                non_deletable_locks.append(lock)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        if non_deletable_locks:"},{"line_number":659,"context_line":"            raise_rule_is_locked(share_id, unrestrict\u003dunrestrict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2e3e939_36a8634f","line":656,"range":{"start_line":651,"start_character":0,"end_line":656,"end_character":48},"updated":"2024-11-21 20:18:41.000000000","message":"```suggestion\n            except (exception.NotAuthorized,\n                    exception.ResourceLockNotFound):\n                # If it is not found, then it means that the context doesn\u0027t\n                # have access to this resource and should be denied.\n                non_deletable_locks.append(lock)\n```","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            try:"},{"line_number":649,"context_line":"                self.resource_locks_api.ensure_context_can_delete_lock("},{"line_number":650,"context_line":"                    context, lock[\u0027id\u0027])"},{"line_number":651,"context_line":"            except exception.NotAuthorized:"},{"line_number":652,"context_line":"                non_deletable_locks.append(lock)"},{"line_number":653,"context_line":"            except exception.ResourceLockNotFound:"},{"line_number":654,"context_line":"                # If it is not found, then it means that the context doesn\u0027t"},{"line_number":655,"context_line":"                # have access to this resource and should be denied."},{"line_number":656,"context_line":"                non_deletable_locks.append(lock)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        if non_deletable_locks:"},{"line_number":659,"context_line":"            raise_rule_is_locked(share_id, unrestrict\u003dunrestrict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a8b002d0_bec3245f","line":656,"range":{"start_line":651,"start_character":0,"end_line":656,"end_character":48},"in_reply_to":"d2e3e939_36a8634f","updated":"2024-11-21 20:32:30.000000000","message":"Done","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"}],"manila/api/v2/share_accesses.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2895b8a407126f8b659703dd057d0b8ef0ff3b3f","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            \u0027resource_id\u0027: id,"},{"line_number":57,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_SHOW,"},{"line_number":58,"context_line":"            \u0027resource_type\u0027: \u0027access_rule\u0027,"},{"line_number":59,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"        locks, count \u003d self.resource_locks_api.get_all("},{"line_number":62,"context_line":"            context.elevated(), search_opts, show_count\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8429067_d62b811d","line":59,"range":{"start_line":59,"start_character":28,"end_line":59,"end_character":32},"updated":"2024-11-20 21:06:27.000000000","message":"nit: trailing comma","commit_id":"0b9cb2f097bc6d8d02e92c9bc0e53f020168df60"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8708ccde3609f424566c3e2825ec728e767c7fe","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            \u0027resource_id\u0027: id,"},{"line_number":57,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_SHOW,"},{"line_number":58,"context_line":"            \u0027resource_type\u0027: \u0027access_rule\u0027,"},{"line_number":59,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"        locks, count \u003d self.resource_locks_api.get_all("},{"line_number":62,"context_line":"            context.elevated(), search_opts, show_count\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0b6b2e3_88053b65","line":59,"range":{"start_line":59,"start_character":28,"end_line":59,"end_character":32},"in_reply_to":"d8429067_d62b811d","updated":"2024-11-21 18:28:21.000000000","message":"Done","commit_id":"0b9cb2f097bc6d8d02e92c9bc0e53f020168df60"}],"manila/lock/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2895b8a407126f8b659703dd057d0b8ef0ff3b3f","unresolved":true,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def ensure_context_can_delete_lock(self, context, lock_id):"},{"line_number":220,"context_line":"        \"\"\"Ensure the requester is able to delete locks.\"\"\""},{"line_number":221,"context_line":"        try:"},{"line_number":222,"context_line":"            resource_lock \u003d self.db.resource_lock_get(context, lock_id)"},{"line_number":223,"context_line":"        except exception.ResourceLockNotFound:"},{"line_number":224,"context_line":"            # If it is not found, then it means that the context doesn\u0027t have"},{"line_number":225,"context_line":"            # access to this resource and should be denied."},{"line_number":226,"context_line":"            raise exception.NotAuthorized("},{"line_number":227,"context_line":"                \"Resource lock cannot be manipulated by user. Please contact \""},{"line_number":228,"context_line":"                \"the administrator.\")"},{"line_number":229,"context_line":"        policy.check_policy(context, \u0027resource_lock\u0027, \u0027delete\u0027, resource_lock)"},{"line_number":230,"context_line":"        self._check_allow_lock_manipulation(context, resource_lock)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba923f8d_0057e3d6","line":228,"range":{"start_line":221,"start_character":8,"end_line":228,"end_character":37},"updated":"2024-11-20 21:06:27.000000000","message":"Can this handling be moved to the caller: https://opendev.org/openstack/manila/src/commit/9b6b6feda915fcad20754778c449b60e6250002b/manila/api/v1/shares.py#L647\n\nThe message used there is appropriate for this condition","commit_id":"0b9cb2f097bc6d8d02e92c9bc0e53f020168df60"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8708ccde3609f424566c3e2825ec728e767c7fe","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def ensure_context_can_delete_lock(self, context, lock_id):"},{"line_number":220,"context_line":"        \"\"\"Ensure the requester is able to delete locks.\"\"\""},{"line_number":221,"context_line":"        try:"},{"line_number":222,"context_line":"            resource_lock \u003d self.db.resource_lock_get(context, lock_id)"},{"line_number":223,"context_line":"        except exception.ResourceLockNotFound:"},{"line_number":224,"context_line":"            # If it is not found, then it means that the context doesn\u0027t have"},{"line_number":225,"context_line":"            # access to this resource and should be denied."},{"line_number":226,"context_line":"            raise exception.NotAuthorized("},{"line_number":227,"context_line":"                \"Resource lock cannot be manipulated by user. Please contact \""},{"line_number":228,"context_line":"                \"the administrator.\")"},{"line_number":229,"context_line":"        policy.check_policy(context, \u0027resource_lock\u0027, \u0027delete\u0027, resource_lock)"},{"line_number":230,"context_line":"        self._check_allow_lock_manipulation(context, resource_lock)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"551e06e9_3fd5eaee","line":228,"range":{"start_line":221,"start_character":8,"end_line":228,"end_character":37},"in_reply_to":"ba923f8d_0057e3d6","updated":"2024-11-21 18:28:21.000000000","message":"Done","commit_id":"0b9cb2f097bc6d8d02e92c9bc0e53f020168df60"}],"manila/tests/api/v1/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16e77753c1bad65b113e6b95fa5e862685d079c5","unresolved":true,"context_lines":[{"line_number":1463,"context_line":"        delete_search_opts \u003d {"},{"line_number":1464,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1465,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1466,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1467,"context_line":"        }"},{"line_number":1468,"context_line":""},{"line_number":1469,"context_line":"        resource_locks.API.get_all.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"31626bc8_32b045f7","line":1466,"range":{"start_line":1466,"start_character":28,"end_line":1466,"end_character":32},"updated":"2024-11-21 20:18:41.000000000","message":"nit: trailing comma","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"        delete_search_opts \u003d {"},{"line_number":1464,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1465,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1466,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1467,"context_line":"        }"},{"line_number":1468,"context_line":""},{"line_number":1469,"context_line":"        resource_locks.API.get_all.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"a372a749_07f8b5da","line":1466,"range":{"start_line":1466,"start_character":28,"end_line":1466,"end_character":32},"in_reply_to":"31626bc8_32b045f7","updated":"2024-11-21 20:32:30.000000000","message":"Done","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16e77753c1bad65b113e6b95fa5e862685d079c5","unresolved":true,"context_lines":[{"line_number":1491,"context_line":"        delete_search_opts \u003d {"},{"line_number":1492,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1493,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1494,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1495,"context_line":"        }"},{"line_number":1496,"context_line":""},{"line_number":1497,"context_line":"        resource_locks.API.get_all.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"303ee477_75af834d","line":1494,"range":{"start_line":1494,"start_character":28,"end_line":1494,"end_character":32},"updated":"2024-11-21 20:18:41.000000000","message":"nit: trailing comma","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[{"line_number":1491,"context_line":"        delete_search_opts \u003d {"},{"line_number":1492,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1493,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1494,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1495,"context_line":"        }"},{"line_number":1496,"context_line":""},{"line_number":1497,"context_line":"        resource_locks.API.get_all.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"839f59a0_e282d84d","line":1494,"range":{"start_line":1494,"start_character":28,"end_line":1494,"end_character":32},"in_reply_to":"303ee477_75af834d","updated":"2024-11-21 20:32:30.000000000","message":"Done","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16e77753c1bad65b113e6b95fa5e862685d079c5","unresolved":true,"context_lines":[{"line_number":1525,"context_line":"        delete_search_opts \u003d {"},{"line_number":1526,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1527,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1528,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1529,"context_line":"        }"},{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        resource_locks.API.get_all.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"7c1cd8fd_fe5f9997","line":1528,"range":{"start_line":1528,"start_character":28,"end_line":1528,"end_character":32},"updated":"2024-11-21 20:18:41.000000000","message":"nit: trailing comma","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"        delete_search_opts \u003d {"},{"line_number":1526,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1527,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1528,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1529,"context_line":"        }"},{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        resource_locks.API.get_all.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"c4cc1e33_6bb39c3d","line":1528,"range":{"start_line":1528,"start_character":28,"end_line":1528,"end_character":32},"in_reply_to":"7c1cd8fd_fe5f9997","updated":"2024-11-21 20:32:30.000000000","message":"Done","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16e77753c1bad65b113e6b95fa5e862685d079c5","unresolved":true,"context_lines":[{"line_number":1565,"context_line":"        delete_search_opts \u003d {"},{"line_number":1566,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1567,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1568,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1569,"context_line":"        }"},{"line_number":1570,"context_line":"        resource_locks.API.get_all.assert_called_once_with("},{"line_number":1571,"context_line":"            context, search_opts\u003ddelete_search_opts, show_count\u003dTrue"}],"source_content_type":"text/x-python","patch_set":2,"id":"47931922_da916aaf","line":1568,"range":{"start_line":1568,"start_character":28,"end_line":1568,"end_character":32},"updated":"2024-11-21 20:18:41.000000000","message":"nit: trailing comma","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[{"line_number":1565,"context_line":"        delete_search_opts \u003d {"},{"line_number":1566,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1567,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1568,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1569,"context_line":"        }"},{"line_number":1570,"context_line":"        resource_locks.API.get_all.assert_called_once_with("},{"line_number":1571,"context_line":"            context, search_opts\u003ddelete_search_opts, show_count\u003dTrue"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ec6b0ad_872550c9","line":1568,"range":{"start_line":1568,"start_character":28,"end_line":1568,"end_character":32},"in_reply_to":"47931922_da916aaf","updated":"2024-11-21 20:32:30.000000000","message":"Done","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16e77753c1bad65b113e6b95fa5e862685d079c5","unresolved":true,"context_lines":[{"line_number":1599,"context_line":"        delete_search_opts \u003d {"},{"line_number":1600,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1601,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1602,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1603,"context_line":"        }"},{"line_number":1604,"context_line":"        resource_locks.API.get_all.assert_called_once_with("},{"line_number":1605,"context_line":"            context.elevated(), search_opts\u003ddelete_search_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce770a1b_c709a2bf","line":1602,"range":{"start_line":1602,"start_character":28,"end_line":1602,"end_character":32},"updated":"2024-11-21 20:18:41.000000000","message":"nit: trailing comma","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3bb1d25471042465b57482ba7719495674995c2","unresolved":false,"context_lines":[{"line_number":1599,"context_line":"        delete_search_opts \u003d {"},{"line_number":1600,"context_line":"            \u0027resource_id\u0027: access_id,"},{"line_number":1601,"context_line":"            \u0027resource_action\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":1602,"context_line":"            \u0027all_projects\u0027: True"},{"line_number":1603,"context_line":"        }"},{"line_number":1604,"context_line":"        resource_locks.API.get_all.assert_called_once_with("},{"line_number":1605,"context_line":"            context.elevated(), search_opts\u003ddelete_search_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e07df8d_24ec5373","line":1602,"range":{"start_line":1602,"start_character":28,"end_line":1602,"end_character":32},"in_reply_to":"ce770a1b_c709a2bf","updated":"2024-11-21 20:32:30.000000000","message":"Done","commit_id":"cf3b1350fb01243b3e7a76a6599615aea1cee09f"}]}