)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a4dfebb0149462872ee80116e1fa0dd9902b5358","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-01-07 09:53:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adapt to nova api 2.87 and skip some cinder calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2.87 api version stopped returning \u0027id\u0027 field"},{"line_number":10,"context_line":"for volume_attachments."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9713146_5f0ef773","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":22},"updated":"2025-01-09 07:48:08.000000000","message":"2.89","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"502214d53eeb78cc79e85f12b719fea435dccc9c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-01-07 09:53:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adapt to nova api 2.87 and skip some cinder calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2.87 api version stopped returning \u0027id\u0027 field"},{"line_number":10,"context_line":"for volume_attachments."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9edf1fc6_36fe9ff6","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":22},"in_reply_to":"c9713146_5f0ef773","updated":"2025-01-09 10:45:21.000000000","message":"Done","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a4dfebb0149462872ee80116e1fa0dd9902b5358","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adapt to nova api 2.87 and skip some cinder calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2.87 api version stopped returning \u0027id\u0027 field"},{"line_number":10,"context_line":"for volume_attachments."},{"line_number":11,"context_line":"Use \u0027volumeId\u0027 instead, and skip resolving the volume name as"},{"line_number":12,"context_line":"none of the code does use volume names, everything only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1bf7850a_db43fa4b","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":8},"updated":"2025-01-09 07:48:08.000000000","message":"2.89","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"502214d53eeb78cc79e85f12b719fea435dccc9c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adapt to nova api 2.87 and skip some cinder calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the 2.87 api version stopped returning \u0027id\u0027 field"},{"line_number":10,"context_line":"for volume_attachments."},{"line_number":11,"context_line":"Use \u0027volumeId\u0027 instead, and skip resolving the volume name as"},{"line_number":12,"context_line":"none of the code does use volume names, everything only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a93da62a_9ee3e0cf","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":8},"in_reply_to":"1bf7850a_db43fa4b","updated":"2025-01-09 10:45:21.000000000","message":"Done","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a4dfebb0149462872ee80116e1fa0dd9902b5358","unresolved":true,"context_lines":[{"line_number":12,"context_line":"none of the code does use volume names, everything only"},{"line_number":13,"context_line":"ever needs volume id, so we can safely skip some API requests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: 2091658"},{"line_number":16,"context_line":"Change-Id: I5031fa4686fad4de5eb9151ca86f51eb5a2c1d76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4d25f05f_3d72ab65","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"updated":"2025-01-09 07:48:08.000000000","message":"here should be\nCloses-Bug:\nsince only this patch to solve this problem.","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"502214d53eeb78cc79e85f12b719fea435dccc9c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"none of the code does use volume names, everything only"},{"line_number":13,"context_line":"ever needs volume id, so we can safely skip some API requests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: 2091658"},{"line_number":16,"context_line":"Change-Id: I5031fa4686fad4de5eb9151ca86f51eb5a2c1d76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffbdad9d_b3cc8f24","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"4d25f05f_3d72ab65","updated":"2025-01-09 10:45:21.000000000","message":"Not really. I filed that bug against novaclient, not Manila. And I have a patch that fixes that backward compatibility breaking in novaclient https://review.opendev.org/c/openstack/python-novaclient/+/937642\n\nSo this patch here is actually more like a workaround for that novaclient bug, not to wait until it is merged and fix is released (plus, seems better to utilize a more universal field that is present in all API versions).","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a87b6d9980104c470a06c4f6e492007cfa1b5f08","unresolved":false,"context_lines":[{"line_number":12,"context_line":"none of the code does use volume names, everything only"},{"line_number":13,"context_line":"ever needs volume id, so we can safely skip some API requests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: 2091658"},{"line_number":16,"context_line":"Change-Id: I5031fa4686fad4de5eb9151ca86f51eb5a2c1d76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"295f735c_89765f05","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"ffbdad9d_b3cc8f24","updated":"2025-01-10 01:14:50.000000000","message":"Done.","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a4dfebb0149462872ee80116e1fa0dd9902b5358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b5f42a6_8598c12c","updated":"2025-01-09 07:48:08.000000000","message":"LGTM, thanks. just some small nit.","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ba95d14900f31e40fd71fa99cbbde4bdb09229bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56302cb6_c179403f","updated":"2025-01-23 21:22:37.000000000","message":"LGTM, thanks Pavlo","commit_id":"25003030b6f3e8f8a9eb2e6366fef5be6ad7142d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a87b6d9980104c470a06c4f6e492007cfa1b5f08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96f60b9f_6dd1be4c","updated":"2025-01-10 01:14:50.000000000","message":"LGTM, thanks.","commit_id":"25003030b6f3e8f8a9eb2e6366fef5be6ad7142d"}],"manila/compute/nova.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a4dfebb0149462872ee80116e1fa0dd9902b5358","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        volumes \u003d novaclient(context).volumes.get_server_volumes(instance_id)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return [vol.volumeId for vol in volumes]"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @translate_server_exception"},{"line_number":194,"context_line":"    def server_update(self, context, instance_id, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"cf080871_e19edabf","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":48},"updated":"2025-01-09 07:48:08.000000000","message":"better add a note here.","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"502214d53eeb78cc79e85f12b719fea435dccc9c","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        volumes \u003d novaclient(context).volumes.get_server_volumes(instance_id)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return [vol.volumeId for vol in volumes]"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @translate_server_exception"},{"line_number":194,"context_line":"    def server_update(self, context, instance_id, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"65fe11b4_c6fa52c0","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":48},"in_reply_to":"cf080871_e19edabf","updated":"2025-01-09 10:45:21.000000000","message":"Done","commit_id":"54688f56a40b8a078fe819fedbc4f374be2b63aa"}]}