)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5d170a08a85559b1d04a5910d70cb45a4bf51a8d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"update_access method."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://review.opendev.org/c/openstack/manila/+/931050"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I50db5078dd53730fd437c5868d0817c44adfa129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d7b050ff_74d59e66","line":15,"updated":"2025-02-20 14:14:14.000000000","message":"please add a closes-bug\n\nCloses-Bug: #2098090","commit_id":"593158787199e1115e9ff86cce3b0217c3b84c81"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b0f5a0ff914f5a7f7021b243e2a8b6f187b2cd82","unresolved":false,"context_lines":[{"line_number":12,"context_line":"update_access method."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://review.opendev.org/c/openstack/manila/+/931050"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I50db5078dd53730fd437c5868d0817c44adfa129"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"46c0c1b6_f78521ea","line":15,"in_reply_to":"d7b050ff_74d59e66","updated":"2025-02-20 14:58:47.000000000","message":"Done","commit_id":"593158787199e1115e9ff86cce3b0217c3b84c81"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d3d6078223b6d0db0ff91556014a8f44353b01d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bc8c766a_8b635c09","updated":"2025-02-03 10:12:23.000000000","message":"recheck","commit_id":"a2db07cbeaf27baa72457f38de2ff95946eaabda"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4801fc8bcae27b858955a16c3abdb66cb653be09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ce505cf5_bb4dd368","updated":"2025-02-03 12:22:12.000000000","message":"x-openstack-manila-api-version\u0027: \u00272.87\u0027, unless this is updated to 2.88, it will fail","commit_id":"a2db07cbeaf27baa72457f38de2ff95946eaabda"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"9d5d0e4baccf254bbf4276d18f94381432b81f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"edfdeb0b_2517b413","updated":"2025-02-11 20:53:29.000000000","message":"Between this patch the the one carlos proposed, tests relating to update access rules level pass. thanks for working on this","commit_id":"b4d02ee4354019c855bc59e7d24d6bf2b1d6f586"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1e60ed8c4547b60a49cb3ceb47cc076dd2cbf760","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f18e3b67_ada4b04d","updated":"2025-02-10 06:50:47.000000000","message":"recheck","commit_id":"b4d02ee4354019c855bc59e7d24d6bf2b1d6f586"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d853f9db47098e80e52e73042e977ac200a7efac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"61e92ff4_0909cc37","updated":"2025-02-19 18:08:55.000000000","message":"Thank you for working on this change. I believe this driver is also broken, please take a look:\n- inspur [1]:  you\u0027ve updated the method signature on the driver and you\u0027ve also updated the assistant signature, but you did not update the place that is calling it. Maybe we should not update the assistant at all, as it doesn\u0027t inherit from the base driver class?\n\n[1] https://review.opendev.org/c/openstack/manila/+/931050/10/manila/share/drivers/inspur/instorage/instorage.py#232","commit_id":"37a4366d055d98cc710e864feb9c27e6f72be53c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1ded7571e2913716b7f48f09a713da61362b4080","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dc637ced_31325857","updated":"2025-02-19 18:36:26.000000000","message":"Sorry, just looked at the most recent patch set and it will break the as13000 driver now. That driver was correct, and I believe the inspur instorage driver that I linked is the one that should be fixed [1]\n\n[1] https://review.opendev.org/c/openstack/manila/+/931050/10/manila/share/drivers/inspur/instorage/instorage.py#611","commit_id":"2eb37f677260d68bd4faa013d42da4acabc86d8a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5d170a08a85559b1d04a5910d70cb45a4bf51a8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"855a8388_dc932bd9","updated":"2025-02-20 14:14:14.000000000","message":"LGTM, only a nit with regards to Closes-Bug","commit_id":"593158787199e1115e9ff86cce3b0217c3b84c81"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"87700f81fa6619977b73c94cee083f43c21ff161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e6c10a6a_28b751c4","updated":"2025-02-20 19:56:48.000000000","message":"LGTM thanks Kiran","commit_id":"b1be38a00e461938c1e18da69c994149410f7f3c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8049bac8895e4a2873836d26f3b7465ddad043b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"314e2b81_cae3fba0","updated":"2025-02-21 09:32:57.000000000","message":"LGTM, thanks, Kiran Pawar. \nIf a vendor supports update rules, they can add this parameter support later.","commit_id":"b1be38a00e461938c1e18da69c994149410f7f3c"}]}