)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f57bd493001e4f3d017bf99a4f0cc6ccb400d0a9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandrakanth Renduchintala \u003cvnr.chandrakanth@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-01-31 23:39:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for bug #2034925"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes deletion of shares with broken affinity/anti-affinity rules by handling NotFound exceptions in ."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a909d85_7c640f8a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2025-05-28 20:35:23.000000000","message":"please add a more descriptive summary line, one example would be:\n\nFixes affinity/anti-affinity rules issues on share deletion","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a893b1c26079707fc222b0ac795a33cb1714dc8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandrakanth Renduchintala \u003cvnr.chandrakanth@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-01-31 23:39:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for bug #2034925"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes deletion of shares with broken affinity/anti-affinity rules by handling NotFound exceptions in ."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ae91dc8_69ccecb2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"in_reply_to":"7a909d85_7c640f8a","updated":"2026-01-29 12:01:06.000000000","message":"Done","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f57bd493001e4f3d017bf99a4f0cc6ccb400d0a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b35fa0d_ca5458c1","updated":"2025-05-28 20:35:23.000000000","message":"Thank you for working on this fix! Please take a look at the comments inline.\nCould you also please provide a release note [1] to this change?\n\n[1] https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b869993d35710b931765e636e35f020655aa4f77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"203a53d8_58fa33d0","updated":"2025-05-13 10:01:29.000000000","message":"recheck","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"769e0b136a54f26cf3d128bbe346106593ed42b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5750ae1_58bf3953","updated":"2025-05-15 14:05:02.000000000","message":"recheck\n\nerror was unrelated \n```\n      File \"/opt/stack/tempest/tempest/lib/common/ssh.py\", line 238, in exec_command\n    raise exceptions.SSHExecCommandFailed(\n\n    tempest.lib.exceptions.SSHExecCommandFailed: Command \u0027sudo sh -c \"dd bs\u003d64M count\u003d12 if\u003d/dev/zero of\u003d/mnt/t1 iflag\u003dfullblock\"\u0027, exit status: 1, stderr:\ndd: closing output file \u0027/mnt/t1\u0027: Cannot allocate memory\n\nstdout:\n```","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e3f3120917a430f70389a541488102845e1bae7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5f99644_3ba10325","updated":"2025-05-27 14:45:48.000000000","message":"recheck\nGrenade job failure, let\u0027s get some clean logs","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2e3d4262169f86d708402ad07dd21295d82a8183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3bc02ff4_9f979e2d","updated":"2026-03-04 09:45:04.000000000","message":"@chandra \nYou have replied Fix applied, but seems to forget push it. If so, push it otherwise I will fix by EOD.","commit_id":"acd191c4cce799c989f2d32d3c9976c2759cd5ef"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"071201370029050533bed3121c592ce18bee8149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9d9b3d2_6191926c","updated":"2026-03-04 10:59:29.000000000","message":"LGTM","commit_id":"acd191c4cce799c989f2d32d3c9976c2759cd5ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ceaaf9f93235ca341a748c2ae17f812658d9e38f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1f318bfc_14df6020","updated":"2026-03-03 18:56:49.000000000","message":"LGTM, thanks for working on this change","commit_id":"acd191c4cce799c989f2d32d3c9976c2759cd5ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"de71d904220006de57619829665bdefbf77d44b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f8324243_d5ad8904","updated":"2026-03-06 12:44:24.000000000","message":"Hey, Kiran! Please hold rechecks. The gate is broken for basically all openstack:  https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/2TF4CXQUCP4Y24PAKZQGM2D5BONL5Z34/\nPlease keep an eye on that thread or #openstack-manila irc channel for updates.","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"e01435c971d7dcabb5a2ce7974ac0359769b11e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4a033c20_4e3948be","updated":"2026-03-05 11:38:46.000000000","message":"LGTM","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"f5e48225cfd9b410b5bdd1bd914d2108562c7cbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8adc62b2_7261a2fd","updated":"2026-03-05 12:41:48.000000000","message":"Please take a look at the comment.","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"903c699198f990966a22a4593790e4f3feaa937b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31c3124f_5bab76b0","updated":"2026-03-06 12:42:53.000000000","message":"recheck","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8fb4aae18612bfd7fdb3ee0077d640e09488a228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0a6baa2_95f5de48","updated":"2026-03-06 07:49:52.000000000","message":"recheck","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5bb7afa535d1802a18c201a64558125377b26bc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19df6c41_df718a3d","updated":"2026-03-06 06:27:38.000000000","message":"thank you; one or more unit tests could help! please add them if you can","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7d9b5fb9fc50e204e54b36da79a2ac6d94b5fb35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b2387e00_2b6db623","in_reply_to":"a710cda4_db5c18e1","updated":"2026-03-06 13:03:48.000000000","message":"Apparently some jobs have been fixed now, I\u0027m watching this change on the CI.","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0aec06d47cb5e38b7c463faf5acd1bfefc29fba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a710cda4_db5c18e1","in_reply_to":"f8324243_d5ad8904","updated":"2026-03-06 12:48:29.000000000","message":"ACK","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"}],"manila/share/api.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f57bd493001e4f3d017bf99a4f0cc6ccb400d0a9","unresolved":true,"context_lines":[{"line_number":2673,"context_line":"            return"},{"line_number":2674,"context_line":""},{"line_number":2675,"context_line":"        except exception.NotFound:"},{"line_number":2676,"context_line":"            msg \u003d ("},{"line_number":2677,"context_line":"                \"Share ID \u0027%(share_id)s\u0027 not found in metadata. \""},{"line_number":2678,"context_line":"                \"Proceeding with deletion anyway.\""},{"line_number":2679,"context_line":"            ) % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":2680,"context_line":"            LOG.warning(msg)"},{"line_number":2681,"context_line":"            return"},{"line_number":2682,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0244f95e_1645609a","line":2679,"range":{"start_line":2676,"start_character":13,"end_line":2679,"end_character":41},"updated":"2025-05-28 20:35:23.000000000","message":"this is more about the metadata, right? so it means that this message should mention that the metadata wasn\u0027t found, and that the deletion would proceed.","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a893b1c26079707fc222b0ac795a33cb1714dc8f","unresolved":false,"context_lines":[{"line_number":2673,"context_line":"            return"},{"line_number":2674,"context_line":""},{"line_number":2675,"context_line":"        except exception.NotFound:"},{"line_number":2676,"context_line":"            msg \u003d ("},{"line_number":2677,"context_line":"                \"Share ID \u0027%(share_id)s\u0027 not found in metadata. \""},{"line_number":2678,"context_line":"                \"Proceeding with deletion anyway.\""},{"line_number":2679,"context_line":"            ) % {\u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":2680,"context_line":"            LOG.warning(msg)"},{"line_number":2681,"context_line":"            return"},{"line_number":2682,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d4e3f299_b291c855","line":2679,"range":{"start_line":2676,"start_character":13,"end_line":2679,"end_character":41},"in_reply_to":"0244f95e_1645609a","updated":"2026-01-29 12:01:06.000000000","message":"not its about share mentioned as uuid in hints are missing, so we need to handle that notfound exception.","commit_id":"c9cbd6e541aa4fd93d1e3174a61d320cb4686ece"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"f5e48225cfd9b410b5bdd1bd914d2108562c7cbd","unresolved":true,"context_lines":[{"line_number":2820,"context_line":"                result \u003d self.db.share_metadata_get_item(context, uuid, key)"},{"line_number":2821,"context_line":"            except exception.MetadataItemNotFound:"},{"line_number":2822,"context_line":"                continue"},{"line_number":2823,"context_line":"            except exception.NotFound:"},{"line_number":2824,"context_line":"                continue"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"            new_val_uuids \u003d [val_uuid for val_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"00b269de_5679d0f4","line":2823,"updated":"2026-03-05 12:41:48.000000000","message":"Shouldn\u0027t we log the exceptions in all the cases handled here?","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"053f7bbb8ffe2cdf8cbd4c52df606d91c7dbd15f","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                result \u003d self.db.share_metadata_get_item(context, uuid, key)"},{"line_number":2821,"context_line":"            except exception.MetadataItemNotFound:"},{"line_number":2822,"context_line":"                continue"},{"line_number":2823,"context_line":"            except exception.NotFound:"},{"line_number":2824,"context_line":"                continue"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"            new_val_uuids \u003d [val_uuid for val_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"1e71d822_fb93f26f","line":2823,"in_reply_to":"00b269de_5679d0f4","updated":"2026-03-05 12:51:08.000000000","message":"its fine, we dont need to log them. Its end part of share deletion and no need to log for the shares which are already gone.","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"da6993cbe93fb5d26ec109d36fa24459bcb3689d","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                result \u003d self.db.share_metadata_get_item(context, uuid, key)"},{"line_number":2821,"context_line":"            except exception.MetadataItemNotFound:"},{"line_number":2822,"context_line":"                continue"},{"line_number":2823,"context_line":"            except exception.NotFound:"},{"line_number":2824,"context_line":"                continue"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"            new_val_uuids \u003d [val_uuid for val_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"2b40b878_97315ffe","line":2823,"in_reply_to":"125ec4c6_53686a52","updated":"2026-03-05 13:49:07.000000000","message":"the share is already deleted, why do we need logging. Its confusing.","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1d2f99b8af3f080b22b4ce3a65d1a4b128cd59b9","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                result \u003d self.db.share_metadata_get_item(context, uuid, key)"},{"line_number":2821,"context_line":"            except exception.MetadataItemNotFound:"},{"line_number":2822,"context_line":"                continue"},{"line_number":2823,"context_line":"            except exception.NotFound:"},{"line_number":2824,"context_line":"                continue"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"            new_val_uuids \u003d [val_uuid for val_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"125ec4c6_53686a52","line":2823,"in_reply_to":"1e71d822_fb93f26f","updated":"2026-03-05 13:47:14.000000000","message":"I tend to agree with Anoop here - if it was not found, maybe it deserves some logging. I am fine with the whole approach though.","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f678993dcfc660c8b9e48b1b28816ee1b8404393","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                result \u003d self.db.share_metadata_get_item(context, uuid, key)"},{"line_number":2821,"context_line":"            except exception.MetadataItemNotFound:"},{"line_number":2822,"context_line":"                continue"},{"line_number":2823,"context_line":"            except exception.NotFound:"},{"line_number":2824,"context_line":"                continue"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"            new_val_uuids \u003d [val_uuid for val_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"edc4ca7f_efc368b0","line":2823,"in_reply_to":"2b40b878_97315ffe","updated":"2026-03-05 14:54:33.000000000","message":"Shouldn\u0027t be confusing, but I\u0027m fine merging it like this too","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"12df85b4bcc94f233126ec56721e28791547c792","unresolved":false,"context_lines":[{"line_number":2820,"context_line":"                result \u003d self.db.share_metadata_get_item(context, uuid, key)"},{"line_number":2821,"context_line":"            except exception.MetadataItemNotFound:"},{"line_number":2822,"context_line":"                continue"},{"line_number":2823,"context_line":"            except exception.NotFound:"},{"line_number":2824,"context_line":"                continue"},{"line_number":2825,"context_line":""},{"line_number":2826,"context_line":"            new_val_uuids \u003d [val_uuid for val_uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"d7b240ba_44ac4151","line":2823,"in_reply_to":"edc4ca7f_efc368b0","updated":"2026-03-05 15:27:57.000000000","message":"Kiran, the idea of a log is to assert that we did not find the share and it is previously deleted. I am okay to not address this as of now, but I see that handling exceptions in the file have been consistently logged. Since we are \"eating up\" this error, which was previously not handled, a log would have been good. But I discussed with Goutham and Carlos in bugsqash and we discussed for it to be okay as its not done for other exceptions as well and to avoid the noise.","commit_id":"37217c36fa32ef59d39c2517a4adb5788ba1681e"}],"releasenotes/notes/bug-2034925-Fix-deletion-of-scheduler-hints-when-share-not-found-ee7bb7fa740be74c.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6cbf95ea935d9a0dc8464aac1e566e834b7b6a26","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    When scheduler hint of share is deleted, the hint of shares mentioned as"},{"line_number":5,"context_line":"    hint in primary share are also updated to delete the UUID of primary share."},{"line_number":6,"context_line":"    Manila is fixed to handle the scenario when secondary shares are already"},{"line_number":7,"context_line":"    gone by handling NotFound exception. For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug #2034925 \u003chttps://bugs.launchpad.net/manila/+bug/2034925\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e5fa67ec_0e9d1acd","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":39},"updated":"2026-03-03 18:56:39.000000000","message":"I think we could drop this statement as it is a code detail.\n```suggestion\n    gone. For more details, please refer to\n```","commit_id":"acd191c4cce799c989f2d32d3c9976c2759cd5ef"},{"author":{"_account_id":36521,"name":"Chandrakanth Renduchintala","display_name":"Chandra R","email":"vnr.chandrakanth@gmail.com","username":"crenduchintala88"},"change_message_id":"acd31f87c096c0e6ce7a7136e6c3868517c941cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    When scheduler hint of share is deleted, the hint of shares mentioned as"},{"line_number":5,"context_line":"    hint in primary share are also updated to delete the UUID of primary share."},{"line_number":6,"context_line":"    Manila is fixed to handle the scenario when secondary shares are already"},{"line_number":7,"context_line":"    gone by handling NotFound exception. For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug #2034925 \u003chttps://bugs.launchpad.net/manila/+bug/2034925\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f8225582_5c5b3578","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":39},"in_reply_to":"e5fa67ec_0e9d1acd","updated":"2026-03-03 21:40:52.000000000","message":"Fix applied.","commit_id":"acd191c4cce799c989f2d32d3c9976c2759cd5ef"}]}