)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"e903ca35219989815d23bc7ca6341b6df92e3df8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: Implement share network subnet metadata update method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consider metadata \u0027showmount\u0027 and use existing method update_showmount()"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/c/openstack/manila/+/929091"},{"line_number":12,"context_line":"Partially-implements: blueprint pass-resource-metadata-updates-to-backend-drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f7089be8_150a31a9","line":9,"updated":"2025-02-27 16:02:01.000000000","message":"Please also mention pnfs","commit_id":"52dcce91f5ad8032d5b2987b3005e3ab2afeb329"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"63facf625e7232ebea68b8eeb5c6a3b1d49a39dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: Implement share network subnet metadata update method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Consider metadata \u0027showmount\u0027 and use existing method update_showmount()"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/c/openstack/manila/+/929091"},{"line_number":12,"context_line":"Partially-implements: blueprint pass-resource-metadata-updates-to-backend-drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b7b220c0_d1df2b7e","line":9,"in_reply_to":"f7089be8_150a31a9","updated":"2025-02-27 16:44:07.000000000","message":"Done","commit_id":"52dcce91f5ad8032d5b2987b3005e3ab2afeb329"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a59fa10cd916fdfbef48cc143af9af908665b72f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8904de48_c7aa9de6","updated":"2025-02-27 14:09:15.000000000","message":"Thanks for proposing this change separately. Please take a look at the comment inline","commit_id":"09f33520f6a45656515b13e12dcd09f37bcf0d36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"28fc4a5f7a92abb5ebb5de85b61fa2f8d1d16633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2b341429_fe169135","updated":"2025-02-27 20:25:15.000000000","message":"Thanks, PTAL at the comments inline","commit_id":"fd53eab21c72d4ee91ce5f7343d7de4432aaff85"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"4cdbf5af0139cab83d3f492da1ede525105f3738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc936e2e_be914545","updated":"2025-02-28 11:58:46.000000000","message":"Thanks Kiran for on working on this, I have few comments, please check those, if applicable please resolved those.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"38b6744fe6d7656efac3573bb1a80e6cd84cbc5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e99a34e0_72072ff0","updated":"2025-03-04 08:24:01.000000000","message":"LGTM - Gireesh, can you please ack this change? :)","commit_id":"f02c422fc990474c53df53866b4a85a47fcc04ad"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1a6a7ccf78a4f5523c34140213914e8fa957be7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c29acd6d_f2623c30","updated":"2025-03-04 09:11:39.000000000","message":"LGTM ..!","commit_id":"f02c422fc990474c53df53866b4a85a47fcc04ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4aa97e2e59a150185b4e0f8412f3000ab69babae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b76598c3_cd8370fe","updated":"2025-03-03 21:55:46.000000000","message":"Thanks; i\u0027ve no problem with this change if NetApp folks are okay with it..","commit_id":"f02c422fc990474c53df53866b4a85a47fcc04ad"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"4cdbf5af0139cab83d3f492da1ede525105f3738","unresolved":true,"context_lines":[{"line_number":4760,"context_line":"        \"\"\"Update pNFS for vserver. \"\"\""},{"line_number":4761,"context_line":"        # Get SVM UUID."},{"line_number":4762,"context_line":"        query \u003d {"},{"line_number":4763,"context_line":"            \u0027name\u0027: self.vserver,"},{"line_number":4764,"context_line":"            \u0027fields\u0027: \u0027uuid\u0027"},{"line_number":4765,"context_line":"        }"},{"line_number":4766,"context_line":"        res \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4767,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":4768,"context_line":"            msg \u003d _(\u0027Vserver %s not found.\u0027) % self.vserver"},{"line_number":4769,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4770,"context_line":"        svm_id \u003d res.get(\u0027records\u0027)[0][\u0027uuid\u0027]"},{"line_number":4771,"context_line":""},{"line_number":4772,"context_line":"        body \u003d {"},{"line_number":4773,"context_line":"            \u0027protocol.v41_features.pnfs_enabled\u0027: pnfs,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4bf5dfe5_518a2aa7","line":4770,"range":{"start_line":4763,"start_character":8,"end_line":4770,"end_character":46},"updated":"2025-02-28 11:58:46.000000000","message":"Can you add one private method to get the vserver uuid, I hope that will be used by many function in future also.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ece1bb552c50dc1763f6ccf22818bda1ec1398b1","unresolved":false,"context_lines":[{"line_number":4760,"context_line":"        \"\"\"Update pNFS for vserver. \"\"\""},{"line_number":4761,"context_line":"        # Get SVM UUID."},{"line_number":4762,"context_line":"        query \u003d {"},{"line_number":4763,"context_line":"            \u0027name\u0027: self.vserver,"},{"line_number":4764,"context_line":"            \u0027fields\u0027: \u0027uuid\u0027"},{"line_number":4765,"context_line":"        }"},{"line_number":4766,"context_line":"        res \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4767,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":4768,"context_line":"            msg \u003d _(\u0027Vserver %s not found.\u0027) % self.vserver"},{"line_number":4769,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4770,"context_line":"        svm_id \u003d res.get(\u0027records\u0027)[0][\u0027uuid\u0027]"},{"line_number":4771,"context_line":""},{"line_number":4772,"context_line":"        body \u003d {"},{"line_number":4773,"context_line":"            \u0027protocol.v41_features.pnfs_enabled\u0027: pnfs,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a71fe1e5_c5a4a090","line":4770,"range":{"start_line":4763,"start_character":8,"end_line":4770,"end_character":46},"in_reply_to":"4bf5dfe5_518a2aa7","updated":"2025-02-28 12:13:38.000000000","message":"that enhancement is not related to this, might be some code optimization follow-up patch would be good idea.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_single_svm.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"4cdbf5af0139cab83d3f492da1ede525105f3738","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        self.library.update_share_from_metadata("},{"line_number":369,"context_line":"            context, share, metadata, share_server\u003dshare_server)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def update_share_network_subnet_from_metadata(self, context,"},{"line_number":372,"context_line":"                                                  share_network,"},{"line_number":373,"context_line":"                                                  share_network_subnet,"},{"line_number":374,"context_line":"                                                  share_server, metadata):"},{"line_number":375,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":5,"id":"56331b33_e4f261e6","line":375,"range":{"start_line":371,"start_character":4,"end_line":375,"end_character":33},"updated":"2025-02-28 11:58:46.000000000","message":"I don\u0027t think this line of code ever executed. This code will be executed only for dhss_false and for dhss_false we don\u0027t have share_network and share server. \nI don\u0027t think it is require, Gautham and Caloss are right person to comment on this.\n\nEven same is applicable for above method, update_share_from_metadata","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d92ef24c281a08d4812cf80538d2279e8d4d1dbb","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        self.library.update_share_from_metadata("},{"line_number":369,"context_line":"            context, share, metadata, share_server\u003dshare_server)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def update_share_network_subnet_from_metadata(self, context,"},{"line_number":372,"context_line":"                                                  share_network,"},{"line_number":373,"context_line":"                                                  share_network_subnet,"},{"line_number":374,"context_line":"                                                  share_server, metadata):"},{"line_number":375,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":5,"id":"d3648e57_8b0833db","line":375,"range":{"start_line":371,"start_character":4,"end_line":375,"end_character":33},"in_reply_to":"1fc637b8_eb50b052","updated":"2025-02-28 16:13:21.000000000","message":"Normally, we use this exception when this method/interface declare in parent class and child class has to implement this and method must need to implement in child class.\n\nIn my opinion, we should throw an exception with a detailed error message that informs the user a misconfiguration has occurred. This method should only be executed as an indication that an unexpected misconfiguration has triggered code that should not normally run.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ece1bb552c50dc1763f6ccf22818bda1ec1398b1","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        self.library.update_share_from_metadata("},{"line_number":369,"context_line":"            context, share, metadata, share_server\u003dshare_server)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def update_share_network_subnet_from_metadata(self, context,"},{"line_number":372,"context_line":"                                                  share_network,"},{"line_number":373,"context_line":"                                                  share_network_subnet,"},{"line_number":374,"context_line":"                                                  share_server, metadata):"},{"line_number":375,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fc637b8_eb50b052","line":375,"range":{"start_line":371,"start_character":4,"end_line":375,"end_character":33},"in_reply_to":"56331b33_e4f261e6","updated":"2025-02-28 12:13:38.000000000","message":"With dhss_false, its not expected to support, that is why NotImplementedError.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"5f061bcbf70d31fe51e443934a36d8378d854fd1","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        self.library.update_share_from_metadata("},{"line_number":369,"context_line":"            context, share, metadata, share_server\u003dshare_server)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def update_share_network_subnet_from_metadata(self, context,"},{"line_number":372,"context_line":"                                                  share_network,"},{"line_number":373,"context_line":"                                                  share_network_subnet,"},{"line_number":374,"context_line":"                                                  share_server, metadata):"},{"line_number":375,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":5,"id":"a7eb2088_0d6d3440","line":375,"range":{"start_line":371,"start_character":4,"end_line":375,"end_character":33},"in_reply_to":"9f7c7322_fc768861","updated":"2025-03-04 09:14:44.000000000","message":"I am fine with this now","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4aa97e2e59a150185b4e0f8412f3000ab69babae","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        self.library.update_share_from_metadata("},{"line_number":369,"context_line":"            context, share, metadata, share_server\u003dshare_server)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def update_share_network_subnet_from_metadata(self, context,"},{"line_number":372,"context_line":"                                                  share_network,"},{"line_number":373,"context_line":"                                                  share_network_subnet,"},{"line_number":374,"context_line":"                                                  share_server, metadata):"},{"line_number":375,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f7c7322_fc768861","line":375,"range":{"start_line":371,"start_character":4,"end_line":375,"end_character":33},"in_reply_to":"d3648e57_8b0833db","updated":"2025-03-03 21:55:46.000000000","message":"think Kiran\u0027s following the same pattern as other methods here: https://github.com/openstack/manila/blob/548593328f43fca0dd6e82a53239d3f40998f287/manila/share/drivers/netapp/dataontap/cluster_mode/drv_single_svm.py#L87-L99\n\nso this is fine.. it\u0027s probably not necessary because we won\u0027t invoke this method with a DHSS\u003dFalse driver.. but, its not harmful either","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a59fa10cd916fdfbef48cc143af9af908665b72f","unresolved":true,"context_lines":[{"line_number":5204,"context_line":"        }"},{"line_number":5205,"context_line":""},{"line_number":5206,"context_line":"        for k, v in metadata.items():"},{"line_number":5207,"context_line":"            update_func \u003d getattr(self, metadata_update_func_map.get(k))"},{"line_number":5208,"context_line":"            if update_func:"},{"line_number":5209,"context_line":"                update_func(v, share_server\u003dshare_server)"},{"line_number":5210,"context_line":""},{"line_number":5211,"context_line":"    @na_utils.trace"},{"line_number":5212,"context_line":"    def _get_aggregate_snaplock_type(self, aggr_name):"},{"line_number":5213,"context_line":"        if self._have_cluster_creds:"}],"source_content_type":"text/x-python","patch_set":1,"id":"454b5a32_da9c09c3","line":5210,"range":{"start_line":5207,"start_character":12,"end_line":5210,"end_character":1},"updated":"2025-02-27 14:09:15.000000000","message":"if metadata sets something other than showmount or pnfs this will fail, as get(k) will return None, and we will send None to getattr. I suggest a different approach:\n\n```suggestion\n            metadata_update_method \u003d (\n                getattr(self, metadata_update_func_map.get(k)\n                if k in metadata_update_func_map.keys()\n                else None\n            )\n            if metadata_update_method:\n                update_func(v, share_server\u003dshare_server)\n\n```","commit_id":"09f33520f6a45656515b13e12dcd09f37bcf0d36"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7ec1d082241f33bc3b013de783a8c34b87af2c00","unresolved":false,"context_lines":[{"line_number":5204,"context_line":"        }"},{"line_number":5205,"context_line":""},{"line_number":5206,"context_line":"        for k, v in metadata.items():"},{"line_number":5207,"context_line":"            update_func \u003d getattr(self, metadata_update_func_map.get(k))"},{"line_number":5208,"context_line":"            if update_func:"},{"line_number":5209,"context_line":"                update_func(v, share_server\u003dshare_server)"},{"line_number":5210,"context_line":""},{"line_number":5211,"context_line":"    @na_utils.trace"},{"line_number":5212,"context_line":"    def _get_aggregate_snaplock_type(self, aggr_name):"},{"line_number":5213,"context_line":"        if self._have_cluster_creds:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d75a1356_e31ac60c","line":5210,"range":{"start_line":5207,"start_character":12,"end_line":5210,"end_character":1},"in_reply_to":"454b5a32_da9c09c3","updated":"2025-02-27 14:25:09.000000000","message":"Done","commit_id":"09f33520f6a45656515b13e12dcd09f37bcf0d36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"28fc4a5f7a92abb5ebb5de85b61fa2f8d1d16633","unresolved":true,"context_lines":[{"line_number":5168,"context_line":"    @na_utils.trace"},{"line_number":5169,"context_line":"    def update_showmount(self, showmount, share_server\u003dNone):"},{"line_number":5170,"context_line":"        showmount \u003d showmount.lower()"},{"line_number":5171,"context_line":"        if showmount not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5172,"context_line":"            return"},{"line_number":5173,"context_line":""},{"line_number":5174,"context_line":"        _, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":5175,"context_line":"        vserver_client.update_showmount(showmount)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7fa7fc47_8dc7f85a","line":5172,"range":{"start_line":5171,"start_character":8,"end_line":5172,"end_character":18},"updated":"2025-02-27 20:25:15.000000000","message":"This should be logged and an error must be raised so you can trigger the failure user message in the share manager.","commit_id":"fd53eab21c72d4ee91ce5f7343d7de4432aaff85"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a718f0ff0d64a59093ed1be9403237ca427b2857","unresolved":false,"context_lines":[{"line_number":5168,"context_line":"    @na_utils.trace"},{"line_number":5169,"context_line":"    def update_showmount(self, showmount, share_server\u003dNone):"},{"line_number":5170,"context_line":"        showmount \u003d showmount.lower()"},{"line_number":5171,"context_line":"        if showmount not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5172,"context_line":"            return"},{"line_number":5173,"context_line":""},{"line_number":5174,"context_line":"        _, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":5175,"context_line":"        vserver_client.update_showmount(showmount)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e9952e3_e2f3379a","line":5172,"range":{"start_line":5171,"start_character":8,"end_line":5172,"end_character":18},"in_reply_to":"7fa7fc47_8dc7f85a","updated":"2025-02-28 07:11:18.000000000","message":"Done","commit_id":"fd53eab21c72d4ee91ce5f7343d7de4432aaff85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"28fc4a5f7a92abb5ebb5de85b61fa2f8d1d16633","unresolved":true,"context_lines":[{"line_number":5176,"context_line":""},{"line_number":5177,"context_line":"    def update_pnfs(self, pnfs, share_server\u003dNone):"},{"line_number":5178,"context_line":"        pnfs \u003d pnfs.lower()"},{"line_number":5179,"context_line":"        if pnfs not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5180,"context_line":"            return"},{"line_number":5181,"context_line":""},{"line_number":5182,"context_line":"        _, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":5183,"context_line":"        vserver_client.update_pnfs(pnfs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d920b73_1ecc1915","line":5180,"range":{"start_line":5179,"start_character":0,"end_line":5180,"end_character":18},"updated":"2025-02-27 20:25:15.000000000","message":"same as above","commit_id":"fd53eab21c72d4ee91ce5f7343d7de4432aaff85"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a718f0ff0d64a59093ed1be9403237ca427b2857","unresolved":false,"context_lines":[{"line_number":5176,"context_line":""},{"line_number":5177,"context_line":"    def update_pnfs(self, pnfs, share_server\u003dNone):"},{"line_number":5178,"context_line":"        pnfs \u003d pnfs.lower()"},{"line_number":5179,"context_line":"        if pnfs not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5180,"context_line":"            return"},{"line_number":5181,"context_line":""},{"line_number":5182,"context_line":"        _, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":5183,"context_line":"        vserver_client.update_pnfs(pnfs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f4a2115c_37428712","line":5180,"range":{"start_line":5179,"start_character":0,"end_line":5180,"end_character":18},"in_reply_to":"7d920b73_1ecc1915","updated":"2025-02-28 07:11:18.000000000","message":"Done","commit_id":"fd53eab21c72d4ee91ce5f7343d7de4432aaff85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"28fc4a5f7a92abb5ebb5de85b61fa2f8d1d16633","unresolved":true,"context_lines":[{"line_number":5186,"context_line":"    def update_share_from_metadata(self, context, share, metadata,"},{"line_number":5187,"context_line":"                                   share_server\u003dNone):"},{"line_number":5188,"context_line":"        metadata_update_func_map \u003d {"},{"line_number":5189,"context_line":"            \"snapshot_policy\": \"update_volume_snapshot_policy\","},{"line_number":5190,"context_line":"        }"},{"line_number":5191,"context_line":""},{"line_number":5192,"context_line":"        for k, v in metadata.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"c122118e_410c5a22","line":5189,"updated":"2025-02-27 20:25:15.000000000","message":"You\u0027re removing previously supported functionality.. how is this advertised/communicated to users?","commit_id":"fd53eab21c72d4ee91ce5f7343d7de4432aaff85"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a718f0ff0d64a59093ed1be9403237ca427b2857","unresolved":false,"context_lines":[{"line_number":5186,"context_line":"    def update_share_from_metadata(self, context, share, metadata,"},{"line_number":5187,"context_line":"                                   share_server\u003dNone):"},{"line_number":5188,"context_line":"        metadata_update_func_map \u003d {"},{"line_number":5189,"context_line":"            \"snapshot_policy\": \"update_volume_snapshot_policy\","},{"line_number":5190,"context_line":"        }"},{"line_number":5191,"context_line":""},{"line_number":5192,"context_line":"        for k, v in metadata.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"be34d137_de35f851","line":5189,"in_reply_to":"c122118e_410c5a22","updated":"2025-02-28 07:11:18.000000000","message":"Done","commit_id":"fd53eab21c72d4ee91ce5f7343d7de4432aaff85"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"4cdbf5af0139cab83d3f492da1ede525105f3738","unresolved":true,"context_lines":[{"line_number":5168,"context_line":"    @na_utils.trace"},{"line_number":5169,"context_line":"    def update_showmount(self, showmount, share_server\u003dNone):"},{"line_number":5170,"context_line":"        showmount \u003d showmount.lower()"},{"line_number":5171,"context_line":"        if showmount not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5172,"context_line":"            err_msg \u003d _(\"Invalid showmount value supplied: %s.\") % showmount"},{"line_number":5173,"context_line":"            raise exception.NetAppException(err_msg)"},{"line_number":5174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7686923a_3d458190","line":5171,"range":{"start_line":5171,"start_character":8,"end_line":5171,"end_character":46},"updated":"2025-02-28 11:58:46.000000000","message":"not sure but I think it should be \n if showmount not in (True, False):\n \n Did you tested this part...? Are we able to set the value on ONTAP if we are passing \"true\", if not we need to change it to bool while passing to update_showmount method.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ece1bb552c50dc1763f6ccf22818bda1ec1398b1","unresolved":false,"context_lines":[{"line_number":5168,"context_line":"    @na_utils.trace"},{"line_number":5169,"context_line":"    def update_showmount(self, showmount, share_server\u003dNone):"},{"line_number":5170,"context_line":"        showmount \u003d showmount.lower()"},{"line_number":5171,"context_line":"        if showmount not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5172,"context_line":"            err_msg \u003d _(\"Invalid showmount value supplied: %s.\") % showmount"},{"line_number":5173,"context_line":"            raise exception.NetAppException(err_msg)"},{"line_number":5174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5cfe1c4e_01c9f0fa","line":5171,"range":{"start_line":5171,"start_character":8,"end_line":5171,"end_character":46},"in_reply_to":"7686923a_3d458190","updated":"2025-02-28 12:13:38.000000000","message":"check other implementations, its true/false and not \u0027True/False\u0027 for both cmode and cmode_rest.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"4cdbf5af0139cab83d3f492da1ede525105f3738","unresolved":true,"context_lines":[{"line_number":5177,"context_line":""},{"line_number":5178,"context_line":"    def update_pnfs(self, pnfs, share_server\u003dNone):"},{"line_number":5179,"context_line":"        pnfs \u003d pnfs.lower()"},{"line_number":5180,"context_line":"        if pnfs not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5181,"context_line":"            err_msg \u003d _(\"Invalid pnfs value supplied: %s.\") % pnfs"},{"line_number":5182,"context_line":"            raise exception.NetAppException(err_msg)"},{"line_number":5183,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"beca2fc2_9900e85b","line":5180,"range":{"start_line":5180,"start_character":8,"end_line":5180,"end_character":41},"updated":"2025-02-28 11:58:46.000000000","message":"Same as above.","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ece1bb552c50dc1763f6ccf22818bda1ec1398b1","unresolved":false,"context_lines":[{"line_number":5177,"context_line":""},{"line_number":5178,"context_line":"    def update_pnfs(self, pnfs, share_server\u003dNone):"},{"line_number":5179,"context_line":"        pnfs \u003d pnfs.lower()"},{"line_number":5180,"context_line":"        if pnfs not in (\u0027true\u0027, \u0027false\u0027):"},{"line_number":5181,"context_line":"            err_msg \u003d _(\"Invalid pnfs value supplied: %s.\") % pnfs"},{"line_number":5182,"context_line":"            raise exception.NetAppException(err_msg)"},{"line_number":5183,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"69a43c1a_52a3dc5a","line":5180,"range":{"start_line":5180,"start_character":8,"end_line":5180,"end_character":41},"in_reply_to":"beca2fc2_9900e85b","updated":"2025-02-28 12:13:38.000000000","message":"Acknowledged","commit_id":"da6a80465af0d3fb089fc7cd0de38a7100426ed0"}],"releasenotes/notes/netapp-add-update-from-network-subnet-metadata-method-0615490d86958c3d.yaml":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"e903ca35219989815d23bc7ca6341b6df92e3df8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The NetApp ONTAP driver is now able to update the `showmount` and"},{"line_number":5,"context_line":"    `pnfs` configurations in a pre-created share server. Please use the"},{"line_number":6,"context_line":"    share network subnet metadata set feature to update these values."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"062392c0_2acf676c","line":4,"updated":"2025-02-27 16:02:01.000000000","message":"I think it is worth mentioning that the valid values of those metadata keys are \u0027true\u0027/\u0027false\u0027","commit_id":"52dcce91f5ad8032d5b2987b3005e3ab2afeb329"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"63facf625e7232ebea68b8eeb5c6a3b1d49a39dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The NetApp ONTAP driver is now able to update the `showmount` and"},{"line_number":5,"context_line":"    `pnfs` configurations in a pre-created share server. Please use the"},{"line_number":6,"context_line":"    share network subnet metadata set feature to update these values."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5eea3d78_b59bfc3e","line":4,"in_reply_to":"062392c0_2acf676c","updated":"2025-02-27 16:44:07.000000000","message":"Done","commit_id":"52dcce91f5ad8032d5b2987b3005e3ab2afeb329"}]}