)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f27de6cecb5545ae8f9c999f3b08e725372e825a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a140cb0_272b6c06","updated":"2025-03-05 09:05:02.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5158e10939cf3642e663ebeede43c85c569ce12d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1bb0a2a5_ba51fb3d","updated":"2025-03-06 21:33:35.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1c17b9e35fb50ad34e520a7faf8fe9a804d4bd86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"230f3858_b3313709","updated":"2025-03-05 12:31:59.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e2d2d4ebb6da6566c19b603396a3708a5d797919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"359ad2d1_e63b3562","updated":"2025-03-05 09:55:06.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e270cd0f79e30eda2707ffea1253dcd95521ff43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ae3c047_6e50081e","updated":"2025-03-08 06:39:47.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"10d5b3f39a9dcb7b721ffc8f12af17fe97272d93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"516ec4e4_86de0da7","updated":"2025-03-05 13:41:33.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"01e9634033ceb810632aa49a6795f43edad55d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c67037a_707a5b42","updated":"2025-03-06 20:34:28.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"0e3c7a58a8ac75789f9aef02a3fe927ffa119e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6228705c_ee3e2193","updated":"2025-03-07 12:27:29.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"76207c8feec04d49262c6c4c3822ab077d910f95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6da98880_247ec192","updated":"2025-03-06 05:32:57.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7c83d8b12dfa229e0db3eb804fc1f219389ff7c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8afb8a32_acf56418","updated":"2025-03-05 08:54:21.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"73c6c820624c359701db3d917732ddee68d3026b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93034cce_c58dd346","updated":"2025-03-05 08:38:22.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"da7661c89604816980d3031e11832bbb2fac27b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"944125a4_eb9260e6","updated":"2025-03-05 13:07:15.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e838dd35f50827b431b349275e633be3bc0a52c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdf6e0eb_c13ac0ea","updated":"2025-03-05 11:30:22.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"26ea6bf3171c29012a3ba08c8b6cc5063ed05366","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cb88a191_5713f86d","updated":"2025-03-05 08:03:13.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ce8db6292b23f765535ea6b758d7686a6e702aa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d59ff878_4f32fe70","updated":"2025-03-07 18:05:21.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6bbe10b65beb48f27745b038d29a3bc0f0ebe1b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da3bc8c3_f777a21f","updated":"2025-03-06 20:56:40.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1a3f4fd50e991ae1316104557605acb87612481d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dad58cbe_4897ecee","updated":"2025-03-07 18:36:44.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f804c772b989ad62affa9c10bba20dd73dd649c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9b6be24_885f7ad5","updated":"2025-03-05 08:19:24.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"cecd46070b7efcfdfd8dad7bfbe81adc38d893c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3389dd2_e76f8618","updated":"2025-03-05 08:28:06.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b8d9ebc18cfc0c219627e5482630dd660070eea6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe1df2a6_caec01d8","updated":"2025-03-06 20:25:17.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c3ade179cb3febd55af3a8000415591e023d3"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"65c259604575a11b1bb50c763c67729fd2b80554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"30654c48_9bff21cd","updated":"2025-03-26 16:44:09.000000000","message":"run-DellEMC PowerScale CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"a8d562b3ab16dd34f84e66e99d0fe80e68ad5768","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9bd380a1_b77aa36a","updated":"2025-03-26 09:03:05.000000000","message":"run-DellEMC PowerScale CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"52dd0599c923310e26ce70c184aebed910af9b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ad7fba2b_c299c8b7","updated":"2025-03-26 14:18:06.000000000","message":"run-DellEMC PowerScale CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"442d73a8ee66a01eb21538bcc62b5ed46d661876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb266440_00f42e08","updated":"2025-03-20 08:24:46.000000000","message":"run-DellEMC PowerScale CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"109351fe8708d7c008290644627f471cf075aac6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c1bca255_b926ac3d","updated":"2025-03-25 12:52:17.000000000","message":"run-DellEMC PowerScale CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"c749fe49cd2b106240768314e533181d234c898d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c2e293c7_c5f3dfa6","updated":"2025-03-26 12:30:59.000000000","message":"run-DellEMC PowerScale CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"aa1560525ed43d46d51e30242bbbf396c74abed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4c77434_f8319cc2","updated":"2025-03-26 09:18:20.000000000","message":"run-DellEMC PowerScale CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5ccff964e2f145d403a7004f27f9492ff3b578a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"08526841_b461680b","updated":"2025-03-26 09:22:18.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2516c942d62b31ac51614d33641bb35b8aed4630","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"271f5f8e_c4780ff9","updated":"2025-03-26 11:04:23.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"728562423464a11207b8d1f590bafddf3a24281f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e060312_fc06c7b6","updated":"2025-03-26 12:59:52.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"90d400d71f7ea2e3e4f3109fc6a69fe3061b6c8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"657934f0_2ceca789","updated":"2025-03-19 16:07:42.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"bf34146bfdc41e31c0bf5cf06d83843102d6d560","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"69794a99_18455c8c","updated":"2025-03-26 11:41:04.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a9ed1ca18e9c4f09c67d792333d00423b37e3bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7e48b82c_549bb337","updated":"2025-03-26 09:09:49.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f2da38fbc291ddfdc86593f09c8aa00cbcdf22ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89f0647f_063932ab","updated":"2025-03-19 21:27:14.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"cc0b94278f07d59e96ab871a66db5abd0349da21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b04f5e92_3432870a","updated":"2025-03-26 12:22:54.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2e67294004c8bfdd56849850d818ea5e0681038f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d645ba5d_71c989bd","updated":"2025-03-26 10:08:22.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f27b08ea731e57bb1be8e1613e85dc460d1071c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee202409_0b1093fd","updated":"2025-03-26 13:43:59.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f7f44ec8100ce008d0cebddedbc49c9cce66c2b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0d2af8f8_a1c08d3b","updated":"2025-03-21 11:25:34.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"41ead74d3b7206aa4ea5b5469edf4aced075d717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"401e0177_a2050c73","updated":"2025-03-24 19:58:34.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"3a491c8c0bdcbaf050afbd86fce79c280006a534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4297f436_3ced2a1c","updated":"2025-03-25 14:10:43.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7e08540d4c26a5827c4e36dcd50a5c8de927ff49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45b73f85_91467bbe","updated":"2025-03-21 09:26:45.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"2af1ab823793344bec0c485324e23ae1b7dff526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"69206364_0c0e3277","updated":"2025-03-24 12:56:23.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"2aad288fa61ffc2839d0fac3342a7b5959f0d1a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"823887a3_4a6f22e4","updated":"2025-03-21 11:20:24.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"600ed00d61b5fe3041d83ba4f95a4035fd2b5f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"966458af_44351a41","updated":"2025-03-25 15:07:28.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"9b9bbf1b48b21354dd1b001b91fb51694007c2af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a8c0f2fc_9cd12ceb","updated":"2025-03-24 14:08:56.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"9c9914fb4fcac15f54b2e5c2ffbf78f2ba83b699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba070aa6_bbbe3881","updated":"2025-03-21 16:11:07.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"455813d30617651bdab7ffa5365abcbe04417087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df4d0e0e_49b1143c","updated":"2025-03-20 08:29:34.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"82c6febeac1ab23498e8e51944b0ea00ffce36aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e1439df1_2e2ac998","updated":"2025-03-24 11:58:47.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"105e743c091e704999bdcc8a1c572ff7ed1f5187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e549d9e7_2c80f62d","updated":"2025-03-21 13:21:41.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6069e56cd704c59469aa4df59096543ccabf4709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f1e6602a_ed6ec4d2","updated":"2025-03-24 14:16:07.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"e0d44830e9702a529992148974b0b3aaa8dd27a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f74b88f0_35ab1949","updated":"2025-03-25 16:15:40.000000000","message":"run-DellEMC PowerStore CI","commit_id":"40e07ba30ba7dc002e7fd2c536b9914d78003542"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"9e244832bf7315d5e5c7bee96913b5e38c312e86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c482c356_5c005d2a","updated":"2025-03-27 18:55:39.000000000","message":"run-DellEMC PowerStore CI","commit_id":"6c359bba886082772ae0204a611c2c309024c72c"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"74241b3ff3a8e3925e462ba54b9c2a9c0031ca33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e541b70_87c3336b","updated":"2025-04-07 05:58:08.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3414a2901d5cdba6e7cebd21aed92bc99a310074"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1c3b37745216da562628e9ad4eff2a52ac20c98a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"565e4fff_3bf5f8b2","updated":"2025-04-08 07:08:58.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3414a2901d5cdba6e7cebd21aed92bc99a310074"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ff13e16f5bcae77c193c03a413187dde8fa55d54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"959a47fa_04b97b2f","updated":"2025-04-08 16:39:31.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3414a2901d5cdba6e7cebd21aed92bc99a310074"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"5bf42b5f2f7682c9f3ccfa57abebf57aa5f8ef1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf24a860_efb7ebc5","updated":"2025-04-08 07:08:14.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3414a2901d5cdba6e7cebd21aed92bc99a310074"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"93bd68d358584e0298c889a0db8ed198f9df037a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d4e7f880_cc0fa777","updated":"2025-04-08 04:16:30.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3414a2901d5cdba6e7cebd21aed92bc99a310074"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"14d796e841d2ec2ba284491a3bfe35e3464eb9b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dc87306c_20e3026a","updated":"2025-04-08 13:19:01.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3414a2901d5cdba6e7cebd21aed92bc99a310074"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"90c4ccdc4cda1f8fab8e7c26edd931425af4973a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"466e7f1e_f30641c3","updated":"2025-04-14 19:40:24.000000000","message":"hey @yian.zong@dell.com: \n\nI can\u0027t access the Dell PowerScale CI results; for example: http://10.228.225.16:9000/t/openstack/build/797c1e7936c44bd0a845839b62d1043a\n\nIt looks like a private IP.. CI results need to be publicly accessible; can you fix this?","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"d9aebbac18e6d6c4b9e402bdf8427e869620a99e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0fb7f68b_4b589892","updated":"2025-04-15 08:03:21.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a346017b5a7df4fb2d9ccdd4202392a7d5a73bd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"100d22ab_f9d6a7fe","updated":"2025-04-14 06:41:52.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"dffcd01e010097d8b4bd24b3fad17d91c84cb87d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4d795b84_d2d77949","updated":"2025-04-15 08:55:47.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"7fd3d9873e443bf706be515321cfe83b8874e51a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6ec2ab1d_c360712d","updated":"2025-04-15 08:44:08.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"dd002c26007738234efe0a3819a05c4acf58766b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8911d9fd_889cc95e","updated":"2025-04-15 08:06:44.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"dff29670d5d7f22af430b211a8d9318a25fc5e96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9bc15104_1993d81a","updated":"2025-04-14 06:58:52.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ccc31916064a58de85f2c2664bab698d592bc32c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9dd677e7_6059400a","updated":"2025-04-15 08:10:25.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e28626c170e323035721332579e01c69ad508499","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b0fc4a90_70a0e4fe","updated":"2025-05-13 04:48:26.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"da99bc3f7091a7d049128bcda171a6f2b68915f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bcef130e_e5c4c16b","updated":"2025-04-15 08:57:27.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"774ea6cb4397e4b28bb66ac83c7955eb9212f989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e1ebe2ac_10a647ba","updated":"2025-05-19 07:19:30.000000000","message":"run-DellEMC PowerScale CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"cbc7bbc4450a0ce4f9d9244a61c1ea584d269be9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4337a47b_b2651b84","updated":"2025-04-29 07:17:53.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ecbbe8874713a47285522bb78ca81843bef99a88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b5d6ace_7ab71b18","updated":"2025-04-29 06:11:39.000000000","message":"run-DellEMC PowerScale CI 1","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"a05fa94b0de4fe91f3e4dec4f7113a7f8c031e50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a7e7bad_f80d805a","updated":"2025-05-29 13:42:11.000000000","message":"run-DellEMC PowerStore CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6e88fe3faf7989cb479f5e85d91f95708e5de0a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f962963e_f3e5177e","updated":"2025-05-19 07:20:20.000000000","message":"run-DellEMC PowerStore CI","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"394f757771cc403ee1ba378fe665898d03db78bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f297885b_2e0b6dee","in_reply_to":"3138efa8_8fd05ce5","updated":"2025-06-25 13:54:41.000000000","message":"Hi @gouthampravi@gmail.com, @ces.eduardo98@gmail.com, @haixin_haixin@qq.com, @ashrod98@redhat.com,\n\nThe last CI result is publicly accessible now.\nPlease kindly review.\nThank you!","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"44995be00c5b674d80d00c79191c441f02a72480","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3138efa8_8fd05ce5","in_reply_to":"466e7f1e_f30641c3","updated":"2025-04-15 07:25:21.000000000","message":"Hi @gouthampravi@gmail.com,\nYes, we are working on making the CI results publicly accessible.\nIt will take some time to make it conform to the security policy.","commit_id":"183aaae10608d93ce7aaf5c907540098dd53f896"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"292f044329d6b2676c3c1b99f92493f0a257cbd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b30ac3e3_dca61440","updated":"2025-07-10 00:55:05.000000000","message":"Also, in your CI system, have you tried removing \"suppress_errors_in_cleanup \u003d True\" from tempest.conf? \n\nI see a lot of tracebacks in the manila-share log.. e.g.: https://paste.opendev.org/show/bWf6O0d4Qz38pVgiSDac/","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"53d384c1_320a2013","updated":"2025-07-10 00:47:56.000000000","message":"Hi some comments inline, ptal","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8ff18afa53e1e239e76e19a8539c7144aeecac1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7c6594d9_987427e0","updated":"2025-07-02 06:31:08.000000000","message":"Overall, everything looks great. Many functions have been optimized. There is only one comment.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80b84c29a55acc2465a88360e8ae05bf18a86d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"efc31f6b_fb592904","updated":"2025-07-08 18:32:10.000000000","message":"Thanks for working on the CI, please take a look at the additional comments inline and also to the request to split up this change","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"84c6c02b42c98065e1fa2fd2a7fb5c1d4c6b119c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6c45b17d_e35f765f","updated":"2025-07-08 18:17:14.000000000","message":"hi Yian, thanks for working on this change. My apologies on the time it took for me to get to this. I would like to ask you to please split up this change into multiple changes, as described in OpenStack\u0027s contributor guidelines [1]. Each fix and feature should be its own change. In summary, if we have all changes here, we won\u0027t be able to backport any of this code, if we need to revert something, we\u0027ll end up reverting all of the commits, and I do think a bunch of these fixes can be proposed to older releases. We can not backport features, so that will also block this change from being backported.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f7909cdd958af9a18ad945d1d7682d64af89a2d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0c18cd27_17425709","updated":"2025-06-11 17:46:25.000000000","message":"run-DellEMC PowerScale CI","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"2dcae479c960f4fa1e7c1cfe5a80284ad0533d5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"85588753_3a2cac3d","updated":"2025-06-25 13:44:53.000000000","message":"run-DellEMC PowerScale CI","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3f9c944829602bf4a16c5a1fc21a71f8c0771f58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"91880cea_34166690","updated":"2025-06-24 12:36:24.000000000","message":"run-DellEMC PowerScale CI","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ab6c234a6bed1339b093d3952fee604285ddd45a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"52e268bc_146568d5","in_reply_to":"0d296240_6b67384d","updated":"2025-07-24 15:14:17.000000000","message":"Yes, thank you for sharing your backport intentions. However, the fixes should also be proposed to other upstream branches, so that they can be available to all of the other deployment tools, not only RHOSO. If there\u0027s a customer deploying with Kolla, Charms or any other tool, we\u0027ll have issues to bring these fixes back to them as well, so I\u0027d prefer we split up this change into multiple patches.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ad08f35d3f5f119e8632980db2deb144fc742d1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6e3db904_a84f0154","in_reply_to":"52e268bc_146568d5","updated":"2025-07-25 05:33:08.000000000","message":"Removed support for `update share stats` and `ensure shares`.\nLeave fix for bug #2100829 in place.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"06166ad4fdd865b0b6d8630ee3145373d658e301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0d296240_6b67384d","in_reply_to":"6c45b17d_e35f765f","updated":"2025-07-09 06:55:55.000000000","message":"Hi @ces.eduardo98@gmail.com,\n\nThank you for reviewing!\n\nI understand your concerns.\nHowever, we don\u0027t plan to backport this patch upstream. The patch is targeting at upcoming RHOSO 18 per customer ask. We have verified this patch on RHOSO 18 by custom manila image.\nMeanwhile, we have other 2 patches [1][2] depend on this patch. Without this patch, those two couldn\u0027t pass the CI. Splitting up this patch might make the review and merge more complicated.\nGiven above reasons, can we keep it as one patch? \n\n[1] https://review.opendev.org/c/openstack/manila/+/947255\n[2] https://review.opendev.org/c/openstack/manila/+/921831","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1adf9b0bce2d0cf54ba86d14e96f3646f4c0cc61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"454daf49_fb858036","in_reply_to":"b30ac3e3_dca61440","updated":"2025-07-17 07:39:54.000000000","message":"The previous tracebacks in manila-share seems caused by a temporary disconnection from PowerScale at \u0027Jun 25 14:10:17\u0027. \n\nThe latest manila-share log is clean[1].\n\n[1] https://elab-os-logsrv.delllabs.net/b98/openstack/b98bc7f8a4cf431589351e41dd313718/screen-m-shr.txt","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c7c02a6e5b8e77692019afaf92daac30e1700bb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6e03fff3_bb7b8bcb","updated":"2025-07-17 05:17:37.000000000","message":"run-DellEMC PowerScale CI","commit_id":"9b1182f8dbe8f3561929a0cb7f8c69c5c2d585b5"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"8f3a5b887fa35a7437ca1689dae764e2204116e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0c4a9f59_aaa92383","updated":"2025-07-27 06:17:45.000000000","message":"Hi Reviewers,\n\nPatches[1][2] split out passed Zuul and CI. Please kindly review. Than you!\n\n[1] 955853: Dell PowerScale: add support for update share stats | https://review.opendev.org/c/openstack/manila/+/955853\n[2] 955856: Dell PowerScale: add support for ensure shares | https://review.opendev.org/c/openstack/manila/+/955856","commit_id":"a8f7d2ebe4acdcce706a834da754cf976a2b1bf8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"099e749b59e2bfb805976c9531832f89c8d9b02f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6d7db626_dd674f80","updated":"2025-07-25 05:34:32.000000000","message":"run-DellEMC PowerScale CI","commit_id":"a8f7d2ebe4acdcce706a834da754cf976a2b1bf8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"12acc6140bccdf576afd533d8f67a25286a53ef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2e83f676_d16f727f","updated":"2025-07-28 07:16:12.000000000","message":"Hi Reviewers,\n\nAll 3 patches just were overwritten by accident.\nPlease stay tuned.","commit_id":"883798e15f2c2948c2050fed5d09cfef9b5b8ed2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1427a19930926e89538b312ae6d2bf7784bc7d80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5239542d_9d21973f","updated":"2025-07-28 07:10:46.000000000","message":"run-DellEMC PowerScale CI","commit_id":"883798e15f2c2948c2050fed5d09cfef9b5b8ed2"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c05ed087829f5c2bbda388e12898ed80dc17afe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ecc500dc_e180d3b4","updated":"2025-07-28 15:21:34.000000000","message":"Hi Reviewers,\n\nAll set now. Please review, thanks!","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dc22b7cca6327bca678e38c2281bb486c93f8390","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2d0aaaa1_a53f63c6","updated":"2025-07-31 22:35:08.000000000","message":"Hi, thank you for your patience with the reviews here.. please see comments inline","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"de9c2357f99163f0e26f5a2d5e8a5fd65f09b8e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"87ba3c88_9eff9f42","updated":"2025-07-28 09:21:50.000000000","message":"recheck manila-grenade","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"7d21bbcdc902a79c6ca49af334d4dd19b6bb02d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0e64f3ee_eb38bbf9","updated":"2025-07-28 09:22:11.000000000","message":"run-DellEMC PowerScale CI","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a7f6988a088dc5aa10219ca7e81cadc82b1851a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3f208223_6d356b9a","in_reply_to":"794a57c8_29d40853","updated":"2025-07-30 05:51:24.000000000","message":"Resolved as patch 952736 rebased.","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2e1275bd693d849f0a0b581279f33c3e723fe5fe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"794a57c8_29d40853","in_reply_to":"ecc500dc_e180d3b4","updated":"2025-07-28 20:28:44.000000000","message":"Gerrit thinks there\u0027s a merge conflict with https://review.opendev.org/c/openstack/manila/+/952736\n\nCan you please resolve it?","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"42201ac36fe0793063b8c96242991f5cae06ed5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e61e3905_c977b72e","updated":"2025-08-01 15:15:42.000000000","message":"run-DellEMC PowerScale CI","commit_id":"a3f1fbb9f663a917412d8ac7ce7760153fd15085"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1571ceab68db39ab2c7e8bec07ac1f7a6bc18d0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"cb26a5bc_7d7b2f73","updated":"2025-08-02 07:06:23.000000000","message":"Hi @gouthampravi@gmail.com,\nThank you for reviewing!\nComments are resolved.","commit_id":"f3581daa310e7a3aa7677a8b15d1d88aa673a48f"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"066cbb8a13c0cb8a4f11f251661ba35fef069a6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"97f92daa_f9b57d17","updated":"2025-08-08 02:13:05.000000000","message":"Thank you all for the effort!","commit_id":"f3581daa310e7a3aa7677a8b15d1d88aa673a48f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fd03ad14237c311c9d9bfe3baf18580ef302454d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"69f47f6c_add04fb9","updated":"2025-08-07 19:23:47.000000000","message":"Thanks for working on this change and splitting up the patches, Yian","commit_id":"f3581daa310e7a3aa7677a8b15d1d88aa673a48f"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"afbdc579c380925b9aafd242216b87a3b960e83a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"135c93dc_bd2a3983","updated":"2025-08-02 06:54:44.000000000","message":"run-DellEMC PowerScale CI","commit_id":"f3581daa310e7a3aa7677a8b15d1d88aa673a48f"}],"manila/share/drivers/dell_emc/driver.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8ff18afa53e1e239e76e19a8539c7144aeecac1d","unresolved":true,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def get_backend_info(self, context):"},{"line_number":298,"context_line":"        \"\"\"Get driver and array configuration parameters.\"\"\""},{"line_number":299,"context_line":"        if hasattr(self.plugin, \u0027get_backend_info\u0027):"},{"line_number":300,"context_line":"            return self.plugin.get_backend_info(context)"},{"line_number":301,"context_line":"        raise NotImplementedError()"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ce6bd5f6_6867cd14","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":52},"updated":"2025-07-02 06:31:08.000000000","message":"i think this must be true if we add get_backend_info to isilon.py.\n\n    def get_backend_info(self, context):\n        \"\"\"Get driver and array configuration parameters.\"\"\"\n        return self.plugin.get_backend_info(context)","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"42cef02442266603ad282cb6347db45f3c67e01e","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def get_backend_info(self, context):"},{"line_number":298,"context_line":"        \"\"\"Get driver and array configuration parameters.\"\"\""},{"line_number":299,"context_line":"        if hasattr(self.plugin, \u0027get_backend_info\u0027):"},{"line_number":300,"context_line":"            return self.plugin.get_backend_info(context)"},{"line_number":301,"context_line":"        raise NotImplementedError()"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"c34f9be3_bf2d3804","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":52},"in_reply_to":"ce6bd5f6_6867cd14","updated":"2025-07-02 07:28:58.000000000","message":"Hi @haixin_haixin@qq.com\n\nThank you for reviewing!\n\nYes, for Isilon, it\u0027s expected to be True.\nMeanwhile, for other Dell drivers, such as PowerStore, Unity, etc., it\u0027s False as `get_backend_info` and `ensure_shares` are not implemented.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8ff18afa53e1e239e76e19a8539c7144aeecac1d","unresolved":true,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":304,"context_line":"        \"\"\"Invoked to ensure that shares are exported.\"\"\""},{"line_number":305,"context_line":"        if hasattr(self.plugin, \u0027ensure_shares\u0027):"},{"line_number":306,"context_line":"            return self.plugin.ensure_shares(context, shares)"},{"line_number":307,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":10,"id":"d7022276_2c40ac6d","line":305,"range":{"start_line":305,"start_character":11,"end_line":305,"end_character":18},"updated":"2025-07-02 06:31:08.000000000","message":"same above.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"42cef02442266603ad282cb6347db45f3c67e01e","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":304,"context_line":"        \"\"\"Invoked to ensure that shares are exported.\"\"\""},{"line_number":305,"context_line":"        if hasattr(self.plugin, \u0027ensure_shares\u0027):"},{"line_number":306,"context_line":"            return self.plugin.ensure_shares(context, shares)"},{"line_number":307,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":10,"id":"b3a1464d_6f9bcfd0","line":305,"range":{"start_line":305,"start_character":11,"end_line":305,"end_character":18},"in_reply_to":"d7022276_2c40ac6d","updated":"2025-07-02 07:28:58.000000000","message":"Please see above.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"}],"manila/share/drivers/dell_emc/plugins/isilon/isilon.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80b84c29a55acc2465a88360e8ae05bf18a86d4","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Isilon specific NAS backend plugin."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"from requests import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":10,"id":"d5c87d54_177a8cad","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":2},"updated":"2025-07-08 18:32:10.000000000","message":"maybe we should keep the way it was? I looked at this and you\u0027re still only using HTTPError, meaning that there\u0027s no reason for us to import the whole module when we are using only one of its exceptions","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Isilon specific NAS backend plugin."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"from requests import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":10,"id":"5437326c_5ce84473","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":2},"in_reply_to":"891a4458_8b018925","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Isilon specific NAS backend plugin."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"from requests import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":10,"id":"891a4458_8b018925","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":2},"in_reply_to":"d5c87d54_177a8cad","updated":"2025-07-10 00:47:56.000000000","message":"Our hacking guideline suggests importing modules and not objects: https://docs.openstack.org/hacking/latest/user/hacking.html#imports\n\nSo this change is fine, however, \"requests\" is not part of the standard library.. so really, it belongs to the next group per the same guideline..","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":182,"context_line":"            self._delete_nfs_share(share)"},{"line_number":183,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":184,"context_line":"            self._delete_cifs_share(share)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            message \u003d (_(\u0027Unsupported share type: %(type)s.\u0027) %"},{"line_number":187,"context_line":"                       {\u0027type\u0027: share[\u0027share_proto\u0027]})"},{"line_number":188,"context_line":"            LOG.error(message)"},{"line_number":189,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        dir_path \u003d self._get_container_path(share)"},{"line_number":192,"context_line":"        # remove quota"}],"source_content_type":"text/x-python","patch_set":10,"id":"66e813f7_6c15ba33","line":189,"range":{"start_line":185,"start_character":0,"end_line":189,"end_character":56},"updated":"2025-07-10 00:47:56.000000000","message":"This wouldn\u0027t be appropriate.. log a warning and return without an error, please.. Deletion of non-existent resources should succeed. \n\n\nRight now, there\u0027s little possibility that a share with a different protocol is scheduled to teh Isilon/Powerscale backend, but, if the logic changes outside the driver, you\u0027ll be allowing deletion of shares scheduled to powerscale, but never created","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            self._delete_nfs_share(share)"},{"line_number":183,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":184,"context_line":"            self._delete_cifs_share(share)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            message \u003d (_(\u0027Unsupported share type: %(type)s.\u0027) %"},{"line_number":187,"context_line":"                       {\u0027type\u0027: share[\u0027share_proto\u0027]})"},{"line_number":188,"context_line":"            LOG.error(message)"},{"line_number":189,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        dir_path \u003d self._get_container_path(share)"},{"line_number":192,"context_line":"        # remove quota"}],"source_content_type":"text/x-python","patch_set":10,"id":"866b63ed_9a12528d","line":189,"range":{"start_line":185,"start_character":0,"end_line":189,"end_character":56},"in_reply_to":"66e813f7_6c15ba33","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80b84c29a55acc2465a88360e8ae05bf18a86d4","unresolved":true,"context_lines":[{"line_number":205,"context_line":"                    _(\u0027Failed to delete quota \"%(quota_id)s\" for \u0027"},{"line_number":206,"context_line":"                      \u0027directory \"%(dir)s\".\u0027) %"},{"line_number":207,"context_line":"                    {\u0027quota_id\u0027: quota[\u0027id\u0027], \u0027dir\u0027: path})"},{"line_number":208,"context_line":"                LOG.error(message)"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            LOG.warning(f\u0027Quota not found for {path}\u0027)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"51519f40_cdcabb0e","line":208,"updated":"2025-07-08 18:32:10.000000000","message":"won\u0027t it be the case to throw some exceptions?","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":205,"context_line":"                    _(\u0027Failed to delete quota \"%(quota_id)s\" for \u0027"},{"line_number":206,"context_line":"                      \u0027directory \"%(dir)s\".\u0027) %"},{"line_number":207,"context_line":"                    {\u0027quota_id\u0027: quota[\u0027id\u0027], \u0027dir\u0027: path})"},{"line_number":208,"context_line":"                LOG.error(message)"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            LOG.warning(f\u0027Quota not found for {path}\u0027)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"f088a546_401bf57e","line":208,"in_reply_to":"51519f40_cdcabb0e","updated":"2025-07-10 00:47:56.000000000","message":"pattern matches what we do in other parts of the code when we\u0027re unable to release the quota for some reason","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"4d4d7612c986d243c45a416b23f8f25bd23ba007","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                    _(\u0027Failed to delete quota \"%(quota_id)s\" for \u0027"},{"line_number":206,"context_line":"                      \u0027directory \"%(dir)s\".\u0027) %"},{"line_number":207,"context_line":"                    {\u0027quota_id\u0027: quota[\u0027id\u0027], \u0027dir\u0027: path})"},{"line_number":208,"context_line":"                LOG.error(message)"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            LOG.warning(f\u0027Quota not found for {path}\u0027)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"d5c2a87d_e24d9142","line":208,"in_reply_to":"f088a546_401bf57e","updated":"2025-07-17 06:20:10.000000000","message":"Leave it as it is.\nEven if quota deletion failed, we still can delete the directory.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f20556d6a05855f068d71c9b4757dfbf8caa58fc","unresolved":true,"context_lines":[{"line_number":306,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":307,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":308,"context_line":"        share_id \u003d self._isilon_api.lookup_nfs_export(export_path)"},{"line_number":309,"context_line":"        if share_id is None:"},{"line_number":310,"context_line":"            message \u003d _(\u0027Share %s should have been created, but was not \u0027"},{"line_number":311,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":312,"context_line":"            LOG.error(message)"},{"line_number":313,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":316,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"}],"source_content_type":"text/x-python","patch_set":10,"id":"8a2038e7_2fb650d0","line":313,"range":{"start_line":309,"start_character":0,"end_line":313,"end_character":62},"updated":"2025-07-08 18:37:30.000000000","message":"please cover it with unit tests","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":307,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":308,"context_line":"        share_id \u003d self._isilon_api.lookup_nfs_export(export_path)"},{"line_number":309,"context_line":"        if share_id is None:"},{"line_number":310,"context_line":"            message \u003d _(\u0027Share %s should have been created, but was not \u0027"},{"line_number":311,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":312,"context_line":"            LOG.error(message)"},{"line_number":313,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":316,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fd8c325d_7946df3d","line":313,"range":{"start_line":309,"start_character":0,"end_line":313,"end_character":62},"in_reply_to":"8a2038e7_2fb650d0","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80b84c29a55acc2465a88360e8ae05bf18a86d4","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        ips.append(access_ip)"},{"line_number":326,"context_line":"        ips.extend(current_clients)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":329,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":330,"context_line":"                share_id, ips, None)"},{"line_number":331,"context_line":"        else:"},{"line_number":332,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":333,"context_line":"                share_id, None, ips)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def _cifs_allow_access(self, share, access):"},{"line_number":336,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":337,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"b212fe47_bab1aac3","line":334,"range":{"start_line":328,"start_character":8,"end_line":334,"end_character":1},"updated":"2025-07-08 18:32:10.000000000","message":"```suggestion\n        ro_ips \u003d ips if access_level \u003d\u003d const.ACCESS_LEVEL_RO else None\n        rw_ips \u003d ips if not ro_ips else None\n        self._isilon_api.modify_nfs_export_access(\n                share_id, ro_ips\u003dro_ips, rw_ips\u003drw_ips)\n\n```\nplease send the kwargs as kwargs for better readability","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        ips.append(access_ip)"},{"line_number":326,"context_line":"        ips.extend(current_clients)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":329,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":330,"context_line":"                share_id, ips, None)"},{"line_number":331,"context_line":"        else:"},{"line_number":332,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":333,"context_line":"                share_id, None, ips)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def _cifs_allow_access(self, share, access):"},{"line_number":336,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":337,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa88bbf4_affed056","line":334,"range":{"start_line":328,"start_character":8,"end_line":334,"end_character":1},"in_reply_to":"b212fe47_bab1aac3","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80b84c29a55acc2465a88360e8ae05bf18a86d4","unresolved":true,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if allowed_ips.__contains__(denied_ip):"},{"line_number":418,"context_line":"            allowed_ips.remove(denied_ip)"},{"line_number":419,"context_line":"            if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":420,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":421,"context_line":"                    export_id, list(allowed_ips), None)"},{"line_number":422,"context_line":"            else:"},{"line_number":423,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":424,"context_line":"                    export_id, None, list(allowed_ips))"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _get_existing_nfs_export(self, export_id):"},{"line_number":427,"context_line":"        export \u003d self._isilon_api.get_nfs_export(export_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"2d5d2006_4064b848","line":424,"range":{"start_line":419,"start_character":12,"end_line":424,"end_character":55},"updated":"2025-07-08 18:32:10.000000000","message":"same as above","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if allowed_ips.__contains__(denied_ip):"},{"line_number":418,"context_line":"            allowed_ips.remove(denied_ip)"},{"line_number":419,"context_line":"            if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":420,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":421,"context_line":"                    export_id, list(allowed_ips), None)"},{"line_number":422,"context_line":"            else:"},{"line_number":423,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":424,"context_line":"                    export_id, None, list(allowed_ips))"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _get_existing_nfs_export(self, export_id):"},{"line_number":427,"context_line":"        export \u003d self._isilon_api.get_nfs_export(export_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"8eadc811_e0297c69","line":424,"range":{"start_line":419,"start_character":12,"end_line":424,"end_character":55},"in_reply_to":"2d5d2006_4064b848","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":278,"context_line":"        self._isilon_api.quota_set("},{"line_number":279,"context_line":"            self._get_container_path(share), \u0027directory\u0027, new_quota_size)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def allow_access(self, context, share, access, share_server):"},{"line_number":282,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":283,"context_line":"        LOG.debug(f\u0027Allowing access to share {share[\"name\"]}.\u0027)"},{"line_number":284,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":285,"context_line":"            self._nfs_allow_access(share, access)"},{"line_number":286,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":287,"context_line":"            self._cifs_allow_access(share, access)"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            message \u003d _("},{"line_number":290,"context_line":"                \u0027Unsupported share protocol: %s. Only \"NFS\" and \u0027"},{"line_number":291,"context_line":"                \u0027\"CIFS\" are currently supported share protocols.\u0027) % share["},{"line_number":292,"context_line":"                \u0027share_proto\u0027]"},{"line_number":293,"context_line":"            LOG.error(message)"},{"line_number":294,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _nfs_allow_access(self, share, access):"},{"line_number":297,"context_line":"        \"\"\"Allow access to nfs share.\"\"\""},{"line_number":298,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":299,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":300,"context_line":"            message \u003d _(\u0027Only \"ip\" access type allowed for the NFS \u0027"},{"line_number":301,"context_line":"                        \u0027protocol.\u0027)"},{"line_number":302,"context_line":"            LOG.error(message)"},{"line_number":303,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        export_path \u003d self._get_container_path(share)"},{"line_number":306,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":307,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":308,"context_line":"        share_id \u003d self._isilon_api.lookup_nfs_export(export_path)"},{"line_number":309,"context_line":"        if share_id is None:"},{"line_number":310,"context_line":"            message \u003d _(\u0027Share %s should have been created, but was not \u0027"},{"line_number":311,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":312,"context_line":"            LOG.error(message)"},{"line_number":313,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":316,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":317,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # Get current allowed clients"},{"line_number":320,"context_line":"        export \u003d self._get_existing_nfs_export(share_id)"},{"line_number":321,"context_line":"        current_clients \u003d export[share_access_group]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # Format of ips could be \u002710.0.0.2\u0027, or \u002710.0.0.2, 10.0.0.0/24\u0027"},{"line_number":324,"context_line":"        ips \u003d list()"},{"line_number":325,"context_line":"        ips.append(access_ip)"},{"line_number":326,"context_line":"        ips.extend(current_clients)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":329,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":330,"context_line":"                share_id, ips, None)"},{"line_number":331,"context_line":"        else:"},{"line_number":332,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":333,"context_line":"                share_id, None, ips)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def _cifs_allow_access(self, share, access):"},{"line_number":336,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":337,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":338,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":339,"context_line":"        if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":340,"context_line":"            access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":341,"context_line":"            self._cifs_allow_access_ip(access_ip, share, access_level)"},{"line_number":342,"context_line":"        elif access_type \u003d\u003d \u0027user\u0027:"},{"line_number":343,"context_line":"            self._cifs_allow_access_user(access_to, share, access_level)"},{"line_number":344,"context_line":"        else:"},{"line_number":345,"context_line":"            message \u003d _(\u0027Only \"ip\" and \"user\" access types allowed for \u0027"},{"line_number":346,"context_line":"                        \u0027CIFS protocol.\u0027)"},{"line_number":347,"context_line":"            LOG.error(message)"},{"line_number":348,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def _cifs_allow_access_ip(self, ip, share, access_level):"},{"line_number":351,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":352,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":353,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":354,"context_line":"            LOG.error(message)"},{"line_number":355,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        allowed_ip \u003d \u0027allow:\u0027 + ip"},{"line_number":358,"context_line":"        smb_share \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"},{"line_number":359,"context_line":"        host_acl \u003d smb_share[\u0027host_acl\u0027]"},{"line_number":360,"context_line":"        if allowed_ip not in host_acl:"},{"line_number":361,"context_line":"            host_acl.append(allowed_ip)"},{"line_number":362,"context_line":"            self._isilon_api.modify_smb_share_access(share[\u0027name\u0027],"},{"line_number":363,"context_line":"                                                     host_acl\u003dhost_acl)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def _cifs_allow_access_user(self, user, share, access_level):"},{"line_number":366,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":367,"context_line":"            smb_permission \u003d isilon_api.SmbPermission.rw"},{"line_number":368,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":369,"context_line":"            smb_permission \u003d isilon_api.SmbPermission.ro"},{"line_number":370,"context_line":"        else:"},{"line_number":371,"context_line":"            message \u003d _(\u0027Only \"RW\" and \"RO\" access levels are supported.\u0027)"},{"line_number":372,"context_line":"            LOG.error(message)"},{"line_number":373,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        self._isilon_api.smb_permissions_add(share[\u0027name\u0027], user,"},{"line_number":376,"context_line":"                                             smb_permission)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def deny_access(self, context, share, access, share_server):"},{"line_number":379,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":380,"context_line":"        LOG.debug(f\u0027Denying access to share {share[\"name\"]}.\u0027)"},{"line_number":381,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":382,"context_line":"            self._nfs_deny_access(share, access)"},{"line_number":383,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":384,"context_line":"            self._cifs_deny_access(share, access)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _nfs_deny_access(self, share, access):"},{"line_number":387,"context_line":"        \"\"\"Deny access to nfs share.\"\"\""},{"line_number":388,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":389,"context_line":"            return"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        denied_ip \u003d access[\u0027access_to\u0027]"},{"line_number":392,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":393,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":394,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":395,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        # Get list of currently allowed client ips"},{"line_number":398,"context_line":"        export_id \u003d self._isilon_api.lookup_nfs_export("},{"line_number":399,"context_line":"            self._get_container_path(share))"},{"line_number":400,"context_line":"        if export_id is None:"},{"line_number":401,"context_line":"            message \u003d _(\u0027Share %s should have been created, but was not \u0027"},{"line_number":402,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":403,"context_line":"            LOG.error(message)"},{"line_number":404,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":405,"context_line":"        export \u003d self._get_existing_nfs_export(export_id)"},{"line_number":406,"context_line":"        try:"},{"line_number":407,"context_line":"            clients \u003d export[share_access_group]"},{"line_number":408,"context_line":"        except KeyError:"},{"line_number":409,"context_line":"            message \u003d (_(\u0027Export %(export_name)s should have contained the \u0027"},{"line_number":410,"context_line":"                         \u0027JSON key %(json_key)s, but this key was not found.\u0027)"},{"line_number":411,"context_line":"                       % {\u0027export_name\u0027: share[\u0027name\u0027],"},{"line_number":412,"context_line":"                          \u0027json_key\u0027: share_access_group})"},{"line_number":413,"context_line":"            LOG.error(message)"},{"line_number":414,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":415,"context_line":"        allowed_ips \u003d set(clients)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if allowed_ips.__contains__(denied_ip):"},{"line_number":418,"context_line":"            allowed_ips.remove(denied_ip)"},{"line_number":419,"context_line":"            if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":420,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":421,"context_line":"                    export_id, list(allowed_ips), None)"},{"line_number":422,"context_line":"            else:"},{"line_number":423,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":424,"context_line":"                    export_id, None, list(allowed_ips))"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _get_existing_nfs_export(self, export_id):"},{"line_number":427,"context_line":"        export \u003d self._isilon_api.get_nfs_export(export_id)"},{"line_number":428,"context_line":"        if export is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"58b1a227_37277751","line":425,"range":{"start_line":281,"start_character":4,"end_line":425,"end_character":0},"updated":"2025-07-10 00:47:56.000000000","message":"\"allow_access\" and \"deny_access\" methods (along with all these helper methods) are not needed when \"update_access\" (line 549) has been implemented. When \"update_access\" exists in the driver, the share manager will never invoke the deprecated \"allow_access\" and \"deny_access\" methods.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        self._isilon_api.quota_set("},{"line_number":279,"context_line":"            self._get_container_path(share), \u0027directory\u0027, new_quota_size)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def allow_access(self, context, share, access, share_server):"},{"line_number":282,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":283,"context_line":"        LOG.debug(f\u0027Allowing access to share {share[\"name\"]}.\u0027)"},{"line_number":284,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":285,"context_line":"            self._nfs_allow_access(share, access)"},{"line_number":286,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":287,"context_line":"            self._cifs_allow_access(share, access)"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            message \u003d _("},{"line_number":290,"context_line":"                \u0027Unsupported share protocol: %s. Only \"NFS\" and \u0027"},{"line_number":291,"context_line":"                \u0027\"CIFS\" are currently supported share protocols.\u0027) % share["},{"line_number":292,"context_line":"                \u0027share_proto\u0027]"},{"line_number":293,"context_line":"            LOG.error(message)"},{"line_number":294,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _nfs_allow_access(self, share, access):"},{"line_number":297,"context_line":"        \"\"\"Allow access to nfs share.\"\"\""},{"line_number":298,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":299,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":300,"context_line":"            message \u003d _(\u0027Only \"ip\" access type allowed for the NFS \u0027"},{"line_number":301,"context_line":"                        \u0027protocol.\u0027)"},{"line_number":302,"context_line":"            LOG.error(message)"},{"line_number":303,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        export_path \u003d self._get_container_path(share)"},{"line_number":306,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":307,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":308,"context_line":"        share_id \u003d self._isilon_api.lookup_nfs_export(export_path)"},{"line_number":309,"context_line":"        if share_id is None:"},{"line_number":310,"context_line":"            message \u003d _(\u0027Share %s should have been created, but was not \u0027"},{"line_number":311,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":312,"context_line":"            LOG.error(message)"},{"line_number":313,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":316,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":317,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # Get current allowed clients"},{"line_number":320,"context_line":"        export \u003d self._get_existing_nfs_export(share_id)"},{"line_number":321,"context_line":"        current_clients \u003d export[share_access_group]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # Format of ips could be \u002710.0.0.2\u0027, or \u002710.0.0.2, 10.0.0.0/24\u0027"},{"line_number":324,"context_line":"        ips \u003d list()"},{"line_number":325,"context_line":"        ips.append(access_ip)"},{"line_number":326,"context_line":"        ips.extend(current_clients)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":329,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":330,"context_line":"                share_id, ips, None)"},{"line_number":331,"context_line":"        else:"},{"line_number":332,"context_line":"            self._isilon_api.modify_nfs_export_access("},{"line_number":333,"context_line":"                share_id, None, ips)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def _cifs_allow_access(self, share, access):"},{"line_number":336,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":337,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":338,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":339,"context_line":"        if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":340,"context_line":"            access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":341,"context_line":"            self._cifs_allow_access_ip(access_ip, share, access_level)"},{"line_number":342,"context_line":"        elif access_type \u003d\u003d \u0027user\u0027:"},{"line_number":343,"context_line":"            self._cifs_allow_access_user(access_to, share, access_level)"},{"line_number":344,"context_line":"        else:"},{"line_number":345,"context_line":"            message \u003d _(\u0027Only \"ip\" and \"user\" access types allowed for \u0027"},{"line_number":346,"context_line":"                        \u0027CIFS protocol.\u0027)"},{"line_number":347,"context_line":"            LOG.error(message)"},{"line_number":348,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def _cifs_allow_access_ip(self, ip, share, access_level):"},{"line_number":351,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":352,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":353,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":354,"context_line":"            LOG.error(message)"},{"line_number":355,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        allowed_ip \u003d \u0027allow:\u0027 + ip"},{"line_number":358,"context_line":"        smb_share \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"},{"line_number":359,"context_line":"        host_acl \u003d smb_share[\u0027host_acl\u0027]"},{"line_number":360,"context_line":"        if allowed_ip not in host_acl:"},{"line_number":361,"context_line":"            host_acl.append(allowed_ip)"},{"line_number":362,"context_line":"            self._isilon_api.modify_smb_share_access(share[\u0027name\u0027],"},{"line_number":363,"context_line":"                                                     host_acl\u003dhost_acl)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def _cifs_allow_access_user(self, user, share, access_level):"},{"line_number":366,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RW:"},{"line_number":367,"context_line":"            smb_permission \u003d isilon_api.SmbPermission.rw"},{"line_number":368,"context_line":"        elif access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":369,"context_line":"            smb_permission \u003d isilon_api.SmbPermission.ro"},{"line_number":370,"context_line":"        else:"},{"line_number":371,"context_line":"            message \u003d _(\u0027Only \"RW\" and \"RO\" access levels are supported.\u0027)"},{"line_number":372,"context_line":"            LOG.error(message)"},{"line_number":373,"context_line":"            raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        self._isilon_api.smb_permissions_add(share[\u0027name\u0027], user,"},{"line_number":376,"context_line":"                                             smb_permission)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def deny_access(self, context, share, access, share_server):"},{"line_number":379,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":380,"context_line":"        LOG.debug(f\u0027Denying access to share {share[\"name\"]}.\u0027)"},{"line_number":381,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":382,"context_line":"            self._nfs_deny_access(share, access)"},{"line_number":383,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":384,"context_line":"            self._cifs_deny_access(share, access)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _nfs_deny_access(self, share, access):"},{"line_number":387,"context_line":"        \"\"\"Deny access to nfs share.\"\"\""},{"line_number":388,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":389,"context_line":"            return"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        denied_ip \u003d access[\u0027access_to\u0027]"},{"line_number":392,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":393,"context_line":"        share_access_group \u003d \u0027clients\u0027"},{"line_number":394,"context_line":"        if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":395,"context_line":"            share_access_group \u003d \u0027read_only_clients\u0027"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        # Get list of currently allowed client ips"},{"line_number":398,"context_line":"        export_id \u003d self._isilon_api.lookup_nfs_export("},{"line_number":399,"context_line":"            self._get_container_path(share))"},{"line_number":400,"context_line":"        if export_id is None:"},{"line_number":401,"context_line":"            message \u003d _(\u0027Share %s should have been created, but was not \u0027"},{"line_number":402,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":403,"context_line":"            LOG.error(message)"},{"line_number":404,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":405,"context_line":"        export \u003d self._get_existing_nfs_export(export_id)"},{"line_number":406,"context_line":"        try:"},{"line_number":407,"context_line":"            clients \u003d export[share_access_group]"},{"line_number":408,"context_line":"        except KeyError:"},{"line_number":409,"context_line":"            message \u003d (_(\u0027Export %(export_name)s should have contained the \u0027"},{"line_number":410,"context_line":"                         \u0027JSON key %(json_key)s, but this key was not found.\u0027)"},{"line_number":411,"context_line":"                       % {\u0027export_name\u0027: share[\u0027name\u0027],"},{"line_number":412,"context_line":"                          \u0027json_key\u0027: share_access_group})"},{"line_number":413,"context_line":"            LOG.error(message)"},{"line_number":414,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":415,"context_line":"        allowed_ips \u003d set(clients)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if allowed_ips.__contains__(denied_ip):"},{"line_number":418,"context_line":"            allowed_ips.remove(denied_ip)"},{"line_number":419,"context_line":"            if access_level \u003d\u003d const.ACCESS_LEVEL_RO:"},{"line_number":420,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":421,"context_line":"                    export_id, list(allowed_ips), None)"},{"line_number":422,"context_line":"            else:"},{"line_number":423,"context_line":"                self._isilon_api.modify_nfs_export_access("},{"line_number":424,"context_line":"                    export_id, None, list(allowed_ips))"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _get_existing_nfs_export(self, export_id):"},{"line_number":427,"context_line":"        export \u003d self._isilon_api.get_nfs_export(export_id)"},{"line_number":428,"context_line":"        if export is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"41ce305f_bfb38e03","line":425,"range":{"start_line":281,"start_character":4,"end_line":425,"end_character":0},"in_reply_to":"58b1a227_37277751","updated":"2025-07-17 05:25:24.000000000","message":"Removed \"allow_access\" and \"deny_access\" methods and all helper methods.\nRefactored \"_update_access_cifs\" method.","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f20556d6a05855f068d71c9b4757dfbf8caa58fc","unresolved":true,"context_lines":[{"line_number":475,"context_line":"        self._password \u003d config.safe_get(\"emc_nas_password\")"},{"line_number":476,"context_line":"        self._root_dir \u003d config.safe_get(\"emc_nas_root_dir\")"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        # validate IP, username and password"},{"line_number":479,"context_line":"        if not all([self._server,"},{"line_number":480,"context_line":"                    self._username,"},{"line_number":481,"context_line":"                    self._password]):"},{"line_number":482,"context_line":"            message \u003d _(\"REST server IP, username and password\""},{"line_number":483,"context_line":"                        \" must be specified.\")"},{"line_number":484,"context_line":"            raise exception.BadConfigurationException(reason\u003dmessage)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        self._server_url \u003d f\u0027https://{self._server}:{self._port}\u0027"},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2b84b2af_b4a61125","line":484,"range":{"start_line":478,"start_character":8,"end_line":484,"end_character":69},"updated":"2025-07-08 18:37:30.000000000","message":"please add unit tests for this: https://cb0b324d2e1a3e0ab94c-5b4233ce682298a00859e3398b583332.ssl.cf5.rackcdn.com/openstack/54cf5441a69a4cae851a178495a937a0/cover/z_5603af41abfaf09d_isilon_py.html","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"4d4d7612c986d243c45a416b23f8f25bd23ba007","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        self._password \u003d config.safe_get(\"emc_nas_password\")"},{"line_number":476,"context_line":"        self._root_dir \u003d config.safe_get(\"emc_nas_root_dir\")"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        # validate IP, username and password"},{"line_number":479,"context_line":"        if not all([self._server,"},{"line_number":480,"context_line":"                    self._username,"},{"line_number":481,"context_line":"                    self._password]):"},{"line_number":482,"context_line":"            message \u003d _(\"REST server IP, username and password\""},{"line_number":483,"context_line":"                        \" must be specified.\")"},{"line_number":484,"context_line":"            raise exception.BadConfigurationException(reason\u003dmessage)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        self._server_url \u003d f\u0027https://{self._server}:{self._port}\u0027"},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9d33ba90_56d64d55","line":484,"range":{"start_line":478,"start_character":8,"end_line":484,"end_character":69},"in_reply_to":"2b84b2af_b4a61125","updated":"2025-07-17 06:20:10.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80b84c29a55acc2465a88360e8ae05bf18a86d4","unresolved":true,"context_lines":[{"line_number":582,"context_line":"            return rule_state_map"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        r \u003d self._isilon_api.modify_nfs_export_access("},{"line_number":585,"context_line":"            export_id, list(nfs_ro_ips), list(nfs_rw_ips))"},{"line_number":586,"context_line":"        if not r:"},{"line_number":587,"context_line":"            return rule_state_map"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"c59c2d6f_53660880","line":585,"range":{"start_line":585,"start_character":22,"end_line":585,"end_character":58},"updated":"2025-07-08 18:32:10.000000000","message":"please send these as kwargs: `ro_ips\u003d(list(nfs_ro_ips))` and so on","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            return rule_state_map"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        r \u003d self._isilon_api.modify_nfs_export_access("},{"line_number":585,"context_line":"            export_id, list(nfs_ro_ips), list(nfs_rw_ips))"},{"line_number":586,"context_line":"        if not r:"},{"line_number":587,"context_line":"            return rule_state_map"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1571c546_b006c635","line":585,"range":{"start_line":585,"start_character":22,"end_line":585,"end_character":58},"in_reply_to":"c59c2d6f_53660880","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dc22b7cca6327bca678e38c2281bb486c93f8390","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                {\u0027share\u0027: share[\u0027name\u0027]})"},{"line_number":128,"context_line":"            LOG.error(message)"},{"line_number":129,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":130,"context_line":"        location \u003d self._format_nfs_path(container_path)"},{"line_number":131,"context_line":"        return location"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _create_cifs_share(self, share):"}],"source_content_type":"text/x-python","patch_set":16,"id":"89fd7ef3_24aa0358","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":56},"updated":"2025-07-31 22:35:08.000000000","message":"How is networking done for this driver, can there ever be multiple export paths?\n\nExport locations are setup as a list of dictionaries. The structure is:\n\n```\n                    \n                    [\n                        {\n                        \u0027path\u0027: \u00271.2.3.4:/foo\u0027,\n                        \u0027metadata\u0027: {},\n                        \u0027is_admin_only\u0027: False\n                        },\n                        {\n                        \u0027path\u0027: \u00275.6.7.8:/foo\u0027,\n                        \u0027metadata\u0027: {},\n                        \u0027is_admin_only\u0027: True\n                        },\n                    ]\n                    \n```\n\nSo even if the driver ever supports only one path, i\u0027d still suggest sending this back as a list structure with just one dict element. \n\nHere\u0027s an example: https://github.com/openstack/manila/blob/dc1320c963651fae770d1d057a7923219e8df579/manila/share/drivers/cephfs/driver.py#L1340-L1348","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1571ceab68db39ab2c7e8bec07ac1f7a6bc18d0c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                {\u0027share\u0027: share[\u0027name\u0027]})"},{"line_number":128,"context_line":"            LOG.error(message)"},{"line_number":129,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":130,"context_line":"        location \u003d self._format_nfs_path(container_path)"},{"line_number":131,"context_line":"        return location"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _create_cifs_share(self, share):"}],"source_content_type":"text/x-python","patch_set":16,"id":"96444e91_b35e01cf","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":56},"in_reply_to":"89fd7ef3_24aa0358","updated":"2025-08-02 07:06:23.000000000","message":"The driver supports one export.","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dc22b7cca6327bca678e38c2281bb486c93f8390","unresolved":true,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def ensure_share(self, context, share, share_server):"},{"line_number":265,"context_line":"        \"\"\"Invoked to ensure that share is exported.\"\"\""},{"line_number":266,"context_line":"        raise NotImplementedError()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":269,"context_line":"        \"\"\"Extends a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"0daaa078_f9621e79","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":35},"updated":"2025-07-31 22:35:08.000000000","message":"this would be incorrect. A driver must either have \"ensure_share\" or \"ensure_shares\".. can be a no-op like it previously was.. \n\nI know you have another patch to implement ensure_shares, you can tackle this in that patch. Here, please leave ensure_share as it was before, a no op.","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1571ceab68db39ab2c7e8bec07ac1f7a6bc18d0c","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def ensure_share(self, context, share, share_server):"},{"line_number":265,"context_line":"        \"\"\"Invoked to ensure that share is exported.\"\"\""},{"line_number":266,"context_line":"        raise NotImplementedError()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":269,"context_line":"        \"\"\"Extends a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"7f054f90_5e96a3d6","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":35},"in_reply_to":"0daaa078_f9621e79","updated":"2025-08-02 07:06:23.000000000","message":"Done","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dc22b7cca6327bca678e38c2281bb486c93f8390","unresolved":true,"context_lines":[{"line_number":366,"context_line":"            state_map \u003d self._update_access_cifs(share, access_rules)"},{"line_number":367,"context_line":"        return state_map"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _update_access_nfs(self, share, access_rules):"},{"line_number":370,"context_line":"        \"\"\"Updates access on a NFS share.\"\"\""},{"line_number":371,"context_line":"        nfs_rw_ips \u003d set()"},{"line_number":372,"context_line":"        nfs_ro_ips \u003d set()"}],"source_content_type":"text/x-python","patch_set":16,"id":"16be989a_62c34e9a","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":54},"updated":"2025-07-31 22:35:08.000000000","message":"for these two methods - _update_access_nfs and _update_access_cifs, are ipv6 addresses supported?\n\nIf yes, you\u0027ll need to set `self.ipv6_implemented \u003d True` in the `__init__` method of the driver, Without this, the share manager will exclude ipv6 rules","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1571ceab68db39ab2c7e8bec07ac1f7a6bc18d0c","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            state_map \u003d self._update_access_cifs(share, access_rules)"},{"line_number":367,"context_line":"        return state_map"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _update_access_nfs(self, share, access_rules):"},{"line_number":370,"context_line":"        \"\"\"Updates access on a NFS share.\"\"\""},{"line_number":371,"context_line":"        nfs_rw_ips \u003d set()"},{"line_number":372,"context_line":"        nfs_ro_ips \u003d set()"}],"source_content_type":"text/x-python","patch_set":16,"id":"43cd85e7_3d82d649","line":369,"range":{"start_line":369,"start_character":0,"end_line":369,"end_character":54},"in_reply_to":"16be989a_62c34e9a","updated":"2025-08-02 07:06:23.000000000","message":"Yes, ipv6 is supported.","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a2d00d95bda3c1b81d84e74646551acc047094d0","unresolved":true,"context_lines":[{"line_number":491,"context_line":"    def _get_location(self, path):"},{"line_number":492,"context_line":"        export_locations \u003d [{\u0027path\u0027: path,"},{"line_number":493,"context_line":"                             \u0027is_admin_only\u0027: False,"},{"line_number":494,"context_line":"                             \u0027metadata\u0027: {}}]"},{"line_number":495,"context_line":"        return export_locations"}],"source_content_type":"text/x-python","patch_set":18,"id":"ea85e1be_471b98b2","line":494,"range":{"start_line":494,"start_character":41,"end_line":494,"end_character":43},"updated":"2025-08-01 20:32:37.000000000","message":"you didn\u0027t respond to my comment asking if there\u0027re multiple paths possible at any time.. if there aren\u0027t, please set \"preferred\": True, as part of this metadata object - since there\u0027s only ever one path, doing this allows that to be the \"preferred\" export path.","commit_id":"a3f1fbb9f663a917412d8ac7ce7760153fd15085"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1571ceab68db39ab2c7e8bec07ac1f7a6bc18d0c","unresolved":false,"context_lines":[{"line_number":491,"context_line":"    def _get_location(self, path):"},{"line_number":492,"context_line":"        export_locations \u003d [{\u0027path\u0027: path,"},{"line_number":493,"context_line":"                             \u0027is_admin_only\u0027: False,"},{"line_number":494,"context_line":"                             \u0027metadata\u0027: {}}]"},{"line_number":495,"context_line":"        return export_locations"}],"source_content_type":"text/x-python","patch_set":18,"id":"1eaa670c_7aee4772","line":494,"range":{"start_line":494,"start_character":41,"end_line":494,"end_character":43},"in_reply_to":"ea85e1be_471b98b2","updated":"2025-08-02 07:06:23.000000000","message":"Done","commit_id":"a3f1fbb9f663a917412d8ac7ce7760153fd15085"}],"manila/share/drivers/dell_emc/plugins/isilon/isilon_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import enum"},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":"import requests"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":10,"id":"b6ad6171_f879deeb","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":15},"updated":"2025-07-10 00:47:56.000000000","message":"requests belongs in the second group: https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import enum"},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":"import requests"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":10,"id":"93959a49_e3197f3f","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":15},"in_reply_to":"b6ad6171_f879deeb","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    def lookup_nfs_export(self, share_path):"},{"line_number":171,"context_line":"        \u0027\u0027\u0027Retrieve NFS export by directory path.\u0027\u0027\u0027"},{"line_number":172,"context_line":"        r \u003d self.send_get_request("},{"line_number":173,"context_line":"            self.host_url + \u0027/platform/12/protocols/nfs/exports\u0027,"},{"line_number":174,"context_line":"            params\u003d{\u0027path\u0027: share_path})"},{"line_number":175,"context_line":"        if r.status_code \u003d\u003d 200 and r.json()[\u0027total\u0027] \u003e 0:"},{"line_number":176,"context_line":"            return r.json()[\u0027exports\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"83ed3b14_1199d476","line":173,"range":{"start_line":173,"start_character":30,"end_line":173,"end_character":41},"updated":"2025-07-10 00:47:56.000000000","message":"just curious: does the `/platform/12` endpoint need a specific version of OneFS?\n\nin the driver doc, you call out that the driver supports OneFS version 9.10+, but some product documentation [1] refers to `/platform/12` being available with 9.2.0.0+\n\n\n[1] https://www.dell.com/support/manuals/en-us/isilon-onefs/ifs_pub_onefs_api_reference/api-versions-in-onefs?guid\u003dguid-83965c60-9938-4608-ab46-8beb2d4b2f3e\u0026lang\u003den-us","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"4d4d7612c986d243c45a416b23f8f25bd23ba007","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def lookup_nfs_export(self, share_path):"},{"line_number":171,"context_line":"        \u0027\u0027\u0027Retrieve NFS export by directory path.\u0027\u0027\u0027"},{"line_number":172,"context_line":"        r \u003d self.send_get_request("},{"line_number":173,"context_line":"            self.host_url + \u0027/platform/12/protocols/nfs/exports\u0027,"},{"line_number":174,"context_line":"            params\u003d{\u0027path\u0027: share_path})"},{"line_number":175,"context_line":"        if r.status_code \u003d\u003d 200 and r.json()[\u0027total\u0027] \u003e 0:"},{"line_number":176,"context_line":"            return r.json()[\u0027exports\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"de0fba17_6bb22aad","line":173,"range":{"start_line":173,"start_character":30,"end_line":173,"end_character":41},"in_reply_to":"83ed3b14_1199d476","updated":"2025-07-17 06:20:10.000000000","message":"`/platform/12` means it\u0027s available since 9.2 and preserved in newer OneFS.\nThe public OneFS API doc[1] is up to 9.9, however, it\u0027s the same in 9.10.\n\n[1] https://developer.dell.com/apis/4088/versions/9.9.0/docs/1introduction.md","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"}],"manila/tests/share/drivers/dell_emc/plugins/isilon/test_isilon.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from requests import exceptions"},{"line_number":18,"context_line":"from unittest import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":10,"id":"7b329cdd_4fb323a6","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":25},"updated":"2025-07-10 00:47:56.000000000","message":"this rearrangement isnt necessary...\nsee the import order template here:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from requests import exceptions"},{"line_number":18,"context_line":"from unittest import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":10,"id":"a7c34c59_ed0b1627","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":25},"in_reply_to":"7b329cdd_4fb323a6","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"}],"manila/tests/share/drivers/dell_emc/plugins/isilon/test_isilon_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97bc6afe69f452781f1aa2455ae1412bd2d16906","unresolved":true,"context_lines":[{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":"import requests_mock"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"826651fd_6ee0fb64","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":25},"updated":"2025-07-10 00:47:56.000000000","message":"unittest is a part of the python standard library.. \n\nplease refer to this import order convention: https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":"import requests_mock"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"16cfd2f8_4a6ab1b7","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":25},"in_reply_to":"826651fd_6ee0fb64","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"}],"releasenotes/notes/bug-2100829-dell-powerscale-http-auth-38831162175686c4.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ce4833d67ca1eab2cf9ce58a4f21cd16b67fc84","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1d6ff688_66e01640","line":20,"updated":"2025-07-10 00:52:24.000000000","message":"I think either this note, or the note in your final change: https://review.opendev.org/c/openstack/manila/+/952736/9/releasenotes/notes/bp-rename-isilon-to-powerscale-8e29d71c9e3629c3.yaml\n\nshould include an \"upgrade\" note calling out the impact to potential Isilon users.\n\n\nIf they had previously configured share types, those wouldn\u0027t work. If they had shares in the past, these wouldn\u0027t work without renaming the host, or unmanaging and re-managing these shares","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e51bf8e43ba82d66ce901cd35665e9ada5fcb8fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"42d9e39f_283519da","line":20,"in_reply_to":"1d6ff688_66e01640","updated":"2025-07-17 05:25:24.000000000","message":"Done","commit_id":"6209ce3ebaed952925d0ef0da4ffa10faa15ee2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dc22b7cca6327bca678e38c2281bb486c93f8390","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    * Enabled configurable SSL cert verification."},{"line_number":14,"context_line":"upgrade:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Dell PowerScale Driver: Previously configured share types wouldn\u0027t work."},{"line_number":17,"context_line":"    Previously created shares wouldn\u0027t work without renaming the host."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bad2f378_a9e32da8","line":17,"range":{"start_line":16,"start_character":4,"end_line":17,"end_character":70},"updated":"2025-07-31 22:35:08.000000000","message":"```suggestion\n    Dell PowerScale Driver was previously the EMC Isilon Driver. If the\n    extra-spec``share_backend_name`` was set to ``isilon`` in share types\n    in the past, this needs to be changed to ``powerscale``.\n```\n\n\ntangentially:\n\nisn\u0027t this note more appropriate for the last change in the series: https://review.opendev.org/c/openstack/manila/+/952736\n\nwe\u0027ll try and merge all these changes during this release, but, it is a little confusing to see this unrelated note.\n\nyou can choose to keep it here if it is less confusing, but noting this in case it confuses other reviewers","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1571ceab68db39ab2c7e8bec07ac1f7a6bc18d0c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    * Enabled configurable SSL cert verification."},{"line_number":14,"context_line":"upgrade:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Dell PowerScale Driver: Previously configured share types wouldn\u0027t work."},{"line_number":17,"context_line":"    Previously created shares wouldn\u0027t work without renaming the host."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1daf0dc0_41bb34d8","line":17,"range":{"start_line":16,"start_character":4,"end_line":17,"end_character":70},"in_reply_to":"bad2f378_a9e32da8","updated":"2025-08-02 07:06:23.000000000","message":"Removed upgrade note here, and will add to patch 952736.","commit_id":"d4b9aca6e3d2fc667839a3e3e17c5ef018af99b4"}]}