)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1f6ce8f5ed6d3f5d3a7ab2fc9a4c64ccc2b2abf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00b1af3b_1c0522c6","updated":"2025-03-28 16:32:13.000000000","message":"Thanks for working on this, this has bothered us for a while already :) \n\nPlease think about my inline suggestion.","commit_id":"267ff21dc8303cc121fa1ef5e2a114f683b68d63"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"da8fb23d46d20732920ee21dbcb4dc24ef95cc0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36095ac5_10d17e1e","updated":"2025-03-31 08:44:40.000000000","message":"a nit comment.","commit_id":"03e210f7df5bbea70ad413f3f2cc635c6ba29c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8b385bcf1df75748a9d80f00ace9f6aa00cbda10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c8055ec6_04d6c845","updated":"2025-04-16 23:12:00.000000000","message":"LGTM, thanks Kiran","commit_id":"27d00fd526f624768fb9264ce22bae970ecd270c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4d852f822fefb3a826af3f7e2d5dc0a7f0af103c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0c5a511_c065dedb","updated":"2025-04-01 01:29:39.000000000","message":"LGTM，thanks.","commit_id":"27d00fd526f624768fb9264ce22bae970ecd270c"}],"manila/share/api.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1f6ce8f5ed6d3f5d3a7ab2fc9a4c64ccc2b2abf5","unresolved":true,"context_lines":[{"line_number":3284,"context_line":"             \u0027status\u0027: constants.STATUS_SERVER_MIGRATING})"},{"line_number":3285,"context_line":""},{"line_number":3286,"context_line":"        share_instance_ids \u003d []"},{"line_number":3287,"context_line":"        for share in shares:"},{"line_number":3288,"context_line":"            for share_instance in share[\u0027instances\u0027]:"},{"line_number":3289,"context_line":"                if share_instance[\u0027share_server_id\u0027] \u003d\u003d share_server[\u0027id\u0027]:"},{"line_number":3290,"context_line":"                    share_instance_ids.append(share_instance[\u0027id\u0027])"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"        snapshot_instance_ids \u003d []"},{"line_number":3293,"context_line":"        snap_instances \u003d self.db.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":1,"id":"1d09a4b2_effa5d70","line":3290,"range":{"start_line":3287,"start_character":7,"end_line":3290,"end_character":67},"updated":"2025-03-28 16:32:13.000000000","message":"For consistency with other code I suggest to use\n`db.share_instances_get_all_by_share_server()` here","commit_id":"267ff21dc8303cc121fa1ef5e2a114f683b68d63"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0b18d32bbd2731c3a696f5f4061c22b4854c2065","unresolved":true,"context_lines":[{"line_number":3284,"context_line":"             \u0027status\u0027: constants.STATUS_SERVER_MIGRATING})"},{"line_number":3285,"context_line":""},{"line_number":3286,"context_line":"        share_instance_ids \u003d []"},{"line_number":3287,"context_line":"        for share in shares:"},{"line_number":3288,"context_line":"            for share_instance in share[\u0027instances\u0027]:"},{"line_number":3289,"context_line":"                if share_instance[\u0027share_server_id\u0027] \u003d\u003d share_server[\u0027id\u0027]:"},{"line_number":3290,"context_line":"                    share_instance_ids.append(share_instance[\u0027id\u0027])"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"        snapshot_instance_ids \u003d []"},{"line_number":3293,"context_line":"        snap_instances \u003d self.db.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":1,"id":"55a74ca3_55527886","line":3290,"range":{"start_line":3287,"start_character":7,"end_line":3290,"end_character":67},"in_reply_to":"1d09a4b2_effa5d70","updated":"2025-03-31 01:54:45.000000000","message":"+1\n\n    share_instances \u003d self.db.share_instance_get_all_by_share_server(context, share_server[\u0027id\u0027])\n    share_instance_ids \u003d [share_instance[\u0027id\u0027] for share_instance in share_instances]","commit_id":"267ff21dc8303cc121fa1ef5e2a114f683b68d63"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0f64f67007c35abc03d30f0ecce1f720b7fa6dd8","unresolved":false,"context_lines":[{"line_number":3284,"context_line":"             \u0027status\u0027: constants.STATUS_SERVER_MIGRATING})"},{"line_number":3285,"context_line":""},{"line_number":3286,"context_line":"        share_instance_ids \u003d []"},{"line_number":3287,"context_line":"        for share in shares:"},{"line_number":3288,"context_line":"            for share_instance in share[\u0027instances\u0027]:"},{"line_number":3289,"context_line":"                if share_instance[\u0027share_server_id\u0027] \u003d\u003d share_server[\u0027id\u0027]:"},{"line_number":3290,"context_line":"                    share_instance_ids.append(share_instance[\u0027id\u0027])"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"        snapshot_instance_ids \u003d []"},{"line_number":3293,"context_line":"        snap_instances \u003d self.db.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":1,"id":"b8809355_b6add348","line":3290,"range":{"start_line":3287,"start_character":7,"end_line":3290,"end_character":67},"in_reply_to":"55a74ca3_55527886","updated":"2025-03-31 05:05:03.000000000","message":"Done","commit_id":"267ff21dc8303cc121fa1ef5e2a114f683b68d63"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"da8fb23d46d20732920ee21dbcb4dc24ef95cc0c","unresolved":true,"context_lines":[{"line_number":3288,"context_line":"        share_instance_ids \u003d ["},{"line_number":3289,"context_line":"            share_instance[\u0027id\u0027] for share_instance in share_instances]"},{"line_number":3290,"context_line":""},{"line_number":3291,"context_line":"        snapshot_instance_ids \u003d []"},{"line_number":3292,"context_line":"        snap_instances \u003d self.db.share_snapshot_instance_get_all_with_filters("},{"line_number":3293,"context_line":"            context, {\u0027share_instance_ids\u0027: share_instance_ids})"},{"line_number":3294,"context_line":"        snapshot_instance_ids \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"56e7d2b9_ef69c75e","line":3291,"range":{"start_line":3291,"start_character":8,"end_line":3291,"end_character":34},"updated":"2025-03-31 08:44:40.000000000","message":"i think we can remove this line.","commit_id":"03e210f7df5bbea70ad413f3f2cc635c6ba29c3b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6fdf566e54c4b793ef264e371027d4f1ab463c9d","unresolved":false,"context_lines":[{"line_number":3288,"context_line":"        share_instance_ids \u003d ["},{"line_number":3289,"context_line":"            share_instance[\u0027id\u0027] for share_instance in share_instances]"},{"line_number":3290,"context_line":""},{"line_number":3291,"context_line":"        snapshot_instance_ids \u003d []"},{"line_number":3292,"context_line":"        snap_instances \u003d self.db.share_snapshot_instance_get_all_with_filters("},{"line_number":3293,"context_line":"            context, {\u0027share_instance_ids\u0027: share_instance_ids})"},{"line_number":3294,"context_line":"        snapshot_instance_ids \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3d002d9b_27fd263d","line":3291,"range":{"start_line":3291,"start_character":8,"end_line":3291,"end_character":34},"in_reply_to":"56e7d2b9_ef69c75e","updated":"2025-03-31 12:01:18.000000000","message":"Done","commit_id":"03e210f7df5bbea70ad413f3f2cc635c6ba29c3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8b385bcf1df75748a9d80f00ace9f6aa00cbda10","unresolved":true,"context_lines":[{"line_number":3265,"context_line":"            preserve_snapshots, new_share_network\u003dNone):"},{"line_number":3266,"context_line":"        \"\"\"Migrates share server to a new host.\"\"\""},{"line_number":3267,"context_line":""},{"line_number":3268,"context_line":"        shares, types, service, new_share_network_id, net_params_changed \u003d ("},{"line_number":3269,"context_line":"            self._migration_initial_checks(context, share_server,"},{"line_number":3270,"context_line":"                                           dest_host,"},{"line_number":3271,"context_line":"                                           new_share_network))"}],"source_content_type":"text/x-python","patch_set":3,"id":"28053e68_3dec38ce","line":3268,"range":{"start_line":3268,"start_character":8,"end_line":3268,"end_character":14},"updated":"2025-04-16 23:12:00.000000000","message":"nit: I think this is no longer being used, so we might set this to _?","commit_id":"27d00fd526f624768fb9264ce22bae970ecd270c"}]}