)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"788fdcfc974a0234484909906952aad253cfc784","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Dell PowerScale: Added support of thin provisioning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powerscale-thin-provisioning"},{"line_number":10,"context_line":"Change-Id: I197796713304ff6695f39b1b39817bfbb4c7927e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"129c5580_82276ede","line":10,"updated":"2025-06-24 19:42:55.000000000","message":"please add the Signed-off-by tag here (do commit amend -s and it should take care of it). It will be required upstream from now on","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1ea1076cbc19dc687aaa18ae1983be6475db4a54","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Dell PowerScale: Added support of thin provisioning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint powerscale-thin-provisioning"},{"line_number":10,"context_line":"Change-Id: I197796713304ff6695f39b1b39817bfbb4c7927e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"464c47cb_e6be7294","line":10,"in_reply_to":"129c5580_82276ede","updated":"2025-06-25 04:45:34.000000000","message":"Done. added signed off","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"c376e66a8ca811bd8637d17b1838c4b50c5463f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08427604_034941a6","updated":"2025-04-28 09:03:23.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"eb251df058e6c703d3b357c3a43c813442ffd6b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08751a41_7f69a4b8","updated":"2025-04-18 14:49:27.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f9d6b25ae09fcb087ea44d552da4f6e553bb846d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a67c0b4_2c30379b","updated":"2025-04-28 06:59:48.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6cf424ca9729b0660ba7d18544703407e7aaed03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20c5ea9c_d2749cd5","updated":"2025-04-18 14:17:07.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"be27d65a6791f1ec186864bcbc136476be17e1aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a435e3f_c6cae486","updated":"2025-04-18 16:48:56.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"a68b8f10506741fdec03fa44bfc70fb93b0ca694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63ada81d_3458ddb4","updated":"2025-04-28 16:02:21.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"debc399712ba1db1e263535916d8a67c6cfeb5fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a94c9c58_7713f2b2","updated":"2025-04-16 05:04:47.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"deb29fc3cc7f7562510618fdb4ceb1cf31310936","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae5ccd11_34531897","updated":"2025-04-18 16:48:02.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"96ab7c3129c92ea42195ea3735a3783746828da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c31819f2_9bc909a4","updated":"2025-04-18 12:38:43.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"b135c75367b3e18511312b6add0667cf142c8cd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9e2b9d1_877c3e8e","updated":"2025-04-28 18:52:16.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6ab4659df3268c569797600c6ab22ed6294e3f69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d7f6e35e_e1efb0db","updated":"2025-04-18 07:50:09.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f2fc8fb5bde73e4fba81ee9a1d33572305511f95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"daa527ae_1c3ed8bc","updated":"2025-04-18 06:25:01.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"2d12a61af11bd09e426e4fbd780853c4a8bf9b14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"deef7202_a170cb57","updated":"2025-04-18 11:57:21.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"cc47d145a6a8d885543724ee4066d3893b8aa90b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e87a9974_492f3aaa","updated":"2025-04-18 16:13:37.000000000","message":"run-DellEMC PowerScale CI","commit_id":"df9126e1d2885c93013232e4734fd01b651c1507"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3158a5178c71f12325bfbf217462aaa3dcfb870a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"094e8749_43f30886","updated":"2025-06-24 12:39:34.000000000","message":"Hi @gouthampravi@gmail.com and @ces.eduardo98@gmail.com,\n\nNow the CI logs are available publicly. Please do a review when you gets a time.","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"788fdcfc974a0234484909906952aad253cfc784","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b8d9813e_6d6160a1","updated":"2025-06-24 19:42:55.000000000","message":"LGTM, thank you Nilesh!","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1529508c53aa38631f002abeed9c3bae984a8827","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74d6a518_f018ee96","updated":"2025-06-13 10:31:48.000000000","message":"Please do a review.","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"6b1095a2b0c239448141f273a531deca42ea4553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"13f0c433_449e64f5","updated":"2025-06-19 08:45:46.000000000","message":"run-DellEMC PowerScale CI","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"16f000df95954974062303381d25abf1ae94d07c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2baf3205_711c6e76","updated":"2025-06-24 12:00:30.000000000","message":"run-DellEMC PowerScale CI","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9a276459197ac63f7c098ce50255018674903fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d28b9844_ff405714","updated":"2025-06-13 08:31:14.000000000","message":"run-DellEMC PowerScale CI","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"78141f70636963dbaff81cd63b5a12368c7e6a0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c70507a4_21559578","in_reply_to":"74d6a518_f018ee96","updated":"2025-06-16 23:29:27.000000000","message":"Nilesh, your CI results are not public. I\u0027ve asked on several other changes in the past, I\u0027m unsure what your plans to make these public are?","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c60e0db5b21032221f310d5aac2c0339c41e3cca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a828a3d_74f94ef2","in_reply_to":"c70507a4_21559578","updated":"2025-06-17 05:04:14.000000000","message":"@gouthampravi@gmail.com, yeah it will be going to public and team is working on it. i am not sure how much time it will take.\nMeanwhile, if we provide the manual result will it work?","commit_id":"7611bb246f4684fbb691b911e8d6117f078cec57"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"626d7e74d707bab32cdc4e91a03fe78b5c65982c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78db3425_552a08a2","updated":"2025-06-26 18:16:04.000000000","message":"@ces.eduardo98@gmail.com and @kinpaa@gmail.com\n\nThanks for the review. I think this patch will not get merge until the base patch(https://review.opendev.org/c/openstack/manila/+/943233/10) gets reviewed and merge into master.","commit_id":"04c02a117c927b753413b067cdf19a368fe6d3a8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"efd11a7e1e19f63e3097ecf66efd6a882ebae65d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"12c744fa_7bbe8592","updated":"2025-07-10 21:02:06.000000000","message":"Could you also please modify: \n\ndoc/source/admin/share_back_ends_feature_support_mapping.rst and call out support for thin provisioning","commit_id":"04c02a117c927b753413b067cdf19a368fe6d3a8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e11c9e56d065c3ad89d427cf434c6915e005443d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"37eac0e0_36068c97","updated":"2025-06-25 07:35:18.000000000","message":"recheck","commit_id":"04c02a117c927b753413b067cdf19a368fe6d3a8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"07b0cb625d6c6aa23a2aa5c418f7bd2772b3a460","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3ef0c71_690e1e02","updated":"2025-07-17 08:41:19.000000000","message":"@gouthampravi@gmail.com Resolved your comments please do review.\n\nAlso @ces.eduardo98@gmail.com and @kinpaa@gmail.com please do a review as well.","commit_id":"803c750e5f1c23c1155b3adfbff24da0b69f825e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"046c4fc622b1eb32738fdf59edc0848aab1ebda7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6646426f_6f943e94","updated":"2025-07-23 04:42:33.000000000","message":"`doc/source/admin/share_back_ends_feature_support_mapping.rst` needs update to reflect support of thin provisioning.","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d49d1d8bb2a81ac7e5f31fc923b351915d7dd2d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ad008390_2a92064e","updated":"2025-07-18 14:07:27.000000000","message":"run-DellEMC PowerScale CI","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"425feb4e27ec2bdc8388f83aa706f88d411882a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34ca00cb_ba536b0a","in_reply_to":"6646426f_6f943e94","updated":"2025-07-23 05:28:46.000000000","message":"Done","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e3d3faa21607a1e8c78d119b7edabb296b124346","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e4b86fc7_63fe2423","updated":"2025-08-01 06:05:19.000000000","message":"@gouthampravi@gmail.com\n\nThanks for the review. updated the comments please check it.","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f90ec91288ab234a350a850bfc1cc93e3e17c109","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"73267ec6_9cfc7950","updated":"2025-07-28 11:36:44.000000000","message":"Now the base patch is 955856: Dell PowerScale: add support for ensure shares | https://review.opendev.org/c/openstack/manila/+/955856. Please do a reveiw.","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"59b86145bb659cf87bb96debde3247c328832302","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e4e50226_6c553aad","updated":"2025-07-28 11:49:14.000000000","message":"run-DellEMC PowerScale CI","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8cd223a1ecd4fc44fe584aecd5fd26515f552a5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9dc363a7_befb9142","updated":"2025-08-01 22:39:04.000000000","message":"CI will not run until this patch is rebased onto the main patch. I’ll rebase it once the main patch is finalized to avoid multiple rebases.","commit_id":"c29510a31b1e3a15c7cf9fe7d9bb12884944f037"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f910cec71014832742c901cbae923d4557f42afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"852d475a_30788ac7","updated":"2025-08-01 22:32:48.000000000","message":"Updated code according review comment.","commit_id":"c29510a31b1e3a15c7cf9fe7d9bb12884944f037"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d5819329a9bd023f945017d18211fb2ad91e74a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9503a87a_b36c5161","updated":"2025-08-01 22:33:11.000000000","message":"run-DellEMC PowerScale CI","commit_id":"c29510a31b1e3a15c7cf9fe7d9bb12884944f037"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8ab3b1f237b94a805d3826980c61a24b9ba52c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3d9584f6_1055a5b0","updated":"2025-08-07 14:16:24.000000000","message":"LGTM, thank you","commit_id":"e9386b67d9c99ec4b0d2e02440ae07b4ec1d0b74"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d965c82ddfc62b62d027057dc7f2ea26229681cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"302e1d72_b0ee506c","updated":"2025-08-07 14:18:35.000000000","message":"LGTM, thanks Nilesh! The issue with oversubscription will be addressed in a different change","commit_id":"e9386b67d9c99ec4b0d2e02440ae07b4ec1d0b74"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"56f498aa4b52139cb69d057c639588553accac7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"123000a9_ede4bf24","updated":"2025-08-04 07:53:19.000000000","message":"run-DellEMC PowerScale CI","commit_id":"e9386b67d9c99ec4b0d2e02440ae07b4ec1d0b74"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6925b7202c6220f7f74bba8b80782867ad132a8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3b59b6bc_e0160398","updated":"2025-08-04 07:41:18.000000000","message":"run-DellEMC PowerScale CI","commit_id":"e9386b67d9c99ec4b0d2e02440ae07b4ec1d0b74"}],"doc/source/configuration/shared-file-systems/drivers/emc-isilon-driver.rst":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"73929f68fdb574ead405539978834066b8e78661","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- Ensure shares."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Thin provisioning"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Back end configuration"},{"line_number":54,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"61c48fc7_a046d7d1","line":51,"range":{"start_line":51,"start_character":1,"end_line":51,"end_character":11},"updated":"2025-07-25 09:08:02.000000000","message":"Thin provisioning is not an operation and should be removed from this list.","commit_id":"069da2eb96a0514669ad7ff66818d9cb7efa8e14"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"d0afb163e188277641a023671e75d6a6dbb27e67","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- Ensure shares."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Thin provisioning"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Back end configuration"},{"line_number":54,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8edce4c6_5b990a8d","line":51,"range":{"start_line":51,"start_character":1,"end_line":51,"end_character":11},"in_reply_to":"302a8054_8f50c41c","updated":"2025-07-27 05:56:03.000000000","message":"The driver claims `thin_provisioning` in the support mapping and you can also add details on PowerScale thin provisioning in below section \"Thin Provisioning\" (L67), for instance, how advisory threshold is related to PowerScale thin provisioning.","commit_id":"069da2eb96a0514669ad7ff66818d9cb7efa8e14"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2e607335e5da8f3b9ae18da9684680c910d4bfc8","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- Ensure shares."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Thin provisioning"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Back end configuration"},{"line_number":54,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"302a8054_8f50c41c","line":51,"range":{"start_line":51,"start_character":1,"end_line":51,"end_character":11},"in_reply_to":"61c48fc7_a046d7d1","updated":"2025-07-25 11:56:37.000000000","message":"Then how does user will know about thin provisioning?","commit_id":"069da2eb96a0514669ad7ff66818d9cb7efa8e14"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f90ec91288ab234a350a850bfc1cc93e3e17c109","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- Ensure shares."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- Thin provisioning"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Back end configuration"},{"line_number":54,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dae9ca34_c36bb224","line":51,"range":{"start_line":51,"start_character":1,"end_line":51,"end_character":11},"in_reply_to":"8edce4c6_5b990a8d","updated":"2025-07-28 11:36:44.000000000","message":"Done","commit_id":"069da2eb96a0514669ad7ff66818d9cb7efa8e14"}],"manila/share/drivers/dell_emc/plugins/isilon/isilon.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2832ba90d1b3dcba3877d63640e772e88bed794f","unresolved":true,"context_lines":[{"line_number":48,"context_line":"               default\u003d\u00270777\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027Predefined ACL value or POSIX mode \u0027"},{"line_number":50,"context_line":"                    \u0027for PowerScale directories.\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027threshold_limit\u0027,"},{"line_number":52,"context_line":"               default\u003d0,"},{"line_number":53,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":54,"context_line":"                    \u0027for triggering Smart Quota alerts\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6338dfa3_630b09d6","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":31},"updated":"2025-07-10 20:45:14.000000000","message":"please prefix this with the name of the driver.. \nsince these options \"fallback\" to the [DEFAULT] section, having an option without context will lead someone to believe this option applies to all drivers","commit_id":"04c02a117c927b753413b067cdf19a368fe6d3a8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"07b0cb625d6c6aa23a2aa5c418f7bd2772b3a460","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               default\u003d\u00270777\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027Predefined ACL value or POSIX mode \u0027"},{"line_number":50,"context_line":"                    \u0027for PowerScale directories.\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027threshold_limit\u0027,"},{"line_number":52,"context_line":"               default\u003d0,"},{"line_number":53,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":54,"context_line":"                    \u0027for triggering Smart Quota alerts\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5811dfeb_d3bb8beb","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":31},"in_reply_to":"6338dfa3_630b09d6","updated":"2025-07-17 08:41:19.000000000","message":"Done","commit_id":"04c02a117c927b753413b067cdf19a368fe6d3a8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2832ba90d1b3dcba3877d63640e772e88bed794f","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    cfg.IntOpt(\u0027threshold_limit\u0027,"},{"line_number":52,"context_line":"               default\u003d0,"},{"line_number":53,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":54,"context_line":"                    \u0027for triggering Smart Quota alerts\u0027)"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"90c94f15_369e21a7","line":54,"range":{"start_line":54,"start_character":54,"end_line":54,"end_character":55},"updated":"2025-07-10 20:45:14.000000000","message":"add \"in Powerscale.\" perhaps?","commit_id":"04c02a117c927b753413b067cdf19a368fe6d3a8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"07b0cb625d6c6aa23a2aa5c418f7bd2772b3a460","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.IntOpt(\u0027threshold_limit\u0027,"},{"line_number":52,"context_line":"               default\u003d0,"},{"line_number":53,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":54,"context_line":"                    \u0027for triggering Smart Quota alerts\u0027)"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"20e7c55c_5fe86dd8","line":54,"range":{"start_line":54,"start_character":54,"end_line":54,"end_character":55},"in_reply_to":"90c94f15_369e21a7","updated":"2025-07-17 08:41:19.000000000","message":"Done","commit_id":"04c02a117c927b753413b067cdf19a368fe6d3a8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"046c4fc622b1eb32738fdf59edc0848aab1ebda7","unresolved":true,"context_lines":[{"line_number":359,"context_line":"            self.reserved_share_extend_percentage)"},{"line_number":360,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d ("},{"line_number":361,"context_line":"            self.max_over_subscription_ratio)"},{"line_number":362,"context_line":"        stats_dict[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        spaces \u003d self._isilon_api.get_space_stats()"},{"line_number":365,"context_line":"        if spaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1320b029_116a78ab","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":46},"updated":"2025-07-23 04:42:33.000000000","message":"If the driver supports both `thin provisioning` and `thick provisioning`, it should report `thin_provisioning\u003d[True, False]`.","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"425feb4e27ec2bdc8388f83aa706f88d411882a4","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            self.reserved_share_extend_percentage)"},{"line_number":360,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d ("},{"line_number":361,"context_line":"            self.max_over_subscription_ratio)"},{"line_number":362,"context_line":"        stats_dict[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        spaces \u003d self._isilon_api.get_space_stats()"},{"line_number":365,"context_line":"        if spaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"d7e49458_60c07bb7","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":46},"in_reply_to":"1320b029_116a78ab","updated":"2025-07-23 05:28:46.000000000","message":"The powerscale driver does not supports ``thick provisioning``.","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c9a803ea6bea837c03574c72f5e9b3e31bcda925","unresolved":true,"context_lines":[{"line_number":359,"context_line":"            self.reserved_share_extend_percentage)"},{"line_number":360,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d ("},{"line_number":361,"context_line":"            self.max_over_subscription_ratio)"},{"line_number":362,"context_line":"        stats_dict[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        spaces \u003d self._isilon_api.get_space_stats()"},{"line_number":365,"context_line":"        if spaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"89b68fb3_12572bff","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":46},"in_reply_to":"28572c48_bcdc3cc6","updated":"2025-07-25 09:18:20.000000000","message":"[3] https://review.opendev.org/c/openstack/manila/+/947255/10/manila/share/drivers/dell_emc/plugins/isilon/isilon_api.py#323","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f90ec91288ab234a350a850bfc1cc93e3e17c109","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            self.reserved_share_extend_percentage)"},{"line_number":360,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d ("},{"line_number":361,"context_line":"            self.max_over_subscription_ratio)"},{"line_number":362,"context_line":"        stats_dict[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        spaces \u003d self._isilon_api.get_space_stats()"},{"line_number":365,"context_line":"        if spaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"4f4540a0_2a509440","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":46},"in_reply_to":"848e445b_729889f2","updated":"2025-07-28 11:36:44.000000000","message":"Thanks! Updated support matrix.","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2e607335e5da8f3b9ae18da9684680c910d4bfc8","unresolved":true,"context_lines":[{"line_number":359,"context_line":"            self.reserved_share_extend_percentage)"},{"line_number":360,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d ("},{"line_number":361,"context_line":"            self.max_over_subscription_ratio)"},{"line_number":362,"context_line":"        stats_dict[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        spaces \u003d self._isilon_api.get_space_stats()"},{"line_number":365,"context_line":"        if spaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"faf8e1f4_37fe1b47","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":46},"in_reply_to":"89b68fb3_12572bff","updated":"2025-07-25 11:56:37.000000000","message":"As I previously explained, there is no concept of thick provisioning tied to the hard_limit. Overprovisioning is already possible with or without this patch—even when hard_limit is set.\n\nEven if we assume that hard_limit implies thick provisioning, PowerScale does not behave accordingly. The reported share state (free_capacity_gb) still reflects used_space, not the hard_limit.\n\nFor example, without this patch:\n\ntotal_capacity_gb: 20807\n\nfree_capacity_gb: 20799\nYet, I am still able to create shares totaling more than 35 TB—which clearly exceeds the reported free space.\n\nSo the question remains: where exactly is thick provisioning?","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"73929f68fdb574ead405539978834066b8e78661","unresolved":true,"context_lines":[{"line_number":359,"context_line":"            self.reserved_share_extend_percentage)"},{"line_number":360,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d ("},{"line_number":361,"context_line":"            self.max_over_subscription_ratio)"},{"line_number":362,"context_line":"        stats_dict[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        spaces \u003d self._isilon_api.get_space_stats()"},{"line_number":365,"context_line":"        if spaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"28572c48_bcdc3cc6","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":46},"in_reply_to":"d7e49458_60c07bb7","updated":"2025-07-25 09:08:02.000000000","message":"Please refer to [1] for details of manila `thin_provisioning`. \n\nThe driver claimed support of `thick_provisioning` since L-release [2]. It\u0027s implemented by create quota with `hard limit`, which size can\u0027t be exceeded.\n\nIn this patch [3], when threshold config is larger than 0, it creates quota with `advisory limit`, which size can be exceeded. Otherwise, it creates quota with `hard limit`.\nIt appears a mixture of thin and thick provision.\n\nBesides, our requirement is to add support for thin provisioning, but not deprecate thick provisioning. \n\n[1] https://docs.openstack.org/manila/latest/admin/capabilities_and_extra_specs.html#share-type-common-capability-extra-specs-that-are-not-visible-to-end-users\n[2] https://review.opendev.org/c/openstack/manila/+/947255/10/doc/source/admin/share_back_ends_feature_support_mapping.rst#287\n[3]","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"d0afb163e188277641a023671e75d6a6dbb27e67","unresolved":true,"context_lines":[{"line_number":359,"context_line":"            self.reserved_share_extend_percentage)"},{"line_number":360,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d ("},{"line_number":361,"context_line":"            self.max_over_subscription_ratio)"},{"line_number":362,"context_line":"        stats_dict[\u0027thin_provisioning\u0027] \u003d True"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        spaces \u003d self._isilon_api.get_space_stats()"},{"line_number":365,"context_line":"        if spaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"848e445b_729889f2","line":362,"range":{"start_line":362,"start_character":0,"end_line":362,"end_character":46},"in_reply_to":"faf8e1f4_37fe1b47","updated":"2025-07-27 05:56:03.000000000","message":"It took me some time to figure out what\u0027s changed in this patch:\n1) Only L362 is to claim support of thin provisioning.\n2) Other code changes add support of PowerScale advisory quota with threshold.\n\nSince thick provisioning is never supported, please remove it form the support mapping [1] to avoid confusion.\n\nAnswering the above question about thick provisioning and free space in manila scheduler:\nManila scheduler weighs hosts by free capacity, taking into account the reserved space.\nThe `reserved_percentage` is by default 0, hence, I assume creating a new share of size larger than the free space will fail.\n\n[1]https://review.opendev.org/c/openstack/manila/+/947255/10/doc/source/admin/share_back_ends_feature_support_mapping.rst#287","commit_id":"30c357a239754203ecdb7d1eb7c0378830200d5d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"d0afb163e188277641a023671e75d6a6dbb27e67","unresolved":true,"context_lines":[{"line_number":47,"context_line":"               default\u003d\u00270777\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027Predefined ACL value or POSIX mode \u0027"},{"line_number":49,"context_line":"                    \u0027for PowerScale directories.\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027powerscale_threshold_limit\u0027,"},{"line_number":51,"context_line":"               default\u003d0,"},{"line_number":52,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":53,"context_line":"                    \u0027for triggering Smart Quota alerts in PowerScale\u0027)"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"aefc3b10_fdcd91eb","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":70},"updated":"2025-07-27 05:56:03.000000000","message":"Previously, I thought it\u0027s a config to switch thin/thick provisioning. It turns out just a config to create advisory quota instead of hard quota.\nBesides, PowerScale quota module is `SmartQuotas`, not `Smart Quota`.","commit_id":"069da2eb96a0514669ad7ff66818d9cb7efa8e14"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f90ec91288ab234a350a850bfc1cc93e3e17c109","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               default\u003d\u00270777\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027Predefined ACL value or POSIX mode \u0027"},{"line_number":49,"context_line":"                    \u0027for PowerScale directories.\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027powerscale_threshold_limit\u0027,"},{"line_number":51,"context_line":"               default\u003d0,"},{"line_number":52,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":53,"context_line":"                    \u0027for triggering Smart Quota alerts in PowerScale\u0027)"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2f294859_9f24adb0","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":70},"in_reply_to":"aefc3b10_fdcd91eb","updated":"2025-07-28 11:36:44.000000000","message":"Done","commit_id":"069da2eb96a0514669ad7ff66818d9cb7efa8e14"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fae6bb35b796a1c1297f75bcb72fed9ef5afc65","unresolved":true,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Predefined ACL value or POSIX mode \u0027"},{"line_number":48,"context_line":"                    \u0027for PowerScale directories.\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027powerscale_threshold_limit\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":52,"context_line":"                    \u0027for triggering SmartQuotas alerts in PowerScale\u0027)"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"52701371_b872d64e","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":25},"updated":"2025-08-01 04:46:21.000000000","message":"does this mean that the alerts are always on?","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e3d3faa21607a1e8c78d119b7edabb296b124346","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Predefined ACL value or POSIX mode \u0027"},{"line_number":48,"context_line":"                    \u0027for PowerScale directories.\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027powerscale_threshold_limit\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027Specifies the threshold limit (in percentage) \u0027"},{"line_number":52,"context_line":"                    \u0027for triggering SmartQuotas alerts in PowerScale\u0027)"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":17,"id":"48a15ad8_590b801f","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":25},"in_reply_to":"52701371_b872d64e","updated":"2025-08-01 06:05:19.000000000","message":"No, if threshold limit is zero then it will not going to set advisory limit on share quota.","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05ad8ae3d015334b8c70e0c7379e4674715198dd","unresolved":true,"context_lines":[{"line_number":364,"context_line":"        if spaces:"},{"line_number":365,"context_line":"            stats_dict[\u0027total_capacity_gb\u0027] \u003d spaces[\u0027total\u0027] // units.Gi"},{"line_number":366,"context_line":"            stats_dict[\u0027free_capacity_gb\u0027] \u003d spaces[\u0027free\u0027] // units.Gi"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def get_network_allocations_number(self):"},{"line_number":369,"context_line":"        \"\"\"Returns number of network allocations for creating VIFs.\"\"\""},{"line_number":370,"context_line":"        # TODO(Shaun Edwards)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ef261138_ee2d1dab","line":367,"updated":"2025-08-01 04:48:49.000000000","message":"when thin provisioning is supported, you\u0027d also need to report apparent total allocation: \"allocated_capacity_gb\" - this is the sum total of all the promised quota - whether or not the allocation was made through Manila. \n\nIs this a metric you can get from the backend?","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f910cec71014832742c901cbae923d4557f42afd","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        if spaces:"},{"line_number":365,"context_line":"            stats_dict[\u0027total_capacity_gb\u0027] \u003d spaces[\u0027total\u0027] // units.Gi"},{"line_number":366,"context_line":"            stats_dict[\u0027free_capacity_gb\u0027] \u003d spaces[\u0027free\u0027] // units.Gi"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def get_network_allocations_number(self):"},{"line_number":369,"context_line":"        \"\"\"Returns number of network allocations for creating VIFs.\"\"\""},{"line_number":370,"context_line":"        # TODO(Shaun Edwards)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5787edff_ff4cc49b","line":367,"in_reply_to":"92555530_575fefd9","updated":"2025-08-01 22:32:48.000000000","message":"@gouthampravi@gmail.com\n\nThanks for clarification. I have updated the code according. please review it.","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e3d3faa21607a1e8c78d119b7edabb296b124346","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        if spaces:"},{"line_number":365,"context_line":"            stats_dict[\u0027total_capacity_gb\u0027] \u003d spaces[\u0027total\u0027] // units.Gi"},{"line_number":366,"context_line":"            stats_dict[\u0027free_capacity_gb\u0027] \u003d spaces[\u0027free\u0027] // units.Gi"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def get_network_allocations_number(self):"},{"line_number":369,"context_line":"        \"\"\"Returns number of network allocations for creating VIFs.\"\"\""},{"line_number":370,"context_line":"        # TODO(Shaun Edwards)"}],"source_content_type":"text/x-python","patch_set":17,"id":"f12f1574_3fab5bbd","line":367,"in_reply_to":"ef261138_ee2d1dab","updated":"2025-08-01 06:05:19.000000000","message":"There is no direct API to retrieve this information. However, we can use the quota API to get the hard limit for each share and calculate the total by summing them up.\n\nShould we implement this? Also, should we include quotas for shares that are not under the PowerScale Manila driver’s root directory?","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb1efddb4cda581d1b4115068bcfc0dce3299c9f","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        if spaces:"},{"line_number":365,"context_line":"            stats_dict[\u0027total_capacity_gb\u0027] \u003d spaces[\u0027total\u0027] // units.Gi"},{"line_number":366,"context_line":"            stats_dict[\u0027free_capacity_gb\u0027] \u003d spaces[\u0027free\u0027] // units.Gi"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def get_network_allocations_number(self):"},{"line_number":369,"context_line":"        \"\"\"Returns number of network allocations for creating VIFs.\"\"\""},{"line_number":370,"context_line":"        # TODO(Shaun Edwards)"}],"source_content_type":"text/x-python","patch_set":17,"id":"92555530_575fefd9","line":367,"in_reply_to":"f12f1574_3fab5bbd","updated":"2025-08-01 20:55:30.000000000","message":"\u003e There is no direct API to retrieve this information. However, we can use the quota API to get the hard limit for each share and calculate the total by summing them up.\n\nThat would be similar to what manila\u0027s scheduler will do when the allocated_capacity_gb isn\u0027t provided for a thin_provisioned backend. So it\u0027s up to you in case you are able to do it efficiently\n\n\u003e Should we implement this? Also, should we include quotas for shares that are not under the PowerScale Manila driver’s root directory?\n\nI think this will depend on how the storage is allocated, and what \"get_space_stats\" gives you in the code above. If the total/free space reported is only for the powerscale root directory, you need to only calculate what apparent storage quota has been handed out.. if it is the space stats in the whole storage system, then, you\u0027ll need to ensure things outside of the root directory are accounted for as well.\n\nThe underlying notion is that overprovisioning can be dangerous if you don\u0027t know how much is actually consumed. I think i found a nice example in netapp\u0027s docs for this: https://netapp-openstack-dev.github.io/openstack-docs/wallaby/cinder/deployment_choice/section_over-subscription.html","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"}],"manila/tests/share/drivers/dell_emc/plugins/isilon/test_isilon.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fae6bb35b796a1c1297f75bcb72fed9ef5afc65","unresolved":true,"context_lines":[{"line_number":516,"context_line":"            \u0027max_over_subscription_ratio\u0027: None,"},{"line_number":517,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":518,"context_line":"            \u0027total_capacity_gb\u0027: 1000,"},{"line_number":519,"context_line":"            \u0027free_capacity_gb\u0027: 100"},{"line_number":520,"context_line":"        }"},{"line_number":521,"context_line":"        self.assertEqual(expected_stats, stats_dict)"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"03aad02a_efaf7ae6","line":519,"range":{"start_line":519,"start_character":32,"end_line":519,"end_character":35},"updated":"2025-08-01 04:46:21.000000000","message":"add a trailing comma at the end of the last element","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e3d3faa21607a1e8c78d119b7edabb296b124346","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            \u0027max_over_subscription_ratio\u0027: None,"},{"line_number":517,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":518,"context_line":"            \u0027total_capacity_gb\u0027: 1000,"},{"line_number":519,"context_line":"            \u0027free_capacity_gb\u0027: 100"},{"line_number":520,"context_line":"        }"},{"line_number":521,"context_line":"        self.assertEqual(expected_stats, stats_dict)"},{"line_number":522,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7ac48207_e11d32dd","line":519,"range":{"start_line":519,"start_character":32,"end_line":519,"end_character":35},"in_reply_to":"03aad02a_efaf7ae6","updated":"2025-08-01 06:05:19.000000000","message":"I\u0027ll update this if there are any changes.","commit_id":"d74f72cf2d6cc881e75162d0b5a4d253bf3b6772"}]}
