)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3515aae4f9b1ac5906a066ec3c81c63602ed3384","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add wsgi module and drop setup entrypoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes in python packaging tooling mean that the wsgi_scripts"},{"line_number":10,"context_line":"functionality via PBR no longer works."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This also aligns Manila to a proposed OpenStack goal [1]."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bad2047b_4ebdd982","line":10,"updated":"2025-05-06 18:56:56.000000000","message":"thats incorect.\n\nit does work it just was not turned on.\n\nsince the repo did not have a pyproject.toml seuptools fell back to its vendored pyporject.toml and it default to setuptools as the build system not pbr.\n\nso the job broke because pbr was turnded off\n\nthe backwared compatible way to fix this can be seen in \n\nhttps://review.opendev.org/c/openstack/watcher/+/948438\nto get grenade to pass you have to merge it on stable/2025.1 first\nhttps://review.opendev.org/c/openstack/watcher/+/948502\n\nand then on master you can add a depends on against the stabel verion of the patch\nhttps://review.opendev.org/c/openstack/watcher/+/948438/8//COMMIT_MSG#42\nto test it before the stable verion is merged\n\nor jsut wait and recheck the master version.","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"faeea846888b79b4190bd770d9194ad39926f7ae","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add wsgi module and drop setup entrypoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes in python packaging tooling mean that the wsgi_scripts"},{"line_number":10,"context_line":"functionality via PBR no longer works."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This also aligns Manila to a proposed OpenStack goal [1]."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3cff9e65_6706b159","line":10,"in_reply_to":"7199a9a9_f96fb79d","updated":"2025-05-08 12:00:43.000000000","message":"Done","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d41e69e399305b865c9583211ae1d5335b3fddd2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add wsgi module and drop setup entrypoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes in python packaging tooling mean that the wsgi_scripts"},{"line_number":10,"context_line":"functionality via PBR no longer works."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This also aligns Manila to a proposed OpenStack goal [1]."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7199a9a9_f96fb79d","line":10,"in_reply_to":"bad2047b_4ebdd982","updated":"2025-05-07 16:48:02.000000000","message":"Yeah, what Sean said. It is deprecated and will break eventually when setuptools kills the easy_install stuff fully, but it still works for now...once you have a `pyproject.toml`.","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b51d75c8e55c74004870537161cc2aaec19a6b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16fee234_a63d0ddf","updated":"2025-05-01 23:07:25.000000000","message":"Hey @stephenfin@redhat.com: If you\u0027re able to take a look and see if we\u0027re doing this right, specially in terms of dropping the wsgi_scripts from setup.cfg, because, it\u0027s useless to have it with the latest setuptools..","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c25d70a3964e9ebd22ca50d22b2969e090a0d065","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"348fb81a_c148c775","in_reply_to":"16fee234_a63d0ddf","updated":"2025-05-06 18:57:37.000000000","message":"its not seee https://review.opendev.org/c/openstack/manila/+/948491/comment/bad2047b_4ebdd982/","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"faeea846888b79b4190bd770d9194ad39926f7ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6209a092_2f6ddeae","in_reply_to":"348fb81a_c148c775","updated":"2025-05-08 12:00:43.000000000","message":"Done","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1bdff0cca759942ddea91fd4b0f94771c2209428","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1af690d7_dc90f472","updated":"2025-05-09 20:14:21.000000000","message":"LGTM, thanks Goutham and Stephen for working on this change!","commit_id":"a13d6c80627a3394ffd6e2f5f416bad49a2f1d5c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6936ec6186dfd0929c3f0118b35f5bebc0e24c0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9c3070c0_086defec","updated":"2025-05-08 21:39:57.000000000","message":"Thanks for the updated change, @stephenfin@redhat.com ; and for the review comments @smooney@redhat.com ; and for the commit message fixup @kajinamit@oss.nttdata.com\n\nSince grenade was marked voting here, we\u0027ll get this landed in 2025.1 first: https://review.opendev.org/c/openstack/manila/+/949279\n\nbefore reviewing/workflowing this.","commit_id":"a13d6c80627a3394ffd6e2f5f416bad49a2f1d5c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bdce518d889f8d023614fd6b6edb1c7215f73451","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de4bc8c0_0ccbe65d","updated":"2025-05-09 20:12:01.000000000","message":"recheck\n\n+2 because others have edited this change, and approved it in effect.. \n\nhttps://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/DOJZL5WZJMN4NEAD5GLIQZ455D2NUREY/","commit_id":"a13d6c80627a3394ffd6e2f5f416bad49a2f1d5c"}],"devstack/settings":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d41e69e399305b865c9583211ae1d5335b3fddd2","unresolved":true,"context_lines":[{"line_number":97,"context_line":"# migrations again."},{"line_number":98,"context_line":"MANILA_USE_DOWNGRADE_MIGRATIONS\u003d${MANILA_USE_DOWNGRADE_MIGRATIONS:-\"False\"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Toggle for deploying manila-api service under Apache web server with enabled"},{"line_number":101,"context_line":"# \u0027mod_wsgi\u0027 plugin."},{"line_number":102,"context_line":"MANILA_USE_MOD_WSGI\u003d${MANILA_USE_MOD_WSGI:-False}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# Toggle for deploying manila-api service with uWSGI"},{"line_number":105,"context_line":"# Set it as True, because starting with Pike it is requirement from"},{"line_number":106,"context_line":"# \u0027governance\u0027 project. See:"},{"line_number":107,"context_line":"# https://governance.openstack.org/tc/goals/pike/deploy-api-in-wsgi.html#completion-criteria"},{"line_number":108,"context_line":"MANILA_USE_UWSGI\u003d${MANILA_USE_UWSGI:-True}"},{"line_number":109,"context_line":"MANILA_WSGI\u003dmanila.wsgi.api:application"},{"line_number":110,"context_line":"MANILA_UWSGI_CONF\u003d$MANILA_CONF_DIR/manila-uwsgi.ini"},{"line_number":111,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"4af256c8_f889ccbc","line":108,"range":{"start_line":100,"start_character":0,"end_line":108,"end_character":42},"updated":"2025-05-07 16:48:02.000000000","message":"You probably want to remove both of these too. mod_wsgi needs a `.wsgi` file so this will no longer work unless you plan on vendoring your own one (and why bother). fwiw, we did just that for Cinder and Nova previously.","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"faeea846888b79b4190bd770d9194ad39926f7ae","unresolved":false,"context_lines":[{"line_number":97,"context_line":"# migrations again."},{"line_number":98,"context_line":"MANILA_USE_DOWNGRADE_MIGRATIONS\u003d${MANILA_USE_DOWNGRADE_MIGRATIONS:-\"False\"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Toggle for deploying manila-api service under Apache web server with enabled"},{"line_number":101,"context_line":"# \u0027mod_wsgi\u0027 plugin."},{"line_number":102,"context_line":"MANILA_USE_MOD_WSGI\u003d${MANILA_USE_MOD_WSGI:-False}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# Toggle for deploying manila-api service with uWSGI"},{"line_number":105,"context_line":"# Set it as True, because starting with Pike it is requirement from"},{"line_number":106,"context_line":"# \u0027governance\u0027 project. See:"},{"line_number":107,"context_line":"# https://governance.openstack.org/tc/goals/pike/deploy-api-in-wsgi.html#completion-criteria"},{"line_number":108,"context_line":"MANILA_USE_UWSGI\u003d${MANILA_USE_UWSGI:-True}"},{"line_number":109,"context_line":"MANILA_WSGI\u003dmanila.wsgi.api:application"},{"line_number":110,"context_line":"MANILA_UWSGI_CONF\u003d$MANILA_CONF_DIR/manila-uwsgi.ini"},{"line_number":111,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"a90ad1a0_7cb9d49d","line":108,"range":{"start_line":100,"start_character":0,"end_line":108,"end_character":42},"in_reply_to":"4af256c8_f889ccbc","updated":"2025-05-08 12:00:43.000000000","message":"Done (via follow-up changes).","commit_id":"1eb20da23363ac03cdcbdefc71ace8c4b39a082b"}],"setup.cfg":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3515aae4f9b1ac5906a066ec3c81c63602ed3384","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    manila-scheduler \u003d manila.cmd.scheduler:main"},{"line_number":39,"context_line":"    manila-share \u003d manila.cmd.share:main"},{"line_number":40,"context_line":"    manila-status \u003d manila.cmd.status:main"},{"line_number":41,"context_line":"wsgi_scripts \u003d"},{"line_number":42,"context_line":"    manila-wsgi \u003d manila.wsgi.wsgi:initialize_application"},{"line_number":43,"context_line":"manila.scheduler.filters \u003d"},{"line_number":44,"context_line":"    AffinityFilter \u003d manila.scheduler.filters.affinity:AffinityFilter"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"d6e547e7_556b90fc","side":"PARENT","line":41,"updated":"2025-05-06 18:56:56.000000000","message":"-1 we shoudl not drop this in the same release where the api module is added.\n\n\nThese still work if you have a pyproject.toml and have enabel pbr in setup.py\n\nso while this shoudl be remvoed evenutlaly. for upgrade reasons, you should not do it in this patch as none of the installer supports outside of devstack the new way of running the api.\n\n\nwhen i fixed watcher gate i keep these scripts adn the still generate if not doing an editable install.","commit_id":"5fadf50c80dddd6c1cb167fd1d10debd5092fe0e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"faeea846888b79b4190bd770d9194ad39926f7ae","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    manila-scheduler \u003d manila.cmd.scheduler:main"},{"line_number":39,"context_line":"    manila-share \u003d manila.cmd.share:main"},{"line_number":40,"context_line":"    manila-status \u003d manila.cmd.status:main"},{"line_number":41,"context_line":"wsgi_scripts \u003d"},{"line_number":42,"context_line":"    manila-wsgi \u003d manila.wsgi.wsgi:initialize_application"},{"line_number":43,"context_line":"manila.scheduler.filters \u003d"},{"line_number":44,"context_line":"    AffinityFilter \u003d manila.scheduler.filters.affinity:AffinityFilter"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"8f66effb_305f7f2d","side":"PARENT","line":41,"in_reply_to":"574c0260_3dd9e24e","updated":"2025-05-08 12:00:43.000000000","message":"Done","commit_id":"5fadf50c80dddd6c1cb167fd1d10debd5092fe0e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d41e69e399305b865c9583211ae1d5335b3fddd2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    manila-scheduler \u003d manila.cmd.scheduler:main"},{"line_number":39,"context_line":"    manila-share \u003d manila.cmd.share:main"},{"line_number":40,"context_line":"    manila-status \u003d manila.cmd.status:main"},{"line_number":41,"context_line":"wsgi_scripts \u003d"},{"line_number":42,"context_line":"    manila-wsgi \u003d manila.wsgi.wsgi:initialize_application"},{"line_number":43,"context_line":"manila.scheduler.filters \u003d"},{"line_number":44,"context_line":"    AffinityFilter \u003d manila.scheduler.filters.affinity:AffinityFilter"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"574c0260_3dd9e24e","side":"PARENT","line":41,"in_reply_to":"d6e547e7_556b90fc","updated":"2025-05-07 16:48:02.000000000","message":"I agree we shouldn\u0027t do it in the same commit (so as not to break grenade), but I think the ship has sailed on not doing it in the same release. Designate and Octavia have already removed their scripts and other will likely be doing so shortly. In addition, the feature that enables this is on life support in pbr due to ongoing setuptools changes and I wouldn\u0027t be surprised to see it disappear without notice (at least from our perspective, since none of us are involved in upstream setuptools work). Once we notify packagers (and I\u0027ll be sending a mail about this shortly), I see no reason to keep it around longer than necessary here.","commit_id":"5fadf50c80dddd6c1cb167fd1d10debd5092fe0e"}]}