)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e77ac90e1b3669628003bf43ab82f8e06fad8799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"302d9d15_fc98e692","updated":"2025-05-29 15:39:51.000000000","message":"This sounds like a new feature... which is fine, but we must weigh the implications of turning this on by default on existing deployments..\n\n\nAlso, newer versions of ONTAP have different semantics:\n\n\nhttps://docs.netapp.com/us-en/ontap/smb-admin/enable-disable-aes-encryption-kerberos-task.html\n\nWhether AES encryption is enabled by default and whether you have the option to specify encryption types depends on your ONTAP version.","commit_id":"61b2dbadb790a9a94858dd3b704f0618b31e11e6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7f98c5157c909677ffea05bbe9d7cf1010a49a4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"53f5d3d2_6551e571","updated":"2025-05-29 09:59:40.000000000","message":"recheck","commit_id":"61b2dbadb790a9a94858dd3b704f0618b31e11e6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e634f09519def26a4e72e765a544435f23050049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"13725ceb_142f6d19","in_reply_to":"302d9d15_fc98e692","updated":"2025-07-10 15:42:11.000000000","message":"the default is kept false for config option and so it will be no-op for existing deployment. Admin should enable it wherever needed. Also the way to specify is differ in ONTAP version and that is also implemented.","commit_id":"61b2dbadb790a9a94858dd3b704f0618b31e11e6"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c2940a9ff5641a8409242ab0e58c8a9718651350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"949ba1ff_7e3ad439","updated":"2025-06-22 15:02:16.000000000","message":"Thanks Kiran for working on this. The changes look good to me, but I have a few minor comments","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"dedac2ca36e37cd7dc389da52d366cdacdc98ff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f014ac2_53ba61ee","updated":"2025-07-09 15:54:00.000000000","message":"Thanks kiran for incorporating the all review comments. I have one more minor comment, please check this also","commit_id":"2846a499b07b19a63a776e57d6cd558ff4a78929"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ffa89407c54326ea165cd7be8f5a62ecbe679f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4fd429ad_7dc2c02c","updated":"2025-07-11 11:19:47.000000000","message":"LGTM ..!","commit_id":"1823f199042542296559a3f7fc906b0ae957be2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a933cfa1017e2e400efde1ae7c9ecc7688bd30b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c723a1f5_d9a52725","updated":"2025-07-10 20:53:58.000000000","message":"NetApp CI is failing this change, i\u0027ve no way to know whether this works or not.. so NetApp folks, could you please take a look? @gawasthi2010@gmail.com @saikumar1016@gmail.com @anoop.shukla@netapp.com","commit_id":"1823f199042542296559a3f7fc906b0ae957be2f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c87c74b4da374e3827b04fe312e96e61d95abad4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e49c201_ab2b085e","in_reply_to":"43fc767e_95ba09a6","updated":"2025-07-11 11:30:38.000000000","message":"Yes, ZAPI testing is done for older ONTAP versions.","commit_id":"1823f199042542296559a3f7fc906b0ae957be2f"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ffa89407c54326ea165cd7be8f5a62ecbe679f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43fc767e_95ba09a6","in_reply_to":"c723a1f5_d9a52725","updated":"2025-07-11 11:19:47.000000000","message":"We are expecting that @kinpaa@gmail.com has done the basic functional testing with ZAPI, for test workflow I have checked API parameter passing through REST APIs.","commit_id":"1823f199042542296559a3f7fc906b0ae957be2f"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e77ac90e1b3669628003bf43ab82f8e06fad8799","unresolved":true,"context_lines":[{"line_number":2221,"context_line":"    @na_utils.trace"},{"line_number":2222,"context_line":"    def configure_cifs_encryption(self):"},{"line_number":2223,"context_line":"        api_args \u003d {"},{"line_number":2224,"context_line":"            \u0027is-aes-encryption-enabled\u0027: \u0027true\u0027"},{"line_number":2225,"context_line":"        }"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0669e5b_d489c231","line":2224,"range":{"start_line":2224,"start_character":46,"end_line":2224,"end_character":47},"updated":"2025-05-29 15:39:51.000000000","message":"nit: trailing comma","commit_id":"61b2dbadb790a9a94858dd3b704f0618b31e11e6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b70bc4cd3d8cf8388089682ae21eea65a75625fa","unresolved":false,"context_lines":[{"line_number":2221,"context_line":"    @na_utils.trace"},{"line_number":2222,"context_line":"    def configure_cifs_encryption(self):"},{"line_number":2223,"context_line":"        api_args \u003d {"},{"line_number":2224,"context_line":"            \u0027is-aes-encryption-enabled\u0027: \u0027true\u0027"},{"line_number":2225,"context_line":"        }"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc709825_c8040e5a","line":2224,"range":{"start_line":2224,"start_character":46,"end_line":2224,"end_character":47},"in_reply_to":"d0669e5b_d489c231","updated":"2025-05-30 13:30:57.000000000","message":"Done","commit_id":"61b2dbadb790a9a94858dd3b704f0618b31e11e6"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c2940a9ff5641a8409242ab0e58c8a9718651350","unresolved":true,"context_lines":[{"line_number":2224,"context_line":"            LOG.warning(msg, msg_args)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"    @na_utils.trace"},{"line_number":2227,"context_line":"    def configure_cifs_encryption(self, aes_encryption):"},{"line_number":2228,"context_line":"        if self.features.AES_ENCRYPTION_TYPES:"},{"line_number":2229,"context_line":"            api_args \u003d {"},{"line_number":2230,"context_line":"                \u0027advertised-enc-types\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"b51cf51f_d3cd7c43","line":2227,"range":{"start_line":2227,"start_character":8,"end_line":2227,"end_character":33},"updated":"2025-06-22 15:02:16.000000000","message":"Modify method name to \"configure_cifs_aes_encryption\" for more readability.","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f286f8d7d495e4f098a26dd4790d385546375bf1","unresolved":false,"context_lines":[{"line_number":2224,"context_line":"            LOG.warning(msg, msg_args)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"    @na_utils.trace"},{"line_number":2227,"context_line":"    def configure_cifs_encryption(self, aes_encryption):"},{"line_number":2228,"context_line":"        if self.features.AES_ENCRYPTION_TYPES:"},{"line_number":2229,"context_line":"            api_args \u003d {"},{"line_number":2230,"context_line":"                \u0027advertised-enc-types\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"c2824d88_e3d4221c","line":2227,"range":{"start_line":2227,"start_character":8,"end_line":2227,"end_character":33},"in_reply_to":"b51cf51f_d3cd7c43","updated":"2025-06-24 10:57:45.000000000","message":"Done","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c2940a9ff5641a8409242ab0e58c8a9718651350","unresolved":true,"context_lines":[{"line_number":4250,"context_line":"                self.set_preferred_dc(new_security_service, svm_uuid)"},{"line_number":4251,"context_line":""},{"line_number":4252,"context_line":"    @na_utils.trace"},{"line_number":4253,"context_line":"    def configure_cifs_encryption(self, vserver_name, aes_encryption):"},{"line_number":4254,"context_line":"        try:"},{"line_number":4255,"context_line":"            svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":4256,"context_line":"            body \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"73b467a5_dd4a36fb","line":4253,"range":{"start_line":4253,"start_character":8,"end_line":4253,"end_character":33},"updated":"2025-06-22 15:02:16.000000000","message":"Modify method name to \"configure_cifs_aes_encryption\" for more readability.","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f286f8d7d495e4f098a26dd4790d385546375bf1","unresolved":false,"context_lines":[{"line_number":4250,"context_line":"                self.set_preferred_dc(new_security_service, svm_uuid)"},{"line_number":4251,"context_line":""},{"line_number":4252,"context_line":"    @na_utils.trace"},{"line_number":4253,"context_line":"    def configure_cifs_encryption(self, vserver_name, aes_encryption):"},{"line_number":4254,"context_line":"        try:"},{"line_number":4255,"context_line":"            svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":4256,"context_line":"            body \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"e9c4257d_ea40c3d1","line":4253,"range":{"start_line":4253,"start_character":8,"end_line":4253,"end_character":33},"in_reply_to":"73b467a5_dd4a36fb","updated":"2025-06-24 10:57:45.000000000","message":"Done","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c2940a9ff5641a8409242ab0e58c8a9718651350","unresolved":true,"context_lines":[{"line_number":271,"context_line":"                     \u0027 partner node will be able to takeover all data LIFs.\u0027),"},{"line_number":272,"context_line":"    cfg.BoolOpt(\u0027netapp_cifs_aes_encryption\u0027,"},{"line_number":273,"context_line":"                default\u003dFalse,"},{"line_number":274,"context_line":"                help\u003d\u0027This will enable/disable the AES encryption for CIFS \u0027"},{"line_number":275,"context_line":"                     \u0027shares. \u0027),"},{"line_number":276,"context_line":"]"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"netapp_cluster_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"fdf1057d_a1ae8c79","line":275,"range":{"start_line":274,"start_character":16,"end_line":275,"end_character":33},"updated":"2025-06-22 15:02:16.000000000","message":"This need to change, we are configuring AES encryption for vserver not for share.\nDescription should be \nThis option enables or disables AES encryption for the share server based on the parameter value (True/False)","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f286f8d7d495e4f098a26dd4790d385546375bf1","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                     \u0027 partner node will be able to takeover all data LIFs.\u0027),"},{"line_number":272,"context_line":"    cfg.BoolOpt(\u0027netapp_cifs_aes_encryption\u0027,"},{"line_number":273,"context_line":"                default\u003dFalse,"},{"line_number":274,"context_line":"                help\u003d\u0027This will enable/disable the AES encryption for CIFS \u0027"},{"line_number":275,"context_line":"                     \u0027shares. \u0027),"},{"line_number":276,"context_line":"]"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"netapp_cluster_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"4098b2c1_96a94f1f","line":275,"range":{"start_line":274,"start_character":16,"end_line":275,"end_character":33},"in_reply_to":"fdf1057d_a1ae8c79","updated":"2025-06-24 10:57:45.000000000","message":"Done","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"}],"releasenotes/notes/netapp-enable-aes-encryption-for-cifs-a1f98e5cb0010ea0.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e77ac90e1b3669628003bf43ab82f8e06fad8799","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver now supports aes-encryption for CIFS shares."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3c245ce2_c891b1d6","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":68},"updated":"2025-05-29 15:39:51.000000000","message":"not for all CIFS shares, only those created on new share servers, and on existing share servers only when the AD security service is being updated","commit_id":"61b2dbadb790a9a94858dd3b704f0618b31e11e6"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b70bc4cd3d8cf8388089682ae21eea65a75625fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver now supports aes-encryption for CIFS shares."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"398a7fac_7cf84225","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":68},"in_reply_to":"3c245ce2_c891b1d6","updated":"2025-05-30 13:30:57.000000000","message":"Done","commit_id":"61b2dbadb790a9a94858dd3b704f0618b31e11e6"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c2940a9ff5641a8409242ab0e58c8a9718651350","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver now supports aes-encryption for CIFS shares. It will"},{"line_number":5,"context_line":"    be applicable for shares created on new share servers, and on existing"},{"line_number":6,"context_line":"    share servers only when the AD security service is being updated. Admin"},{"line_number":7,"context_line":"    needs to set \u0027netapp_cifs_aes_encryption\u0027 config option to \u0027True\u0027 in"},{"line_number":8,"context_line":"    order to enable it."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ddfa4c6f_b94929a7","line":8,"range":{"start_line":4,"start_character":2,"end_line":8,"end_character":23},"updated":"2025-06-22 15:02:16.000000000","message":"Add the bug link in description\nhttps://bugs.launchpad.net/manila/+bug/2111813","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f286f8d7d495e4f098a26dd4790d385546375bf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver now supports aes-encryption for CIFS shares. It will"},{"line_number":5,"context_line":"    be applicable for shares created on new share servers, and on existing"},{"line_number":6,"context_line":"    share servers only when the AD security service is being updated. Admin"},{"line_number":7,"context_line":"    needs to set \u0027netapp_cifs_aes_encryption\u0027 config option to \u0027True\u0027 in"},{"line_number":8,"context_line":"    order to enable it."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e36f2364_8cb4f6c5","line":8,"range":{"start_line":4,"start_character":2,"end_line":8,"end_character":23},"in_reply_to":"ddfa4c6f_b94929a7","updated":"2025-06-24 10:57:45.000000000","message":"Done","commit_id":"576a6121a60b66c793b02dbbd03b0784ed240d46"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"dedac2ca36e37cd7dc389da52d366cdacdc98ff7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver now supports aes-encryption for CIFS shares. It will"},{"line_number":5,"context_line":"    be applicable for shares created on new share servers, and on existing"},{"line_number":6,"context_line":"    share servers only when the AD security service is being updated. Admin"},{"line_number":7,"context_line":"    needs to set \u0027netapp_cifs_aes_encryption\u0027 config option to \u0027True\u0027 in"},{"line_number":8,"context_line":"    order to enable it."},{"line_number":9,"context_line":"fixes:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The aes-encryption fixes KRB5KDC_ERR_ETYPE_NOSUPP error observed during"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5779c5f0_f44f32bc","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":23},"updated":"2025-07-09 15:54:00.000000000","message":"This is bug fix so we need to remove this part.","commit_id":"2846a499b07b19a63a776e57d6cd558ff4a78929"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"963a8627f3553b7ea656a8205fcc3ce0958c0e58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver now supports aes-encryption for CIFS shares. It will"},{"line_number":5,"context_line":"    be applicable for shares created on new share servers, and on existing"},{"line_number":6,"context_line":"    share servers only when the AD security service is being updated. Admin"},{"line_number":7,"context_line":"    needs to set \u0027netapp_cifs_aes_encryption\u0027 config option to \u0027True\u0027 in"},{"line_number":8,"context_line":"    order to enable it."},{"line_number":9,"context_line":"fixes:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The aes-encryption fixes KRB5KDC_ERR_ETYPE_NOSUPP error observed during"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2f4044ca_fce0117e","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":23},"in_reply_to":"5779c5f0_f44f32bc","updated":"2025-07-10 08:23:22.000000000","message":"Done","commit_id":"2846a499b07b19a63a776e57d6cd558ff4a78929"}]}