)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4135b48335d41af348cb4dc9abda007d078ffb4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2779c36f_c144b39a","updated":"2025-06-23 06:24:16.000000000","message":"I have added required unit tests, please review. If any test is missed, I will add accordingly. Thanks.","commit_id":"9f2352d907c489ba00bbd58956baf939560fa0c1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"8f08ae00289b4c7c47af118b8f3bffd9e709707b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7205902a_3221fdb1","updated":"2025-06-23 06:25:03.000000000","message":"Please review. Thanks.","commit_id":"9f2352d907c489ba00bbd58956baf939560fa0c1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"410fb41c_e16b5226","updated":"2025-07-01 21:36:17.000000000","message":"Hey, Sai! Thanks for working on the changes. Please take a look at the comments inline. Also, could you please add a release note to this change?","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"624d7696_20c56a7c","updated":"2025-07-09 12:47:21.000000000","message":"Hi Carloss, thank you so much taking time, reviewing and providing such valuable comments. I have addressed most of the comments and provided info for rest of them. Please review.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4f5b894ed19e5c6f25cdfc360b77a271ee81559c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"054062f3_7f443c10","updated":"2025-06-26 14:09:57.000000000","message":"The changes from the driver are ready, please do review!! Thanks.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"e75df4cfe821e211886320999f68af7291203e79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b69202fc_dbf2e1f1","updated":"2025-06-26 05:45:04.000000000","message":"recheck","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dd2ac6c5_e9e4ed6d","updated":"2025-08-06 13:29:07.000000000","message":"Thanks for the update and apologies on the delay to get back to the discussions. Please take a look at the answers inline","commit_id":"6964c60f7b077c5a7259b189ff4b884811bcf9bf"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5424b4705aede53c20eea9ba3f29b10ed45ec99c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0e174550_ec408450","updated":"2025-08-11 14:46:34.000000000","message":"Thank you so much Carloss for all the comments. Addressed all of them as discussed in collab meeting. Please review.","commit_id":"2eb1bbdfe2f871564a997ff686c3809cb59661d6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d954600526f27d334d25e5fa275bb799dd9668b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0b19bb08_2f45590f","updated":"2025-08-21 14:28:26.000000000","message":"Actually...\nCould you please add a release note to this change? Please also mention the manage/unmanage limitation","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"9f7cc9b6b664f6ee6211680b209fa7ee867870b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2d9e177a_c4659528","updated":"2025-08-18 10:51:00.000000000","message":"Thank you so much Carloss for the valuable comments and continuous support. I have manually tested below workflows with encrypted/non-encrypted shares as discussed in collab meeting to ensure there are no regressions. \n\nEncrypted share:\n- Share create (share server created)\n- Unmanage share\n- Manage share\n- Delete share\n- Unmanage share-server\n- Manage share-server\n- Share create\n- Snapshot create\n- Create share from snapshot\n- Snapshot delete\n- Delete share server\n\nUnencrypted share:\n- Share create (Share server created)\n- Unmanage share\n- Manage share\n- Delete share\n- Unmanage the share server \n- Manage the share server\n- Share create\n- Snapshot create\n- Create share from snapshot\n- Snapshot delete \t\n- Create replica\n- Delete replica\n- Delete share servernage","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9cb3c68e6fd899d956be74b9756a454459e3f3ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f34ba055_f4055031","updated":"2025-08-13 19:26:13.000000000","message":"Thanks for splitting up this change and the fix. Change looks good to me overall, but I have some other major things we discussed at the collab review to bring up. Please take a look at the comments inline","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"f3923e90b82170a10fe583683742b57c9f12e2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"43f8bd3c_0a02d373","in_reply_to":"0b19bb08_2f45590f","updated":"2025-08-21 18:55:48.000000000","message":"Done.","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3c818497a16ead9a3e2b29404ef2787884693004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ad5ab423_f5583fb2","in_reply_to":"2d9e177a_c4659528","updated":"2025-08-21 14:07:00.000000000","message":"Thanks for all the testing. Could you also please share the results of your  manila-tempest-plugin test run?","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"fb0e44b78a8d8492a4ca847cbe3d7b0ec8064776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"31875245_a6bf095f","in_reply_to":"ad5ab423_f5583fb2","updated":"2025-08-21 19:18:45.000000000","message":"Hi Carloss, \n\nAs we mentioned earlier, we have a dedicated engineer working on CI and we plan to run NetApp CI in the coming 2-3 days, hope it goes in our way!\n\nWe already have a successful run in cinder [https://review.opendev.org/c/openstack/cinder/+/955054]\n\nThank you!!","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02711a4e36524777f5ae8301e509ee93b698c76d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2f11ceff_939d701c","updated":"2025-08-25 05:19:02.000000000","message":"Thanks, LGTM.. please update this patch based on Kiran\u0027s changes in the core patch. Would you be able to post tempest test results after the change?","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"7fc17d737677ad06bcb7082c14bd21268c1e5f48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e609720f_e157d3e0","in_reply_to":"2f11ceff_939d701c","updated":"2025-08-25 15:44:46.000000000","message":"Filed bug for blocked workflows. https://bugs.launchpad.net/manila/+bug/2121394\n\nAs I mentioned in earlier comments,\nW have a dedicated engineer working on CI and we plan to run NetApp CI in the in a day mostly, hope it goes in our way!\n\nWe already have a successful run in cinder [https://review.opendev.org/c/openstack/cinder/+/955054]","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"15427f07d475b3892570b98d3f8d558a1680aefc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"57c98e7a_24e686e7","updated":"2025-08-27 13:10:08.000000000","message":"@gouthampravi@gmail.com @ces.eduardo98@gmail.com Thank you both of you so much for continuous feedback and support. \n\nDue to limited resources[ONTAP clusters], we have run the CI for \"manila-tempest-plugin-ontap-dhss\" and run seems good with encryption changes. Most of the failures are at SetUp class and this is happening for the runs without encryption changes as well[Non encryption changes ref: https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/45/957045/5/upstream-check/manila-tempest-plugin-ontap-dhss/5c1299c/testr_results.html]\n\nWe really did our best to get CI up and for this run. Please take a look and approve.","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"29a2416ba10165647ad4f61fa02e504638fab7a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6f734b56_bf951920","updated":"2025-08-28 11:48:12.000000000","message":"Do we also need this patch as dependent? \nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/955394","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"beab79b5941f75b3be11a46d3fc8bdb35805fc44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d6b3e22a_1e58cb37","updated":"2025-08-29 12:58:46.000000000","message":"Hi @ces.eduardo98@gmail.com and @gouthampravi@gmail.com,\n\nThe latest CI run from the DNM patch \"https://review.opendev.org/c/openstack/manila/+/958721\" has good results. \n\nAs we promised, we kept our best efforts to bring up the CI and it is up now. Most of the tests are failing at tearDownClass. The encryption test is failing and we assure you that, we will fix it soon. \n\nAs discussed with Carloss in irc chat, I have run the encryption tempest test locally with the latest code and it\u0027s passing. Here is result of the test: https://paste.opendev.org/show/bx36yhkQ7SaJtb41unDk/\n\nPlease do consider this and approve the merge!!\n\nWe assure you that, NetApp will continue to put best efforts to resolve remaining issue in CI very soon. \n\nThank you so much both of you for continuous support. Your guidance is very much appreciated.","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"303e316e6b59ca506962f983f0ff68a17c7716cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6b2c6a01_dc144741","updated":"2025-08-28 11:38:40.000000000","message":"Hi Goutham/Carloss, \n\nThank you for your suggestions to run the tests. \n\nRaised [DNM] change patch as suggested and added required dependency patches. \nIn the job, added run_encryption_tests \u003d True and also kept TEMPEST_USE_TEST_ACCOUNTS\u003d\"False\". \n\nDNM change patch: https://review.opendev.org/c/openstack/manila/+/958721\n\nPlease take a look and approve accordingly!","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"519be7f0ab8698c3cb2555f9ed92eecfd7761c1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cb20489c_15fe1ead","updated":"2025-08-28 17:59:13.000000000","message":"LGTM ..!","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"92be7d92bded45cbb5de862ce0f6af3c08f4c43c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"34eec9d7_8de4f257","updated":"2025-08-25 17:02:10.000000000","message":"LGTM; waiting on Zuul, and hopefully NetApp CI","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":38290},"change_message_id":"675b73f4cdb80070fe9d11331c474fd1b733d10d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"003bd77c_6830bc9e","updated":"2025-08-26 14:40:32.000000000","message":"Run-NetApp CI","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":38290},"change_message_id":"613c46ce598c537044e5502914766b40618fd253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1d07360a_ccebd4cf","updated":"2025-08-26 06:32:06.000000000","message":"Run-NetApp CI","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":38290},"change_message_id":"aedfe2e35828913b8d081065a6561d774bd2faeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"75a79e4a_dd448888","updated":"2025-08-26 07:26:33.000000000","message":"Run-NetApp CI","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":38290},"change_message_id":"3ea3a10831542ef1c37587998134a359315f69af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"88cee0ba_d82b14b4","updated":"2025-08-25 17:02:56.000000000","message":"Run-NetApp CI","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"7fc17d737677ad06bcb7082c14bd21268c1e5f48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"84cc7174_93fca905","updated":"2025-08-25 15:44:46.000000000","message":"Thanks a lot @gouthampravi@gmail.com and @ces.eduardo98@gmail.com. for your support and feedback. \n \nAddressed comments. Took latest changes from Kiran, updated driver patch.\n\nTested encrypted share creation with the latest changes and working as expected. \n\nPlease do review and approve!!","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"347a770364e5de8da45ff96b8a3f6fce2de867af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"88a2f866_09df6f27","updated":"2025-08-29 13:36:32.000000000","message":"Thanks for the hard work on this change. Changing my vote to +2 but we should be holding this change until the testing query is completed.","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a5979af128d9e29a509631325c3f18f4d2ea9d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4c5f6ee5_cf45358c","updated":"2025-08-27 15:01:52.000000000","message":"Thanks for working on this. Please take a look at the reply inline :)","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"8d76b1b964ae57a253d9d89aa83bf1669a1148d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b731b642_6d5ea734","updated":"2025-08-26 02:40:10.000000000","message":"recheck","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"503600bad90e6d5f80fc56c1fc2764a2c0fe0bad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5fd84cc6_1776c5d4","in_reply_to":"0e7e35a7_325ad76c","updated":"2025-08-28 12:13:23.000000000","message":"Ahhh, this was already added as dependency to https://review.opendev.org/c/openstack/manila-tempest-plugin/+/952368, so we don\u0027t need https://review.opendev.org/c/openstack/manila-tempest-plugin/+/955394 as dependency to DNM change. Ignore please!","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"303e316e6b59ca506962f983f0ff68a17c7716cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7d94ad84_c2676fba","in_reply_to":"499b8fcc_4d7625b6","updated":"2025-08-28 11:38:40.000000000","message":"Done.","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a5979af128d9e29a509631325c3f18f4d2ea9d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"83f01067_846d54f3","in_reply_to":"57c98e7a_24e686e7","updated":"2025-08-27 15:01:52.000000000","message":"The set up issues are also showing up in other jobs like the container one. I looked through the issues and the set ups seem fine, but I realized the job didn\u0027t run encryption tests, nor have it enabled:\n\nthis key: run_encryption_tests is not set in the tempest.conf, nor this change is linked to the one of the encryption tests. I know you\u0027ve run in a local env but it would also be nice to get a clean run in the job with everything and the most recent version of manila-tempest-plugin.\n\nI\u0027d recommend to:\n- Create a change [DNM] Testing NetApp with share encryption.\n- Propose it to manila with a depends-on to this change and the manila-tempest-plugin change: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/952368\n- In the job, add the run_encryption_tests flag and set it to True\n- Run the CI on the DNM change","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"58548cf5fd1072082f1c04ff3d42d30db69ac279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0e7e35a7_325ad76c","in_reply_to":"6f734b56_bf951920","updated":"2025-08-28 11:48:44.000000000","message":"I meant for DNM change.","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"b4cc45acf64fc68d8b5ac9b37b8ed013fd8979ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ea4ca3a9_3dfcc612","in_reply_to":"7b5b8e21_d5b627d6","updated":"2025-08-29 13:59:43.000000000","message":"Thank you so much Carloss!! I have tested the scenarios you mentioned. \nNetApp allows both encrypted and un-encrypted volumes under the encrypted vserver. \n\nI have tested these scenarios:\n\n1)First gets created as encypted.\nopenstack share create NFS 1 --share-network network1 --encryption-key-ref 608c4de7-34c3-40ca-bcbc-befff08bae0c --share-type ost_zapi_encryption_type --name  nfs_share1 \n\nOSTK-select10::\u003e volume show -volume share_97c5226c_8eae_4141_bad0_4ebcf573fafc -fields encrypt\nvserver                                 volume                                     encrypt \n--------------------------------------- ------------------------------------------ ------- \nos_ee843bce-171b-4734-87d0-e1b344a2f8c0 share_97c5226c_8eae_4141_bad0_4ebcf573fafc true  \n\n2)Second share gets created as non-encrypted shares. \nopenstack share create NFS 1 --share-network network1 --share-type ost_zapi_encryption_type --name  nfs_share2\n\nOSTK-select10::\u003e volume show -volume share_193a795a_bee9_4f05_9c39_9bfd421d29de -fields encrypt\nvserver                                 volume                                     encrypt \n--------------------------------------- ------------------------------------------ ------- \nos_ee843bce-171b-4734-87d0-e1b344a2f8c0 share_193a795a_bee9_4f05_9c39_9bfd421d29de false   \n\nI think, we are good here!!","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0e45e3ffb5899c5a87b50238fce1eee8e4509baf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"499b8fcc_4d7625b6","in_reply_to":"83f01067_846d54f3","updated":"2025-08-27 21:24:42.000000000","message":"+1\n\nto address most of the \"unrelated\" test failures, you have to fix something in the CI configuration.. You need to enable \"dynamic\" test credentials because we have some weird issues with pre-provisioned credentials.. \n\nin tempest.conf you need to delete the following option\n\n```\n[auth]\n...\ntest_accounts_file \u003d etc/accounts.yaml\n...\n```\n\nand set the following option to True\n```\n[auth]\n...\nuse_dynamic_credentials \u003d True\n...\n```\n\nThis can be done automatically by deleting ``TEMPEST_USE_TEST_ACCOUNTS\u003d\"True\"`` from your devstack\u0027s local.conf (or setting that option to False)","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"347a770364e5de8da45ff96b8a3f6fce2de867af","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7b5b8e21_d5b627d6","in_reply_to":"d6b3e22a_1e58cb37","updated":"2025-08-29 13:36:32.000000000","message":"Hey, Sai\n\nI looked at the DNM change and saw that most tests are passing and most failures are related to teardowns. The encryption test was failing with the share failing to create and being stuck in ERROR and I looked into the logs of manila-api, scheduler and share but the issue doesn\u0027t show up there. I think the manual test run helps us to ensure that things work just fine.\n\nThanks for running the tests locally and please take a look at the CI and fix the testing there as well.\n\nI have only one scenario that came up to my mind at this point:\n- You have a share type (st1) with encryption_support set to share_sever\n- You create one share (s1) using that share type and a share network (sn1) and specifying the encryption key (enc_key_1)\n- A share server with the encryption key is created\n- You then create a second share (s2), using the same share network (sn1) this time without encryption key.\n\nFrom what I see in the code, choose_share_sever_compatible_with_share is not filtering out the share server that has the encryption key when the share has it set and I believe the share can end up in the share server that is encrypted, even though the user didn\u0027t specify the encryption key. Could you please test this scenario and ensure that a share without encryption key can\u0027t end up in an encrypted share server?","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a23d086090846442bb2cec32a0bf13b82fe6844e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ec031437_a967b5ba","in_reply_to":"ea4ca3a9_3dfcc612","updated":"2025-08-29 14:22:44.000000000","message":"Ack, thanks for confirming. My last request is to please sort out the issue with the CI and attempt to get the encryption test passing on the DNM change. If there are issues, we can get them in before RC1. I\u0027m good with this change merging now. Thanks for the hard work!","commit_id":"ad6a41d1a9bf668aef995e99f08e0b4a5705cf3a"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                \u0027services\u0027: \u0027,\u0027.join(protocols),"},{"line_number":758,"context_line":"                \u0027fields\u0027: \u0027ip.address,location.home_node.name,\u0027"},{"line_number":759,"context_line":"                          \u0027location.home_port.name,ip.netmask,\u0027"},{"line_number":760,"context_line":"                          \u0027services,svm.name,enabled\u0027"},{"line_number":761,"context_line":"            }"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            query \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5b608d3c_9de0392c","line":760,"range":{"start_line":760,"start_character":45,"end_line":760,"end_character":52},"updated":"2025-07-01 21:36:17.000000000","message":"might be a straightforward question, but what changed related to getting networking interfaces for this change that we needed to start fetching \"enabled\" as well?","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                \u0027services\u0027: \u0027,\u0027.join(protocols),"},{"line_number":758,"context_line":"                \u0027fields\u0027: \u0027ip.address,location.home_node.name,\u0027"},{"line_number":759,"context_line":"                          \u0027location.home_port.name,ip.netmask,\u0027"},{"line_number":760,"context_line":"                          \u0027services,svm.name,enabled\u0027"},{"line_number":761,"context_line":"            }"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            query \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"e3a55904_143ed9f9","line":760,"range":{"start_line":760,"start_character":45,"end_line":760,"end_character":52},"in_reply_to":"5b608d3c_9de0392c","updated":"2025-07-09 12:47:21.000000000","message":"Not sure if something has changed on this but I am sure basic REST share creation workflow is failing without this code and I think the share creation workflow was not tested in recent times so I had to this code. Please let me know your further suggestions on this.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5424b4705aede53c20eea9ba3f29b10ed45ec99c","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                \u0027services\u0027: \u0027,\u0027.join(protocols),"},{"line_number":758,"context_line":"                \u0027fields\u0027: \u0027ip.address,location.home_node.name,\u0027"},{"line_number":759,"context_line":"                          \u0027location.home_port.name,ip.netmask,\u0027"},{"line_number":760,"context_line":"                          \u0027services,svm.name,enabled\u0027"},{"line_number":761,"context_line":"            }"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            query \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"fc1490f7_63c63972","line":760,"range":{"start_line":760,"start_character":45,"end_line":760,"end_character":52},"in_reply_to":"98620fda_038ffe78","updated":"2025-08-11 14:46:34.000000000","message":"Created a bug, will raise patch for the same. \nBug: https://bugs.launchpad.net/manila/+bug/2120291","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                \u0027services\u0027: \u0027,\u0027.join(protocols),"},{"line_number":758,"context_line":"                \u0027fields\u0027: \u0027ip.address,location.home_node.name,\u0027"},{"line_number":759,"context_line":"                          \u0027location.home_port.name,ip.netmask,\u0027"},{"line_number":760,"context_line":"                          \u0027services,svm.name,enabled\u0027"},{"line_number":761,"context_line":"            }"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            query \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"98620fda_038ffe78","line":760,"range":{"start_line":760,"start_character":45,"end_line":760,"end_character":52},"in_reply_to":"e3a55904_143ed9f9","updated":"2025-08-06 13:29:07.000000000","message":"Ack. If this is an unrelated fix, it should ship in a different patch","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":4416,"context_line":"                                                         app_cred_secret):"},{"line_number":4417,"context_line":"        \"\"\"Creates a Barbican KMS configuration for the specified vserver.\"\"\""},{"line_number":4418,"context_line":""},{"line_number":4419,"context_line":"        body \u003d {"},{"line_number":4420,"context_line":"            \u0027svm.name\u0027: vserver_name"},{"line_number":4421,"context_line":"        }"},{"line_number":4422,"context_line":""},{"line_number":4423,"context_line":"        if config_name:"},{"line_number":4424,"context_line":"            body[\u0027configuration.name\u0027] \u003d config_name"},{"line_number":4425,"context_line":""},{"line_number":4426,"context_line":"        if key_id:"},{"line_number":4427,"context_line":"            body[\u0027key_id\u0027] \u003d key_id"},{"line_number":4428,"context_line":""},{"line_number":4429,"context_line":"        if keystone_url:"},{"line_number":4430,"context_line":"            body[\u0027keystone_url\u0027] \u003d keystone_url"},{"line_number":4431,"context_line":""},{"line_number":4432,"context_line":"        if app_cred_id:"},{"line_number":4433,"context_line":"            body[\u0027application_cred_id\u0027] \u003d app_cred_id"},{"line_number":4434,"context_line":""},{"line_number":4435,"context_line":"        if app_cred_secret:"},{"line_number":4436,"context_line":"            body[\u0027application_cred_secret\u0027] \u003d app_cred_secret"},{"line_number":4437,"context_line":""},{"line_number":4438,"context_line":"        self.send_request(\u0027/security/barbican-kms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4439,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f1914da_2320eb18","line":4436,"range":{"start_line":4419,"start_character":8,"end_line":4436,"end_character":61},"updated":"2025-07-01 21:36:17.000000000","message":"none of these are kwargs, so:\n\n```suggestion\n        body \u003d {\n            \u0027svm.name\u0027: vserver_name,\n            \u0027configuration.name\u0027: config_name,\n            \u0027key_id\u0027: key_id,\n            \u0027keystone_url\u0027: keystone_url,\n            \u0027application_cred_id\u0027: app_cred_id,\n            \u0027application_cred_secret\u0027: app_cred_secret,\n        }\n```","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":false,"context_lines":[{"line_number":4416,"context_line":"                                                         app_cred_secret):"},{"line_number":4417,"context_line":"        \"\"\"Creates a Barbican KMS configuration for the specified vserver.\"\"\""},{"line_number":4418,"context_line":""},{"line_number":4419,"context_line":"        body \u003d {"},{"line_number":4420,"context_line":"            \u0027svm.name\u0027: vserver_name"},{"line_number":4421,"context_line":"        }"},{"line_number":4422,"context_line":""},{"line_number":4423,"context_line":"        if config_name:"},{"line_number":4424,"context_line":"            body[\u0027configuration.name\u0027] \u003d config_name"},{"line_number":4425,"context_line":""},{"line_number":4426,"context_line":"        if key_id:"},{"line_number":4427,"context_line":"            body[\u0027key_id\u0027] \u003d key_id"},{"line_number":4428,"context_line":""},{"line_number":4429,"context_line":"        if keystone_url:"},{"line_number":4430,"context_line":"            body[\u0027keystone_url\u0027] \u003d keystone_url"},{"line_number":4431,"context_line":""},{"line_number":4432,"context_line":"        if app_cred_id:"},{"line_number":4433,"context_line":"            body[\u0027application_cred_id\u0027] \u003d app_cred_id"},{"line_number":4434,"context_line":""},{"line_number":4435,"context_line":"        if app_cred_secret:"},{"line_number":4436,"context_line":"            body[\u0027application_cred_secret\u0027] \u003d app_cred_secret"},{"line_number":4437,"context_line":""},{"line_number":4438,"context_line":"        self.send_request(\u0027/security/barbican-kms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4439,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"f87ebb8e_420bf75b","line":4436,"range":{"start_line":4419,"start_character":8,"end_line":4436,"end_character":61},"in_reply_to":"9f1914da_2320eb18","updated":"2025-07-09 12:47:21.000000000","message":"Updated.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":5647,"context_line":"            \u0027get\u0027"},{"line_number":5648,"context_line":"        )"},{"line_number":5649,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5650,"context_line":"        if clock_fmt_value is None:"},{"line_number":5651,"context_line":"            return False"},{"line_number":5652,"context_line":"        return True"},{"line_number":5653,"context_line":""},{"line_number":5654,"context_line":"    @na_utils.trace"},{"line_number":5655,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":7,"id":"d5d74fa8_3460d4d9","line":5652,"range":{"start_line":5650,"start_character":8,"end_line":5652,"end_character":19},"updated":"2025-07-01 21:36:17.000000000","message":"has something related to snaplock changed for this encryption feature? If it\u0027s a separate fix, please move to another change. If it\u0027s accidental, please remove it","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":true,"context_lines":[{"line_number":5647,"context_line":"            \u0027get\u0027"},{"line_number":5648,"context_line":"        )"},{"line_number":5649,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5650,"context_line":"        if clock_fmt_value is None:"},{"line_number":5651,"context_line":"            return False"},{"line_number":5652,"context_line":"        return True"},{"line_number":5653,"context_line":""},{"line_number":5654,"context_line":"    @na_utils.trace"},{"line_number":5655,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":7,"id":"df384c09_332bb741","line":5652,"range":{"start_line":5650,"start_character":8,"end_line":5652,"end_character":19},"in_reply_to":"b9757428_753e96bb","updated":"2025-08-06 13:29:07.000000000","message":"Yes, please submit this as a different patch. That patch can be backported to fix this issue in more releases.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":true,"context_lines":[{"line_number":5647,"context_line":"            \u0027get\u0027"},{"line_number":5648,"context_line":"        )"},{"line_number":5649,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5650,"context_line":"        if clock_fmt_value is None:"},{"line_number":5651,"context_line":"            return False"},{"line_number":5652,"context_line":"        return True"},{"line_number":5653,"context_line":""},{"line_number":5654,"context_line":"    @na_utils.trace"},{"line_number":5655,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b9757428_753e96bb","line":5652,"range":{"start_line":5650,"start_character":8,"end_line":5652,"end_character":19},"in_reply_to":"d5d74fa8_3460d4d9","updated":"2025-07-09 12:47:21.000000000","message":"It is not related encryption feature. The earlier code was working for only snaplock compliance configured cluster and if it is not configured, it is ending up throwing error and REST share creation is failed.  The updated code handles both the scenarios.\n\nSo, we should raise a separate patch for this piece of code? Is it not possible to have this code if this can be considered?","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5424b4705aede53c20eea9ba3f29b10ed45ec99c","unresolved":false,"context_lines":[{"line_number":5647,"context_line":"            \u0027get\u0027"},{"line_number":5648,"context_line":"        )"},{"line_number":5649,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5650,"context_line":"        if clock_fmt_value is None:"},{"line_number":5651,"context_line":"            return False"},{"line_number":5652,"context_line":"        return True"},{"line_number":5653,"context_line":""},{"line_number":5654,"context_line":"    @na_utils.trace"},{"line_number":5655,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":7,"id":"32637d96_bf783132","line":5652,"range":{"start_line":5650,"start_character":8,"end_line":5652,"end_character":19},"in_reply_to":"df384c09_332bb741","updated":"2025-08-11 14:46:34.000000000","message":"Created a bug, will raise patch for the same. \nBug: https://bugs.launchpad.net/manila/+bug/2120291","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9cb3c68e6fd899d956be74b9756a454459e3f3ec","unresolved":true,"context_lines":[{"line_number":4409,"context_line":"                            \u0027%(server)s.\u0027, {\u0027server\u0027: vserver_name})"},{"line_number":4410,"context_line":""},{"line_number":4411,"context_line":"    @na_utils.trace"},{"line_number":4412,"context_line":"    def create_barbican_kms_config_for_specified_vserver(self, vserver_name,"},{"line_number":4413,"context_line":"                                                         config_name, key_id,"},{"line_number":4414,"context_line":"                                                         keystone_url,"},{"line_number":4415,"context_line":"                                                         app_cred_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fbee4e81_1cdc678a","line":4412,"range":{"start_line":4412,"start_character":8,"end_line":4412,"end_character":56},"updated":"2025-08-13 19:26:13.000000000","message":"During the collab review sessions, we talked about a few new scenarios that must be tested, as for example manage/unmanage. This feature is very important for maintenance and/or bringing existing share servers/shares.\n\nWhen we manage a share server, it means we are bringing it under manila\u0027s management, so we should also make sure it doesn\u0027t have any barbican config already in the storage that was left behind during a previous unmanage, otherwise, this can mean it is a key that is tied to a diferent admin/user, which would be something wrong to do.\n\nI looked at the implementation and I realized that this scenario is not being taken care of. I\u0027d say we have three or more possible approaches here:\n\n1. When managing a share server, the NetApp ONTAP driver should check for existing Barbican KMS configuration in the cluster for that given share server. In case there is a key already configured, the manage operation should have a way to ensure that the key belongs to the user (or a new parameter should be allowed in the openstack share adopt command/api) and if it belongs to the user, we will also somehow \"manage\" the key bringing it to Manila\u0027s context. If not, the request should be blocked before it is ever completed. This will also mean that the share manager will need to know about the relationship.\n\n2. Do the checking but don\u0027t allow the share server manage operation to be completed in case a key was found. This will mean that this share server can never be managed by manila.\n\n3. Allow the manage to happen and return the key info to the share/manager, which also must be changed.\n\nI\u0027d be more in favor of something that looks more like 1. because I personally don\u0027t like the idea of a share server not being managed by manila, specially considering that this share server belonged to OpenStack in the past. I\u0027d be open for other approaches, do you have any other ideas on how to deal with this situation?\n\nIf we end up with approach 2, I am thinking it must be temporary and we should fix it as soon as humanly possible.","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"7fc17d737677ad06bcb7082c14bd21268c1e5f48","unresolved":false,"context_lines":[{"line_number":4409,"context_line":"                            \u0027%(server)s.\u0027, {\u0027server\u0027: vserver_name})"},{"line_number":4410,"context_line":""},{"line_number":4411,"context_line":"    @na_utils.trace"},{"line_number":4412,"context_line":"    def create_barbican_kms_config_for_specified_vserver(self, vserver_name,"},{"line_number":4413,"context_line":"                                                         config_name, key_id,"},{"line_number":4414,"context_line":"                                                         keystone_url,"},{"line_number":4415,"context_line":"                                                         app_cred_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"e9e87c22_76028dbe","line":4412,"range":{"start_line":4412,"start_character":8,"end_line":4412,"end_character":56},"in_reply_to":"0fa61d5c_2901953d","updated":"2025-08-25 15:44:46.000000000","message":"Done. Bug filed: https://bugs.launchpad.net/manila/+bug/2121394","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02711a4e36524777f5ae8301e509ee93b698c76d","unresolved":true,"context_lines":[{"line_number":4409,"context_line":"                            \u0027%(server)s.\u0027, {\u0027server\u0027: vserver_name})"},{"line_number":4410,"context_line":""},{"line_number":4411,"context_line":"    @na_utils.trace"},{"line_number":4412,"context_line":"    def create_barbican_kms_config_for_specified_vserver(self, vserver_name,"},{"line_number":4413,"context_line":"                                                         config_name, key_id,"},{"line_number":4414,"context_line":"                                                         keystone_url,"},{"line_number":4415,"context_line":"                                                         app_cred_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"0fa61d5c_2901953d","line":4412,"range":{"start_line":4412,"start_character":8,"end_line":4412,"end_character":56},"in_reply_to":"382e4c2c_76c09c8d","updated":"2025-08-25 05:19:02.000000000","message":"+1","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3c818497a16ead9a3e2b29404ef2787884693004","unresolved":true,"context_lines":[{"line_number":4409,"context_line":"                            \u0027%(server)s.\u0027, {\u0027server\u0027: vserver_name})"},{"line_number":4410,"context_line":""},{"line_number":4411,"context_line":"    @na_utils.trace"},{"line_number":4412,"context_line":"    def create_barbican_kms_config_for_specified_vserver(self, vserver_name,"},{"line_number":4413,"context_line":"                                                         config_name, key_id,"},{"line_number":4414,"context_line":"                                                         keystone_url,"},{"line_number":4415,"context_line":"                                                         app_cred_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"382e4c2c_76c09c8d","line":4412,"range":{"start_line":4412,"start_character":8,"end_line":4412,"end_character":56},"in_reply_to":"82b8e31c_9519b656","updated":"2025-08-21 14:07:00.000000000","message":"Please file the bugs we asked for this. We can keep this as is but let\u0027s follow-up as soon as we can.","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"9f7cc9b6b664f6ee6211680b209fa7ee867870b0","unresolved":true,"context_lines":[{"line_number":4409,"context_line":"                            \u0027%(server)s.\u0027, {\u0027server\u0027: vserver_name})"},{"line_number":4410,"context_line":""},{"line_number":4411,"context_line":"    @na_utils.trace"},{"line_number":4412,"context_line":"    def create_barbican_kms_config_for_specified_vserver(self, vserver_name,"},{"line_number":4413,"context_line":"                                                         config_name, key_id,"},{"line_number":4414,"context_line":"                                                         keystone_url,"},{"line_number":4415,"context_line":"                                                         app_cred_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"82b8e31c_9519b656","line":4412,"range":{"start_line":4412,"start_character":8,"end_line":4412,"end_character":56},"in_reply_to":"fbee4e81_1cdc678a","updated":"2025-08-18 10:51:00.000000000","message":"I understand the scenario you mentioned here, let\u0027s discuss this in today\u0027s sync-up meeting! Thank you!! \n\nInfo: I have tested manage/unmanage of share-server, it was working and my user was admin throughout the testing!!","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        # Share-server/share encryption support with NetApp will only be"},{"line_number":552,"context_line":"        # possible with DHSS\u003dTrue"},{"line_number":553,"context_line":"        encryption_support \u003d None if self.configuration.safe_get("},{"line_number":554,"context_line":"            \u0027netapp_vserver\u0027) else [\u0027share_server\u0027]"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        netapp_flexvol_encryption \u003d self._cluster_info.get("},{"line_number":557,"context_line":"            \u0027nve_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"804042de_ff0199a6","line":554,"range":{"start_line":553,"start_character":29,"end_line":554,"end_character":51},"updated":"2025-07-01 21:36:17.000000000","message":"maybe there\u0027s a better way to do this? i.e. checking for cluster credentials. Are other functionalities doing the same thing within the driver?","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":false,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        # Share-server/share encryption support with NetApp will only be"},{"line_number":552,"context_line":"        # possible with DHSS\u003dTrue"},{"line_number":553,"context_line":"        encryption_support \u003d None if self.configuration.safe_get("},{"line_number":554,"context_line":"            \u0027netapp_vserver\u0027) else [\u0027share_server\u0027]"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        netapp_flexvol_encryption \u003d self._cluster_info.get("},{"line_number":557,"context_line":"            \u0027nve_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f21dab3_4bd9476e","line":554,"range":{"start_line":553,"start_character":29,"end_line":554,"end_character":51},"in_reply_to":"1b8f7c6f_a251542e","updated":"2025-08-06 13:29:07.000000000","message":"Acknowledged","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":true,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        # Share-server/share encryption support with NetApp will only be"},{"line_number":552,"context_line":"        # possible with DHSS\u003dTrue"},{"line_number":553,"context_line":"        encryption_support \u003d None if self.configuration.safe_get("},{"line_number":554,"context_line":"            \u0027netapp_vserver\u0027) else [\u0027share_server\u0027]"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        netapp_flexvol_encryption \u003d self._cluster_info.get("},{"line_number":557,"context_line":"            \u0027nve_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1b8f7c6f_a251542e","line":554,"range":{"start_line":553,"start_character":29,"end_line":554,"end_character":51},"in_reply_to":"804042de_ff0199a6","updated":"2025-07-09 12:47:21.000000000","message":"This is to make a decision between DHSS\u003dfalse and DHSS\u003dtrue. Incase of false, we will have netapp_vserver param and in case of true, we won\u0027t so we discussed internally and prioritized this param. Please suggest if you see any other better option.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9cb3c68e6fd899d956be74b9756a454459e3f3ec","unresolved":true,"context_lines":[{"line_number":1957,"context_line":"            helper.delete_share(share, share_name)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"    @na_utils.trace"},{"line_number":1960,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":1961,"context_line":"        \"\"\"Creates a snapshot of a share.\"\"\""},{"line_number":1962,"context_line":"        vserver, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":1963,"context_line":"        share_name \u003d self._get_backend_share_name(snapshot[\u0027share_id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"35570a86_afa29190","line":1960,"range":{"start_line":1960,"start_character":8,"end_line":1960,"end_character":23},"updated":"2025-08-13 19:26:13.000000000","message":"At the collab review session we talked about different features, e.g., Replication and snapshots for shares and you guys mentioned that replication and snapshot features won\u0027t be allowed in case the share server is encrypted.\n\nThis change is adding encryption, yes, but let\u0027s consider another scenario:\n\n- A NetApp customer is using replication and/or snapshots\n- They get excited with the share encryption feature and start using it, so they create some encrypted shares (share server) and didn\u0027t check for this limitation of replication\n- Nothing is currently preventing them from creating a replica, snapshot or start a migration of a share\n- They create a replica, the replica creation succeeds but when they attempt to promote, it may fail or encounter different issues\n\nThis is huge, they are about to go through a big maintenance and thought they had a backup plan.\n\nHave you tested replication and snapshotting with encrypted shares?\n\nCould you please add all of the exception handling here?","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3c818497a16ead9a3e2b29404ef2787884693004","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"            helper.delete_share(share, share_name)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"    @na_utils.trace"},{"line_number":1960,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":1961,"context_line":"        \"\"\"Creates a snapshot of a share.\"\"\""},{"line_number":1962,"context_line":"        vserver, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":1963,"context_line":"        share_name \u003d self._get_backend_share_name(snapshot[\u0027share_id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"ce286577_f48dc046","line":1960,"range":{"start_line":1960,"start_character":8,"end_line":1960,"end_character":23},"in_reply_to":"1c586dd1_ee9e699c","updated":"2025-08-21 14:07:00.000000000","message":"Ack, thanks. I see this was updated in the API after I posted the comment, so LGTM","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"9f7cc9b6b664f6ee6211680b209fa7ee867870b0","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"            helper.delete_share(share, share_name)"},{"line_number":1958,"context_line":""},{"line_number":1959,"context_line":"    @na_utils.trace"},{"line_number":1960,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":1961,"context_line":"        \"\"\"Creates a snapshot of a share.\"\"\""},{"line_number":1962,"context_line":"        vserver, vserver_client \u003d self._get_vserver(share_server\u003dshare_server)"},{"line_number":1963,"context_line":"        share_name \u003d self._get_backend_share_name(snapshot[\u0027share_id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1c586dd1_ee9e699c","line":1960,"range":{"start_line":1960,"start_character":8,"end_line":1960,"end_character":23},"in_reply_to":"35570a86_afa29190","updated":"2025-08-18 10:51:00.000000000","message":"Snapshots with encrypted/non-encrypted shares have been tested. Working as expected. Replication testing with non-encrypted shares tested to ensure no regression and working as expected. We are not supporting replication with encrypted share and exception handling is done from API side. Below is tested example. \n\n\nstack@ostack-ubuntu-15-sai:~/manila$ openstack share replica create enc_share1\nReplica cannot be created for share \u002761cc8be4-7643-4aed-84b9-3d62f121d121\u0027 since it is encrypted. (HTTP 403) (Request-ID: req-b9456f29-0ca2-4670-9608-59b2792a45e8)\nstack@ostack-ubuntu-15-sai:~/manila$","commit_id":"b201ade5d85401c75085504fba71e3197e2a48ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02711a4e36524777f5ae8301e509ee93b698c76d","unresolved":true,"context_lines":[{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        if share.get(\u0027encryption_key_ref\u0027):"},{"line_number":1185,"context_line":"            provisioning_options[\u0027encrypt\u0027] \u003d True"},{"line_number":1186,"context_line":"            LOG.debug(\u0027Creating an encrypted share %(share)s on pool %(pool)s \u0027"},{"line_number":1187,"context_line":"                      \u0027with provisioning options %(options)s\u0027,"},{"line_number":1188,"context_line":"                      {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1189,"context_line":"                       \u0027options\u0027: provisioning_options})"},{"line_number":1190,"context_line":"        else:"},{"line_number":1191,"context_line":"            LOG.debug(\u0027Creating share %(share)s on pool %(pool)s with \u0027"},{"line_number":1192,"context_line":"                      \u0027provisioning options %(options)s\u0027,"},{"line_number":1193,"context_line":"                      {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1194,"context_line":"                       \u0027options\u0027: provisioning_options})"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"        if self._is_flexgroup_pool(pool_name):"},{"line_number":1197,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"f36a15cd_213e3dd8","line":1194,"range":{"start_line":1186,"start_character":12,"end_line":1194,"end_character":56},"updated":"2025-08-25 05:19:02.000000000","message":"Isn\u0027t this the same thing logged just above?","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"7fc17d737677ad06bcb7082c14bd21268c1e5f48","unresolved":false,"context_lines":[{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        if share.get(\u0027encryption_key_ref\u0027):"},{"line_number":1185,"context_line":"            provisioning_options[\u0027encrypt\u0027] \u003d True"},{"line_number":1186,"context_line":"            LOG.debug(\u0027Creating an encrypted share %(share)s on pool %(pool)s \u0027"},{"line_number":1187,"context_line":"                      \u0027with provisioning options %(options)s\u0027,"},{"line_number":1188,"context_line":"                      {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1189,"context_line":"                       \u0027options\u0027: provisioning_options})"},{"line_number":1190,"context_line":"        else:"},{"line_number":1191,"context_line":"            LOG.debug(\u0027Creating share %(share)s on pool %(pool)s with \u0027"},{"line_number":1192,"context_line":"                      \u0027provisioning options %(options)s\u0027,"},{"line_number":1193,"context_line":"                      {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1194,"context_line":"                       \u0027options\u0027: provisioning_options})"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"        if self._is_flexgroup_pool(pool_name):"},{"line_number":1197,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"47e0638c_9858c645","line":1194,"range":{"start_line":1186,"start_character":12,"end_line":1194,"end_character":56},"in_reply_to":"79e26129_a91d62c8","updated":"2025-08-25 15:44:46.000000000","message":"Done. Kept, if/else to say encrypted or normal share.","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a628a71755b6169558eda8d3f08d9a057815630b","unresolved":true,"context_lines":[{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        if share.get(\u0027encryption_key_ref\u0027):"},{"line_number":1185,"context_line":"            provisioning_options[\u0027encrypt\u0027] \u003d True"},{"line_number":1186,"context_line":"            LOG.debug(\u0027Creating an encrypted share %(share)s on pool %(pool)s \u0027"},{"line_number":1187,"context_line":"                      \u0027with provisioning options %(options)s\u0027,"},{"line_number":1188,"context_line":"                      {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1189,"context_line":"                       \u0027options\u0027: provisioning_options})"},{"line_number":1190,"context_line":"        else:"},{"line_number":1191,"context_line":"            LOG.debug(\u0027Creating share %(share)s on pool %(pool)s with \u0027"},{"line_number":1192,"context_line":"                      \u0027provisioning options %(options)s\u0027,"},{"line_number":1193,"context_line":"                      {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1194,"context_line":"                       \u0027options\u0027: provisioning_options})"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"        if self._is_flexgroup_pool(pool_name):"},{"line_number":1197,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"79e26129_a91d62c8","line":1194,"range":{"start_line":1186,"start_character":12,"end_line":1194,"end_character":56},"in_reply_to":"f36a15cd_213e3dd8","updated":"2025-08-25 13:09:53.000000000","message":"Hey, yes. I think this comes from a suggestion I added to log this after updating the provisioning_ops, as at this point it would be outdated. we can drop the one from line 1179, drop both logs on this if/else statement and keep only one log with everything updated after the if statement. WDYT?","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":316,"context_line":"            msg \u003d _(\"Starting creation of a vserver with \u0027dp_destination\u0027 \""},{"line_number":317,"context_line":"                    \"subtype.\")"},{"line_number":318,"context_line":"            LOG.debug(msg)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":321,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":322,"context_line":"        # server\u0027s neutron subnet id."}],"source_content_type":"text/x-python","patch_set":7,"id":"17219728_59a6bc25","side":"PARENT","line":319,"updated":"2025-07-01 21:36:17.000000000","message":"please add the blank like back so it doesn\u0027t suggest changes on git history","commit_id":"48cc585dbe50032309995e7ba69561208c159802"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            msg \u003d _(\"Starting creation of a vserver with \u0027dp_destination\u0027 \""},{"line_number":317,"context_line":"                    \"subtype.\")"},{"line_number":318,"context_line":"            LOG.debug(msg)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":321,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":322,"context_line":"        # server\u0027s neutron subnet id."}],"source_content_type":"text/x-python","patch_set":7,"id":"b85c3592_d07fa217","side":"PARENT","line":319,"in_reply_to":"17219728_59a6bc25","updated":"2025-07-09 12:47:21.000000000","message":"Done.","commit_id":"48cc585dbe50032309995e7ba69561208c159802"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        backend_name \u003d share_utils.extract_host(metadata.get(\u0027request_host\u0027),"},{"line_number":391,"context_line":"                                                level\u003d\u0027backend_name\u0027)"},{"line_number":392,"context_line":"        rest_client \u003d data_motion.get_client_for_backend("},{"line_number":393,"context_line":"            backend_name, vserver_name\u003dNone, force_rest_client\u003dTrue)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        LOG.debug(\u0027Creating a Barbican KMS configuration for the vserver \u0027"},{"line_number":396,"context_line":"                  \u0027%(vserver)s\u0027, {\u0027vserver\u0027: vserver_name})"}],"source_content_type":"text/x-python","patch_set":7,"id":"0cbdfc67_e534020d","line":393,"range":{"start_line":393,"start_character":45,"end_line":393,"end_character":67},"updated":"2025-07-01 21:36:17.000000000","message":"I don\u0027t agree with this... What if the deployer wanted to use ZAPI and there is something wrong with using REST in the cluster? We are deliberately forcing to use REST when ZAPI could have been enforced without even raising anything to communicate the administrators.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        backend_name \u003d share_utils.extract_host(metadata.get(\u0027request_host\u0027),"},{"line_number":391,"context_line":"                                                level\u003d\u0027backend_name\u0027)"},{"line_number":392,"context_line":"        rest_client \u003d data_motion.get_client_for_backend("},{"line_number":393,"context_line":"            backend_name, vserver_name\u003dNone, force_rest_client\u003dTrue)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        LOG.debug(\u0027Creating a Barbican KMS configuration for the vserver \u0027"},{"line_number":396,"context_line":"                  \u0027%(vserver)s\u0027, {\u0027vserver\u0027: vserver_name})"}],"source_content_type":"text/x-python","patch_set":7,"id":"70ba4778_6474b015","line":393,"range":{"start_line":393,"start_character":45,"end_line":393,"end_character":67},"in_reply_to":"0cbdfc67_e534020d","updated":"2025-07-09 12:47:21.000000000","message":"The barbican APIs are only available in REST and we don\u0027t expect customers switch between and ZAPI and REST every time for this specific workflow. As a team(NetApp), we discussed this and coded accordingly. We can add a log line for this if needed but we think it\u0027s okay. Please let us know your feedback on this.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        backend_name \u003d share_utils.extract_host(metadata.get(\u0027request_host\u0027),"},{"line_number":391,"context_line":"                                                level\u003d\u0027backend_name\u0027)"},{"line_number":392,"context_line":"        rest_client \u003d data_motion.get_client_for_backend("},{"line_number":393,"context_line":"            backend_name, vserver_name\u003dNone, force_rest_client\u003dTrue)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        LOG.debug(\u0027Creating a Barbican KMS configuration for the vserver \u0027"},{"line_number":396,"context_line":"                  \u0027%(vserver)s\u0027, {\u0027vserver\u0027: vserver_name})"}],"source_content_type":"text/x-python","patch_set":7,"id":"71d07ee6_a1e58f4f","line":393,"range":{"start_line":393,"start_character":45,"end_line":393,"end_character":67},"in_reply_to":"70ba4778_6474b015","updated":"2025-08-06 13:29:07.000000000","message":"This is a bit tricky. Is there a possibility that REST is not working on the cluster? We have scenarios where we fall back from rest to zapi, but this would be one of the first things doing otherwise and can cause failures. I don\u0027t think raising an exception here and stating that if you\u0027d like to do encryption, you must have REST set as the default. I am open to other reviewers opinion though.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5424b4705aede53c20eea9ba3f29b10ed45ec99c","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        backend_name \u003d share_utils.extract_host(metadata.get(\u0027request_host\u0027),"},{"line_number":391,"context_line":"                                                level\u003d\u0027backend_name\u0027)"},{"line_number":392,"context_line":"        rest_client \u003d data_motion.get_client_for_backend("},{"line_number":393,"context_line":"            backend_name, vserver_name\u003dNone, force_rest_client\u003dTrue)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        LOG.debug(\u0027Creating a Barbican KMS configuration for the vserver \u0027"},{"line_number":396,"context_line":"                  \u0027%(vserver)s\u0027, {\u0027vserver\u0027: vserver_name})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5eff331f_87903136","line":393,"range":{"start_line":393,"start_character":45,"end_line":393,"end_character":67},"in_reply_to":"71d07ee6_a1e58f4f","updated":"2025-08-11 14:46:34.000000000","message":"Done. Added an exception as discussed in collab meeting.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        LOG.debug(\u0027Checking if the encryption key ref passed is already \u0027"},{"line_number":1012,"context_line":"                  \u0027configured for the existing share_servers\u0027)"},{"line_number":1013,"context_line":"        if encryption_key_ref and encryption_key_ref !\u003d \\"},{"line_number":1014,"context_line":"           share_server[\u0027encryption_key_ref\u0027]:"},{"line_number":1015,"context_line":"            args \u003d {\u0027server_id\u0027: share_server[\u0027id\u0027], \u0027network_id\u0027:"},{"line_number":1016,"context_line":"                    share[\u0027share_network_id\u0027]}"},{"line_number":1017,"context_line":"            msg \u003d _(\u0027The available share server %(server_id)s under the \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1c381223_eafda8f1","line":1014,"range":{"start_line":1013,"start_character":8,"end_line":1014,"end_character":45},"updated":"2025-07-01 21:36:17.000000000","message":"```suggestion\n        if (encryption_key_ref and encryption_key_ref !\u003d\n               share_server[\u0027encryption_key_ref\u0027]):\n```","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":false,"context_lines":[{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        LOG.debug(\u0027Checking if the encryption key ref passed is already \u0027"},{"line_number":1012,"context_line":"                  \u0027configured for the existing share_servers\u0027)"},{"line_number":1013,"context_line":"        if encryption_key_ref and encryption_key_ref !\u003d \\"},{"line_number":1014,"context_line":"           share_server[\u0027encryption_key_ref\u0027]:"},{"line_number":1015,"context_line":"            args \u003d {\u0027server_id\u0027: share_server[\u0027id\u0027], \u0027network_id\u0027:"},{"line_number":1016,"context_line":"                    share[\u0027share_network_id\u0027]}"},{"line_number":1017,"context_line":"            msg \u003d _(\u0027The available share server %(server_id)s under the \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"0a261669_0effdf9b","line":1014,"range":{"start_line":1013,"start_character":8,"end_line":1014,"end_character":45},"in_reply_to":"1c381223_eafda8f1","updated":"2025-07-09 12:47:21.000000000","message":"Done.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":true,"context_lines":[{"line_number":966,"context_line":"        :param encryption_key_ref: Encryption key reference"},{"line_number":967,"context_line":"        :returns: share-server or None"},{"line_number":968,"context_line":"        \"\"\""},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        if not share_servers:"},{"line_number":971,"context_line":"            # No share server to reuse"},{"line_number":972,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":8,"id":"25686cf9_f4623c7d","line":969,"updated":"2025-08-06 13:29:07.000000000","message":"this and the additional blank lines are not needed and can make it more difficult to track changes with git history/blame in the future. Please remove them","commit_id":"6964c60f7b077c5a7259b189ff4b884811bcf9bf"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5424b4705aede53c20eea9ba3f29b10ed45ec99c","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        :param encryption_key_ref: Encryption key reference"},{"line_number":967,"context_line":"        :returns: share-server or None"},{"line_number":968,"context_line":"        \"\"\""},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        if not share_servers:"},{"line_number":971,"context_line":"            # No share server to reuse"},{"line_number":972,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":8,"id":"611ba8b9_11e85015","line":969,"in_reply_to":"25686cf9_f4623c7d","updated":"2025-08-11 14:46:34.000000000","message":"Done.","commit_id":"6964c60f7b077c5a7259b189ff4b884811bcf9bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":true,"context_lines":[{"line_number":1020,"context_line":"                    \u0027%(network_id)s is already configured with a different\u0027"},{"line_number":1021,"context_line":"                    \u0027 encryption-key-ref, please create share on the different\u0027"},{"line_number":1022,"context_line":"                    \u0027 share network\u0027)"},{"line_number":1023,"context_line":"            raise exception.NetAppException(msg % args)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"        if (share_group and share_group.get(\u0027share_server_id\u0027) !\u003d"},{"line_number":1026,"context_line":"                share_server[\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":8,"id":"27cbd67a_fed07bf4","line":1023,"range":{"start_line":1023,"start_character":12,"end_line":1023,"end_character":55},"updated":"2025-08-06 13:29:07.000000000","message":"shouldn\u0027t we just return false instead of raising an exception? other share servers might still be suitable","commit_id":"6964c60f7b077c5a7259b189ff4b884811bcf9bf"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5424b4705aede53c20eea9ba3f29b10ed45ec99c","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"                    \u0027%(network_id)s is already configured with a different\u0027"},{"line_number":1021,"context_line":"                    \u0027 encryption-key-ref, please create share on the different\u0027"},{"line_number":1022,"context_line":"                    \u0027 share network\u0027)"},{"line_number":1023,"context_line":"            raise exception.NetAppException(msg % args)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"        if (share_group and share_group.get(\u0027share_server_id\u0027) !\u003d"},{"line_number":1026,"context_line":"                share_server[\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dc74bd13_f37f0f61","line":1023,"range":{"start_line":1023,"start_character":12,"end_line":1023,"end_character":55},"in_reply_to":"27cbd67a_fed07bf4","updated":"2025-08-11 14:46:34.000000000","message":"Done.","commit_id":"6964c60f7b077c5a7259b189ff4b884811bcf9bf"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fbc2cf30dfdcdcb46fdb7ffd796a22196af230c1","unresolved":true,"context_lines":[{"line_number":154,"context_line":"    cfg.StrOpt(\u0027netapp_lif_name_template\u0027,"},{"line_number":155,"context_line":"               default\u003d\u0027os_%(net_allocation_id)s\u0027,"},{"line_number":156,"context_line":"               help\u003d\u0027Logical interface (LIF) name template\u0027),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027netapp_identity_auth_token_path\u0027,"},{"line_number":158,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":159,"context_line":"               help\u003d\u0027Path to interact with auth tokens\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027netapp_aggregate_name_search_pattern\u0027,"},{"line_number":161,"context_line":"               default\u003d\u0027(.*)\u0027,"},{"line_number":162,"context_line":"               help\u003d\u0027Pattern for searching available aggregates \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"02e01ea4_06e87e04","line":159,"range":{"start_line":157,"start_character":4,"end_line":159,"end_character":57},"updated":"2025-07-01 21:36:17.000000000","message":"maybe this can be an option in manila itself?","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"27cdf88013373194596f141a7d446b029b109f16","unresolved":true,"context_lines":[{"line_number":154,"context_line":"    cfg.StrOpt(\u0027netapp_lif_name_template\u0027,"},{"line_number":155,"context_line":"               default\u003d\u0027os_%(net_allocation_id)s\u0027,"},{"line_number":156,"context_line":"               help\u003d\u0027Logical interface (LIF) name template\u0027),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027netapp_identity_auth_token_path\u0027,"},{"line_number":158,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":159,"context_line":"               help\u003d\u0027Path to interact with auth tokens\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027netapp_aggregate_name_search_pattern\u0027,"},{"line_number":161,"context_line":"               default\u003d\u0027(.*)\u0027,"},{"line_number":162,"context_line":"               help\u003d\u0027Pattern for searching available aggregates \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"ce3dcc56_c4a90a3d","line":159,"range":{"start_line":157,"start_character":4,"end_line":159,"end_character":57},"in_reply_to":"02e01ea4_06e87e04","updated":"2025-07-09 12:47:21.000000000","message":"This is option is used to append for keystone_url like below,\nkeystone_auth_token_path \u003d self.configuration.safe_get(\n            \u0027netapp_identity_auth_token_path\u0027)\n        keystone_url \u003d keystone_auth_url + keystone_auth_token_path\n\nAnd, above \"keystone_auth_url\" is fetched from openstack endpoint list. \n\nFrom NetApp point of view, we see that this extension \"/v3/auth/tokens\" was missing and there is a chance that we may need a different extension so we had to introduce this param in options.py. \n\nI am not sure if this is needed at manila level because different cloud productions may already have the url and they might not need this. We can approach Kiran on this and take a decision accordingly.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fb8c4f0646d7858fdbaa3e3ddb6f62c85d0af372","unresolved":true,"context_lines":[{"line_number":154,"context_line":"    cfg.StrOpt(\u0027netapp_lif_name_template\u0027,"},{"line_number":155,"context_line":"               default\u003d\u0027os_%(net_allocation_id)s\u0027,"},{"line_number":156,"context_line":"               help\u003d\u0027Logical interface (LIF) name template\u0027),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027netapp_identity_auth_token_path\u0027,"},{"line_number":158,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":159,"context_line":"               help\u003d\u0027Path to interact with auth tokens\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027netapp_aggregate_name_search_pattern\u0027,"},{"line_number":161,"context_line":"               default\u003d\u0027(.*)\u0027,"},{"line_number":162,"context_line":"               help\u003d\u0027Pattern for searching available aggregates \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"e784af3a_b629c0cb","line":159,"range":{"start_line":157,"start_character":4,"end_line":159,"end_character":57},"in_reply_to":"ce3dcc56_c4a90a3d","updated":"2025-08-06 13:29:07.000000000","message":"Yeah, let\u0027s take other people\u0027s opinion","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5424b4705aede53c20eea9ba3f29b10ed45ec99c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    cfg.StrOpt(\u0027netapp_lif_name_template\u0027,"},{"line_number":155,"context_line":"               default\u003d\u0027os_%(net_allocation_id)s\u0027,"},{"line_number":156,"context_line":"               help\u003d\u0027Logical interface (LIF) name template\u0027),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027netapp_identity_auth_token_path\u0027,"},{"line_number":158,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":159,"context_line":"               help\u003d\u0027Path to interact with auth tokens\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027netapp_aggregate_name_search_pattern\u0027,"},{"line_number":161,"context_line":"               default\u003d\u0027(.*)\u0027,"},{"line_number":162,"context_line":"               help\u003d\u0027Pattern for searching available aggregates \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"278c5fbf_c0a30a09","line":159,"range":{"start_line":157,"start_character":4,"end_line":159,"end_character":57},"in_reply_to":"e784af3a_b629c0cb","updated":"2025-08-11 14:46:34.000000000","message":"It was discussed and decided to keep. NetApp team will document this accordingly.","commit_id":"28de294150318291bec5a8489ee58230b5ee8ce7"}],"releasenotes/notes/netapp-barbican-share-encryption-support-46ec89c70557e526.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02711a4e36524777f5ae8301e509ee93b698c76d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    with DHSS\u003dTrue."},{"line_number":10,"context_line":"upgrades:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    For the NetApp driver, the manage/unmanage operations for encrypted"},{"line_number":13,"context_line":"    share/share-server works like a normal share which is without"},{"line_number":14,"context_line":"    verifying encryption-key and also users. This will be fixed in the"},{"line_number":15,"context_line":"    coming releases accordingly."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1db90fd9_4ba90bbd","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":32},"updated":"2025-08-25 05:19:02.000000000","message":"This isn\u0027t a NetApp limitation really, some work may need to be done in the core code.. @kinpaa@gmail.com: This note should apply to the core code, and you must block manage/unmanage of share servers with encryption enabled","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"7fc17d737677ad06bcb7082c14bd21268c1e5f48","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    with DHSS\u003dTrue."},{"line_number":10,"context_line":"upgrades:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    For the NetApp driver, the manage/unmanage operations for encrypted"},{"line_number":13,"context_line":"    share/share-server works like a normal share which is without"},{"line_number":14,"context_line":"    verifying encryption-key and also users. This will be fixed in the"},{"line_number":15,"context_line":"    coming releases accordingly."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7dfd1ccf_4208c703","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"13ae2c00_a5fdac48","updated":"2025-08-25 15:44:46.000000000","message":"Removed the release noted as Kiran added exception for unmanaging the share server. Tested with the latest code. \n\n\nstack@ostack-ubuntu-15-sai:~/manila$ openstack share server abandon 5d2813f5-2fbd-4968-bc72-4dc5fae46c8c\nFailed to abandon share server with ID \u00275d2813f5-2fbd-4968-bc72-4dc5fae46c8c\u0027: Cannot unmanage the share server containing encryption key reference (HTTP 400) (Request-ID: req-4a9f634d-c747-4e49-9653-88126df0bae2)\nFailed to abandon 1 of 1 servers.","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a628a71755b6169558eda8d3f08d9a057815630b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    with DHSS\u003dTrue."},{"line_number":10,"context_line":"upgrades:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    For the NetApp driver, the manage/unmanage operations for encrypted"},{"line_number":13,"context_line":"    share/share-server works like a normal share which is without"},{"line_number":14,"context_line":"    verifying encryption-key and also users. This will be fixed in the"},{"line_number":15,"context_line":"    coming releases accordingly."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"13ae2c00_a5fdac48","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"1db90fd9_4ba90bbd","updated":"2025-08-25 13:09:53.000000000","message":"The NetApp driver isn\u0027t checking the key and ensuring it exists and returning something, so at some extent, it is a NetApp driver limitation.\n\nAt the end I agree with the main point. The core code must handle a share server being managed with encryption details when they exist. The main problem at the moment with the NetApp ONTAP driver is that we are not doing any checks and NetApp engineers mentioned they would like to do this as a follow-up.\n\nWe are not seeing any driver maintainers pursuing this feature at the moment, but if someone wants to implement it and deal with the manage/unmanage situation right away, they would need to go change the core to reflect if we don\u0027t get this part in as part of the initial implementation of manage/unmanage.","commit_id":"4edd84d5e7061edd9898e9b95661d34cbe163775"}]}