)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7de0975931ce824ee69a0d371209ec6a61602c4d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"supported in POST (create) call. Fixed it by moving \u0027retention_period\u0027"},{"line_number":11,"context_line":"setting to PATCH (update) call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by:"},{"line_number":14,"context_line":"Closes-bug: #2111918"},{"line_number":15,"context_line":"Change-Id: I6d9fcd5a70673f0007b73d5c8e7536b118567088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f2089ee3_a92c51d3","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2025-06-12 15:19:41.000000000","message":"this has to have your name and email: Kiran Pawar \u003cemail\u003e","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4f6e1bb4b58ab04d4f6d5ec596287fced9635e30","unresolved":false,"context_lines":[{"line_number":10,"context_line":"supported in POST (create) call. Fixed it by moving \u0027retention_period\u0027"},{"line_number":11,"context_line":"setting to PATCH (update) call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by:"},{"line_number":14,"context_line":"Closes-bug: #2111918"},{"line_number":15,"context_line":"Change-Id: I6d9fcd5a70673f0007b73d5c8e7536b118567088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"30351ca2_134d4bed","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"in_reply_to":"f2089ee3_a92c51d3","updated":"2025-06-13 08:11:49.000000000","message":"Done","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7de0975931ce824ee69a0d371209ec6a61602c4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"671c84aa_7d04c9c4","updated":"2025-06-12 15:19:41.000000000","message":"Fix looks good, please take a look at the comments inline. @gawasthi2010@gmail.com, could you please take a look at the test comment Kiran left?","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8500c023b6981d889c1f9b7c6408b10ebe91c2a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"baa47577_639a3773","updated":"2025-06-12 14:23:23.000000000","message":"NetApp,\nCan someone put this small change in their environment and test ?","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a63e480574af296f0f324f3a08e27248c6bbc28c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b2bf8e5b_a34dcca6","updated":"2025-06-12 14:17:39.000000000","message":"Thanks Kiran for fixing this, changes looks good to me.","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"83be78d337b447142371fd778b17452b387df7b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb923aab_c6af43f3","in_reply_to":"baa47577_639a3773","updated":"2025-06-22 05:27:55.000000000","message":"I get this code in my local env and tested and it is working fine.","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1aeb5b2b4fe678c93c8a66f2bba4fe5235147862","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6acf4fc7_fc285ad1","updated":"2025-06-16 17:31:20.000000000","message":"Hey @kinpaa@gmail.com - i\u0027ve a problem with this being a debug level log.. If the Administrator has configured \"netapp_delete_retention_hours\" (the default is \"12\" hours), it feels like we should warn them when we can\u0027t enforce it.","commit_id":"1f2509e644da33ae2f0389fdd60bcdc748233a0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2bb1260463925d11f73706c837cbe0827ad26f42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1bffe735_96e5efc9","updated":"2025-06-16 17:08:11.000000000","message":"LGTM, thank you","commit_id":"1f2509e644da33ae2f0389fdd60bcdc748233a0e"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"83be78d337b447142371fd778b17452b387df7b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd800516_d3634b5f","updated":"2025-06-22 05:27:55.000000000","message":"LGTM, also I get these changes to local environment, share server and share creation is working fine.","commit_id":"48cc585dbe50032309995e7ba69561208c159802"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"36f4248a7150fcf25207f2c49de5cbd4c97fc875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"334cfa72_3d2f4e07","updated":"2025-06-18 20:50:06.000000000","message":"LGTM, thanks Kiran","commit_id":"48cc585dbe50032309995e7ba69561208c159802"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"ff46ffb6c91e591262f669059d81ce3c0232b3a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ac9cadaa_192cda61","updated":"2025-06-19 08:42:50.000000000","message":"Looks good,","commit_id":"48cc585dbe50032309995e7ba69561208c159802"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7bf6f89604f90a50b2b3912e38a0527e8bb64788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dbe4b984_773fe28b","updated":"2025-06-22 05:32:12.000000000","message":"Thanks for testing.","commit_id":"48cc585dbe50032309995e7ba69561208c159802"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1aeb5b2b4fe678c93c8a66f2bba4fe5235147862","unresolved":true,"context_lines":[{"line_number":4405,"context_line":"                self.send_request(f\u0027/svm/svms/{svm_uuid}\u0027, \u0027patch\u0027,"},{"line_number":4406,"context_line":"                                  body\u003dbody)"},{"line_number":4407,"context_line":"            except netapp_api.api.NaApiError:"},{"line_number":4408,"context_line":"                LOG.debug(\u0027Failed to modify retention period for vserver \u0027"},{"line_number":4409,"context_line":"                          \u0027%(server)s.\u0027, {\u0027server\u0027: vserver_name})"},{"line_number":4410,"context_line":""},{"line_number":4411,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":3,"id":"74f58e26_96aa4d0e","line":4408,"range":{"start_line":4408,"start_character":20,"end_line":4408,"end_character":25},"updated":"2025-06-16 17:31:20.000000000","message":"warning","commit_id":"1f2509e644da33ae2f0389fdd60bcdc748233a0e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1cd9d428bedf617fa8880a8e480b01878f82c8b4","unresolved":false,"context_lines":[{"line_number":4405,"context_line":"                self.send_request(f\u0027/svm/svms/{svm_uuid}\u0027, \u0027patch\u0027,"},{"line_number":4406,"context_line":"                                  body\u003dbody)"},{"line_number":4407,"context_line":"            except netapp_api.api.NaApiError:"},{"line_number":4408,"context_line":"                LOG.debug(\u0027Failed to modify retention period for vserver \u0027"},{"line_number":4409,"context_line":"                          \u0027%(server)s.\u0027, {\u0027server\u0027: vserver_name})"},{"line_number":4410,"context_line":""},{"line_number":4411,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8a69934_3ad3757b","line":4408,"range":{"start_line":4408,"start_character":20,"end_line":4408,"end_character":25},"in_reply_to":"74f58e26_96aa4d0e","updated":"2025-06-17 07:23:09.000000000","message":"Done","commit_id":"1f2509e644da33ae2f0389fdd60bcdc748233a0e"}],"releasenotes/notes/bug-2111918-netapp-fix-rentention-period-rest-api-e73b358ccc6e7b37.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7de0975931ce824ee69a0d371209ec6a61602c4d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver share server (i.e. SVM) create API was failing due to"},{"line_number":5,"context_line":"    unsupported paramter i.e. retention_period in POST call. Fixed this by"},{"line_number":6,"context_line":"    moving retention_period in PATCH call. For more details, please check"},{"line_number":7,"context_line":"    `Launchpad bug #2111918 \u003chttps://bugs.launchpad.net/manila/+bug/2111918\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0935c053_9e02a06e","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":73},"updated":"2025-06-12 15:19:41.000000000","message":"some implementation details there, I\u0027d say we can say: Fixed an issue while creating shares due to an undesired retention period parameter.","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4f6e1bb4b58ab04d4f6d5ec596287fced9635e30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver share server (i.e. SVM) create API was failing due to"},{"line_number":5,"context_line":"    unsupported paramter i.e. retention_period in POST call. Fixed this by"},{"line_number":6,"context_line":"    moving retention_period in PATCH call. For more details, please check"},{"line_number":7,"context_line":"    `Launchpad bug #2111918 \u003chttps://bugs.launchpad.net/manila/+bug/2111918\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"70a5d3eb_ed2fd01d","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":73},"in_reply_to":"0935c053_9e02a06e","updated":"2025-06-13 08:11:49.000000000","message":"Done","commit_id":"4634c70a06d5e001d3982482b18cf0ac46edd9e1"}]}