)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed6c69d5_7e43e45d","updated":"2025-06-09 15:04:52.000000000","message":"Thank you for taking over this change, Riane. Please take a look at the comments inline. I believe you will also need to change another file [1]. In that file, you will need to add an extra if statement to only add the segmentation_id and network_type in case they are already part of the share network object. If there is no such key, the dictionary can\u0027t have it set.\n\n[1] https://github.com/openstack/manila/blob/master/manila/api/views/share_networks.py#L70C5-L82C19","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"}],"manila/api/v2/share_networks.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            policy.check_policy(context, RESOURCE_NAME, \u0027share_network:show_network_details\u0027, )"},{"line_number":77,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":78,"context_line":"            \"\"\"Allow Admin to get the details of a share network.\"\"\""},{"line_number":79,"context_line":"        share_network.pop(\u0027network_type\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1b14349_f46a51cf","line":76,"range":{"start_line":76,"start_character":57,"end_line":76,"end_character":91},"updated":"2025-06-09 15:04:52.000000000","message":"this parameter should only be \"show_network_details\"","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            policy.check_policy(context, RESOURCE_NAME, \u0027share_network:show_network_details\u0027, )"},{"line_number":77,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":78,"context_line":"            \"\"\"Allow Admin to get the details of a share network.\"\"\""},{"line_number":79,"context_line":"        share_network.pop(\u0027network_type\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2426b730_ae4dfe28","line":76,"in_reply_to":"32471b37_16d26117","updated":"2025-06-20 18:14:10.000000000","message":"\u003e pep8: E501 line too long (95 \u003e 79 characters)\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            policy.check_policy(context, RESOURCE_NAME, \u0027share_network:show_network_details\u0027, )"},{"line_number":77,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":78,"context_line":"            \"\"\"Allow Admin to get the details of a share network.\"\"\""},{"line_number":79,"context_line":"        share_network.pop(\u0027network_type\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"08a98047_aaab7e48","line":76,"range":{"start_line":76,"start_character":57,"end_line":76,"end_character":91},"in_reply_to":"d1b14349_f46a51cf","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            policy.check_policy(context, RESOURCE_NAME, \u0027share_network:show_network_details\u0027, )"},{"line_number":77,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":78,"context_line":"            \"\"\"Allow Admin to get the details of a share network.\"\"\""},{"line_number":79,"context_line":"        share_network.pop(\u0027network_type\u0027, None)"},{"line_number":80,"context_line":"        share_network.pop(\u0027segmentation_id\u0027, None)"},{"line_number":81,"context_line":"        return self._view_builder.build_share_network(req, share_network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"78d31cfe_5bcdbe57","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":68},"updated":"2025-06-09 15:04:52.000000000","message":"```suggestion\n            # Only administrators are able to see the \u0027network_type\u0027 and \u0027segmentation_id\u0027 of a share network,\n            so we remove these from the output.\n```","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        try:"},{"line_number":76,"context_line":"            policy.check_policy(context, RESOURCE_NAME, \u0027share_network:show_network_details\u0027, )"},{"line_number":77,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":78,"context_line":"            \"\"\"Allow Admin to get the details of a share network.\"\"\""},{"line_number":79,"context_line":"        share_network.pop(\u0027network_type\u0027, None)"},{"line_number":80,"context_line":"        share_network.pop(\u0027segmentation_id\u0027, None)"},{"line_number":81,"context_line":"        return self._view_builder.build_share_network(req, share_network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"75df158d_9463f4c8","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":68},"in_reply_to":"78d31cfe_5bcdbe57","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":76,"context_line":"            policy.check_policy(context, RESOURCE_NAME, \u0027share_network:show_network_details\u0027, )"},{"line_number":77,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":78,"context_line":"            \"\"\"Allow Admin to get the details of a share network.\"\"\""},{"line_number":79,"context_line":"        share_network.pop(\u0027network_type\u0027, None)"},{"line_number":80,"context_line":"        share_network.pop(\u0027segmentation_id\u0027, None)"},{"line_number":81,"context_line":"        return self._view_builder.build_share_network(req, share_network)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _all_share_servers_are_auto_deletable(self, share_network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7d130a91_39979f09","line":80,"range":{"start_line":79,"start_character":8,"end_line":80,"end_character":50},"updated":"2025-06-09 15:04:52.000000000","message":"this has to be done only when PolicyNotAuthorized, so please fix the indentation of these statements by moving them one block ahead, so that they are run when we catch the exception","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            policy.check_policy(context, RESOURCE_NAME, \u0027share_network:show_network_details\u0027, )"},{"line_number":77,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":78,"context_line":"            \"\"\"Allow Admin to get the details of a share network.\"\"\""},{"line_number":79,"context_line":"        share_network.pop(\u0027network_type\u0027, None)"},{"line_number":80,"context_line":"        share_network.pop(\u0027segmentation_id\u0027, None)"},{"line_number":81,"context_line":"        return self._view_builder.build_share_network(req, share_network)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _all_share_servers_are_auto_deletable(self, share_network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb93329c_ee31693f","line":80,"range":{"start_line":79,"start_character":8,"end_line":80,"end_character":50},"in_reply_to":"7d130a91_39979f09","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":133,"context_line":"                        \"non-managed shares on the share network subnet \""},{"line_number":134,"context_line":"                        \"%(id)s, so it cannot be deleted. Please contact the \""},{"line_number":135,"context_line":"                        \"cloud administrator to rectify.\") % {"},{"line_number":136,"context_line":"                          \u0027id\u0027: subnet[\u0027id\u0027]}"},{"line_number":137,"context_line":"                LOG.error(msg)"},{"line_number":138,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e958ab26_18fd8936","line":136,"in_reply_to":"a73d0463_d2554533","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E126 continuation line over-indented for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                        \"non-managed shares on the share network subnet \""},{"line_number":134,"context_line":"                        \"%(id)s, so it cannot be deleted. Please contact the \""},{"line_number":135,"context_line":"                        \"cloud administrator to rectify.\") % {"},{"line_number":136,"context_line":"                          \u0027id\u0027: subnet[\u0027id\u0027]}"},{"line_number":137,"context_line":"                LOG.error(msg)"},{"line_number":138,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"43ae2dd0_a0764ef4","line":136,"in_reply_to":"e958ab26_18fd8936","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":175,"context_line":"                    not exact_value and"},{"line_number":176,"context_line":"                    value in subnet.get(key.rstrip(\u0027~\u0027))"},{"line_number":177,"context_line":"                    if key.endswith(\u0027~\u0027) and"},{"line_number":178,"context_line":"                       subnet.get(key.rstrip(\u0027~\u0027)) else ()):"},{"line_number":179,"context_line":"                return True"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a1491193_60d25f4c","line":178,"in_reply_to":"0c96fb49_dd057155","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                    not exact_value and"},{"line_number":176,"context_line":"                    value in subnet.get(key.rstrip(\u0027~\u0027))"},{"line_number":177,"context_line":"                    if key.endswith(\u0027~\u0027) and"},{"line_number":178,"context_line":"                       subnet.get(key.rstrip(\u0027~\u0027)) else ()):"},{"line_number":179,"context_line":"                return True"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d893e107_d1511981","line":178,"in_reply_to":"a1491193_60d25f4c","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    networks \u003d ["},{"line_number":238,"context_line":"                        network for network in networks"},{"line_number":239,"context_line":"                        if network.get(key) \u003d\u003d value or"},{"line_number":240,"context_line":"                           self._subnet_has_search_opt(key, value, network) or"},{"line_number":241,"context_line":"                           (value in network.get(key.rstrip(\u0027~\u0027))"},{"line_number":242,"context_line":"                            if key.endswith(\u0027~\u0027) and"},{"line_number":243,"context_line":"                               network.get(key.rstrip(\u0027~\u0027)) else ())]"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbd5aeb0_beffa288","line":240,"in_reply_to":"4fc8d037_8f0e7816","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                    networks \u003d ["},{"line_number":238,"context_line":"                        network for network in networks"},{"line_number":239,"context_line":"                        if network.get(key) \u003d\u003d value or"},{"line_number":240,"context_line":"                           self._subnet_has_search_opt(key, value, network) or"},{"line_number":241,"context_line":"                           (value in network.get(key.rstrip(\u0027~\u0027))"},{"line_number":242,"context_line":"                            if key.endswith(\u0027~\u0027) and"},{"line_number":243,"context_line":"                               network.get(key.rstrip(\u0027~\u0027)) else ())]"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fc8d037_8f0e7816","line":240,"in_reply_to":"a90f2ab0_42690874","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                        network for network in networks"},{"line_number":239,"context_line":"                        if network.get(key) \u003d\u003d value or"},{"line_number":240,"context_line":"                           self._subnet_has_search_opt(key, value, network) or"},{"line_number":241,"context_line":"                           (value in network.get(key.rstrip(\u0027~\u0027))"},{"line_number":242,"context_line":"                            if key.endswith(\u0027~\u0027) and"},{"line_number":243,"context_line":"                               network.get(key.rstrip(\u0027~\u0027)) else ())]"},{"line_number":244,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"eeb440ae_62992184","line":241,"in_reply_to":"7ef0452f_1a23e839","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":238,"context_line":"                        network for network in networks"},{"line_number":239,"context_line":"                        if network.get(key) \u003d\u003d value or"},{"line_number":240,"context_line":"                           self._subnet_has_search_opt(key, value, network) or"},{"line_number":241,"context_line":"                           (value in network.get(key.rstrip(\u0027~\u0027))"},{"line_number":242,"context_line":"                            if key.endswith(\u0027~\u0027) and"},{"line_number":243,"context_line":"                               network.get(key.rstrip(\u0027~\u0027)) else ())]"},{"line_number":244,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ef0452f_1a23e839","line":241,"in_reply_to":"f3b76c70_2bb8bd94","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                    networks \u003d ["},{"line_number":246,"context_line":"                        network for network in networks"},{"line_number":247,"context_line":"                        if network.get(key) \u003d\u003d value or"},{"line_number":248,"context_line":"                           self._subnet_has_search_opt(key, value, network,"},{"line_number":249,"context_line":"                                                       exact_value\u003dTrue)]"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        limited_list \u003d common.limited(networks, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9dbe96bf_fa42f4cb","line":248,"in_reply_to":"05c5a3a2_e321caa0","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":245,"context_line":"                    networks \u003d ["},{"line_number":246,"context_line":"                        network for network in networks"},{"line_number":247,"context_line":"                        if network.get(key) \u003d\u003d value or"},{"line_number":248,"context_line":"                           self._subnet_has_search_opt(key, value, network,"},{"line_number":249,"context_line":"                                                       exact_value\u003dTrue)]"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        limited_list \u003d common.limited(networks, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"05c5a3a2_e321caa0","line":248,"in_reply_to":"ba2beeda_2f08862f","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                # passing both parameter since a share network subnet must"},{"line_number":325,"context_line":"                # have both fields filled or empty."},{"line_number":326,"context_line":"                subnet_neutron_net_and_subnet_id_are_empty \u003d ("},{"line_number":327,"context_line":"                        subnet[\u0027neutron_net_id\u0027] is None"},{"line_number":328,"context_line":"                        and subnet[\u0027neutron_subnet_id\u0027] is None)"},{"line_number":329,"context_line":"                update_values_without_neutron_net_or_subnet \u003d ("},{"line_number":330,"context_line":"                        update_values.get(\u0027neutron_net_id\u0027) is None or"}],"source_content_type":"text/x-python","patch_set":1,"id":"b58139cc_efc821a7","line":327,"in_reply_to":"28a5221a_6b2c8a0c","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E126 continuation line over-indented for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                # passing both parameter since a share network subnet must"},{"line_number":325,"context_line":"                # have both fields filled or empty."},{"line_number":326,"context_line":"                subnet_neutron_net_and_subnet_id_are_empty \u003d ("},{"line_number":327,"context_line":"                        subnet[\u0027neutron_net_id\u0027] is None"},{"line_number":328,"context_line":"                        and subnet[\u0027neutron_subnet_id\u0027] is None)"},{"line_number":329,"context_line":"                update_values_without_neutron_net_or_subnet \u003d ("},{"line_number":330,"context_line":"                        update_values.get(\u0027neutron_net_id\u0027) is None or"}],"source_content_type":"text/x-python","patch_set":1,"id":"921dcca0_1831a0ab","line":327,"in_reply_to":"b58139cc_efc821a7","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                        subnet[\u0027neutron_net_id\u0027] is None"},{"line_number":328,"context_line":"                        and subnet[\u0027neutron_subnet_id\u0027] is None)"},{"line_number":329,"context_line":"                update_values_without_neutron_net_or_subnet \u003d ("},{"line_number":330,"context_line":"                        update_values.get(\u0027neutron_net_id\u0027) is None or"},{"line_number":331,"context_line":"                        update_values.get(\u0027neutron_subnet_id\u0027) is None)"},{"line_number":332,"context_line":"                if (subnet_neutron_net_and_subnet_id_are_empty"},{"line_number":333,"context_line":"                        and update_values_without_neutron_net_or_subnet):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e534621_27d19fa3","line":330,"in_reply_to":"4f06df75_00923106","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":327,"context_line":"                        subnet[\u0027neutron_net_id\u0027] is None"},{"line_number":328,"context_line":"                        and subnet[\u0027neutron_subnet_id\u0027] is None)"},{"line_number":329,"context_line":"                update_values_without_neutron_net_or_subnet \u003d ("},{"line_number":330,"context_line":"                        update_values.get(\u0027neutron_net_id\u0027) is None or"},{"line_number":331,"context_line":"                        update_values.get(\u0027neutron_subnet_id\u0027) is None)"},{"line_number":332,"context_line":"                if (subnet_neutron_net_and_subnet_id_are_empty"},{"line_number":333,"context_line":"                        and update_values_without_neutron_net_or_subnet):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f06df75_00923106","line":330,"in_reply_to":"ae004862_ed93288a","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E126 continuation line over-indented for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            self._share_network_subnets_contain_share_servers(share_network))"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        support_adding_to_in_use_networks \u003d ("},{"line_number":460,"context_line":"                req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.63\"))"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if contain_share_servers:"},{"line_number":463,"context_line":"            if not support_adding_to_in_use_networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"927b9405_45fd1b7e","line":460,"in_reply_to":"6a767b8a_99e26baf","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":457,"context_line":"            self._share_network_subnets_contain_share_servers(share_network))"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        support_adding_to_in_use_networks \u003d ("},{"line_number":460,"context_line":"                req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.63\"))"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if contain_share_servers:"},{"line_number":463,"context_line":"            if not support_adding_to_in_use_networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a767b8a_99e26baf","line":460,"in_reply_to":"aa2949fb_6c04c7eb","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E126 continuation line over-indented for hanging indent\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":457,"context_line":"            self._share_network_subnets_contain_share_servers(share_network))"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        support_adding_to_in_use_networks \u003d ("},{"line_number":460,"context_line":"                req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.63\"))"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if contain_share_servers:"},{"line_number":463,"context_line":"            if not support_adding_to_in_use_networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb2c3fbe_30af2548","line":460,"in_reply_to":"e51a44f6_62753eb8","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E501 line too long (81 \u003e 79 characters)\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            self._share_network_subnets_contain_share_servers(share_network))"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        support_adding_to_in_use_networks \u003d ("},{"line_number":460,"context_line":"                req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.63\"))"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if contain_share_servers:"},{"line_number":463,"context_line":"            if not support_adding_to_in_use_networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"cea8a52a_4d2c8884","line":460,"in_reply_to":"fb2c3fbe_30af2548","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"}],"manila/policies/share_network.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        deprecated_rule\u003ddeprecated_share_network_subnet_create_check"},{"line_number":299,"context_line":"    ),"},{"line_number":300,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":301,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027share_network:show_network_details\u0027,"},{"line_number":302,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":303,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":304,"context_line":"        description\u003d\"Allow admin to view network_type and segmentation_id of share networks\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9d6220b4_8da64e4a","line":301,"range":{"start_line":301,"start_character":33,"end_line":301,"end_character":47},"updated":"2025-06-09 15:04:52.000000000","message":"please remove `share_network:` and leave only show_network_details","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        deprecated_rule\u003ddeprecated_share_network_subnet_create_check"},{"line_number":299,"context_line":"    ),"},{"line_number":300,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":301,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027share_network:show_network_details\u0027,"},{"line_number":302,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":303,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":304,"context_line":"        description\u003d\"Allow admin to view network_type and segmentation_id of share networks\","}],"source_content_type":"text/x-python","patch_set":1,"id":"69133bff_dce093e5","line":301,"range":{"start_line":301,"start_character":33,"end_line":301,"end_character":47},"in_reply_to":"9d6220b4_8da64e4a","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"be6a65df7cd633edcad5cf18e384b35a116f87f8","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027share_network:show_network_details\u0027,"},{"line_number":302,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":303,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":304,"context_line":"        description\u003d\"Allow admin to view network_type and segmentation_id of share networks\","},{"line_number":305,"context_line":"        operations\u003d["},{"line_number":306,"context_line":"            {"},{"line_number":307,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c08b020c_e84281d7","line":304,"in_reply_to":"25801ae8_2decac16","updated":"2025-06-20 18:14:10.000000000","message":"Done","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dac9dbac891f4974d82e7c4c88a7f6cc84932467","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027share_network:show_network_details\u0027,"},{"line_number":302,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":303,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":304,"context_line":"        description\u003d\"Allow admin to view network_type and segmentation_id of share networks\","},{"line_number":305,"context_line":"        operations\u003d["},{"line_number":306,"context_line":"            {"},{"line_number":307,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"25801ae8_2decac16","line":304,"in_reply_to":"74674831_47dfbe36","updated":"2025-06-09 15:04:52.000000000","message":"\u003e pep8: E501 line too long (93 \u003e 79 characters)\n\nPlease fix.","commit_id":"66a39d57ac5c578ae9ea9d466dbeb77a538829b4"}]}