)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0fcd0933dd5893f133ab5ca8bafb12c36c393e13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef40c6ac_2b00fb6c","updated":"2025-07-15 18:57:37.000000000","message":"LGTM, please address the comment in a follow-up change","commit_id":"9b2b69734aad4fde62eb569cc7ea9d56949f1503"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a697b4de81f79e8a3efefdf9949125264bd1c59f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99369f18_6df642d9","updated":"2025-07-02 06:25:52.000000000","message":"LGTM.","commit_id":"9b2b69734aad4fde62eb569cc7ea9d56949f1503"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b54713d2e4491a31febd2991a9ec5cd37b73c85b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38cc3ca7_0840bab9","updated":"2025-07-02 05:51:16.000000000","message":"i have a question about this.","commit_id":"9b2b69734aad4fde62eb569cc7ea9d56949f1503"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b54713d2e4491a31febd2991a9ec5cd37b73c85b","unresolved":true,"context_lines":[{"line_number":728,"context_line":"                return x[\u0027replica_state\u0027] in preferred_statuses"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        replica_snapshots \u003d list(filter("},{"line_number":731,"context_line":"            lambda x: qualified_replica(x[\u0027share_instance\u0027]), self.instances))"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if not replica_snapshots:"},{"line_number":734,"context_line":"            return self.status"}],"source_content_type":"text/x-python","patch_set":1,"id":"a318a87e_c3f378c9","line":731,"range":{"start_line":731,"start_character":62,"end_line":731,"end_character":76},"updated":"2025-07-02 05:51:16.000000000","message":"if self.instances is None,\nmaybe this line will report:\n TypeError: \u0027NoneType\u0027 object is not iterable.\n \n According to the scenario you described,Is it possible that this could happen?","commit_id":"9b2b69734aad4fde62eb569cc7ea9d56949f1503"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a697b4de81f79e8a3efefdf9949125264bd1c59f","unresolved":false,"context_lines":[{"line_number":728,"context_line":"                return x[\u0027replica_state\u0027] in preferred_statuses"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        replica_snapshots \u003d list(filter("},{"line_number":731,"context_line":"            lambda x: qualified_replica(x[\u0027share_instance\u0027]), self.instances))"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if not replica_snapshots:"},{"line_number":734,"context_line":"            return self.status"}],"source_content_type":"text/x-python","patch_set":1,"id":"71f57ee7_7fe6ff7a","line":731,"range":{"start_line":731,"start_character":62,"end_line":731,"end_character":76},"in_reply_to":"5b14d2d4_19cbaa8a","updated":"2025-07-02 06:25:52.000000000","message":"Done","commit_id":"9b2b69734aad4fde62eb569cc7ea9d56949f1503"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"aa4e34a55e9b17b0bfdd89afd45356d650917503","unresolved":true,"context_lines":[{"line_number":728,"context_line":"                return x[\u0027replica_state\u0027] in preferred_statuses"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        replica_snapshots \u003d list(filter("},{"line_number":731,"context_line":"            lambda x: qualified_replica(x[\u0027share_instance\u0027]), self.instances))"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if not replica_snapshots:"},{"line_number":734,"context_line":"            return self.status"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b14d2d4_19cbaa8a","line":731,"range":{"start_line":731,"start_character":62,"end_line":731,"end_character":76},"in_reply_to":"a318a87e_c3f378c9","updated":"2025-07-02 05:56:06.000000000","message":"this could be empty list instead of None, in that case.","commit_id":"9b2b69734aad4fde62eb569cc7ea9d56949f1503"}],"releasenotes/notes/bug-2114260-Add-guard-to-qualified_replica-e02bd4b21acee803.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0fcd0933dd5893f133ab5ca8bafb12c36c393e13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ShareSnapshot model properties fixed to handle race condition where share"},{"line_number":5,"context_line":"    instance is deleted mean-time. For more details, please check"},{"line_number":6,"context_line":"    `Launchpad bug #2114260 \u003chttps://bugs.launchpad.net/manila/+bug/2114260\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4d87afc4_bdf72f19","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":33},"updated":"2025-07-15 18:57:37.000000000","message":"mentioning the table name feels like too much implementation detail. Please submit a follow-up change with:\n```suggestion\n    Fixed a race condition issue while fetching snapshots when previous\n    share instances were deleted in the meantime. For more details, please check\n```","commit_id":"9b2b69734aad4fde62eb569cc7ea9d56949f1503"}]}