)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"11c9d48a2d3bd6a29558799ea9afc557c10292f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fac269c_901c1252","updated":"2025-06-20 15:52:37.000000000","message":"recheck","commit_id":"a456c5ef033a645609753eabc0c6bd63e6a9542a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9f8bed6bdfd0fa67ec6b2cf77a4fdb80637d47b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9a73f65_79540802","updated":"2025-07-10 21:24:48.000000000","message":"Looks good, minor suggestions inline. Please take a look.\n@saikumar1016@gmail.com @gawasthi2010@gmail.com @anoop.shukla@netapp.com could you please review and test this change?","commit_id":"47fd788961615162ed9a62dd20415166cbb95628"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"87e7894c70dc8c54c4ae901abca40b9382b75a81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"be277948_15fdf5c2","updated":"2025-07-29 11:24:15.000000000","message":"LGTM","commit_id":"a6f17d2e335d52f828b7d0ad6eabd16b6c10dc1d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2552272f6c3cc89ac67a35f5c572df1a29ef63c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fda5490a_78cfb5a0","updated":"2025-08-07 12:20:36.000000000","message":"LGTM","commit_id":"a6f17d2e335d52f828b7d0ad6eabd16b6c10dc1d"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"7e3efb779de70a240ec92eed555c06822891a27c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"45245066_099ebf4b","updated":"2025-08-07 12:08:08.000000000","message":"LGTM ..!","commit_id":"a6f17d2e335d52f828b7d0ad6eabd16b6c10dc1d"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9f8bed6bdfd0fa67ec6b2cf77a4fdb80637d47b8","unresolved":true,"context_lines":[{"line_number":238,"context_line":"            else:"},{"line_number":239,"context_line":"                create_args[\u0027ipspace\u0027] \u003d ipspace_name"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if logical_space_reporting:"},{"line_number":242,"context_line":"            create_args[\u0027is-space-reporting-logical\u0027] \u003d \u0027true\u0027"},{"line_number":243,"context_line":"            create_args[\u0027is-space-enforcement-logical\u0027] \u003d \u0027true\u0027"},{"line_number":244,"context_line":"        else:"},{"line_number":245,"context_line":"            create_args[\u0027is-space-reporting-logical\u0027] \u003d \u0027false\u0027"},{"line_number":246,"context_line":"            create_args[\u0027is-space-enforcement-logical\u0027] \u003d \u0027false\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        LOG.debug(\u0027Creating Vserver %(vserver)s with create args \u0027"},{"line_number":249,"context_line":"                  \u0027%(args)s\u0027, {\u0027vserver\u0027: vserver_name, \u0027args\u0027: create_args})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3e56b525_ea23860b","line":246,"range":{"start_line":241,"start_character":7,"end_line":246,"end_character":65},"updated":"2025-07-10 21:24:48.000000000","message":"we can simplify this a bit\n```suggestion\n        create_args[\u0027is-space-reporting-logical\u0027] \u003d (\n            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)\n        create_args[\u0027is-space-enforcement-logical\u0027] \u003d (\n            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)\n```","commit_id":"47fd788961615162ed9a62dd20415166cbb95628"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"53aa286f096423ae969c608deea6885d154643bf","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            else:"},{"line_number":239,"context_line":"                create_args[\u0027ipspace\u0027] \u003d ipspace_name"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if logical_space_reporting:"},{"line_number":242,"context_line":"            create_args[\u0027is-space-reporting-logical\u0027] \u003d \u0027true\u0027"},{"line_number":243,"context_line":"            create_args[\u0027is-space-enforcement-logical\u0027] \u003d \u0027true\u0027"},{"line_number":244,"context_line":"        else:"},{"line_number":245,"context_line":"            create_args[\u0027is-space-reporting-logical\u0027] \u003d \u0027false\u0027"},{"line_number":246,"context_line":"            create_args[\u0027is-space-enforcement-logical\u0027] \u003d \u0027false\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        LOG.debug(\u0027Creating Vserver %(vserver)s with create args \u0027"},{"line_number":249,"context_line":"                  \u0027%(args)s\u0027, {\u0027vserver\u0027: vserver_name, \u0027args\u0027: create_args})"}],"source_content_type":"text/x-python","patch_set":3,"id":"b2d903ff_f428ce55","line":246,"range":{"start_line":241,"start_character":7,"end_line":246,"end_character":65},"in_reply_to":"3e56b525_ea23860b","updated":"2025-07-11 10:46:54.000000000","message":"Done","commit_id":"47fd788961615162ed9a62dd20415166cbb95628"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9f8bed6bdfd0fa67ec6b2cf77a4fdb80637d47b8","unresolved":true,"context_lines":[{"line_number":4397,"context_line":"        for aggr_name in aggregate_names:"},{"line_number":4398,"context_line":"            body[\u0027aggregates\u0027].append({\u0027name\u0027: aggr_name})"},{"line_number":4399,"context_line":""},{"line_number":4400,"context_line":"        if logical_space_reporting:"},{"line_number":4401,"context_line":"            body[\u0027is_space_reporting_logical\u0027] \u003d \u0027true\u0027"},{"line_number":4402,"context_line":"            body[\u0027is_space_enforcement_logical\u0027] \u003d \u0027true\u0027"},{"line_number":4403,"context_line":"        else:"},{"line_number":4404,"context_line":"            body[\u0027is_space_reporting_logical\u0027] \u003d \u0027false\u0027"},{"line_number":4405,"context_line":"            body[\u0027is_space_enforcement_logical\u0027] \u003d \u0027false\u0027"},{"line_number":4406,"context_line":""},{"line_number":4407,"context_line":"        self.send_request(\u0027/svm/svms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4408,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b867b640_3b2a7ed9","line":4405,"range":{"start_line":4400,"start_character":8,"end_line":4405,"end_character":58},"updated":"2025-07-10 21:24:48.000000000","message":"same suggestion as the other file","commit_id":"47fd788961615162ed9a62dd20415166cbb95628"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"53aa286f096423ae969c608deea6885d154643bf","unresolved":false,"context_lines":[{"line_number":4397,"context_line":"        for aggr_name in aggregate_names:"},{"line_number":4398,"context_line":"            body[\u0027aggregates\u0027].append({\u0027name\u0027: aggr_name})"},{"line_number":4399,"context_line":""},{"line_number":4400,"context_line":"        if logical_space_reporting:"},{"line_number":4401,"context_line":"            body[\u0027is_space_reporting_logical\u0027] \u003d \u0027true\u0027"},{"line_number":4402,"context_line":"            body[\u0027is_space_enforcement_logical\u0027] \u003d \u0027true\u0027"},{"line_number":4403,"context_line":"        else:"},{"line_number":4404,"context_line":"            body[\u0027is_space_reporting_logical\u0027] \u003d \u0027false\u0027"},{"line_number":4405,"context_line":"            body[\u0027is_space_enforcement_logical\u0027] \u003d \u0027false\u0027"},{"line_number":4406,"context_line":""},{"line_number":4407,"context_line":"        self.send_request(\u0027/svm/svms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4408,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2c40c647_1a34a4a1","line":4405,"range":{"start_line":4400,"start_character":8,"end_line":4405,"end_character":58},"in_reply_to":"b867b640_3b2a7ed9","updated":"2025-07-11 10:46:54.000000000","message":"Done","commit_id":"47fd788961615162ed9a62dd20415166cbb95628"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"51b2801adcc54553d8d97bc8d33f371ea9bf4d51","unresolved":true,"context_lines":[{"line_number":4416,"context_line":"        for aggr_name in aggregate_names:"},{"line_number":4417,"context_line":"            body[\u0027aggregates\u0027].append({\u0027name\u0027: aggr_name})"},{"line_number":4418,"context_line":""},{"line_number":4419,"context_line":"        body[\u0027is_space_reporting_logical\u0027] \u003d ("},{"line_number":4420,"context_line":"            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)"},{"line_number":4421,"context_line":"        body[\u0027is_space_enforcement_logical\u0027] \u003d ("},{"line_number":4422,"context_line":"            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"312fa2b7_76c39022","line":4419,"updated":"2025-07-25 13:56:33.000000000","message":"These attributes are only available on ONTAP 9.11 and above. Do we need to check for version here?","commit_id":"a6f17d2e335d52f828b7d0ad6eabd16b6c10dc1d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"63f949e0e4bdeced83639d2f3dbe6e2df6b00b2a","unresolved":false,"context_lines":[{"line_number":4416,"context_line":"        for aggr_name in aggregate_names:"},{"line_number":4417,"context_line":"            body[\u0027aggregates\u0027].append({\u0027name\u0027: aggr_name})"},{"line_number":4418,"context_line":""},{"line_number":4419,"context_line":"        body[\u0027is_space_reporting_logical\u0027] \u003d ("},{"line_number":4420,"context_line":"            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)"},{"line_number":4421,"context_line":"        body[\u0027is_space_enforcement_logical\u0027] \u003d ("},{"line_number":4422,"context_line":"            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f476474_dac18734","line":4419,"in_reply_to":"312fa2b7_76c39022","updated":"2025-07-29 10:21:18.000000000","message":"REST client only runs with ONTAP 9.11.1\n\nhttps://github.com/openstack/manila/blob/076231a7dcb41a2ff9eb3c6cda8ae1a49ebf7b49/manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py#L104","commit_id":"a6f17d2e335d52f828b7d0ad6eabd16b6c10dc1d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"87e7894c70dc8c54c4ae901abca40b9382b75a81","unresolved":false,"context_lines":[{"line_number":4416,"context_line":"        for aggr_name in aggregate_names:"},{"line_number":4417,"context_line":"            body[\u0027aggregates\u0027].append({\u0027name\u0027: aggr_name})"},{"line_number":4418,"context_line":""},{"line_number":4419,"context_line":"        body[\u0027is_space_reporting_logical\u0027] \u003d ("},{"line_number":4420,"context_line":"            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)"},{"line_number":4421,"context_line":"        body[\u0027is_space_enforcement_logical\u0027] \u003d ("},{"line_number":4422,"context_line":"            \u0027true\u0027 if logical_space_reporting else \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"508f57ec_d79c4e47","line":4419,"in_reply_to":"3f476474_dac18734","updated":"2025-07-29 11:24:15.000000000","message":"Okay acknowledged.","commit_id":"a6f17d2e335d52f828b7d0ad6eabd16b6c10dc1d"}],"releasenotes/notes/netapp-add-support-for-logical-space-reporting-bb3b582f162664c8.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d0048545f9b1373399922b25d56ac8a1cf45f74d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver now allow to create share server with logical space"},{"line_number":5,"context_line":"    reporting. New config option \"netapp_enable_logical_space_reporting\" is"},{"line_number":6,"context_line":"    added and its value must be set to \u0027True\u0027 to enable this feature."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ef9ffd9b_47197f3e","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":43},"updated":"2025-09-11 21:47:09.000000000","message":"nit: allows creating share servers","commit_id":"a6f17d2e335d52f828b7d0ad6eabd16b6c10dc1d"}]}