)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"595590b239bdf73a4791f25293335ed0aae2788e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f0ccbd8_51724146","updated":"2025-07-21 19:26:48.000000000","message":"Hey, Sai! Please take a look at the comments inline","commit_id":"22060e6258d41f17b597ba9b76b81b30f07f4754"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"fb425b1b40e65bda76115cb0f2b7b15694f93429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a56c9957_7de4152a","updated":"2025-07-22 13:58:24.000000000","message":"Hey Carloss, \n\nThank you so much for your feedback and support! Made the suggested changes.","commit_id":"c5b92c89173ed6dab77e5bbbbeab42f9d4b738a7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34b8cc70bcc8010d1e9c30801aba2c52581ad95c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"67db5772_a373e92a","updated":"2025-07-29 07:27:42.000000000","message":"Haixin/Carlos,\ncan you please approve ?","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"809da6eebe5fb57e47c49632e8235f941fb6c3d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"95b46bd2_381aaeb8","updated":"2025-07-29 08:40:19.000000000","message":"LGTM","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c4847be5fe6bcf90584245021814145c0ec7d2a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"73cd0b96_d5c41bb4","updated":"2025-07-30 12:04:42.000000000","message":"LGTM ..!","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6dbf09c5b4cbeca083be47a3b415eabd9cd611a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63a15302_9dfe9320","updated":"2025-07-31 09:56:22.000000000","message":"LGTM, thanks for working on this change. @gouthampravi@gmail.com could you please take a look at it as well?","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77ac2a6b5801fdc9e3de602a4f94c80cab26cfb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf6e2ff8_ab8897b4","updated":"2025-07-31 14:51:31.000000000","message":"Please hold, testing this..","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"54b63d019ef43c896768d62216b3cb671315b396","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25ce5480_dd3a0cd7","updated":"2025-07-24 12:21:34.000000000","message":"Tested","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77ac2a6b5801fdc9e3de602a4f94c80cab26cfb6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"30064d86_3d5427ef","in_reply_to":"63a15302_9dfe9320","updated":"2025-07-31 14:51:31.000000000","message":"thanks for checking, i\u0027d like to get this in after testing the core patch..","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"15606aa55e6fe2c07b4c4f1106e161d24b0a3336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ab421ba9_9c2947c7","updated":"2025-08-29 13:01:47.000000000","message":"-1 due to unused variables. We can discuss that authtoken setting but I think that\u0027s caused by something additionally configured outside of devstack and I believe these should be managed externally, unless core devstack supports app credential.","commit_id":"848ff758d2658a33cc15ede8cbe145c4a50e024f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2c8dec9467b063ac5370c06eea693e664d497ead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42b8e104_8b027742","updated":"2025-08-29 13:13:35.000000000","message":"I overlooked change, please remove those 2 lines.","commit_id":"848ff758d2658a33cc15ede8cbe145c4a50e024f"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c686116b0f61b2908be004d6de080c734517d73d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7bf7f90b_d0881914","updated":"2025-08-29 09:24:39.000000000","message":"Thank you Goutham for the suggestion. Will propose service_type change in barbican and add this patch as dependency there as you suggested.","commit_id":"848ff758d2658a33cc15ede8cbe145c4a50e024f"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4f13575ce7fd1d464c993101e59de389c8cc0af7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b49a3a1_39b719cd","in_reply_to":"42b8e104_8b027742","updated":"2025-08-29 13:37:05.000000000","message":"Done.","commit_id":"848ff758d2658a33cc15ede8cbe145c4a50e024f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dcaf2d1b4d658dfae13d392c72049c6b99fc9253","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5ca6b62c_cdfaec30","in_reply_to":"ab421ba9_9c2947c7","updated":"2025-09-08 18:15:51.000000000","message":"We\u0027ve tested that not much is required to support app credentials, at least in the way Manila is now using them (Manila requests app creds for an external storage system to access specific secrets that end users provide it). It\u0027s only the inclusion of \"service_type\" in the keystone_authtoken section in barbican.","commit_id":"848ff758d2658a33cc15ede8cbe145c4a50e024f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"acdbdb53b04ba0b7bbeb10dffcfbda5a54172a91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"82db7f8f_09679ff1","updated":"2025-09-09 16:17:16.000000000","message":"Thanks, LGTM..","commit_id":"876f202e7fad83a36bfc785c83d9c8683f6bd55e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"09d60f091e91b228dd249b92083f272c8d9c75e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6ff99e04_acf47f0f","updated":"2025-09-04 17:56:07.000000000","message":"recheck","commit_id":"876f202e7fad83a36bfc785c83d9c8683f6bd55e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b62c45a92eb7d3a16edff88e1a7c639c97cee067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"17f2325c_5f846803","updated":"2025-09-09 19:40:51.000000000","message":"recheck\n\none of the scenario tests failed to SSH into a test VM","commit_id":"876f202e7fad83a36bfc785c83d9c8683f6bd55e"}],"devstack/plugin.sh":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"547184312c215e19aa8ba173604f518b33281db5","unresolved":true,"context_lines":[{"line_number":276,"context_line":"        echo -\"No configured backends, please set a value to MANILA_ENABLED_BACKENDS\""},{"line_number":277,"context_line":"        exit 1"},{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":"    if is_service_enabled barbican; then"},{"line_number":280,"context_line":"        configure_barbican $MANILA_CONF barbican barbican"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    configure_backends"},{"line_number":284,"context_line":"    iniset $MANILA_CONF DEFAULT enabled_share_backends $MANILA_ENABLED_BACKENDS"}],"source_content_type":"text/x-sh","patch_set":1,"id":"895a2ebd_07e6eeba","line":281,"range":{"start_line":279,"start_character":4,"end_line":281,"end_character":6},"updated":"2025-07-18 21:06:44.000000000","message":"this condition might not have worked, the dummy dhss\u003dtrue job didn\u0027t have any of the barbican configuration set as a result. Please take a look at it, as well as how the key_manager_backend was set","commit_id":"7fe5fe2ecb52810221702db1ca144e561cb2a6c2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"1111a02546633a9ddb98a390b89787d6b42db95b","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        echo -\"No configured backends, please set a value to MANILA_ENABLED_BACKENDS\""},{"line_number":277,"context_line":"        exit 1"},{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":"    if is_service_enabled barbican; then"},{"line_number":280,"context_line":"        configure_barbican $MANILA_CONF barbican barbican"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    configure_backends"},{"line_number":284,"context_line":"    iniset $MANILA_CONF DEFAULT enabled_share_backends $MANILA_ENABLED_BACKENDS"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fe15f939_fe35f336","line":281,"range":{"start_line":279,"start_character":4,"end_line":281,"end_character":6},"in_reply_to":"895a2ebd_07e6eeba","updated":"2025-07-24 07:42:23.000000000","message":"Done.","commit_id":"7fe5fe2ecb52810221702db1ca144e561cb2a6c2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"547184312c215e19aa8ba173604f518b33281db5","unresolved":true,"context_lines":[{"line_number":1153,"context_line":"    iniset $conf_file $section project_name service"},{"line_number":1154,"context_line":"    iniset $conf_file $section user_domain_name Default"},{"line_number":1155,"context_line":"    iniset $conf_file $section password $SERVICE_PASSWORD"},{"line_number":1156,"context_line":"    iniset $conf_file $section username barbican"},{"line_number":1157,"context_line":"    iniset $conf_file $section auth_type password"},{"line_number":1158,"context_line":"}"},{"line_number":1159,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ee061d3b_2f504e3f","line":1156,"range":{"start_line":1156,"start_character":40,"end_line":1156,"end_character":48},"updated":"2025-07-18 21:06:44.000000000","message":"$admin_user","commit_id":"7fe5fe2ecb52810221702db1ca144e561cb2a6c2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"51e9277fcb325db6725e809e4959a91baea94803","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"    iniset $conf_file $section project_name service"},{"line_number":1154,"context_line":"    iniset $conf_file $section user_domain_name Default"},{"line_number":1155,"context_line":"    iniset $conf_file $section password $SERVICE_PASSWORD"},{"line_number":1156,"context_line":"    iniset $conf_file $section username barbican"},{"line_number":1157,"context_line":"    iniset $conf_file $section auth_type password"},{"line_number":1158,"context_line":"}"},{"line_number":1159,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"07aef9e8_d1a0954a","line":1156,"range":{"start_line":1156,"start_character":40,"end_line":1156,"end_character":48},"in_reply_to":"ee061d3b_2f504e3f","updated":"2025-07-21 06:44:11.000000000","message":"Updated.","commit_id":"7fe5fe2ecb52810221702db1ca144e561cb2a6c2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"595590b239bdf73a4791f25293335ed0aae2788e","unresolved":true,"context_lines":[{"line_number":276,"context_line":"        echo -\"No configured backends, please set a value to MANILA_ENABLED_BACKENDS\""},{"line_number":277,"context_line":"        exit 1"},{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":"    if is_service_enabled barbican; then"},{"line_number":280,"context_line":"        configure_barbican $MANILA_CONF barbican barbican"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    configure_backends"},{"line_number":284,"context_line":"    iniset $MANILA_CONF DEFAULT enabled_share_backends $MANILA_ENABLED_BACKENDS"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4f06ce9a_5daf0511","line":281,"range":{"start_line":279,"start_character":3,"end_line":281,"end_character":6},"updated":"2025-07-21 19:26:48.000000000","message":"I think you can attempt to set\n\n```\n[key_manager]\nbackend\u003dbarbican\n```\nhere, in this conditional statement. you\u0027d need to do the same thing as the other iniset parameters are doing\n\n\nI\u0027d also attempt to do what is being done to other services above. We can skip some re-declarations of the function below this way, please check the suggested edit\n\n```suggestion\n    if is_service_enabled barbican; then\n        configure_keystone_authtoken_middleware $MANILA_CONF barbican barbican\n        iniset $MANILA_CONF barbican barbican_endpoint_type internal\n        iniset $MANILA_CONF barbican auth_endpoint $KEYSTONE_SERVICE_URI\n        iniset $MANILA_CONF key_manager backend barbican\n    fi\n```\nIdeally we should not hardcode the key_manager backend and the barbican_endpoint_type. Please create variables for that and set the variables on the job itself, so that we pick that up in the environment.","commit_id":"22060e6258d41f17b597ba9b76b81b30f07f4754"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"fb425b1b40e65bda76115cb0f2b7b15694f93429","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        echo -\"No configured backends, please set a value to MANILA_ENABLED_BACKENDS\""},{"line_number":277,"context_line":"        exit 1"},{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":"    if is_service_enabled barbican; then"},{"line_number":280,"context_line":"        configure_barbican $MANILA_CONF barbican barbican"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    configure_backends"},{"line_number":284,"context_line":"    iniset $MANILA_CONF DEFAULT enabled_share_backends $MANILA_ENABLED_BACKENDS"}],"source_content_type":"text/x-sh","patch_set":2,"id":"88b26537_4db3c8a1","line":281,"range":{"start_line":279,"start_character":3,"end_line":281,"end_character":6},"in_reply_to":"4f06ce9a_5daf0511","updated":"2025-07-22 13:58:24.000000000","message":"Done.","commit_id":"22060e6258d41f17b597ba9b76b81b30f07f4754"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"595590b239bdf73a4791f25293335ed0aae2788e","unresolved":true,"context_lines":[{"line_number":1140,"context_line":"    openstack --os-cloud devstack-admin bgp speaker add peer bgpspeaker bgppeer"},{"line_number":1141,"context_line":"}"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"function configure_barbican {"},{"line_number":1144,"context_line":"    local conf_file\u003d$1"},{"line_number":1145,"context_line":"    local admin_user\u003d$2"},{"line_number":1146,"context_line":"    local section\u003d${3:-barbican}"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"    iniset $conf_file $section barbican_endpoint_type internal"},{"line_number":1149,"context_line":"    iniset $conf_file $section auth_endpoint $KEYSTONE_SERVICE_URI"},{"line_number":1150,"context_line":"    iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI"},{"line_number":1151,"context_line":"    iniset $conf_file $section cafile $SSL_BUNDLE_FILE"},{"line_number":1152,"context_line":"    iniset $conf_file $section project_domain_name Default"},{"line_number":1153,"context_line":"    iniset $conf_file $section project_name service"},{"line_number":1154,"context_line":"    iniset $conf_file $section user_domain_name Default"},{"line_number":1155,"context_line":"    iniset $conf_file $section password $SERVICE_PASSWORD"},{"line_number":1156,"context_line":"    iniset $conf_file $section username $admin_user"},{"line_number":1157,"context_line":"    iniset $conf_file $section auth_type password"},{"line_number":1158,"context_line":"}"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"# Main dispatcher"},{"line_number":1161,"context_line":"if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"37db1776_fd77c7a0","line":1158,"range":{"start_line":1143,"start_character":0,"end_line":1158,"end_character":1},"updated":"2025-07-21 19:26:48.000000000","message":"please remove and let\u0027s attempt to reuse the existing code as I suggested. I think it will save us some maintenance time","commit_id":"22060e6258d41f17b597ba9b76b81b30f07f4754"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"fb425b1b40e65bda76115cb0f2b7b15694f93429","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"    openstack --os-cloud devstack-admin bgp speaker add peer bgpspeaker bgppeer"},{"line_number":1141,"context_line":"}"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"function configure_barbican {"},{"line_number":1144,"context_line":"    local conf_file\u003d$1"},{"line_number":1145,"context_line":"    local admin_user\u003d$2"},{"line_number":1146,"context_line":"    local section\u003d${3:-barbican}"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"    iniset $conf_file $section barbican_endpoint_type internal"},{"line_number":1149,"context_line":"    iniset $conf_file $section auth_endpoint $KEYSTONE_SERVICE_URI"},{"line_number":1150,"context_line":"    iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI"},{"line_number":1151,"context_line":"    iniset $conf_file $section cafile $SSL_BUNDLE_FILE"},{"line_number":1152,"context_line":"    iniset $conf_file $section project_domain_name Default"},{"line_number":1153,"context_line":"    iniset $conf_file $section project_name service"},{"line_number":1154,"context_line":"    iniset $conf_file $section user_domain_name Default"},{"line_number":1155,"context_line":"    iniset $conf_file $section password $SERVICE_PASSWORD"},{"line_number":1156,"context_line":"    iniset $conf_file $section username $admin_user"},{"line_number":1157,"context_line":"    iniset $conf_file $section auth_type password"},{"line_number":1158,"context_line":"}"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"# Main dispatcher"},{"line_number":1161,"context_line":"if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"48650edf_e1c31cc4","line":1158,"range":{"start_line":1143,"start_character":0,"end_line":1158,"end_character":1},"in_reply_to":"37db1776_fd77c7a0","updated":"2025-07-22 13:58:24.000000000","message":"Done.","commit_id":"22060e6258d41f17b597ba9b76b81b30f07f4754"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77ac2a6b5801fdc9e3de602a4f94c80cab26cfb6","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"        iniset $BARBICAN_CONF keystone_authtoken service_type $SERVICE_TYPE"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    configure_backends"}],"source_content_type":"text/x-sh","patch_set":4,"id":"05a2ac1d_ac42f2d7","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":75},"updated":"2025-07-31 14:51:31.000000000","message":"?\n\nWhy is this necessary?","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"9c53668d788533a3ddb5c4f1411ce8d76c1b9992","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"        iniset $BARBICAN_CONF keystone_authtoken service_type $SERVICE_TYPE"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    configure_backends"}],"source_content_type":"text/x-sh","patch_set":4,"id":"b6a78a13_28a70870","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":75},"in_reply_to":"05a2ac1d_ac42f2d7","updated":"2025-08-04 13:38:56.000000000","message":"Hi Goutham, \n\nThis is was also requested by our ONTAP team. They have developed barbican APIs and they must be using service token for communication between 2 OpenStack services. AFAIK, When they were testing with DevStack, the keystore enable API was not working for them and they updated this and it was working so we had to keep this for our testing as well throughout the development phase!! Thank you.","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dcaf2d1b4d658dfae13d392c72049c6b99fc9253","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"        iniset $BARBICAN_CONF keystone_authtoken service_type $SERVICE_TYPE"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    configure_backends"}],"source_content_type":"text/x-sh","patch_set":4,"id":"06cfebff_b0f22a80","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":75},"in_reply_to":"4b4d9aab_99dfd7ba","updated":"2025-09-08 18:15:51.000000000","message":"Resolving this conversation because the discussion continued in other changes (https://review.opendev.org/c/openstack/barbican/+/958845 and https://review.opendev.org/c/openstack/devstack/+/959436)","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c686116b0f61b2908be004d6de080c734517d73d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"        iniset $BARBICAN_CONF keystone_authtoken service_type $SERVICE_TYPE"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    configure_backends"}],"source_content_type":"text/x-sh","patch_set":4,"id":"8e5c3b2d_52eca00c","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":75},"in_reply_to":"72e57478_6d4ed06e","updated":"2025-08-29 09:24:39.000000000","message":"Hi Goutham, \n\nWill move this to barbican project as suggested. Thank you.","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dabf314ac66aa8510a1813f9bbdfba2d30caecca","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"        iniset $BARBICAN_CONF keystone_authtoken service_type $SERVICE_TYPE"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    configure_backends"}],"source_content_type":"text/x-sh","patch_set":4,"id":"4b4d9aab_99dfd7ba","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":75},"in_reply_to":"8e5c3b2d_52eca00c","updated":"2025-08-29 12:58:44.000000000","message":"Did they really deploy barbican using devstack ?\nCurrent devstack uses password authentication for authtokenmiddleware which does NOT require service_type. If you face that problem then probably they use application credential but that\u0027s not what devstack currently supports.","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b380247f249c9ebfdc3f0e0cb555743f64f22d2","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"        iniset $BARBICAN_CONF keystone_authtoken service_type $SERVICE_TYPE"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    configure_backends"}],"source_content_type":"text/x-sh","patch_set":4,"id":"72e57478_6d4ed06e","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":75},"in_reply_to":"b6a78a13_28a70870","updated":"2025-08-27 00:19:33.000000000","message":"Hmm, it looks like its necessary with application credentials\nBarbican\u0027s devstack plugin ought to include this then - can you please propose it there?\n\nhttps://docs.openstack.org/keystone/latest/user/application_credentials.html#access-rules","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dcaf2d1b4d658dfae13d392c72049c6b99fc9253","unresolved":true,"context_lines":[{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":"    if is_service_enabled barbican; then"},{"line_number":280,"context_line":"        configure_keystone_authtoken_middleware $MANILA_CONF barbican barbican"},{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"    fi"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"cea3c18e_ffaab664","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":78},"updated":"2025-09-08 18:15:51.000000000","message":"these two options are being removed in: https://review.opendev.org/c/openstack/manila/+/959104\n\nPTAL and test/update this change","commit_id":"876f202e7fad83a36bfc785c83d9c8683f6bd55e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c27a50a7008e06e9903cb516b35c03db240eadb4","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":"    if is_service_enabled barbican; then"},{"line_number":280,"context_line":"        configure_keystone_authtoken_middleware $MANILA_CONF barbican barbican"},{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"    fi"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"6028ae77_17ac79cb","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":78},"in_reply_to":"215e4752_9b833a40","updated":"2025-09-09 14:51:41.000000000","message":"Tested the share encryption workflow by cherry-picking the changes  https://review.opendev.org/c/openstack/manila/+/959104.\n\n1. Deployed latest DevStack\n2. Cherry picked the changes from 959104\n3. Configure all the required stuff required to execute encrypted share creation workflow\n4. Restart manila services\n5. Create all OpenStack necessary things like share-network, keystore...etc as needed for share creation.\n6. Execute share encryption workflow\n\n\nTest below encrypted share creation workflows and I don\u0027t see any regression due to 959104 changes.\n1. NFS ZAPI \n   - Create share\n   - Delete share\n   - Delete share server\n2. NFS REST\n   - Create share\n   - Delete share\n   - Delete share server\n3. CIFS ZAPI\n   - Create share\n   - Delete share\n   - Delete share server\n\nAs mentioned in last sync-up meeting, CIFS REST workflow has an issue and will come back with a triage soon, will have a bug raised if needed according to the RCA. \n\n\nNote: I had below 2 lines also in the manila.conf as Takashi mentioned they are needed. \nbarbican_endpoint_type \u003d internal\nauth_endpoint \u003d https://\u003cIP\u003e/identity","commit_id":"876f202e7fad83a36bfc785c83d9c8683f6bd55e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a6b00b08a15abdbc1dab27789600d6aff63d7f9a","unresolved":true,"context_lines":[{"line_number":278,"context_line":"    fi"},{"line_number":279,"context_line":"    if is_service_enabled barbican; then"},{"line_number":280,"context_line":"        configure_keystone_authtoken_middleware $MANILA_CONF barbican barbican"},{"line_number":281,"context_line":"        iniset $MANILA_CONF barbican barbican_endpoint_type $BARBICAN_ENDPOINT_TYPE"},{"line_number":282,"context_line":"        iniset $MANILA_CONF barbican auth_endpoint $BARBICAN_KEYSTONE_ENDPOINT"},{"line_number":283,"context_line":"        iniset $MANILA_CONF key_manager backend $KEY_MANAGER_BACKEND"},{"line_number":284,"context_line":"    fi"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"215e4752_9b833a40","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":78},"in_reply_to":"cea3c18e_ffaab664","updated":"2025-09-09 06:51:27.000000000","message":"I think these are still required (and use in the core castellan implementation).","commit_id":"876f202e7fad83a36bfc785c83d9c8683f6bd55e"}],"devstack/settings":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b380247f249c9ebfdc3f0e0cb555743f64f22d2","unresolved":true,"context_lines":[{"line_number":50,"context_line":"BARBICAN_KEYSTONE_ENDPOINT\u003d${BARBICAN_KEYSTONE_ENDPOINT:-$KEYSTONE_SERVICE_URI}"},{"line_number":51,"context_line":"BARBICAN_CONF_DIR\u003d${BARBICAN_CONF_DIR:-/etc/barbican}"},{"line_number":52,"context_line":"BARBICAN_CONF\u003d$BARBICAN_CONF_DIR/barbican.conf"},{"line_number":53,"context_line":"SERVICE_TYPE\u003d${SERVICE_TYPE:-key-manager}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Set this to False to leave \"default_share_type\" and"},{"line_number":56,"context_line":"# \"default_share_group_type\" configuration options empty."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"2b71a863_146799f2","line":53,"updated":"2025-08-27 00:19:33.000000000","message":"BARBICAN_SERVICE_TYPE?","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c686116b0f61b2908be004d6de080c734517d73d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"BARBICAN_KEYSTONE_ENDPOINT\u003d${BARBICAN_KEYSTONE_ENDPOINT:-$KEYSTONE_SERVICE_URI}"},{"line_number":51,"context_line":"BARBICAN_CONF_DIR\u003d${BARBICAN_CONF_DIR:-/etc/barbican}"},{"line_number":52,"context_line":"BARBICAN_CONF\u003d$BARBICAN_CONF_DIR/barbican.conf"},{"line_number":53,"context_line":"SERVICE_TYPE\u003d${SERVICE_TYPE:-key-manager}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Set this to False to leave \"default_share_type\" and"},{"line_number":56,"context_line":"# \"default_share_group_type\" configuration options empty."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"11f09a80_e35c1ace","line":53,"in_reply_to":"2b71a863_146799f2","updated":"2025-08-29 09:24:39.000000000","message":"I don\u0027t think we need this anymore, so removed this line. Please let me know if this is okay.","commit_id":"9bf66ade12803e5516bf7e6888b1c9057c2dfe5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"15606aa55e6fe2c07b4c4f1106e161d24b0a3336","unresolved":true,"context_lines":[{"line_number":48,"context_line":"BARBICAN_ENDPOINT_TYPE\u003d${BARBICAN_ENDPOINT_TYPE:-internal}"},{"line_number":49,"context_line":"KEY_MANAGER_BACKEND\u003d${KEY_MANAGER_BACKEND:-barbican}"},{"line_number":50,"context_line":"BARBICAN_KEYSTONE_ENDPOINT\u003d${BARBICAN_KEYSTONE_ENDPOINT:-$KEYSTONE_SERVICE_URI}"},{"line_number":51,"context_line":"BARBICAN_CONF_DIR\u003d${BARBICAN_CONF_DIR:-/etc/barbican}"},{"line_number":52,"context_line":"BARBICAN_CONF\u003d$BARBICAN_CONF_DIR/barbican.conf"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Set this to False to leave \"default_share_type\" and"},{"line_number":55,"context_line":"# \"default_share_group_type\" configuration options empty."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"05f61008_5fd456e0","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":46},"updated":"2025-08-29 13:01:47.000000000","message":"These two lines are no longer needed.","commit_id":"848ff758d2658a33cc15ede8cbe145c4a50e024f"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4f13575ce7fd1d464c993101e59de389c8cc0af7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"BARBICAN_ENDPOINT_TYPE\u003d${BARBICAN_ENDPOINT_TYPE:-internal}"},{"line_number":49,"context_line":"KEY_MANAGER_BACKEND\u003d${KEY_MANAGER_BACKEND:-barbican}"},{"line_number":50,"context_line":"BARBICAN_KEYSTONE_ENDPOINT\u003d${BARBICAN_KEYSTONE_ENDPOINT:-$KEYSTONE_SERVICE_URI}"},{"line_number":51,"context_line":"BARBICAN_CONF_DIR\u003d${BARBICAN_CONF_DIR:-/etc/barbican}"},{"line_number":52,"context_line":"BARBICAN_CONF\u003d$BARBICAN_CONF_DIR/barbican.conf"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Set this to False to leave \"default_share_type\" and"},{"line_number":55,"context_line":"# \"default_share_group_type\" configuration options empty."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"135e2f22_8c1aa57d","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":46},"in_reply_to":"05f61008_5fd456e0","updated":"2025-08-29 13:37:05.000000000","message":"Done.","commit_id":"848ff758d2658a33cc15ede8cbe145c4a50e024f"}]}