)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"248996b109e14f358630483261e89b7a4ca4d034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f0671066_0e641de9","updated":"2025-12-19 18:53:18.000000000","message":"This is a great bug fix, Kiran. I believe there\u0027s a part that might need some tweaking. Please take a look at the comment inline","commit_id":"58fa5a435ca7a94fad3fce17dbb5a52ec293ad83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c5969d10ba8da26328c7acdcb119f6f245a3c021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c824177_8d59b4d0","updated":"2026-01-08 00:32:22.000000000","message":"LGTM, thank Kiran and Chuan!","commit_id":"bfdbe0c50008a75fc8f48a12275c83c6d926d8b5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"df7d4c1626bf290c0478f14ab21f4f7e9c0422f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cd5b43dc_7bfb88d2","updated":"2026-01-07 13:44:32.000000000","message":"LGTM, thanks Kiran","commit_id":"bfdbe0c50008a75fc8f48a12275c83c6d926d8b5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a96396be54f61a9f409770545cd27cf51106e43b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cb717dc4_dc212ab9","updated":"2026-01-08 18:01:12.000000000","message":"worth backporting this to all maintained stable branches, @kinpaa@gmail.com?","commit_id":"bfdbe0c50008a75fc8f48a12275c83c6d926d8b5"}],"manila/api/v1/share_servers.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"248996b109e14f358630483261e89b7a4ca4d034","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        if search_opts:"},{"line_number":85,"context_line":"            for k, v in search_opts.items():"},{"line_number":86,"context_line":"                share_servers \u003d [s for s in share_servers if"},{"line_number":87,"context_line":"                                 (hasattr(s, k) and"},{"line_number":88,"context_line":"                                  s[k] \u003d\u003d v or k \u003d\u003d \u0027share_network\u0027 and"},{"line_number":89,"context_line":"                                  v in [s.share_network_name,"},{"line_number":90,"context_line":"                                        s.share_network_id] or"},{"line_number":91,"context_line":"                                  k \u003d\u003d \u0027share_network_subnet_id\u0027 and"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e864011_e5ec4736","line":88,"range":{"start_line":87,"start_character":34,"end_line":88,"end_character":43},"updated":"2025-12-19 18:53:18.000000000","message":"when it has filters, this should be 100% true all the time now, no? so maybe this code should also be modified to fit the new filtering way","commit_id":"58fa5a435ca7a94fad3fce17dbb5a52ec293ad83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a3f29a4070898c7ba58a9f1f86a00c3492f53a18","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        if search_opts:"},{"line_number":85,"context_line":"            for k, v in search_opts.items():"},{"line_number":86,"context_line":"                share_servers \u003d [s for s in share_servers if"},{"line_number":87,"context_line":"                                 (hasattr(s, k) and"},{"line_number":88,"context_line":"                                  s[k] \u003d\u003d v or k \u003d\u003d \u0027share_network\u0027 and"},{"line_number":89,"context_line":"                                  v in [s.share_network_name,"},{"line_number":90,"context_line":"                                        s.share_network_id] or"},{"line_number":91,"context_line":"                                  k \u003d\u003d \u0027share_network_subnet_id\u0027 and"}],"source_content_type":"text/x-python","patch_set":5,"id":"6596c23c_16478c67","line":88,"range":{"start_line":87,"start_character":34,"end_line":88,"end_character":43},"in_reply_to":"4b567d62_9439da5a","updated":"2025-12-30 17:26:25.000000000","message":"sorry, let me clarify: I meant this is now ambiguous and should not exist here anymore, as the filtering is happening in the database. You\u0027re having an if statement into something that was already retrieved to the database based on the filters, so this condition will always be true. I think this check should be dropped and you should evaluate keeping only the ones after the \"or\" clause.","commit_id":"58fa5a435ca7a94fad3fce17dbb5a52ec293ad83"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c4592a6211ff4f76ecd34ac3a0c345ceb5fa3bfa","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        if search_opts:"},{"line_number":85,"context_line":"            for k, v in search_opts.items():"},{"line_number":86,"context_line":"                share_servers \u003d [s for s in share_servers if"},{"line_number":87,"context_line":"                                 (hasattr(s, k) and"},{"line_number":88,"context_line":"                                  s[k] \u003d\u003d v or k \u003d\u003d \u0027share_network\u0027 and"},{"line_number":89,"context_line":"                                  v in [s.share_network_name,"},{"line_number":90,"context_line":"                                        s.share_network_id] or"},{"line_number":91,"context_line":"                                  k \u003d\u003d \u0027share_network_subnet_id\u0027 and"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b567d62_9439da5a","line":88,"range":{"start_line":87,"start_character":34,"end_line":88,"end_character":43},"in_reply_to":"4e864011_e5ec4736","updated":"2025-12-30 14:54:17.000000000","message":"can you bit more detailed what changes are expected in network/subnet filtering ?","commit_id":"58fa5a435ca7a94fad3fce17dbb5a52ec293ad83"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fb6e43cc6911650c4e28d3697928148353b79c85","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if search_opts:"},{"line_number":85,"context_line":"            for k, v in search_opts.items():"},{"line_number":86,"context_line":"                share_servers \u003d [s for s in share_servers if"},{"line_number":87,"context_line":"                                 (hasattr(s, k) and"},{"line_number":88,"context_line":"                                  s[k] \u003d\u003d v or k \u003d\u003d \u0027share_network\u0027 and"},{"line_number":89,"context_line":"                                  v in [s.share_network_name,"},{"line_number":90,"context_line":"                                        s.share_network_id] or"},{"line_number":91,"context_line":"                                  k \u003d\u003d \u0027share_network_subnet_id\u0027 and"}],"source_content_type":"text/x-python","patch_set":5,"id":"c323faf0_d1db5832","line":88,"range":{"start_line":87,"start_character":34,"end_line":88,"end_character":43},"in_reply_to":"6596c23c_16478c67","updated":"2026-01-03 05:28:52.000000000","message":"That condition is needed to filter share servers by project_id as you can see above the condition we assign project_id to already filtered share_servers and then check for that attribute. So the check can not be dropped otherwise  test_index_project_id_filter() fails.","commit_id":"58fa5a435ca7a94fad3fce17dbb5a52ec293ad83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"df7d4c1626bf290c0478f14ab21f4f7e9c0422f4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if search_opts:"},{"line_number":85,"context_line":"            for k, v in search_opts.items():"},{"line_number":86,"context_line":"                share_servers \u003d [s for s in share_servers if"},{"line_number":87,"context_line":"                                 (hasattr(s, k) and"},{"line_number":88,"context_line":"                                  s[k] \u003d\u003d v or k \u003d\u003d \u0027share_network\u0027 and"},{"line_number":89,"context_line":"                                  v in [s.share_network_name,"},{"line_number":90,"context_line":"                                        s.share_network_id] or"},{"line_number":91,"context_line":"                                  k \u003d\u003d \u0027share_network_subnet_id\u0027 and"}],"source_content_type":"text/x-python","patch_set":5,"id":"2f0929c8_9c451378","line":88,"range":{"start_line":87,"start_character":34,"end_line":88,"end_character":43},"in_reply_to":"c323faf0_d1db5832","updated":"2026-01-07 13:44:32.000000000","message":"Ack, that makes sense. I also missed all the filters that are already being applied are being popped and we\u0027re looking at what remained in the seach options.","commit_id":"58fa5a435ca7a94fad3fce17dbb5a52ec293ad83"}]}