)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fd243c218539520631d4cfa4de714ed4b1fb5f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"292c1491_0efb16f6","updated":"2025-08-18 22:21:13.000000000","message":"Can a NetApp engineer please test/ack this change?","commit_id":"8cc21a840ab67a310e1210e0018a7a1b4f451be6"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"59650434f968a2c6cf1b896b1c19e1c77ceb437d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7fdfc445_ea28c2fd","updated":"2025-08-13 10:16:15.000000000","message":"Hi, Reviewers,\n\nThis patch is created out of comments from https://review.opendev.org/c/openstack/manila/+/951669\n\nThis is tested with REST basic creation workflows. Please review and approve. Thank you!!","commit_id":"8cc21a840ab67a310e1210e0018a7a1b4f451be6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5fa19e8a0dc6761d8ddc80d8cb6c573a958c3032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9a61392_8628104b","updated":"2025-08-18 22:21:01.000000000","message":"LGTM, only some minor tweaks to the release note. Also, could you please add the closes-bug tag to the commit message?","commit_id":"8cc21a840ab67a310e1210e0018a7a1b4f451be6"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c0d30f9bcd02b0a9f7581dec3bffc212b089bd6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fb5d024d_a260c629","updated":"2025-08-19 05:39:00.000000000","message":"LGTM ..!","commit_id":"1d39fc59d07c2b439a2b778b36100ad1e212ba59"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0044fce4734aec562dba78c94526eb2a54d525c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49803d5a_3e81c525","updated":"2025-08-19 04:45:58.000000000","message":"Thank you Carloss. Addressed the comments!","commit_id":"1d39fc59d07c2b439a2b778b36100ad1e212ba59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e1e12a10b028dea603b0521f450adc12d59a7bee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3cfa90b9_3295760a","updated":"2025-08-25 14:39:33.000000000","message":"Please take a look at the comments inline","commit_id":"c1d6415a87e8d04052606d45ac5021b1f4b80d69"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4d2eff894010c947a6e28065b772863380c69738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b31c0191_fab1046c","updated":"2025-08-21 18:14:25.000000000","message":"recheck","commit_id":"c1d6415a87e8d04052606d45ac5021b1f4b80d69"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48503261de05b6a4d9972f58b0cd29f0cebc2579","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"84a247e4_2785f31c","updated":"2025-08-28 16:54:34.000000000","message":"Hey Sai, \n\nShould this fix be backported? and if yes, how far back? Can you please propose backports?","commit_id":"4e694d4780cf2803122a3256b0e4ca1279acb6c5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"218bd5b2fcececec4b53dcf45ad5cdb42603b380","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a4a5bea7_0b6332bb","updated":"2025-08-28 13:30:41.000000000","message":"LGTM, thanks Sai","commit_id":"4e694d4780cf2803122a3256b0e4ca1279acb6c5"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5e0c18cb49c8d5333e350caf0bf859812416c3a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2f301ae0_fd14c6e5","updated":"2025-08-26 13:14:53.000000000","message":"Run-NetApp CI","commit_id":"4e694d4780cf2803122a3256b0e4ca1279acb6c5"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0aa475999d571c5b87094435373462c5262e17e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fe598771_6ff04419","updated":"2025-08-25 17:37:39.000000000","message":"Thank you for the comments @ces.eduardo98@gmail.com, addressed them. Please take a look and approve.","commit_id":"4e694d4780cf2803122a3256b0e4ca1279acb6c5"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"2beab3976974bcc599563c24f8efaa8f08bc0c88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e9612795_613be99e","in_reply_to":"84a247e4_2785f31c","updated":"2025-08-29 06:42:23.000000000","message":"Yes Goutham, thank you. We are looking at backporting this till Antelope. For now, I have proposed backport to epoxy. https://review.opendev.org/c/openstack/manila/+/958828","commit_id":"4e694d4780cf2803122a3256b0e4ca1279acb6c5"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"856eb49ccb8f5bbd9a8a346c58090a19d630592f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dc73f226_446c4593","in_reply_to":"bee0ee9a_2d1224b2","updated":"2025-09-04 13:02:14.000000000","message":"Sure Goutham, will do thank you!","commit_id":"4e694d4780cf2803122a3256b0e4ca1279acb6c5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d045da37c30b4aed708fce25e7b728cc049489d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bee0ee9a_2d1224b2","in_reply_to":"e9612795_613be99e","updated":"2025-09-03 22:51:21.000000000","message":"Thank you; please propose this to older branches as well in order..","commit_id":"4e694d4780cf2803122a3256b0e4ca1279acb6c5"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e1e12a10b028dea603b0521f450adc12d59a7bee","unresolved":true,"context_lines":[{"line_number":5626,"context_line":"            \u0027get\u0027"},{"line_number":5627,"context_line":"        )"},{"line_number":5628,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5629,"context_line":"        return \u0027not configured\u0027 not in clock_fmt_value.lower()"},{"line_number":5630,"context_line":""},{"line_number":5631,"context_line":"    @na_utils.trace"},{"line_number":5632,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":4,"id":"53ba7c0d_2f1c940c","side":"PARENT","line":5629,"range":{"start_line":5629,"start_character":16,"end_line":5629,"end_character":31},"updated":"2025-08-25 14:39:33.000000000","message":"not necessary check anymore? is it 100% of the times configured now? If there\u0027s still a chance, I\u0027d suggest:\n\n```suggestion\n        return (\n            clock_fmt_value is not None and\n            (\u0027not configured\u0027 not in clock_fmt_value.lower()))\n```","commit_id":"06cf298bbbbb77a2427ef8abdb7c8834e2bd12cb"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0aa475999d571c5b87094435373462c5262e17e2","unresolved":false,"context_lines":[{"line_number":5626,"context_line":"            \u0027get\u0027"},{"line_number":5627,"context_line":"        )"},{"line_number":5628,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5629,"context_line":"        return \u0027not configured\u0027 not in clock_fmt_value.lower()"},{"line_number":5630,"context_line":""},{"line_number":5631,"context_line":"    @na_utils.trace"},{"line_number":5632,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9d6ccb03_75b85c30","side":"PARENT","line":5629,"range":{"start_line":5629,"start_character":16,"end_line":5629,"end_character":31},"in_reply_to":"53ba7c0d_2f1c940c","updated":"2025-08-25 17:37:39.000000000","message":"Thank you for the suggestion Carloss but if clock_fmt_value is None: means not configured, and this specific code was verified/suggested by Gireesh to work for any cluster. We would like to keep it like this.","commit_id":"06cf298bbbbb77a2427ef8abdb7c8834e2bd12cb"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e1e12a10b028dea603b0521f450adc12d59a7bee","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                \u0027services\u0027: \u0027,\u0027.join(protocols),"},{"line_number":758,"context_line":"                \u0027fields\u0027: \u0027ip.address,location.home_node.name,\u0027"},{"line_number":759,"context_line":"                          \u0027location.home_port.name,ip.netmask,\u0027"},{"line_number":760,"context_line":"                          \u0027services,svm.name,enabled\u0027"},{"line_number":761,"context_line":"            }"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            query \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"43c8afdb_6787daad","line":760,"updated":"2025-08-25 14:39:33.000000000","message":"please don\u0027t remove blank lines in a commit. Here and below","commit_id":"c1d6415a87e8d04052606d45ac5021b1f4b80d69"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0aa475999d571c5b87094435373462c5262e17e2","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                \u0027services\u0027: \u0027,\u0027.join(protocols),"},{"line_number":758,"context_line":"                \u0027fields\u0027: \u0027ip.address,location.home_node.name,\u0027"},{"line_number":759,"context_line":"                          \u0027location.home_port.name,ip.netmask,\u0027"},{"line_number":760,"context_line":"                          \u0027services,svm.name,enabled\u0027"},{"line_number":761,"context_line":"            }"},{"line_number":762,"context_line":"        else:"},{"line_number":763,"context_line":"            query \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"b2b0cf93_35ba8808","line":760,"in_reply_to":"43c8afdb_6787daad","updated":"2025-08-25 17:37:39.000000000","message":"Done. Added back blank lines.","commit_id":"c1d6415a87e8d04052606d45ac5021b1f4b80d69"}],"releasenotes/notes/bug-2120291-netapp-rest-basic-share-creation-failure-fixes-f768ba19f3157db4.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5fa19e8a0dc6761d8ddc80d8cb6c573a958c3032","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The netapp driver had an issue while checking for WORM shares compliance"},{"line_number":5,"context_line":"    during the shares creation. The issue is now fixed, and share creation"},{"line_number":6,"context_line":"    works fine with both rest and netapp legacy client."},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cfd7a639_1ee99a92","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":34},"updated":"2025-08-18 22:21:01.000000000","message":"NetApp ONTAP driver failed while...","commit_id":"8cc21a840ab67a310e1210e0018a7a1b4f451be6"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0044fce4734aec562dba78c94526eb2a54d525c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The netapp driver had an issue while checking for WORM shares compliance"},{"line_number":5,"context_line":"    during the shares creation. The issue is now fixed, and share creation"},{"line_number":6,"context_line":"    works fine with both rest and netapp legacy client."},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"79ad1179_332d294f","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":34},"in_reply_to":"cfd7a639_1ee99a92","updated":"2025-08-19 04:45:58.000000000","message":"Done.","commit_id":"8cc21a840ab67a310e1210e0018a7a1b4f451be6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5fa19e8a0dc6761d8ddc80d8cb6c573a958c3032","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The netapp driver had an issue while checking for WORM shares compliance"},{"line_number":5,"context_line":"    during the shares creation. The issue is now fixed, and share creation"},{"line_number":6,"context_line":"    works fine with both rest and netapp legacy client."},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    `Bug #2120291 \u003chttps://bugs.launchpad.net/manila/+bug/2120291\u003e`_:"},{"line_number":9,"context_line":"    [NetApp-REST] Basic share creation workflow failing with few errors"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"986c7a79_5007d238","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":71},"updated":"2025-08-18 22:21:01.000000000","message":"```suggestion\n    for more details, please refer to \n    `Launchpad bug #2120291 \u003chttps://bugs.launchpad.net/manila/+bug/2120291\u003e`_.\n```","commit_id":"8cc21a840ab67a310e1210e0018a7a1b4f451be6"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0044fce4734aec562dba78c94526eb2a54d525c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The netapp driver had an issue while checking for WORM shares compliance"},{"line_number":5,"context_line":"    during the shares creation. The issue is now fixed, and share creation"},{"line_number":6,"context_line":"    works fine with both rest and netapp legacy client."},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    `Bug #2120291 \u003chttps://bugs.launchpad.net/manila/+bug/2120291\u003e`_:"},{"line_number":9,"context_line":"    [NetApp-REST] Basic share creation workflow failing with few errors"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"439bea8f_5b760de0","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":71},"in_reply_to":"986c7a79_5007d238","updated":"2025-08-19 04:45:58.000000000","message":"Done.","commit_id":"8cc21a840ab67a310e1210e0018a7a1b4f451be6"}]}
