)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"17a2040218dcba36ad666cde5786ac6110833d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef940887_78b15514","updated":"2025-09-04 23:30:40.000000000","message":"This seems to clone a volume to do BFV, couldn\u0027t it just use the same image instead?","commit_id":"db479f1ec1e2f1ea5dfebfa36524b82223894228"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"3f6da2a61d4a3c44253d8e1ed99ad7b0963514fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"361bede3_a36f3c17","updated":"2025-10-09 00:06:54.000000000","message":"bump","commit_id":"db479f1ec1e2f1ea5dfebfa36524b82223894228"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"69e8dd5a097bc21102179376bfc736e53d87429c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"417ac685_42634ed0","updated":"2025-09-02 01:57:18.000000000","message":"here\u0027s the test output on devstack env\n\nubuntu@instance:/opt/stack/manila$ openstack share network create --neutron-net-id $(openstack network list |grep private|cut -d \u0027 \u0027 -f2) --neutron-subnet-id $(openstack subnet list |grep \u0027 private\u0027|cut -d \u0027 \u0027 -f2) --name share-net\n+-----------------------------------+----------------------------------------------------------+\n| Field                             | Value                                                    |\n+-----------------------------------+----------------------------------------------------------+\n| id                                | db48360d-e53c-47d5-a385-23fb141af132                     |\n| name                              | share-net                                                |\n| project_id                        | 8bfe318a8c9f45b49562a58fa8190ae5                         |\n| created_at                        | 2025-09-02T01:41:41.762823                               |\n| updated_at                        | None                                                     |\n| description                       | None                                                     |\n| status                            | active                                                   |\n| security_service_update_support   | True                                                     |\n| network_allocation_update_support | True                                                     |\n| share_network_subnets             |                                                          |\n|                                   | id \u003d 32ea821b-c004-4eca-b028-e1b44c80493c                |\n|                                   | availability_zone \u003d None                                 |\n|                                   | created_at \u003d 2025-09-02T01:41:41.831143                  |\n|                                   | updated_at \u003d None                                        |\n|                                   | segmentation_id \u003d None                                   |\n|                                   | neutron_net_id \u003d 06659c6c-87a4-4302-80ad-450271f2dcc7    |\n|                                   | neutron_subnet_id \u003d ef0aed11-d971-43e3-b0d3-483e414b4114 |\n|                                   | ip_version \u003d None                                        |\n|                                   | cidr \u003d None                                              |\n|                                   | network_type \u003d None                                      |\n|                                   | mtu \u003d None                                               |\n|                                   | gateway \u003d None                                           |\n|                                   | metadata \u003d {}                                            |\n+-----------------------------------+----------------------------------------------------------+\nubuntu@instance:/opt/stack/manila$ openstack share create --share-network $(openstack share network list|grep share-net|cut -d \u0027 \u0027 -f2) --name share1 NFS 1\n+---------------------------------------+--------------------------------------+\n| Field                                 | Value                                |\n+---------------------------------------+--------------------------------------+\n| id                                    | 7954d4f4-3f18-4853-966a-4cbdddd23249 |\n| size                                  | 1                                    |\n| availability_zone                     | None                                 |\n| created_at                            | 2025-09-02T01:41:55.908570           |\n| status                                | creating                             |\n| name                                  | share1                               |\n| description                           | None                                 |\n| project_id                            | 8bfe318a8c9f45b49562a58fa8190ae5     |\n| snapshot_id                           | None                                 |\n| share_network_id                      | db48360d-e53c-47d5-a385-23fb141af132 |\n| share_proto                           | NFS                                  |\n| metadata                              | {}                                   |\n| share_type                            | 69a32358-5fa2-4602-abde-0869de5f8f92 |\n| volume_type                           | default                              |\n| is_public                             | False                                |\n| snapshot_support                      | False                                |\n| task_state                            | None                                 |\n| share_type_name                       | default                              |\n| access_rules_status                   | active                               |\n| replication_type                      | None                                 |\n| has_replicas                          | False                                |\n| user_id                               | 34dcea77e14343abb48ea8bffc64deba     |\n| create_share_from_snapshot_support    | False                                |\n| revert_to_snapshot_support            | False                                |\n| share_group_id                        | None                                 |\n| source_share_group_snapshot_member_id | None                                 |\n| mount_snapshot_support                | False                                |\n| progress                              | None                                 |\n| is_soft_deleted                       | False                                |\n| scheduled_to_be_deleted_at            | None                                 |\n| source_backup_id                      | None                                 |\n| share_server_id                       | None                                 |\n| host                                  |                                      |\n+---------------------------------------+--------------------------------------+\nubuntu@instance:/opt/stack/manila$ openstack server list --all-projects\n+--------------------------------------+-----------------------------------------------+--------+----------+--------------------------+-----------------------+----------------------------------+\n| ID                                   | Name                                          | Status | Networks | Image                    | Flavor                | Project ID                       |\n+--------------------------------------+-----------------------------------------------+--------+----------+--------------------------+-----------------------+----------------------------------+\n| b988a2ac-b4d5-4856-854a-6dd034d376b3 | generic2_ea210904-3cc7-4c63-8c6d-276b5784cde1 | BUILD  |          | N/A (booted from volume) | manila-service-flavor | f7e93d0942e949aebfe4bf746f6a0929 |\n+--------------------------------------+-----------------------------------------------+--------+----------+--------------------------+-----------------------+----------------------------------+\nubuntu@instance:/opt/stack/manila$ openstack server list --all-projects\n+------------------------------------+------------------------------------+--------+------------------------------------+--------------------------+-----------------------+----------------------------------+\n| ID                                 | Name                               | Status | Networks                           | Image                    | Flavor                | Project ID                       |\n+------------------------------------+------------------------------------+--------+------------------------------------+--------------------------+-----------------------+----------------------------------+\n| b988a2ac-b4d5-4856-854a-           | generic2_ea210904-3cc7-4c63-8c6d-  | ACTIVE | admin_net\u003d10.2.5.74;               | N/A (booted from volume) | manila-service-flavor | f7e93d0942e949aebfe4bf746f6a0929 |\n| 6dd034d376b3                       | 276b5784cde1                       |        | manila_service_network\u003d10.254.0.10 |                          |                       |                                  |\n+------------------------------------+------------------------------------+--------+------------------------------------+--------------------------+-----------------------+----------------------------------+\nubuntu@instance:/opt/stack/manila$ openstack volume list --all-projects\n+--------------------------------------+--------------------------------------------+-----------+------+---------------------------------------------------------------+\n| ID                                   | Name                                       | Status    | Size | Attached to                                                   |\n+--------------------------------------+--------------------------------------------+-----------+------+---------------------------------------------------------------+\n| b9ab56ff-6959-4b3b-b891-0757921b72c0 |                                            | in-use    |   10 | Attached to b988a2ac-b4d5-4856-854a-6dd034d376b3 on /dev/vda  |\n| 80781a03-37f0-4f02-b24c-93414bda8b6e | image-1004d6a3-35e0-424e-9cbb-f3b1bdf3e64b | available |    4 |                                                               |\n+--------------------------------------+--------------------------------------------+-----------+------+---------------------------------------------------------------+","commit_id":"db479f1ec1e2f1ea5dfebfa36524b82223894228"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"52fb5ec98bcbfaf9461fe47d591adac088777579","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80ce258f_3d056bb5","in_reply_to":"ef940887_78b15514","updated":"2025-09-05 07:37:51.000000000","message":"This patch supports both ways to do  BFV, with either image.\n\n_build_bdm_from_image in manila/share/drivers/service_instance.py will be used for format block device mapping if base volume id is not provided.","commit_id":"db479f1ec1e2f1ea5dfebfa36524b82223894228"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"123ec3932094a795fa5073294b7d39c7ef4528c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"116bd1de_4b752712","updated":"2026-01-16 19:01:03.000000000","message":"This looks pretty neat, thank you @ricolin@ricolky.com\n\nI just have a suggestion inline","commit_id":"84c4879e4f9b257ceb90c5c62c580e157a096190"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a0039c88f9e9e0e6c15daedd1d76898a40617792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25934e51_9da6d328","updated":"2026-01-20 20:39:17.000000000","message":"recheck","commit_id":"84c4879e4f9b257ceb90c5c62c580e157a096190"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8320e07b8d15d57e901cd329f5d3d83ddd3bd3f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"09ed0b60_35b5f5a2","updated":"2026-01-29 22:24:59.000000000","message":"LGTM, thank you @ricolin@ricolky.com","commit_id":"fe05f588fb44b2356d13550c91e284210a474200"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62a2d7591f70fecb2c60f3f569e31480e741429d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"50101539_a53dcd8b","updated":"2026-01-29 22:25:08.000000000","message":"recheck\n\ngeneric driver job timed out","commit_id":"fe05f588fb44b2356d13550c91e284210a474200"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"123ec3932094a795fa5073294b7d39c7ef4528c4","unresolved":true,"context_lines":[{"line_number":135,"context_line":"             \u0027Only used if driver_handles_share_servers\u003dTrue.\u0027"},{"line_number":136,"context_line":"    ),"},{"line_number":137,"context_line":"    cfg.IntOpt("},{"line_number":138,"context_line":"        \u0027boot_volume_size\u0027,"},{"line_number":139,"context_line":"        default\u003d10,"},{"line_number":140,"context_line":"        min\u003d1,"},{"line_number":141,"context_line":"        help\u003d\u0027Size (GiB) of the root volume when booting from volume. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"891553da_7b286274","line":138,"range":{"start_line":138,"start_character":9,"end_line":138,"end_character":25},"updated":"2026-01-16 19:01:03.000000000","message":"i\u0027d suggest prefixing: \"service_instance_\" to all these options too..\n\nthese are in the [DEFAULT] section, and would be less confusing..","commit_id":"84c4879e4f9b257ceb90c5c62c580e157a096190"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"a7aa26608d58b1edcfe4d8192cc79a66534679d0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"             \u0027Only used if driver_handles_share_servers\u003dTrue.\u0027"},{"line_number":136,"context_line":"    ),"},{"line_number":137,"context_line":"    cfg.IntOpt("},{"line_number":138,"context_line":"        \u0027boot_volume_size\u0027,"},{"line_number":139,"context_line":"        default\u003d10,"},{"line_number":140,"context_line":"        min\u003d1,"},{"line_number":141,"context_line":"        help\u003d\u0027Size (GiB) of the root volume when booting from volume. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b2c5b6b_8579106a","line":138,"range":{"start_line":138,"start_character":9,"end_line":138,"end_character":25},"in_reply_to":"891553da_7b286274","updated":"2026-01-23 07:48:20.000000000","message":"Done","commit_id":"84c4879e4f9b257ceb90c5c62c580e157a096190"}],"manila/volume/cinder.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"123ec3932094a795fa5073294b7d39c7ef4528c4","unresolved":true,"context_lines":[{"line_number":331,"context_line":"                                  msg_timeout\u003d\"Volume action timeout.\","},{"line_number":332,"context_line":"                                  expected_size\u003dNone):"},{"line_number":333,"context_line":"        t \u003d time.time()"},{"line_number":334,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":335,"context_line":"            if volume[\u0027status\u0027] \u003d\u003d const.STATUS_AVAILABLE:"},{"line_number":336,"context_line":"                if expected_size and volume[\u0027size\u0027] !\u003d expected_size:"},{"line_number":337,"context_line":"                    LOG.debug(\"The volume %(vol_id)s is available but the \""},{"line_number":338,"context_line":"                              \"volume size does not match the expected size. \""},{"line_number":339,"context_line":"                              \"A volume resize operation may be pending. \""},{"line_number":340,"context_line":"                              \"Expected size: %(expected_size)s, \""},{"line_number":341,"context_line":"                              \"Actual size: %(volume_size)s.\","},{"line_number":342,"context_line":"                              dict(vol_id\u003dvolume[\u0027id\u0027],"},{"line_number":343,"context_line":"                                   expected_size\u003dexpected_size,"},{"line_number":344,"context_line":"                                   volume_size\u003dvolume[\u0027size\u0027]))"},{"line_number":345,"context_line":"                else:"},{"line_number":346,"context_line":"                    break"},{"line_number":347,"context_line":"            elif \u0027error\u0027 in volume[\u0027status\u0027].lower():"},{"line_number":348,"context_line":"                raise exception.ManilaException(msg_error)"},{"line_number":349,"context_line":"            time.sleep(1)"},{"line_number":350,"context_line":"            volume \u003d self.get(ctxt.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            raise exception.ManilaException(msg_timeout)"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"021f933f_48f7d32e","line":350,"range":{"start_line":334,"start_character":0,"end_line":350,"end_character":69},"updated":"2026-01-16 19:01:03.000000000","message":"please consider rewriting this with the retry decorator here: https://github.com/openstack/manila/blob/59ed29572d0e659aa720028cdde1f0d8bcb36a4d/manila/utils.py#L383-L390","commit_id":"db479f1ec1e2f1ea5dfebfa36524b82223894228"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"a7aa26608d58b1edcfe4d8192cc79a66534679d0","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                                  msg_timeout\u003d\"Volume action timeout.\","},{"line_number":332,"context_line":"                                  expected_size\u003dNone):"},{"line_number":333,"context_line":"        t \u003d time.time()"},{"line_number":334,"context_line":"        while time.time() - t \u003c timeout:"},{"line_number":335,"context_line":"            if volume[\u0027status\u0027] \u003d\u003d const.STATUS_AVAILABLE:"},{"line_number":336,"context_line":"                if expected_size and volume[\u0027size\u0027] !\u003d expected_size:"},{"line_number":337,"context_line":"                    LOG.debug(\"The volume %(vol_id)s is available but the \""},{"line_number":338,"context_line":"                              \"volume size does not match the expected size. \""},{"line_number":339,"context_line":"                              \"A volume resize operation may be pending. \""},{"line_number":340,"context_line":"                              \"Expected size: %(expected_size)s, \""},{"line_number":341,"context_line":"                              \"Actual size: %(volume_size)s.\","},{"line_number":342,"context_line":"                              dict(vol_id\u003dvolume[\u0027id\u0027],"},{"line_number":343,"context_line":"                                   expected_size\u003dexpected_size,"},{"line_number":344,"context_line":"                                   volume_size\u003dvolume[\u0027size\u0027]))"},{"line_number":345,"context_line":"                else:"},{"line_number":346,"context_line":"                    break"},{"line_number":347,"context_line":"            elif \u0027error\u0027 in volume[\u0027status\u0027].lower():"},{"line_number":348,"context_line":"                raise exception.ManilaException(msg_error)"},{"line_number":349,"context_line":"            time.sleep(1)"},{"line_number":350,"context_line":"            volume \u003d self.get(ctxt.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            raise exception.ManilaException(msg_timeout)"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"88d2e308_1e692cb0","line":350,"range":{"start_line":334,"start_character":0,"end_line":350,"end_character":69},"in_reply_to":"021f933f_48f7d32e","updated":"2026-01-23 07:48:20.000000000","message":"Done","commit_id":"db479f1ec1e2f1ea5dfebfa36524b82223894228"}]}