)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5e3546a113ee17d9ccbc47fb4cd379252376ddf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a2e79f69_a9d84f55","updated":"2025-11-07 21:23:32.000000000","message":"Changes look good, thanks! Added some thoughts on the open TODOs","commit_id":"3ffbfab1df3feba897c428fe8f505a9257f10b2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ebdbc4edae94fed195a6b865de6f547a6baf276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f21f9a1c_0f1f5ee9","updated":"2026-01-09 23:36:49.000000000","message":"LGTM, thank you Stephen.. we can fix the minor issues noted in a follow up commit, i\u0027ll do that shortly","commit_id":"f83cfbe155f07337ddd77531cfb2a18c2ea42daf"}],"manila/api/schemas/shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5e3546a113ee17d9ccbc47fb4cd379252376ddf9","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                \u0027force_host_assisted_migration\u0027: parameter_types.boolean,"},{"line_number":105,"context_line":"                # TODO(stephenfin): Add pattern for `host@backend#pool`"},{"line_number":106,"context_line":"                \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":107,"context_line":"                # TODO(stephenfin): Should we enforce format\u003duuid here?"},{"line_number":108,"context_line":"                \u0027new_share_network_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":109,"context_line":"                \u0027new_share_type_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":110,"context_line":"                \u0027nondisruptive\u0027: parameter_types.boolean,"}],"source_content_type":"text/x-python","patch_set":3,"id":"07ee1b66_9c8db56e","line":107,"range":{"start_line":107,"start_character":36,"end_line":107,"end_character":71},"updated":"2025-11-07 21:23:32.000000000","message":"IMHO, yes :)","commit_id":"3ffbfab1df3feba897c428fe8f505a9257f10b2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aadfabdb6b2858c9a6c73cc5bb63086ecefe9839","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                \u0027force_host_assisted_migration\u0027: parameter_types.boolean,"},{"line_number":105,"context_line":"                # TODO(stephenfin): Add pattern for `host@backend#pool`"},{"line_number":106,"context_line":"                \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":107,"context_line":"                # TODO(stephenfin): Should we enforce format\u003duuid here?"},{"line_number":108,"context_line":"                \u0027new_share_network_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":109,"context_line":"                \u0027new_share_type_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":110,"context_line":"                \u0027nondisruptive\u0027: parameter_types.boolean,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4fddad5e_a50ed056","line":107,"range":{"start_line":107,"start_character":36,"end_line":107,"end_character":71},"in_reply_to":"07ee1b66_9c8db56e","updated":"2026-01-09 23:36:11.000000000","message":"lets do it in a follow up.","commit_id":"3ffbfab1df3feba897c428fe8f505a9257f10b2a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5e3546a113ee17d9ccbc47fb4cd379252376ddf9","unresolved":true,"context_lines":[{"line_number":277,"context_line":"migration_get_progress_response_body_v259 \u003d copy.deepcopy("},{"line_number":278,"context_line":"    migration_get_progress_response_body"},{"line_number":279,"context_line":")"},{"line_number":280,"context_line":"migration_get_progress_response_body_v259[\u0027properties\u0027].update({"},{"line_number":281,"context_line":"    # TODO(stephenfin): What is the type of this?"},{"line_number":282,"context_line":"    \u0027details\u0027: {},"},{"line_number":283,"context_line":"})"},{"line_number":284,"context_line":"migration_get_progress_response_body_v259[\u0027required\u0027].append(\u0027details\u0027)"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a5c719d6_b6d51931","line":282,"range":{"start_line":280,"start_character":14,"end_line":282,"end_character":0},"updated":"2025-11-07 21:23:32.000000000","message":"this would be an object, usually in the format of: percentage: 100, or something similar","commit_id":"3ffbfab1df3feba897c428fe8f505a9257f10b2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aadfabdb6b2858c9a6c73cc5bb63086ecefe9839","unresolved":true,"context_lines":[{"line_number":277,"context_line":"migration_get_progress_response_body_v259 \u003d copy.deepcopy("},{"line_number":278,"context_line":"    migration_get_progress_response_body"},{"line_number":279,"context_line":")"},{"line_number":280,"context_line":"migration_get_progress_response_body_v259[\u0027properties\u0027].update({"},{"line_number":281,"context_line":"    # TODO(stephenfin): What is the type of this?"},{"line_number":282,"context_line":"    \u0027details\u0027: {},"},{"line_number":283,"context_line":"})"},{"line_number":284,"context_line":"migration_get_progress_response_body_v259[\u0027required\u0027].append(\u0027details\u0027)"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c6a4d13f_dc7ffd9c","line":282,"range":{"start_line":280,"start_character":14,"end_line":282,"end_character":0},"in_reply_to":"a5c719d6_b6d51931","updated":"2026-01-09 23:36:11.000000000","message":"it\u0027s a dictionary that can have arbitrary keys and values.. \n\nhttps://github.com/openstack/manila/commit/aa62a8090ec3aa988bad89e2eb7535059fe8131f","commit_id":"3ffbfab1df3feba897c428fe8f505a9257f10b2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aadfabdb6b2858c9a6c73cc5bb63086ecefe9839","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":98,"context_line":"                # TODO(stephenfin): Should we enforce format\u003duuid here?"},{"line_number":99,"context_line":"                \u0027new_share_network_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":100,"context_line":"                \u0027new_share_type_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":101,"context_line":"                \u0027nondisruptive\u0027: parameter_types.boolean,"},{"line_number":102,"context_line":"                \u0027preserve_metadata\u0027: parameter_types.boolean,"},{"line_number":103,"context_line":"                \u0027preserve_snapshots\u0027: parameter_types.boolean,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec3bc849_821c8cd0","line":100,"range":{"start_line":100,"start_character":58,"end_line":100,"end_character":62},"updated":"2026-01-09 23:36:11.000000000","message":"same","commit_id":"f83cfbe155f07337ddd77531cfb2a18c2ea42daf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aadfabdb6b2858c9a6c73cc5bb63086ecefe9839","unresolved":true,"context_lines":[{"line_number":256,"context_line":"migration_get_progress_response_body \u003d {"},{"line_number":257,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":258,"context_line":"    \u0027properties\u0027: {"},{"line_number":259,"context_line":"        \u0027task_state\u0027: {"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        },"},{"line_number":262,"context_line":"        \u0027total_progress\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027min\u0027: 0, \u0027max\u0027: 100},"},{"line_number":263,"context_line":"    },"},{"line_number":264,"context_line":"    \u0027required\u0027: [\u0027task_state\u0027, \u0027total_progress\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"d0a2ba30_ac673811","line":261,"range":{"start_line":259,"start_character":22,"end_line":261,"end_character":10},"updated":"2026-01-09 23:36:11.000000000","message":"isn\u0027t this supposed to be an ENUM?","commit_id":"f83cfbe155f07337ddd77531cfb2a18c2ea42daf"}]}
