)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c61c60cb5346aa53be42194bb327a6dd5473aa14","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: cifs - enable SMB signing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default it would be disabled. It can only be enabled after cifs"},{"line_number":10,"context_line":"server has been created. Therefore this can not be coupled with the"},{"line_number":11,"context_line":"other cifs security settings that are handled in"},{"line_number":12,"context_line":"configure_cifs_encryption() before cifs server creation. We wait 5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"90a8e54d_44d01a0c","line":9,"updated":"2026-01-22 15:39:08.000000000","message":"The reason ONTAP does not enable SMB signing is because of performance. Please refer to the link: \n\nhttps://docs.netapp.com/us-en/ontap-technical-reports/ontap-security-hardening/configure-smb-signing-sealing.html\n\nIMO we should still give this option to the customers by using a configuration on manila.conf instead of forcing it. Although I do agree that for security reasons it should be enforced by customers.\n\nOpinions?","commit_id":"3cc32e97705844ba2dadb01a79e1a16d0c37f6f1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2cb74fc1ff9383ee041715bcaaf533f721d14235","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: cifs - enable SMB signing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default it would be disabled. It can only be enabled after cifs"},{"line_number":10,"context_line":"server has been created. Therefore this can not be coupled with the"},{"line_number":11,"context_line":"other cifs security settings that are handled in"},{"line_number":12,"context_line":"configure_cifs_encryption() before cifs server creation. We wait 5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e199b85b_62c474ac","line":9,"in_reply_to":"90a8e54d_44d01a0c","updated":"2026-01-23 07:13:37.000000000","message":"ok, I have added config option and disabled by default.","commit_id":"3cc32e97705844ba2dadb01a79e1a16d0c37f6f1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c61c60cb5346aa53be42194bb327a6dd5473aa14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"536d7304_5968fcf5","updated":"2026-01-22 15:39:08.000000000","message":"Please look at comments.","commit_id":"3cc32e97705844ba2dadb01a79e1a16d0c37f6f1"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"020dc12d60a0e1ff6e2c24eaf640b149ead20313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"345c9831_f9c5e580","updated":"2026-01-28 12:36:41.000000000","message":"LGTM","commit_id":"55d0d078388cbb257aed8617dd1e3ed12bff0594"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c9e8dcbc689ec39995fa5cd4616049a4ba006d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5c35e6e_7d7b67ac","updated":"2026-01-29 16:17:22.000000000","message":"LGTM","commit_id":"55d0d078388cbb257aed8617dd1e3ed12bff0594"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"1b19d585271d92806950df08dd9345bdc4b3ad42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ae17dfb6_3f78060a","updated":"2026-01-30 09:41:23.000000000","message":"LGTM","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"dfe9e9c1dffbb73ed635ee068eb3db972a844d4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7787b7f9_6d5d451e","updated":"2026-02-03 12:43:54.000000000","message":"Run-NetApp CI","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"230dbc3e8c5f355da0df378837219edf5b15f9fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e8132534_c2238626","updated":"2026-02-03 12:45:11.000000000","message":"Thanks Kiran for working on this, have provided few minor comments, could you also run the NetApp CI for this patch.","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"4d902abda7cbcff7ce0fce21a00acd523ab8c39c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"296a1e4f_8831c403","updated":"2026-02-06 10:50:10.000000000","message":"LGTM","commit_id":"e4b774bdf6220d44f9652359f4dc9d724e5f7c20"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"cc684a9b681de2e1743b905492378ed9595898cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"302233f8_008b8d89","updated":"2026-02-06 08:30:42.000000000","message":"LGTM","commit_id":"e4b774bdf6220d44f9652359f4dc9d724e5f7c20"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"82c5a4cbd07d3a76262be15d5817779f12faac67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"70cde492_908c2617","updated":"2026-02-04 04:22:49.000000000","message":"NetApp CI DHSS True+rest+NFS test cases passed\n\n\nhttps://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/88/962588/6/upstream-check-manila/manila-tempest-plugin-ontap-dhss-rest/034b1af/","commit_id":"e4b774bdf6220d44f9652359f4dc9d724e5f7c20"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"c0ec54c384d0d092956cb205e0d49a6ed993cb4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f64e4929_4ef9836b","updated":"2026-02-03 13:58:56.000000000","message":"Run-NetApp CI","commit_id":"e4b774bdf6220d44f9652359f4dc9d724e5f7c20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0112732f17bdf5f5b6bf3518ee459fb492a78439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"744fb1cc_96883125","updated":"2026-03-02 16:36:12.000000000","message":"rebased","commit_id":"e4b774bdf6220d44f9652359f4dc9d724e5f7c20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d416766c4f794ccb01b2587823496a124023da93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1367ed2d_74456ac6","updated":"2026-03-03 06:12:31.000000000","message":"Anoop/Kumar,\nCan you approve again ? The PR is just rebased and NetApp CI is all good too.","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"21e4d701980bea099382c7e4269cae1ca154cf72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"84a8e8ca_bb652e78","updated":"2026-03-04 11:03:35.000000000","message":"LGTM!","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0112485bfa8fc6de6bb77e8098a5834aada41e8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"60553b25_a309db46","updated":"2026-03-05 12:42:12.000000000","message":"Looks good for the most part, I think there might be a bug in the client rest though, please take a look at the comments inline","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"c0ddaf1c08a1a220e706a5a91930b29bfaba06af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5f39e9ab_a9218ba9","updated":"2026-03-05 08:21:02.000000000","message":"Thanks kiran for working on this and NetApp CI also passing. LGTM ..!","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"145790e3af8e339ae4dcecdd12baf3285e4f1add","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"986737e9_e39d87c1","updated":"2026-03-05 17:06:09.000000000","message":"LGTM, thanks Kiran. I\u0027d like to ask NetApp engineers to please review and test this change.","commit_id":"850295b786c8fbe63486e25dd45da34142ccef60"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"163ea57df055abac4fdf5c761a7ffa9b821e659c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4a6bc3dd_6e09605b","updated":"2026-03-05 15:45:30.000000000","message":"One comment following up CArlos\u0027 finding.","commit_id":"850295b786c8fbe63486e25dd45da34142ccef60"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"28f1846630d45419e1ab402ea9cc15df39f546e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"94f17070_7c9b482d","updated":"2026-03-06 06:44:26.000000000","message":"Thanks Carlos. Fix is tested with ZAPI and gated by config option(default False), so we are good to add.","commit_id":"850295b786c8fbe63486e25dd45da34142ccef60"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"404216d867322b31f0ff73584a2155f0ea019308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8513326e_854dda67","updated":"2026-03-10 13:24:24.000000000","message":"thanks for review.","commit_id":"850295b786c8fbe63486e25dd45da34142ccef60"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"230dbc3e8c5f355da0df378837219edf5b15f9fb","unresolved":true,"context_lines":[{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":"    @na_utils.trace"},{"line_number":1701,"context_line":"    def setup_security_services(self, security_services, vserver_client,"},{"line_number":1702,"context_line":"                                vserver_name, aes_encryption, smb_signing,"},{"line_number":1703,"context_line":"                                timeout\u003d30):"},{"line_number":1704,"context_line":"        api_args \u003d {"},{"line_number":1705,"context_line":"            \u0027name-mapping-switch\u0027: ["}],"source_content_type":"text/x-python","patch_set":5,"id":"53d729b1_46f6de4d","line":1702,"range":{"start_line":1702,"start_character":62,"end_line":1702,"end_character":73},"updated":"2026-02-03 12:45:11.000000000","message":"nit- it is better to set it default value to False","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"902911fc53a01cae2bd416488658743b0edf825c","unresolved":false,"context_lines":[{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":"    @na_utils.trace"},{"line_number":1701,"context_line":"    def setup_security_services(self, security_services, vserver_client,"},{"line_number":1702,"context_line":"                                vserver_name, aes_encryption, smb_signing,"},{"line_number":1703,"context_line":"                                timeout\u003d30):"},{"line_number":1704,"context_line":"        api_args \u003d {"},{"line_number":1705,"context_line":"            \u0027name-mapping-switch\u0027: ["}],"source_content_type":"text/x-python","patch_set":5,"id":"93bcf802_1051ae1c","line":1702,"range":{"start_line":1702,"start_character":62,"end_line":1702,"end_character":73},"in_reply_to":"53d729b1_46f6de4d","updated":"2026-02-03 12:54:48.000000000","message":"we are sending conf value similar to aes_encryption. So default is not needed.","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"230dbc3e8c5f355da0df378837219edf5b15f9fb","unresolved":true,"context_lines":[{"line_number":2411,"context_line":"                        backoff_rate\u003d1)"},{"line_number":2412,"context_line":"    def wait_for_cifs_server(self, vserver_name):"},{"line_number":2413,"context_line":"        if not self.cifs_server_exists(vserver_name):"},{"line_number":2414,"context_line":"            msg \u003d f\"Cifs server on vserver {vserver_name} not found.\""},{"line_number":2415,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"03b58f31_2b44f88b","line":2414,"range":{"start_line":2414,"start_character":12,"end_line":2414,"end_character":69},"updated":"2026-02-03 12:45:11.000000000","message":"nit- better to follow the same pattern for exception message \n\nmsg \u003d _(\u0027Cifs server on vserver %(vserver_name)s not found..\u0027)\nmsg_args \u003d {\u0027vserver_name\u0027: vserver_name}\nraise exception.NetAppException(msg % msg_args)","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"902911fc53a01cae2bd416488658743b0edf825c","unresolved":false,"context_lines":[{"line_number":2411,"context_line":"                        backoff_rate\u003d1)"},{"line_number":2412,"context_line":"    def wait_for_cifs_server(self, vserver_name):"},{"line_number":2413,"context_line":"        if not self.cifs_server_exists(vserver_name):"},{"line_number":2414,"context_line":"            msg \u003d f\"Cifs server on vserver {vserver_name} not found.\""},{"line_number":2415,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f25c4ce_d0956730","line":2414,"range":{"start_line":2414,"start_character":12,"end_line":2414,"end_character":69},"in_reply_to":"03b58f31_2b44f88b","updated":"2026-02-03 12:54:48.000000000","message":"Done","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0112485bfa8fc6de6bb77e8098a5834aada41e8e","unresolved":true,"context_lines":[{"line_number":4465,"context_line":"                    self.wait_for_cifs_server(vserver_name)"},{"line_number":4466,"context_line":"                    self.configure_cifs_signing(vserver_name)"},{"line_number":4467,"context_line":"                except exception.NetAppException as e:"},{"line_number":4468,"context_line":"                    LOG.error(f\"Gave up waiting and proceed for cifs server \""},{"line_number":4469,"context_line":"                              f\"on vserver {vserver_name}. {e.message}\")"},{"line_number":4470,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4471,"context_line":"            credential_msg \u003d \"could not authenticate\""},{"line_number":4472,"context_line":"            privilege_msg \u003d \"insufficient access\""}],"source_content_type":"text/x-python","patch_set":7,"id":"31d9720e_d40435d6","line":4469,"range":{"start_line":4468,"start_character":30,"end_line":4469,"end_character":71},"updated":"2026-03-05 12:42:12.000000000","message":"```suggestion\n                    LOG.error(f\"Gave up waiting for CIFS server \"\n                              f\"on vserver {vserver_name}. Proceeding. \"\n                               \" {e.message}\")\n```","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fc68d3837ace356339328314f480544fdb5522ef","unresolved":false,"context_lines":[{"line_number":4465,"context_line":"                    self.wait_for_cifs_server(vserver_name)"},{"line_number":4466,"context_line":"                    self.configure_cifs_signing(vserver_name)"},{"line_number":4467,"context_line":"                except exception.NetAppException as e:"},{"line_number":4468,"context_line":"                    LOG.error(f\"Gave up waiting and proceed for cifs server \""},{"line_number":4469,"context_line":"                              f\"on vserver {vserver_name}. {e.message}\")"},{"line_number":4470,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4471,"context_line":"            credential_msg \u003d \"could not authenticate\""},{"line_number":4472,"context_line":"            privilege_msg \u003d \"insufficient access\""}],"source_content_type":"text/x-python","patch_set":7,"id":"263d6892_0db08fcf","line":4469,"range":{"start_line":4468,"start_character":30,"end_line":4469,"end_character":71},"in_reply_to":"31d9720e_d40435d6","updated":"2026-03-05 13:33:00.000000000","message":"Done","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0112485bfa8fc6de6bb77e8098a5834aada41e8e","unresolved":true,"context_lines":[{"line_number":4832,"context_line":"            \u0027name\u0027: vserver_name if vserver_name else self.vserver,"},{"line_number":4833,"context_line":"            \u0027fields\u0027: \u0027uuid\u0027"},{"line_number":4834,"context_line":"        }"},{"line_number":4835,"context_line":"        response \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4836,"context_line":"        if not response.get(\u0027records\u0027):"},{"line_number":4837,"context_line":"            return False"},{"line_number":4838,"context_line":"        return True"},{"line_number":4839,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2f0cc69b_e911454b","line":4836,"range":{"start_line":4835,"start_character":7,"end_line":4836,"end_character":39},"updated":"2026-03-05 12:42:12.000000000","message":"this is checking if CIFS server exists, right, but why are we getting svms here instead? Shouldn\u0027t this be looking for existing cifs servers within the svm? I think it would look like /protocols/cifs/services/{svm_uuid} but I don\u0027t have a storage to test quickly","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fc68d3837ace356339328314f480544fdb5522ef","unresolved":false,"context_lines":[{"line_number":4832,"context_line":"            \u0027name\u0027: vserver_name if vserver_name else self.vserver,"},{"line_number":4833,"context_line":"            \u0027fields\u0027: \u0027uuid\u0027"},{"line_number":4834,"context_line":"        }"},{"line_number":4835,"context_line":"        response \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4836,"context_line":"        if not response.get(\u0027records\u0027):"},{"line_number":4837,"context_line":"            return False"},{"line_number":4838,"context_line":"        return True"},{"line_number":4839,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d75d2a24_d22607dc","line":4836,"range":{"start_line":4835,"start_character":7,"end_line":4836,"end_character":39},"in_reply_to":"2f0cc69b_e911454b","updated":"2026-03-05 13:33:00.000000000","message":"yes, we should better fetch cifs server and check name.","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0112485bfa8fc6de6bb77e8098a5834aada41e8e","unresolved":true,"context_lines":[{"line_number":4856,"context_line":"                 backoff_rate\u003d1)"},{"line_number":4857,"context_line":"    def wait_for_cifs_server(self, vserver_name):"},{"line_number":4858,"context_line":"        if not self.cifs_server_exists(vserver_name):"},{"line_number":4859,"context_line":"            msg \u003d f\"Cifs server on vserver {vserver_name} not found.\""},{"line_number":4860,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4861,"context_line":""},{"line_number":4862,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":7,"id":"f4c951f0_05a54ede","line":4859,"range":{"start_line":4859,"start_character":20,"end_line":4859,"end_character":24},"updated":"2026-03-05 12:42:12.000000000","message":"CIFS","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0112485bfa8fc6de6bb77e8098a5834aada41e8e","unresolved":true,"context_lines":[{"line_number":4856,"context_line":"                 backoff_rate\u003d1)"},{"line_number":4857,"context_line":"    def wait_for_cifs_server(self, vserver_name):"},{"line_number":4858,"context_line":"        if not self.cifs_server_exists(vserver_name):"},{"line_number":4859,"context_line":"            msg \u003d f\"Cifs server on vserver {vserver_name} not found.\""},{"line_number":4860,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4861,"context_line":""},{"line_number":4862,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":7,"id":"0a50ad44_58101d58","line":4859,"range":{"start_line":4859,"start_character":17,"end_line":4859,"end_character":69},"updated":"2026-03-05 12:42:12.000000000","message":"please do the translation, as in zapi","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fc68d3837ace356339328314f480544fdb5522ef","unresolved":false,"context_lines":[{"line_number":4856,"context_line":"                 backoff_rate\u003d1)"},{"line_number":4857,"context_line":"    def wait_for_cifs_server(self, vserver_name):"},{"line_number":4858,"context_line":"        if not self.cifs_server_exists(vserver_name):"},{"line_number":4859,"context_line":"            msg \u003d f\"Cifs server on vserver {vserver_name} not found.\""},{"line_number":4860,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4861,"context_line":""},{"line_number":4862,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":7,"id":"a23798bc_50a40140","line":4859,"range":{"start_line":4859,"start_character":17,"end_line":4859,"end_character":69},"in_reply_to":"0a50ad44_58101d58","updated":"2026-03-05 13:33:00.000000000","message":"Done","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"fc68d3837ace356339328314f480544fdb5522ef","unresolved":false,"context_lines":[{"line_number":4856,"context_line":"                 backoff_rate\u003d1)"},{"line_number":4857,"context_line":"    def wait_for_cifs_server(self, vserver_name):"},{"line_number":4858,"context_line":"        if not self.cifs_server_exists(vserver_name):"},{"line_number":4859,"context_line":"            msg \u003d f\"Cifs server on vserver {vserver_name} not found.\""},{"line_number":4860,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4861,"context_line":""},{"line_number":4862,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":7,"id":"ca49b43e_30c32cfe","line":4859,"range":{"start_line":4859,"start_character":20,"end_line":4859,"end_character":24},"in_reply_to":"f4c951f0_05a54ede","updated":"2026-03-05 13:33:00.000000000","message":"Done","commit_id":"95d3f75345255bce0787968080646eff0f79c2b2"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"163ea57df055abac4fdf5c761a7ffa9b821e659c","unresolved":true,"context_lines":[{"line_number":4851,"context_line":"                return False"},{"line_number":4852,"context_line":"            cifs_name \u003d response.get(\u0027records\u0027)[0][\u0027name\u0027]"},{"line_number":4853,"context_line":"            cifs_server \u003d self._get_cifs_server_name(vserver_name)"},{"line_number":4854,"context_line":"            if cifs_name \u003d\u003d cifs_server:"},{"line_number":4855,"context_line":"                return True"},{"line_number":4856,"context_line":"            return False"},{"line_number":4857,"context_line":"        except exception.NetAppException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"c28bd927_dd112fbf","line":4854,"updated":"2026-03-05 15:45:30.000000000","message":"Shouldnt we also check if enabled flag on the cifs server config is true?","commit_id":"850295b786c8fbe63486e25dd45da34142ccef60"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"4ee2b2451adf61ec63f8890820dfee729b9ceac0","unresolved":true,"context_lines":[{"line_number":4851,"context_line":"                return False"},{"line_number":4852,"context_line":"            cifs_name \u003d response.get(\u0027records\u0027)[0][\u0027name\u0027]"},{"line_number":4853,"context_line":"            cifs_server \u003d self._get_cifs_server_name(vserver_name)"},{"line_number":4854,"context_line":"            if cifs_name \u003d\u003d cifs_server:"},{"line_number":4855,"context_line":"                return True"},{"line_number":4856,"context_line":"            return False"},{"line_number":4857,"context_line":"        except exception.NetAppException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"b0c2ae5f_ec052f2b","line":4854,"in_reply_to":"963285ed_cef65c83","updated":"2026-03-10 13:34:15.000000000","message":"As discussed, I think it is okay for not checking the CIFS server status. But in a corner case, there can be a CIFS server configured but disabled. For now I feel its okay to limit the check to the existance.","commit_id":"850295b786c8fbe63486e25dd45da34142ccef60"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"47ec2d2b0532f317aea2b9480034d3e3a52292bb","unresolved":true,"context_lines":[{"line_number":4851,"context_line":"                return False"},{"line_number":4852,"context_line":"            cifs_name \u003d response.get(\u0027records\u0027)[0][\u0027name\u0027]"},{"line_number":4853,"context_line":"            cifs_server \u003d self._get_cifs_server_name(vserver_name)"},{"line_number":4854,"context_line":"            if cifs_name \u003d\u003d cifs_server:"},{"line_number":4855,"context_line":"                return True"},{"line_number":4856,"context_line":"            return False"},{"line_number":4857,"context_line":"        except exception.NetAppException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"963285ed_cef65c83","line":4854,"in_reply_to":"c28bd927_dd112fbf","updated":"2026-03-05 15:50:13.000000000","message":"yes, we can add that check. Compared with ZAPI where we just validate presence of CIFS server. wdyt ?","commit_id":"850295b786c8fbe63486e25dd45da34142ccef60"}],"releasenotes/notes/bug-2126055-netapp-cifs-enable-SMB-signing-29a179f3529e0ba4.yaml":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"657d0b0ad0f4511741339678a8e6c82329b5d0d6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Netapp ONTAP driver is fixed to enable SMB signing for CIFS server."},{"line_number":5,"context_line":"    For more details, please check"},{"line_number":6,"context_line":"    `Launchpad bug #2126055 \u003chttps://bugs.launchpad.net/manila/+bug/2126055\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"535ef3c6_e792461f","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":55},"updated":"2026-01-30 09:00:41.000000000","message":"Can you please mention the new option `netapp_cifs_smb_signing` and that operators would actively have to enable this, because the default is disabled.","commit_id":"55d0d078388cbb257aed8617dd1e3ed12bff0594"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"144e752e4c765e1640178dea63273e2efc1f0c83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Netapp ONTAP driver is fixed to enable SMB signing for CIFS server."},{"line_number":5,"context_line":"    For more details, please check"},{"line_number":6,"context_line":"    `Launchpad bug #2126055 \u003chttps://bugs.launchpad.net/manila/+bug/2126055\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"edb5a43a_27431fe5","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":55},"in_reply_to":"535ef3c6_e792461f","updated":"2026-01-30 09:36:25.000000000","message":"Done","commit_id":"55d0d078388cbb257aed8617dd1e3ed12bff0594"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"230dbc3e8c5f355da0df378837219edf5b15f9fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4e7d3f3d_c9f8607f","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":0},"updated":"2026-02-03 12:45:11.000000000","message":"Can you modify the release note same as below patch format, start with NetApp Driver bug ...\n\nhttps://review.opendev.org/c/openstack/manila/+/960948","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"902911fc53a01cae2bd416488658743b0edf825c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"467d4d3b_0dba21d5","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":0},"in_reply_to":"4e7d3f3d_c9f8607f","updated":"2026-02-03 12:54:48.000000000","message":"Done","commit_id":"8865bbf3ba543a98ac8423df90f0d79d57bd4fb1"}]}