)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0473dd6d8b8eccf9ae09e7db85f7ee52561f5f45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2a81bb7d_0ddcecb2","updated":"2025-10-14 05:15:34.000000000","message":"Please include a release note: \n\nhttps://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#what-are-release-notes\n\nAlso is there a launchpad bug for this issue?","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"931fb9df53588b270495746c8ac3736fb4d4568d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0790717d_c68d0f25","updated":"2025-10-14 07:29:44.000000000","message":"Run-NetApp CI","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e959049e314c9093185e2889f7a594020b34011c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"641418ae_6e31511b","updated":"2025-10-14 04:28:27.000000000","message":"Run-NetApp CI","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"fd93f05dbb46c0b2a957a29a36bdaaf0602b39d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70e1fca6_1851329b","in_reply_to":"2a81bb7d_0ddcecb2","updated":"2025-10-17 14:17:31.000000000","message":"Added the release notes. Also created a bug and linked it to the patch.","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e1d8f02aa4aa5e0ceaee16a689104236fe5ceab3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe80187c_1c0c2bbf","updated":"2025-10-17 07:25:24.000000000","message":"Run-NetApp CI","commit_id":"ab0d93493c52cd3d4132bfecf3f2f9d9f0112d5f"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"4e3888ffa12056b89ea66635b248bb1244845bc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3cf6f253_54034b99","updated":"2025-10-17 07:25:43.000000000","message":"This Patch is still WIP.","commit_id":"ab0d93493c52cd3d4132bfecf3f2f9d9f0112d5f"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a562c4a1faa3d3b9507ba2d5977b25ba6777a22b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00a4743b_4c640020","updated":"2025-10-17 19:09:50.000000000","message":"Manideep: instead of changing every ware.Can you explore?... else: if data_struct[k] is not None:\n                    child.set_content(str(data_struct[k]))\n        self.add_child_elem(child)","commit_id":"31383eabd77556460305e92744d8d3127bb55491"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"c286bfa2c5a586464de7dcf93326ba34252e7ed4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4d265904_072f4fba","updated":"2025-10-21 05:33:41.000000000","message":"Recheck","commit_id":"31383eabd77556460305e92744d8d3127bb55491"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"fd93f05dbb46c0b2a957a29a36bdaaf0602b39d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4fce81a_e59461b2","updated":"2025-10-17 14:17:31.000000000","message":"Run-NetApp CI","commit_id":"31383eabd77556460305e92744d8d3127bb55491"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"44a8909df27ae7fdaf415006538a71c596ad882e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f82ff20_ee7f8b39","updated":"2025-10-19 03:43:21.000000000","message":"recheck","commit_id":"31383eabd77556460305e92744d8d3127bb55491"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"5b96075e0a66d0154e1961552d963fac27611ce3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8467290c_f80b1ed5","updated":"2025-10-21 12:43:12.000000000","message":"Recheck","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"a7f1a18f3a26cf37824ccea23431bfb514ac62e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87009e49_d9794579","updated":"2025-10-22 17:10:21.000000000","message":"Recheck","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"d0a21f0b284328bef4e14e9609c947319f5f82d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8f0df0cc_bc32e942","updated":"2025-10-22 08:02:25.000000000","message":"Recheck","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"f15602ba55a071b5d85fb72269bf74b2135ef93f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c20e52fb_fc6d40c0","updated":"2025-10-21 17:09:12.000000000","message":"Recheck","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"ce5bbcbb4818c49a7b8837a145b9bad9b1ad8a80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c2cfb952_6eb69868","updated":"2025-10-21 09:53:30.000000000","message":"Recheck","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"989afeeb8e41414d43f7f478655484045f702cfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"43aa25c2_fd1fbf83","updated":"2025-10-22 08:02:18.000000000","message":"Run-NetApp CI","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"9c1c3fb641e8a8a9fbbd308c3ebcab0c20495d6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"63341245_2644b078","updated":"2025-10-21 14:19:37.000000000","message":"Run-NetApp CI","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"31d921c301fd49d3dff43aed3f2949b009bbe690","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"640b53a1_8c1e009d","updated":"2025-10-22 10:05:35.000000000","message":"Run-NetApp CI","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"c8fb4f7688326d29088c84ebcea651ae82272792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"658e7225_4e15f8dd","updated":"2025-10-22 10:38:28.000000000","message":"Run-NetApp CI","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"18e551f42f761e2dbff6361a652835336e8aae5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f278668a_0909271b","updated":"2025-10-22 17:10:30.000000000","message":"Run-NetApp CI","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"e33fbd8976582d62cc56ab0ab30a56fd95f3b46a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c3baea68_7c8e6ef8","updated":"2025-10-24 06:42:06.000000000","message":"pip8 job is failing for this, could you please check this.","commit_id":"4e4c231666806b494c622faa8363e1bbab43101e"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"e48a4aa26c53fe2e539bc3e136e3aeb4090a88fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b5229d31_f762e921","updated":"2025-10-27 06:29:20.000000000","message":"LGTM","commit_id":"7067b883325483ce0af7c8be170c14a16778baee"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"77485b417eca158df111da3787aa06e1150eb046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"08d77fd5_f80fa1fa","updated":"2025-11-01 16:36:43.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"22636b1adeb7e366f03ceed29bbcaaeb2105b60e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0b99770a_cd612f11","updated":"2025-10-31 04:00:56.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"07259f21080498529f01aca8edb5002bf6dbd020","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"17f220d7_2b0e9152","updated":"2025-11-01 17:36:17.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"048cc29e6e92e06ba264765821d9c76622f6e9e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"29889e13_3290bf71","updated":"2025-10-31 16:33:20.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e6500825d57fd62c824dbbba5ae32f1fc28b31a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2d284d0c_e7527949","updated":"2025-11-01 14:01:45.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"484ef7cffe2b9fdf94c7e62ee15249245fcbad2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2f150201_2eebecd7","updated":"2025-10-31 03:33:15.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"827e9bb4008d8e9889c4264fc600cc45b9f5a8d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"51968580_815614bc","updated":"2025-10-31 17:36:08.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"405aba539080896ffb9d8b43e7fc73085a65f414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"56020bac_84a30d3f","updated":"2025-10-31 03:48:06.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"f3fe3dbcdc1076e304271dc6b0b98765d53c9915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"577f83e0_5e2f9863","updated":"2025-10-31 07:34:43.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"7ca0b4d9e777c5b129214603fa99b2b3bfe46f13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7349ebce_4d590156","updated":"2025-10-31 15:41:23.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"f9ec061d54a025263847ce371161f9f39a3176a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d2144c1f_da00f6a3","updated":"2025-11-01 15:32:37.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"7225681cd5550a1216cdb7860ba363a579cf2903","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d515413d_83867909","updated":"2025-11-01 13:20:55.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"97755afd980cd6bd45d6d6f26f237143ac1bfb78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fd47433c_eed96246","updated":"2025-10-31 03:19:22.000000000","message":"Run-NetApp CI","commit_id":"df379ffdd404f1c3f56d01c968e2929940b81664"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"621fe67cc4c84add093c81b468bab1d539fe4692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"eeb9aa25_b923e13a","updated":"2025-11-01 19:26:01.000000000","message":"Run-NetApp CI","commit_id":"23414b468a70674be55c8d477ce598569b80b809"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"519de48f8f1c3ca09711db713ab9d3d75a20ae84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"84b06331_07f00b35","updated":"2025-11-03 05:02:59.000000000","message":"LGTM","commit_id":"36de432366599ddf5f7da9fe12ad278838dd5510"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3cc75f44ff7257534077f372b138c8802857505d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a1be195e_0e06562d","updated":"2025-11-03 11:21:45.000000000","message":"LGTM ..!","commit_id":"36de432366599ddf5f7da9fe12ad278838dd5510"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"550f70add47a6f168c01aa729e510f74430f1f6f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"441c4913_7e047c3b","updated":"2025-11-03 21:32:14.000000000","message":"Please add one or more unit tests with these situations:\n\n- delete_retention_hours is set to 0\n- delete_retention_hours is set to 65535","commit_id":"36de432366599ddf5f7da9fe12ad278838dd5510"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"208eb58fdf5095389e0fb8824d91acc446725fc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4ae25cd2_4ea40b06","updated":"2025-11-02 06:49:07.000000000","message":"Run-NetApp CI","commit_id":"36de432366599ddf5f7da9fe12ad278838dd5510"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"cb2ba7b1c80f2fd3162f77bb1d0307925110470d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9e2dff79_8f1ea792","in_reply_to":"441c4913_7e047c3b","updated":"2025-11-04 16:26:18.000000000","message":"Addressed. \nAdded test cases.","commit_id":"36de432366599ddf5f7da9fe12ad278838dd5510"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"89dbbfdb6953bb0b39fd30dadc28d5d6762f0736","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1f316da4_3a990dd8","updated":"2025-11-07 10:42:23.000000000","message":"LGTM, thanks Manideep!","commit_id":"122d96d89b59b43debc47a147cde67b2f039e572"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"db306f8341ea16ed7da11ebc14411351c7ca75c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7241dad2_92c49392","updated":"2025-11-05 07:41:45.000000000","message":"LGTM.","commit_id":"122d96d89b59b43debc47a147cde67b2f039e572"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a86465c698a6367608844007be284dbf85ecd723","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7dddb602_7eab479c","updated":"2025-11-07 04:11:36.000000000","message":"Thanks Manideep for working on this. Changes looks good for me.","commit_id":"122d96d89b59b43debc47a147cde67b2f039e572"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0473dd6d8b8eccf9ae09e7db85f7ee52561f5f45","unresolved":true,"context_lines":[{"line_number":260,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":261,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":262,"context_line":"        }"},{"line_number":263,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":264,"context_line":"            modify_args.update("},{"line_number":265,"context_line":"                {\u0027volume-delete-retention-hours\u0027: delete_retention_hours})"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2ec6457c_148e4876","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":48},"updated":"2025-10-14 05:15:34.000000000","message":"you\u0027ve to test if \"delete_retention_hours\" is not None; and that it has a value equal to or greater than 0","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"fd93f05dbb46c0b2a957a29a36bdaaf0602b39d9","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":261,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":262,"context_line":"        }"},{"line_number":263,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":264,"context_line":"            modify_args.update("},{"line_number":265,"context_line":"                {\u0027volume-delete-retention-hours\u0027: delete_retention_hours})"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"31f2fa3b_dd681980","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":48},"in_reply_to":"2ec6457c_148e4876","updated":"2025-10-17 14:17:31.000000000","message":"I have tested the following for both Rest and Zapi\n1. netapp_delete_retention_hours\u003d0\n2. netapp_delete_retention_hours\u003d5\n3. Created a share without setting netapp_delete_retention_hours in config and the share got create with default value (12 hours).","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"c96f84fb87024375ea4d794334fb490101d96de3","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        }"},{"line_number":263,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":264,"context_line":"            modify_args.update("},{"line_number":265,"context_line":"                {\u0027volume-delete-retention-hours\u0027: str(delete_retention_hours)})"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self.send_request(\u0027vserver-modify\u0027, modify_args)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dd174f5e_24d74cef","line":265,"range":{"start_line":265,"start_character":0,"end_line":265,"end_character":79},"updated":"2025-10-17 14:31:25.000000000","message":"Note: The delete_retention_hours is typecasted to string because the translate_struct in client/api.py is not adding the value to zapi request body (when delete_retention_hours is set to 0).\n\n                else:\n                    if data_struct[k]:\n                        child.set_content(str(data_struct[k]))\n                self.add_child_elem(child)","commit_id":"31383eabd77556460305e92744d8d3127bb55491"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"8c3922da7a4ee41cfbb2d8781c88e979360c3f10","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        }"},{"line_number":263,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":264,"context_line":"            modify_args.update("},{"line_number":265,"context_line":"                {\u0027volume-delete-retention-hours\u0027: str(delete_retention_hours)})"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self.send_request(\u0027vserver-modify\u0027, modify_args)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a5104d19_78f30177","line":265,"range":{"start_line":265,"start_character":0,"end_line":265,"end_character":79},"in_reply_to":"4e78b77c_0562a71a","updated":"2025-10-21 12:25:28.000000000","message":"Done","commit_id":"31383eabd77556460305e92744d8d3127bb55491"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"bb79eae087b0b11fca0e5ed5ca6190b01f957d87","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        }"},{"line_number":263,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":264,"context_line":"            modify_args.update("},{"line_number":265,"context_line":"                {\u0027volume-delete-retention-hours\u0027: str(delete_retention_hours)})"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self.send_request(\u0027vserver-modify\u0027, modify_args)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4e78b77c_0562a71a","line":265,"range":{"start_line":265,"start_character":0,"end_line":265,"end_character":79},"in_reply_to":"51b77d57_132d2855","updated":"2025-10-21 12:25:15.000000000","message":"Agreed with you Jayaanand.\nBut we did not want to make changes to api.py as the code was there for quite sometime and the file was not modified in recent times.\nWe thought we will typecast the delete_retention_hours in client_cmode.py as it will anyways get typecasted in api.py above.","commit_id":"31383eabd77556460305e92744d8d3127bb55491"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a562c4a1faa3d3b9507ba2d5977b25ba6777a22b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        }"},{"line_number":263,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":264,"context_line":"            modify_args.update("},{"line_number":265,"context_line":"                {\u0027volume-delete-retention-hours\u0027: str(delete_retention_hours)})"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        self.send_request(\u0027vserver-modify\u0027, modify_args)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"51b77d57_132d2855","line":265,"range":{"start_line":265,"start_character":0,"end_line":265,"end_character":79},"in_reply_to":"dd174f5e_24d74cef","updated":"2025-10-17 19:09:50.000000000","message":"what is the impact of changing this code like this... instead of changing every ware... else: if data_struct[k] is not None:\n                    child.set_content(str(data_struct[k]))\n        self.add_child_elem(child)","commit_id":"31383eabd77556460305e92744d8d3127bb55491"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0473dd6d8b8eccf9ae09e7db85f7ee52561f5f45","unresolved":true,"context_lines":[{"line_number":4489,"context_line":""},{"line_number":4490,"context_line":"        self.send_request(\u0027/svm/svms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4491,"context_line":""},{"line_number":4492,"context_line":"        try:"},{"line_number":4493,"context_line":"            svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":4494,"context_line":"            body \u003d {"},{"line_number":4495,"context_line":"                \u0027retention_period\u0027: delete_retention_hours"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0383692_4e07dd75","line":4492,"range":{"start_line":4492,"start_character":8,"end_line":4492,"end_character":12},"updated":"2025-10-14 05:15:34.000000000","message":"you\u0027ve to test if \"delete_retention_hours\" is not None; and that it has a value equal to or greater than 0","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"fd93f05dbb46c0b2a957a29a36bdaaf0602b39d9","unresolved":false,"context_lines":[{"line_number":4489,"context_line":""},{"line_number":4490,"context_line":"        self.send_request(\u0027/svm/svms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4491,"context_line":""},{"line_number":4492,"context_line":"        try:"},{"line_number":4493,"context_line":"            svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":4494,"context_line":"            body \u003d {"},{"line_number":4495,"context_line":"                \u0027retention_period\u0027: delete_retention_hours"}],"source_content_type":"text/x-python","patch_set":1,"id":"591caf6f_c93a7c32","line":4492,"range":{"start_line":4492,"start_character":8,"end_line":4492,"end_character":12},"in_reply_to":"c0383692_4e07dd75","updated":"2025-10-17 14:17:31.000000000","message":"I have tested the following for both Rest and Zapi\n1. netapp_delete_retention_hours\u003d0\n2. netapp_delete_retention_hours\u003d5\n3. Created a share without setting netapp_delete_retention_hours in config and the share got create with default value (12 hours).","commit_id":"565c744604e47ee61bcbcd747af787b952a20b45"}],"releasenotes/notes/bug-2128702-allow-zero-netapp-volume-retantion-period-24a524c2b91d866e.yaml":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"4aab66fafbbdb6a9922c9b27999b4a127278e797","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp Driver `bug #2128702"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/2128702\u003e`_:"},{"line_number":6,"context_line":"    Allow configuring netapp volume retention period to zero."},{"line_number":7,"context_line":"    The current login does not configure it to zero even if"},{"line_number":8,"context_line":"    netapp_delete_retention_hours is set to 0 in manila configuration."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b7b9458c_d7242696","line":7,"updated":"2025-10-23 05:19:56.000000000","message":"current login? Is it a typo?","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"d6a2de9388d82069933ed821466e3f3ffcf14235","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    NetApp Driver `bug #2128702"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/2128702\u003e`_:"},{"line_number":6,"context_line":"    Allow configuring netapp volume retention period to zero."},{"line_number":7,"context_line":"    The current login does not configure it to zero even if"},{"line_number":8,"context_line":"    netapp_delete_retention_hours is set to 0 in manila configuration."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c382767c_0661f256","line":7,"in_reply_to":"b7b9458c_d7242696","updated":"2025-10-23 06:33:25.000000000","message":"it was a typo. Addressed the comment.","commit_id":"62afd11483c7672a8a9203ba10219f7483de84ae"}]}