)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"57aaed577a73fcc46f69becfcb4b84ec15af89c2","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP add microversioned schema for Share Snapshot API responses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addresses the comments from Goutham."},{"line_number":10,"context_line":"It adds 4 different microversions."},{"line_number":11,"context_line":"Removed a previously added validation wrapper in patchset 1 that was leading to build errors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Next steps:"},{"line_number":14,"context_line":"    - add request body schemas for create and update operations"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I308d942ae460e881cf37f95f393c799c75d5bd62"},{"line_number":17,"context_line":"Signed-off-by: Marco Wehrhahn \u003cmarco.wehrhahn@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"de260a55_8193039d","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":63},"updated":"2025-11-12 13:50:37.000000000","message":"Hey, Marco! Thanks for noting the steps here. I\u0027d recommend to keep the commit message referring to what this change as a whole does though, so that we can ensure that we\u0027re capturing what this commit is doing.","commit_id":"3699517da285acc444dc575e0e10892e72135f53"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"a30150e2ebbb39443f36fc8012a8d80c9165eab9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP add microversioned schema for Share Snapshot API responses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addresses the comments from Goutham."},{"line_number":10,"context_line":"It adds 4 different microversions."},{"line_number":11,"context_line":"Removed a previously added validation wrapper in patchset 1 that was leading to build errors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Next steps:"},{"line_number":14,"context_line":"    - add request body schemas for create and update operations"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I308d942ae460e881cf37f95f393c799c75d5bd62"},{"line_number":17,"context_line":"Signed-off-by: Marco Wehrhahn \u003cmarco.wehrhahn@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3c72fa7d_11dc382d","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":63},"in_reply_to":"de260a55_8193039d","updated":"2025-11-14 17:37:02.000000000","message":"Done","commit_id":"3699517da285acc444dc575e0e10892e72135f53"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd7e25513f4048d01b1b267e28f9e0d86497c5a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f982675_bb292c8d","updated":"2025-11-07 20:20:08.000000000","message":"Thanks for working on this Marco; i\u0027ve some comments inline","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"57aaed577a73fcc46f69becfcb4b84ec15af89c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cbee1c95_2a89e0c0","updated":"2025-11-12 13:50:37.000000000","message":"Great job on updating this change, Marco! Please take a look at the suggestions inline","commit_id":"3699517da285acc444dc575e0e10892e72135f53"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c6df168bcbf1becb2ef6bb2aabbc8dad93dbb658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f624bc15_292225d3","updated":"2025-11-14 17:32:24.000000000","message":"Minor tweaks to the commit message. LGTM","commit_id":"fabbcb776c2f4ae7796f346016819d78435d963c"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"8d3f5ac036a8623b7a1fa6c7978fdaf38009ed6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"05b6d05b_009a71ba","updated":"2025-11-21 20:41:56.000000000","message":"Fixed the deepcopy vs copy","commit_id":"e07ea29033a0e42acd31f8d482b7a0c06105a934"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd4431fd4dae70800cccfb341f35095513d58ee9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9332915f_3a9c6aaa","updated":"2025-11-21 21:18:37.000000000","message":"Perfect; just a minor change in the last patch, lets get this in.. thanks @marco.wehrhahn@gmail.com","commit_id":"e07ea29033a0e42acd31f8d482b7a0c06105a934"}],"manila/api/schemas/share_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd7e25513f4048d01b1b267e28f9e0d86497c5a6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Huawei Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"a994fd0b_f7097173","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2025-11-07 20:20:08.000000000","message":"you can drop these lines.. We just require the Apache v2 license in files containing code artifacts.","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"a30150e2ebbb39443f36fc8012a8d80c9165eab9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Huawei Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"5173c340_1615802a","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"a994fd0b_f7097173","updated":"2025-11-14 17:37:02.000000000","message":"Done","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd7e25513f4048d01b1b267e28f9e0d86497c5a6","unresolved":true,"context_lines":[{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"index_request_query \u003d {"},{"line_number":26,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":27,"context_line":"    \u0027properties\u0027: {"},{"line_number":28,"context_line":"        # Admin only"}],"source_content_type":"text/x-python","patch_set":3,"id":"675331c7_17f4cf7d","line":25,"updated":"2025-11-07 20:20:08.000000000","message":"As discussed elsewhere, i\u0027d break this up into three separate JSON objects:\n\nA base index_request_query object serving API versions \u003c\u003d 2.35\nA index_request_query object for API versions \u003e\u003d2.36 and \u003c\u003d2.78\nA index_request_query object for API versions \u003e\u003d2.79\n\nSee https://opendev.org/openstack/manila/src/commit/993ccebb7007ae1c47b6b2c82938879f3104be04/manila/api/schemas/messages.py#L31-L109 as an example","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"a30150e2ebbb39443f36fc8012a8d80c9165eab9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d cfg.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"index_request_query \u003d {"},{"line_number":26,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":27,"context_line":"    \u0027properties\u0027: {"},{"line_number":28,"context_line":"        # Admin only"}],"source_content_type":"text/x-python","patch_set":3,"id":"f47b30ce_2904e7cb","line":25,"in_reply_to":"675331c7_17f4cf7d","updated":"2025-11-14 17:37:02.000000000","message":"Done","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd7e25513f4048d01b1b267e28f9e0d86497c5a6","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            **parameter_types.boolean,"},{"line_number":48,"context_line":"            \u0027default\u0027: False,"},{"line_number":49,"context_line":"            \u0027description\u0027: \"Show count in share snapshot list API response\""},{"line_number":50,"context_line":"        }),"},{"line_number":51,"context_line":"    },"},{"line_number":52,"context_line":"    \u0027required\u0027: [],"},{"line_number":53,"context_line":"    \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3be41304_46efb2c7","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":11},"updated":"2025-11-07 20:20:08.000000000","message":"unfortunately, the API reference isn\u0027t complete when it comes to the possible query parameters in this API. Could you please help us out by looking directly into the code: https://opendev.org/openstack/manila/src/commit/993ccebb7007ae1c47b6b2c82938879f3104be04/manila/api/v1/share_snapshots.py#L94-L173\n\n\nAll the search/pagination query parameters that you see there in code are missing from the API ref, and have been present since API version 2.0.","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"a30150e2ebbb39443f36fc8012a8d80c9165eab9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            **parameter_types.boolean,"},{"line_number":48,"context_line":"            \u0027default\u0027: False,"},{"line_number":49,"context_line":"            \u0027description\u0027: \"Show count in share snapshot list API response\""},{"line_number":50,"context_line":"        }),"},{"line_number":51,"context_line":"    },"},{"line_number":52,"context_line":"    \u0027required\u0027: [],"},{"line_number":53,"context_line":"    \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"acc26287_35de138f","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":11},"in_reply_to":"3be41304_46efb2c7","updated":"2025-11-14 17:37:02.000000000","message":"Done","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"57aaed577a73fcc46f69becfcb4b84ec15af89c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ac9ade54_c81d54f7","updated":"2025-11-12 13:50:37.000000000","message":"please mark comments you addressed as done","commit_id":"3699517da285acc444dc575e0e10892e72135f53"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"a30150e2ebbb39443f36fc8012a8d80c9165eab9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3968c7e4_f8566486","in_reply_to":"ac9ade54_c81d54f7","updated":"2025-11-14 17:37:02.000000000","message":"Done","commit_id":"3699517da285acc444dc575e0e10892e72135f53"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"55e49501f5efe94870a471611460f0668055b654","unresolved":true,"context_lines":[{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# \u003e\u003d v2.36: like filters for name~/description~"},{"line_number":89,"context_line":"index_request_query_v236 \u003d copy.deepcopy(index_request_query)"},{"line_number":90,"context_line":"index_request_query_v236[\u0027properties\u0027].update({"},{"line_number":91,"context_line":"    \u0027name~\u0027: parameter_types.single_param({"},{"line_number":92,"context_line":"        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"26605b01_73ffbe04","line":89,"range":{"start_line":89,"start_character":32,"end_line":89,"end_character":40},"updated":"2025-11-21 19:41:44.000000000","message":"copy\n\ndeepcopy isn\u0027t necessary.","commit_id":"fabbcb776c2f4ae7796f346016819d78435d963c"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"8d3f5ac036a8623b7a1fa6c7978fdaf38009ed6b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# \u003e\u003d v2.36: like filters for name~/description~"},{"line_number":89,"context_line":"index_request_query_v236 \u003d copy.deepcopy(index_request_query)"},{"line_number":90,"context_line":"index_request_query_v236[\u0027properties\u0027].update({"},{"line_number":91,"context_line":"    \u0027name~\u0027: parameter_types.single_param({"},{"line_number":92,"context_line":"        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5811a54d_fde05777","line":89,"range":{"start_line":89,"start_character":32,"end_line":89,"end_character":40},"in_reply_to":"26605b01_73ffbe04","updated":"2025-11-21 20:41:56.000000000","message":"Done","commit_id":"fabbcb776c2f4ae7796f346016819d78435d963c"}],"manila/api/v2/share_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd7e25513f4048d01b1b267e28f9e0d86497c5a6","unresolved":true,"context_lines":[{"line_number":338,"context_line":"    @wsgi.Controller.api_version(\"2.0\")"},{"line_number":339,"context_line":"    @validation.request_query_schema(schema.index_request_query)"},{"line_number":340,"context_line":"    # Only validating with a single schema here"},{"line_number":341,"context_line":"    # because this index method serves the purposes of multiple api versions"},{"line_number":342,"context_line":"    def index(self, req):"},{"line_number":343,"context_line":"        \"\"\"Returns a summary list of shares.\"\"\""},{"line_number":344,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.36\"):"}],"source_content_type":"text/x-python","patch_set":3,"id":"98574c28_8e26cd5b","line":341,"updated":"2025-11-07 20:20:08.000000000","message":"Add the response validation as well","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"},{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"a30150e2ebbb39443f36fc8012a8d80c9165eab9","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @wsgi.Controller.api_version(\"2.0\")"},{"line_number":339,"context_line":"    @validation.request_query_schema(schema.index_request_query)"},{"line_number":340,"context_line":"    # Only validating with a single schema here"},{"line_number":341,"context_line":"    # because this index method serves the purposes of multiple api versions"},{"line_number":342,"context_line":"    def index(self, req):"},{"line_number":343,"context_line":"        \"\"\"Returns a summary list of shares.\"\"\""},{"line_number":344,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.36\"):"}],"source_content_type":"text/x-python","patch_set":3,"id":"19a1a68c_573dccde","line":341,"in_reply_to":"98574c28_8e26cd5b","updated":"2025-11-14 17:37:02.000000000","message":"Done","commit_id":"0d9577ac56bb9c93a3e4f924c4a7f634cdbd4828"}]}