)]}'
{"manila/share/api.py":[{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zachary.goggin@ecmwf.int","username":"za","status":"Manila share backup enthusiast at ECMWF :)"},"change_message_id":"5c9072e6d50aab6c51d20ac2da80c67418bbd02f","unresolved":true,"context_lines":[{"line_number":4257,"context_line":"                raise exception.InvalidBackup(reason\u003dmsg)"},{"line_number":4258,"context_line":""},{"line_number":4259,"context_line":"        else:"},{"line_number":4260,"context_line":"            if backup.status in [constants.STATUS_BACKUP_RESTORING,"},{"line_number":4261,"context_line":"                                 constants.STATUS_BACKUP_CREATING]:"},{"line_number":4262,"context_line":"                msg \u003d (_(\u0027backup % status cannot restoring or creating \u0027"},{"line_number":4263,"context_line":"                         \u0027 during forced deletion.\u0027) % backup[\u0027id]\u0027])"},{"line_number":4264,"context_line":"                raise exception.InvalidBackup(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"83db9a66_3d8b461e","line":4261,"range":{"start_line":4260,"start_character":11,"end_line":4261,"end_character":67},"updated":"2025-12-13 12:22:17.000000000","message":"My thinking at the moment, is that force will mainly be\nused to attempt deletion of share backups in various error states, e.g.\n\nSTATUS_ERROR_CREATING\nSTATUS_ERROR_DELETING\n\netc.\n\nI do not think it is a good idea to allow the deletion of a backup\nthat is currently being utilised by the backup driver or share driver\nthis seems like asking for trouble in the data and share services to me :)\n\nEven if through exception handling we can recover properly on the Manila side\nbackup drivers may not be able to do so cleanly given they interact with external\nsystems.\n\n\nIf we should allow this, let me know and I can change it.","commit_id":"c9476444f9b01dd592e01d39af0194e5409e9109"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zachary.goggin@ecmwf.int","username":"za","status":"Manila share backup enthusiast at ECMWF :)"},"change_message_id":"18c880d88c627eda4d2e8286a83fb7f7a617c7e1","unresolved":true,"context_lines":[{"line_number":4259,"context_line":"        else:"},{"line_number":4260,"context_line":"            if backup.status in [constants.STATUS_BACKUP_RESTORING,"},{"line_number":4261,"context_line":"                                 constants.STATUS_BACKUP_CREATING]:"},{"line_number":4262,"context_line":"                msg \u003d (_(\u0027backup % status cannot restoring or creating \u0027"},{"line_number":4263,"context_line":"                         \u0027 during forced deletion.\u0027) % backup[\u0027id]\u0027])"},{"line_number":4264,"context_line":"                raise exception.InvalidBackup(reason\u003dmsg)"},{"line_number":4265,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cea39ced_0c51a50a","line":4262,"range":{"start_line":4262,"start_character":42,"end_line":4262,"end_character":58},"updated":"2025-12-13 12:23:28.000000000","message":"typo","commit_id":"c9476444f9b01dd592e01d39af0194e5409e9109"}]}
