)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38469,"name":"Rose Kimondo","display_name":"Rose Kimondo","email":"rosewairimu1@gmail.com","username":"rosekimondo"},"change_message_id":"f6a68263e7a866986d02fa3bfec3f766211c6fd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a31c1e2f_4d494183","updated":"2025-11-11 17:05:12.000000000","message":"@gouthampravi@gmail.com @ces.eduardo98@gmail.com\nThis patch that was previously failing the tests has successfully passed.\nLooking forward to your review. Thank you.","commit_id":"d87d12519f9523369d6d4a15b580eb31a0563781"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cc072f895019208d6e38a68bc1b74f6efa1492ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"900a0f52_1a9baaa7","updated":"2025-11-13 20:19:07.000000000","message":"Hi @rosewairimu1@gmail.com: A comment inline for you to check","commit_id":"d87d12519f9523369d6d4a15b580eb31a0563781"},{"author":{"_account_id":38469,"name":"Rose Kimondo","display_name":"Rose Kimondo","email":"rosewairimu1@gmail.com","username":"rosekimondo"},"change_message_id":"6a87a9e4e29a03f08ea24b8768c23fd6714664e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"220591a4_1942b599","in_reply_to":"900a0f52_1a9baaa7","updated":"2025-11-14 07:17:53.000000000","message":"Noted @gouthampravi@gmail.com , @anoop.shukla@netapp.com\n\nChecking it out. Thanks","commit_id":"d87d12519f9523369d6d4a15b580eb31a0563781"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"981ed7bf7c1e558eb81d5ef03bd3dab37af02fe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ede6b2e6_730ec24f","updated":"2025-11-18 22:40:46.000000000","message":"@rosewairimu1@gmail.com: Can you please add a short bugfix release note: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#what-are-release-notes","commit_id":"7ce055aa0cf7b0c65a52891fe94ab6bea1c1582f"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"d9a516000a46768850848372f19c712bc1523027","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b08c7aa0_c5527428","updated":"2025-11-19 13:06:15.000000000","message":"LGTM","commit_id":"7ce055aa0cf7b0c65a52891fe94ab6bea1c1582f"},{"author":{"_account_id":38469,"name":"Rose Kimondo","display_name":"Rose Kimondo","email":"rosewairimu1@gmail.com","username":"rosekimondo"},"change_message_id":"05fd15f45f164b1d0867e25d11eb685b23fb3ee0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b01c43c2_a5255b8f","in_reply_to":"ede6b2e6_730ec24f","updated":"2025-11-19 16:39:25.000000000","message":"@gouthampravi@gmail.com\n\nI have added the bugfix release note as requested.","commit_id":"7ce055aa0cf7b0c65a52891fe94ab6bea1c1582f"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e6a75d31da4cc912f116992b3a0b8d12c3e334da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6920f7ea_fb7f50ce","updated":"2025-12-16 12:56:45.000000000","message":"LGTM","commit_id":"1a182180a6d71a67c692ac811be1ed6faf4bb935"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"d8c1e2451ca95090a66787b3a325b47afeb4247c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b4d16933_7926a245","updated":"2025-12-12 09:30:13.000000000","message":"LGTM","commit_id":"1a182180a6d71a67c692ac811be1ed6faf4bb935"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ea95f8a49b2a23c5f8c1be10dffadacc76b336c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2949644b_2ea798c3","updated":"2025-11-20 20:05:10.000000000","message":"LGTM, thanks @rosewairimu1@gmail.com. \n\n@anoop.shukla@netapp.com @saikumar1016@gmail.com Could you take (another) look? Also, do you think this cleanup should be done with unmanage too?","commit_id":"1a182180a6d71a67c692ac811be1ed6faf4bb935"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"41261c2ba295ec52099ce1fffd80668a36546e57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f3f0c386_68122815","updated":"2025-12-19 18:19:27.000000000","message":"LGTM, thanks Rose","commit_id":"1a182180a6d71a67c692ac811be1ed6faf4bb935"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"c3533921c6a6984d73d504e8acbbe855fda69158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0b32c734_102ed1fc","in_reply_to":"2949644b_2ea798c3","updated":"2025-12-12 09:37:04.000000000","message":"Unmanage is a no-op(pass through) in NetApp driver code.\nhttps://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L2136\n\nIMO it should be continued the way then handling it partially. \nIn any case, user has to use delete share action if they want to unmanage that is taken care in this fix.","commit_id":"1a182180a6d71a67c692ac811be1ed6faf4bb935"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cc072f895019208d6e38a68bc1b74f6efa1492ad","unresolved":true,"context_lines":[{"line_number":1846,"context_line":"                    share[\u0027id\u0027])"},{"line_number":1847,"context_line":"                vserver_client.mark_qos_policy_group_for_deletion("},{"line_number":1848,"context_line":"                    qos_policy_for_share)"},{"line_number":1849,"context_line":"            try:"},{"line_number":1850,"context_line":"                self.private_storage.delete(share[\u0027id\u0027])"},{"line_number":1851,"context_line":"            except Exception as e:"},{"line_number":1852,"context_line":"                LOG.warning("},{"line_number":1853,"context_line":"                    \"Failed to delete private storage for share %s: %s\","},{"line_number":1854,"context_line":"                    share[\u0027id\u0027], e)"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"        else:"},{"line_number":1857,"context_line":"            LOG.info(\"Share %s does not exist.\", share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"060dccf1_0de974fb","line":1854,"range":{"start_line":1849,"start_character":12,"end_line":1854,"end_character":35},"updated":"2025-11-13 20:19:07.000000000","message":"I\u0027d try this outside of the \"if\" block here..","commit_id":"d87d12519f9523369d6d4a15b580eb31a0563781"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"17c15bcf9aff722f16ebdf1cc97dfc2851cd3b01","unresolved":true,"context_lines":[{"line_number":1846,"context_line":"                    share[\u0027id\u0027])"},{"line_number":1847,"context_line":"                vserver_client.mark_qos_policy_group_for_deletion("},{"line_number":1848,"context_line":"                    qos_policy_for_share)"},{"line_number":1849,"context_line":"            try:"},{"line_number":1850,"context_line":"                self.private_storage.delete(share[\u0027id\u0027])"},{"line_number":1851,"context_line":"            except Exception as e:"},{"line_number":1852,"context_line":"                LOG.warning("},{"line_number":1853,"context_line":"                    \"Failed to delete private storage for share %s: %s\","},{"line_number":1854,"context_line":"                    share[\u0027id\u0027], e)"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"        else:"},{"line_number":1857,"context_line":"            LOG.info(\"Share %s does not exist.\", share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"cf68b99c_1c2c386c","line":1854,"range":{"start_line":1849,"start_character":12,"end_line":1854,"end_character":35},"in_reply_to":"060dccf1_0de974fb","updated":"2025-11-14 07:01:07.000000000","message":"+1","commit_id":"d87d12519f9523369d6d4a15b580eb31a0563781"},{"author":{"_account_id":38469,"name":"Rose Kimondo","display_name":"Rose Kimondo","email":"rosewairimu1@gmail.com","username":"rosekimondo"},"change_message_id":"a6ad4ac1975c70daf9f22247ea8996ca355f1ca6","unresolved":false,"context_lines":[{"line_number":1846,"context_line":"                    share[\u0027id\u0027])"},{"line_number":1847,"context_line":"                vserver_client.mark_qos_policy_group_for_deletion("},{"line_number":1848,"context_line":"                    qos_policy_for_share)"},{"line_number":1849,"context_line":"            try:"},{"line_number":1850,"context_line":"                self.private_storage.delete(share[\u0027id\u0027])"},{"line_number":1851,"context_line":"            except Exception as e:"},{"line_number":1852,"context_line":"                LOG.warning("},{"line_number":1853,"context_line":"                    \"Failed to delete private storage for share %s: %s\","},{"line_number":1854,"context_line":"                    share[\u0027id\u0027], e)"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"        else:"},{"line_number":1857,"context_line":"            LOG.info(\"Share %s does not exist.\", share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"441549f4_dc907db3","line":1854,"range":{"start_line":1849,"start_character":12,"end_line":1854,"end_character":35},"in_reply_to":"cf68b99c_1c2c386c","updated":"2025-11-18 15:02:18.000000000","message":"@gouthampravi@gmail.com @anoop.shukla@netapp.com\nI have implemented the change as requested","commit_id":"d87d12519f9523369d6d4a15b580eb31a0563781"}]}