)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"55f0dabddf91edd2c634814c1d8c2f9204e4ca59","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Medha Choudhary \u003cmedhaj06@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-04 09:54:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"updated autosize attributes for rest dhss true test case failure fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I8e16e1622e975dec2a42850f0e06159875d70f39"},{"line_number":10,"context_line":"Depends-On: I38e761c412f634b43a34af15b0f407b8d2b0bcf6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9dba4178_3bb0653f","line":7,"updated":"2025-11-05 07:39:39.000000000","message":"The commit message must be more descriptive. Also this is missing a bug fixed.\n\nWe need to have a release note added to the review.","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"567a151dfdeb7a93e4ef7d44aa6518358bbe0194","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Medha Choudhary \u003cmedhaj06@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-04 09:54:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"updated autosize attributes for rest dhss true test case failure fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: I8e16e1622e975dec2a42850f0e06159875d70f39"},{"line_number":10,"context_line":"Depends-On: I38e761c412f634b43a34af15b0f407b8d2b0bcf6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"10d97f29_375a6383","line":7,"in_reply_to":"9dba4178_3bb0653f","updated":"2025-11-07 08:26:43.000000000","message":"Done","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"950685a9c983ed9378d8230137618912c8712f4b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ac08e316_6b89c14b","updated":"2025-11-10 13:21:41.000000000","message":"Please take a look at the OpenStack\u0027s commit message guide: https://wiki.openstack.org/wiki/GitCommitMessages\n\nThis guide is a good reference for making the commit messages more consistent across all OpenStack services. There are a couple of things that stood out that need some fixes:\n- The first line should be limited to 50 characters and should not end with a period. \n- Subsequent lines should be wrapped at 72 characters.\n\nAlso, please do not refer to line numbers, as they will change in the future.","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53797ba88c5824eeb860ba57567feeda6dbffbe4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cf71a2a7_8e9866ce","in_reply_to":"aaf291b6_1b7cd08a","updated":"2025-11-11 09:38:41.000000000","message":"Hey, Medha, Thanks for working on the other comments. Please fix the commit message as well as requested.","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fdc11c2abdb7a93a35a3c235fbe431168691ca95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aaf291b6_1b7cd08a","in_reply_to":"ac08e316_6b89c14b","updated":"2025-11-11 03:53:08.000000000","message":"Acknowledged","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"56ccdc22588f4ccecba003567fd9e63d4fdb5dea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"10f9d0ff_c818d1d7","in_reply_to":"cf71a2a7_8e9866ce","updated":"2025-11-11 11:28:21.000000000","message":"updated the commit message","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"f37497ffe0739e031f382883b8b44e627f217a4b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Issue: Test test_snapshot_before_share_replica failed with KeyError: \u0027mode\u0027 during replica promotion operation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Root Cause: In client_cmode_rest.py at line 2594, the modify_volume() method unconditionally accessed dictionary keys (\u0027mode\u0027, \u0027grow-threshold-percent\u0027, etc.)"},{"line_number":10,"context_line":" from the autosize_attributes parameter without checking if they exist. During replica promotion, when _update_autosize_attributes_after_promote_replica() called modify_volume()."},{"line_number":11,"context_line":"The passed autosize_attributes dictionary was missing the \u0027mode\u0027 key, causing a KeyError."},{"line_number":12,"context_line":"Fix: Modified the code to safely check for the existence of each key before accessing it using conditional checks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f395dfda_865ad715","line":9,"updated":"2025-11-10 05:41:58.000000000","message":"nit: line number are not required. numbers will change over time.","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fdc11c2abdb7a93a35a3c235fbe431168691ca95","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Issue: Test test_snapshot_before_share_replica failed with KeyError: \u0027mode\u0027 during replica promotion operation."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Root Cause: In client_cmode_rest.py at line 2594, the modify_volume() method unconditionally accessed dictionary keys (\u0027mode\u0027, \u0027grow-threshold-percent\u0027, etc.)"},{"line_number":10,"context_line":" from the autosize_attributes parameter without checking if they exist. During replica promotion, when _update_autosize_attributes_after_promote_replica() called modify_volume()."},{"line_number":11,"context_line":"The passed autosize_attributes dictionary was missing the \u0027mode\u0027 key, causing a KeyError."},{"line_number":12,"context_line":"Fix: Modified the code to safely check for the existence of each key before accessing it using conditional checks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"8a76f10c_bd6c9342","line":9,"in_reply_to":"f395dfda_865ad715","updated":"2025-11-11 03:53:08.000000000","message":"Acknowledged","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c6a74945dd11dd47e6df3f85a11d3540da826ca","unresolved":false,"context_lines":[{"line_number":19,"context_line":"autosize attribute before accessing it. The function now gracefully handles"},{"line_number":20,"context_line":"partial autosize attribute dictionaries, including only present attributes"},{"line_number":21,"context_line":"in the request body."},{"line_number":22,"context_line":"Closes-bug: #2130717"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I8ee3f84abc295c40d35c201c0360578e56239ddf"},{"line_number":25,"context_line":"Signed-off-by: medhac1403 \u003cmedhaj06@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"e29467f6_fbbf0165","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":20},"updated":"2025-11-13 17:26:02.000000000","message":"Unfortunately, our bug linking automation looks for \"Closes-Bug\" only in the last paragraph of the commit message; please note that for next time. For now, i\u0027ve manually linked the bug and this patch.","commit_id":"4dc5390ed04caddea8e34730ab12b1452531f645"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"3a8f54e03e0537bf53a97e0185b746e7acee6673","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05cc59e6_254f56d3","updated":"2025-10-30 09:34:24.000000000","message":"Run-NetApp CI","commit_id":"d71bb97d2760b92a682cf903a69cf2eff5b59826"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"d93916e3c196cd0b9eed249b630ffbdc4f5e47a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"326fabb7_72a539a7","updated":"2025-10-29 09:46:28.000000000","message":"Run-NetApp CI","commit_id":"d71bb97d2760b92a682cf903a69cf2eff5b59826"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"9c0758cbd3df5610a2da9d1f5c8c1af51063c0a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9516dd7_15f4cf5d","updated":"2025-11-03 05:36:46.000000000","message":"Run-NetApp CI","commit_id":"d71bb97d2760b92a682cf903a69cf2eff5b59826"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"4e99a06d226b6ec80ca45200be3da69f8f22f195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"85295a2d_5a45431a","updated":"2025-11-03 12:25:25.000000000","message":"Run-NetApp CI","commit_id":"74d8b3fb1d26c27a184d4018a8660fb4fb0bdb33"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a472e8c68b36696b7f1eed726471e37d89ec9c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"36ebe5ba_77782fa6","updated":"2025-11-03 14:28:20.000000000","message":"please find my comments inline...","commit_id":"74d8b3fb1d26c27a184d4018a8660fb4fb0bdb33"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"8e85cd5894a36099d85800ff89268583cac68e14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a49539b0_5af4f6bb","updated":"2025-11-05 04:54:02.000000000","message":"LGTM","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"55f0dabddf91edd2c634814c1d8c2f9204e4ca59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"19ee8839_120f8d55","updated":"2025-11-05 07:39:39.000000000","message":"Please take a look at the comments.","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fe4c2ff32e2cade7c8296b75c85f6aedf37db490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6cd81f2a_69f42810","updated":"2025-11-04 09:58:30.000000000","message":"Run-NetApp CI","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"7f73bc801c06308b77a10f275f5645cf6d48df08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ef7cd8c3_f3e09556","updated":"2025-11-04 14:59:38.000000000","message":"Run-NetApp CI","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"1492c08acf45d22d1d3991a0d26ec567ff1ffb14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"da4956ba_e47a11b5","updated":"2025-11-10 13:01:05.000000000","message":"LGTM","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"950685a9c983ed9378d8230137618912c8712f4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"12453fd5_8f4cad55","updated":"2025-11-10 13:21:41.000000000","message":"Thanks for working on this change. Please take a look at the comments inline","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0913f841c49b7965a28da7ac005c2eccd3e4fbd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c3fd19fa_c0b8ed08","updated":"2025-11-11 09:39:11.000000000","message":"Hey, Medha. Thanks for working on the comments. Please fix the commit message as requested :)","commit_id":"3211cba36fb52fc2ced7a9ef2ec2a553eabb9ac8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c6a74945dd11dd47e6df3f85a11d3540da826ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7e95653d_26e5de0a","updated":"2025-11-13 17:26:02.000000000","message":"LGTM, thank you","commit_id":"4dc5390ed04caddea8e34730ab12b1452531f645"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d9a60d7fc43a28ff254d44538d638c2f284e359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f729dc23_ebf7feed","updated":"2025-11-11 12:56:45.000000000","message":"LGTM, thanks Medha","commit_id":"4dc5390ed04caddea8e34730ab12b1452531f645"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"c4500d43be2a8b45f1c11325417776eb0b061143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"54c3ffb9_950f4b6f","updated":"2025-11-12 12:49:48.000000000","message":"Run-NetApp CI","commit_id":"4dc5390ed04caddea8e34730ab12b1452531f645"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"7ee67ce454cca5a8837126ea5653b10412f55175","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"992ff7cf_84401134","updated":"2025-11-13 10:04:52.000000000","message":"Run-NetApp CI","commit_id":"4dc5390ed04caddea8e34730ab12b1452531f645"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"0536248c50932321c1beae45c76067d44c008c2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ab1176ca_5fb298f1","updated":"2025-11-13 05:36:30.000000000","message":"Run-NetApp CI","commit_id":"4dc5390ed04caddea8e34730ab12b1452531f645"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"14ac44445af6fe6a0f91f074636d04b8b256d26e","unresolved":true,"context_lines":[{"line_number":2587,"context_line":"        body \u003d {"},{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            attributes \u003d autosize_attributes"},{"line_number":2593,"context_line":"            body[\u0027autosize\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1593434e_50ba74c3","line":2590,"updated":"2025-11-03 10:42:47.000000000","message":"@saikumar1016@gmail.com AS this is functional bug, don\u0027t we need to create a launchpad bug and tag this?\n\n@medhaj06@gmail.com This can be backported to previous release.","commit_id":"c4bc25958e361518039b251c254efd9d88d3222a"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"eb9cc910c800591f748716a9d97ac32d80592532","unresolved":false,"context_lines":[{"line_number":2587,"context_line":"        body \u003d {"},{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            attributes \u003d autosize_attributes"},{"line_number":2593,"context_line":"            body[\u0027autosize\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"39d984c8_a6a11f88","line":2590,"in_reply_to":"1593434e_50ba74c3","updated":"2025-11-06 10:09:33.000000000","message":"Acknowledged","commit_id":"c4bc25958e361518039b251c254efd9d88d3222a"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"eeee134e15d33eb52bfbeb8581030436c71a5cbe","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            attributes \u003d autosize_attributes"},{"line_number":2593,"context_line":"            body[\u0027autosize\u0027] \u003d {}"},{"line_number":2594,"context_line":"            if \u0027mode\u0027 in attributes:"}],"source_content_type":"text/x-python","patch_set":4,"id":"2bd49dbf_5792fd66","line":2591,"updated":"2025-11-03 10:31:01.000000000","message":"@medhaj06@gmail.com \nI had fixed this issue locally today as part of my analysis.\n\nI would suggest you to modify this code as below to make it more readable and explicit check:\n       \n```suggestion\n                if autosize_attributes and not str(autosize_attributes.get(\u0027reset\u0027, \u0027\u0027)).lower() \u003d\u003d \u0027true\u0027:\n            attributes \u003d autosize_attributes\n            body[\u0027autosize\u0027] \u003d {\n                k: attributes[k]\n                for k in [\n                    \u0027mode\u0027,\n                    \u0027grow-threshold-percent\u0027,\n                    \u0027shrink-threshold-percent\u0027,\n                    \u0027maximum-size\u0027,\n                    \u0027minimum-size\u0027\n                ]\n                if k in attributes\n            }\n```","commit_id":"c4bc25958e361518039b251c254efd9d88d3222a"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"8bfba850501ef2cd9ad48a97fbbfef9a2911f271","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            attributes \u003d autosize_attributes"},{"line_number":2593,"context_line":"            body[\u0027autosize\u0027] \u003d {}"},{"line_number":2594,"context_line":"            if \u0027mode\u0027 in attributes:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fbdc1572_be99d652","line":2591,"in_reply_to":"2bd49dbf_5792fd66","updated":"2025-11-03 11:40:59.000000000","message":"@medhaj06@gmail.com I see that API keys and the param names are different for few of them.\n\nCan you try to refactor with below once?\n\n```suggestion\n if autosize_attributes:\n    reset_val \u003d autosize_attributes.get(\u0027reset\u0027, \u0027\u0027)\n    if not (reset_val is True or str(reset_val).lower() \u003d\u003d \u0027true\u0027):\n        src \u003d autosize_attributes\n        autosize \u003d {}\n        if \u0027mode\u0027 in src:\n            autosize[\u0027mode\u0027] \u003d src[\u0027mode\u0027]\n        for src_key, dest_key in (\n            (\u0027grow-threshold-percent\u0027, \u0027grow_threshold\u0027),\n            (\u0027shrink-threshold-percent\u0027, \u0027shrink_threshold\u0027),\n            (\u0027maximum-size\u0027, \u0027maximum\u0027),\n            (\u0027minimum-size\u0027, \u0027minimum\u0027),\n        ):\n            if src_key in src:\n                autosize[dest_key] \u003d src[src_key]\n        if autosize:\n            body[\u0027autosize\u0027] \u003d autosize\n```","commit_id":"c4bc25958e361518039b251c254efd9d88d3222a"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"4e99a06d226b6ec80ca45200be3da69f8f22f195","unresolved":false,"context_lines":[{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            attributes \u003d autosize_attributes"},{"line_number":2593,"context_line":"            body[\u0027autosize\u0027] \u003d {}"},{"line_number":2594,"context_line":"            if \u0027mode\u0027 in attributes:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ee3e5588_8e13da61","line":2591,"in_reply_to":"fbdc1572_be99d652","updated":"2025-11-03 12:25:25.000000000","message":"Done","commit_id":"c4bc25958e361518039b251c254efd9d88d3222a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a472e8c68b36696b7f1eed726471e37d89ec9c57","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            reset_val \u003d autosize_attributes.get(\u0027reset\u0027, \u0027\u0027)"},{"line_number":2593,"context_line":"            if not (reset_val is True or str(reset_val).lower() \u003d\u003d \u0027true\u0027):"},{"line_number":2594,"context_line":"                src \u003d autosize_attributes"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3e7bf08_b8947c34","line":2591,"updated":"2025-11-03 14:28:20.000000000","message":"The check if not (reset_val is True or str(reset_val).lower() \u003d\u003d \u0027true\u0027): is unnecessarily complex. Consider simplifying to if not str(reset_val).lower() \u003d\u003d \u0027true\u0027: since True will also be converted to \u0027true\u0027.","commit_id":"74d8b3fb1d26c27a184d4018a8660fb4fb0bdb33"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fe4c2ff32e2cade7c8296b75c85f6aedf37db490","unresolved":false,"context_lines":[{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            reset_val \u003d autosize_attributes.get(\u0027reset\u0027, \u0027\u0027)"},{"line_number":2593,"context_line":"            if not (reset_val is True or str(reset_val).lower() \u003d\u003d \u0027true\u0027):"},{"line_number":2594,"context_line":"                src \u003d autosize_attributes"}],"source_content_type":"text/x-python","patch_set":5,"id":"71f58bb6_3018db49","line":2591,"in_reply_to":"b3e7bf08_b8947c34","updated":"2025-11-04 09:58:30.000000000","message":"Done","commit_id":"74d8b3fb1d26c27a184d4018a8660fb4fb0bdb33"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a472e8c68b36696b7f1eed726471e37d89ec9c57","unresolved":true,"context_lines":[{"line_number":2595,"context_line":"                autosize \u003d {}"},{"line_number":2596,"context_line":"                if \u0027mode\u0027 in src:"},{"line_number":2597,"context_line":"                    autosize[\u0027mode\u0027] \u003d src[\u0027mode\u0027]"},{"line_number":2598,"context_line":"                for src_key, dest_key in ("},{"line_number":2599,"context_line":"                        (\u0027grow-threshold-percent\u0027, \u0027grow_threshold\u0027),"},{"line_number":2600,"context_line":"                        (\u0027shrink-threshold-percent\u0027, \u0027shrink_threshold\u0027),"},{"line_number":2601,"context_line":"                        (\u0027maximum-size\u0027, \u0027maximum\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"cb4376fb_a555c27f","line":2598,"updated":"2025-11-03 14:28:20.000000000","message":"This block is same as defining dictionary... why for loop is required?Ex:\n+                 autosize_key_map \u003d {\n+                     \u0027grow-threshold-percent\u0027: \u0027grow_threshold\u0027,\n+                     \u0027shrink-threshold-percent\u0027: \u0027shrink_threshold\u0027,\n+                     \u0027maximum-size\u0027: \u0027maximum\u0027,\n+                     \u0027minimum-size\u0027: \u0027minimum\u0027,\n+                 }\n+                 for src_key, dest_key in autosize_key_map.items():\n+                     if src_key in src:\n+                         autosize[dest_key] \u003d src[src_key]\n+                 if autosize:\n+                     body[\u0027autosize\u0027] \u003d autosize","commit_id":"74d8b3fb1d26c27a184d4018a8660fb4fb0bdb33"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fe4c2ff32e2cade7c8296b75c85f6aedf37db490","unresolved":false,"context_lines":[{"line_number":2595,"context_line":"                autosize \u003d {}"},{"line_number":2596,"context_line":"                if \u0027mode\u0027 in src:"},{"line_number":2597,"context_line":"                    autosize[\u0027mode\u0027] \u003d src[\u0027mode\u0027]"},{"line_number":2598,"context_line":"                for src_key, dest_key in ("},{"line_number":2599,"context_line":"                        (\u0027grow-threshold-percent\u0027, \u0027grow_threshold\u0027),"},{"line_number":2600,"context_line":"                        (\u0027shrink-threshold-percent\u0027, \u0027shrink_threshold\u0027),"},{"line_number":2601,"context_line":"                        (\u0027maximum-size\u0027, \u0027maximum\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1c852651_933f30a5","line":2598,"in_reply_to":"cb4376fb_a555c27f","updated":"2025-11-04 09:58:30.000000000","message":"Done","commit_id":"74d8b3fb1d26c27a184d4018a8660fb4fb0bdb33"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"55f0dabddf91edd2c634814c1d8c2f9204e4ca59","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            reset_val \u003d autosize_attributes.get(\u0027reset\u0027, \u0027\u0027)"},{"line_number":2593,"context_line":"            if not str(reset_val).lower() \u003d\u003d \u0027true\u0027:"},{"line_number":2594,"context_line":"                src \u003d autosize_attributes"}],"source_content_type":"text/x-python","patch_set":7,"id":"a148c29e_711ed11e","line":2591,"updated":"2025-11-05 07:39:39.000000000","message":"We need to add UTs to test the below changes.","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"567a151dfdeb7a93e4ef7d44aa6518358bbe0194","unresolved":false,"context_lines":[{"line_number":2588,"context_line":"            \u0027guarantee\u0027: {\u0027type\u0027: \u0027none\u0027 if thin_provisioned else \u0027volume\u0027}"},{"line_number":2589,"context_line":"        }"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"        if autosize_attributes:"},{"line_number":2592,"context_line":"            reset_val \u003d autosize_attributes.get(\u0027reset\u0027, \u0027\u0027)"},{"line_number":2593,"context_line":"            if not str(reset_val).lower() \u003d\u003d \u0027true\u0027:"},{"line_number":2594,"context_line":"                src \u003d autosize_attributes"}],"source_content_type":"text/x-python","patch_set":7,"id":"4a2964fb_9f16180c","line":2591,"in_reply_to":"a148c29e_711ed11e","updated":"2025-11-07 08:26:43.000000000","message":"Done","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"55f0dabddf91edd2c634814c1d8c2f9204e4ca59","unresolved":true,"context_lines":[{"line_number":2593,"context_line":"            if not str(reset_val).lower() \u003d\u003d \u0027true\u0027:"},{"line_number":2594,"context_line":"                src \u003d autosize_attributes"},{"line_number":2595,"context_line":""},{"line_number":2596,"context_line":"                # Build autosize dict directly"},{"line_number":2597,"context_line":"                autosize_key_map \u003d {"},{"line_number":2598,"context_line":"                    \u0027grow-threshold-percent\u0027: \u0027grow_threshold\u0027,"},{"line_number":2599,"context_line":"                    \u0027shrink-threshold-percent\u0027: \u0027shrink_threshold\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"8227a2e1_8ff2372d","line":2596,"updated":"2025-11-05 07:39:39.000000000","message":"Move to another method may be? From line 2596-2612 we can create another method to map the values from the autosize_attributes to autosize object.","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"567a151dfdeb7a93e4ef7d44aa6518358bbe0194","unresolved":false,"context_lines":[{"line_number":2593,"context_line":"            if not str(reset_val).lower() \u003d\u003d \u0027true\u0027:"},{"line_number":2594,"context_line":"                src \u003d autosize_attributes"},{"line_number":2595,"context_line":""},{"line_number":2596,"context_line":"                # Build autosize dict directly"},{"line_number":2597,"context_line":"                autosize_key_map \u003d {"},{"line_number":2598,"context_line":"                    \u0027grow-threshold-percent\u0027: \u0027grow_threshold\u0027,"},{"line_number":2599,"context_line":"                    \u0027shrink-threshold-percent\u0027: \u0027shrink_threshold\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"52375e1f_a12ba587","line":2596,"in_reply_to":"8227a2e1_8ff2372d","updated":"2025-11-07 08:26:43.000000000","message":"Done","commit_id":"bca0baacb3ff552b9d94ce6ef51743b3f2f6ec2e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c6a74945dd11dd47e6df3f85a11d3540da826ca","unresolved":true,"context_lines":[{"line_number":2657,"context_line":"            if src_key in src"},{"line_number":2658,"context_line":"        }"},{"line_number":2659,"context_line":""},{"line_number":2660,"context_line":"        # Add mode if present"},{"line_number":2661,"context_line":"        if \u0027mode\u0027 in src:"},{"line_number":2662,"context_line":"            autosize[\u0027mode\u0027] \u003d src[\u0027mode\u0027]"},{"line_number":2663,"context_line":""},{"line_number":2664,"context_line":"        return autosize if autosize else None"},{"line_number":2665,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"8c1107f8_355a958b","line":2662,"range":{"start_line":2660,"start_character":0,"end_line":2662,"end_character":42},"updated":"2025-11-13 17:26:02.000000000","message":"you could instead add `\u0027mode\u0027: \u0027mode\u0027` in the `autosize_key_map` above","commit_id":"4dc5390ed04caddea8e34730ab12b1452531f645"}],"releasenotes/notes/bug-2130717-auto-attribute-mode-key-error-for-rest-e7958807a5e2e0e5.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"950685a9c983ed9378d8230137618912c8712f4b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fb5328ef_a0f66639","updated":"2025-11-10 13:21:41.000000000","message":"please wrap all lines within 79 characters","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fdc11c2abdb7a93a35a3c235fbe431168691ca95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b60b1d81_042b2b23","in_reply_to":"fb5328ef_a0f66639","updated":"2025-11-11 03:53:08.000000000","message":"Acknowledged","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"950685a9c983ed9378d8230137618912c8712f4b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Modified the code to safely check for the existence of each key before accessing it using conditional checks (if \u0027mode\u0027 in attributes)."},{"line_number":6,"context_line":"    This allows the function to handle partial autosize attribute dictionaries gracefully, only including attributes that are actually present in the request body."},{"line_number":7,"context_line":"    Also handled the reset true case in Rest to skip the setting od any autosize attributes."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b67b815c_76787cb9","line":4,"updated":"2025-11-10 13:21:41.000000000","message":"This release note needs some enhancements. As they are targeting end users, we should not use implementation details or talk about changes we did in the code. A reference for writing release notes would be [1]. Instead, we should focus on the outcome for the user. A more appropriate approach suggested inline\n\n[1] https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fdc11c2abdb7a93a35a3c235fbe431168691ca95","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Modified the code to safely check for the existence of each key before accessing it using conditional checks (if \u0027mode\u0027 in attributes)."},{"line_number":6,"context_line":"    This allows the function to handle partial autosize attribute dictionaries gracefully, only including attributes that are actually present in the request body."},{"line_number":7,"context_line":"    Also handled the reset true case in Rest to skip the setting od any autosize attributes."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f1597d02_556c0f76","line":4,"in_reply_to":"b67b815c_76787cb9","updated":"2025-11-11 03:53:08.000000000","message":"Done","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"950685a9c983ed9378d8230137618912c8712f4b","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Modified the code to safely check for the existence of each key before accessing it using conditional checks (if \u0027mode\u0027 in attributes)."},{"line_number":6,"context_line":"    This allows the function to handle partial autosize attribute dictionaries gracefully, only including attributes that are actually present in the request body."},{"line_number":7,"context_line":"    Also handled the reset true case in Rest to skip the setting od any autosize attributes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b5bad6e8_ef4c3b83","line":8,"range":{"start_line":5,"start_character":4,"end_line":8,"end_character":1},"updated":"2025-11-10 13:21:41.000000000","message":"```suggestion\n    Fixed an issue that caused the share replica promotion to fail due to\n    missing replica attributes in the NetApp driver while using the REST API.\n    For more details, please refer to\n    `launchpad bug #2130717 \u003chttps://bugs.launchpad.net/manila/+bug/2130717\u003e`_.\n\n```","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"fdc11c2abdb7a93a35a3c235fbe431168691ca95","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Modified the code to safely check for the existence of each key before accessing it using conditional checks (if \u0027mode\u0027 in attributes)."},{"line_number":6,"context_line":"    This allows the function to handle partial autosize attribute dictionaries gracefully, only including attributes that are actually present in the request body."},{"line_number":7,"context_line":"    Also handled the reset true case in Rest to skip the setting od any autosize attributes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6eb05032_90b98a51","line":8,"range":{"start_line":5,"start_character":4,"end_line":8,"end_character":1},"in_reply_to":"b5bad6e8_ef4c3b83","updated":"2025-11-11 03:53:08.000000000","message":"Done","commit_id":"eb2927fd5c183161ce9e5490447e658c5e5f7b57"}]}