)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"57b6dc2f295730f0d367796bed60489746887f1a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     cea701db (Merge \"[Doc] Update quota APIs to use share_type as query parameter\")"},{"line_number":2,"context_line":"Author:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2025-11-03 10:00:41 +0000"},{"line_number":4,"context_line":"Commit:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7eb7e3cc_4d1b8751","line":1,"updated":"2026-03-31 21:15:49.000000000","message":"The subject line is 67 characters, exceeding the 50-character\nOpenStack convention. Suggest: \"Add unit tests for CephFS driver\nuncovered lines\"","commit_id":"a56eaff1e9785ce7778c519beda11cc701abcdab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"17d758f5d41c6a511be8bda913cc1c3a5134aa8e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit tests for CephFS driver uncovered lines"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1989472"},{"line_number":10,"context_line":"Change-Id: If5e25ebefa9657e941d0965f0a958abd030e727a"},{"line_number":11,"context_line":"Signed-off-by: olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"31e92090_0fbea975","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":6},"updated":"2026-04-06 21:35:14.000000000","message":"Partial","commit_id":"3bc9746f9ad3da01334d60cee40cc1abedd6e47f"}],"manila/tests/share/drivers/cephfs/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"57b6dc2f295730f0d367796bed60489746887f1a","unresolved":true,"context_lines":[{"line_number":25,"context_line":"import manila.exception as exception"},{"line_number":26,"context_line":"from manila.share import configuration"},{"line_number":27,"context_line":"from manila.share.drivers.cephfs import driver"},{"line_number":28,"context_line":"from manila.share.drivers.cephfs.driver import AllocationCapacityCache"},{"line_number":29,"context_line":"from manila.share import share_types"},{"line_number":30,"context_line":"from manila import test"},{"line_number":31,"context_line":"from manila.tests import fake_share"}],"source_content_type":"text/x-python","patch_set":4,"id":"f59f2f5a_052892bf","line":28,"updated":"2026-03-31 21:15:49.000000000","message":"The import \"from manila.share.drivers.cephfs.driver import\nAllocationCapacityCache\" imports a class directly, violating the\nOpenStack convention of importing modules, not objects. The driver\nmodule is already imported on the previous line, so use\ndriver.AllocationCapacityCache instead and remove this import.","commit_id":"a56eaff1e9785ce7778c519beda11cc701abcdab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"57b6dc2f295730f0d367796bed60489746887f1a","unresolved":true,"context_lines":[{"line_number":1243,"context_line":"        cache \u003d AllocationCapacityCache(duration\u003d60)"},{"line_number":1244,"context_line":"        cache._stop_watch.start()"},{"line_number":1245,"context_line":"        first_elapsed \u003d cache._stop_watch.elapsed()"},{"line_number":1246,"context_line":"        time.sleep(0.01)"},{"line_number":1247,"context_line":"        cache.update_data(123)"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        self.assertTrue(cache._stop_watch.has_started())"}],"source_content_type":"text/x-python","patch_set":4,"id":"d29b3a70_498780f5","line":1246,"updated":"2026-03-31 21:15:49.000000000","message":"Using time.sleep() in unit tests introduces real wall-clock delays\nand can be flaky. The assertion on line 1250 is weak -- it would\nalso pass if restart() was never called. A more robust approach:\n    with mock.patch.object(cache._stop_watch, \u0027restart\u0027) as mock_restart:\n        cache.update_data(123)\n        mock_restart.assert_called_once()","commit_id":"a56eaff1e9785ce7778c519beda11cc701abcdab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"57b6dc2f295730f0d367796bed60489746887f1a","unresolved":true,"context_lines":[{"line_number":1250,"context_line":"        self.assertLess(cache._stop_watch.elapsed(), first_elapsed + 0.01)"},{"line_number":1251,"context_line":"        self.assertEqual(123, cache._cached_allocated_capacity)"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"    def test_get_export_locations_with_share_group_id(self):"},{"line_number":1254,"context_line":"        fake_subvolume_path \u003d \u0027/foo/bar\u0027"},{"line_number":1255,"context_line":"        fake_group_id \u003d \u0027fake_group_id\u0027"},{"line_number":1256,"context_line":"        share \u003d {\"id\": \u0027fakeid\u0027, \"share_group_id\": fake_group_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"57429024_b8538434","line":1253,"updated":"2026-03-31 21:15:49.000000000","message":"The test creates its own share dict rather than using self._share\nfrom setUp. Consider share \u003d dict(self._share, share_group_id\u003d\u0027fake_group_id\u0027)\nfor consistency with other tests in this class.","commit_id":"a56eaff1e9785ce7778c519beda11cc701abcdab"}]}