)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1080016857638e03a8e8b9968bf5c5c340a5dc67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a9f6a50_fb56a98c","updated":"2025-11-10 17:35:45.000000000","message":"Thanks Francesco; i don\u0027t think we\u0027ll need this fallback mechanism here, because the minimum version of python-jsonschema in our requirements file should provide the Draft202012Validator: https://github.com/openstack/manila/blob/3946294f2ba884e80b734e40dc20f235862b3f4b/requirements.txt#L52\n\nInstead, since we\u0027re experimenting with the Draft7Validator, lets try to see if any of our validation depends on it (it doesn\u0027t per my analysis of the merged content; but, in a future update, we might start using some new additions like `prefixItems`, `unevaluatedItems` etc): https://review.opendev.org/c/openstack/manila/+/966621","commit_id":"14ef99170a7a5c40105dc1aab88b4c51d4441e09"}],"manila/api/validation/validators.py":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"29f4a1357b8323511808851fe8bf7f500bf2e1cf","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    except AttributeError:"},{"line_number":198,"context_line":"        try:"},{"line_number":199,"context_line":"            validator_org \u003d jsonschema.Draft7Validator"},{"line_number":200,"context_line":"        except AttributeError:"},{"line_number":201,"context_line":"            validator_org \u003d jsonschema.Draft4Validator"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__("}],"source_content_type":"text/x-python","patch_set":1,"id":"34b62ff6_66f26437","line":200,"updated":"2025-11-10 16:09:22.000000000","message":"not entirely sure we want to fallback to Draft4 but this might be just to be extra safe.","commit_id":"14ef99170a7a5c40105dc1aab88b4c51d4441e09"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e95fc0600c7cac47656bef19309209d78c64a827","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    except AttributeError:"},{"line_number":198,"context_line":"        try:"},{"line_number":199,"context_line":"            validator_org \u003d jsonschema.Draft7Validator"},{"line_number":200,"context_line":"        except AttributeError:"},{"line_number":201,"context_line":"            validator_org \u003d jsonschema.Draft4Validator"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__("}],"source_content_type":"text/x-python","patch_set":1,"id":"4b6de984_c50ca712","line":200,"in_reply_to":"34b62ff6_66f26437","updated":"2025-11-10 21:08:20.000000000","message":"Hi Francesco, testing with Draft7Validator didn\u0027t break anything: http://review.opendev.org/c/openstack/manila/+/966621?tab\u003dchange-view-tab-header-zuul-results-summary\n\nSo, we can safely use it right now if the issue is with the Draft202012Validator; but, if we set the min package requirement to jsonschema\u003e\u003d4.17 as we\u0027ve done, this fall back is unnecessary. \n\nif we amend the requirement to \u003e3.2.0, this fallback makes sense.. i\u0027m not a fan of it though; 4.17 was released in Nov 2022, three years ago; hopefully we can expect people to have it in environments where Manila Gazpacho would be deployed.","commit_id":"14ef99170a7a5c40105dc1aab88b4c51d4441e09"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"61224011b1d1a396e838f6acdcac8a21c6011947","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    except AttributeError:"},{"line_number":198,"context_line":"        try:"},{"line_number":199,"context_line":"            validator_org \u003d jsonschema.Draft7Validator"},{"line_number":200,"context_line":"        except AttributeError:"},{"line_number":201,"context_line":"            validator_org \u003d jsonschema.Draft4Validator"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__("}],"source_content_type":"text/x-python","patch_set":1,"id":"47e74d37_f67f2154","line":200,"in_reply_to":"4b6de984_c50ca712","updated":"2025-11-11 08:19:18.000000000","message":"Thank you for your feedback. I wasn\u0027t sure about the direction with this and having a fallback chain for me was just about taking a safe path.\nI agree that the current 202012 validator is more than enough considering the min availability and I already verified that `Draft7Validator` is good since the A release because it is available as a dependency.\nI\u0027m ok to abandon the patch if you think that we shouldn\u0027t do this change in the current branch, and to make things consistent I might propose a PS where I amend the requirements to have `jsonschema\u003e\u003d3.2.0`.","commit_id":"14ef99170a7a5c40105dc1aab88b4c51d4441e09"}]}