)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"44a9fb2c9fccf724292bebe54b45a0f032b29cc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"50d56f97_83c9ff7d","updated":"2025-11-11 16:55:25.000000000","message":"LGTM, Manideep. Thanks for working on this change.\nI see there was a conflict and this isn\u0027t a clean cherry-pick, but differences seem to be related to testing only. Please ask some engineer from the NetApp team to ack this change and approve it in the NetApp\u0027s end","commit_id":"721759410edaca115254a4243df656dc25565719"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bba0a1d8e2f639974bd2ca31c9a06df4365b0a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6e2c3146_aef1090a","updated":"2025-11-13 05:41:39.000000000","message":"Manideep confirmed that options have min value","commit_id":"721759410edaca115254a4243df656dc25565719"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4a8f19f54a4ebddfee0ceb4287be6d062c85db09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2b6b2856_9d1c231c","updated":"2025-11-13 13:20:13.000000000","message":"Thanks for acking the change, @jayaanand.borra@netapp.com","commit_id":"721759410edaca115254a4243df656dc25565719"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7d46d3cfc9ddc74d46618c63620899ce80982a5b","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":241,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":244,"context_line":"            modify_args.update("},{"line_number":245,"context_line":"                {\u0027volume-delete-retention-hours\u0027: str(delete_retention_hours)})"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c807d6b4_5a093ef8","line":243,"updated":"2025-11-13 05:06:45.000000000","message":"if DELETE_RETENTION_HOURS -ve for some reason. what will be the impact? Do we need to add any restriction?","commit_id":"e2c40f529e6b5fb6376944c9f4ab7df9f00385fa"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bba0a1d8e2f639974bd2ca31c9a06df4365b0a3b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            \u0027aggr-list\u0027: aggr_list,"},{"line_number":241,"context_line":"            \u0027vserver-name\u0027: vserver_name,"},{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"        if self.features.DELETE_RETENTION_HOURS:"},{"line_number":244,"context_line":"            modify_args.update("},{"line_number":245,"context_line":"                {\u0027volume-delete-retention-hours\u0027: str(delete_retention_hours)})"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a3bfed7_e91ed3b5","line":243,"in_reply_to":"c807d6b4_5a093ef8","updated":"2025-11-13 05:41:39.000000000","message":"Done","commit_id":"e2c40f529e6b5fb6376944c9f4ab7df9f00385fa"}]}
