)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"09a328905b3a5a7994b628c7d4179a4fbd159079","unresolved":true,"context_lines":[{"line_number":13,"context_line":"request and response validation decorators."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In this change, we also needed to update the snapshot controller as"},{"line_number":16,"context_line":"commit 8e0bbbcae (\"api: Remove use of mixin classes\") moved methods"},{"line_number":17,"context_line":"from ShareSnapshotMixin into ShareSnapshotsController but left the"},{"line_number":18,"context_line":"versioned show() calling super().show(), which no longer resolves"},{"line_number":19,"context_line":"since wsgi.Controller has no show method. This causes an"},{"line_number":20,"context_line":"AttributeError at runtime and in unit tests."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Inline the show logic directly into the versioned method, matching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1213e6a7_39f9390d","line":19,"range":{"start_line":16,"start_character":54,"end_line":19,"end_character":41},"updated":"2026-03-12 18:44:46.000000000","message":"I don\u0027t see this behavior.. I see the show method moved to a different place with new decorators. Is the issue that we were missing the min version decorator? Wouldn\u0027t that mean that 2.0 is the version accepted?","commit_id":"de4ba661af6893d64c8b17b93903e8217bc2efdf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"39a06df13cd9d755c9624f665765ad3fc15f88fc","unresolved":true,"context_lines":[{"line_number":13,"context_line":"request and response validation decorators."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In this change, we also needed to update the snapshot controller as"},{"line_number":16,"context_line":"commit 8e0bbbcae (\"api: Remove use of mixin classes\") moved methods"},{"line_number":17,"context_line":"from ShareSnapshotMixin into ShareSnapshotsController but left the"},{"line_number":18,"context_line":"versioned show() calling super().show(), which no longer resolves"},{"line_number":19,"context_line":"since wsgi.Controller has no show method. This causes an"},{"line_number":20,"context_line":"AttributeError at runtime and in unit tests."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Inline the show logic directly into the versioned method, matching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"67161647_574e360b","line":19,"range":{"start_line":16,"start_character":54,"end_line":19,"end_character":41},"in_reply_to":"1213e6a7_39f9390d","updated":"2026-03-12 18:55:07.000000000","message":"very badly worded by me, sorry... So we used to have the v2 controller inheriting from the mixin, which had the show method implementation done. The controller, was doing the version checks and then calling super().show() - which makes sense, as the implementation comes from the mixin. Now, the mixin ceased to exist and we can simply have one single show method, as it doesn\u0027t differ much based on microversions. If we kept calling super().show() it would look inside the classes the controller inherits from, and that will fail, as it only inherits from wsgi.controller which doesn\u0027t have a show method.\n\nFor some reason, this worked on a devstack but unit tests caught this.","commit_id":"de4ba661af6893d64c8b17b93903e8217bc2efdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"38d6833ea7fbde5c025456a4a61b96a144e39d09","unresolved":false,"context_lines":[{"line_number":13,"context_line":"request and response validation decorators."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In this change, we also needed to update the snapshot controller as"},{"line_number":16,"context_line":"commit 8e0bbbcae (\"api: Remove use of mixin classes\") moved methods"},{"line_number":17,"context_line":"from ShareSnapshotMixin into ShareSnapshotsController but left the"},{"line_number":18,"context_line":"versioned show() calling super().show(), which no longer resolves"},{"line_number":19,"context_line":"since wsgi.Controller has no show method. This causes an"},{"line_number":20,"context_line":"AttributeError at runtime and in unit tests."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Inline the show logic directly into the versioned method, matching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"31143c59_817d3497","line":19,"range":{"start_line":16,"start_character":54,"end_line":19,"end_character":41},"in_reply_to":"67161647_574e360b","updated":"2026-03-12 19:32:12.000000000","message":"Perfect, we don\u0027t need it in the commit message since the behavior was caught and fixed between patches to this change.","commit_id":"de4ba661af6893d64c8b17b93903e8217bc2efdf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38358,"name":"Marco Wehrhahn","email":"marco.wehrhahn@gmail.com","username":"marco-wehr"},"change_message_id":"a9848d56e43e88c447979804e93aa714e398ea98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c5b246fb_da5e8b63","updated":"2025-11-28 19:43:51.000000000","message":"Happy holidays! Please review at your earliest convenience 😊","commit_id":"acaef39ce1eac08a96af9f45a31ba06fc0eb6223"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603ba2b7ffe953d0bb28be87aeb218b0d68bd10f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ded9572_7c2029b8","in_reply_to":"c5b246fb_da5e8b63","updated":"2026-01-26 19:42:53.000000000","message":"Thanks for working on this Marco. I\u0027ve made some changes and uploaded a newer patch. Do check it out, and update it if you think it needs more changes","commit_id":"acaef39ce1eac08a96af9f45a31ba06fc0eb6223"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"24f8ab6955792aa17398e8fd68ea1c47c3d4c3a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e41a5d9_00e05230","updated":"2026-03-12 09:17:55.000000000","message":"LGTM + jobs are happy. THanks Marco!","commit_id":"b7e9b48cb9ac4558d2c3fb275753441bc423a0bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"38d6833ea7fbde5c025456a4a61b96a144e39d09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5b5ad62a_17ca1201","updated":"2026-03-12 19:32:12.000000000","message":"LGTM, thank you for updating this Carlos.","commit_id":"b47dd43955bdfc67ecffe8c28c93ca68bc70acff"}],"manila/api/schemas/share_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603ba2b7ffe953d0bb28be87aeb218b0d68bd10f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    \u0027properties\u0027: {"},{"line_number":161,"context_line":"        \u0027id\u0027: {"},{"line_number":162,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027integer\u0027],"},{"line_number":163,"context_line":"            \u0027description\u0027: \"The UUID of the snapshot.\","},{"line_number":164,"context_line":"        },"},{"line_number":165,"context_line":"        \u0027status\u0027: {"},{"line_number":166,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3bb509ad_65dd1377","line":163,"range":{"start_line":163,"start_character":13,"end_line":163,"end_character":55},"updated":"2026-01-26 19:42:53.000000000","message":"here and everywhere else, we could re-use the description from the parameters.yaml file","commit_id":"acaef39ce1eac08a96af9f45a31ba06fc0eb6223"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603ba2b7ffe953d0bb28be87aeb218b0d68bd10f","unresolved":false,"context_lines":[{"line_number":214,"context_line":"}"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# \u003e\u003d v2.12: provider_location added"},{"line_number":217,"context_line":"show_snapshot_v212 \u003d copy.copy(show_snapshot)"},{"line_number":218,"context_line":"show_snapshot_v212[\u0027properties\u0027] \u003d copy.copy(show_snapshot[\u0027properties\u0027])"},{"line_number":219,"context_line":"show_snapshot_v212[\u0027properties\u0027].update({"},{"line_number":220,"context_line":"    \u0027provider_location\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4ce1e36_5922ae1f","line":217,"range":{"start_line":217,"start_character":21,"end_line":217,"end_character":30},"updated":"2026-01-26 19:42:53.000000000","message":"my bad on copy.copy.. Sometimes, we\u0027re modifying the inner dicts where we\u0027ll have to end up using deepcopy.","commit_id":"acaef39ce1eac08a96af9f45a31ba06fc0eb6223"}]}