)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"36de81fb8682d0f76a439fd90e468fcf7619200f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7387f6a5_3e2c9b66","updated":"2025-12-18 17:01:56.000000000","message":"The CI build ran successfully : \nhpe-alletramp-manila-file-driver build/99af9b36b536474f983cc3e2c95887d9 : SUCCESS in 1h 39m 41s\n(Time run Thursday, Dec 18, 2025, 4:37:43 PM UTC+05:30)\n\nCI Logs: https://github.com/hpe-storage/hpe_manila_logs/tree/main/new_logs/968969","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"daa05f47e80298584d8b7bf0a7dc6eefb5cfbce9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1aa3ef81_6408b802","updated":"2025-12-19 12:47:12.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"a53d23ee65e9f649bc1087406c8a7968f601462f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"30648ecb_b0133855","updated":"2025-12-18 09:27:37.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"afe3c3c2d5e21fef0b07637ba90e07d3ac9d3a19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5f1761c7_63483464","updated":"2025-12-18 12:32:52.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"14ff361bd26fbae5fbd009c9538ff9c8cad1eab1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6589ef22_84c22331","updated":"2025-12-18 12:22:19.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"b49b3c65487247a36e06244268e83a54f76cb884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c216f93_124dca70","updated":"2025-12-19 10:56:50.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"78896ef122f2dddcf1aafe1c20dbf82104a3a5f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"80511b22_ed1ce97d","updated":"2025-12-18 13:07:16.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"3a0c4e2c2423e9ea2d4ab41c680a39423af3f959","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b06ed4a_91d57139","updated":"2025-12-19 10:37:29.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"98c2e721ca1d16fc7cb69d341512409e1ccbd5f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b01f3723_2845c2c1","updated":"2025-12-19 12:01:18.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"28f4725e34ab127c6ba7a0b714a00452273a7193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cbf0536e_b5d4016d","updated":"2025-12-18 12:51:05.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"819110126d4487ea9e9f9f1f5a516306f84e5385","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dd37e4a7_fd501e46","updated":"2025-12-18 07:45:38.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"25a43a9a574d48c57602c2cddcc96218f18d7a9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e2ed32b8_f9556e67","updated":"2025-12-19 12:27:31.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"cf45ac80e6694aa7cf848c7a0da2ecd1a0531c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f89c265c_f58471b2","updated":"2025-12-18 04:03:58.000000000","message":"run-HPE Storage Manila CI","commit_id":"1b137e8e29829d22c21d237a3e84c953be9bd54f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a5ee1a0e_10df354c","updated":"2026-01-13 05:53:48.000000000","message":"Thank you for submitting this Srinesh, please see some comments inline","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"04970fe6_161f861f","updated":"2026-01-19 05:53:31.000000000","message":"Thanks for reviewing the changes @gouthampravi@gmail.com. I have addressed your review comments. Please take a look and let me know.","commit_id":"c155403ffb3597c1d455bb1d45099859f094444e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f1eef6bea060bc5a951e354449a4761ffaf13df5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"57604c9a_b40f04a0","updated":"2026-01-23 18:55:08.000000000","message":"Hey @srinesh.a-r@hpe.com: Thanks for the changes. The HPE CI system isn\u0027t posting a log link:\n\n```\nhpe-alletramp-manila-file-driver build/62ea38de5a7a439796b30a0e139281a9 : SUCCESS in 1m 21s\n```\n\ncould you please check its configuration? Also, the execution time, `1m 21 seconds` seems a bit suspect to me..","commit_id":"54dc0007d26560a7a4366a6d6cada98b308d4bee"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"bb0b45694d5c0900742190d08f093b91608011e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"78ef6483_020351ad","in_reply_to":"57604c9a_b40f04a0","updated":"2026-01-27 14:57:00.000000000","message":"I understood from our HPE CI team that we are facing an issue with posting the logs url since the account we are using for CI needs enhanced privileges due to new version of Zuul which we have requested.\n\nWill also look into fixing the short run time issue. The job was was running successfully earlier on 18th Dec it ran for 1h 39m 41s. \n\nSuccessful CI Logs: https://github.com/hpe-storage/hpe_manila_logs/tree/main/new_logs/968969\n\n```\nhpe-alletramp-manila-file-driver build/99af9b36b536474f983cc3e2c95887d9 : SUCCESS in 1h 39m 41s\n(Time run Thursday, Dec 18, 2025, 4:37:43 PM UTC+05:30)\n```","commit_id":"54dc0007d26560a7a4366a6d6cada98b308d4bee"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"bb0b45694d5c0900742190d08f093b91608011e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0c6ccbf8_ffd02d2d","updated":"2026-01-27 14:57:00.000000000","message":"Hi @gouthampravi@gmail.com: I have addressed your review comments. Please take a look and let me know.","commit_id":"c6c9a8fb0b7fae2f1b7494f5a057f02a1304d9bd"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"375b65a21fcf6d96e393d935ba34ff7593bb894e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0bbbb395_f25a2b98","updated":"2026-01-29 09:31:04.000000000","message":"run-HPE Storage Manila CI","commit_id":"c6c9a8fb0b7fae2f1b7494f5a057f02a1304d9bd"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"16956df55a5083bb70edc7f33e7c860c4984bb5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7b0e27b5_ab599161","updated":"2026-02-04 06:31:30.000000000","message":"run-HPE Storage Manila CI","commit_id":"c6c9a8fb0b7fae2f1b7494f5a057f02a1304d9bd"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"0988b979b6ad864082328a166b6e3f41b9cdc866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8f0dfe02_a68f60f6","updated":"2026-02-03 04:50:03.000000000","message":"run-HPE Storage Manila CI","commit_id":"c6c9a8fb0b7fae2f1b7494f5a057f02a1304d9bd"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"0b84c7df5a481a213f0610b2fde2cba598e530aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c60a8525_48092fe8","updated":"2026-02-05 05:49:22.000000000","message":"run-HPE Storage Manila CI","commit_id":"c6c9a8fb0b7fae2f1b7494f5a057f02a1304d9bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7a4dcdf5084ed3d2917583a037cf2310bbe7ede","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"21a2ef6c_ab5da61d","updated":"2026-02-05 23:53:26.000000000","message":"Hi @srinesh.a-r@hpe.com.. Thanks for chatting with us at the collab review session. I\u0027ve some comments inline, please take a look. \n\nAs we discussed, if there\u0027s no workaround currently to the issue of allowing READONLY access to shares upon creation, I would atleast report a bug against this in https://bugs.launchpad.net/manila and address it at a later time","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"805d768e0265e1ce0b39d181eb75f6f71cacbcf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0d72dd2f_c4c0641b","updated":"2026-02-05 10:04:49.000000000","message":"run-HPE Storage Manila CI","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"aedb1475ed15e1741770cc41561a00394f218671","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"eacca503_fe1a08fd","updated":"2026-02-10 06:20:15.000000000","message":"Hi @gouthampravi@gmail.com @anoop.shukla@netapp.com\n\nI have addressed the 2 issues we had discussed as part of the mid-cycle call.\n\n1) Disallow Access to newly created shares\n\nLike you had suggested we have implemented a workaround to block all IP addresses when a share is created in manila by assigning a default access rule of (0.0.0.0, ro, root_squash) when the access rule in manila is empty. This blocks all IP addresses from accessing the share similar to recommended manila behavior.\n\n2) Share Naming\n\nWe have made changes to align to the share_name_template naming convention and our naming our share in the given format now.\n\nHave also addressed the remaining review comments you had given. Please take a look and let me know.","commit_id":"5757ae90827d124d27c0e55d4aaabbfc8d5f8509"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"3020369d40daf2c2026e1d208377b42e0ef999dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"79e97adb_b2de60d4","updated":"2026-02-13 04:26:13.000000000","message":"run-HPE Storage Manila CI","commit_id":"3fef740d932b226480bd369a97399c064bb66a5b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d50ca36834a86924684ae3d70b1c363b5467d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"943df320_3ead2abe","updated":"2026-02-17 06:18:32.000000000","message":"Hey @srinesh.a-r@hpe.com:\n\nI\u0027ve further questions, but, these don\u0027t look like critical issues. However, I\u0027d like you to respond or, file bugs and work on them after this patch merges:\n\n1) Your CI system is still not posting logs, and it\u0027s failing once in a while. Have you see the latest logs? Are all the tests passing? Do you have an ETA on when the issue will be resolved?\n2) I\u0027ve left a question regarding purging share contents prior to deletion. \n3) While thinking about driver documentation (thank you for your review on https://review.opendev.org/c/openstack/manila/+/976320), it occurred to me that manila users expect to allow IP based access to the world using 0.0.0.0/0 for ipv4 and ::/0 for IPv6. Would your driver honor that?","commit_id":"97551d84ad8861c46ede1788d87fcd5edcb33227"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"40bd458d5e29d8a520b79a09d44e711cee490316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"565511bd_552cd3b8","updated":"2026-02-18 04:51:33.000000000","message":"run-HPE Storage Manila CI","commit_id":"97551d84ad8861c46ede1788d87fcd5edcb33227"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"c8a435170b0c9226cfb2b0a38a3a7575eef43dfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"84bddf51_1dfa46cd","updated":"2026-02-17 14:56:23.000000000","message":"run-HPE Storage Manila CI","commit_id":"97551d84ad8861c46ede1788d87fcd5edcb33227"},{"author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"change_message_id":"6ffed98a5bbc89b3797cfeaa580d508b44543631","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9b5af5de_3c1f6511","updated":"2026-02-18 09:52:48.000000000","message":"run-HPE Storage Manila CI","commit_id":"97551d84ad8861c46ede1788d87fcd5edcb33227"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"4ce460c352f92ffa7b12db9da49f83544dcbe986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1687c0f2_06bcfcb2","in_reply_to":"943df320_3ead2abe","updated":"2026-02-18 12:27:53.000000000","message":"1) We are able to run the CI job successfully with logs as well posting as part of Patchset 17 (Wednesday, Feb 18, 2026, 4:42:54 PM UTC+05:30) an hour back.\n\n2) Have replied inline.\n\n3) In Alletra MP case to provide access to all IP addresses we can use \"\\*\". We have already handled this case by converting \"0.0.0.0/0\" received from manila to \"\\*\" on the backend array during access rules update (Since we are only supporting ipv4 in our case).","commit_id":"97551d84ad8861c46ede1788d87fcd5edcb33227"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"4ce460c352f92ffa7b12db9da49f83544dcbe986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9e827be8_6dd47af9","updated":"2026-02-18 12:27:53.000000000","message":"Hi @gouthampravi@gmail.com\n\nThanks for reviewing the changes. We are able to get the CI job running successfully with logs posting an hour back. Please let me know if any other details are needed for merge of the first patch of changes.","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ff8470995e9c2972b85f6aed8edb7e3d47c2d253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"22b46af9_a3a58fae","updated":"2026-02-23 14:10:48.000000000","message":"LGTM ..!","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2c9ecd2ab6082747e5206aa4545203bf6ca21faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"052f1719_28d9a956","updated":"2026-02-18 23:14:24.000000000","message":"LGTM, please do follow up on the pending comments","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f1761f12_342f9513","updated":"2026-02-18 11:54:36.000000000","message":"LGTM, thanks for working on this change! Driver structure looks great and seems pretty well covered with unit tests. Only have some cosmetic changes for the code, but I\u0027d also like to reinforce  that the HPE CI is not sharing any logs and it is very important to get the tests results posted. For the changes I am proposing, please feel free to address them in a follow-up change. I\u0027ll not merge this change at the moment while we wait on CI outputs.","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"7090605e4c211e87afbbc2918ec490350a000f2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"8f912071_8d03b466","updated":"2026-02-18 12:39:21.000000000","message":"Thanks for reviewing the changes @ces.eduardo98@gmail.com.\n\nWe are able to run the CI job successfully with logs as well posting in the comment as part of Patchset 17 (Wednesday, Feb 18, 2026, 4:42:54 PM UTC+05:30) an hour back.\n\nHope this is enough to merge the first round of changes and I can address the comments in a follow up patch.","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"0c1b9831dc459fa21c2b690a2f080f97ed484614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ed731403_d53bde7e","updated":"2026-02-19 05:31:37.000000000","message":"run-HPE Storage Manila CI","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"7090605e4c211e87afbbc2918ec490350a000f2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e8668015_5ad4b3cf","in_reply_to":"f1761f12_342f9513","updated":"2026-02-18 12:39:21.000000000","message":"Hope it is okay if I address the changes in a follow-up patch.","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"}],"doc/source/admin/hpe_alletra_mp_b10000_driver.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Share networks are not supported. Shares are created directly on the HPE"},{"line_number":34,"context_line":"Alletra MP B10000 array without the use of a share server or service VM."},{"line_number":35,"context_line":"Network connectivity is setup outside of Manila."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. note::"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"64347c04_00955252","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":29},"updated":"2026-01-13 05:53:48.000000000","message":"nit: set up","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Share networks are not supported. Shares are created directly on the HPE"},{"line_number":34,"context_line":"Alletra MP B10000 array without the use of a share server or service VM."},{"line_number":35,"context_line":"Network connectivity is setup outside of Manila."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. note::"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"d505cc78_c43c0f57","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":29},"in_reply_to":"64347c04_00955252","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   In Alletra MP B10000, when the access rules list is empty, the share is"},{"line_number":112,"context_line":"   accessible by all IPs with read-only and root-squash permissions. This is"},{"line_number":113,"context_line":"   the default behavior in Alletra MP B10000 unified file."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"To allow read-write access:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"440d2e66_36a0448c","line":113,"range":{"start_line":111,"start_character":3,"end_line":113,"end_character":58},"updated":"2026-01-13 05:53:48.000000000","message":"This seems bad in a multitenant setup. Is there any way to deny all clients or is this readonly nature enforced for any specific reason?","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   In Alletra MP B10000, when the access rules list is empty, the share is"},{"line_number":112,"context_line":"   accessible by all IPs with read-only and root-squash permissions. This is"},{"line_number":113,"context_line":"   the default behavior in Alletra MP B10000 unified file."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"To allow read-write access:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"868c78cb_7d847ad0","line":113,"range":{"start_line":111,"start_character":3,"end_line":113,"end_character":58},"in_reply_to":"440d2e66_36a0448c","updated":"2026-01-19 05:53:31.000000000","message":"In Unified File we rely on the standard Linux NFS server. If an export is defined without an explicit host list or access mode, the NFS export defaults to permitting all hosts with read-only access. This behavior is applied by the NFS export configuration utilities and enforced by the kernel NFS server.\n\nSo we have aligned to NFS server","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"bb0b45694d5c0900742190d08f093b91608011e4","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   In Alletra MP B10000, when the access rules list is empty, the share is"},{"line_number":112,"context_line":"   accessible by all IPs with read-only and root-squash permissions. This is"},{"line_number":113,"context_line":"   the default behavior in Alletra MP B10000 unified file."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"To allow read-write access:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"b26ba7fc_6072444c","line":113,"range":{"start_line":111,"start_character":3,"end_line":113,"end_character":58},"in_reply_to":"4e35cc02_e9e97cba","updated":"2026-01-27 14:57:00.000000000","message":"Yes, we will include it in our backlog for future releases to reconsider the behavior and see if we can align more with the way you mentioned.\n\nCurrently I have included an additional line to this comment recommending the customer setting of access rules for secured access to client.","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f1eef6bea060bc5a951e354449a4761ffaf13df5","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   In Alletra MP B10000, when the access rules list is empty, the share is"},{"line_number":112,"context_line":"   accessible by all IPs with read-only and root-squash permissions. This is"},{"line_number":113,"context_line":"   the default behavior in Alletra MP B10000 unified file."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"To allow read-write access:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"4e35cc02_e9e97cba","line":113,"range":{"start_line":111,"start_character":3,"end_line":113,"end_character":58},"in_reply_to":"868c78cb_7d847ad0","updated":"2026-01-23 18:55:08.000000000","message":"Yes, but you could build for better security than that? \nA standard linux NFS Server is meant to be customized and secured for general purpose NFS in a multi-tenant environment like OpenStack.","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d50ca36834a86924684ae3d70b1c363b5467d35","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   In Alletra MP B10000, when the access rules list is empty, the share is"},{"line_number":112,"context_line":"   accessible by all IPs with read-only and root-squash permissions. This is"},{"line_number":113,"context_line":"   the default behavior in Alletra MP B10000 unified file."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"To allow read-write access:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"b1e43418_abf07b20","line":113,"range":{"start_line":111,"start_character":3,"end_line":113,"end_character":58},"in_reply_to":"b26ba7fc_6072444c","updated":"2026-02-17 06:18:32.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":".. code-block:: console"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"   $ openstack share extend \u003cshare\u003e \u003cnew-size\u003e"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. note::"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"02ae0db2_9984c3a9","line":146,"range":{"start_line":146,"start_character":5,"end_line":146,"end_character":27},"updated":"2026-01-13 05:53:48.000000000","message":"this isn\u0027t a valid command, the command is: \"openstack share resize\"","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":".. code-block:: console"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"   $ openstack share extend \u003cshare\u003e \u003cnew-size\u003e"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. note::"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"092f41cc_782a1863","line":146,"range":{"start_line":146,"start_character":5,"end_line":146,"end_character":27},"in_reply_to":"02ae0db2_9984c3a9","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":70,"context_line":"   this reduce type are created on the backend. The reduce setting is applied"},{"line_number":71,"context_line":"   at share creation time and cannot be changed for existing shares."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"   The ``reduce`` parameter controls the ``compression`` and ``dedup`` capabilities"},{"line_number":74,"context_line":"   of the share:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"   - If reduce \u003d true: compression \u003d true, dedup \u003d true"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa0dcfea_dfdf0b9b","line":73,"range":{"start_line":73,"start_character":63,"end_line":73,"end_character":68},"updated":"2026-02-18 11:54:36.000000000","message":"I think you meant ``dedupe`` ?","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":170,"context_line":"   permissions on the backend Alletra B10000 array. You must explicitly create"},{"line_number":171,"context_line":"   access rules to allow client access."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"To allow read-write access:"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. code-block:: console"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"   $ openstack share access create \u003cshare\u003e ip \u003cip-address\u003e --access-level rw"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"To allow read-only access:"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. code-block:: console"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"   $ openstack share access create \u003cshare\u003e ip \u003cip-address\u003e --access-level ro"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"To view current access rules:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":".. code-block:: console"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"   $ openstack share access list \u003cshare\u003e"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"To remove access:"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":".. code-block:: console"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"   $ openstack share access delete \u003cshare\u003e \u003caccess-id\u003e"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Extending Shares"},{"line_number":198,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"78e7ae14_92784c1c","line":195,"range":{"start_line":173,"start_character":0,"end_line":195,"end_character":54},"updated":"2026-02-18 11:54:36.000000000","message":"It\u0027s nice to have this mentioned in the doc, however as there is no specific detail to the driver in the above commands, this becomes one more place where we need to maintain these commands. In case something changes, we\u0027ll need to update it here and in the main documentation, so I\u0027d prefer not having these here and having a link referring people to the main documentation, something like [1] \nhttps://docs.openstack.org/manila/latest/user/create-and-manage-shares.html","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":".. code-block:: console"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"   $ openstack share resize \u003cshare\u003e \u003cnew-size\u003e"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":".. note::"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"dbffe79d_90273d68","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":2},"updated":"2026-02-18 11:54:36.000000000","message":"same as above","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":".. code-block:: console"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   $ openstack share adopt \u003chost\u003e@\u003cbackend\u003e#\u003cpool\u003e \u003cprotocol\u003e \u003cexport-path\u003e --share-type \u003cshare-type\u003e --name \u003cshare-name\u003e"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Unmanaging Shares"},{"line_number":258,"context_line":"~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":17,"id":"0052c4fc_8ad3f1f8","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":2},"updated":"2026-02-18 11:54:36.000000000","message":"same as above","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":".. code-block:: console"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"   $ openstack share service ensure shares \u003chost\u003e"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Driver Capabilities"},{"line_number":287,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3ad1309f_22c41d79","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":2},"updated":"2026-02-18 11:54:36.000000000","message":"same","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: console"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"   $ openstack share service list"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"To check the backend pool status:"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3b203009_5b8c8a26","line":338,"range":{"start_line":338,"start_character":0,"end_line":338,"end_character":2},"updated":"2026-02-18 11:54:36.000000000","message":"same","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":".. code-block:: console"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"   $ openstack share pool list --detail"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"The :mod:`manila.share.drivers.hpe.alletra_mp_b10000.hpe_alletra_driver` Module"},{"line_number":347,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":17,"id":"bd5ee16c_d40374fe","line":344,"range":{"start_line":344,"start_character":0,"end_line":344,"end_character":2},"updated":"2026-02-18 11:54:36.000000000","message":"same","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"}],"doc/source/configuration/shared-file-systems/drivers/hpe-alletra-mp-b10000-driver.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":".. code-block:: console"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"   $ openstack share extend \u003cshare\u003e \u003cnew-size\u003e"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":".. note::"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7b97cb74_1a2ac406","line":327,"range":{"start_line":327,"start_character":21,"end_line":327,"end_character":27},"updated":"2026-01-13 05:53:48.000000000","message":"resize","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":".. code-block:: console"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"   $ openstack share extend \u003cshare\u003e \u003cnew-size\u003e"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":".. note::"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1315da2a_60bae463","line":327,"range":{"start_line":327,"start_character":21,"end_line":327,"end_character":27},"in_reply_to":"7b97cb74_1a2ac406","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d50ca36834a86924684ae3d70b1c363b5467d35","unresolved":true,"context_lines":[{"line_number":348,"context_line":"   $ openstack share delete my_share"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":".. note::"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"   If a share contains data, the delete operation will fail. The error will be"},{"line_number":353,"context_line":"   reported in the Manila logs and the share will be in ``error_deleting`` state."},{"line_number":354,"context_line":"   Ensure the share is empty before attempting to delete it."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"Share access"},{"line_number":357,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f5c609a_b0a55cc9","line":354,"range":{"start_line":351,"start_character":0,"end_line":354,"end_character":60},"updated":"2026-02-17 06:18:32.000000000","message":"Could the driver just purge the contents? This is certainly inconsistent with the other drivers; it might take a while for someone to mount a share and erase all of its contents prior to deletion.","commit_id":"97551d84ad8861c46ede1788d87fcd5edcb33227"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"4ce460c352f92ffa7b12db9da49f83544dcbe986","unresolved":true,"context_lines":[{"line_number":348,"context_line":"   $ openstack share delete my_share"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":".. note::"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"   If a share contains data, the delete operation will fail. The error will be"},{"line_number":353,"context_line":"   reported in the Manila logs and the share will be in ``error_deleting`` state."},{"line_number":354,"context_line":"   Ensure the share is empty before attempting to delete it."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"Share access"},{"line_number":357,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"f1cb7fae_f888f3b8","line":354,"range":{"start_line":351,"start_character":0,"end_line":354,"end_character":60},"in_reply_to":"7f5c609a_b0a55cc9","updated":"2026-02-18 12:27:53.000000000","message":"We want to avoid deleting customer data and give them the option to clear it themselves before removing the share. So by design we have kept the behavior of delete operation failing when share contains data on the Alletra array itself.","commit_id":"97551d84ad8861c46ede1788d87fcd5edcb33227"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":365,"context_line":"   by setting a default access rule of 0.0.0.0 with read-only and root_squash"},{"line_number":366,"context_line":"   permissions on the backend Alletra B10000 array. You must explicitly create"},{"line_number":367,"context_line":"   access rules to allow client access."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"To allow read-write access:"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":".. code-block:: console"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"   $ openstack share access create \u003cshare\u003e ip \u003cip-address\u003e --access-level rw"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"To allow read-only access:"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":".. code-block:: console"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"   $ openstack share access create \u003cshare\u003e ip \u003cip-address\u003e --access-level ro"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"To remove access:"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":".. code-block:: console"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"   $ openstack share access delete \u003cshare\u003e \u003caccess-id\u003e"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"Share extend"},{"line_number":388,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5d7bad95_e93722ef","line":385,"range":{"start_line":368,"start_character":1,"end_line":385,"end_character":54},"updated":"2026-02-18 11:54:36.000000000","message":"same as the other file","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"}],"manila/share/drivers/hpe/alletra_mp_b10000/fileshare/fileshare_handler.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import helpers"},{"line_number":25,"context_line":"from manila import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from oslo_log import log"},{"line_number":28,"context_line":"from oslo_serialization import base64"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import uuid"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ebb5d7fc_2265cb2c","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":11},"updated":"2026-01-13 05:53:48.000000000","message":"See import order template here:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import helpers"},{"line_number":25,"context_line":"from manila import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from oslo_log import log"},{"line_number":28,"context_line":"from oslo_serialization import base64"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import uuid"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"abab6afb_23a017f7","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":11},"in_reply_to":"ebb5d7fc_2265cb2c","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.filesystem_handler \u003d filesystem_handler.FileSystemHandler("},{"line_number":40,"context_line":"            rest_client)"},{"line_number":41,"context_line":"        self.filesharesetting_handler \u003d filesharesetting_handler.\\"},{"line_number":42,"context_line":"            FileSharesettingHandler(rest_client)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # BE APIs"},{"line_number":45,"context_line":"    def create_fileshare(self, fe_create_fileshare, extra_specs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1cb4ee4f_f2c59c3a","line":42,"range":{"start_line":41,"start_character":8,"end_line":42,"end_character":48},"updated":"2026-02-18 11:54:36.000000000","message":"```suggestion\n        self.filesharesetting_handler \u003d (\n            filesharesetting_handler.FileSharesettingHandler(\n                rest_client\n        )\n```","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \"CREATE_FILESHARE \" +"},{"line_number":64,"context_line":"            fe_create_fileshare[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        be_fileshare_name, be_filesystem_name, be_sharesetting_name \\"},{"line_number":67,"context_line":"            \u003d self.convert._get_be_share_resource_names(fe_create_fileshare)"},{"line_number":68,"context_line":"        msg \u003d _("},{"line_number":69,"context_line":"            \"Create fileshare backend operation completed for id: %(fe_id)s. \""},{"line_number":70,"context_line":"            \"Backend share name %(be_name)s\") % {"}],"source_content_type":"text/x-python","patch_set":17,"id":"2793e918_1eb390fa","line":67,"range":{"start_line":66,"start_character":8,"end_line":67,"end_character":76},"updated":"2026-02-18 11:54:36.000000000","message":"```suggestion\n        be_fileshare_name, be_filesystem_name, be_sharesetting_name \u003d (\n            self.convert._get_be_share_resource_names(fe_create_fileshare)\n        )\n```","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        be_existing_filesystem_size \u003d None"},{"line_number":128,"context_line":"        if expand_filesystem:"},{"line_number":129,"context_line":"            try:"},{"line_number":130,"context_line":"                fe_filesystem \u003d self.filesystem_handler.\\"},{"line_number":131,"context_line":"                    _get_filesystem_by_name(be_filesystem_name)"},{"line_number":132,"context_line":"            except Exception as e:"},{"line_number":133,"context_line":"                msg \u003d _(\"Edit fileshare failed for id\""},{"line_number":134,"context_line":"                        \" %(share_id)s. Error: %(error)s\") % {"}],"source_content_type":"text/x-python","patch_set":17,"id":"b43f50f5_2629f191","line":131,"range":{"start_line":130,"start_character":16,"end_line":131,"end_character":63},"updated":"2026-02-18 11:54:36.000000000","message":"```suggestion\n                fe_filesystem \u003d (\n                    self.filesystem_handler._get_filesystem_by_name(\n                        be_filesystem_name)\n                )\n```","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    def manage_fileshare(self, fe_manage_fileshare, extra_specs):"},{"line_number":198,"context_line":"        self.validator.validate_manage_fileshare_fe_req("},{"line_number":199,"context_line":"            fe_manage_fileshare, extra_specs)"},{"line_number":200,"context_line":"        be_manage_fileshare \u003d self.convert.\\"},{"line_number":201,"context_line":"            convert_manage_fileshare_to_be_model("},{"line_number":202,"context_line":"                fe_manage_fileshare, extra_specs)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            fe_fileshare \u003d self._get_fileshare_by_hostip_mountpath("}],"source_content_type":"text/x-python","patch_set":17,"id":"be6f049b_19967195","line":202,"range":{"start_line":200,"start_character":8,"end_line":202,"end_character":49},"updated":"2026-02-18 11:54:36.000000000","message":"please use the format suggested above","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":232,"context_line":"            LOG.error(msg)"},{"line_number":233,"context_line":"            raise exception.HPEAlletraB10000DriverException(reason\u003dmsg)"},{"line_number":234,"context_line":"        try:"},{"line_number":235,"context_line":"            fe_filesharesetting \u003d self.filesharesetting_handler.\\"},{"line_number":236,"context_line":"                _get_filesharesetting_by_name("},{"line_number":237,"context_line":"                    fe_fileshare[\u0027be_sharesetting_name\u0027])"},{"line_number":238,"context_line":"        except Exception as e:"},{"line_number":239,"context_line":"            msg \u003d ("},{"line_number":240,"context_line":"                _("}],"source_content_type":"text/x-python","patch_set":17,"id":"ddb64b98_a01e970e","line":237,"range":{"start_line":235,"start_character":12,"end_line":237,"end_character":57},"updated":"2026-02-18 11:54:36.000000000","message":"same","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"}],"manila/share/drivers/hpe/alletra_mp_b10000/fileshare/filesharesetting_handler.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        self.validator.validate_get_filesharesettings_be_resp("},{"line_number":34,"context_line":"            be_filesharesettings)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        fe_filesharesettings \u003d self.convert.\\"},{"line_number":37,"context_line":"            convert_filesharesettings_to_fe_model("},{"line_number":38,"context_line":"                be_filesharesettings)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return fe_filesharesettings"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"19c6c212_29d74a16","line":38,"range":{"start_line":36,"start_character":8,"end_line":38,"end_character":37},"updated":"2026-02-18 11:54:36.000000000","message":"same as the other files, here and below","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"}],"manila/share/drivers/hpe/alletra_mp_b10000/hpe_alletra_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":168,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":169,"context_line":"        \"\"\"Remove a share from manila and backend\"\"\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        be_share_id, be_share_name, be_filesystem_name, be_sharesetting_name \\"},{"line_number":172,"context_line":"            \u003d (self.privatestorage_handler.get_share_by_id(share[\u0027id\u0027]))"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.fileshare_handler._compare_values_with_be_share("},{"line_number":175,"context_line":"            be_share_id, be_share_name, be_filesystem_name,"},{"line_number":176,"context_line":"            be_sharesetting_name)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.fileshare_handler.\\"},{"line_number":179,"context_line":"            delete_fileshare_by_id(share[\u0027id\u0027], be_share_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"8c793307_c189b0a8","line":176,"range":{"start_line":171,"start_character":0,"end_line":176,"end_character":33},"updated":"2026-01-13 05:53:48.000000000","message":"Please handle the case where a share doesn\u0027t exist on the back end. For example, a share created through manila has been deleted directly on the storage system. When this is done, and the user deletes the share via manila, these API calls will raise an error which sets the share\u0027s status to \"error_deleting\". \n\nInstead, if a share isn\u0027t found, you can log a warning like you\u0027re doing in case of \"unmanage\" below.","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":169,"context_line":"        \"\"\"Remove a share from manila and backend\"\"\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        be_share_id, be_share_name, be_filesystem_name, be_sharesetting_name \\"},{"line_number":172,"context_line":"            \u003d (self.privatestorage_handler.get_share_by_id(share[\u0027id\u0027]))"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.fileshare_handler._compare_values_with_be_share("},{"line_number":175,"context_line":"            be_share_id, be_share_name, be_filesystem_name,"},{"line_number":176,"context_line":"            be_sharesetting_name)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.fileshare_handler.\\"},{"line_number":179,"context_line":"            delete_fileshare_by_id(share[\u0027id\u0027], be_share_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"a39e2adb_e47cde60","line":176,"range":{"start_line":171,"start_character":0,"end_line":176,"end_character":33},"in_reply_to":"8c793307_c189b0a8","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.privatestorage_handler.delete_share_by_id(share[\u0027id\u0027])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":280,"context_line":"        \"\"\"Ensure shares exist on backend and return their current state."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        Only returns updates for shares that need status changes. Shares that"}],"source_content_type":"text/x-python","patch_set":8,"id":"b17c9309_b34a0ea3","line":279,"range":{"start_line":279,"start_character":8,"end_line":279,"end_character":21},"updated":"2026-01-13 05:53:48.000000000","message":"\"get_backend_info\" must be implemented as well to make this effective. \n\nYou can use any custom logic to implement \"get_backend_info\"; the goal is to allow the driver to determine whether ensure_shares is called. The driver gets to return a dictionary in \"get_backend_info\" and manila\u0027s share manager will hash that data to determine if the ensure_shares routine needs to be executed during startup.\n\nSome drivers return their entire configuration, or specific configuration items and some others request information from the backend storage system to see if a maintenance operation is necessary.","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.privatestorage_handler.delete_share_by_id(share[\u0027id\u0027])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":280,"context_line":"        \"\"\"Ensure shares exist on backend and return their current state."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        Only returns updates for shares that need status changes. Shares that"}],"source_content_type":"text/x-python","patch_set":8,"id":"ae71a0b0_14fe3654","line":279,"range":{"start_line":279,"start_character":8,"end_line":279,"end_character":21},"in_reply_to":"b17c9309_b34a0ea3","updated":"2026-01-19 05:53:31.000000000","message":"Have made the change. Also included some additional documentation to suggest manual ensure shares cli command if customer needs to manually sync export path updates.","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f1eef6bea060bc5a951e354449a4761ffaf13df5","unresolved":true,"context_lines":[{"line_number":239,"context_line":"            # Suppress errors in this case to allow deletion to proceed."},{"line_number":240,"context_line":"            if not access_rules:"},{"line_number":241,"context_line":"                LOG.warning("},{"line_number":242,"context_line":"                    \"Failed to clear share %(share_id)s access rules\""},{"line_number":243,"context_line":"                    \"during deletion: %(error)s. Continuing with deletion.\","},{"line_number":244,"context_line":"                    {\u0027share_id\u0027: share[\u0027id\u0027], \u0027error\u0027: str(e)})"},{"line_number":245,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":10,"id":"dda793c8_b2f2c217","line":242,"range":{"start_line":242,"start_character":68,"end_line":242,"end_character":69},"updated":"2026-01-23 18:55:08.000000000","message":"space before end quotes","commit_id":"54dc0007d26560a7a4366a6d6cada98b308d4bee"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"bb0b45694d5c0900742190d08f093b91608011e4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            # Suppress errors in this case to allow deletion to proceed."},{"line_number":240,"context_line":"            if not access_rules:"},{"line_number":241,"context_line":"                LOG.warning("},{"line_number":242,"context_line":"                    \"Failed to clear share %(share_id)s access rules\""},{"line_number":243,"context_line":"                    \"during deletion: %(error)s. Continuing with deletion.\","},{"line_number":244,"context_line":"                    {\u0027share_id\u0027: share[\u0027id\u0027], \u0027error\u0027: str(e)})"},{"line_number":245,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":10,"id":"78534ad4_d4a44f9a","line":242,"range":{"start_line":242,"start_character":68,"end_line":242,"end_character":69},"in_reply_to":"dda793c8_b2f2c217","updated":"2026-01-27 14:57:00.000000000","message":"Done","commit_id":"54dc0007d26560a7a4366a6d6cada98b308d4bee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7a4dcdf5084ed3d2917583a037cf2310bbe7ede","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.fileshare_handler \u003d None"},{"line_number":65,"context_line":"        self.privatestorage_handler \u003d HPEAlletraPrivateStorageHandler("},{"line_number":66,"context_line":"            kwargs.get(\u0027private_storage\u0027))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def do_setup(self, context):"},{"line_number":69,"context_line":"        \"\"\"Driver initialization\"\"\""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7d196614_72dc72fe","line":67,"updated":"2026-02-05 23:53:26.000000000","message":"I suggest setting some opts so we don\u0027t need the share manager to figure this out:\n\n```\n  self.snapshot_support \u003d False  \n  self.create_share_from_snapshot_support \u003d False\n  self.revert_to_snapshot_support \u003d False\n```","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"aedb1475ed15e1741770cc41561a00394f218671","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.fileshare_handler \u003d None"},{"line_number":65,"context_line":"        self.privatestorage_handler \u003d HPEAlletraPrivateStorageHandler("},{"line_number":66,"context_line":"            kwargs.get(\u0027private_storage\u0027))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def do_setup(self, context):"},{"line_number":69,"context_line":"        \"\"\"Driver initialization\"\"\""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"6f7508a4_6bf62ea1","line":67,"in_reply_to":"7d196614_72dc72fe","updated":"2026-02-10 06:20:15.000000000","message":"Done","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7a4dcdf5084ed3d2917583a037cf2310bbe7ede","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                \"HPE Alletra backend for orphaned share resources and \""},{"line_number":181,"context_line":"                \"remove them manually if present.\","},{"line_number":182,"context_line":"                {\u0027share_id\u0027: share[\u0027id\u0027], \u0027error\u0027: str(e)})"},{"line_number":183,"context_line":"            return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            self.fileshare_handler._compare_values_with_be_share("}],"source_content_type":"text/x-python","patch_set":12,"id":"424bf091_ea9338eb","line":183,"range":{"start_line":183,"start_character":12,"end_line":183,"end_character":18},"updated":"2026-02-05 23:53:26.000000000","message":"don\u0027t you want to still cleanup the private storage?\n\nself.private_storage.delete(share[\u0027id\u0027])","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"aedb1475ed15e1741770cc41561a00394f218671","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                \"HPE Alletra backend for orphaned share resources and \""},{"line_number":181,"context_line":"                \"remove them manually if present.\","},{"line_number":182,"context_line":"                {\u0027share_id\u0027: share[\u0027id\u0027], \u0027error\u0027: str(e)})"},{"line_number":183,"context_line":"            return"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            self.fileshare_handler._compare_values_with_be_share("}],"source_content_type":"text/x-python","patch_set":12,"id":"72915542_2d5551c2","line":183,"range":{"start_line":183,"start_character":12,"end_line":183,"end_character":18},"in_reply_to":"424bf091_ea9338eb","updated":"2026-02-10 06:20:15.000000000","message":"Done","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7a4dcdf5084ed3d2917583a037cf2310bbe7ede","unresolved":true,"context_lines":[{"line_number":438,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":439,"context_line":"            \u0027dedupe\u0027: [True, False],"},{"line_number":440,"context_line":"            \u0027compression\u0027: [True, False],"},{"line_number":441,"context_line":"            \u0027pools\u0027: None,"},{"line_number":442,"context_line":"        }"},{"line_number":443,"context_line":"        # Update the stats"},{"line_number":444,"context_line":"        super(HPEAlletraMPB10000ShareDriver, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":12,"id":"a3867174_4e92feb3","line":441,"range":{"start_line":441,"start_character":13,"end_line":441,"end_character":26},"updated":"2026-02-05 23:53:26.000000000","message":"You\u0027re missing \"reserved_share_percentage\" - it needs to be read and reported from the configuration. An example:\n\n https://opendev.org/openstack/manila/src/commit/33b38fa8763b37c58a99d8dc4ee9a4a81ac723e3/manila/share/drivers/cephfs/driver.py#L385-L386","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"aedb1475ed15e1741770cc41561a00394f218671","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":439,"context_line":"            \u0027dedupe\u0027: [True, False],"},{"line_number":440,"context_line":"            \u0027compression\u0027: [True, False],"},{"line_number":441,"context_line":"            \u0027pools\u0027: None,"},{"line_number":442,"context_line":"        }"},{"line_number":443,"context_line":"        # Update the stats"},{"line_number":444,"context_line":"        super(HPEAlletraMPB10000ShareDriver, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":12,"id":"8d12c629_8e23658d","line":441,"range":{"start_line":441,"start_character":13,"end_line":441,"end_character":26},"in_reply_to":"a3867174_4e92feb3","updated":"2026-02-10 06:20:15.000000000","message":"Done","commit_id":"a05305dd402f5ce7767157e875ac20d2b465a6f4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1253c01d0721eafb0d7df25e457481e49ac10122","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        existing_session_key \u003d None"},{"line_number":102,"context_line":"        if (self.rest_client is not None and"},{"line_number":103,"context_line":"                self.rest_client.session_key is not None):"},{"line_number":104,"context_line":"            existing_session_key \\"},{"line_number":105,"context_line":"                \u003d self.rest_client.session_key"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Initialize rest client"},{"line_number":108,"context_line":"        self.rest_client \u003d rest_client.HpeAlletraRestClient("}],"source_content_type":"text/x-python","patch_set":17,"id":"fb3de778_191dbe2f","line":105,"range":{"start_line":104,"start_character":12,"end_line":105,"end_character":46},"updated":"2026-02-18 11:54:36.000000000","message":"no need for breaking the line here\n```suggestion\n            existing_session_key \u003d self.rest_client.session_key\n```","commit_id":"f0685679e9b43ad7e61f33ad930193e16d654087"}],"manila/share/drivers/hpe/alletra_mp_b10000/rest_client/rest_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f48d6e9c5f17894b8ddec1b9656e50f752a0a3b","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                          \u0027method\u0027: http_method,"},{"line_number":68,"context_line":"                          \u0027url\u0027: http_url,"},{"line_number":69,"context_line":"                          \u0027headers\u0027: headers,"},{"line_number":70,"context_line":"                          \u0027payload\u0027: payload})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _log_http_response(self, status, headers, body):"},{"line_number":73,"context_line":"        \"\"\"Log HTTP response details when debug mode is enabled.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"edfb0b8c_d8dc5599","line":70,"range":{"start_line":70,"start_character":26,"end_line":70,"end_character":46},"updated":"2026-01-13 05:53:48.000000000","message":"please sanitize this, i see that the authenticate method above has self.password added to the info, and that would get logged here if hpealletra_debug\u003dTrue\n\n```\n          safe_payload \u003d payload\n          if payload and \u0027/credentials\u0027 in http_url:\n              try:\n                  data \u003d json.loads(payload)\n                  if \u0027password\u0027 in data:\n                      data \u003d data.copy()\n                      data[\u0027password\u0027] \u003d \u0027***REDACTED***\u0027\n                  safe_payload \u003d json.dumps(data)\n              except (ValueError, TypeError):\n                  pass\n```","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                          \u0027method\u0027: http_method,"},{"line_number":68,"context_line":"                          \u0027url\u0027: http_url,"},{"line_number":69,"context_line":"                          \u0027headers\u0027: headers,"},{"line_number":70,"context_line":"                          \u0027payload\u0027: payload})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _log_http_response(self, status, headers, body):"},{"line_number":73,"context_line":"        \"\"\"Log HTTP response details when debug mode is enabled.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"2d9a5cb2_17f0f4c5","line":70,"range":{"start_line":70,"start_character":26,"end_line":70,"end_character":46},"in_reply_to":"edfb0b8c_d8dc5599","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"}],"manila/tests/share/drivers/hpe/alletra_mp_b10000/fileshare/test_filesetup_handler.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b367cdbebbd2f659cfbf38272d7accd2401bc6e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("}],"source_content_type":"text/x-python","patch_set":8,"id":"814881d0_330a505a","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":25},"updated":"2026-01-13 05:55:41.000000000","message":"https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f57a3f2_115ca3c3","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":25},"in_reply_to":"814881d0_330a505a","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"}],"manila/tests/share/drivers/hpe/alletra_mp_b10000/fileshare/test_fileshare_handler.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b367cdbebbd2f659cfbf38272d7accd2401bc6e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("},{"line_number":23,"context_line":"    fileshare_handler as fileshare"},{"line_number":24,"context_line":")"},{"line_number":25,"context_line":"import manila.share.drivers.hpe.alletra_mp_b10000.fileshare.helpers as helpers"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f25638e_17ec377a","line":25,"range":{"start_line":16,"start_character":0,"end_line":25,"end_character":78},"updated":"2026-01-13 05:55:41.000000000","message":"https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("},{"line_number":23,"context_line":"    fileshare_handler as fileshare"},{"line_number":24,"context_line":")"},{"line_number":25,"context_line":"import manila.share.drivers.hpe.alletra_mp_b10000.fileshare.helpers as helpers"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"6a8b9221_d9543dfb","line":25,"range":{"start_line":16,"start_character":0,"end_line":25,"end_character":78},"in_reply_to":"9f25638e_17ec377a","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"}],"manila/tests/share/drivers/hpe/alletra_mp_b10000/fileshare/test_filesharesetting_handler.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b367cdbebbd2f659cfbf38272d7accd2401bc6e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("},{"line_number":23,"context_line":"    filesharesetting_handler as filesharesetting)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"33a5be57_2589e6a9","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":49},"updated":"2026-01-13 05:55:41.000000000","message":"https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("},{"line_number":23,"context_line":"    filesharesetting_handler as filesharesetting)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6d3c0a4_253f38e4","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":49},"in_reply_to":"33a5be57_2589e6a9","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"}],"manila/tests/share/drivers/hpe/alletra_mp_b10000/fileshare/test_filesystem_handler.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b367cdbebbd2f659cfbf38272d7accd2401bc6e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("},{"line_number":23,"context_line":"    filesystem_handler as filesystem)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"61b9cae7_05b12575","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":37},"updated":"2026-01-13 05:55:41.000000000","message":"https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import ("},{"line_number":23,"context_line":"    filesystem_handler as filesystem)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"cdd9c841_63c7fa7d","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":37},"in_reply_to":"61b9cae7_05b12575","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"}],"manila/tests/share/drivers/hpe/alletra_mp_b10000/fileshare/test_helpers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b367cdbebbd2f659cfbf38272d7accd2401bc6e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":"from oslo_service import loopingcall"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import helpers"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"96968a53_9516bf9e","line":23,"range":{"start_line":15,"start_character":0,"end_line":23,"end_character":72},"updated":"2026-01-13 05:55:41.000000000","message":"fix these up per https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e567b292d0152ad4366ee2f40f17281c580b164f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import ddt"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila import test"},{"line_number":21,"context_line":"from oslo_service import loopingcall"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manila.share.drivers.hpe.alletra_mp_b10000.fileshare import helpers"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"2adde1e5_309ba2f7","line":23,"range":{"start_line":15,"start_character":0,"end_line":23,"end_character":72},"in_reply_to":"96968a53_9516bf9e","updated":"2026-01-19 05:53:31.000000000","message":"Done","commit_id":"738d6b964ee49a5d319a485d33465f9e06c9d824"}]}