)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"37aef9770159beef0d1542714773a29ab89fe640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f20414bc_aa6226e1","updated":"2026-01-12 09:09:16.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3218be13720560b3bad66b3aeb30aabff3253e57"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4a7fbc6587bd22ef81a811194cdc366bf5255233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0899288b_afc100a4","updated":"2026-01-22 08:45:01.000000000","message":"@ces.eduardo98@gmail.com Thanks for the review, will update the patch soon and also merge manage/umanage share and with this patch.","commit_id":"267196ad2fc6ddace842ee8870c11e85d55bc3e5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8ee57e63f87497874c9ec3aadd325ccb0f845ca6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"613b2fd3_6187f49a","updated":"2026-01-20 19:16:24.000000000","message":"Thanks for working on this change, Nilesh! Looks good, but I\u0027d like to ask to please squash it with the shares\u0027 manage/unmanage as I asked in that change.","commit_id":"267196ad2fc6ddace842ee8870c11e85d55bc3e5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2606d26135f344e73d666489a66f931cd450983c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f4ca18b5_e6521f23","updated":"2026-01-28 10:23:03.000000000","message":"Thanks for the review @ces.eduardo98@gmail.com.\n\nHave addressed the review comment also merge the changes with manage/unamange share.","commit_id":"ca09f899716457f5760f744edd03e1e2ab4e78ab"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4fd317caa65d276955b475b96e0a40bdc12eb904","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5835ad97_a258a484","updated":"2026-02-04 20:58:10.000000000","message":"Hey, Nilesh! Thanks for working on this change. Looks good. I looked at the logs from this run [1], more specifically the manage/unmanage tests but they are being skipped. Could you please enable them on your CI and start a new run?\n\nYou\u0027ll need to enable both of these config options [2]\n\n[1] https://github.com/dell/dell-openstack-ci-logs/tree/main/t/openstack/build/581c3f79a3174d51abb81248f18a00b0\n[2] https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/config.py#L282-L291","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4a3886a79f629a6f44dc1acfff815fff94da6b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"92bebca1_c4448111","updated":"2026-02-05 13:07:14.000000000","message":"Just looked at tests results and tests are running and passing. Thanks for doing the job run. About the comment I shared inline, please address it in a follow-up change in case you do not need to submit another patch set","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a01456b2c1ae70f0c28caec9810854ec15b5a7dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"329ac9ae_5c2a9e8a","updated":"2026-02-05 15:35:44.000000000","message":"Please take a look at the comments.","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"dd059c7379bdabab9d59a219a07388d0257e2318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6ca3201f_d139f41c","updated":"2026-02-05 12:01:31.000000000","message":"run-DellEMC PowerScale CI","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"824c136050a5391c057ae36243925999fe528542","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b7b643b4_72d2ef76","updated":"2026-02-05 20:59:18.000000000","message":"Thanks for the review.\n\nRebased on master as ``revert_snap`` will take time.\n\n@ces.eduardo98@gmail.com and @gouthampravi@gmail.com please do a review.","commit_id":"3d917b3338dc7354f10d6ce0f19138d9f716c515"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"87a868bcff3f4c0905b441f58f188443599f683e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f7d2c800_0895f18d","updated":"2026-02-05 21:11:52.000000000","message":"run-DellEMC PowerScale CI","commit_id":"3d917b3338dc7354f10d6ce0f19138d9f716c515"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"26f99a0a0e3e18ccbd69d562eaa44e72f7b39be9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"168b07ef_514000db","updated":"2026-02-05 22:00:01.000000000","message":"run-DellEMC PowerScale CI","commit_id":"cfee53cb55a1e69bbf9c166a3a21679beab73705"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e4cc0b6ba5c1b4a2f90326018265e0cf6fab269e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"30326031_aa804809","updated":"2026-02-09 14:51:44.000000000","message":"LGTM, thanks Nilesh!\n@anoop.shukla@netapp.com - thanks for the review, can you please revisit and share your vote? :)","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"822d33fffc0722c5973d61328c40031939508b0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8c9021a5_44cc427f","updated":"2026-02-06 22:06:35.000000000","message":"LGTM, there are some comments to address if you make another patch, or if you\u0027d like to create a follow up change","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5e3bb009c40f22212cb50ef519b259625a104f0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"45f53be1_c32c40e6","updated":"2026-02-06 04:44:38.000000000","message":"recheck","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"acb33394494ef69f02dfa79bdafb4b6d948a117c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9fad3e8f_f8b6bc09","updated":"2026-02-05 22:12:09.000000000","message":"run-DellEMC PowerScale CI","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"020727c1b5c17dc33586e29e7fbc1f5e1b60eb06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dfdef0c6_111ca04d","updated":"2026-02-12 21:06:53.000000000","message":"Let\u0027s get this in so the series of changes can begin to merge.","commit_id":"a4c93dd315ee84004ee13654ba304e620ccf046b"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1c891a7e05a636465ca31f00f1ebc8d1d29ad5a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c51ea5e5_0d59fee7","updated":"2026-02-13 04:04:01.000000000","message":"Thanks @ces.eduardo98@gmail.com and @gouthampravi@gmail.com for the review.","commit_id":"a4c93dd315ee84004ee13654ba304e620ccf046b"}],"doc/source/configuration/shared-file-systems/drivers/dell-emc-powerscale-driver.rst":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8ee57e63f87497874c9ec3aadd325ccb0f845ca6","unresolved":true,"context_lines":[{"line_number":121,"context_line":"share is existing in OpenStack, otherwise need to manage share first."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    .. code-block:: console"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        $ manila snapshot-manage --name ${name} ${share_id} ${provider_location} --driver_options size\u003d${snapshot_size}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    .. note::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ea7f46c_098a18e8","line":124,"updated":"2026-01-20 19:16:24.000000000","message":"please add the reference to the admin doc as pointed in the other change","commit_id":"267196ad2fc6ddace842ee8870c11e85d55bc3e5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2606d26135f344e73d666489a66f931cd450983c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"share is existing in OpenStack, otherwise need to manage share first."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    .. code-block:: console"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        $ manila snapshot-manage --name ${name} ${share_id} ${provider_location} --driver_options size\u003d${snapshot_size}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    .. note::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa395139_04b2e73d","line":124,"in_reply_to":"9ea7f46c_098a18e8","updated":"2026-01-28 10:23:03.000000000","message":"Done","commit_id":"267196ad2fc6ddace842ee8870c11e85d55bc3e5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f7d42299c5b7ecc058a808dde09cc710d41f4a29","unresolved":true,"context_lines":[{"line_number":115,"context_line":"~~~~~~~~~~~~~~"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Overview"},{"line_number":118,"context_line":"--------"},{"line_number":119,"context_line":"Shrinking reduces the size (GiB) of an existing Manila share to a"},{"line_number":120,"context_line":"smaller value. The operation enforces quota limits and rejects invalid"},{"line_number":121,"context_line":"sizes (e.g., 0 or any value greater than the current size)."}],"source_content_type":"text/x-rst","patch_set":13,"id":"1548a77e_14a5e1f5","line":118,"updated":"2026-02-05 22:11:54.000000000","message":"Getting local pep8 error so resolved over here.","commit_id":"cfee53cb55a1e69bbf9c166a3a21679beab73705"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"822d33fffc0722c5973d61328c40031939508b0d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"~~~~~~~~~~~~~~"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Overview"},{"line_number":118,"context_line":"--------"},{"line_number":119,"context_line":"Shrinking reduces the size (GiB) of an existing Manila share to a"},{"line_number":120,"context_line":"smaller value. The operation enforces quota limits and rejects invalid"},{"line_number":121,"context_line":"sizes (e.g., 0 or any value greater than the current size)."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fbbdd44_5ee9b9e1","line":118,"in_reply_to":"1548a77e_14a5e1f5","updated":"2026-02-06 22:06:35.000000000","message":"Good stuff, I\u0027d just drop these section headers as suggested on the change that introduced it. It clutters the docs","commit_id":"cfee53cb55a1e69bbf9c166a3a21679beab73705"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f7d42299c5b7ecc058a808dde09cc710d41f4a29","unresolved":true,"context_lines":[{"line_number":121,"context_line":"sizes (e.g., 0 or any value greater than the current size)."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Limitations and behavior"},{"line_number":124,"context_line":"------------------------"},{"line_number":125,"context_line":"* New size must be a positive integer **less than** the current size and"},{"line_number":126,"context_line":"  within quotas."},{"line_number":127,"context_line":"* During the operation, the share status transitions to **shrinking**"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5243bf4b_cb3c247b","line":124,"updated":"2026-02-05 22:11:54.000000000","message":"Getting local pep8 error so resolved over here.","commit_id":"cfee53cb55a1e69bbf9c166a3a21679beab73705"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"822d33fffc0722c5973d61328c40031939508b0d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"sizes (e.g., 0 or any value greater than the current size)."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Limitations and behavior"},{"line_number":124,"context_line":"------------------------"},{"line_number":125,"context_line":"* New size must be a positive integer **less than** the current size and"},{"line_number":126,"context_line":"  within quotas."},{"line_number":127,"context_line":"* During the operation, the share status transitions to **shrinking**"}],"source_content_type":"text/x-rst","patch_set":13,"id":"16f1dbb1_b0f424e9","line":124,"in_reply_to":"5243bf4b_cb3c247b","updated":"2026-02-06 22:06:35.000000000","message":"Done","commit_id":"cfee53cb55a1e69bbf9c166a3a21679beab73705"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"822d33fffc0722c5973d61328c40031939508b0d","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"To Manage and Unmanage an existing share snapshot"},{"line_number":146,"context_line":"-------------------------------------------------"},{"line_number":147,"context_line":"To manage a snapshot existing in PowerScale System, you need make sure the related"},{"line_number":148,"context_line":"share is existing in OpenStack, otherwise need to manage share first."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"For detailed usage instructions, refer to the Manila administration"}],"source_content_type":"text/x-rst","patch_set":14,"id":"df32e7b1_12d02c07","line":147,"range":{"start_line":147,"start_character":52,"end_line":147,"end_character":70},"updated":"2026-02-06 22:06:35.000000000","message":"you need to make sure\n\n\n(also, can you wrap text at 79 characters)","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a060ed9eca61625adf0b2c3a8e62ecf818822744","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"To Manage and Unmanage an existing share snapshot"},{"line_number":146,"context_line":"-------------------------------------------------"},{"line_number":147,"context_line":"To manage a snapshot existing in PowerScale System, you need make sure the related"},{"line_number":148,"context_line":"share is existing in OpenStack, otherwise need to manage share first."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"For detailed usage instructions, refer to the Manila administration"}],"source_content_type":"text/x-rst","patch_set":14,"id":"335bb905_b20ac405","line":147,"range":{"start_line":147,"start_character":52,"end_line":147,"end_character":70},"in_reply_to":"df32e7b1_12d02c07","updated":"2026-02-10 05:46:55.000000000","message":"sure, will do it in follow up patch.","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"822d33fffc0722c5973d61328c40031939508b0d","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"For detailed usage instructions, refer to the Manila administration"},{"line_number":151,"context_line":"documentation:"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":":doc:`/admin/shared-file-systems-manage-and-unmanage-snapshot`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"cf0db9e5_420102d8","line":152,"updated":"2026-02-06 22:06:35.000000000","message":"It appears that the size can be specified via driver options. It\u0027d be nice to call that out here.","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a060ed9eca61625adf0b2c3a8e62ecf818822744","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"For detailed usage instructions, refer to the Manila administration"},{"line_number":151,"context_line":"documentation:"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":":doc:`/admin/shared-file-systems-manage-and-unmanage-snapshot`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"b9646e5f_5f39a326","line":152,"in_reply_to":"cf0db9e5_420102d8","updated":"2026-02-10 05:46:55.000000000","message":"sure, will do it in follow up patch","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"}],"manila/share/drivers/dell_emc/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"822d33fffc0722c5973d61328c40031939508b0d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if self.manage_existing_support:"},{"line_number":121,"context_line":"            return self.plugin.manage_existing(share, driver_options)"},{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            raise NotImplementedError()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def manage_existing_with_server(self, share, driver_options,"},{"line_number":126,"context_line":"                                    share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"39446ab7_c08610f6","line":123,"updated":"2026-02-06 22:06:35.000000000","message":"good fix","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4fd317caa65d276955b475b96e0a40bdc12eb904","unresolved":true,"context_lines":[{"line_number":720,"context_line":"        provider_location \u003d snapshot.get(\u0027provider_location\u0027)"},{"line_number":721,"context_line":"        snap \u003d self._powerscale_api.get_snapshot_id(provider_location)"},{"line_number":722,"context_line":"        if not snap:"},{"line_number":723,"context_line":"            message \u003d (\"Could not find a snapshot in the backend with \""},{"line_number":724,"context_line":"                       \"provider_location: %s, please make sure \""},{"line_number":725,"context_line":"                       \"the snapshot exists in the backend.\""},{"line_number":726,"context_line":"                       % provider_location)"},{"line_number":727,"context_line":"            LOG.error(message)"},{"line_number":728,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":729,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"}],"source_content_type":"text/x-python","patch_set":9,"id":"922023ad_720043ce","line":726,"range":{"start_line":723,"start_character":12,"end_line":726,"end_character":43},"updated":"2026-02-04 20:58:10.000000000","message":"maybe we should reword this to snapshot id, or in a way that links the provider location and the snapshot ID that is being used for the query\n\n\n\n\n```suggestion\n            message \u003d (\"Could not find a snapshot in the backend with \"\n                       \"ID: %s, please make sure \"\n                       \"the snapshot exists in the backend.\"\n                       % provider_location)\n```","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"824c136050a5391c057ae36243925999fe528542","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        provider_location \u003d snapshot.get(\u0027provider_location\u0027)"},{"line_number":721,"context_line":"        snap \u003d self._powerscale_api.get_snapshot_id(provider_location)"},{"line_number":722,"context_line":"        if not snap:"},{"line_number":723,"context_line":"            message \u003d (\"Could not find a snapshot in the backend with \""},{"line_number":724,"context_line":"                       \"provider_location: %s, please make sure \""},{"line_number":725,"context_line":"                       \"the snapshot exists in the backend.\""},{"line_number":726,"context_line":"                       % provider_location)"},{"line_number":727,"context_line":"            LOG.error(message)"},{"line_number":728,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":729,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"}],"source_content_type":"text/x-python","patch_set":9,"id":"7e3c4596_078e134c","line":726,"range":{"start_line":723,"start_character":12,"end_line":726,"end_character":43},"in_reply_to":"922023ad_720043ce","updated":"2026-02-05 20:59:18.000000000","message":"Done","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a01456b2c1ae70f0c28caec9810854ec15b5a7dc","unresolved":true,"context_lines":[{"line_number":728,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":729,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"},{"line_number":730,"context_line":"              self._get_container_path(snapshot[\u0027share\u0027])):"},{"line_number":731,"context_line":"            message \u003d \"Snapshot is not belong to the given share\""},{"line_number":732,"context_line":"            LOG.error(message)"},{"line_number":733,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":734,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"80210526_a26ce2bc","line":731,"updated":"2026-02-05 15:35:44.000000000","message":"May be reword to - \"Snapshot does not belong to the given share %s\" - where %s can be the share name.","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"824c136050a5391c057ae36243925999fe528542","unresolved":false,"context_lines":[{"line_number":728,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":729,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"},{"line_number":730,"context_line":"              self._get_container_path(snapshot[\u0027share\u0027])):"},{"line_number":731,"context_line":"            message \u003d \"Snapshot is not belong to the given share\""},{"line_number":732,"context_line":"            LOG.error(message)"},{"line_number":733,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":734,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fcb53be1_9da8e2ba","line":731,"in_reply_to":"80210526_a26ce2bc","updated":"2026-02-05 20:59:18.000000000","message":"Done","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"822d33fffc0722c5973d61328c40031939508b0d","unresolved":true,"context_lines":[{"line_number":699,"context_line":"                       % provider_location)"},{"line_number":700,"context_line":"            LOG.error(message)"},{"line_number":701,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":702,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"},{"line_number":703,"context_line":"              self._get_container_path(snapshot[\u0027share\u0027])):"},{"line_number":704,"context_line":"            message \u003d (\"Snapshot does not belong to the given share %s.\""},{"line_number":705,"context_line":"                       % snapshot[\u0027share\u0027][\u0027name\u0027])"},{"line_number":706,"context_line":"            LOG.error(message)"},{"line_number":707,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            snapshot_size \u003d int(driver_options.get(\"size\", 0))"}],"source_content_type":"text/x-python","patch_set":14,"id":"63007cb9_91466f82","line":706,"range":{"start_line":702,"start_character":0,"end_line":706,"end_character":30},"updated":"2026-02-06 22:06:35.000000000","message":"Do you need the same kind of validation to the \"manage_existing\" method as well?\n\nAfter you establish the backend_quota_path, looks like you can validate that against the container path?\n\n```\n  expected_path \u003d self._get_container_path(share)\n  if backend_quota_path !\u003d expected_path:\n      raise exception.ManageInvalidShare(\n          reason\u003df\"Export path {backend_quota_path} does not match \"\n                 f\"driver container path {expected_path}. This would \"\n                 f\"cause extend/shrink operations to fail.\"\n      )\n```","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"fd01d021b6a9769ae2ecff67485512a461988363","unresolved":true,"context_lines":[{"line_number":699,"context_line":"                       % provider_location)"},{"line_number":700,"context_line":"            LOG.error(message)"},{"line_number":701,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":702,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"},{"line_number":703,"context_line":"              self._get_container_path(snapshot[\u0027share\u0027])):"},{"line_number":704,"context_line":"            message \u003d (\"Snapshot does not belong to the given share %s.\""},{"line_number":705,"context_line":"                       % snapshot[\u0027share\u0027][\u0027name\u0027])"},{"line_number":706,"context_line":"            LOG.error(message)"},{"line_number":707,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            snapshot_size \u003d int(driver_options.get(\"size\", 0))"}],"source_content_type":"text/x-python","patch_set":14,"id":"88ff0c94_d1c1abc8","line":706,"range":{"start_line":702,"start_character":0,"end_line":706,"end_character":30},"in_reply_to":"63007cb9_91466f82","updated":"2026-02-10 11:35:39.000000000","message":"@gouthampravi@gmail.com\nThis isn’t possible. The container_path is derived from the share_id, which does not match the backend_quota_path. That never possible becuase share-id getting generated during adopt call. Because of this mismatch, we’re seeing issues with extend/shrink operations as well as share deletion.\n\nShould this be addressed as part of this patch, or should we file a bug and handle it in a follow-up patch?","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"ae6e6252a4a5fbbdd190d2c9396ce499caa34262","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                       % provider_location)"},{"line_number":700,"context_line":"            LOG.error(message)"},{"line_number":701,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":702,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"},{"line_number":703,"context_line":"              self._get_container_path(snapshot[\u0027share\u0027])):"},{"line_number":704,"context_line":"            message \u003d (\"Snapshot does not belong to the given share %s.\""},{"line_number":705,"context_line":"                       % snapshot[\u0027share\u0027][\u0027name\u0027])"},{"line_number":706,"context_line":"            LOG.error(message)"},{"line_number":707,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            snapshot_size \u003d int(driver_options.get(\"size\", 0))"}],"source_content_type":"text/x-python","patch_set":14,"id":"bc9266cc_a5a0d783","line":706,"range":{"start_line":702,"start_character":0,"end_line":706,"end_character":30},"in_reply_to":"88ff0c94_d1c1abc8","updated":"2026-02-12 09:17:00.000000000","message":"Hi team, I have added this validation in a follow up patch as a bug fix-\nBug - https://bugs.launchpad.net/manila/+bug/2141517\nPatch - https://review.opendev.org/c/openstack/manila/+/976586\nPlease have a look into it and review it.","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"020727c1b5c17dc33586e29e7fbc1f5e1b60eb06","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                       % provider_location)"},{"line_number":700,"context_line":"            LOG.error(message)"},{"line_number":701,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":702,"context_line":"        elif (snap[\u0027path\u0027] !\u003d"},{"line_number":703,"context_line":"              self._get_container_path(snapshot[\u0027share\u0027])):"},{"line_number":704,"context_line":"            message \u003d (\"Snapshot does not belong to the given share %s.\""},{"line_number":705,"context_line":"                       % snapshot[\u0027share\u0027][\u0027name\u0027])"},{"line_number":706,"context_line":"            LOG.error(message)"},{"line_number":707,"context_line":"            raise exception.ManageInvalidShareSnapshot(reason\u003dmessage)"},{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            snapshot_size \u003d int(driver_options.get(\"size\", 0))"}],"source_content_type":"text/x-python","patch_set":14,"id":"651ddccd_89e8638c","line":706,"range":{"start_line":702,"start_character":0,"end_line":706,"end_character":30},"in_reply_to":"bc9266cc_a5a0d783","updated":"2026-02-12 21:06:53.000000000","message":"For future reference, You don\u0027t need to file a bug for something that\u0027s not \"released\" yet.","commit_id":"dd79f8a234bb1de36eeb771cffc758bf07074fe3"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale_api.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a01456b2c1ae70f0c28caec9810854ec15b5a7dc","unresolved":true,"context_lines":[{"line_number":187,"context_line":"        if r.status_code \u003d\u003d 200:"},{"line_number":188,"context_line":"            return snapshot_json[\u0027snapshots\u0027][0]"},{"line_number":189,"context_line":"        elif r.status_code \u003d\u003d 404:"},{"line_number":190,"context_line":"            return None"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            r.raise_for_status()"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"40c7a37a_36564d01","line":190,"updated":"2026-02-05 15:35:44.000000000","message":"Shouldn\u0027t we throw error in this case as well?","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"824c136050a5391c057ae36243925999fe528542","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if r.status_code \u003d\u003d 200:"},{"line_number":188,"context_line":"            return snapshot_json[\u0027snapshots\u0027][0]"},{"line_number":189,"context_line":"        elif r.status_code \u003d\u003d 404:"},{"line_number":190,"context_line":"            return None"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            r.raise_for_status()"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"8f01c627_3d215483","line":190,"in_reply_to":"40c7a37a_36564d01","updated":"2026-02-05 20:59:18.000000000","message":"I will handle ``powerscale.py`` side","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a01456b2c1ae70f0c28caec9810854ec15b5a7dc","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        response \u003d self.send_delete_request("},{"line_number":310,"context_line":"            \u0027{0}/platform/1/snapshot/snapshots/{1}\u0027"},{"line_number":311,"context_line":"            .format(self.host_url, snapshot_id))"},{"line_number":312,"context_line":"        return response.status_code \u003d\u003d 204"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def quota_create(self, path, quota_type, size):"},{"line_number":315,"context_line":"        thresholds \u003d {\u0027hard\u0027: size}"}],"source_content_type":"text/x-python","patch_set":9,"id":"a8615e4f_e5d265c5","line":312,"updated":"2026-02-05 15:35:44.000000000","message":"As discussed in the mid cycle - I think we should have handling of status codes in a common method. May be a point to note for a tech debt consideration.","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"824c136050a5391c057ae36243925999fe528542","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        response \u003d self.send_delete_request("},{"line_number":310,"context_line":"            \u0027{0}/platform/1/snapshot/snapshots/{1}\u0027"},{"line_number":311,"context_line":"            .format(self.host_url, snapshot_id))"},{"line_number":312,"context_line":"        return response.status_code \u003d\u003d 204"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def quota_create(self, path, quota_type, size):"},{"line_number":315,"context_line":"        thresholds \u003d {\u0027hard\u0027: size}"}],"source_content_type":"text/x-python","patch_set":9,"id":"caff582e_06b55e0b","line":312,"in_reply_to":"a8615e4f_e5d265c5","updated":"2026-02-05 20:59:18.000000000","message":"Sure, will consider this in future.","commit_id":"e2e5a04ea9bf71903645bd00294b8f4fdf5665ab"}]}