)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59277f1cb9b7b84c9eaa02de195a00854a7c6a0d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerScale Manila: Add manage/unmanage share support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for managing and unmanaging existing shares in the Dell EMC PowerScale driver."},{"line_number":10,"context_line":"It introduces logic to register shares with Manila using OneFS REST API and to unmanage shares without deleting data."},{"line_number":11,"context_line":"Unit tests are included to validate these operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint dell-powerscale-manage-unmanage-share"},{"line_number":14,"context_line":"Change-Id: Id75b31ac2c10c949f2a49ca28302349bb2295fe4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"29d20917_ce5b7acf","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"updated":"2026-01-20 18:58:05.000000000","message":"nit: please wrap lines at 72 characters, as defined in [1]\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"a9d9187bcec6945bae2a5aa5a8a25d525fe0238d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerScale Manila: Add manage/unmanage share support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for managing and unmanaging existing shares in the Dell EMC PowerScale driver."},{"line_number":10,"context_line":"It introduces logic to register shares with Manila using OneFS REST API and to unmanage shares without deleting data."},{"line_number":11,"context_line":"Unit tests are included to validate these operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint dell-powerscale-manage-unmanage-share"},{"line_number":14,"context_line":"Change-Id: Id75b31ac2c10c949f2a49ca28302349bb2295fe4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"46d228d9_d6b099d1","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"29d20917_ce5b7acf","updated":"2026-01-28 08:56:34.000000000","message":"Done","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"5f08af87c448b956c42f0e0ea87c14704e2aa0d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d54aa0e4_9b028da2","updated":"2026-01-08 06:31:05.000000000","message":"Thank you for adding this feature! I\u0027m also interested in this topic, so I left some comments. Could you please take a look and share your thoughts?","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d554ccb3_642e4a78","updated":"2026-01-08 20:48:37.000000000","message":"Thanks you for working on this patch. Please take a look on comments.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59277f1cb9b7b84c9eaa02de195a00854a7c6a0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31c5698f_2d772e77","updated":"2026-01-20 18:58:05.000000000","message":"Hey, thanks for working on this change. Please take a look at the comments inline.\nAlso, we have functional tests for manage/unmanage in place. Could you please enable those in the Dell CI for this change?","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85774358c05cc7d7f7b8bb8e3c4e2310d98bed14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"878b9026_66ac5ef5","updated":"2026-01-20 19:01:34.000000000","message":"Something I forgot to mention: can you please squash the two manage/unmanage changes (this and snapshot)? I think this is a better approach, considering it\u0027s a driver feature and both are the same subject.","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"cc0c3a9b312fb9e3db5a25525394baa12dd5b4b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bd804888_c4b1ce47","updated":"2026-01-27 10:36:17.000000000","message":"run-DellEMC PowerScale CI","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"32f7341deb8a3f012295bc75f7c0cd778e0e574b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5f08704b_27654ccc","updated":"2026-01-28 08:56:12.000000000","message":"Manage/unmanage share and manage/unmanage snapshot changes have been squashed into a single patch: [https://review.opendev.org/c/openstack/manila/+/972278]","commit_id":"4a90c01a0e63466772a32b92f3047e9ae167d3f8"}],"doc/source/admin/dell_emc_powerscale_driver.rst":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":50,"context_line":"* Delete snapshot"},{"line_number":51,"context_line":"* Create share from snapshot"},{"line_number":52,"context_line":"* Extend share"},{"line_number":53,"context_line":"* Manage and Unmanage CIFS/NFS share"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Backend Configuration"},{"line_number":56,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d3e1d7c4_6ff06acd","line":53,"updated":"2026-01-08 20:48:37.000000000","message":"this is not right file to update driver details\n\nactual file is at location ``doc/source/configuration/shared-file-systems/drivers/dell-emc-powerscale-driver.rst``.\n\nAlso please add section of Manage and Unmanage CIFS/NFS share which explain feature.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":50,"context_line":"* Delete snapshot"},{"line_number":51,"context_line":"* Create share from snapshot"},{"line_number":52,"context_line":"* Extend share"},{"line_number":53,"context_line":"* Manage and Unmanage CIFS/NFS share"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Backend Configuration"},{"line_number":56,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8a12d9bc_45869eaa","line":53,"in_reply_to":"d3e1d7c4_6ff06acd","updated":"2026-01-16 10:10:57.000000000","message":"done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"}],"doc/source/configuration/shared-file-systems/drivers/dell-emc-powerscale-driver.rst":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59277f1cb9b7b84c9eaa02de195a00854a7c6a0d","unresolved":true,"context_lines":[{"line_number":99,"context_line":"-------------------------------------------------------"},{"line_number":100,"context_line":".. code-block:: console"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  # NFS: import an existing export into Manila"},{"line_number":103,"context_line":"  openstack share adopt \\"},{"line_number":104,"context_line":"    \u003chost@backend#pool\u003e \\"},{"line_number":105,"context_line":"    NFS \\"},{"line_number":106,"context_line":"    \u003cshare-path\u003e \\"},{"line_number":107,"context_line":"    --share-type \u003cshare-type\u003e \\"},{"line_number":108,"context_line":"    --name \u003cshare-name\u003e"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  # CIFS: import an existing SMB share into Manila"},{"line_number":111,"context_line":"  openstack share adopt \\"},{"line_number":112,"context_line":"    \u003chost@backend#pool\u003e \\"},{"line_number":113,"context_line":"    CIFS \\"},{"line_number":114,"context_line":"    \u003cshare-path\u003e \\"},{"line_number":115,"context_line":"    --share-type \u003cshare-type\u003e \\"},{"line_number":116,"context_line":"    --name \u003cshare-name\u003e"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Manage existing share – manila CLI (legacy environments)"},{"line_number":119,"context_line":"--------------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f48b174_9704f283","line":116,"range":{"start_line":102,"start_character":2,"end_line":116,"end_character":23},"updated":"2026-01-20 18:58:05.000000000","message":"I think we can avoid adding this (and the below) command here, as we already have it in [1] and apparently there are no specifics. Please add a mention to refer to [1] and just share the specifics to the driver if necessary.\n\n[2] https://docs.openstack.org/manila/latest/admin/shared-file-systems-manage-and-unmanage-share.html","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"a9d9187bcec6945bae2a5aa5a8a25d525fe0238d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"-------------------------------------------------------"},{"line_number":100,"context_line":".. code-block:: console"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  # NFS: import an existing export into Manila"},{"line_number":103,"context_line":"  openstack share adopt \\"},{"line_number":104,"context_line":"    \u003chost@backend#pool\u003e \\"},{"line_number":105,"context_line":"    NFS \\"},{"line_number":106,"context_line":"    \u003cshare-path\u003e \\"},{"line_number":107,"context_line":"    --share-type \u003cshare-type\u003e \\"},{"line_number":108,"context_line":"    --name \u003cshare-name\u003e"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  # CIFS: import an existing SMB share into Manila"},{"line_number":111,"context_line":"  openstack share adopt \\"},{"line_number":112,"context_line":"    \u003chost@backend#pool\u003e \\"},{"line_number":113,"context_line":"    CIFS \\"},{"line_number":114,"context_line":"    \u003cshare-path\u003e \\"},{"line_number":115,"context_line":"    --share-type \u003cshare-type\u003e \\"},{"line_number":116,"context_line":"    --name \u003cshare-name\u003e"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Manage existing share – manila CLI (legacy environments)"},{"line_number":119,"context_line":"--------------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ebc29f32_aae9591c","line":116,"range":{"start_line":102,"start_character":2,"end_line":116,"end_character":23},"in_reply_to":"3f48b174_9704f283","updated":"2026-01-28 08:56:34.000000000","message":"Done","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"}],"manila/share/drivers/dell_emc/driver.py":[{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"838cbbb8250e2de996ab0d23e5bac6741659ac8b","unresolved":true,"context_lines":[{"line_number":102,"context_line":"            self.plugin, \u0027revert_to_snap_support\u0027, False)"},{"line_number":103,"context_line":"        self.shrink_share_support \u003d getattr("},{"line_number":104,"context_line":"            self.plugin, \u0027shrink_share_support\u0027, False)"},{"line_number":105,"context_line":"        self.manage_existing_support \u003d getattr("},{"line_number":106,"context_line":"            self.plugin, \u0027manage_existing_support\u0027, False)"},{"line_number":107,"context_line":"        self.manage_existing_with_server_support \u003d getattr("},{"line_number":108,"context_line":"            self.plugin, \u0027manage_existing_with_server_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8233f69f_be0d17cc","side":"PARENT","line":105,"updated":"2026-01-08 04:22:09.000000000","message":"I guess that removing this code is not a right way because Dell drivers like powermax, vnx, powerstore are still not implemented.","commit_id":"5122362344c8c51c1de117ae275109fc27e1dc07"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            self.plugin, \u0027revert_to_snap_support\u0027, False)"},{"line_number":103,"context_line":"        self.shrink_share_support \u003d getattr("},{"line_number":104,"context_line":"            self.plugin, \u0027shrink_share_support\u0027, False)"},{"line_number":105,"context_line":"        self.manage_existing_support \u003d getattr("},{"line_number":106,"context_line":"            self.plugin, \u0027manage_existing_support\u0027, False)"},{"line_number":107,"context_line":"        self.manage_existing_with_server_support \u003d getattr("},{"line_number":108,"context_line":"            self.plugin, \u0027manage_existing_with_server_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6aa3077f_e630b035","side":"PARENT","line":105,"in_reply_to":"15dfe20d_fcc932f9","updated":"2026-01-16 10:10:57.000000000","message":"Fixed","commit_id":"5122362344c8c51c1de117ae275109fc27e1dc07"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":102,"context_line":"            self.plugin, \u0027revert_to_snap_support\u0027, False)"},{"line_number":103,"context_line":"        self.shrink_share_support \u003d getattr("},{"line_number":104,"context_line":"            self.plugin, \u0027shrink_share_support\u0027, False)"},{"line_number":105,"context_line":"        self.manage_existing_support \u003d getattr("},{"line_number":106,"context_line":"            self.plugin, \u0027manage_existing_support\u0027, False)"},{"line_number":107,"context_line":"        self.manage_existing_with_server_support \u003d getattr("},{"line_number":108,"context_line":"            self.plugin, \u0027manage_existing_with_server_support\u0027, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"15dfe20d_fcc932f9","side":"PARENT","line":105,"in_reply_to":"8233f69f_be0d17cc","updated":"2026-01-08 20:48:37.000000000","message":"Agree. Don\u0027t need to remove this, this is used by other drivers which does not implemented manage.","commit_id":"5122362344c8c51c1de117ae275109fc27e1dc07"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"838cbbb8250e2de996ab0d23e5bac6741659ac8b","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":117,"context_line":"        \"\"\"manage an existing share\"\"\""},{"line_number":118,"context_line":"        return self.plugin.manage_existing(share, driver_options)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def manage_existing_with_server(self, share, driver_options,"},{"line_number":121,"context_line":"                                    share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"cf687825_311c6def","line":118,"updated":"2026-01-08 04:22:09.000000000","message":"So I think the `AttributeError` will be raised here when calling manage with those drivers(powermax, vnx, powerstore, powerflex..)","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":117,"context_line":"        \"\"\"manage an existing share\"\"\""},{"line_number":118,"context_line":"        return self.plugin.manage_existing(share, driver_options)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def manage_existing_with_server(self, share, driver_options,"},{"line_number":121,"context_line":"                                    share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bd3a55e1_86c8c307","line":118,"in_reply_to":"2f926c9a_ccc6d756","updated":"2026-01-16 10:10:57.000000000","message":"Fixed","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":117,"context_line":"        \"\"\"manage an existing share\"\"\""},{"line_number":118,"context_line":"        return self.plugin.manage_existing(share, driver_options)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def manage_existing_with_server(self, share, driver_options,"},{"line_number":121,"context_line":"                                    share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f926c9a_ccc6d756","line":118,"in_reply_to":"cf687825_311c6def","updated":"2026-01-08 20:48:37.000000000","message":"Agree, do not remove this section, keep as it is, it will create an error for other drivers.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    def unmanage(self, share):"},{"line_number":167,"context_line":"        LOG.info(\u0027Dell EMC driver will unmanage share: %s out of \u0027"},{"line_number":168,"context_line":"                 \u0027OpenStack.\u0027, share.get(\u0027id\u0027))"},{"line_number":169,"context_line":"        return self.plugin.unmanage(share)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def unmanage_with_server(self, share, share_server\u003dNone):"},{"line_number":172,"context_line":"        LOG.info(\u0027Dell EMC driver will unmanage share: %s out of \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c11f1e7_41a0123b","line":169,"updated":"2026-01-08 20:48:37.000000000","message":"I think this is not required, and implementation in driver code.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def unmanage(self, share):"},{"line_number":167,"context_line":"        LOG.info(\u0027Dell EMC driver will unmanage share: %s out of \u0027"},{"line_number":168,"context_line":"                 \u0027OpenStack.\u0027, share.get(\u0027id\u0027))"},{"line_number":169,"context_line":"        return self.plugin.unmanage(share)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def unmanage_with_server(self, share, share_server\u003dNone):"},{"line_number":172,"context_line":"        LOG.info(\u0027Dell EMC driver will unmanage share: %s out of \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"eed40fe4_0f8e7242","line":169,"in_reply_to":"4c11f1e7_41a0123b","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale.py":[{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"838cbbb8250e2de996ab0d23e5bac6741659ac8b","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        self.reserved_snapshot_percentage \u003d None"},{"line_number":86,"context_line":"        self.reserved_share_extend_percentage \u003d None"},{"line_number":87,"context_line":"        self.max_over_subscription_ratio \u003d None"},{"line_number":88,"context_line":"        self._threshold_limit \u003d 0"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _get_container_path(self, share):"},{"line_number":91,"context_line":"        \"\"\"Return path to a container.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1d16e3b2_201c972c","line":88,"updated":"2026-01-08 04:22:09.000000000","message":"Instead of the above changes in the `driver.py` file, I suggest setting the manage_existing_support option of powerscale to true here.\n\n```suggestion\n        self._threshold_limit \u003d 0\n        self.manage_existing_support \u003d True\n```","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        self.reserved_snapshot_percentage \u003d None"},{"line_number":86,"context_line":"        self.reserved_share_extend_percentage \u003d None"},{"line_number":87,"context_line":"        self.max_over_subscription_ratio \u003d None"},{"line_number":88,"context_line":"        self._threshold_limit \u003d 0"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _get_container_path(self, share):"},{"line_number":91,"context_line":"        \"\"\"Return path to a container.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff840580_bba6ad30","line":88,"in_reply_to":"1d16e3b2_201c972c","updated":"2026-01-08 20:48:37.000000000","message":"Agree.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.reserved_snapshot_percentage \u003d None"},{"line_number":86,"context_line":"        self.reserved_share_extend_percentage \u003d None"},{"line_number":87,"context_line":"        self.max_over_subscription_ratio \u003d None"},{"line_number":88,"context_line":"        self._threshold_limit \u003d 0"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _get_container_path(self, share):"},{"line_number":91,"context_line":"        \"\"\"Return path to a container.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"eea71867_187eb933","line":88,"in_reply_to":"ff840580_bba6ad30","updated":"2026-01-16 10:10:57.000000000","message":"Fixed","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":285,"context_line":"        new_quota_size \u003d new_size * units.Gi"},{"line_number":286,"context_line":"        self._powerscale_api.quota_set("},{"line_number":287,"context_line":"            self._get_container_path(share), \u0027directory\u0027, new_quota_size)"},{"line_number":288,"context_line":"       "},{"line_number":289,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":290,"context_line":"        \"\"\"Import an external NFS/CIFS share into Manila.\"\"\""},{"line_number":291,"context_line":"        export_path \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"91a90527_d4a3d192","line":288,"updated":"2026-01-08 20:48:37.000000000","message":"Correct this.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        new_quota_size \u003d new_size * units.Gi"},{"line_number":286,"context_line":"        self._powerscale_api.quota_set("},{"line_number":287,"context_line":"            self._get_container_path(share), \u0027directory\u0027, new_quota_size)"},{"line_number":288,"context_line":"       "},{"line_number":289,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":290,"context_line":"        \"\"\"Import an external NFS/CIFS share into Manila.\"\"\""},{"line_number":291,"context_line":"        export_path \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"39ef9a46_e9a0cc92","line":288,"in_reply_to":"91a90527_d4a3d192","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"f5190332a6b6bf53f83313178d453462256566db","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        export_path \u003d ("},{"line_number":292,"context_line":"            share.get(\u0027export_location\u0027)"},{"line_number":293,"context_line":"            or share.get(\u0027export_locations\u0027, [None])[0]"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        protocol \u003d share.get(\u0027share_proto\u0027).upper()"},{"line_number":296,"context_line":"        LOG.info("},{"line_number":297,"context_line":"            \"Managing existing share with protocol: %s, export path: %s\","}],"source_content_type":"text/x-python","patch_set":4,"id":"e690385c_63ee13ea","line":294,"updated":"2026-01-08 06:24:19.000000000","message":"And it might be better to add a check for when the export_path is None, as the `in` operator does not work with `NoneType`, I think. Personally, I think using `ManageInvalidShare` exception rather than `ShareBackendException` would be more specific.\n\n```suggestion\n        )\n        if not export_path:\n            message \u003d (\"Failed to manage existing share: %s, missing \"\n                       \"export locations.\" % share[\u0027id\u0027])\n            raise exception.ManageInvalidShare(reason\u003dmessage)\n```","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        export_path \u003d ("},{"line_number":292,"context_line":"            share.get(\u0027export_location\u0027)"},{"line_number":293,"context_line":"            or share.get(\u0027export_locations\u0027, [None])[0]"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        protocol \u003d share.get(\u0027share_proto\u0027).upper()"},{"line_number":296,"context_line":"        LOG.info("},{"line_number":297,"context_line":"            \"Managing existing share with protocol: %s, export path: %s\","}],"source_content_type":"text/x-python","patch_set":4,"id":"f4905218_db5a421b","line":294,"in_reply_to":"e690385c_63ee13ea","updated":"2026-01-16 10:10:57.000000000","message":"Fixed","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":292,"context_line":"            share.get(\u0027export_location\u0027)"},{"line_number":293,"context_line":"            or share.get(\u0027export_locations\u0027, [None])[0]"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        protocol \u003d share.get(\u0027share_proto\u0027).upper()"},{"line_number":296,"context_line":"        LOG.info("},{"line_number":297,"context_line":"            \"Managing existing share with protocol: %s, export path: %s\","},{"line_number":298,"context_line":"            protocol,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d8cfee6b_5e05c095","line":295,"updated":"2026-01-08 20:48:37.000000000","message":"does not required upper check, will always get in uppercase.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            share.get(\u0027export_location\u0027)"},{"line_number":293,"context_line":"            or share.get(\u0027export_locations\u0027, [None])[0]"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        protocol \u003d share.get(\u0027share_proto\u0027).upper()"},{"line_number":296,"context_line":"        LOG.info("},{"line_number":297,"context_line":"            \"Managing existing share with protocol: %s, export path: %s\","},{"line_number":298,"context_line":"            protocol,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a914d0f_bb5f0049","line":295,"in_reply_to":"d8cfee6b_5e05c095","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        if protocol \u003d\u003d \u0027NFS\u0027:"},{"line_number":302,"context_line":"            nfs_path \u003d ("},{"line_number":303,"context_line":"                export_path.split(\u0027:\u0027)[-1]"},{"line_number":304,"context_line":"                if \u0027:\u0027 in export_path else export_path"},{"line_number":305,"context_line":"            )"},{"line_number":306,"context_line":"            if not self._powerscale_api.validate_nfs_export(nfs_path):"},{"line_number":307,"context_line":"                raise exception.ShareBackendException("}],"source_content_type":"text/x-python","patch_set":4,"id":"f974b388_12c78d66","line":304,"updated":"2026-01-08 20:48:37.000000000","message":"path will be configure by user in below format\n``Share export path, NFS share such as: 10.0.0.1:/example_path, CIFS share such as: \\\\10.0.0.1\\example_cifs_share``. so does not required this check.Do  direct split.\n\nSame apply at line 315.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        if protocol \u003d\u003d \u0027NFS\u0027:"},{"line_number":302,"context_line":"            nfs_path \u003d ("},{"line_number":303,"context_line":"                export_path.split(\u0027:\u0027)[-1]"},{"line_number":304,"context_line":"                if \u0027:\u0027 in export_path else export_path"},{"line_number":305,"context_line":"            )"},{"line_number":306,"context_line":"            if not self._powerscale_api.validate_nfs_export(nfs_path):"},{"line_number":307,"context_line":"                raise exception.ShareBackendException("}],"source_content_type":"text/x-python","patch_set":4,"id":"0eb2eee6_b31dfcab","line":304,"in_reply_to":"f974b388_12c78d66","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":338,"context_line":"            quota_info.get(\u0027thresholds\u0027, {}).get(\u0027hard\u0027)"},{"line_number":339,"context_line":"            or quota_info.get(\u0027usage\u0027, {}).get(\u0027logical\u0027, 0)"},{"line_number":340,"context_line":"        )"},{"line_number":341,"context_line":"        size_gb \u003d max(1, size_bytes // (1024 ** 3))"},{"line_number":342,"context_line":"        return {"},{"line_number":343,"context_line":"            \u0027size\u0027: size_gb,"},{"line_number":344,"context_line":"            \u0027export_locations\u0027: [export_location],"}],"source_content_type":"text/x-python","patch_set":4,"id":"d6281a5f_304bf75f","line":341,"updated":"2026-01-08 20:48:37.000000000","message":"you can use units.Gi instead of 1024 ** 3.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            quota_info.get(\u0027thresholds\u0027, {}).get(\u0027hard\u0027)"},{"line_number":339,"context_line":"            or quota_info.get(\u0027usage\u0027, {}).get(\u0027logical\u0027, 0)"},{"line_number":340,"context_line":"        )"},{"line_number":341,"context_line":"        size_gb \u003d max(1, size_bytes // (1024 ** 3))"},{"line_number":342,"context_line":"        return {"},{"line_number":343,"context_line":"            \u0027size\u0027: size_gb,"},{"line_number":344,"context_line":"            \u0027export_locations\u0027: [export_location],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3d3f14ac_1a40402b","line":341,"in_reply_to":"d6281a5f_304bf75f","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":345,"context_line":"            \u0027protocol\u0027: protocol,"},{"line_number":346,"context_line":"        }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def unmanage(self, share):"},{"line_number":349,"context_line":"        LOG.info(\"Unmanaging share: %s\", share.get(\u0027id\u0027))"},{"line_number":350,"context_line":"        return {"},{"line_number":351,"context_line":"            \u0027status\u0027: \u0027success\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"47b3a46d_a649395c","line":348,"updated":"2026-01-08 20:48:37.000000000","message":"Does not required,generic code will handle this.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            \u0027protocol\u0027: protocol,"},{"line_number":346,"context_line":"        }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def unmanage(self, share):"},{"line_number":349,"context_line":"        LOG.info(\"Unmanaging share: %s\", share.get(\u0027id\u0027))"},{"line_number":350,"context_line":"        return {"},{"line_number":351,"context_line":"            \u0027status\u0027: \u0027success\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"44b0c8f3_93be4213","line":348,"in_reply_to":"47b3a46d_a649395c","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59277f1cb9b7b84c9eaa02de195a00854a7c6a0d","unresolved":true,"context_lines":[{"line_number":287,"context_line":"        self._powerscale_api.quota_set("},{"line_number":288,"context_line":"            self._get_container_path(share), \u0027directory\u0027, new_quota_size)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":291,"context_line":"        \"\"\"Import an external NFS/CIFS share into Manila.\"\"\""},{"line_number":292,"context_line":"        export_path \u003d ("},{"line_number":293,"context_line":"            share.get(\u0027export_location\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"661903ad_31c42293","line":290,"range":{"start_line":290,"start_character":0,"end_line":290,"end_character":2},"updated":"2026-01-20 18:58:05.000000000","message":"great unit test coverage, thank you!","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"0859f6676ff170a66374da3a26ea4a051ec5e33e","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self._powerscale_api.quota_set("},{"line_number":288,"context_line":"            self._get_container_path(share), \u0027directory\u0027, new_quota_size)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":291,"context_line":"        \"\"\"Import an external NFS/CIFS share into Manila.\"\"\""},{"line_number":292,"context_line":"        export_path \u003d ("},{"line_number":293,"context_line":"            share.get(\u0027export_location\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b66508d6_d6a16443","line":290,"range":{"start_line":290,"start_character":0,"end_line":290,"end_character":2},"in_reply_to":"661903ad_31c42293","updated":"2026-01-27 10:07:30.000000000","message":"Acknowledged","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59277f1cb9b7b84c9eaa02de195a00854a7c6a0d","unresolved":true,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":291,"context_line":"        \"\"\"Import an external NFS/CIFS share into Manila.\"\"\""},{"line_number":292,"context_line":"        export_path \u003d ("},{"line_number":293,"context_line":"            share.get(\u0027export_location\u0027)"},{"line_number":294,"context_line":"            or share.get(\u0027export_locations\u0027, [None])[0]"},{"line_number":295,"context_line":"        )"},{"line_number":296,"context_line":"        if not export_path:"},{"line_number":297,"context_line":"            message \u003d ("},{"line_number":298,"context_line":"                \"Failed to manage existing share: %s, \""},{"line_number":299,"context_line":"                \"missing export locations.\""},{"line_number":300,"context_line":"            ) % share[\u0027id\u0027]"},{"line_number":301,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmessage)"},{"line_number":302,"context_line":"        protocol \u003d share.get(\u0027share_proto\u0027)"},{"line_number":303,"context_line":"        LOG.info("},{"line_number":304,"context_line":"            \"Managing existing share with protocol: %s, export path: %s\","}],"source_content_type":"text/x-python","patch_set":5,"id":"f4e1f948_a7b00869","line":301,"range":{"start_line":292,"start_character":1,"end_line":301,"end_character":62},"updated":"2026-01-20 18:58:05.000000000","message":"This is already being validated at the API level [1], so we can drop it here.\n\n[1] https://github.com/openstack/manila/blob/master/manila/api/v1/share_manage.py#L77-L87","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"a9d9187bcec6945bae2a5aa5a8a25d525fe0238d","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":291,"context_line":"        \"\"\"Import an external NFS/CIFS share into Manila.\"\"\""},{"line_number":292,"context_line":"        export_path \u003d ("},{"line_number":293,"context_line":"            share.get(\u0027export_location\u0027)"},{"line_number":294,"context_line":"            or share.get(\u0027export_locations\u0027, [None])[0]"},{"line_number":295,"context_line":"        )"},{"line_number":296,"context_line":"        if not export_path:"},{"line_number":297,"context_line":"            message \u003d ("},{"line_number":298,"context_line":"                \"Failed to manage existing share: %s, \""},{"line_number":299,"context_line":"                \"missing export locations.\""},{"line_number":300,"context_line":"            ) % share[\u0027id\u0027]"},{"line_number":301,"context_line":"            raise exception.ManageInvalidShare(reason\u003dmessage)"},{"line_number":302,"context_line":"        protocol \u003d share.get(\u0027share_proto\u0027)"},{"line_number":303,"context_line":"        LOG.info("},{"line_number":304,"context_line":"            \"Managing existing share with protocol: %s, export path: %s\","}],"source_content_type":"text/x-python","patch_set":5,"id":"edf7664d_35ce10be","line":301,"range":{"start_line":292,"start_character":1,"end_line":301,"end_character":62},"in_reply_to":"f4e1f948_a7b00869","updated":"2026-01-28 08:56:34.000000000","message":"Done","commit_id":"67263b33ebb4a111d7313fb492a7c2d70939479d"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale_api.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":344,"context_line":"            \u0027{0}/platform/1/quota/quotas/{1}\u0027.format(self.host_url, quota_id))"},{"line_number":345,"context_line":"        return response.status_code \u003d\u003d 204"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def validate_nfs_export(self, export_path):"},{"line_number":348,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/nfs/exports\""},{"line_number":349,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":350,"context_line":"        if response.status_code !\u003d 200:"},{"line_number":351,"context_line":"            response.raise_for_status()"},{"line_number":352,"context_line":"        exports \u003d response.json().get(\u0027exports\u0027, [])"},{"line_number":353,"context_line":"        return any(export_path in exp.get(\u0027paths\u0027, []) for exp in exports)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def validate_cifs_share(self, share_name):"},{"line_number":356,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/smb/shares\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1c4ae8b4_ba60b23c","line":353,"range":{"start_line":347,"start_character":4,"end_line":353,"end_character":74},"updated":"2026-01-08 20:48:37.000000000","message":"this is not good approach to validate export. you can use existing ``lookup_nfs_export`` to validate this.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            \u0027{0}/platform/1/quota/quotas/{1}\u0027.format(self.host_url, quota_id))"},{"line_number":345,"context_line":"        return response.status_code \u003d\u003d 204"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def validate_nfs_export(self, export_path):"},{"line_number":348,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/nfs/exports\""},{"line_number":349,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":350,"context_line":"        if response.status_code !\u003d 200:"},{"line_number":351,"context_line":"            response.raise_for_status()"},{"line_number":352,"context_line":"        exports \u003d response.json().get(\u0027exports\u0027, [])"},{"line_number":353,"context_line":"        return any(export_path in exp.get(\u0027paths\u0027, []) for exp in exports)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def validate_cifs_share(self, share_name):"},{"line_number":356,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/smb/shares\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1c5f9959_a83ae2ef","line":353,"range":{"start_line":347,"start_character":4,"end_line":353,"end_character":74},"in_reply_to":"1c4ae8b4_ba60b23c","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":352,"context_line":"        exports \u003d response.json().get(\u0027exports\u0027, [])"},{"line_number":353,"context_line":"        return any(export_path in exp.get(\u0027paths\u0027, []) for exp in exports)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def validate_cifs_share(self, share_name):"},{"line_number":356,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/smb/shares\""},{"line_number":357,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":358,"context_line":"        if response.status_code !\u003d 200:"},{"line_number":359,"context_line":"            response.raise_for_status()"},{"line_number":360,"context_line":"        shares \u003d response.json().get(\u0027shares\u0027, [])"},{"line_number":361,"context_line":"        return any(share.get(\u0027name\u0027) \u003d\u003d share_name for share in shares)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def get_quota_info(self, path):"},{"line_number":364,"context_line":"        url \u003d f\"{self.host_url}/platform/1/quota/quotas?path\u003d{path}\""}],"source_content_type":"text/x-python","patch_set":4,"id":"d20b9beb_6b6950c3","line":361,"range":{"start_line":355,"start_character":4,"end_line":361,"end_character":71},"updated":"2026-01-08 20:48:37.000000000","message":"this is not good approach to validate export. you can use existing ``lookup_smb_share`` to validate this.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        exports \u003d response.json().get(\u0027exports\u0027, [])"},{"line_number":353,"context_line":"        return any(export_path in exp.get(\u0027paths\u0027, []) for exp in exports)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def validate_cifs_share(self, share_name):"},{"line_number":356,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/smb/shares\""},{"line_number":357,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":358,"context_line":"        if response.status_code !\u003d 200:"},{"line_number":359,"context_line":"            response.raise_for_status()"},{"line_number":360,"context_line":"        shares \u003d response.json().get(\u0027shares\u0027, [])"},{"line_number":361,"context_line":"        return any(share.get(\u0027name\u0027) \u003d\u003d share_name for share in shares)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def get_quota_info(self, path):"},{"line_number":364,"context_line":"        url \u003d f\"{self.host_url}/platform/1/quota/quotas?path\u003d{path}\""}],"source_content_type":"text/x-python","patch_set":4,"id":"750a8a80_db1d9219","line":361,"range":{"start_line":355,"start_character":4,"end_line":361,"end_character":71},"in_reply_to":"d20b9beb_6b6950c3","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":360,"context_line":"        shares \u003d response.json().get(\u0027shares\u0027, [])"},{"line_number":361,"context_line":"        return any(share.get(\u0027name\u0027) \u003d\u003d share_name for share in shares)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def get_quota_info(self, path):"},{"line_number":364,"context_line":"        url \u003d f\"{self.host_url}/platform/1/quota/quotas?path\u003d{path}\""},{"line_number":365,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":366,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":367,"context_line":"            return {}"},{"line_number":368,"context_line":"        elif response.status_code !\u003d 200:"},{"line_number":369,"context_line":"            response.raise_for_status()"},{"line_number":370,"context_line":"        quotas \u003d response.json().get(\u0027quotas\u0027, [])"},{"line_number":371,"context_line":"        return quotas[0] if quotas else {}"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def get_cifs_share_path(self, share_name):"},{"line_number":374,"context_line":"        \"\"\"Return OneFS path for a given CIFS share name.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"2bc99051_6d810ad8","line":371,"range":{"start_line":363,"start_character":4,"end_line":371,"end_character":42},"updated":"2026-01-08 20:48:37.000000000","message":"use exiting function to get quota ``quota_get``.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        shares \u003d response.json().get(\u0027shares\u0027, [])"},{"line_number":361,"context_line":"        return any(share.get(\u0027name\u0027) \u003d\u003d share_name for share in shares)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def get_quota_info(self, path):"},{"line_number":364,"context_line":"        url \u003d f\"{self.host_url}/platform/1/quota/quotas?path\u003d{path}\""},{"line_number":365,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":366,"context_line":"        if response.status_code \u003d\u003d 404:"},{"line_number":367,"context_line":"            return {}"},{"line_number":368,"context_line":"        elif response.status_code !\u003d 200:"},{"line_number":369,"context_line":"            response.raise_for_status()"},{"line_number":370,"context_line":"        quotas \u003d response.json().get(\u0027quotas\u0027, [])"},{"line_number":371,"context_line":"        return quotas[0] if quotas else {}"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def get_cifs_share_path(self, share_name):"},{"line_number":374,"context_line":"        \"\"\"Return OneFS path for a given CIFS share name.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"d59eb2ea_3976579f","line":371,"range":{"start_line":363,"start_character":4,"end_line":371,"end_character":42},"in_reply_to":"2bc99051_6d810ad8","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":370,"context_line":"        quotas \u003d response.json().get(\u0027quotas\u0027, [])"},{"line_number":371,"context_line":"        return quotas[0] if quotas else {}"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def get_cifs_share_path(self, share_name):"},{"line_number":374,"context_line":"        \"\"\"Return OneFS path for a given CIFS share name.\"\"\""},{"line_number":375,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/smb/shares\""},{"line_number":376,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":377,"context_line":"        if response.status_code !\u003d 200:"},{"line_number":378,"context_line":"            response.raise_for_status()"},{"line_number":379,"context_line":"        shares \u003d response.json().get(\u0027shares\u0027, [])"},{"line_number":380,"context_line":"        for sh in shares:"},{"line_number":381,"context_line":"            if sh.get(\u0027name\u0027) \u003d\u003d share_name:"},{"line_number":382,"context_line":"                return sh.get(\u0027path\u0027)"},{"line_number":383,"context_line":"        return None"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def modify_smb_share_access(self, share_name,"},{"line_number":386,"context_line":"                                host_acl\u003dNone, permissions\u003dNone):"},{"line_number":387,"context_line":"        \"\"\"Modifies SMB share access"}],"source_content_type":"text/x-python","patch_set":4,"id":"6fd4b08f_2d3e66f7","line":384,"range":{"start_line":373,"start_character":4,"end_line":384,"end_character":1},"updated":"2026-01-08 20:48:37.000000000","message":"you can use existing function ``lookup_smb_share`` for this.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        quotas \u003d response.json().get(\u0027quotas\u0027, [])"},{"line_number":371,"context_line":"        return quotas[0] if quotas else {}"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def get_cifs_share_path(self, share_name):"},{"line_number":374,"context_line":"        \"\"\"Return OneFS path for a given CIFS share name.\"\"\""},{"line_number":375,"context_line":"        url \u003d f\"{self.host_url}/platform/3/protocols/smb/shares\""},{"line_number":376,"context_line":"        response \u003d self.send_get_request(url)"},{"line_number":377,"context_line":"        if response.status_code !\u003d 200:"},{"line_number":378,"context_line":"            response.raise_for_status()"},{"line_number":379,"context_line":"        shares \u003d response.json().get(\u0027shares\u0027, [])"},{"line_number":380,"context_line":"        for sh in shares:"},{"line_number":381,"context_line":"            if sh.get(\u0027name\u0027) \u003d\u003d share_name:"},{"line_number":382,"context_line":"                return sh.get(\u0027path\u0027)"},{"line_number":383,"context_line":"        return None"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def modify_smb_share_access(self, share_name,"},{"line_number":386,"context_line":"                                host_acl\u003dNone, permissions\u003dNone):"},{"line_number":387,"context_line":"        \"\"\"Modifies SMB share access"}],"source_content_type":"text/x-python","patch_set":4,"id":"fb17f37b_b0bc2171","line":384,"range":{"start_line":373,"start_character":4,"end_line":384,"end_character":1},"in_reply_to":"6fd4b08f_2d3e66f7","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"}],"manila/tests/share/drivers/dell_emc/test_driver.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9aa72af74ab0508f21c8337a03110c262a8b4f3a","unresolved":true,"context_lines":[{"line_number":260,"context_line":"        snapshot \u003d mock.Mock()"},{"line_number":261,"context_line":"        identifier \u003d mock.Mock()"},{"line_number":262,"context_line":"        self.driver.plugin \u003d mock.Mock()"},{"line_number":263,"context_line":"        self.driver.manage_existing(share, driver_options)"},{"line_number":264,"context_line":"        result \u003d self.driver.manage_existing_with_server("},{"line_number":265,"context_line":"            share, driver_options, share_server)"},{"line_number":266,"context_line":"        self.assertIsInstance(result, NotImplementedError)"}],"source_content_type":"text/x-python","patch_set":4,"id":"be7ba921_2d2bec7a","line":263,"updated":"2026-01-08 20:48:37.000000000","message":"please revert all changes, these are not required.","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"496bb082ff21bf98e64f73450d66224e71537efe","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        snapshot \u003d mock.Mock()"},{"line_number":261,"context_line":"        identifier \u003d mock.Mock()"},{"line_number":262,"context_line":"        self.driver.plugin \u003d mock.Mock()"},{"line_number":263,"context_line":"        self.driver.manage_existing(share, driver_options)"},{"line_number":264,"context_line":"        result \u003d self.driver.manage_existing_with_server("},{"line_number":265,"context_line":"            share, driver_options, share_server)"},{"line_number":266,"context_line":"        self.assertIsInstance(result, NotImplementedError)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0fa4e604_ee807919","line":263,"in_reply_to":"be7ba921_2d2bec7a","updated":"2026-01-16 10:10:57.000000000","message":"Done","commit_id":"6767e81dec69eb539e031e3667bf64c7711d539a"}]}