)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e529253c43911ff7115c32640bafa119f9aa4d29","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerScale: Dedupe support at share level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support to schedule Dedupe job at share level in Dell PowerScale Manila Driver. It includes the logic to schedule Dedupe job while creating manila share."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint dell-powerscale-dedupe-share"},{"line_number":12,"context_line":"Change-Id: I3dfa727a64cbc6f1b249f9ee0cceabf5c1e93efa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1009e000_96f11e37","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":169},"updated":"2026-02-19 14:35:53.000000000","message":"nit: please wrap summary lines at 72 characters","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"e965baf8625458bee8973416d39526958b9baec0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerScale: Dedupe support at share level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support to schedule Dedupe job at share level in Dell PowerScale Manila Driver. It includes the logic to schedule Dedupe job while creating manila share."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint dell-powerscale-dedupe-share"},{"line_number":12,"context_line":"Change-Id: I3dfa727a64cbc6f1b249f9ee0cceabf5c1e93efa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"b2462077_dfc2a9d2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":169},"in_reply_to":"1009e000_96f11e37","updated":"2026-02-19 21:40:02.000000000","message":"Acknowledged","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"a26f9d5b3df96f41bb1d0e6870117f12ec28018f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c26265d2_ecb1194b","updated":"2026-01-13 13:12:39.000000000","message":"run-DellEMC PowerScale CI","commit_id":"a07c8ad36f9d22d0c33ef02c9f333e97056fcbeb"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"ec45599977ddc9b6f70538261272a329dd67c900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53efe7ed_7bd7c570","updated":"2026-01-13 18:32:08.000000000","message":"run-DellEMC PowerScale CI","commit_id":"c761d1e34dc81a6df017e8bee3cdfb3b4510869f"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"aceb3a528de5b15dce9512405a28c71ca30be963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a9fc0cfe_11423bb5","updated":"2026-01-14 12:55:50.000000000","message":"run-DellEMC PowerScale CI","commit_id":"0d3c4d7c7124f96ea93bed9a1eb5397ca791f83e"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"e1f704b65410c85319aa9a8e0e125c00cdfa911b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ec98ccb_cab8167c","updated":"2026-01-14 19:46:46.000000000","message":"run-DellEMC PowerScale CI","commit_id":"6cc9bae386b8e465d1a1350c21a9d24268d872ff"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"70b203a3bfa613685fb240ebd1811b4ec143b1f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7317aa44_301e6dc0","updated":"2026-01-14 22:21:12.000000000","message":"run-DellEMC PowerScale CI","commit_id":"dc9a6429b52ab7d9626c16909b0a0a563cf3ee9f"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"9baffe7f7aef0cceb47bf3da3321083a3830ee85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e59c405c_e51a3924","updated":"2026-01-16 11:48:52.000000000","message":"run-DellEMC PowerScale CI","commit_id":"c6cd7d79adcd539a242a1d20b4ea4f0286ca3a8f"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"50db7056_e9906872","updated":"2026-01-22 12:09:06.000000000","message":"Thanks for working on this patch. Added few comments.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"b4b4bf27a6526ca653b7f0c9be3f0bce5957532c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a2c9a51_5d84472f","updated":"2026-01-16 15:04:46.000000000","message":"run-DellEMC PowerScale CI","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"1c7bc44fe240adb924096192b3eb3fcc5736a835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4bfac449_d236a223","updated":"2026-01-28 13:46:50.000000000","message":"run-DellEMC PowerScale CI","commit_id":"18faca199ba8f9078ec8cccb6d58e6c4c2bec1ee"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"06d14208e2bd93a95fe689220f602be9572c98c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f85f09a7_2d71d0df","updated":"2026-02-01 19:56:24.000000000","message":"@ces.eduardo98@gmail.com @gouthampravi@gmail.com\nCould you please help in reviewing this patch.\nThank you","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"d2e6334589c33942637432f81fa269d007006d27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"98b36297_05dcd3d2","updated":"2026-02-04 14:22:05.000000000","message":"Hi Anoop,\n\nThank you for your review. Here, deduplication is backend specific. We want to give the option to the user to create share with deduplication disabled as well. Also, we have the suggestion to define dedupe as extra spec as per the following page : https://docs.openstack.org/manila/latest/admin/capabilities_and_extra_specs.html\nAlso, for the question related to retype, PowerScale Manila currently does not support retype operation.","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"33a70f78b3f08fc6de0941493173c752b470ad5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d82b8fa9_a17341a7","updated":"2026-02-04 12:51:54.000000000","message":"Please take a look at the comments.","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cb5231608479d4b5d186442492ceb65b972c0a50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"17c25b41_a487e104","updated":"2026-02-05 15:45:08.000000000","message":"could you please rebase this on top of the manage/unmanage support patch, and test it together? I\u0027d like to know if dedupe is updated when managing a share as well..","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"eb89504dae3de0f76a316933a660994149f38dc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f6ddd831_a4b8db0f","in_reply_to":"17c25b41_a487e104","updated":"2026-02-09 17:29:06.000000000","message":"Hi, Thanks for your review. I have tested it. Its working with manage/unmanage support patch.","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"9c25cfbbbd3a99d043398626933fed29270929db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ecfa5f49_3a71003a","updated":"2026-02-09 17:30:06.000000000","message":"run-DellEMC PowerScale CI","commit_id":"53b5043d7b356c4e2efb934e31084a007499ded5"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"7991c16fdd7ea72e6d06e56b6cd4c75332cffc7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"42df3c4e_85237d77","updated":"2026-02-10 06:47:26.000000000","message":"recheck","commit_id":"7bcaefe5d4c9b0a37ee17c384dbafc0e103121df"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"87eefca098ebbb911929a628d6841eef4d85139f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c9d950bd_f2cdd163","updated":"2026-02-17 13:00:33.000000000","message":"@gouthampravi@gmail.com Thanks for your review and approval.\n@ces.eduardo98@gmail.com @anoop.shukla@netapp.com Could you please help in reviewing this patch.","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d4a485f59d8b0338e140c900cd79e0a6d30c6110","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0dc35bfc_a3024d37","updated":"2026-02-17 06:43:47.000000000","message":"LGTM, thank you","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e529253c43911ff7115c32640bafa119f9aa4d29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"76406d77_33863533","updated":"2026-02-19 14:35:53.000000000","message":"LGTM, thanks Abhishek","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"61748811384b637378071ec5ac5bc56f6a0abb48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"85491a68_43a4b8ce","updated":"2026-02-19 21:43:30.000000000","message":"recheck","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9fd0002d8700aff6d3c6255a927853051c24b347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"00dde662_81d9c07a","updated":"2026-02-17 06:44:36.000000000","message":"run-DellEMC PowerScale CI","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"e965baf8625458bee8973416d39526958b9baec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3ae69548_d54254e5","in_reply_to":"76406d77_33863533","updated":"2026-02-19 21:40:02.000000000","message":"Thank you Carlos","commit_id":"5043ee88017a14c4a5f517c8985cd8f1e4445194"}],"doc/source/configuration/shared-file-systems/drivers/dell-emc-powerscale-driver.rst":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"33a70f78b3f08fc6de0941493173c752b470ad5d","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    --name \u003cshare_name\u003e --share-type \u003cshare_type\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"On PowerScale, Dedupe job will be scheduled weekly"},{"line_number":103,"context_line":"on Sunday at 12:00 AM for the created NFS/CIFS share."},{"line_number":104,"context_line":"If you do not wanschedule dedupe job, then do not"},{"line_number":105,"context_line":"provide extra spec while creating share type."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da23260c_18f519d4","line":103,"updated":"2026-02-04 12:51:54.000000000","message":"Any reasons why we do not want to use a configuration value in manila.conf to enable creating shares with dedup configuration enabled? Another question I had was, how do we handle the share retype if someone would want to enable it on volumes that are previously created?","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"eb89504dae3de0f76a316933a660994149f38dc9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    --name \u003cshare_name\u003e --share-type \u003cshare_type\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"On PowerScale, Dedupe job will be scheduled weekly"},{"line_number":103,"context_line":"on Sunday at 12:00 AM for the created NFS/CIFS share."},{"line_number":104,"context_line":"If you do not wanschedule dedupe job, then do not"},{"line_number":105,"context_line":"provide extra spec while creating share type."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"725d7638_7864726f","line":103,"in_reply_to":"da23260c_18f519d4","updated":"2026-02-09 17:29:06.000000000","message":"Done","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8472ab3d083f82a30272d8192917d57143711087","unresolved":true,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":".. code-block:: ini"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    powerscale_dedupe_schedule \u003d \"every 1 weeks on sunday, monday at 01:00 AM\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"If you do not want to schedule dedupe job, then do not"},{"line_number":223,"context_line":"provide extra spec while creating share type."}],"source_content_type":"text/x-rst","patch_set":13,"id":"c80ba840_8ced5594","line":220,"range":{"start_line":220,"start_character":33,"end_line":220,"end_character":78},"updated":"2026-02-13 22:03:59.000000000","message":"Maybe provide what other options can be used here, or if there is any documentation that you can link that tells operators how to format this.","commit_id":"8d8be1453c799ada702711913eb4e53759bcd59b"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"9a5fe874c3c3e53971e9107bb071701e22a8cd8c","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":".. code-block:: ini"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    powerscale_dedupe_schedule \u003d \"every 1 weeks on sunday, monday at 01:00 AM\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"If you do not want to schedule dedupe job, then do not"},{"line_number":223,"context_line":"provide extra spec while creating share type."}],"source_content_type":"text/x-rst","patch_set":13,"id":"bb9b374d_6afdc6d2","line":220,"range":{"start_line":220,"start_character":33,"end_line":220,"end_character":78},"in_reply_to":"c80ba840_8ced5594","updated":"2026-02-14 20:19:38.000000000","message":"Done","commit_id":"8d8be1453c799ada702711913eb4e53759bcd59b"}],"manila/scheduler/host_manager.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        self.create_share_from_snapshot_support \u003d True"},{"line_number":151,"context_line":"        self.revert_to_snapshot_support \u003d False"},{"line_number":152,"context_line":"        self.mount_snapshot_support \u003d False"},{"line_number":153,"context_line":"        self.dedupe \u003d True"},{"line_number":154,"context_line":"        self.compression \u003d False"},{"line_number":155,"context_line":"        self.replication_type \u003d None"},{"line_number":156,"context_line":"        self.replication_domain \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"830a443b_9a3c0be7","line":153,"updated":"2026-01-22 12:09:06.000000000","message":"This does not required to change here. You need to enable it at driver level.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.create_share_from_snapshot_support \u003d True"},{"line_number":151,"context_line":"        self.revert_to_snapshot_support \u003d False"},{"line_number":152,"context_line":"        self.mount_snapshot_support \u003d False"},{"line_number":153,"context_line":"        self.dedupe \u003d True"},{"line_number":154,"context_line":"        self.compression \u003d False"},{"line_number":155,"context_line":"        self.replication_type \u003d None"},{"line_number":156,"context_line":"        self.replication_domain \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"d38ca827_4d325e3d","line":153,"in_reply_to":"830a443b_9a3c0be7","updated":"2026-01-28 12:52:16.000000000","message":"Done. This change has been reverted to enable dedupe at driver level.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    1.0.4 - Rename isilon to powerscale"},{"line_number":39,"context_line":"    1.0.5 - Add support to schedule Dedupe job for a share"},{"line_number":40,"context_line":"\"\"\""},{"line_number":41,"context_line":"VERSION \u003d \"1.0.4\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5c9993da_25ff2719","line":41,"updated":"2026-01-22 12:09:06.000000000","message":"please update the version.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    1.0.4 - Rename isilon to powerscale"},{"line_number":39,"context_line":"    1.0.5 - Add support to schedule Dedupe job for a share"},{"line_number":40,"context_line":"\"\"\""},{"line_number":41,"context_line":"VERSION \u003d \"1.0.4\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"67992a12_c5ce0db8","line":41,"in_reply_to":"5c9993da_25ff2719","updated":"2026-01-28 12:52:16.000000000","message":"Done","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        self.reserved_snapshot_percentage \u003d None"},{"line_number":87,"context_line":"        self.reserved_share_extend_percentage \u003d None"},{"line_number":88,"context_line":"        self.max_over_subscription_ratio \u003d None"},{"line_number":89,"context_line":"        self._threshold_limit \u003d 0"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _get_container_path(self, share):"},{"line_number":92,"context_line":"        \"\"\"Return path to a container.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"b8969b17_8c1c88da","line":89,"updated":"2026-01-22 12:09:06.000000000","message":"Needs to enable dedupe here.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ee08260ec32ce54527bf57e9759f7d4d2d20e518","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.reserved_snapshot_percentage \u003d None"},{"line_number":87,"context_line":"        self.reserved_share_extend_percentage \u003d None"},{"line_number":88,"context_line":"        self.max_over_subscription_ratio \u003d None"},{"line_number":89,"context_line":"        self._threshold_limit \u003d 0"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _get_container_path(self, share):"},{"line_number":92,"context_line":"        \"\"\"Return path to a container.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7e4b3883_45a05a4f","line":89,"in_reply_to":"1f8cf6c6_592e7e5b","updated":"2026-01-28 05:19:23.000000000","message":"Sorry I missed, that is not required here.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"ebf5338ded2e5baf1698fe2570daad7279bc1135","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        self.reserved_snapshot_percentage \u003d None"},{"line_number":87,"context_line":"        self.reserved_share_extend_percentage \u003d None"},{"line_number":88,"context_line":"        self.max_over_subscription_ratio \u003d None"},{"line_number":89,"context_line":"        self._threshold_limit \u003d 0"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _get_container_path(self, share):"},{"line_number":92,"context_line":"        \"\"\"Return path to a container.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f8cf6c6_592e7e5b","line":89,"in_reply_to":"b8969b17_8c1c88da","updated":"2026-01-27 18:51:54.000000000","message":"Enabling dedupe here is throwing following error : \nShare type extra spec requirement \"dedupe\u003dTrue\" does not match reported capability \"False\"","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            LOG.error(message)"},{"line_number":141,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":142,"context_line":"        location \u003d self._get_location(self._format_nfs_path(container_path))"},{"line_number":143,"context_line":"        self.dedupe_extra_spec(context, share, location)"},{"line_number":144,"context_line":"        return location"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _create_cifs_share(self, share, context):"}],"source_content_type":"text/x-python","patch_set":7,"id":"40c5e714_4da26c71","line":143,"updated":"2026-01-22 12:09:06.000000000","message":"It should be work like this.\n1. first check dedupe is enable is or not\n\n\n```suggestion\n        dedupe_status \u003d self._check_dedupe_spec(share):\n           return share_types.get_share_type_extra_specs(type_id, \u0027dedupe\u0027)\n        \n```\n2. if enable then call update_dedupe_settings.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            LOG.error(message)"},{"line_number":141,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":142,"context_line":"        location \u003d self._get_location(self._format_nfs_path(container_path))"},{"line_number":143,"context_line":"        self.dedupe_extra_spec(context, share, location)"},{"line_number":144,"context_line":"        return location"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _create_cifs_share(self, share, context):"}],"source_content_type":"text/x-python","patch_set":7,"id":"51fd1729_61236f97","line":143,"in_reply_to":"40c5e714_4da26c71","updated":"2026-01-28 12:52:16.000000000","message":"Edited as : \n        dedupe_status \u003d share_types.get_share_type_extra_specs(share_type_id, \u0027dedupe\u0027)\n        if isinstance(dedupe_status, str) and dedupe_status.lower() \u003d\u003d \"true\":\n            self.update_dedupe_settings(share)","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":590,"context_line":"                             \u0027metadata\u0027: {\"preferred\": True}}]"},{"line_number":591,"context_line":"        return export_locations"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def dedupe_extra_spec(self, context, share, location):"},{"line_number":594,"context_line":"        \"\"\"Invoked to ensure that shares are exported."},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        :share: NFS/CIFS share"}],"source_content_type":"text/x-python","patch_set":7,"id":"2e06c2d5_5ccd5f29","line":593,"updated":"2026-01-22 12:09:06.000000000","message":"This is not looking good approach.\n\nYou can use share_types.get_share_type_extra_specs(type_id, key) instead of this.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                             \u0027metadata\u0027: {\"preferred\": True}}]"},{"line_number":591,"context_line":"        return export_locations"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def dedupe_extra_spec(self, context, share, location):"},{"line_number":594,"context_line":"        \"\"\"Invoked to ensure that shares are exported."},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        :share: NFS/CIFS share"}],"source_content_type":"text/x-python","patch_set":7,"id":"44811218_8f01a41f","line":593,"in_reply_to":"2e06c2d5_5ccd5f29","updated":"2026-01-28 12:52:16.000000000","message":"Done. Thanks for the suggestion. Updated the code to use existing predefined function to fetch dedupe extra spec.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":623,"context_line":"            paths \u003d dedupe_settings[\"settings\"][\"paths\"]"},{"line_number":624,"context_line":"            assess_paths \u003d dedupe_settings[\"settings\"][\"assess_paths\"]"},{"line_number":625,"context_line":"            LOG.debug(\"Paths %s. Assess Paths %s.\", paths, assess_paths)"},{"line_number":626,"context_line":"            full_share_path \u003d location[0][\u0027path\u0027]"},{"line_number":627,"context_line":"            if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":628,"context_line":"                share_path \u003d full_share_path.split(\u0027:\u0027, 1)[1]"},{"line_number":629,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3904ae7f_c52bd405","line":626,"updated":"2026-01-22 12:09:06.000000000","message":"location does not required to pass in the function\n\nYou can use self.__get_container_path(share)","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":623,"context_line":"            paths \u003d dedupe_settings[\"settings\"][\"paths\"]"},{"line_number":624,"context_line":"            assess_paths \u003d dedupe_settings[\"settings\"][\"assess_paths\"]"},{"line_number":625,"context_line":"            LOG.debug(\"Paths %s. Assess Paths %s.\", paths, assess_paths)"},{"line_number":626,"context_line":"            full_share_path \u003d location[0][\u0027path\u0027]"},{"line_number":627,"context_line":"            if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"},{"line_number":628,"context_line":"                share_path \u003d full_share_path.split(\u0027:\u0027, 1)[1]"},{"line_number":629,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"d12f026e_b0cd0f06","line":626,"in_reply_to":"3904ae7f_c52bd405","updated":"2026-01-28 12:52:16.000000000","message":"Done","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":634,"context_line":"            LOG.debug(\"Updated Paths %s. \""},{"line_number":635,"context_line":"                      \"Updated Assess Paths %s.\", paths, assess_paths)"},{"line_number":636,"context_line":"            self._powerscale_api.modify_dedupe_settings(paths, assess_paths)"},{"line_number":637,"context_line":"            LOG.debug(\"Dedupe settings modified.\")"},{"line_number":638,"context_line":"            self._powerscale_api.schedule_dedupe_job()"},{"line_number":639,"context_line":"        else:"},{"line_number":640,"context_line":"            message \u003d _(\u0027Invalid Dedupe value supplied for \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"b7a34943_1890b025","line":637,"updated":"2026-01-22 12:09:06.000000000","message":"All function logging not looking good, please update it.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            LOG.debug(\"Updated Paths %s. \""},{"line_number":635,"context_line":"                      \"Updated Assess Paths %s.\", paths, assess_paths)"},{"line_number":636,"context_line":"            self._powerscale_api.modify_dedupe_settings(paths, assess_paths)"},{"line_number":637,"context_line":"            LOG.debug(\"Dedupe settings modified.\")"},{"line_number":638,"context_line":"            self._powerscale_api.schedule_dedupe_job()"},{"line_number":639,"context_line":"        else:"},{"line_number":640,"context_line":"            message \u003d _(\u0027Invalid Dedupe value supplied for \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"22a755c2_6df0acf0","line":637,"in_reply_to":"b7a34943_1890b025","updated":"2026-01-28 12:52:16.000000000","message":"Done","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":635,"context_line":"                      \"Updated Assess Paths %s.\", paths, assess_paths)"},{"line_number":636,"context_line":"            self._powerscale_api.modify_dedupe_settings(paths, assess_paths)"},{"line_number":637,"context_line":"            LOG.debug(\"Dedupe settings modified.\")"},{"line_number":638,"context_line":"            self._powerscale_api.schedule_dedupe_job()"},{"line_number":639,"context_line":"        else:"},{"line_number":640,"context_line":"            message \u003d _(\u0027Invalid Dedupe value supplied for \u0027"},{"line_number":641,"context_line":"                        \u0027share location %s\u0027) % location"}],"source_content_type":"text/x-python","patch_set":7,"id":"cd6650e3_ae35864a","line":638,"updated":"2026-01-22 12:09:06.000000000","message":"For every new share you are creating scheduler which is not right, you needs to check if scheduler exist, if not then create one.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                      \"Updated Assess Paths %s.\", paths, assess_paths)"},{"line_number":636,"context_line":"            self._powerscale_api.modify_dedupe_settings(paths, assess_paths)"},{"line_number":637,"context_line":"            LOG.debug(\"Dedupe settings modified.\")"},{"line_number":638,"context_line":"            self._powerscale_api.schedule_dedupe_job()"},{"line_number":639,"context_line":"        else:"},{"line_number":640,"context_line":"            message \u003d _(\u0027Invalid Dedupe value supplied for \u0027"},{"line_number":641,"context_line":"                        \u0027share location %s\u0027) % location"}],"source_content_type":"text/x-python","patch_set":7,"id":"bd775386_c0399ff8","line":638,"in_reply_to":"cd6650e3_ae35864a","updated":"2026-01-28 12:52:16.000000000","message":"Here, we are triggering PUT API and updating the schedule. Dedupe only has 1 scheduler.\nBut to save the PUT call, we can implement a GET call to check whether there is a need to modify the schedule in that 1 scheduler.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cb5231608479d4b5d186442492ceb65b972c0a50","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        self.process_dedupe(share)"},{"line_number":163,"context_line":"        return location"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def process_dedupe(self, share):"},{"line_number":166,"context_line":"        share_type_id \u003d share.get(\"share_type_id\")"},{"line_number":167,"context_line":"        dedupe_status \u003d share_types.get_share_type_extra_specs(share_type_id,"},{"line_number":168,"context_line":"                                                               \u0027dedupe\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"f7ba328c_dcdc9eee","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":22},"updated":"2026-02-05 15:45:08.000000000","message":"this could be a \"private\" method\n\n```suggestion\n    def _process_dedupe(self, share):\n```","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"eb89504dae3de0f76a316933a660994149f38dc9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.process_dedupe(share)"},{"line_number":163,"context_line":"        return location"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def process_dedupe(self, share):"},{"line_number":166,"context_line":"        share_type_id \u003d share.get(\"share_type_id\")"},{"line_number":167,"context_line":"        dedupe_status \u003d share_types.get_share_type_extra_specs(share_type_id,"},{"line_number":168,"context_line":"                                                               \u0027dedupe\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"e10c73fb_9581a8fd","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":22},"in_reply_to":"f7ba328c_dcdc9eee","updated":"2026-02-09 17:29:06.000000000","message":"Done","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cb5231608479d4b5d186442492ceb65b972c0a50","unresolved":true,"context_lines":[{"line_number":616,"context_line":"        def normalize(s: str) -\u003e str:"},{"line_number":617,"context_line":"            return \" \".join((s or \"\").split()).strip()"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"        expected_schedule \u003d \"every 1 weeks on sunday at 12:00 AM\""},{"line_number":620,"context_line":"        needs_action \u003d any("},{"line_number":621,"context_line":"            job.get(\"id\") \u003d\u003d \"Dedupe\" and ("},{"line_number":622,"context_line":"                normalize(job.get(\"schedule\", \"\")).lower()"}],"source_content_type":"text/x-python","patch_set":10,"id":"6e107311_27d3a21a","line":619,"range":{"start_line":619,"start_character":28,"end_line":619,"end_character":65},"updated":"2026-02-05 15:45:08.000000000","message":"echo what @anoop.shukla@netapp.com asked about this; wondering if this can be a driver configuration in manila.conf to allow some control of this.","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"eb89504dae3de0f76a316933a660994149f38dc9","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        def normalize(s: str) -\u003e str:"},{"line_number":617,"context_line":"            return \" \".join((s or \"\").split()).strip()"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"        expected_schedule \u003d \"every 1 weeks on sunday at 12:00 AM\""},{"line_number":620,"context_line":"        needs_action \u003d any("},{"line_number":621,"context_line":"            job.get(\"id\") \u003d\u003d \"Dedupe\" and ("},{"line_number":622,"context_line":"                normalize(job.get(\"schedule\", \"\")).lower()"}],"source_content_type":"text/x-python","patch_set":10,"id":"aa0f9066_b78366a3","line":619,"range":{"start_line":619,"start_character":28,"end_line":619,"end_character":65},"in_reply_to":"6e107311_27d3a21a","updated":"2026-02-09 17:29:06.000000000","message":"Done","commit_id":"d99c95e6f6b698dee636f6af378af8dcb64d5841"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8472ab3d083f82a30272d8192917d57143711087","unresolved":true,"context_lines":[{"line_number":215,"context_line":"                LOG.error(message)"},{"line_number":216,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            if (dedupe_status.lower() \u003d\u003d \"true\" and"},{"line_number":219,"context_line":"                    manage_share_path not in paths):"},{"line_number":220,"context_line":"                message \u003d _("},{"line_number":221,"context_line":"                    \u0027Cannot manage share at \"%(path)s\" because \u0027"},{"line_number":222,"context_line":"                    \u0027dedupe is disabled for the given path\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"5866645c_f2657f23","line":219,"range":{"start_line":218,"start_character":12,"end_line":219,"end_character":52},"updated":"2026-02-13 22:03:59.000000000","message":"the value may not always be \"true\". It can be truthy because the API allows it, and there\u0027s a scheduler filter (the extra specs ops filter) that allows you to perform comparisons.\n\nSo, please use this method to get a true boolean out of the extra-spec: https://github.com/openstack/manila/blob/9b806a511882c4f99500778a13ccb86c5d4a00a6/manila/share/share_types.py#L427-L447","commit_id":"2c4a025a7aa1772a958e5a141eecdd9e6d26f0ec"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"9a5fe874c3c3e53971e9107bb071701e22a8cd8c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                LOG.error(message)"},{"line_number":216,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            if (dedupe_status.lower() \u003d\u003d \"true\" and"},{"line_number":219,"context_line":"                    manage_share_path not in paths):"},{"line_number":220,"context_line":"                message \u003d _("},{"line_number":221,"context_line":"                    \u0027Cannot manage share at \"%(path)s\" because \u0027"},{"line_number":222,"context_line":"                    \u0027dedupe is disabled for the given path\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"7da95bfd_49560bd1","line":219,"range":{"start_line":218,"start_character":12,"end_line":219,"end_character":52},"in_reply_to":"5866645c_f2657f23","updated":"2026-02-14 20:19:38.000000000","message":"Done","commit_id":"2c4a025a7aa1772a958e5a141eecdd9e6d26f0ec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8472ab3d083f82a30272d8192917d57143711087","unresolved":true,"context_lines":[{"line_number":942,"context_line":"                                                 read_only\u003dTrue)"},{"line_number":943,"context_line":"        return state_map"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    def update_dedupe_settings(self, share, manage_share_path):"},{"line_number":946,"context_line":"        \"\"\"Schedule dedupe job for a given share."},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"        :share: NFS/CIFS share"}],"source_content_type":"text/x-python","patch_set":15,"id":"853c501d_f154985c","line":945,"range":{"start_line":945,"start_character":8,"end_line":945,"end_character":30},"updated":"2026-02-13 22:03:59.000000000","message":"consider marking this a private method\n```suggestion\n    def _update_dedupe_settings(self, share, manage_share_path):\n```","commit_id":"2c4a025a7aa1772a958e5a141eecdd9e6d26f0ec"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"9a5fe874c3c3e53971e9107bb071701e22a8cd8c","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                                 read_only\u003dTrue)"},{"line_number":943,"context_line":"        return state_map"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    def update_dedupe_settings(self, share, manage_share_path):"},{"line_number":946,"context_line":"        \"\"\"Schedule dedupe job for a given share."},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"        :share: NFS/CIFS share"}],"source_content_type":"text/x-python","patch_set":15,"id":"118e07e6_f973c969","line":945,"range":{"start_line":945,"start_character":8,"end_line":945,"end_character":30},"in_reply_to":"853c501d_f154985c","updated":"2026-02-14 20:19:38.000000000","message":"Done","commit_id":"2c4a025a7aa1772a958e5a141eecdd9e6d26f0ec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8472ab3d083f82a30272d8192917d57143711087","unresolved":true,"context_lines":[{"line_number":955,"context_line":"            share_path \u003d self._get_container_path(share)"},{"line_number":956,"context_line":"        else:"},{"line_number":957,"context_line":"            share_path \u003d manage_share_path"},{"line_number":958,"context_line":"        paths.append(share_path)"},{"line_number":959,"context_line":"        assess_paths.append(share_path)"},{"line_number":960,"context_line":"        self._powerscale_api.modify_dedupe_settings(paths, assess_paths)"},{"line_number":961,"context_line":"        dedupe_job_schedule \u003d self._powerscale_api.get_dedupe_schedule()"},{"line_number":962,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"4195488b_018f567c","line":959,"range":{"start_line":958,"start_character":8,"end_line":959,"end_character":39},"updated":"2026-02-13 22:03:59.000000000","message":"nit: i\u0027d check if the share_path is in these lists.. \n```\n  if share_path not in paths:\n      paths.append(share_path)\n  if share_path not in assess_paths:\n      assess_paths.append(share_path)\n```","commit_id":"2c4a025a7aa1772a958e5a141eecdd9e6d26f0ec"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"9a5fe874c3c3e53971e9107bb071701e22a8cd8c","unresolved":false,"context_lines":[{"line_number":955,"context_line":"            share_path \u003d self._get_container_path(share)"},{"line_number":956,"context_line":"        else:"},{"line_number":957,"context_line":"            share_path \u003d manage_share_path"},{"line_number":958,"context_line":"        paths.append(share_path)"},{"line_number":959,"context_line":"        assess_paths.append(share_path)"},{"line_number":960,"context_line":"        self._powerscale_api.modify_dedupe_settings(paths, assess_paths)"},{"line_number":961,"context_line":"        dedupe_job_schedule \u003d self._powerscale_api.get_dedupe_schedule()"},{"line_number":962,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"e9ffa18a_b4a5df46","line":959,"range":{"start_line":958,"start_character":8,"end_line":959,"end_character":39},"in_reply_to":"4195488b_018f567c","updated":"2026-02-14 20:19:38.000000000","message":"Done","commit_id":"2c4a025a7aa1772a958e5a141eecdd9e6d26f0ec"}],"manila/tests/scheduler/drivers/test_filter.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":343,"context_line":"    def test__schedule_share_with_default_dedupe_value("},{"line_number":344,"context_line":"            self, _mock_service_get_all_by_topic):"},{"line_number":345,"context_line":"        sched, fake_context, request_spec \u003d self._setup_dedupe_fakes("},{"line_number":346,"context_line":"            {\u0027capabilities:dedupe\u0027: \u0027\u003cis\u003e True\u0027})"},{"line_number":347,"context_line":"        fakes.mock_host_manager_db_calls(_mock_service_get_all_by_topic)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        weighed_host \u003d sched._schedule_share(fake_context, request_spec, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"89c948a8_da62efdb","line":346,"updated":"2026-01-22 12:09:06.000000000","message":"This is not right please remove this changes.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def test__schedule_share_with_default_dedupe_value("},{"line_number":344,"context_line":"            self, _mock_service_get_all_by_topic):"},{"line_number":345,"context_line":"        sched, fake_context, request_spec \u003d self._setup_dedupe_fakes("},{"line_number":346,"context_line":"            {\u0027capabilities:dedupe\u0027: \u0027\u003cis\u003e True\u0027})"},{"line_number":347,"context_line":"        fakes.mock_host_manager_db_calls(_mock_service_get_all_by_topic)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        weighed_host \u003d sched._schedule_share(fake_context, request_spec, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"2ffea87f_4c2bd079","line":346,"in_reply_to":"89c948a8_da62efdb","updated":"2026-01-28 12:52:16.000000000","message":"Done. This change has been reverted to enable dedupe at driver level.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"}],"manila/tests/scheduler/test_host_manager.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                        \u0027create_share_from_snapshot_support\u0027: False,"},{"line_number":210,"context_line":"                        \u0027revert_to_snapshot_support\u0027: True,"},{"line_number":211,"context_line":"                        \u0027mount_snapshot_support\u0027: True,"},{"line_number":212,"context_line":"                        \u0027dedupe\u0027: True,"},{"line_number":213,"context_line":"                        \u0027compression\u0027: False,"},{"line_number":214,"context_line":"                        \u0027replication_type\u0027: None,"},{"line_number":215,"context_line":"                        \u0027replication_domain\u0027: None,"}],"source_content_type":"text/x-python","patch_set":7,"id":"eab6ff93_b9e6880d","line":212,"updated":"2026-01-22 12:09:06.000000000","message":"Please remove these all changes, this should at driver level.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                        \u0027create_share_from_snapshot_support\u0027: False,"},{"line_number":210,"context_line":"                        \u0027revert_to_snapshot_support\u0027: True,"},{"line_number":211,"context_line":"                        \u0027mount_snapshot_support\u0027: True,"},{"line_number":212,"context_line":"                        \u0027dedupe\u0027: True,"},{"line_number":213,"context_line":"                        \u0027compression\u0027: False,"},{"line_number":214,"context_line":"                        \u0027replication_type\u0027: None,"},{"line_number":215,"context_line":"                        \u0027replication_domain\u0027: None,"}],"source_content_type":"text/x-python","patch_set":7,"id":"c09a770a_7c792d4f","line":212,"in_reply_to":"eab6ff93_b9e6880d","updated":"2026-01-28 12:52:16.000000000","message":"Done. This change has been reverted to enable dedupe at driver level.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"}],"manila/tests/share/drivers/dell_emc/plugins/powerscale/test_powerscale.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e7a99ec13777c98ed9186b5e7ff0a1dcc42b2590","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        share \u003d {\"name\": self.SHARE_NAME, \"share_proto\": \u0027NFS\u0027,"},{"line_number":121,"context_line":"                 \"share_type_id\": \u0027fake-st-id\u0027, \"size\": 8}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        fake_share_type \u003d {"},{"line_number":124,"context_line":"            \u0027name\u0027: \u0027fake-st\u0027,"},{"line_number":125,"context_line":"            \u0027id\u0027: \u0027fake-st-id\u0027,"},{"line_number":126,"context_line":"            \u0027extra_specs\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"3cdec616_85a22a42","line":123,"updated":"2026-01-22 12:09:06.000000000","message":"duplicate code. please create this at class level or create a function to fetch this like self._get_share_type() and return this.","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"bd00ec073860627a1806c0a9d498f079181e632a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        share \u003d {\"name\": self.SHARE_NAME, \"share_proto\": \u0027NFS\u0027,"},{"line_number":121,"context_line":"                 \"share_type_id\": \u0027fake-st-id\u0027, \"size\": 8}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        fake_share_type \u003d {"},{"line_number":124,"context_line":"            \u0027name\u0027: \u0027fake-st\u0027,"},{"line_number":125,"context_line":"            \u0027id\u0027: \u0027fake-st-id\u0027,"},{"line_number":126,"context_line":"            \u0027extra_specs\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5d264d62_bf85e463","line":123,"in_reply_to":"3cdec616_85a22a42","updated":"2026-01-28 12:52:16.000000000","message":"Done","commit_id":"353214c24cebfce47975e2b67a3acd0fbd7cda10"}]}