)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0a1c78ecaecb9de4dbcd567bdc412c5eb696d7eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1903aaa4_cdde218f","updated":"2026-03-05 20:49:09.000000000","message":"Change looks good, thanks for updating it, Goutham","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4a5cc319077e2615163fc779629e3dc80d319b89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f9d8dd85_428cec72","updated":"2026-03-05 20:00:20.000000000","message":"Looks good, based on some job outputs that I\u0027ve looked at [1] too. Thanks\n\n[1] https://review.opendev.org/c/openstack/manila-tempest-plugin/+/972973/4#message-f5f318896fc3f025c7940424cdaacd4fcaa98e56","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e9e46c9fced58f38ff600c9e6fbfe3feca101f20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a50b425c_b1b82b8f","updated":"2026-03-05 15:28:10.000000000","message":"The code change looks good. I hae a question about how we plan to test this in CI in the next cycle. Since we are working with 2 modes here.","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"}],"manila/manager.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1f8a533d5fe197c245e8974037cf2bd8789a637f","unresolved":true,"context_lines":[{"line_number":178,"context_line":"                self.last_capabilities)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class ThreadPoolExecutorWithBlock(futures.ThreadPoolExecutor):"},{"line_number":182,"context_line":"    \"\"\"A thread pool executor with a submit blocking method"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    This class implements a method that allow to submit new workers but only if"}],"source_content_type":"text/x-python","patch_set":1,"id":"a96f46be_3ece8086","line":181,"range":{"start_line":181,"start_character":34,"end_line":181,"end_character":60},"updated":"2026-01-15 17:52:54.000000000","message":"if we\u0027d like to keep the green threads behavior, we should possibly go for asyncio instead","commit_id":"1de6d9e84d3cc1313695b06e7799eb00c4bb8089"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"25e93952ee55aa45f8e63658d67fc1a21e87a70d","unresolved":true,"context_lines":[{"line_number":178,"context_line":"                self.last_capabilities)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class ThreadPoolExecutorWithBlock(futures.ThreadPoolExecutor):"},{"line_number":182,"context_line":"    \"\"\"A thread pool executor with a submit blocking method"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    This class implements a method that allow to submit new workers but only if"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0e47d4a_354c0b01","line":181,"range":{"start_line":181,"start_character":34,"end_line":181,"end_character":60},"in_reply_to":"a96f46be_3ece8086","updated":"2026-01-20 20:15:39.000000000","message":"oslo.service provides a threadpool utility: \n\nhttps://github.com/openstack/oslo.service/blob/master/oslo_service/backend/_threading/threadgroup.py\n\n\n```\n\ntg \u003d ThreadGroup(thread_pool_size\u003d10)\n\n# Add work to the pool\ntg.add_thread(some_function, arg1, arg2)\n\n# Wait for all threads to complete\ntg.wait()\n\n# Stop the thread pool\ntg.stop(graceful\u003dTrue)\n```","commit_id":"1de6d9e84d3cc1313695b06e7799eb00c4bb8089"}],"releasenotes/notes/allow-enabling-native-threads-instead-of-eventlet-5a3c1b616c68bc62.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cc2e7b4e3ef9d954131341fc17e96adaee991aff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new environment variable, ``OS_MANILA_DISABLE_EVENTLET_PATCHING``, can"},{"line_number":5,"context_line":"    be set to ``1`` before launching the ``manila-scheduler``,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"064c7cbf_39cbe170","line":2,"updated":"2026-03-05 17:09:40.000000000","message":"thanks for updating the release note, it looks great","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e9e46c9fced58f38ff600c9e6fbfe3feca101f20","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    an external WSGI server (uWSGI, gunicorn, Apache mod_wsgi) since that"},{"line_number":10,"context_line":"    path already uses native threads."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This option is being introduced as a **technology preview**. A future"},{"line_number":13,"context_line":"    release of Manila will remove eventlet entirely and rely on native"},{"line_number":14,"context_line":"    threads. The preview lets operators and driver vendors validate their"},{"line_number":15,"context_line":"    deployments ahead of that change. **Do not enable this in production"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"179f5fb1_1cb20b70","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":73},"updated":"2026-03-05 15:28:10.000000000","message":"So here (and in the previous patch) we are calling out as supported but I lack some CI testing with these flags enabled, for both unit and integration tests, even if we have some known issues (which can turn the job to a non-voting for now). While we still keep both modes, we should have at least some minimal CI running on each mode, no? What do you think?","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cc2e7b4e3ef9d954131341fc17e96adaee991aff","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    an external WSGI server (uWSGI, gunicorn, Apache mod_wsgi) since that"},{"line_number":10,"context_line":"    path already uses native threads."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This option is being introduced as a **technology preview**. A future"},{"line_number":13,"context_line":"    release of Manila will remove eventlet entirely and rely on native"},{"line_number":14,"context_line":"    threads. The preview lets operators and driver vendors validate their"},{"line_number":15,"context_line":"    deployments ahead of that change. **Do not enable this in production"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"904645d4_4fa55d07","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":73},"in_reply_to":"05dd01fa_b8299b82","updated":"2026-03-05 17:09:40.000000000","message":"Good point, Douglas. I think we should also have a new manila-tempest-plugin job for the next release, could be dummy. I think that will help us in determining how these changes are behaving through the cycle.","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bfc9930c68a3e09202d9fbcb284cd8c52ce933fd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    an external WSGI server (uWSGI, gunicorn, Apache mod_wsgi) since that"},{"line_number":10,"context_line":"    path already uses native threads."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This option is being introduced as a **technology preview**. A future"},{"line_number":13,"context_line":"    release of Manila will remove eventlet entirely and rely on native"},{"line_number":14,"context_line":"    threads. The preview lets operators and driver vendors validate their"},{"line_number":15,"context_line":"    deployments ahead of that change. **Do not enable this in production"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"05dd01fa_b8299b82","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":73},"in_reply_to":"179f5fb1_1cb20b70","updated":"2026-03-05 17:03:15.000000000","message":"I\u0027m overwriting the same note so we can clarify that this is possible, but not meant for production yet.. \n\nYes! we need a unit test job, will add one. We\u0027re using a CI job here to run tempest: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/972973 \n\nWe\u0027ll create at least one non-eventlet job once the job passes consistently..","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4a5cc319077e2615163fc779629e3dc80d319b89","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    an external WSGI server (uWSGI, gunicorn, Apache mod_wsgi) since that"},{"line_number":10,"context_line":"    path already uses native threads."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    This option is being introduced as a **technology preview**. A future"},{"line_number":13,"context_line":"    release of Manila will remove eventlet entirely and rely on native"},{"line_number":14,"context_line":"    threads. The preview lets operators and driver vendors validate their"},{"line_number":15,"context_line":"    deployments ahead of that change. **Do not enable this in production"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6fd140e5_ff073750","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":73},"in_reply_to":"904645d4_4fa55d07","updated":"2026-03-05 20:00:20.000000000","message":"It could be added as non-voting initially, and once is stable, moved to voting. I think that the depends-on change is valuable since it tests against more jobs, but wouldn\u0027t trigger for all other proposed changes in master, while we still support both modes.\n\nI think that the note and the warning log messages are clear enough about *not using in production environments*.","commit_id":"1d9352526bce48e35ec4a92e39f01c38e9e3e0de"}]}