)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5d8e1aaaa71f41ae28b1d681f834ec372d5f5c65","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f26edfd3_f14d4570","line":22,"updated":"2026-11-11 20:56:03.000000000","message":"can you please also add the Closes-Bug tag here, referencing the bug you created? Sorry, I missed this earlier","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"58ec9aec095ddf180a84327331ab5377902fe4d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0e5437b0_ab2a15d8","line":22,"in_reply_to":"3ea19ba6_b82ce418","updated":"2026-11-12 12:00:51.000000000","message":"Done. Thx","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"119e54b4775df380e9a99a8315424908f4959624","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3ea19ba6_b82ce418","line":22,"in_reply_to":"f26edfd3_f14d4570","updated":"2026-11-12 06:09:21.000000000","message":"+1 \n\nI\u0027d like to see this please. We should be writing up an OpenStack Security Note and getting this fix backported to all stable releases.","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"380543965bea5889c900e7dbfb235dd299176f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"51eed675_05a7494a","updated":"2026-10-27 14:34:56.000000000","message":"Hello, thank you for the fix. Could you please create a launchpad bug for this issue?\n\nIn Manila, we deny access by default, so that is a security flaw in our end. Also I believe that if the two fixes are not in the same update access from rw, to ro, we should split this into two changes. Updating access is a way more recent feature, which will limit how further we can backport this fix.","commit_id":"620cae2150beba5aca4a4af12f8b3366818642b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d125706234b2e0a74d46d3995b5eb8cffbbd84b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6e47df32_4ae89b36","in_reply_to":"51eed675_05a7494a","updated":"2026-10-28 14:57:10.000000000","message":"Thank you for the bug report [1] - I think that confirms that this is two separate issues. If this is an issue in the first place, shouldn\u0027t we simply fix and do not offer the config option?\n\n[1] https://bugs.launchpad.net/manila/+bug/2172349","commit_id":"620cae2150beba5aca4a4af12f8b3366818642b8"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"63f7d5895c3848c8100a9aedd7806a33813ddd62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d7c451b0_ab20bbac","in_reply_to":"6e47df32_4ae89b36","updated":"2026-10-29 00:16:36.000000000","message":"Done. Only deny by default is left. I deleted \"allow access\" param","commit_id":"620cae2150beba5aca4a4af12f8b3366818642b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e5bf55387ed0308066c084e71232a3e314bc1bf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c1e3ea49_5f2b5efb","updated":"2026-11-05 12:33:12.000000000","message":"LGTM, thank you Volodymyr. I have one minor comment inline, that must be addressed but I\u0027m okay if this is in a follow-up change. DO you have any CI tests results? Or tempest tests ran? We need to ensure we\u0027re not breaking operations","commit_id":"cfd84db32b46d2c4e866fb30f806ec142c438333"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"3d2f9edd0af8b1a65dd9de4f1ab917e2820f76a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f88e52a2_af91b9b9","updated":"2026-11-05 15:18:58.000000000","message":"Please add the bug being closed in the release note.","commit_id":"cfd84db32b46d2c4e866fb30f806ec142c438333"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"50a73edd2b4ee3ac907f92aa2bca32df9421a5ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4be09219_bd8302a9","in_reply_to":"c1e3ea49_5f2b5efb","updated":"2026-11-05 15:50:33.000000000","message":"Yes. You can see VASTData CI above. Here is link:\nhttp://vast-zuul-ci-logs.s3-website-eu-west-1.amazonaws.com/t/opendev/buildset/717d0abdca364e8789b541eab6103518","commit_id":"cfd84db32b46d2c4e866fb30f806ec142c438333"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"50a73edd2b4ee3ac907f92aa2bca32df9421a5ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d40f696d_1b964f79","in_reply_to":"f88e52a2_af91b9b9","updated":"2026-11-05 15:50:33.000000000","message":"Done","commit_id":"cfd84db32b46d2c4e866fb30f806ec142c438333"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"40096359d6a121df75503182b27ef924a5b72428","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9ec4ac33_d6a83e33","updated":"2026-11-11 19:34:55.000000000","message":"LGTM, thank you @volodymyr.boiko@vastdata.com","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"119e54b4775df380e9a99a8315424908f4959624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1bd9f22a_4639e934","updated":"2026-11-12 06:09:21.000000000","message":"Thanks for these bug fixes @volodymyr.boiko@vastdata.com\n\nPlease see comments inline","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"35a8787730d8426886b0da86c433b9ca33233aef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7ff54117_5dbd8901","updated":"2026-11-05 19:40:59.000000000","message":"recheck\nflaky test on the LVM job","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cc8e763823dc933c8e9f572203a232a507b29f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7017f4fc_7430345d","updated":"2026-11-14 06:09:13.000000000","message":"@volodymyr.boiko@vastdata.com: Could you please cherry-pick this to older stable branches?","commit_id":"459d4fdf7f2c8e12428964c850acab7fc507ba4b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c31f1b94f57d2ccfc9f4ed43a04e70bef7db1a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2556cac4_0645808a","updated":"2026-11-12 15:45:18.000000000","message":"LGTM, thank you Volodymyr","commit_id":"459d4fdf7f2c8e12428964c850acab7fc507ba4b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29234fafdd5811c56e81bd761d82ac6e9631cc5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e6ad471b_1fa3f949","updated":"2026-11-13 23:07:53.000000000","message":"LGTM, thanks @volodymyr.boiko@vastdata.com","commit_id":"459d4fdf7f2c8e12428964c850acab7fc507ba4b"}],"manila/share/drivers/vastdata/driver_util.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e5bf55387ed0308066c084e71232a3e314bc1bf9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import copy"},{"line_number":16,"context_line":"import ipaddress"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"import types"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":11,"id":"d5f0eb85_2904dcea","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":14},"updated":"2026-11-05 12:33:12.000000000","message":"netaddr is a third party library, so it should not be alongside the stdlib","commit_id":"cfd84db32b46d2c4e866fb30f806ec142c438333"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"50a73edd2b4ee3ac907f92aa2bca32df9421a5ed","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import copy"},{"line_number":16,"context_line":"import ipaddress"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"import types"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":11,"id":"ddabb2a1_564322f2","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":14},"in_reply_to":"d5f0eb85_2904dcea","updated":"2026-11-05 15:50:33.000000000","message":"Done","commit_id":"cfd84db32b46d2c4e866fb30f806ec142c438333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"119e54b4775df380e9a99a8315424908f4959624","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        \u003e\u003e\u003e expand_ip_or_cidr(\"10.0.0.0/30\")"},{"line_number":267,"context_line":"        [\"10.0.0.1\", \"10.0.0.2\"]"},{"line_number":268,"context_line":"    \"\"\""},{"line_number":269,"context_line":"    return [str(ip) for ip in netaddr.IPNetwork(access_to).iter_hosts()]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def decorate_methods_with(dec):"}],"source_content_type":"text/x-python","patch_set":12,"id":"0181bbe6_bbfbdb3e","line":269,"range":{"start_line":269,"start_character":0,"end_line":269,"end_character":72},"updated":"2026-11-12 06:09:21.000000000","message":"a \"0.0.0.0/0\" access rule would expand to ~4.2B host strings in memory here; and a /64 Ipv6 address will hang the share manager trying to materialize every host\n\nAre you sure you\u0027d like to do this?\nis there a \"allow-all\" rule so you can avoid this sort of expansion (for 0.0.0.0/0 or ::/0) or, maybe you want to guard against huge subnets?","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"58ec9aec095ddf180a84327331ab5377902fe4d6","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        \u003e\u003e\u003e expand_ip_or_cidr(\"10.0.0.0/30\")"},{"line_number":267,"context_line":"        [\"10.0.0.1\", \"10.0.0.2\"]"},{"line_number":268,"context_line":"    \"\"\""},{"line_number":269,"context_line":"    return [str(ip) for ip in netaddr.IPNetwork(access_to).iter_hosts()]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def decorate_methods_with(dec):"}],"source_content_type":"text/x-python","patch_set":12,"id":"4da87e39_b9d3826c","line":269,"range":{"start_line":269,"start_character":0,"end_line":269,"end_character":72},"in_reply_to":"0181bbe6_bbfbdb3e","updated":"2026-11-12 12:00:51.000000000","message":"Vast indeed supports providing ip ranges so no need to unroll every range. Updated.","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"}],"manila/tests/share/drivers/vastdata/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"de7ead1d0b9bfa67530f0255c45aec3cf523bdbf","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            execute\u003dmock.MagicMock(), configuration\u003dself.fake_conf"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        self._driver.do_setup(self._context)"},{"line_number":87,"context_line":"        if self.fake_conf.vast_api_token:"},{"line_number":88,"context_line":"            m_auth_token.assert_not_called()"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            m_auth_token.assert_called_once()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_do_setup(self):"},{"line_number":93,"context_line":"        session \u003d self._driver.rest.session"}],"source_content_type":"text/x-python","patch_set":1,"id":"00aed6c6_54560afc","line":90,"range":{"start_line":87,"start_character":0,"end_line":90,"end_character":45},"updated":"2026-01-16 21:24:28.000000000","message":"seems to be breaking some unit tests.. since you\u0027re not setting the value here and the default is \"\", when do you expect the condition to be true?","commit_id":"9039f43a19c9bca77d18a1ed676f15b3e9821642"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"d2d4bc934c0148990c08cea60592fcc51080cbea","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            execute\u003dmock.MagicMock(), configuration\u003dself.fake_conf"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        self._driver.do_setup(self._context)"},{"line_number":87,"context_line":"        if self.fake_conf.vast_api_token:"},{"line_number":88,"context_line":"            m_auth_token.assert_not_called()"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            m_auth_token.assert_called_once()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_do_setup(self):"},{"line_number":93,"context_line":"        session \u003d self._driver.rest.session"}],"source_content_type":"text/x-python","patch_set":1,"id":"f077ab30_ed65ac9a","line":90,"range":{"start_line":87,"start_character":0,"end_line":90,"end_character":45},"in_reply_to":"00aed6c6_54560afc","updated":"2026-10-13 10:35:17.000000000","message":"I deleted this test","commit_id":"9039f43a19c9bca77d18a1ed676f15b3e9821642"}],"manila/tests/share/drivers/vastdata/test_driver_util.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"119e54b4775df380e9a99a8315424908f4959624","unresolved":true,"context_lines":[{"line_number":262,"context_line":"                            \"192.168.1.7\", \"192.168.1.8\", \"192.168.1.9\","},{"line_number":263,"context_line":"                            \"192.168.1.10\", \"192.168.1.11\", \"192.168.1.12\","},{"line_number":264,"context_line":"                            \"192.168.1.13\", \"192.168.1.14\"]),"},{"line_number":265,"context_line":"    )"},{"line_number":266,"context_line":"    @ddt.unpack"},{"line_number":267,"context_line":"    def test_expand_ip_or_cidr(self, input_cidr, expected):"},{"line_number":268,"context_line":"        result \u003d driver_util.expand_ip_or_cidr(input_cidr)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3500798e_126ac663","line":265,"updated":"2026-11-12 06:09:21.000000000","message":"this logic won\u0027t work well for 0.0.0.0/0","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"58ec9aec095ddf180a84327331ab5377902fe4d6","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                            \"192.168.1.7\", \"192.168.1.8\", \"192.168.1.9\","},{"line_number":263,"context_line":"                            \"192.168.1.10\", \"192.168.1.11\", \"192.168.1.12\","},{"line_number":264,"context_line":"                            \"192.168.1.13\", \"192.168.1.14\"]),"},{"line_number":265,"context_line":"    )"},{"line_number":266,"context_line":"    @ddt.unpack"},{"line_number":267,"context_line":"    def test_expand_ip_or_cidr(self, input_cidr, expected):"},{"line_number":268,"context_line":"        result \u003d driver_util.expand_ip_or_cidr(input_cidr)"}],"source_content_type":"text/x-python","patch_set":12,"id":"12475347_30aa3d85","line":265,"in_reply_to":"3500798e_126ac663","updated":"2026-11-12 12:00:51.000000000","message":"updated","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"29234fafdd5811c56e81bd761d82ac6e9631cc5b","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    )"},{"line_number":284,"context_line":"    def test_expand_ip_or_cidr_invalid_input(self, invalid_input):"},{"line_number":285,"context_line":"        # Test that invalid inputs raise appropriate exceptions"},{"line_number":286,"context_line":"        import netaddr"},{"line_number":287,"context_line":"        self.assertRaises("},{"line_number":288,"context_line":"            (netaddr.core.AddrFormatError, ValueError),"},{"line_number":289,"context_line":"            driver_util.expand_ip_or_cidr,"}],"source_content_type":"text/x-python","patch_set":13,"id":"91310e8b_ab5aaccc","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":22},"updated":"2026-11-13 23:07:53.000000000","message":"why is this import done here, and not at the module level - i.e., what do we save?","commit_id":"459d4fdf7f2c8e12428964c850acab7fc507ba4b"}],"releasenotes/notes/fix-vastdata-access-rule-update-duplicates-7ff8dfe053d7d659.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"119e54b4775df380e9a99a8315424908f4959624","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    (e.g., from \u0027rw\u0027 to \u0027ro\u0027) would result in the IP address appearing"},{"line_number":6,"context_line":"    in both \u0027nfs_read_write\u0027 and \u0027nfs_read_only\u0027 lists on the VAST cluster."},{"line_number":7,"context_line":"    The driver now replaces both lists with the access rules Manila"},{"line_number":8,"context_line":"    wants on the share."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"d5bc40f8_991f5cd2","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":23},"updated":"2026-11-12 06:09:21.000000000","message":"And you\u0027re also closing a security hole that this driver had where it didn\u0027t ensure the \"deny-by-default\" behavior on new shares?\n\nPlease add a \"security\" section instead of \"fixes\" and please link the launchpad bug for more details.","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"},{"author":{"_account_id":36962,"name":"Volodymyr Boiko","display_name":"Volodymyr","email":"volodymyr.boiko@vastdata.com","username":"fnn45"},"change_message_id":"58ec9aec095ddf180a84327331ab5377902fe4d6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    (e.g., from \u0027rw\u0027 to \u0027ro\u0027) would result in the IP address appearing"},{"line_number":6,"context_line":"    in both \u0027nfs_read_write\u0027 and \u0027nfs_read_only\u0027 lists on the VAST cluster."},{"line_number":7,"context_line":"    The driver now replaces both lists with the access rules Manila"},{"line_number":8,"context_line":"    wants on the share."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e9670050_efa8121c","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":23},"in_reply_to":"d5bc40f8_991f5cd2","updated":"2026-11-12 12:00:51.000000000","message":"Done","commit_id":"1c8e1028a70c0100432249a8c44e0b05b305ae2d"}]}
