)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2f226f5934def350cc990c6bb545932931c40167","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Pawar \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-01-29 14:21:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: cDOT add share_id, project_id, name, type, proto as volume comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume comment with necessary debugging information is added during"},{"line_number":10,"context_line":"volume create/modify and ensure calls. The information includes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9e7743f4_417b8f88","line":7,"updated":"2026-02-04 12:45:08.000000000","message":"I think we should use the term ONTAP instead of cDOT.","commit_id":"ce409abdf1574d88f22dfc5db4aa98b9c4f9bafe"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e1a00e48b45de27ad377faba4b564b4d18d9c4ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Pawar \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-01-29 14:21:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: cDOT add share_id, project_id, name, type, proto as volume comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume comment with necessary debugging information is added during"},{"line_number":10,"context_line":"volume create/modify and ensure calls. The information includes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"86a25d15_88a9c59c","line":7,"in_reply_to":"9e7743f4_417b8f88","updated":"2026-02-09 08:18:52.000000000","message":"Done","commit_id":"ce409abdf1574d88f22dfc5db4aa98b9c4f9bafe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e745f31205e03826645a108378ee20266632585f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"32b4377a_530de1ab","updated":"2026-01-29 07:35:23.000000000","message":"Run-NetApp CI","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"5ac61f5695a81ac158c77d9fdc2faf5355d33a83","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"030f292c_ab19b6db","updated":"2026-01-29 12:37:25.000000000","message":"Thanks Kiran for working on this, added few comments, please take a look. Add the release note for this patch.","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a50d45c3e768c89e1fbe3ab0d820b61f796aa925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29bc8ea3_396f39c7","in_reply_to":"030f292c_ab19b6db","updated":"2026-01-29 14:22:47.000000000","message":"Done","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2f226f5934def350cc990c6bb545932931c40167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3f864c1_65da0b46","updated":"2026-02-04 12:45:08.000000000","message":"Please take a look at comments.","commit_id":"ce409abdf1574d88f22dfc5db4aa98b9c4f9bafe"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"62ecd54b3a03f6ee05feef2fbbbbbc2d3a193dce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0179d8d4_232d7ab3","updated":"2026-02-10 04:22:37.000000000","message":"LGTM","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"17df4b8b9db1411bc36e408f509e6a0128f488ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a38768f5_eaebea79","updated":"2026-02-09 14:47:20.000000000","message":"LGTM","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8bac360876485ddc5cc819247c7b6f79f450b933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad96a004_94d8371e","updated":"2026-02-10 16:09:35.000000000","message":"Looks good, one question inline though. THanks for working on this change, Kiran","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"10891dd87c9161b31f2c2cd42580939264fcd4db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cae1c9c2_7522c5e6","updated":"2026-02-09 10:37:54.000000000","message":"recheck","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"6be4e0799e950dfb6664e24fcfdaf8543910a1af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"63e3c77b_601605d4","updated":"2026-02-12 02:45:37.000000000","message":"LGTM","commit_id":"8750110bf28229c0df225cf9e04882f9a24197bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f139eddc831ffb9b60bd87cfbfac2acf31972749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b1b77bce_b918aafc","updated":"2026-02-12 15:10:42.000000000","message":"LGTM, thanks Kiran","commit_id":"8750110bf28229c0df225cf9e04882f9a24197bf"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"b75f22bda1435f114daebf4c9e4bfedf4e65adf2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3424f7dd_3b703dcf","updated":"2026-02-16 11:03:52.000000000","message":"Hello, \nI am wondering if it is a good idea to use the comment section of the volume, which is a feature available for other purposes and can break some existing integrations.\nCould it be done with metadatas instead ?\n\nAlso, is it a good idea to include share_name (personal customer data) into the NetApp cluster ?","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"eb17d884d410b552d45bfe7b61b110298a925461","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"baa42e4e_6d463f4d","updated":"2026-02-19 15:46:51.000000000","message":"LGTM","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"669d50eca0a00890f327ae88ddda839aa1219186","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5dc238b2_47cedcd4","in_reply_to":"1a84aea1_e8df0753","updated":"2026-02-16 16:40:41.000000000","message":"re share name: It helps greatly to quickly make the connection between a customer complaining I have a problem with share \u0027beloved_pet\u0027, who does not care about share instance IDs or whatever, and the representation as volume on the back end.\n\nre volume tags: yes, this would be better than abusing the comment field. At the time we introduced this downstream, volume tagging was not available, yet. Here and now we have the chance to introduce this directly via tagging +1","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"664e9832bc73f6cb1f9e0d230f13e27459c3d221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"216651fc_af73de16","in_reply_to":"33c4565b_a63a3401","updated":"2026-04-21 05:05:32.000000000","message":"Added as volume tags.","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"b9a27cff27f3a9e8f40bb1e413bc19a150d195b5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1a84aea1_e8df0753","in_reply_to":"3424f7dd_3b703dcf","updated":"2026-02-16 13:09:46.000000000","message":"By metadatas I mean volume tagging available since 9.14.1\nhttps://docs.netapp.com/us-en/ontap/assign-tags-volumes-task.html","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"521934c2181e26482dbbdd682370335ec043307a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e81c5f10_f30ac750","in_reply_to":"40910497_94dceb03","updated":"2026-02-18 16:40:46.000000000","message":"Hello!\n\nYes i am talking about the _tags attribute from REST API but doesn\u0027t seem to be available from ONTAPI\n\nSince we need it in NetApp Harvest and we are still using zapi collectors, we cannot use tags for now.\n\nWe are currently updating volume comment in a manila share creation post_hook waiting to be able to fully use the volume tags.\n\nMaybe we could work on the tags solution and be able to configure a prefix for the keys and a list of share attributes we wanna tag ?\n\nRegards, \nRomain","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"21110cf7fe7633f9678117802e2aa69df138e54d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f4173d9a_3821f833","in_reply_to":"5dc238b2_47cedcd4","updated":"2026-02-17 16:41:00.000000000","message":"thank you for your reply\nwe also use the comments because tags didn\u0027t exist when we started,\nwe needed the project_id and share_id in the comment for monitoring purposes.\ni think it is very important that this feature is at least disableable in the options, preferably deactivated by default in my opinion","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff3fc54e6a516cd2fec9bf148b3f00c0a2d753ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b74484a_f8e9f24b","in_reply_to":"79fdee72_fbe0529f","updated":"2026-02-19 17:59:03.000000000","message":"My 0.02c on this is that overloading a comment field seems like a bad approach, it makes things hard to parse... we\u0027ve dealt with that sort of thing in Manila too - for example, the Kubernetes CSI driver uses the \"description\" field to tag resources because metadata capabilities didn\u0027t exist for some of them.. \n\nAren\u0027t there existing workflows in the driver where the ONTAP driver uses REST where possible even when it uses ZAPI for most things?","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"eb17d884d410b552d45bfe7b61b110298a925461","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"18802d79_44f9aaeb","in_reply_to":"79fdee72_fbe0529f","updated":"2026-02-19 15:46:51.000000000","message":"_tags are not available on ZAPIs and may/will not be available on ZAPIs. _tags is a good way to tag resources on ONTAP.\n\nIMO, as long as created shares by Manila are not managed outside, we can use comments. Customers who need the comments to be used for other purposes still have a way to use _tags for their tagging requirements.","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"8ca6b81c4d4e564753b3ff583482e1bcc82e4288","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"33c4565b_a63a3401","in_reply_to":"9b74484a_f8e9f24b","updated":"2026-02-19 19:25:37.000000000","message":"The way tags operate on ONTAP are a bit different. Tags are key value pairs. So to fetch them back it will require to provide a key. But I don\u0027t disagree that this can be a REST Only implementation instead. We can force REST for adding comment as tag with a key.\n\nAnother thing we may want to consider is, any tag or comment added on source site would get replicated to the replicas when they are protected with snapmirror. So, if in future there is a requirement of having a different tag/comment for the replica, it may not be easy to manage.","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"edf3bc8245481b390f06dd9eff05b73b52691303","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"79fdee72_fbe0529f","in_reply_to":"e81c5f10_f30ac750","updated":"2026-02-18 16:45:15.000000000","message":"We can not use tags until we drop ZAPI support. I will better keep volume comment as it is and add enable/disable via conf option with default false. In your deployment, you can then use comment as you need.","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ba35d1a732687cb63a68dd02c4ddc114b47bf86e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"40910497_94dceb03","in_reply_to":"f4173d9a_3821f833","updated":"2026-02-18 12:33:26.000000000","message":"yes, I am planning to keep this controlled via config option. Are you ok with comment then or want to move to tags ? \n\nAlso, are you referring to \"_tags\" from REST API(9.13.1 and above), I dont see similar in ZAPI at  https://docs.netapp.com/p/ontap/nmsdk/9.8/Reference-Manual-For-Ontap-9131-Apis.pdf","commit_id":"c98eb5587f79372d5eac1d9bee547a433963bab0"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"0cd39cda2d7e0a56eb806e4d7f6c0059297cb19e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7d63a28b_a7e37753","updated":"2026-04-21 07:35:10.000000000","message":"This is now a substantially new change, thanks for the big reworking!\nSee my comments inline.","commit_id":"fc75cf7d199585c83e1faa3bf81b669675ab63ff"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"f9f9da60e8985215a4814e89c9b809a50fd0fead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"55fdb9c1_8a4f5d4f","updated":"2026-05-08 12:32:04.000000000","message":"LGTM","commit_id":"b5bac1511f3bfb0dfcd670daea30478589a17a1b"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"c689ed245dd5a46a9bfeaddfbc0f6c1f3e605354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"df154d24_c3fd7a4a","updated":"2026-05-06 04:44:17.000000000","message":"LGTM.","commit_id":"b5bac1511f3bfb0dfcd670daea30478589a17a1b"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"3cc41372a880482d841ce537e8b01183e173b1b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1b4afac2_225f9e57","updated":"2026-05-05 06:30:21.000000000","message":"Run-NetApp CI","commit_id":"b5bac1511f3bfb0dfcd670daea30478589a17a1b"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"929a2caae359765b942dbf2d127810841d813ec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"99ffa020_320dfbc5","updated":"2026-05-05 10:48:29.000000000","message":"Run-NetApp CI","commit_id":"b5bac1511f3bfb0dfcd670daea30478589a17a1b"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"ca810b0cce3d8b26b56ed59722f50dda0410b992","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"05e65317_10a7e6fb","updated":"2026-04-21 12:01:53.000000000","message":"lgtm","commit_id":"b5bac1511f3bfb0dfcd670daea30478589a17a1b"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"5ac61f5695a81ac158c77d9fdc2faf5355d33a83","unresolved":true,"context_lines":[{"line_number":2490,"context_line":"                                    snaplock_type\u003dNone):"},{"line_number":2491,"context_line":"        api_args \u003d {"},{"line_number":2492,"context_line":"            \u0027volume-type\u0027: volume_type,"},{"line_number":2493,"context_line":"            \u0027volume-comment\u0027: comment,"},{"line_number":2494,"context_line":"            \u0027space-reserve\u0027: (\u0027none\u0027 if thin_provisioned else \u0027volume\u0027),"},{"line_number":2495,"context_line":"        }"},{"line_number":2496,"context_line":"        if volume_type !\u003d \u0027dp\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ea8edbb_eab7325b","line":2493,"range":{"start_line":2493,"start_character":13,"end_line":2493,"end_character":37},"updated":"2026-01-29 12:37:25.000000000","message":"This need to add under condition, comment should be added only when it is not empty string.\nif comment:\n api_args[\u0027volume-comment\u0027\u0027] \u003d comment","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a50d45c3e768c89e1fbe3ab0d820b61f796aa925","unresolved":false,"context_lines":[{"line_number":2490,"context_line":"                                    snaplock_type\u003dNone):"},{"line_number":2491,"context_line":"        api_args \u003d {"},{"line_number":2492,"context_line":"            \u0027volume-type\u0027: volume_type,"},{"line_number":2493,"context_line":"            \u0027volume-comment\u0027: comment,"},{"line_number":2494,"context_line":"            \u0027space-reserve\u0027: (\u0027none\u0027 if thin_provisioned else \u0027volume\u0027),"},{"line_number":2495,"context_line":"        }"},{"line_number":2496,"context_line":"        if volume_type !\u003d \u0027dp\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7811153f_8a33213d","line":2493,"range":{"start_line":2493,"start_character":13,"end_line":2493,"end_character":37},"in_reply_to":"3ea8edbb_eab7325b","updated":"2026-01-29 14:22:47.000000000","message":"Done","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"0cd39cda2d7e0a56eb806e4d7f6c0059297cb19e","unresolved":true,"context_lines":[{"line_number":3077,"context_line":"        request \u003d {\u0027_tags\u0027: tags}"},{"line_number":3078,"context_line":"        url_params \u003d {\u0027volume_uuid\u0027: volume_uuid}"},{"line_number":3079,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":3080,"context_line":"        self.send_request(\u0027volume-modify-tags\u0027, api_args\u003dapi_args,"},{"line_number":3081,"context_line":"                          use_zapi\u003dFalse)"},{"line_number":3082,"context_line":""},{"line_number":3083,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":9,"id":"eb70eb2a_a0c7c4fe","line":3080,"updated":"2026-04-21 07:35:10.000000000","message":"I think we should add some error handling.\n\nImho, we should catch all errors and log an error, but don\u0027t raise, in case tagging is not working.\n\nWe have update_share, which is retrying to apply the tags anyway. An error here should not block successful volume creation, I think","commit_id":"fc75cf7d199585c83e1faa3bf81b669675ab63ff"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7a79d4fcf5986e192177495322a17f9c4b09beac","unresolved":false,"context_lines":[{"line_number":3077,"context_line":"        request \u003d {\u0027_tags\u0027: tags}"},{"line_number":3078,"context_line":"        url_params \u003d {\u0027volume_uuid\u0027: volume_uuid}"},{"line_number":3079,"context_line":"        api_args \u003d self._format_request(request, url_params\u003durl_params)"},{"line_number":3080,"context_line":"        self.send_request(\u0027volume-modify-tags\u0027, api_args\u003dapi_args,"},{"line_number":3081,"context_line":"                          use_zapi\u003dFalse)"},{"line_number":3082,"context_line":""},{"line_number":3083,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ba76af1_555f5cf2","line":3080,"in_reply_to":"eb70eb2a_a0c7c4fe","updated":"2026-04-21 10:56:45.000000000","message":"Done","commit_id":"fc75cf7d199585c83e1faa3bf81b669675ab63ff"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"5ac61f5695a81ac158c77d9fdc2faf5355d33a83","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"            body[\u0027qos.policy.name\u0027] \u003d qos_policy_group"},{"line_number":1103,"context_line":"        if adaptive_qos_policy_group is not None:"},{"line_number":1104,"context_line":"            body[\u0027qos.policy.name\u0027] \u003d adaptive_qos_policy_group"},{"line_number":1105,"context_line":"        if comment is not None:"},{"line_number":1106,"context_line":"            body[\u0027comment\u0027] \u003d comment"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        if encrypt is True:"},{"line_number":1109,"context_line":"            if not self.features.FLEXVOL_ENCRYPTION:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d7569cd6_c88d8c02","line":1106,"range":{"start_line":1105,"start_character":8,"end_line":1106,"end_character":37},"updated":"2026-01-29 12:37:25.000000000","message":"As default value of comment is \u0027\u0027, in this case condition should be \nif comment: NOT if comment is not None:\n\nbelow condition will be always pass.\nif comment is not None:\n            body[\u0027comment\u0027] \u003d comment","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a50d45c3e768c89e1fbe3ab0d820b61f796aa925","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"            body[\u0027qos.policy.name\u0027] \u003d qos_policy_group"},{"line_number":1103,"context_line":"        if adaptive_qos_policy_group is not None:"},{"line_number":1104,"context_line":"            body[\u0027qos.policy.name\u0027] \u003d adaptive_qos_policy_group"},{"line_number":1105,"context_line":"        if comment is not None:"},{"line_number":1106,"context_line":"            body[\u0027comment\u0027] \u003d comment"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        if encrypt is True:"},{"line_number":1109,"context_line":"            if not self.features.FLEXVOL_ENCRYPTION:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d0774075_4ce55219","line":1106,"range":{"start_line":1105,"start_character":8,"end_line":1106,"end_character":37},"in_reply_to":"d7569cd6_c88d8c02","updated":"2026-01-29 14:22:47.000000000","message":"Done","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"5ac61f5695a81ac158c77d9fdc2faf5355d33a83","unresolved":true,"context_lines":[{"line_number":1299,"context_line":"                                        snapshot_reserve,"},{"line_number":1300,"context_line":"                                        mount_point_name,"},{"line_number":1301,"context_line":"                                        snaplock_type,"},{"line_number":1302,"context_line":"                                        comment\u003dNone,"},{"line_number":1303,"context_line":"                                        **provisioning_options):"},{"line_number":1304,"context_line":"        \"\"\"Wait for starting create FlexGroup volume succeed."},{"line_number":1305,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0efec87c_278c1f6d","line":1302,"range":{"start_line":1302,"start_character":40,"end_line":1302,"end_character":52},"updated":"2026-01-29 12:37:25.000000000","message":"Can you make it consistence, make it \u0027\u0027 instead of None. I am seeing few places you are using None and few places you are using \u0027\u0027.","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a50d45c3e768c89e1fbe3ab0d820b61f796aa925","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"                                        snapshot_reserve,"},{"line_number":1300,"context_line":"                                        mount_point_name,"},{"line_number":1301,"context_line":"                                        snaplock_type,"},{"line_number":1302,"context_line":"                                        comment\u003dNone,"},{"line_number":1303,"context_line":"                                        **provisioning_options):"},{"line_number":1304,"context_line":"        \"\"\"Wait for starting create FlexGroup volume succeed."},{"line_number":1305,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0b1b763e_28645057","line":1302,"range":{"start_line":1302,"start_character":40,"end_line":1302,"end_character":52},"in_reply_to":"0efec87c_278c1f6d","updated":"2026-01-29 14:22:47.000000000","message":"Done","commit_id":"17bc8d7ee232eb1bb56bdfc840258e0efe6a2e62"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2f226f5934def350cc990c6bb545932931c40167","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        return self.configuration.netapp_volume_name_template % {"},{"line_number":383,"context_line":"            \u0027share_id\u0027: share_id.replace(\u0027-\u0027, \u0027_\u0027)}"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _generate_backend_share_comment(self, share):"},{"line_number":386,"context_line":"        \"\"\"Generate share comment.\"\"\""},{"line_number":387,"context_line":"        # caution: share_type is nullable"},{"line_number":388,"context_line":"        if share.get(\u0027share_type\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"56c71985_e17b7a58","line":385,"updated":"2026-02-04 12:45:08.000000000","message":"Need to keep in mind that the ONTAP Volume comment can be of max size 1023 chars. In the below content I am not seeing any handling but that may be okay as we may not reach that limit with the existing format.","commit_id":"ce409abdf1574d88f22dfc5db4aa98b9c4f9bafe"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e1a00e48b45de27ad377faba4b564b4d18d9c4ed","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        return self.configuration.netapp_volume_name_template % {"},{"line_number":383,"context_line":"            \u0027share_id\u0027: share_id.replace(\u0027-\u0027, \u0027_\u0027)}"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _generate_backend_share_comment(self, share):"},{"line_number":386,"context_line":"        \"\"\"Generate share comment.\"\"\""},{"line_number":387,"context_line":"        # caution: share_type is nullable"},{"line_number":388,"context_line":"        if share.get(\u0027share_type\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a2af6c5b_73fce846","line":385,"in_reply_to":"56c71985_e17b7a58","updated":"2026-02-09 08:18:52.000000000","message":"yes 1023 is very good limit.","commit_id":"ce409abdf1574d88f22dfc5db4aa98b9c4f9bafe"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8bac360876485ddc5cc819247c7b6f79f450b933","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        return self.configuration.netapp_volume_name_template % {"},{"line_number":383,"context_line":"            \u0027share_id\u0027: share_id.replace(\u0027-\u0027, \u0027_\u0027)}"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _generate_backend_share_comment(self, share):"},{"line_number":386,"context_line":"        \"\"\"Generate share comment.\"\"\""},{"line_number":387,"context_line":"        # caution: share_type is nullable"},{"line_number":388,"context_line":"        if share.get(\u0027share_type\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"cc65728b_75fc1caf","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":39},"updated":"2026-02-10 16:09:35.000000000","message":"should this also be called and set during the manage operation? If not, it\u0027d be called in the ensure anyways, but if I understand correctly there would be a gap of time when this information does not exist in the volume, until it\u0027s reconciled","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7576f40dd819f8c435c11823e3d2fc40917fbc50","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        return self.configuration.netapp_volume_name_template % {"},{"line_number":383,"context_line":"            \u0027share_id\u0027: share_id.replace(\u0027-\u0027, \u0027_\u0027)}"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _generate_backend_share_comment(self, share):"},{"line_number":386,"context_line":"        \"\"\"Generate share comment.\"\"\""},{"line_number":387,"context_line":"        # caution: share_type is nullable"},{"line_number":388,"context_line":"        if share.get(\u0027share_type\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fb230ee6_1f2cb795","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":39},"in_reply_to":"cc65728b_75fc1caf","updated":"2026-02-11 13:31:24.000000000","message":"we have not using manage/unmanage and hence this is skipped. But yes, we can apply to manage operation as well and this will apply comment to managed share.\nShould I do so ?","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d01e40c0dc1ce46e979675bae12a5acbe7fac260","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        return self.configuration.netapp_volume_name_template % {"},{"line_number":383,"context_line":"            \u0027share_id\u0027: share_id.replace(\u0027-\u0027, \u0027_\u0027)}"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _generate_backend_share_comment(self, share):"},{"line_number":386,"context_line":"        \"\"\"Generate share comment.\"\"\""},{"line_number":387,"context_line":"        # caution: share_type is nullable"},{"line_number":388,"context_line":"        if share.get(\u0027share_type\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb42cfcb_a0f33c7a","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":39},"in_reply_to":"dd637bab_32a67a37","updated":"2026-02-11 16:28:21.000000000","message":"Done","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f77198af79c0b5ed26b7c19735de7668cce6eb6c","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        return self.configuration.netapp_volume_name_template % {"},{"line_number":383,"context_line":"            \u0027share_id\u0027: share_id.replace(\u0027-\u0027, \u0027_\u0027)}"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def _generate_backend_share_comment(self, share):"},{"line_number":386,"context_line":"        \"\"\"Generate share comment.\"\"\""},{"line_number":387,"context_line":"        # caution: share_type is nullable"},{"line_number":388,"context_line":"        if share.get(\u0027share_type\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd637bab_32a67a37","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":39},"in_reply_to":"fb230ee6_1f2cb795","updated":"2026-02-11 14:51:33.000000000","message":"I think so, yes... If we don\u0027t do it, means there\u0027s a chance the share will live without the comment in the backend until it\u0027s reconciled by ensure_shares.","commit_id":"40a206b58316ceda02dfdf6b8c8b59e5d5732b72"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"0cd39cda2d7e0a56eb806e4d7f6c0059297cb19e","unresolved":true,"context_lines":[{"line_number":405,"context_line":"            share_type_name \u003d share.get(\u0027share_type_name\u0027)"},{"line_number":406,"context_line":"        return ["},{"line_number":407,"context_line":"            \u0027share_id:%s\u0027 % share.get(\u0027share_id\u0027),"},{"line_number":408,"context_line":"            \u0027share_name:%s\u0027 % share.get(\u0027display_name\u0027),"},{"line_number":409,"context_line":"            \u0027project:%s\u0027 % share.get(\u0027project_id\u0027),"},{"line_number":410,"context_line":"            \u0027share_type:%s\u0027 % share_type_name,"},{"line_number":411,"context_line":"            \u0027protocol:%s\u0027 % share.get(\u0027share_proto\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"14694ea7_a543a424","line":408,"range":{"start_line":408,"start_character":12,"end_line":408,"end_character":56},"updated":"2026-04-21 07:35:10.000000000","message":"We need to consider some length limit:\n\ndisplay name can be 255 chars, but tag key-value pairs cannot be longer than 200 characters","commit_id":"fc75cf7d199585c83e1faa3bf81b669675ab63ff"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7a79d4fcf5986e192177495322a17f9c4b09beac","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            share_type_name \u003d share.get(\u0027share_type_name\u0027)"},{"line_number":406,"context_line":"        return ["},{"line_number":407,"context_line":"            \u0027share_id:%s\u0027 % share.get(\u0027share_id\u0027),"},{"line_number":408,"context_line":"            \u0027share_name:%s\u0027 % share.get(\u0027display_name\u0027),"},{"line_number":409,"context_line":"            \u0027project:%s\u0027 % share.get(\u0027project_id\u0027),"},{"line_number":410,"context_line":"            \u0027share_type:%s\u0027 % share_type_name,"},{"line_number":411,"context_line":"            \u0027protocol:%s\u0027 % share.get(\u0027share_proto\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"cb5bdd1a_683190a7","line":408,"range":{"start_line":408,"start_character":12,"end_line":408,"end_character":56},"in_reply_to":"14694ea7_a543a424","updated":"2026-04-21 10:56:45.000000000","message":"Done","commit_id":"fc75cf7d199585c83e1faa3bf81b669675ab63ff"}]}