)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     cea701db (Merge \"[Doc] Update quota APIs to use share_type as query parameter\")"},{"line_number":2,"context_line":"Author:     JonathanKoerber \u003cjonathankoerber@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-01-24 23:44:22 -0800"},{"line_number":4,"context_line":"Commit:     JonathanKoerber \u003cjonathankoerber@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9130636e_cfefa452","line":1,"updated":"2026-04-17 16:52:29.000000000","message":"A bit more description on why this change is needed, please.. this patch mixes two unrelated concerns: (1) adding create schema validation and (2) modifying migration_start/complete/cancel/get_progress. These should be separate patches.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     cea701db (Merge \"[Doc] Update quota APIs to use share_type as query parameter\")"},{"line_number":2,"context_line":"Author:     JonathanKoerber \u003cjonathankoerber@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-01-24 23:44:22 -0800"},{"line_number":4,"context_line":"Commit:     JonathanKoerber \u003cjonathankoerber@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b247c1c4_dad03ddf","line":1,"in_reply_to":"9130636e_cfefa452","updated":"2026-04-25 19:23:16.000000000","message":"This is resolved. The change was unrelated and removed.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"2e4944f3a1f1fdb628eec4d23b63aa2811494fdb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     cea701db (Merge \"[Doc] Update quota APIs to use share_type as query parameter\")"},{"line_number":2,"context_line":"Author:     JonathanKoerber \u003cjonathankoerber@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-01-24 23:44:22 -0800"},{"line_number":4,"context_line":"Commit:     JonathanKoerber \u003cjonathankoerber@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"6a8e1db9_f12cb9f6","line":1,"in_reply_to":"b247c1c4_dad03ddf","updated":"2026-04-25 19:23:54.000000000","message":"Done","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"792f2b9ab0b86570df20d6a234decf33b944a543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"abc396c1_47b11fe5","updated":"2026-04-17 17:01:41.000000000","message":"Hey, Jonathan! I suggested an edit in your change which fixed almost all unit tests on my environment, except for `test_share_create_with_share_net`. Please take a look at the comments.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d0867956_2020e272","updated":"2026-04-25 19:23:16.000000000","message":"Thank you for your feedback. The items that were pointed our have been changed or removed. Patch is passing.","commit_id":"88170c6aea4fea0ecf2b265b1b89a080b7654f56"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"2e4944f3a1f1fdb628eec4d23b63aa2811494fdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"47fc5bc0_d57e2bc1","updated":"2026-04-25 19:23:54.000000000","message":"Thanks for the feedback.","commit_id":"88170c6aea4fea0ecf2b265b1b89a080b7654f56"}],"manila/api/schemas/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":314,"context_line":"            \u0027additionalProperties\u0027: True"},{"line_number":315,"context_line":"        },"},{"line_number":316,"context_line":"        \u0027required\u0027: [],"},{"line_number":317,"context_line":"        \u0027additionalProgerties\u0027: True"},{"line_number":318,"context_line":"    }"},{"line_number":319,"context_line":"}"},{"line_number":320,"context_line":"create_request_body_v213 \u003d copy.deepcopy(create_request_body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7693acf0_db3fb38c","line":317,"updated":"2026-04-17 16:52:29.000000000","message":"Two bugs on this line:\n1. `\u0027additionalProgerties\u0027` is misspelled.. should be `\u0027additionalProperties\u0027`. jsonschema silently ignores unknown keywords, so this has no effect.\n2. Both `\u0027required\u0027: []` (line 316) and `\u0027additionalProgerties\u0027` are inside the `\u0027properties\u0027` dict, need to be siblings of `\u0027properties\u0027`, not children.\n\nShould be:\n```\ncreate_request_body \u003d {\n    \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027],\n    \u0027properties\u0027: {\n        \u0027share\u0027: { ... }\n    },\n    \u0027required\u0027: [],\n    \u0027additionalProperties\u0027: True,\n}\n```","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            \u0027additionalProperties\u0027: True"},{"line_number":315,"context_line":"        },"},{"line_number":316,"context_line":"        \u0027required\u0027: [],"},{"line_number":317,"context_line":"        \u0027additionalProgerties\u0027: True"},{"line_number":318,"context_line":"    }"},{"line_number":319,"context_line":"}"},{"line_number":320,"context_line":"create_request_body_v213 \u003d copy.deepcopy(create_request_body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da878900_41a452a3","line":317,"in_reply_to":"7693acf0_db3fb38c","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                \u0027volume_type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":388,"context_line":"                \u0027encryption_key_ref\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":389,"context_line":"            },"},{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2b0bc67c_822af913","line":390,"updated":"2026-04-17 16:52:29.000000000","message":"Same structural bug as the request schema: `\u0027required\u0027: [\u0027share\u0027]` is inside the `share` property definition, not on the outer response object. And the outer `\u0027required\u0027` (line 393) and `\u0027additionalProperties\u0027` (line 398) are again inside `\u0027properties\u0027`, making them property definitions rather than schema constraints.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"792f2b9ab0b86570df20d6a234decf33b944a543","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                \u0027volume_type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":388,"context_line":"                \u0027encryption_key_ref\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":389,"context_line":"            },"},{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aa68064_a2554844","line":390,"range":{"start_line":390,"start_character":0,"end_line":390,"end_character":34},"updated":"2026-04-17 17:01:41.000000000","message":"this is expecting that \u0027share\u0027 object exists inside share, like: {\u0027share\u0027: {\u0027share\u0027: {...}}}. Instead, this should be removed from here and moved to two levels out.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                \u0027volume_type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":388,"context_line":"                \u0027encryption_key_ref\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":389,"context_line":"            },"},{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"909d5287_979db89a","line":390,"in_reply_to":"2b0bc67c_822af913","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                \u0027volume_type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":388,"context_line":"                \u0027encryption_key_ref\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":389,"context_line":"            },"},{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e720057c_0ec0a14d","line":390,"range":{"start_line":390,"start_character":0,"end_line":390,"end_character":34},"in_reply_to":"3aa68064_a2554844","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"},{"line_number":394,"context_line":"                     \u0027name\u0027, \u0027description\u0027, \u0027project_id\u0027, \u0027snapshot_id\u0027,"},{"line_number":395,"context_line":"                     \u0027share_network_id\u0027, \u0027share_proto\u0027, \u0027metadata\u0027, \u0027links\u0027,"},{"line_number":396,"context_line":"                     \u0027is_public\u0027, \u0027share_server_id\u0027, \u0027host\u0027, \u0027volume_type\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"635db10e_1454960a","line":393,"updated":"2026-04-17 16:52:29.000000000","message":"`\u0027create_at\u0027` in the required list — should be `\u0027created_at\u0027`.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"},{"line_number":394,"context_line":"                     \u0027name\u0027, \u0027description\u0027, \u0027project_id\u0027, \u0027snapshot_id\u0027,"},{"line_number":395,"context_line":"                     \u0027share_network_id\u0027, \u0027share_proto\u0027, \u0027metadata\u0027, \u0027links\u0027,"},{"line_number":396,"context_line":"                     \u0027is_public\u0027, \u0027share_server_id\u0027, \u0027host\u0027, \u0027volume_type\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5d1cb19c_eee8125b","line":393,"in_reply_to":"635db10e_1454960a","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"792f2b9ab0b86570df20d6a234decf33b944a543","unresolved":true,"context_lines":[{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"})"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"create_response_body \u003d {"},{"line_number":358,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":359,"context_line":"    \u0027properties\u0027: {"},{"line_number":360,"context_line":"        \u0027share\u0027: {"},{"line_number":361,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":362,"context_line":"            \u0027properties\u0027: {"},{"line_number":363,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":364,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":365,"context_line":"                \u0027availability_zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":366,"context_line":"                \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":367,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":368,"context_line":"                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":369,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":370,"context_line":"                \u0027project_id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":371,"context_line":"                \u0027snapshot_id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":372,"context_line":"                \u0027share_network_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":373,"context_line":"                \u0027share_proto\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":374,"context_line":"                \u0027metadata\u0027: {"},{"line_number":375,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":376,"context_line":"                    \u0027patternProperties\u0027: {"},{"line_number":377,"context_line":"                        \"^[a-zA-Z0-9-_:.]{1,255}$\": {"},{"line_number":378,"context_line":"                            \u0027type\u0027: \u0027string\u0027"},{"line_number":379,"context_line":"                        }"},{"line_number":380,"context_line":"                    }"},{"line_number":381,"context_line":"                },"},{"line_number":382,"context_line":"                \u0027links\u0027: {\u0027type\u0027: \u0027array\u0027},"},{"line_number":383,"context_line":"                \u0027is_public\u0027: parameter_types.boolean,"},{"line_number":384,"context_line":"                \u0027share_server_id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":385,"context_line":"                \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":386,"context_line":"                \u0027share_type_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":387,"context_line":"                \u0027volume_type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":388,"context_line":"                \u0027encryption_key_ref\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":389,"context_line":"            },"},{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"},{"line_number":394,"context_line":"                     \u0027name\u0027, \u0027description\u0027, \u0027project_id\u0027, \u0027snapshot_id\u0027,"},{"line_number":395,"context_line":"                     \u0027share_network_id\u0027, \u0027share_proto\u0027, \u0027metadata\u0027, \u0027links\u0027,"},{"line_number":396,"context_line":"                     \u0027is_public\u0027, \u0027share_server_id\u0027, \u0027host\u0027, \u0027volume_type\u0027,"},{"line_number":397,"context_line":"                     \u0027encryption_key_ref\u0027],"},{"line_number":398,"context_line":"        \u0027additionalProperties\u0027: True,"},{"line_number":399,"context_line":"    }"},{"line_number":400,"context_line":"}"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"create_response_body_v22 \u003d copy.deepcopy(create_response_body)"},{"line_number":403,"context_line":"create_response_body_v22[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d1bf27c_93a1556d","line":400,"range":{"start_line":357,"start_character":0,"end_line":400,"end_character":1},"updated":"2026-04-17 17:01:41.000000000","message":"```suggestion\ncreate_response_body \u003d {\n    \u0027type\u0027: \u0027object\u0027,\n    \u0027properties\u0027: {\n        \u0027share\u0027: {\n            \u0027type\u0027: \u0027object\u0027,\n            \u0027properties\u0027: {\n                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},\n                \u0027availability_zone\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027project_id\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027snapshot_id\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027share_network_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},\n                \u0027share_proto\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027metadata\u0027: {\n                    \u0027type\u0027: \u0027object\u0027,\n                    \u0027patternProperties\u0027: {\n                        \"^[a-zA-Z0-9-_:.]{1,255}$\": {\n                            \u0027type\u0027: \u0027string\u0027\n                        }\n                    }\n                },\n                \u0027links\u0027: {\u0027type\u0027: \u0027array\u0027},\n                \u0027is_public\u0027: parameter_types.boolean,\n                \u0027share_server_id\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027share_type_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},\n                \u0027volume_type\u0027: {\u0027type\u0027: \u0027string\u0027},\n                \u0027encryption_key_ref\u0027: {\u0027type\u0027: \u0027object\u0027}\n            },\n            \u0027additionalProperties\u0027: True,\n        },\n        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,\n                     \u0027name\u0027, \u0027description\u0027, \u0027project_id\u0027, \u0027snapshot_id\u0027,\n                     \u0027share_network_id\u0027, \u0027share_proto\u0027, \u0027metadata\u0027, \u0027links\u0027,\n                     \u0027is_public\u0027, \u0027share_server_id\u0027, \u0027host\u0027, \u0027volume_type\u0027,\n                     \u0027encryption_key_ref\u0027],\n        \u0027additionalProperties\u0027: True,\n    },\n    \u0027required\u0027: [\u0027share\u0027],\n}\n```","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    }"},{"line_number":355,"context_line":"})"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"create_response_body \u003d {"},{"line_number":358,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":359,"context_line":"    \u0027properties\u0027: {"},{"line_number":360,"context_line":"        \u0027share\u0027: {"},{"line_number":361,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":362,"context_line":"            \u0027properties\u0027: {"},{"line_number":363,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":364,"context_line":"                \u0027size\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":365,"context_line":"                \u0027availability_zone\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":366,"context_line":"                \u0027created_at\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":367,"context_line":"                \u0027status\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":368,"context_line":"                \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":369,"context_line":"                \u0027description\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":370,"context_line":"                \u0027project_id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":371,"context_line":"                \u0027snapshot_id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":372,"context_line":"                \u0027share_network_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":373,"context_line":"                \u0027share_proto\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":374,"context_line":"                \u0027metadata\u0027: {"},{"line_number":375,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":376,"context_line":"                    \u0027patternProperties\u0027: {"},{"line_number":377,"context_line":"                        \"^[a-zA-Z0-9-_:.]{1,255}$\": {"},{"line_number":378,"context_line":"                            \u0027type\u0027: \u0027string\u0027"},{"line_number":379,"context_line":"                        }"},{"line_number":380,"context_line":"                    }"},{"line_number":381,"context_line":"                },"},{"line_number":382,"context_line":"                \u0027links\u0027: {\u0027type\u0027: \u0027array\u0027},"},{"line_number":383,"context_line":"                \u0027is_public\u0027: parameter_types.boolean,"},{"line_number":384,"context_line":"                \u0027share_server_id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":385,"context_line":"                \u0027host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":386,"context_line":"                \u0027share_type_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":387,"context_line":"                \u0027volume_type\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":388,"context_line":"                \u0027encryption_key_ref\u0027: {\u0027type\u0027: \u0027object\u0027}"},{"line_number":389,"context_line":"            },"},{"line_number":390,"context_line":"            \u0027required\u0027: [\u0027share\u0027],"},{"line_number":391,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":392,"context_line":"        },"},{"line_number":393,"context_line":"        \u0027required\u0027: [\u0027id\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027create_at\u0027, \u0027status\u0027,"},{"line_number":394,"context_line":"                     \u0027name\u0027, \u0027description\u0027, \u0027project_id\u0027, \u0027snapshot_id\u0027,"},{"line_number":395,"context_line":"                     \u0027share_network_id\u0027, \u0027share_proto\u0027, \u0027metadata\u0027, \u0027links\u0027,"},{"line_number":396,"context_line":"                     \u0027is_public\u0027, \u0027share_server_id\u0027, \u0027host\u0027, \u0027volume_type\u0027,"},{"line_number":397,"context_line":"                     \u0027encryption_key_ref\u0027],"},{"line_number":398,"context_line":"        \u0027additionalProperties\u0027: True,"},{"line_number":399,"context_line":"    }"},{"line_number":400,"context_line":"}"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"create_response_body_v22 \u003d copy.deepcopy(create_response_body)"},{"line_number":403,"context_line":"create_response_body_v22[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"cbca75db_b5e9bd12","line":400,"range":{"start_line":357,"start_character":0,"end_line":400,"end_character":1},"in_reply_to":"8d1bf27c_93a1556d","updated":"2026-04-25 19:23:16.000000000","message":"Fix applied.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"create_response_body_v22 \u003d copy.deepcopy(create_response_body)"},{"line_number":403,"context_line":"create_response_body_v22[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":404,"context_line":"    \u0027shapshot_support\u0027: parameter_types.boolean"},{"line_number":405,"context_line":"})"},{"line_number":406,"context_line":"create_response_body_v25 \u003d copy.deepcopy(create_response_body_v22)"},{"line_number":407,"context_line":"create_response_body_v25[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"76d23f63_7e378702","line":404,"updated":"2026-04-17 16:52:29.000000000","message":"Typo: `\u0027shapshot_support\u0027` should be `\u0027snapshot_support\u0027`. This field name won\u0027t match the actual API response field.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"create_response_body_v22 \u003d copy.deepcopy(create_response_body)"},{"line_number":403,"context_line":"create_response_body_v22[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":404,"context_line":"    \u0027shapshot_support\u0027: parameter_types.boolean"},{"line_number":405,"context_line":"})"},{"line_number":406,"context_line":"create_response_body_v25 \u003d copy.deepcopy(create_response_body_v22)"},{"line_number":407,"context_line":"create_response_body_v25[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"c254304b_82c75727","line":404,"in_reply_to":"76d23f63_7e378702","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":426,"context_line":"})"},{"line_number":427,"context_line":"create_response_body_v224 \u003d copy.deepcopy(create_response_body_v216)"},{"line_number":428,"context_line":"create_response_body_v224[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":429,"context_line":"    \u0027create_share_from_shapshot_support\u0027: parameter_types.boolean"},{"line_number":430,"context_line":"})"},{"line_number":431,"context_line":"create_response_body_v227 \u003d copy.deepcopy(create_response_body_v224)"},{"line_number":432,"context_line":"create_response_body_v227[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"400cd78c_2cc48e9b","line":429,"updated":"2026-04-17 16:52:29.000000000","message":"Typo: `\u0027create_share_from_shapshot_support\u0027` should be `\u0027create_share_from_snapshot_support\u0027`.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"2e4944f3a1f1fdb628eec4d23b63aa2811494fdb","unresolved":false,"context_lines":[{"line_number":426,"context_line":"})"},{"line_number":427,"context_line":"create_response_body_v224 \u003d copy.deepcopy(create_response_body_v216)"},{"line_number":428,"context_line":"create_response_body_v224[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":429,"context_line":"    \u0027create_share_from_shapshot_support\u0027: parameter_types.boolean"},{"line_number":430,"context_line":"})"},{"line_number":431,"context_line":"create_response_body_v227 \u003d copy.deepcopy(create_response_body_v224)"},{"line_number":432,"context_line":"create_response_body_v227[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"fda09c71_bd59169e","line":429,"in_reply_to":"400cd78c_2cc48e9b","updated":"2026-04-25 19:23:54.000000000","message":"Done","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":430,"context_line":"})"},{"line_number":431,"context_line":"create_response_body_v227 \u003d copy.deepcopy(create_response_body_v224)"},{"line_number":432,"context_line":"create_response_body_v227[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":433,"context_line":"    \u0027revert_to_snopshot_support\u0027: parameter_types.boolean"},{"line_number":434,"context_line":"})"},{"line_number":435,"context_line":"create_response_body_v231 \u003d copy.deepcopy(create_response_body_v227)"},{"line_number":436,"context_line":"create_response_body_v231[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"cbdaccfb_057b51ac","line":433,"updated":"2026-04-17 16:52:29.000000000","message":"Typo: `\u0027revert_to_snopshot_support\u0027` should be `\u0027revert_to_snapshot_support\u0027`.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":430,"context_line":"})"},{"line_number":431,"context_line":"create_response_body_v227 \u003d copy.deepcopy(create_response_body_v224)"},{"line_number":432,"context_line":"create_response_body_v227[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":433,"context_line":"    \u0027revert_to_snopshot_support\u0027: parameter_types.boolean"},{"line_number":434,"context_line":"})"},{"line_number":435,"context_line":"create_response_body_v231 \u003d copy.deepcopy(create_response_body_v227)"},{"line_number":436,"context_line":"create_response_body_v231[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"}],"source_content_type":"text/x-python","patch_set":6,"id":"50b87782_d38d9b87","line":433,"in_reply_to":"cbdaccfb_057b51ac","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":441,"context_line":"create_response_body_v232[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":442,"context_line":"    \u0027mount_snapshot_support\u0027: parameter_types.boolean"},{"line_number":443,"context_line":"})"},{"line_number":444,"context_line":"create_response_body_v254 \u003d copy.deepcopy(create_response_body_v231)"},{"line_number":445,"context_line":"create_response_body_v254[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":446,"context_line":"    \u0027progress\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":447,"context_line":"})"}],"source_content_type":"text/x-python","patch_set":6,"id":"ab68df15_8b75bece","line":444,"updated":"2026-04-17 16:52:29.000000000","message":"`create_response_body_v254` deepcopies from `create_response_body_v231`, but it should deepcopy from `create_response_body_v232`. This means `mount_snapshot_support` (added in 2.32) is missing from all response schemas for 2.54+.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":441,"context_line":"create_response_body_v232[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":442,"context_line":"    \u0027mount_snapshot_support\u0027: parameter_types.boolean"},{"line_number":443,"context_line":"})"},{"line_number":444,"context_line":"create_response_body_v254 \u003d copy.deepcopy(create_response_body_v231)"},{"line_number":445,"context_line":"create_response_body_v254[\u0027properties\u0027][\u0027share\u0027][\u0027properties\u0027].update({"},{"line_number":446,"context_line":"    \u0027progress\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":447,"context_line":"})"}],"source_content_type":"text/x-python","patch_set":6,"id":"d8844eb7_91ef5132","line":444,"in_reply_to":"ab68df15_8b75bece","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"}],"manila/api/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":342,"context_line":"    @validation.response_body_schema("},{"line_number":343,"context_line":"        schema.create_response_body_v269, \u00272.69\u0027, \u00272.79\u0027)"},{"line_number":344,"context_line":"    @validation.response_body_schema(schema.create_response_body_v280, \u00272.80\u0027)"},{"line_number":345,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811OO"},{"line_number":346,"context_line":"        if not self.is_valid_body(body, \u0027share\u0027):"},{"line_number":347,"context_line":"            raise exc.HTTPUnprocessableEntity()"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5117a2fc_ac00457a","line":345,"updated":"2026-04-17 16:52:29.000000000","message":"`# noqa F811OO` — the `OO` at the end makes this an invalid noqa directive. This is likely causing the pep8 CI failure. Should be `# noqa F811`.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    @validation.response_body_schema("},{"line_number":343,"context_line":"        schema.create_response_body_v269, \u00272.69\u0027, \u00272.79\u0027)"},{"line_number":344,"context_line":"    @validation.response_body_schema(schema.create_response_body_v280, \u00272.80\u0027)"},{"line_number":345,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811OO"},{"line_number":346,"context_line":"        if not self.is_valid_body(body, \u0027share\u0027):"},{"line_number":347,"context_line":"            raise exc.HTTPUnprocessableEntity()"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f3d0fdf_0b1fce29","line":345,"in_reply_to":"5117a2fc_ac00457a","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":525,"context_line":"    @wsgi.Controller.api_version(\u00272.29\u0027, experimental\u003dTrue)"},{"line_number":526,"context_line":"    @wsgi.action(\"migration_start\")"},{"line_number":527,"context_line":"    @wsgi.Controller.authorize"},{"line_number":528,"context_line":"    def migration_start(self, req, id, body):"},{"line_number":529,"context_line":"        \"\"\"Migrate a share to the specified host.\"\"\""},{"line_number":530,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":531,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"46dd605a_9f5dfaae","line":528,"updated":"2026-04-17 16:52:29.000000000","message":"The `@validation.request_body_schema` and `@validation.response_body_schema` decorators were removed from `migration_start`. This is unrelated to the share create schema work and removes existing validation. Same for `migration_complete` (line 599), `migration_cancel` (line 614), and `migration_get_progress` (line 628). These changes should not be in this patch.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":525,"context_line":"    @wsgi.Controller.api_version(\u00272.29\u0027, experimental\u003dTrue)"},{"line_number":526,"context_line":"    @wsgi.action(\"migration_start\")"},{"line_number":527,"context_line":"    @wsgi.Controller.authorize"},{"line_number":528,"context_line":"    def migration_start(self, req, id, body):"},{"line_number":529,"context_line":"        \"\"\"Migrate a share to the specified host.\"\"\""},{"line_number":530,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":531,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e544c2e_ffa7efce","line":528,"in_reply_to":"46dd605a_9f5dfaae","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":531,"context_line":"        try:"},{"line_number":532,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":533,"context_line":"        except exception.NotFound:"},{"line_number":534,"context_line":"            msg \u003d _(\"Share;/ %s not found.\") % id"},{"line_number":535,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if share.get(\u0027is_soft_deleted\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7e912a7b_4a482123","line":534,"updated":"2026-04-17 16:52:29.000000000","message":"`;/` should be dropped.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        try:"},{"line_number":532,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":533,"context_line":"        except exception.NotFound:"},{"line_number":534,"context_line":"            msg \u003d _(\"Share;/ %s not found.\") % id"},{"line_number":535,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if share.get(\u0027is_soft_deleted\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fbb41d59_1ec7c65f","line":534,"in_reply_to":"7e912a7b_4a482123","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"}],"manila/tests/api/contrib/stubs.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    return fake_share"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def stub_share_json_schema(id, **kwargs):"},{"line_number":105,"context_line":"    share \u003d stub_share(id, kwargs)"},{"line_number":106,"context_line":"    return {\u0027share\u0027: share}"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"76c1f5fc_37568c73","line":104,"updated":"2026-04-17 16:52:29.000000000","message":"PEP8: needs two blank lines before function definition (only one blank line between `stub_share` return and `stub_share_json_schema`).","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    return fake_share"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def stub_share_json_schema(id, **kwargs):"},{"line_number":105,"context_line":"    share \u003d stub_share(id, kwargs)"},{"line_number":106,"context_line":"    return {\u0027share\u0027: share}"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8244c5d5_c871dd37","line":104,"in_reply_to":"76c1f5fc_37568c73","updated":"2026-04-25 19:23:16.000000000","message":"Acknowledged","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3657838a9ab6b171c936eb3da6bac72c42b56edd","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    return fake_share"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def stub_share_json_schema(id, **kwargs):"},{"line_number":105,"context_line":"    share \u003d stub_share(id, kwargs)"},{"line_number":106,"context_line":"    return {\u0027share\u0027: share}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def stub_snapshot(id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5e282e8f_561e3833","line":105,"updated":"2026-04-17 16:52:29.000000000","message":"`stub_share(id, kwargs)` passes the kwargs dict as a positional argument. Should be `stub_share(id, **kwargs)` to unpack it. This is likely causing unit test failures.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"2e4944f3a1f1fdb628eec4d23b63aa2811494fdb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    return fake_share"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def stub_share_json_schema(id, **kwargs):"},{"line_number":105,"context_line":"    share \u003d stub_share(id, kwargs)"},{"line_number":106,"context_line":"    return {\u0027share\u0027: share}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def stub_snapshot(id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b7d659aa_60c52527","line":105,"in_reply_to":"27443787_26a83ebc","updated":"2026-04-25 19:23:54.000000000","message":"Done","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"},{"author":{"_account_id":37037,"name":"Jonathan Koerber","display_name":"Jonathan Koerber","email":"jonathankoerber@gmail.com","username":"JonathanKoerber"},"change_message_id":"9cf811da2d318a9f3b7f756be9fde1708816b53b","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    return fake_share"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def stub_share_json_schema(id, **kwargs):"},{"line_number":105,"context_line":"    share \u003d stub_share(id, kwargs)"},{"line_number":106,"context_line":"    return {\u0027share\u0027: share}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def stub_snapshot(id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"27443787_26a83ebc","line":105,"in_reply_to":"5e282e8f_561e3833","updated":"2026-04-25 19:23:16.000000000","message":"This was and unnecessary change and removed.","commit_id":"3ab716eb04700753bcf87216fdba02439ec6fa4d"}]}