)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f051c4249130146b7fd6376a3e196c4bd43b79c9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Manideep \u003cmanideep.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-02-23 06:26:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Customer Ask] Implementation of NAE support for NetApp Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib4e22df1458d322c104cb65563d1919a62f9e61a"},{"line_number":10,"context_line":"Signed-off-by: Manideep \u003cmanideep.openstack@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6f594f2e_0977397b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"updated":"2026-02-25 06:31:57.000000000","message":"The OpenStack Community doesn\u0027t have customers, so this tag doesn\u0027t make sense","commit_id":"45eb1e68b0e1ee69c1e361e29794955c719d927c"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"1352201af39934021bb8368ac78ec48873b51858","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manideep \u003cmanideep.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-02-23 06:26:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Customer Ask] Implementation of NAE support for NetApp Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib4e22df1458d322c104cb65563d1919a62f9e61a"},{"line_number":10,"context_line":"Signed-off-by: Manideep \u003cmanideep.openstack@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d1be1084_d8d05ae4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":15},"in_reply_to":"6f594f2e_0977397b","updated":"2026-02-27 07:05:42.000000000","message":"Done","commit_id":"45eb1e68b0e1ee69c1e361e29794955c719d927c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"3488ee2e5096cb0288aaf8eb38a142640abe1be3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06452870_19243b89","updated":"2026-02-21 06:24:29.000000000","message":"Run-NetApp CI","commit_id":"f015a47f138e284cad598c650e243f2cf6cd9c51"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"07b01247eddbfdad462d69a4bd9bce9512fe9765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e660251_c55ebf9f","updated":"2026-02-19 12:54:09.000000000","message":"Run-NetApp CI","commit_id":"f015a47f138e284cad598c650e243f2cf6cd9c51"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"17382dcbd8e5e11cea73a0ff598315c8f0afdb5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8af51b74_6d6fd322","updated":"2026-02-21 08:44:59.000000000","message":"Run-NetApp CI","commit_id":"f015a47f138e284cad598c650e243f2cf6cd9c51"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"513711c7cb71f52f65a577dba2ed717c1e153864","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a20ad196_12791023","updated":"2026-02-23 05:02:20.000000000","message":"Run-NetApp CI","commit_id":"f015a47f138e284cad598c650e243f2cf6cd9c51"},{"author":{"_account_id":38614,"name":"Sailaja Mada","display_name":"Sailaja Mada","email":"sailajam@netapp.com","username":"sailajam"},"change_message_id":"8837503434e49ec82864eec9d7dd2a395ccf093b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3ace5d3_2c0e2104","updated":"2026-02-21 12:49:48.000000000","message":"Run-NetApp CI","commit_id":"f015a47f138e284cad598c650e243f2cf6cd9c51"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"3c578a2ba56fe016a69ad95b687b3391963e3ad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc078b95_42b4f99f","updated":"2026-02-19 15:02:56.000000000","message":"Run-NetApp CI","commit_id":"f015a47f138e284cad598c650e243f2cf6cd9c51"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"d4364749f269fd029e65dd0a1382fc4c71a10718","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"def9813b_c34cc61d","updated":"2026-02-22 06:23:48.000000000","message":"recheck","commit_id":"f015a47f138e284cad598c650e243f2cf6cd9c51"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f051c4249130146b7fd6376a3e196c4bd43b79c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6766bfd5_2e5043a4","updated":"2026-02-25 06:31:57.000000000","message":"Hi, please seek a FFE; this came in quite late and our review bandwidth is limited","commit_id":"45eb1e68b0e1ee69c1e361e29794955c719d927c"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"499ba6874c117a36c8650785dd7a7d9fceacc33d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa95187f_6b298a05","updated":"2026-02-24 16:50:34.000000000","message":"LGTM","commit_id":"45eb1e68b0e1ee69c1e361e29794955c719d927c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"5d377d8351cc6bcfb0cce9cbd5c0bd56357a77d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bc9c2cac_2fa46c35","updated":"2026-02-27 10:03:10.000000000","message":"I have already review this in our downstream gerrit, changes LGTM ..!","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"feec42fe4b0a12fa4fe291bedcec0b188396e3a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ccd814d8_4f97ee61","updated":"2026-02-27 09:17:54.000000000","message":"LGTM","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5fc24d692907b1d65a814fdaee1cebfcec507126","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd7187f2_f6c6c84a","updated":"2026-02-27 21:23:16.000000000","message":"NetApp CI seems to be failing - are you guys looking into the issues?","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"93595c4e4a17dd6fbc67229ee8592b8c15edc1af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c994c26_e2bbc00d","updated":"2026-02-27 07:06:04.000000000","message":"Run-NetApp CI","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1e6ddc088e25cc53a6c733ddd065bcb0f00ac052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"20257a6b_96657967","updated":"2026-02-27 21:23:00.000000000","message":"Thanks for working on this change. Please take a look at the comments inline","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e0c2257d0dee2acea80afc8c934573b343ccc5d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2595825_3c189e05","in_reply_to":"bd7187f2_f6c6c84a","updated":"2026-02-28 10:57:43.000000000","message":"The NetApp CI passed earlier on the same diff.\nI will check why it failed with it ran for 2nd time on same code changes.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"f9f6cf01664c8d4c318c719b0aadd0ca8ec35ee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1d68d429_5f2b92fa","updated":"2026-03-02 05:21:14.000000000","message":"LGTM ..!","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9830983b1416ae1d052296dd9070f1539a85ed4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"421cd897_bb9731f7","updated":"2026-03-03 18:23:44.000000000","message":"LGTM, thanks Manideep","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a8bb26ce313c6ff9bdbf580fd144cdc03615eb1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3aaaaf5f_3204a4d4","updated":"2026-03-03 18:33:35.000000000","message":"Minor comments inline, can be addressed in a follow up","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"aeaff8b05be17faf33bf47e2134d9333dd1e201a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36ea2794_e1a47edf","updated":"2026-02-28 17:55:49.000000000","message":"Run-NetApp CI","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"92a9e8aca9b61ede02f13c8beb14a9c95ee341dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b112b453_e5d7f27c","updated":"2026-02-28 12:30:06.000000000","message":"Thank you Gowtham and Carloss for the review.\nI have addressed the review comments.","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2708d1186c6f686ba4b5f3496b7f35b8c272c2bb","unresolved":true,"context_lines":[{"line_number":2532,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":2533,"context_line":"            else:"},{"line_number":2534,"context_line":"                api_args[\u0027encrypt\u0027] \u003d \u0027true\u0027"},{"line_number":2535,"context_line":"        elif aggregate_encrypted is False:"},{"line_number":2536,"context_line":"            api_args[\u0027encrypt\u0027] \u003d \u0027false\u0027"},{"line_number":2537,"context_line":""},{"line_number":2538,"context_line":"        if snaplock_type is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"621bcf85_b7961b52","line":2535,"updated":"2026-02-27 20:31:06.000000000","message":"What is the behavior when ``aggregate_encrypted is None`` (e.g. no cluster creds)?\nSame concern in the REST client at line 1118.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1e6ddc088e25cc53a6c733ddd065bcb0f00ac052","unresolved":true,"context_lines":[{"line_number":2532,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":2533,"context_line":"            else:"},{"line_number":2534,"context_line":"                api_args[\u0027encrypt\u0027] \u003d \u0027true\u0027"},{"line_number":2535,"context_line":"        elif aggregate_encrypted is False:"},{"line_number":2536,"context_line":"            api_args[\u0027encrypt\u0027] \u003d \u0027false\u0027"},{"line_number":2537,"context_line":""},{"line_number":2538,"context_line":"        if snaplock_type is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6b6f6a4b_dc60116a","line":2535,"in_reply_to":"621bcf85_b7961b52","updated":"2026-02-27 21:23:00.000000000","message":"++","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e25dc68644991e0953d4271d5c2a25eb1bb5b9c0","unresolved":false,"context_lines":[{"line_number":2532,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":2533,"context_line":"            else:"},{"line_number":2534,"context_line":"                api_args[\u0027encrypt\u0027] \u003d \u0027true\u0027"},{"line_number":2535,"context_line":"        elif aggregate_encrypted is False:"},{"line_number":2536,"context_line":"            api_args[\u0027encrypt\u0027] \u003d \u0027false\u0027"},{"line_number":2537,"context_line":""},{"line_number":2538,"context_line":"        if snaplock_type is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"d6038eae_e7def545","line":2535,"in_reply_to":"6b6f6a4b_dc60116a","updated":"2026-02-28 10:45:18.000000000","message":"When cluster creds are not provided.\nThe encryption of ONTAP volume is decided by ONTAP.\nIf NAE is enabled on ONTAP, the volume will be create with encryption-type as aggregate. (Please note the netapp_flexvol_encryption and netapp_aggregate_encryption will still be set to False in manila pool because manila do not have that information).\n\nsimilarly if NVE is enabled on ONTAP, ONTAP volume will be NVE.\nSame behaviour for rest as well.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1e6ddc088e25cc53a6c733ddd065bcb0f00ac052","unresolved":true,"context_lines":[{"line_number":1115,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1116,"context_line":"            else:"},{"line_number":1117,"context_line":"                body[\u0027encryption.enabled\u0027] \u003d \u0027true\u0027"},{"line_number":1118,"context_line":"        elif aggregate_encrypted is False:"},{"line_number":1119,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027false\u0027"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        if snaplock_type is not None:"},{"line_number":1122,"context_line":"            body[\u0027snaplock.type\u0027] \u003d snaplock_type"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfc12da7_61df2428","line":1119,"range":{"start_line":1118,"start_character":8,"end_line":1119,"end_character":48},"updated":"2026-02-27 21:23:00.000000000","message":"should else continue being false here?","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e0c2257d0dee2acea80afc8c934573b343ccc5d4","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1116,"context_line":"            else:"},{"line_number":1117,"context_line":"                body[\u0027encryption.enabled\u0027] \u003d \u0027true\u0027"},{"line_number":1118,"context_line":"        elif aggregate_encrypted is False:"},{"line_number":1119,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027false\u0027"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        if snaplock_type is not None:"},{"line_number":1122,"context_line":"            body[\u0027snaplock.type\u0027] \u003d snaplock_type"}],"source_content_type":"text/x-python","patch_set":6,"id":"d465ddc1_56b5fffb","line":1119,"range":{"start_line":1118,"start_character":8,"end_line":1119,"end_character":48},"in_reply_to":"dfc12da7_61df2428","updated":"2026-02-28 10:57:43.000000000","message":"The else here would account to aggregate_encrypted\u003dTrue and encrypt\u003dFalse, which means the volume in ONTAP should be encrypted with aggreagte type.\nIn this case, \nif I cannot pass encryption.enabled\u003dfalse as this is not allowed by ONTAP.\nif I cannot pass encryption.enabled\u003dtrue as this will create ontap volume with volume level encryption.\nSo, I left it empty so that the ONTAP will care of it.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2708d1186c6f686ba4b5f3496b7f35b8c272c2bb","unresolved":true,"context_lines":[{"line_number":2927,"context_line":"            \u0027name\u0027: volume_name,"},{"line_number":2928,"context_line":"        }"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"        if encrypt_destination is True:"},{"line_number":2931,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027true\u0027"},{"line_number":2932,"context_line":"        elif dest_aggr_encryption is False:"},{"line_number":2933,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"d18d591e_2c921ea5","line":2930,"updated":"2026-02-27 20:31:06.000000000","message":"What if ``dest_aggr_encryption is True``. You\u0027re handling this in the ZAPI\nimplementation (client_cmode.py:5849-5862). Also, unlike ZAPI, there are no feature gates here?\n(``NAE_SUPPORT`` / ``FLEXVOL_ENCRYPTION`` checks)","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e0c2257d0dee2acea80afc8c934573b343ccc5d4","unresolved":false,"context_lines":[{"line_number":2927,"context_line":"            \u0027name\u0027: volume_name,"},{"line_number":2928,"context_line":"        }"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"        if encrypt_destination is True:"},{"line_number":2931,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027true\u0027"},{"line_number":2932,"context_line":"        elif dest_aggr_encryption is False:"},{"line_number":2933,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7113a89c_bed5b1b4","line":2930,"in_reply_to":"b2e443b0_6f8ff902","updated":"2026-02-28 10:57:43.000000000","message":"if dest_aggr_encryption is True, ONTAP will create a NAE volume.\n I did not pass encryption.enabled\u003dTrue here for the above case as this will create a NVE volume.\n \n \n NAE and NVE are supported for all versions of ONTAP which supported rest. So, if someone is using REST, NAE and NVE features should be present by default. Hence, I did not add those.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1e6ddc088e25cc53a6c733ddd065bcb0f00ac052","unresolved":true,"context_lines":[{"line_number":2927,"context_line":"            \u0027name\u0027: volume_name,"},{"line_number":2928,"context_line":"        }"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"        if encrypt_destination is True:"},{"line_number":2931,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027true\u0027"},{"line_number":2932,"context_line":"        elif dest_aggr_encryption is False:"},{"line_number":2933,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"b2e443b0_6f8ff902","line":2930,"in_reply_to":"d18d591e_2c921ea5","updated":"2026-02-27 21:23:00.000000000","message":"++","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2708d1186c6f686ba4b5f3496b7f35b8c272c2bb","unresolved":true,"context_lines":[{"line_number":708,"context_line":"        :param aggr_pool: list of aggregate names for the FlexGroup pool."},{"line_number":709,"context_line":"        Return True if all aggregates in pool have encryption enabled."},{"line_number":710,"context_line":"        \"\"\""},{"line_number":711,"context_line":"        encryption_status \u003d True"},{"line_number":712,"context_line":"        for aggr_name in sorted(aggr_pool):"},{"line_number":713,"context_line":"            if aggr_name not in aggr_info:"},{"line_number":714,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"58bbba3b_b3799ebf","line":711,"updated":"2026-02-27 20:31:06.000000000","message":"this is an unsafe default given the conditional processing below..\ncan a flexgroup span aggrs with different encryption status? if not,\nmaybe the safest thing to do in 713-714 is:\n\n.. code-block:: python\n\n    if aggr_name not in aggr_info:\n        encryption_status \u003d False\n        break","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1e6ddc088e25cc53a6c733ddd065bcb0f00ac052","unresolved":true,"context_lines":[{"line_number":708,"context_line":"        :param aggr_pool: list of aggregate names for the FlexGroup pool."},{"line_number":709,"context_line":"        Return True if all aggregates in pool have encryption enabled."},{"line_number":710,"context_line":"        \"\"\""},{"line_number":711,"context_line":"        encryption_status \u003d True"},{"line_number":712,"context_line":"        for aggr_name in sorted(aggr_pool):"},{"line_number":713,"context_line":"            if aggr_name not in aggr_info:"},{"line_number":714,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"d88dc45a_be9b23ce","line":711,"in_reply_to":"58bbba3b_b3799ebf","updated":"2026-02-27 21:23:00.000000000","message":"++","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e25dc68644991e0953d4271d5c2a25eb1bb5b9c0","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        :param aggr_pool: list of aggregate names for the FlexGroup pool."},{"line_number":709,"context_line":"        Return True if all aggregates in pool have encryption enabled."},{"line_number":710,"context_line":"        \"\"\""},{"line_number":711,"context_line":"        encryption_status \u003d True"},{"line_number":712,"context_line":"        for aggr_name in sorted(aggr_pool):"},{"line_number":713,"context_line":"            if aggr_name not in aggr_info:"},{"line_number":714,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"132c584b_0d8248b3","line":711,"in_reply_to":"d88dc45a_be9b23ce","updated":"2026-02-28 10:45:18.000000000","message":"can a flexgroup span aggrs with different encryption status?  --\u003e No.\nEither all aggregates should be NAE or non NAE. (We are planning to document this).\nIf there is a way to fail this at pool initialization, I can do it to not initialize the pool if the aggregates are with diff enc status.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2708d1186c6f686ba4b5f3496b7f35b8c272c2bb","unresolved":true,"context_lines":[{"line_number":1454,"context_line":"            share, extra_specs, list(self.BOOLEAN_QUALIFIED_EXTRA_SPECS_MAP))"},{"line_number":1455,"context_line":"        self._check_string_extra_specs_validity(share, extra_specs)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"        \"\"\"Verify that NAE cannot exist with"},{"line_number":1458,"context_line":"        NVE or encryption_support is enabled\"\"\""},{"line_number":1459,"context_line":"        nve \u003d self._get_nve_option(extra_specs)"},{"line_number":1460,"context_line":"        nae \u003d self._get_nae_option(extra_specs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a455cd67_e71118aa","line":1457,"updated":"2026-02-27 20:31:06.000000000","message":"Please use single line comments with ``#`` comments instead. Same issue in\n``lib_multi_svm.py``","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e25dc68644991e0953d4271d5c2a25eb1bb5b9c0","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"            share, extra_specs, list(self.BOOLEAN_QUALIFIED_EXTRA_SPECS_MAP))"},{"line_number":1455,"context_line":"        self._check_string_extra_specs_validity(share, extra_specs)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"        \"\"\"Verify that NAE cannot exist with"},{"line_number":1458,"context_line":"        NVE or encryption_support is enabled\"\"\""},{"line_number":1459,"context_line":"        nve \u003d self._get_nve_option(extra_specs)"},{"line_number":1460,"context_line":"        nae \u003d self._get_nae_option(extra_specs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"03c20225_7dd60684","line":1457,"in_reply_to":"a455cd67_e71118aa","updated":"2026-02-28 10:45:18.000000000","message":"Acknowledged","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1e6ddc088e25cc53a6c733ddd065bcb0f00ac052","unresolved":true,"context_lines":[{"line_number":1465,"context_line":"            args \u003d {\u0027type_id\u0027: share[\u0027share_type_id\u0027],"},{"line_number":1466,"context_line":"                    \u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":1467,"context_line":"            msg \u003d _(\u0027Invalid combination of extra_specs in share_type \u0027"},{"line_number":1468,"context_line":"                    \u0027%(type_id)s for share %(share_id)s:\u0027"},{"line_number":1469,"context_line":"                    \u0027netapp_aggregate_encryption is not compatible with \u0027"},{"line_number":1470,"context_line":"                    \u0027netapp_flexvol_encryption or encryption_support.\u0027)"},{"line_number":1471,"context_line":"            raise exception.NetAppException(msg % args)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f318bef6_12af7862","line":1468,"range":{"start_line":1468,"start_character":20,"end_line":1468,"end_character":57},"updated":"2026-02-27 21:23:00.000000000","message":"```suggestion\n                    \u0027%(type_id)s for share %(share_id)s: \u0027\n```","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e25dc68644991e0953d4271d5c2a25eb1bb5b9c0","unresolved":false,"context_lines":[{"line_number":1465,"context_line":"            args \u003d {\u0027type_id\u0027: share[\u0027share_type_id\u0027],"},{"line_number":1466,"context_line":"                    \u0027share_id\u0027: share[\u0027id\u0027]}"},{"line_number":1467,"context_line":"            msg \u003d _(\u0027Invalid combination of extra_specs in share_type \u0027"},{"line_number":1468,"context_line":"                    \u0027%(type_id)s for share %(share_id)s:\u0027"},{"line_number":1469,"context_line":"                    \u0027netapp_aggregate_encryption is not compatible with \u0027"},{"line_number":1470,"context_line":"                    \u0027netapp_flexvol_encryption or encryption_support.\u0027)"},{"line_number":1471,"context_line":"            raise exception.NetAppException(msg % args)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e2e98350_cae0b14b","line":1468,"range":{"start_line":1468,"start_character":20,"end_line":1468,"end_character":57},"in_reply_to":"f318bef6_12af7862","updated":"2026-02-28 10:45:18.000000000","message":"Acknowledged","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"8555205cc43e67fbabc1dcba18b78d1bc338f69a","unresolved":true,"context_lines":[{"line_number":4470,"context_line":"            return None"},{"line_number":4471,"context_line":""},{"line_number":4472,"context_line":"        nae_support \u003d (not self.configuration.netapp_use_legacy_client"},{"line_number":4473,"context_line":"                       or self._client.features.NAE_SUPPORT)"},{"line_number":4474,"context_line":"        dest_aggr_info \u003d ("},{"line_number":4475,"context_line":"            destination_client.get_cluster_aggregate_attributes("},{"line_number":4476,"context_line":"                {destination_aggregate}))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5c32a0e0_1fb84544","line":4473,"updated":"2026-02-28 15:28:45.000000000","message":"source and destination client are same all the time? if condition is checked on destination client","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"abba6f8b7b1a5e85ca3c2c3cdbdd371a0a07180f","unresolved":false,"context_lines":[{"line_number":4470,"context_line":"            return None"},{"line_number":4471,"context_line":""},{"line_number":4472,"context_line":"        nae_support \u003d (not self.configuration.netapp_use_legacy_client"},{"line_number":4473,"context_line":"                       or self._client.features.NAE_SUPPORT)"},{"line_number":4474,"context_line":"        dest_aggr_info \u003d ("},{"line_number":4475,"context_line":"            destination_client.get_cluster_aggregate_attributes("},{"line_number":4476,"context_line":"                {destination_aggregate}))"}],"source_content_type":"text/x-python","patch_set":7,"id":"382041f7_df1384d2","line":4473,"in_reply_to":"5c32a0e0_1fb84544","updated":"2026-02-28 17:34:56.000000000","message":"Done","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2708d1186c6f686ba4b5f3496b7f35b8c272c2bb","unresolved":true,"context_lines":[{"line_number":1519,"context_line":"            extra_specs \u003d req_spec.get(\u0027share_type\u0027, {}).get(\u0027extra_specs\u0027, {})"},{"line_number":1520,"context_line":"            for spec in specs_to_validate:"},{"line_number":1521,"context_line":"                \"\"\"TODO(manideep): See if we need to check for all the pools\"\"\""},{"line_number":1522,"context_line":"                if (spec in extra_specs and"},{"line_number":1523,"context_line":"                        str(extra_specs.get(spec)).lower() !\u003d str("},{"line_number":1524,"context_line":"                            pools[0].get(spec)).lower()):"},{"line_number":1525,"context_line":"                    msg \u003d _(\"Cannot perform server migration since the \""}],"source_content_type":"text/x-python","patch_set":6,"id":"cb6bac5e_cb2e3db0","line":1522,"updated":"2026-02-27 20:31:06.000000000","message":"Hmmm, this change is a regression: let\u0027s imagine you\u0027re migrating from a share type with\n``netapp_flexvol_encryption\u003dfalse`` to a pool that has ``netapp_flexvol_encryption\u003dTrue``. This was previously allowed (user\ndoesn\u0027t require encryption) but now disallowed because strings don\u0027t match...\nThis could block legitimate migrations. maybe the new check only makes sense for ``netapp_aggregate_encryption``?\nAlso, please no docstring style comments in-line.. Change that to a simple single line comments. The comment doesn\u0027t make sense to me. It\u0027d make sense if you explained why the validation is necessary.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e25dc68644991e0953d4271d5c2a25eb1bb5b9c0","unresolved":false,"context_lines":[{"line_number":1519,"context_line":"            extra_specs \u003d req_spec.get(\u0027share_type\u0027, {}).get(\u0027extra_specs\u0027, {})"},{"line_number":1520,"context_line":"            for spec in specs_to_validate:"},{"line_number":1521,"context_line":"                \"\"\"TODO(manideep): See if we need to check for all the pools\"\"\""},{"line_number":1522,"context_line":"                if (spec in extra_specs and"},{"line_number":1523,"context_line":"                        str(extra_specs.get(spec)).lower() !\u003d str("},{"line_number":1524,"context_line":"                            pools[0].get(spec)).lower()):"},{"line_number":1525,"context_line":"                    msg \u003d _(\"Cannot perform server migration since the \""}],"source_content_type":"text/x-python","patch_set":6,"id":"6fb9cbd0_49d65ee0","line":1522,"in_reply_to":"cb6bac5e_cb2e3db0","updated":"2026-02-28 10:45:18.000000000","message":"Q:- let\u0027s imagine you\u0027re migrating from a share type with\nnetapp_flexvol_encryption\u003dfalse to a pool that has netapp_flexvol_encryption\u003dTrue.  \n\nA:- I think the above should not be allowed as the share type capabilities does not match with pool capabilities. \n\n\nAs of today, I am not sure why this check is being done for only pool[0] but not all the pools. So added a TODO to revisit it later. Removing the todo, I will create a task to track it internally.","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a8bb26ce313c6ff9bdbf580fd144cdc03615eb1e","unresolved":true,"context_lines":[{"line_number":1509,"context_line":"                    LOG.error(msg)"},{"line_number":1510,"context_line":"                    return not_compatible"},{"line_number":1511,"context_line":""},{"line_number":1512,"context_line":"        \"\"\"Check \u0027netapp_flexvol_encryption\u0027 and \u0027revert_to_snapshot_support\u0027"},{"line_number":1513,"context_line":"        and \u0027netapp_aggregate_encryption\u0027\"\"\""},{"line_number":1514,"context_line":"        specs_to_validate \u003d (\u0027netapp_flexvol_encryption\u0027,"},{"line_number":1515,"context_line":"                             \u0027revert_to_snapshot_support\u0027,"},{"line_number":1516,"context_line":"                             \u0027netapp_aggregate_encryption\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"80523205_5675d769","line":1513,"range":{"start_line":1512,"start_character":8,"end_line":1513,"end_character":44},"updated":"2026-03-03 18:33:35.000000000","message":"don\u0027t use docstring comments inline","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2708d1186c6f686ba4b5f3496b7f35b8c272c2bb","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                                              encrypt_dst, fv_encryption):"},{"line_number":230,"context_line":"        self.mock_object(self.client, \u0027features\u0027,"},{"line_number":231,"context_line":"                         mock.Mock(FLEXVOL_ENCRYPTION\u003dfv_encryption))"},{"line_number":232,"context_line":"        self.mock_object(self.client, \u0027features\u0027,"},{"line_number":233,"context_line":"                         mock.Mock(NAE_SUPPORT\u003ddest_aggr_encryption))"},{"line_number":234,"context_line":"        self.client._send_volume_move_request("},{"line_number":235,"context_line":"            fake.ROOT_VOLUME_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b430bc59_c0048373","line":232,"updated":"2026-02-27 20:31:06.000000000","message":"You\u0027re overwriting the mock from above. you need:\n\n.. code-block:: python\n\n    self.mock_object(self.client, \u0027features\u0027,\n                     mock.Mock(FLEXVOL_ENCRYPTION\u003dfv_encryption,\n                               NAE_SUPPORT\u003ddest_aggr_encryption))\n\nSame issue at line 249","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"e25dc68644991e0953d4271d5c2a25eb1bb5b9c0","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                                              encrypt_dst, fv_encryption):"},{"line_number":230,"context_line":"        self.mock_object(self.client, \u0027features\u0027,"},{"line_number":231,"context_line":"                         mock.Mock(FLEXVOL_ENCRYPTION\u003dfv_encryption))"},{"line_number":232,"context_line":"        self.mock_object(self.client, \u0027features\u0027,"},{"line_number":233,"context_line":"                         mock.Mock(NAE_SUPPORT\u003ddest_aggr_encryption))"},{"line_number":234,"context_line":"        self.client._send_volume_move_request("},{"line_number":235,"context_line":"            fake.ROOT_VOLUME_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"14ef098e_9e93f2c2","line":232,"in_reply_to":"b430bc59_c0048373","updated":"2026-02-28 10:45:18.000000000","message":"Acknowledged","commit_id":"43a6685f75172413b7f1efe53c2de2fee89b37a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a8bb26ce313c6ff9bdbf580fd144cdc03615eb1e","unresolved":true,"context_lines":[{"line_number":7885,"context_line":""},{"line_number":7886,"context_line":"    @ddt.data("},{"line_number":7887,"context_line":"        {\u0027method_name\u0027: \u0027start_volume_move\u0027, \u0027ontapi_version\u0027: (1, 20)},"},{"line_number":7888,"context_line":"        {\u0027method_name\u0027: \u0027start_volume_move\u0027, \u0027ontapi_version\u0027: (9, 6, 0)},"},{"line_number":7889,"context_line":"        {\u0027method_name\u0027: \u0027check_volume_move\u0027, \u0027ontapi_version\u0027: (1, 20)},"},{"line_number":7890,"context_line":"        {\u0027method_name\u0027: \u0027check_volume_move\u0027, \u0027ontapi_version\u0027: (9, 6, 0)}"},{"line_number":7891,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":7,"id":"6fcc8c9d_1fbd5dd2","line":7888,"range":{"start_line":7888,"start_character":0,"end_line":7888,"end_character":74},"updated":"2026-03-03 18:33:35.000000000","message":"9.6 is an ONTAP version, not an ontapi version?","commit_id":"2b512a4e135f1b68670640b3e03f1a42f40cb9c3"}]}