)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"85b1fe27b233f303b6e64851b33305e16e7e01ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb560e0f_2473aaaf","updated":"2026-03-02 11:06:37.000000000","message":"Hey team, can you help us with reviewing this! Thanks.","commit_id":"806c0f14afc0a3c4f4f735d6ab4a3bfbf94e763d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"af04c5803211940d09023f10b1b1b832eea3f209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40fbafc7_f3bca938","updated":"2026-03-12 15:59:11.000000000","message":"Thanks for the fix and the doc update. This change could use a release note. I\u0027ll follow up and propose it.","commit_id":"931a76ff57bc1f9f16f926e02d0365930df5ee22"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"f72ed110563bd206006ee0a8d2d06a5828eb769d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4039af74_77fbbb59","updated":"2026-03-12 11:43:19.000000000","message":"run-DellEMC PowerScale CI","commit_id":"931a76ff57bc1f9f16f926e02d0365930df5ee22"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36b603cf509fc60ac02b94c89ce12552930320ee","unresolved":true,"context_lines":[{"line_number":950,"context_line":"                smb_share \u003d self._powerscale_api.lookup_smb_share(manage_name)"},{"line_number":951,"context_line":"                name \u003d manage_name"},{"line_number":952,"context_line":"                if smb_share is None:"},{"line_number":953,"context_line":"                    LOG.warning(\u0027Attempted to delete CIFS export \"%s\", \u0027"},{"line_number":954,"context_line":"                                \u0027but it does not exist.\u0027, name)"},{"line_number":955,"context_line":"                    return"},{"line_number":956,"context_line":"            if (smb_share[\u0027path\u0027] \u003d\u003d path or"}],"source_content_type":"text/x-python","patch_set":1,"id":"7eede046_3037724b","line":953,"updated":"2026-03-11 22:48:09.000000000","message":"nit: Although unlikely — a defensive restructure would be safer:\n\n```\nif smb_share is None:\n    if manage_name:\n        smb_share \u003d self._powerscale_api.lookup_smb_share(manage_name)\n        name \u003d manage_name\n    if smb_share is None:\n        LOG.warning(...)\n        return\n```\n\nRelated to this, ``test_delete_cifs_share_share_does_not_exist`` was\nremoved but it tested the \"SMB share already gone\" idempotency.\nConsider updating it for the new signature rather than removing it.","commit_id":"806c0f14afc0a3c4f4f735d6ab4a3bfbf94e763d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"8798bfc4a0cb70378cf622561151ef1bf06af046","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                smb_share \u003d self._powerscale_api.lookup_smb_share(manage_name)"},{"line_number":951,"context_line":"                name \u003d manage_name"},{"line_number":952,"context_line":"                if smb_share is None:"},{"line_number":953,"context_line":"                    LOG.warning(\u0027Attempted to delete CIFS export \"%s\", \u0027"},{"line_number":954,"context_line":"                                \u0027but it does not exist.\u0027, name)"},{"line_number":955,"context_line":"                    return"},{"line_number":956,"context_line":"            if (smb_share[\u0027path\u0027] \u003d\u003d path or"}],"source_content_type":"text/x-python","patch_set":1,"id":"0ee4db29_eeabb7c1","line":953,"in_reply_to":"7eede046_3037724b","updated":"2026-03-12 11:42:34.000000000","message":"Done","commit_id":"806c0f14afc0a3c4f4f735d6ab4a3bfbf94e763d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36b603cf509fc60ac02b94c89ce12552930320ee","unresolved":true,"context_lines":[{"line_number":968,"context_line":"            else:"},{"line_number":969,"context_line":"                message \u003d _(\u0027CIFS share \"%s\": the delete operation \u0027"},{"line_number":970,"context_line":"                            \u0027failed because the share path \u0027"},{"line_number":971,"context_line":"                            \u0027does not match the expected path.\u0027) % name"},{"line_number":972,"context_line":"                LOG.warning(message)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    def _get_cifs_manage_name_path(self, share, manage_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c56873c_84a33ddf","line":971,"updated":"2026-03-11 22:48:09.000000000","message":"\"share\" here is a boolean, rename to ``is_share``:\n\n```\ndef _get_cifs_manage_name_path(self, is_share, manage_name):\n```","commit_id":"806c0f14afc0a3c4f4f735d6ab4a3bfbf94e763d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"8798bfc4a0cb70378cf622561151ef1bf06af046","unresolved":false,"context_lines":[{"line_number":968,"context_line":"            else:"},{"line_number":969,"context_line":"                message \u003d _(\u0027CIFS share \"%s\": the delete operation \u0027"},{"line_number":970,"context_line":"                            \u0027failed because the share path \u0027"},{"line_number":971,"context_line":"                            \u0027does not match the expected path.\u0027) % name"},{"line_number":972,"context_line":"                LOG.warning(message)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    def _get_cifs_manage_name_path(self, share, manage_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5173eeed_b6ce168b","line":971,"in_reply_to":"8c56873c_84a33ddf","updated":"2026-03-12 11:42:34.000000000","message":"Done","commit_id":"806c0f14afc0a3c4f4f735d6ab4a3bfbf94e763d"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36b603cf509fc60ac02b94c89ce12552930320ee","unresolved":true,"context_lines":[{"line_number":4137,"context_line":""},{"line_number":4138,"context_line":"        share_ref \u003d self.db.share_get(context, snapshot_ref[\u0027share_id\u0027])"},{"line_number":4139,"context_line":""},{"line_number":4140,"context_line":"        if snapshot_ref.get(\"display_name\"):"},{"line_number":4141,"context_line":"            snapshot_instance.update({"},{"line_number":4142,"context_line":"                \"display_name\": snapshot_ref.get(\"display_name\")"},{"line_number":4143,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d40f9c4_23be6860","line":4140,"updated":"2026-03-11 22:48:09.000000000","message":"rather than special-casing this in ``delete_snapshot``, consider adding\n ``display_name`` to ``_get_snapshot_instance_dict`` so it\u0027s always\navailable to drivers through all the snapshot methods.","commit_id":"806c0f14afc0a3c4f4f735d6ab4a3bfbf94e763d"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"8798bfc4a0cb70378cf622561151ef1bf06af046","unresolved":false,"context_lines":[{"line_number":4137,"context_line":""},{"line_number":4138,"context_line":"        share_ref \u003d self.db.share_get(context, snapshot_ref[\u0027share_id\u0027])"},{"line_number":4139,"context_line":""},{"line_number":4140,"context_line":"        if snapshot_ref.get(\"display_name\"):"},{"line_number":4141,"context_line":"            snapshot_instance.update({"},{"line_number":4142,"context_line":"                \"display_name\": snapshot_ref.get(\"display_name\")"},{"line_number":4143,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":1,"id":"339a8943_d68c65fb","line":4140,"in_reply_to":"8d40f9c4_23be6860","updated":"2026-03-12 11:42:34.000000000","message":"Done","commit_id":"806c0f14afc0a3c4f4f735d6ab4a3bfbf94e763d"}]}