)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"da6f52c70ae0d03192809afc2a2b9a83bcb18e93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d55d3ec6_d6d8e328","updated":"2026-03-03 06:14:50.000000000","message":"run-NetApp CI","commit_id":"dbfe0e6de92c852dd5dd1469927a779b91e482c8"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1d79f0277abf0dd7392175bfe6c1921b329ca7fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61d5891b_6c0de8db","updated":"2026-03-05 05:19:49.000000000","message":"LGTM, provided one comment","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"deeb9f228928128a879a48502a169ea8a41ff31a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7c97c330_2cf60d6f","updated":"2026-03-04 20:34:07.000000000","message":"Looks good to me; got a concern inline in the REST code.. i don\u0027t know why the ONTAPI and REST code differ much - this could just be because the REST API has different expectations. Yet something for @gawasthi2010@gmail.com or @anoop.shukla@netapp.com to verify","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"158a50688c93a3f6b3ba3960b191d00471edd766","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10d13d7b_e6992fa4","updated":"2026-03-04 16:30:31.000000000","message":"Readability seems much better, thanks for working on this, Kiran","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"ab5875122f7fb7b70de5bafbe6675c60059085a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0de94e2f_e39b8352","updated":"2026-03-04 07:19:24.000000000","message":"Run-NetApp CI","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"67becb729dfd4937c867e6e74d4aa53191a01a78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"619637aa_0e4f73e4","updated":"2026-03-05 06:40:48.000000000","message":"Considering Anoop\u0027s vote as +2. Merging.","commit_id":"1379a19de1f2fa0ec9fa18c0f9d53a5c4ac6c724"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"0e89cdb51ce615e8e8a8b060c1cccf36d25c1c7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a106f1cf_a3f5102b","updated":"2026-03-05 06:33:52.000000000","message":"LGTM","commit_id":"1379a19de1f2fa0ec9fa18c0f9d53a5c4ac6c724"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"b3abad2aa33d4d350936f1674d50d81d72fe1968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"135b0556_2497b510","updated":"2026-03-05 06:03:40.000000000","message":"LGTM.","commit_id":"1379a19de1f2fa0ec9fa18c0f9d53a5c4ac6c724"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"adaa0957dc8335ffe4bffe8c9aa3971a14a2f106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"296e7fb1_f6ad22ae","updated":"2026-03-05 09:53:05.000000000","message":"recheck","commit_id":"1379a19de1f2fa0ec9fa18c0f9d53a5c4ac6c724"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"caf5c9845334b3ffba4d25473c0a05559086330e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c522d7d_dab3691a","updated":"2026-03-05 11:26:05.000000000","message":"recheck","commit_id":"1379a19de1f2fa0ec9fa18c0f9d53a5c4ac6c724"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"deeb9f228928128a879a48502a169ea8a41ff31a","unresolved":true,"context_lines":[{"line_number":5986,"context_line":"        }"},{"line_number":5987,"context_line":"        return policy_info"},{"line_number":5988,"context_line":""},{"line_number":5989,"context_line":"    def _adaptive_qos_policy_group_update_optional_params(self, api_args,"},{"line_number":5990,"context_line":"                                                          qos_type_specs):"},{"line_number":5991,"context_line":"        if qos_type_specs.get(\u0027absolute_min_iops\u0027):"},{"line_number":5992,"context_line":"            api_args[\u0027absolute-min-iops\u0027] \u003d qos_type_specs.get("}],"source_content_type":"text/x-python","patch_set":2,"id":"34b9b17b_bf5f280f","line":5989,"range":{"start_line":5989,"start_character":8,"end_line":5989,"end_character":57},"updated":"2026-03-04 20:34:07.000000000","message":"the name of the method should suggest an action, perhaps:\n\n```suggestion\n    def _get_optional_adaptive_qos_policy_specs(self, api_args,\n```","commit_id":"035275772fd193a2357fe280f30fc2442ce901e9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93d250c9e9a775f2eb014d009a9f14ea45ed7296","unresolved":false,"context_lines":[{"line_number":5986,"context_line":"        }"},{"line_number":5987,"context_line":"        return policy_info"},{"line_number":5988,"context_line":""},{"line_number":5989,"context_line":"    def _adaptive_qos_policy_group_update_optional_params(self, api_args,"},{"line_number":5990,"context_line":"                                                          qos_type_specs):"},{"line_number":5991,"context_line":"        if qos_type_specs.get(\u0027absolute_min_iops\u0027):"},{"line_number":5992,"context_line":"            api_args[\u0027absolute-min-iops\u0027] \u003d qos_type_specs.get("}],"source_content_type":"text/x-python","patch_set":2,"id":"6c4d7f24_173bc11d","line":5989,"range":{"start_line":5989,"start_character":8,"end_line":5989,"end_character":57},"in_reply_to":"34b9b17b_bf5f280f","updated":"2026-03-05 05:42:01.000000000","message":"Done","commit_id":"035275772fd193a2357fe280f30fc2442ce901e9"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"deeb9f228928128a879a48502a169ea8a41ff31a","unresolved":true,"context_lines":[{"line_number":2234,"context_line":"            if value is not None:"},{"line_number":2235,"context_line":"                try:"},{"line_number":2236,"context_line":"                    body[f\"fixed.{key}\"] \u003d int(value)"},{"line_number":2237,"context_line":"                except (TypeError, ValueError):"},{"line_number":2238,"context_line":"                    pass"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        if qos_type_specs.get(\u0027capacity_shared\u0027) \u003d\u003d \u0027true\u0027:"},{"line_number":2241,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"244de706_c87f287e","line":2238,"range":{"start_line":2237,"start_character":16,"end_line":2238,"end_character":24},"updated":"2026-03-04 20:34:07.000000000","message":"maybe warn about invalid values?","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93d250c9e9a775f2eb014d009a9f14ea45ed7296","unresolved":false,"context_lines":[{"line_number":2234,"context_line":"            if value is not None:"},{"line_number":2235,"context_line":"                try:"},{"line_number":2236,"context_line":"                    body[f\"fixed.{key}\"] \u003d int(value)"},{"line_number":2237,"context_line":"                except (TypeError, ValueError):"},{"line_number":2238,"context_line":"                    pass"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        if qos_type_specs.get(\u0027capacity_shared\u0027) \u003d\u003d \u0027true\u0027:"},{"line_number":2241,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c458e1e_2bd250d1","line":2238,"range":{"start_line":2237,"start_character":16,"end_line":2238,"end_character":24},"in_reply_to":"244de706_c87f287e","updated":"2026-03-05 05:42:01.000000000","message":"Done","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1d79f0277abf0dd7392175bfe6c1921b329ca7fa","unresolved":true,"context_lines":[{"line_number":2237,"context_line":"                except (TypeError, ValueError):"},{"line_number":2238,"context_line":"                    pass"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        if qos_type_specs.get(\u0027capacity_shared\u0027) \u003d\u003d \u0027true\u0027:"},{"line_number":2241,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d True"},{"line_number":2242,"context_line":"        else:"},{"line_number":2243,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d False"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return self.send_request(\u0027/storage/qos/policies\u0027, \u0027post\u0027,"},{"line_number":2246,"context_line":"                                 body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bc045866_ddac9779","line":2243,"range":{"start_line":2240,"start_character":8,"end_line":2243,"end_character":49},"updated":"2026-03-05 05:19:49.000000000","message":"better to use the bool method. Example \nif bool(qos_type_specs.get(\u0027capacity_shared\u0027))\n            body[\u0027fixed.capacity_shared\u0027] \u003d True","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"deeb9f228928128a879a48502a169ea8a41ff31a","unresolved":true,"context_lines":[{"line_number":2237,"context_line":"                except (TypeError, ValueError):"},{"line_number":2238,"context_line":"                    pass"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        if qos_type_specs.get(\u0027capacity_shared\u0027) \u003d\u003d \u0027true\u0027:"},{"line_number":2241,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d True"},{"line_number":2242,"context_line":"        else:"},{"line_number":2243,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d False"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return self.send_request(\u0027/storage/qos/policies\u0027, \u0027post\u0027,"},{"line_number":2246,"context_line":"                                 body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":3,"id":"aafaed0f_69292c9d","line":2243,"range":{"start_line":2240,"start_character":8,"end_line":2243,"end_character":49},"updated":"2026-03-04 20:34:07.000000000","message":"is this a bug fix?","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93d250c9e9a775f2eb014d009a9f14ea45ed7296","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"                except (TypeError, ValueError):"},{"line_number":2238,"context_line":"                    pass"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        if qos_type_specs.get(\u0027capacity_shared\u0027) \u003d\u003d \u0027true\u0027:"},{"line_number":2241,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d True"},{"line_number":2242,"context_line":"        else:"},{"line_number":2243,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d False"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return self.send_request(\u0027/storage/qos/policies\u0027, \u0027post\u0027,"},{"line_number":2246,"context_line":"                                 body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":3,"id":"22303ece_0af8b6d8","line":2243,"range":{"start_line":2240,"start_character":8,"end_line":2243,"end_character":49},"in_reply_to":"aafaed0f_69292c9d","updated":"2026-03-05 05:42:01.000000000","message":"seems like not as existing code is correct.","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"93d250c9e9a775f2eb014d009a9f14ea45ed7296","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"                except (TypeError, ValueError):"},{"line_number":2238,"context_line":"                    pass"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        if qos_type_specs.get(\u0027capacity_shared\u0027) \u003d\u003d \u0027true\u0027:"},{"line_number":2241,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d True"},{"line_number":2242,"context_line":"        else:"},{"line_number":2243,"context_line":"            body[\u0027fixed.capacity_shared\u0027] \u003d False"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return self.send_request(\u0027/storage/qos/policies\u0027, \u0027post\u0027,"},{"line_number":2246,"context_line":"                                 body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b66e1603_61fabc60","line":2243,"range":{"start_line":2240,"start_character":8,"end_line":2243,"end_character":49},"in_reply_to":"bc045866_ddac9779","updated":"2026-03-05 05:42:01.000000000","message":"after discussing with NetApp, existing code is correct.","commit_id":"6cdea1f0da23427f84041c4d4764a500db33efa5"}]}