)]}'
{"id":"openstack%2Fmanila~981639","triplet_id":"openstack%2Fmanila~master~I788e4f89061710a6084364b9fe4c3f42cec07be0","project":"openstack/manila","branch":"master","attention_set":{},"removed_from_attention_set":{"29632":{"account":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"last_update":"2026-03-25 08:19:09.000000000","reason":"Change was abandoned"},"16001":{"account":{"_account_id":16001,"name":"Goutham","email":"gouthamh4@gmail.com","username":"goutham"},"last_update":"2026-03-25 08:19:09.000000000","reason":"Change was abandoned"},"16643":{"account":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"last_update":"2026-03-25 04:18:48.000000000","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change","reason_account":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}},"6469":{"account":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"last_update":"2026-03-25 08:19:09.000000000","reason":"Change was abandoned"},"38940":{"account":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"last_update":"2026-03-25 08:19:09.000000000","reason":"Change was abandoned"}},"hashtags":["outreachy-2026-prospect"],"change_id":"I788e4f89061710a6084364b9fe4c3f42cec07be0","subject":"Replace assertEqual(False, ...) with assertFalse(...) in unit tests","status":"ABANDONED","created":"2026-03-21 12:00:29.000000000","updated":"2026-03-31 20:04:46.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"d4801eb37928c6bd6c0aa335e8491b9a1dafb9ee","_number":981639,"virtual_id_number":981639,"owner":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"_account_id":16001,"name":"Goutham","email":"gouthamh4@gmail.com","username":"goutham"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-03-21 12:19:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16001,"name":"Goutham","email":"gouthamh4@gmail.com","username":"goutham"},{"value":-1,"date":"2026-03-25 04:18:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"_account_id":16001,"name":"Goutham","email":"gouthamh4@gmail.com","username":"goutham"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":16001,"name":"Goutham","email":"gouthamh4@gmail.com","username":"goutham"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}],"CC":[{"_account_id":34853,"name":"NetApp-CI","email":"ng-openstack-ci@netapp.com","username":"netapp-ontap-ci"},{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-21 12:19:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-21 13:37:43.000000000","updated_by":{"_account_id":34853,"name":"NetApp-CI","email":"ng-openstack-ci@netapp.com","username":"netapp-ontap-ci"},"reviewer":{"_account_id":34853,"name":"NetApp-CI","email":"ng-openstack-ci@netapp.com","username":"netapp-ontap-ci"},"state":"CC"},{"updated":"2026-03-21 13:49:34.000000000","updated_by":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"reviewer":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"state":"CC"},{"updated":"2026-03-24 08:55:32.000000000","updated_by":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"reviewer":{"_account_id":16001,"name":"Goutham","email":"gouthamh4@gmail.com","username":"goutham"},"state":"REVIEWER"},{"updated":"2026-03-24 08:55:32.000000000","updated_by":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"reviewer":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"state":"REVIEWER"},{"updated":"2026-03-24 11:47:27.000000000","updated_by":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2026-03-24 21:46:41.000000000","updated_by":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"}],"messages":[{"id":"4b196a20c84cc3363307bd5ea3423a552ce8955d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"date":"2026-03-21 12:00:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"360eec55a5ba8c12ecff1ee5460a327b86d47ac8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"date":"2026-03-21 12:00:56.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"195dd2fbd890db08933ebbc9c6f79cd0f1d03a80","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-21 12:19:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f42a2b6de97a4fdc92cd10a072891ada\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/17bc6f7e8b544e26b6b8c2d5d6d7fdb0 : SUCCESS in 6m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0f40f8f919e74d3fa6dd38057e4f5dbe : SUCCESS in 18m 14s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7901e1da9e814dd0aab610e8b0cadbd8 : SUCCESS in 3m 25s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/05898847e5c043838f543dc2de1a8bc0 : SUCCESS in 5m 03s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/59c1586423444a06976758c3b1f45601 : SUCCESS in 5m 25s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/d9d79d9a148f4ce38e46525b152ca92d : SUCCESS in 11m 05s (non-voting)\n- manila-tox-genconfig https://zuul.opendev.org/t/openstack/build/9c027ffe438443a7a52b1afdaa5229d6 : SUCCESS in 2m 42s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/2f51b4ad56854841811ea1c57e50b79a : SUCCESS in 4m 10s (non-voting)\n- manila-tox-py3-threading https://zuul.opendev.org/t/openstack/build/61cbbbb26d0c4561bef9f3816431a660 : SUCCESS in 5m 34s (non-voting)\n- codegenerator-openapi-shared-file-system-tips-with-api-ref https://zuul.opendev.org/t/openstack/build/e2e6a38c868a4f88b0a2048d2bade231 : POST_FAILURE in 6m 59s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"134277df9aad66eeb3cf938fa0308e86fbd7d4b6","author":{"_account_id":34853,"name":"NetApp-CI","email":"ng-openstack-ci@netapp.com","username":"netapp-ontap-ci"},"date":"2026-03-21 13:37:43.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- manila-tempest-plugin-ontap-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/39/981639/2/upstream-check-manila/manila-tempest-plugin-ontap-dhss/0a9ee62/ : SUCCESS in 1h 16m 33s\n\nComment \"run-NetApp CI\" to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI","accounts_in_message":[],"_revision_number":2},{"id":"9358ef1224d822eaf217ccdc22a72809c54dedce","author":{"_account_id":38657,"name":"ananta agarwalla","display_name":"HPE AlletraMP Manila CI","email":"ananta.agarwalla@hpe.com","username":"manillaci"},"date":"2026-03-21 13:49:34.000000000","message":"Patch Set 2:\n\nBuild Failed: Logs: https://github.com/hpe-storage/hpe_manila_logs/tree/main/new_logs/981639","accounts_in_message":[],"_revision_number":2},{"id":"1ed348c63d3d074509daec37f40f883facb22e20","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2026-03-25 04:18:48.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"feb5119cd86af23d32a5ea02938d96342d6c3711","tag":"autogenerated:gerrit:abandon","author":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"date":"2026-03-25 08:19:09.000000000","message":"Abandoned\n\nFix wasnt necessary","accounts_in_message":[],"_revision_number":2},{"id":"d4801eb37928c6bd6c0aa335e8491b9a1dafb9ee","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2026-03-31 20:04:46.000000000","message":"Hashtag added: outreachy-2026-prospect","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bc1be46be3e76d48601c24fa46c23acdeda2c4fb","revisions":{"2fbba24790de6d2dd07175b3a96289fc16a3f18d":{"kind":"REWORK","_number":1,"created":"2026-03-21 12:00:29.000000000","uploader":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"ref":"refs/changes/39/981639/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila","ref":"refs/changes/39/981639/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila refs/changes/39/981639/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila refs/changes/39/981639/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila refs/changes/39/981639/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila refs/changes/39/981639/1"}}},"commit":{"parents":[{"commit":"743b9294eff3cfd07fccb16fc45699e3d2cced99","subject":"Add unit tests for manila.cmd.status module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/743b9294eff3cfd07fccb16fc45699e3d2cced99"}]}],"author":{"name":"akintewe","email":"solaakintewe@gmail.com","date":"2026-03-21 12:00:00.000000000","tz":60},"committer":{"name":"akintewe","email":"solaakintewe@gmail.com","date":"2026-03-21 12:00:00.000000000","tz":60},"subject":"Replace assertEqual(False, ...) with assertFalse(...) in unit tests","message":"Replace assertEqual(False, ...) with assertFalse(...) in unit tests\n\nWhile going through the test files and running tests locally, I noticed\na few spots where self.assertEqual(False, x) was being used instead of\nself.assertFalse(x). The assertFalse form is clearer about the intent\nand gives more helpful failure messages.\n\nFixed 5 instances across 4 test files:\n- manila/tests/share/test_manager.py\n- manila/tests/share/drivers/veritas/test_veritas_isa.py (2 instances)\n- manila/tests/share/drivers/container/test_driver.py\n- manila/tests/share/drivers/dell_emc/plugins/unity/test_connection.py\n\nAll affected tests still pass.\n\nCloses-Bug: #2145079\nChange-Id: I788e4f89061710a6084364b9fe4c3f42cec07be0\nSigned-off-by: akintewe \u003csolaakintewe@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/2fbba24790de6d2dd07175b3a96289fc16a3f18d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/2fbba24790de6d2dd07175b3a96289fc16a3f18d"}]},"branch":"refs/heads/master"},"bc1be46be3e76d48601c24fa46c23acdeda2c4fb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-03-21 12:00:56.000000000","uploader":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"ref":"refs/changes/39/981639/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila","ref":"refs/changes/39/981639/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila refs/changes/39/981639/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila refs/changes/39/981639/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila refs/changes/39/981639/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila refs/changes/39/981639/2"}}},"commit":{"parents":[{"commit":"743b9294eff3cfd07fccb16fc45699e3d2cced99","subject":"Add unit tests for manila.cmd.status module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/743b9294eff3cfd07fccb16fc45699e3d2cced99"}]}],"author":{"name":"akintewe","email":"solaakintewe@gmail.com","date":"2026-03-21 12:00:00.000000000","tz":60},"committer":{"name":"Oluwasola Akintewe","email":"solaakintewe@gmail.com","date":"2026-03-21 12:00:56.000000000","tz":0},"subject":"Replace assertEqual(False, ...) with assertFalse(...) in unit tests","message":"Replace assertEqual(False, ...) with assertFalse(...) in unit tests\n\nWhile going through the test files and running tests locally, I noticed\na few spots where self.assertEqual(False, x) was being used instead of\nself.assertFalse(x). The assertFalse form is clearer about the intent\nand gives more helpful failure messages.\n\nFixed 5 instances across 4 test files which are\n- manila/tests/share/test_manager.py\n- manila/tests/share/drivers/veritas/test_veritas_isa.py (2 instances)\n- manila/tests/share/drivers/container/test_driver.py\n- manila/tests/share/drivers/dell_emc/plugins/unity/test_connection.py\n\nAll affected tests still pass.\n\nCloses-Bug: #2145079\nChange-Id: I788e4f89061710a6084364b9fe4c3f42cec07be0\nSigned-off-by: akintewe \u003csolaakintewe@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/bc1be46be3e76d48601c24fa46c23acdeda2c4fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/bc1be46be3e76d48601c24fa46c23acdeda2c4fb"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
