)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"87a24950f4746a874c4c0618ce6da24b5a945b66","unresolved":true,"context_lines":[{"line_number":24,"context_line":"network is deleted, but network along-with its share servers are still"},{"line_number":25,"context_line":"present in db. Manila then internally run periodic function to cleanup"},{"line_number":26,"context_line":"those share servers and finally related share network. Any error in"},{"line_number":27,"context_line":"peridic callback processing will move share server and share network in"},{"line_number":28,"context_line":"\u0027error_deferred_deleting\u0027 state and admin must cleanup those resources."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-bug: #2145137"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"04626fb7_654c1149","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":7},"updated":"2026-03-27 13:37:34.000000000","message":"typo: periodic","commit_id":"665e0552cbbb129d584c5b2eb8d343766bff6897"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ad865d1e4bd0ad3c92ecc8b105b60a6043af31","unresolved":true,"context_lines":[{"line_number":24,"context_line":"network is deleted, but network along-with its share servers are still"},{"line_number":25,"context_line":"present in db. Manila then internally run periodic function to cleanup"},{"line_number":26,"context_line":"those share servers and finally related share network. Any error in"},{"line_number":27,"context_line":"peridic callback processing will move share server and share network in"},{"line_number":28,"context_line":"\u0027error_deferred_deleting\u0027 state and admin must cleanup those resources."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-bug: #2145137"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"db43ad6b_a1431f2f","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":7},"in_reply_to":"04626fb7_654c1149","updated":"2026-03-31 08:09:51.000000000","message":"ACK, Will address in next iteration.","commit_id":"665e0552cbbb129d584c5b2eb8d343766bff6897"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f3332302cff0e0d1d31e780b463ee25ad7ecd9f9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"network is deleted, but network along-with its share servers are still"},{"line_number":25,"context_line":"present in db. Manila then internally run periodic function to cleanup"},{"line_number":26,"context_line":"those share servers and finally related share network. Any error in"},{"line_number":27,"context_line":"peridic callback processing will move share server and share network in"},{"line_number":28,"context_line":"\u0027error_deferred_deleting\u0027 state and admin must cleanup those resources."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-bug: #2145137"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2e42f1cb_fa3f45b6","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":7},"in_reply_to":"db43ad6b_a1431f2f","updated":"2026-05-14 10:54:02.000000000","message":"Done","commit_id":"665e0552cbbb129d584c5b2eb8d343766bff6897"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f0f50f2bf7b35937e0695f6847575daba850812a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71c74b57_2be4cf89","updated":"2026-03-24 15:46:07.000000000","message":"Hi,\nCan you Please comment on approach (RFC) ?\n\nI will then continue to add more tests, releasenote and remaining things in PR.","commit_id":"665e0552cbbb129d584c5b2eb8d343766bff6897"}],"manila/share/manager.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"87a24950f4746a874c4c0618ce6da24b5a945b66","unresolved":true,"context_lines":[{"line_number":4002,"context_line":"            except Exception:"},{"line_number":4003,"context_line":"                LOG.exception("},{"line_number":4004,"context_line":"                    \"Deferred delete: failed to delete share server \u0027%s\u0027. \""},{"line_number":4005,"context_line":"                    \"Will retry on next periodic cycle.\", share_server_id)"},{"line_number":4006,"context_line":""},{"line_number":4007,"context_line":"    @periodic_task.periodic_task("},{"line_number":4008,"context_line":"        spacing\u003dCONF.periodic_deferred_delete_interval)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec215746_0717f88e","line":4005,"updated":"2026-03-27 13:37:34.000000000","message":"Means we could end up in infinite loop here?\nMost likely if this is not working in the first 24 hours, it will never clean up on its own and needs human intervention","commit_id":"665e0552cbbb129d584c5b2eb8d343766bff6897"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c3ad865d1e4bd0ad3c92ecc8b105b60a6043af31","unresolved":true,"context_lines":[{"line_number":4002,"context_line":"            except Exception:"},{"line_number":4003,"context_line":"                LOG.exception("},{"line_number":4004,"context_line":"                    \"Deferred delete: failed to delete share server \u0027%s\u0027. \""},{"line_number":4005,"context_line":"                    \"Will retry on next periodic cycle.\", share_server_id)"},{"line_number":4006,"context_line":""},{"line_number":4007,"context_line":"    @periodic_task.periodic_task("},{"line_number":4008,"context_line":"        spacing\u003dCONF.periodic_deferred_delete_interval)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc91aeee_52c35b50","line":4005,"in_reply_to":"ec215746_0717f88e","updated":"2026-03-31 08:09:51.000000000","message":"the share server and share network are in state of deferred_deleting as long as they are not throwing error in final stage i.e. deletion from db. In this case, if not found we are all good. But if any error then its error_deferred_deleting, which admin (human-intevention) needs to look into. Similar to share, share-network also has listing controlled to these states for admin. So far this seems less probabilistic","commit_id":"665e0552cbbb129d584c5b2eb8d343766bff6897"}]}