)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fc3a4a29d2bca33bdbda96e2d1fdf4cb0245597","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     2d465341 (Add missing unit test to cephfs driver for line 490. Updating test coverage to 80%)"},{"line_number":2,"context_line":"Author:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-03-24 09:17:05 +0000"},{"line_number":4,"context_line":"Commit:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"86823499_491846d6","line":1,"updated":"2026-03-31 21:15:26.000000000","message":"Subject line is 65 characters (\"Add missing unit test to cephfs\ndriver for lines 633-678 and 635\"), which exceeds the 50-character\nlimit. Also, \"lines 633-678 and 635\" is redundant since 635 is\nwithin 633-678.\nSuggestion: \"Add manage_existing resize test for CephFS\"","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fc3a4a29d2bca33bdbda96e2d1fdf4cb0245597","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     2d465341 (Add missing unit test to cephfs driver for line 490. Updating test coverage to 80%)"},{"line_number":2,"context_line":"Author:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-03-24 09:17:05 +0000"},{"line_number":4,"context_line":"Commit:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"cdf2a956_bdcec5c3","line":1,"updated":"2026-03-31 21:15:26.000000000","message":"The commit message has no body. A brief description of what the\ntest covers (the infinite-size-with-valid-driver-options success\npath) would help reviewers understand the intent without reading\nthe code.","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06834c7fe610206be920c7502f3e72cf2abcb11d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     2d465341 (Add missing unit test to cephfs driver for line 490. Updating test coverage to 80%)"},{"line_number":2,"context_line":"Author:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-03-24 09:17:05 +0000"},{"line_number":4,"context_line":"Commit:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5dc48268_8c14f8a6","line":1,"in_reply_to":"86823499_491846d6","updated":"2026-04-06 21:33:28.000000000","message":"Done","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06834c7fe610206be920c7502f3e72cf2abcb11d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     2d465341 (Add missing unit test to cephfs driver for line 490. Updating test coverage to 80%)"},{"line_number":2,"context_line":"Author:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2026-03-24 09:17:05 +0000"},{"line_number":4,"context_line":"Commit:     olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"14a842a5_73728e68","line":1,"in_reply_to":"cdf2a956_bdcec5c3","updated":"2026-04-06 21:33:28.000000000","message":"Done","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06834c7fe610206be920c7502f3e72cf2abcb11d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"It verifies that the share is resized correctly, metadata is"},{"line_number":12,"context_line":"updated, and export locations are returned as expected."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1989472"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Idbe8841a94e773c09d7f220117ff127cf08e3b27"},{"line_number":17,"context_line":"Signed-off-by: olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b971f5c8_89804a8b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":6},"updated":"2026-04-06 21:33:28.000000000","message":"Partial-Bug","commit_id":"649b3cb55ceffbdc4814bccb2593526273a0f420"}],"manila/tests/share/drivers/cephfs/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fc3a4a29d2bca33bdbda96e2d1fdf4cb0245597","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7d78e16_7f80b372","updated":"2026-03-31 21:15:26.000000000","message":"All other test_manage_existing* tests use the\n_setup_manage_subvolume_test() helper to set up the share,\nargdict, and subvolume_info consistently. This test manually\nconstructs its own share dict and sets driver attributes\ndirectly, which is inconsistent and fragile. Please refactor\nto use the shared helper, overriding bytes_quota to \"infinite\"\nafterward (exactly as test_manage_existing_subvolume_infinite_*\ntests do).","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fc3a4a29d2bca33bdbda96e2d1fdf4cb0245597","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83734b89_13b5a250","updated":"2026-03-31 21:15:26.000000000","message":"Consider naming the test\ntest_manage_existing_subvolume_infinite_size_success to mirror\nthe existing test_manage_existing_subvolume_infinite_size (which\ntests the failure paths) and\ntest_manage_existing_subvolume_infinite_no_provided_size.","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fc3a4a29d2bca33bdbda96e2d1fdf4cb0245597","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0025c57b_a1e2c56e","updated":"2026-03-31 21:15:26.000000000","message":"The test is missing assertions that the other manage_existing\ntests include. In particular, it should assert that:\n- driver.rados_command was called with the expected arguments\n- self._driver.private_storage.update was called with the\n  expected share metadata\n- self._driver._get_export_locations was called with the\n  expected arguments\n- The full return dict matches (including export_locations),\n  not just result[\"size\"]\nSee test_manage_existing() at line 444 for the pattern to\nfollow.","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5fc3a4a29d2bca33bdbda96e2d1fdf4cb0245597","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23e15722_16c87c0c","updated":"2026-03-31 21:15:26.000000000","message":"The test uses mock.patch.object as a context manager, but the\nestablished pattern in this file (42 occurrences) is\nself.mock_object(). Please use self.mock_object() for\nconsistency. For example:\n  mock_resize \u003d self.mock_object(\n      self._driver, \u0027_resize_share\u0027)\n  self.mock_object(\n      self._driver, \u0027_get_export_locations\u0027,\n      mock.Mock(return_value\u003dsubvolume_name))","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06834c7fe610206be920c7502f3e72cf2abcb11d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c894132_6de82e2d","in_reply_to":"0025c57b_a1e2c56e","updated":"2026-04-06 21:33:28.000000000","message":"Done","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06834c7fe610206be920c7502f3e72cf2abcb11d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c49d7350_50bb8fe7","in_reply_to":"23e15722_16c87c0c","updated":"2026-04-06 21:33:28.000000000","message":"Done","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06834c7fe610206be920c7502f3e72cf2abcb11d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34089973_e07296eb","in_reply_to":"83734b89_13b5a250","updated":"2026-04-06 21:33:28.000000000","message":"Done","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06834c7fe610206be920c7502f3e72cf2abcb11d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c29f7416_442165dc","in_reply_to":"f7d78e16_7f80b372","updated":"2026-04-06 21:33:28.000000000","message":"Done","commit_id":"47f53cf4f7def5d34e15d4fd57d9858a4cc263c1"}]}